Re: [Xen-devel] [PATCH 39/52] xen: check parameter validity when parsing command line

2017-08-10 Thread Wei Liu
On Thu, Aug 10, 2017 at 03:24:05PM +0200, Juergen Gross wrote: > On 10/08/17 15:02, Wei Liu wrote: > > On Wed, Aug 09, 2017 at 09:06:53AM +0200, Juergen Gross wrote: > >> Where possible check validity of parameters in _cmdline_parse() and > >> issue a warning message in case of an error detected.

Re: [Xen-devel] [PATCH 39/52] xen: check parameter validity when parsing command line

2017-08-10 Thread Juergen Gross
On 10/08/17 15:32, Jan Beulich wrote: On 10.08.17 at 15:24, wrote: >> @@ -176,7 +200,8 @@ int __init parse_bool(const char *s) >> !strcmp("on", s) || >> !strcmp("true", s) || >> !strcmp("enable", s) || >> - !strcmp("1", s) ) >> +

Re: [Xen-devel] [PATCH 39/52] xen: check parameter validity when parsing command line

2017-08-10 Thread Jan Beulich
>>> On 10.08.17 at 15:24, wrote: > @@ -176,7 +200,8 @@ int __init parse_bool(const char *s) > !strcmp("on", s) || > !strcmp("true", s) || > !strcmp("enable", s) || > - !strcmp("1", s) ) > + !strcmp("1", s) || > + !strcmp("",

Re: [Xen-devel] [PATCH 39/52] xen: check parameter validity when parsing command line

2017-08-10 Thread Juergen Gross
On 10/08/17 15:02, Wei Liu wrote: > On Wed, Aug 09, 2017 at 09:06:53AM +0200, Juergen Gross wrote: >> Where possible check validity of parameters in _cmdline_parse() and >> issue a warning message in case of an error detected. >> >> Cc: Andrew Cooper >> Cc: George

Re: [Xen-devel] [PATCH 39/52] xen: check parameter validity when parsing command line

2017-08-10 Thread Wei Liu
On Wed, Aug 09, 2017 at 09:06:53AM +0200, Juergen Gross wrote: > Where possible check validity of parameters in _cmdline_parse() and > issue a warning message in case of an error detected. > > Cc: Andrew Cooper > Cc: George Dunlap > Cc: