Re: [Xen-devel] [OSSTEST PATCH 3/3] make-flight: Provide Windows 10 and Windows Server 16 guests with 3.5G of RAM

2017-06-19 Thread Paul Durrant
> -Original Message- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: 16 June 2017 18:34 > To: xen-de...@lists.xenproject.org > Cc: Ian Jackson ; Ian Jackson > ; Paul Durrant ; Wei Liu > ; Dario Faggioli > Subject: [OSSTEST PATCH 3/3] make-flight: Provide Windows 10 and > Win

Re: [Xen-devel] [OSSTEST PATCH 1/3] ts-windows-install: Honour memsize and disksize guest runvars

2017-06-19 Thread Paul Durrant
> -Original Message- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: 16 June 2017 18:34 > To: xen-de...@lists.xenproject.org > Cc: Ian Jackson ; Ian Jackson > ; Wei Liu ; Paul Durrant > > Subject: [OSSTEST PATCH 1/3] ts-windows-install: Honour memsize and > disksize guest ru

Re: [Xen-devel] [OSSTEST PATCH] ts-windows-install: Provide guest with 32G of disk rather than 10G

2017-06-19 Thread Paul Durrant
> -Original Message- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: 16 June 2017 16:57 > To: xen-de...@lists.xenproject.org > Cc: Ian Jackson ; Ian Jackson > ; Paul Durrant > Subject: [OSSTEST PATCH] ts-windows-install: Provide guest with 32G of disk > rather than 10G > >

Re: [Xen-devel] [PATCH] VT-d: fix VF of RC integrated endpoint matched to wrong VT-d unit

2017-06-19 Thread Jan Beulich
>>> On 19.06.17 at 08:33, wrote: > On Fri, Jun 16, 2017 at 09:52:11AM -0600, Jan Beulich wrote: > On 16.06.17 at 08:48, wrote: >>> The problem is a VF of RC integrated PF (e.g. PF's BDF is 00:02.0), >>> we would wrongly use 00:00.0 to search VT-d unit. >>> >>> To search VT-d unit for a VF, t

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Jan Beulich
>>> On 18.06.17 at 21:19, wrote: > On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper > wrote: >> On 04/04/17 14:14, Jan Beulich wrote: >>> We shouldn't hand MFN info back from increase-reservation for >>> translated domains, just like we don't for populate-physmap and >>> memory-exchange. For full s

Re: [Xen-devel] [PATCH] VT-d: fix VF of RC integrated endpoint matched to wrong VT-d unit

2017-06-19 Thread Chao Gao
On Mon, Jun 19, 2017 at 01:43:25AM -0600, Jan Beulich wrote: On 19.06.17 at 08:33, wrote: >> On Fri, Jun 16, 2017 at 09:52:11AM -0600, Jan Beulich wrote: >> On 16.06.17 at 08:48, wrote: The problem is a VF of RC integrated PF (e.g. PF's BDF is 00:02.0), we would wrongly use 00:

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Julien Grall
Hi, On 19/06/17 09:15, Jan Beulich wrote: On 18.06.17 at 21:19, wrote: On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper wrote: On 04/04/17 14:14, Jan Beulich wrote: We shouldn't hand MFN info back from increase-reservation for translated domains, just like we don't for populate-physmap and mem

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread George Dunlap
On 19/06/17 09:15, Jan Beulich wrote: On 18.06.17 at 21:19, wrote: >> On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper >> wrote: >>> On 04/04/17 14:14, Jan Beulich wrote: We shouldn't hand MFN info back from increase-reservation for translated domains, just like we don't for populate

Re: [Xen-devel] [PATCH 02/14 v4] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h

2017-06-19 Thread Andre Przywara
Hi Bhupinder, I think the commit message is a bit misleading. Actually you *rename* functions and their call sites, and also this touches the VGIC code, so shouldn't it mention both in the first line of the commit message? After all this patch really has not much to do with vpl011. On 06/06/17 18

Re: [Xen-devel] Notes on stubdoms and latency on ARM

2017-06-19 Thread George Dunlap
On 17/06/17 01:14, Volodymyr Babchuk wrote: > Hello George, > > On 31 May 2017 at 20:02, George Dunlap wrote: There is no way out: if the stubdom needs events, then we'll have to expose and context switch the vGIC. If it doesn't, then we can skip the vGIC. However, we would have a

Re: [Xen-devel] [linux-4.9 test] 110535: regressions - FAIL

2017-06-19 Thread Ian Jackson
osstest service owner writes ("[linux-4.9 test] 110535: regressions - FAIL"): > flight 110535 linux-4.9 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/110535/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-am

[Xen-devel] Hugepage support for Dom0

2017-06-19 Thread Manish Jaggi
Hi, Does Xen arm64 support hugepages for Dom0 ? If yes how to enable it. Found wiki page on it : https://wiki.xenproject.org/wiki/Huge_Page_Support but is not updated. Thanks -Manish ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.

Re: [Xen-devel] [PATCH v2] x86/boot: Fix the boot time relocation calculations

2017-06-19 Thread Julien Grall
On 14/06/17 11:33, Julien Grall wrote: Hi Andrew, On 06/12/2017 11:45 AM, Andrew Cooper wrote: c/s b28044226e1 "x86: make Xen early boot code relocatable" introduces mov $sym_offs(__image_base__),%esi to the legacy boot path. However, this is by definition 0, which means the boot code

Re: [Xen-devel] [linux-4.9 test] 110371: regressions - FAIL

2017-06-19 Thread Julien Grall
On 13/06/17 13:13, Ian Jackson wrote: Dario Faggioli writes ("Re: [Xen-devel] [linux-4.9 test] 110371: regressions - FAIL"): So, this appears to be something related to linux-4.9 and that particular board, I guess? Yes, indeed. This has been broken for some time. (If this was known and b

[Xen-devel] [distros-debian-sid test] 71584: trouble: blocked/broken

2017-06-19 Thread Platform Team regression test user
flight 71584 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71584/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvops 3 host-install(3) broken REGR.

Re: [Xen-devel] [PATCH v12 01/34] ARM: vGIC: avoid rank lock when reading priority

2017-06-19 Thread Julien Grall
Hi, On 14/06/17 18:55, Julien Grall wrote: Hi Andre, On 06/14/2017 05:51 PM, Andre Przywara wrote: When reading the priority value of a virtual interrupt, we were taking the respective rank lock so far. However for forwarded interrupts (Dom0 only so far) this may lead to a deadlock with the fo

Re: [Xen-devel] [PATCH 2/2] xen/input: add multi-touch support

2017-06-19 Thread Oleksandr Andrushchenko
Ping On 06/08/2017 09:45 AM, Oleksandr Andrushchenko wrote: Hi, Dmitry! On 06/07/2017 07:56 PM, Dmitry Torokhov wrote: On Wed, May 31, 2017 at 12:06:56PM +0300, Oleksandr Andrushchenko wrote: Hi, Dmitry! On 05/30/2017 07:37 PM, Dmitry Torokhov wrote: On Tue, May 30, 2017 at 03:50:20PM +0300,

[Xen-devel] [xen-4.9-testing test] 110550: tolerable trouble: broken/fail/pass - PUSHED

2017-06-19 Thread osstest service owner
flight 110550 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/110550/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 3 host-install(3) broken pass in 110542 test-amd64-i386-xl-qemut-win7

Re: [Xen-devel] [PATCH 03/14 v4] xen/arm: vpl011: Add pl011 uart emulation in Xen

2017-06-19 Thread Andre Przywara
Hi, On 06/06/17 18:25, Bhupinder Thakur wrote: > Add emulation code to emulate read/write access to pl011 registers > and pl011 interrupts: > > - Emulate DR read/write by reading and writing from/to the IN > and OUT ring buffers and raising an event to the backend when > there is

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Jan Beulich
>>> On 19.06.17 at 11:11, wrote: > On 19/06/17 09:15, Jan Beulich wrote: > On 18.06.17 at 21:19, wrote: >>> On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper >>> wrote: On 04/04/17 14:14, Jan Beulich wrote: > We shouldn't hand MFN info back from increase-reservation for > translate

[Xen-devel] blkback shutdown problem ? (Re: [linux-4.9 test] 110513: regressions - FAIL)

2017-06-19 Thread Ian Jackson
osstest service owner writes ("[linux-4.9 test] 110513: regressions - FAIL"): > flight 110513 linux-4.9 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/110513/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-am

Re: [Xen-devel] [PATCH 06/14 v4] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-06-19 Thread Bhupinder Thakur
Hi Julien, I was mistaken in my earlier mail about vpl011 init working if it is moved to libxl__arch_domain_create(). It is failing because as you have mentioned vuart_pfn is allocated later in xc_dom_build_image(). Can we delay mapping of this page in Xen until the ring buffer is actually requir

Re: [Xen-devel] [OSSTEST PATCH v11 00/20] Have OpenStack tested on top of xen's master and libvirt's master.

2017-06-19 Thread Anthony PERARD
On Fri, Jun 16, 2017 at 06:56:44PM +0100, Anthony PERARD wrote: > Changes in V11: > - plenty of new patches, on top of the original 3 patches that were acked. > - and an attempt at creating a flight for a stable branch of openstack. But > there is many git tree to pull the branch from. And here

Re: [Xen-devel] [PATCH 06/14 v4] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-06-19 Thread Julien Grall
On 19/06/17 11:59, Bhupinder Thakur wrote: Hi Julien, I was mistaken in my earlier mail about vpl011 init working if it is moved to libxl__arch_domain_create(). It is failing because as you have mentioned vuart_pfn is allocated later in xc_dom_build_image(). Can we delay mapping of this page

Re: [Xen-devel] [PATCH] libxc: add xc_domain_add_to_physmap_batch to wrap XENMEM_add_to_physmap_batch

2017-06-19 Thread Wei Liu
On Fri, Jun 16, 2017 at 05:36:18PM +0800, Zhongze Liu wrote: > Hi Jan, > > > 2017-06-16 16:45 GMT+08:00 Jan Beulich : > On 16.06.17 at 06:55, wrote: > >> currently there is no wrapper for XENMEM_add_to_physmap_batch in libxc. > >> add a wrapper to do that. > > > > It may help acceptance if

Re: [Xen-devel] [RFC PATCH v3 07/10] arm/mem_access: Add software guest-page-table walk

2017-06-19 Thread Julien Grall
On 15/06/17 12:05, Sergej Proskurin wrote: The function p2m_mem_access_check_and_get_page in mem_access.c translates a gva to an ipa by means of the hardware functionality of the ARM architecture. This is implemented in the function gva_to_ipa. If mem_access is active, hardware-based gva to ipa

Re: [Xen-devel] Operf and Opreport outputs

2017-06-19 Thread dhara buch
Hello, Thanks a lot for the detailed explanation. I could understand the working of operf and opreport. Unlike operf, ocount counts each occurrence of the monitored event. In such a case, why ocount also gives varying values of CPU_CLK_UNHALTED even when the monitored code doesn't get changed. Is

Re: [Xen-devel] blkback shutdown problem ? (Re: [linux-4.9 test] 110513: regressions - FAIL)

2017-06-19 Thread Roger Pau Monné
On Mon, Jun 19, 2017 at 11:55:14AM +0100, Ian Jackson wrote: > osstest service owner writes ("[linux-4.9 test] 110513: regressions - FAIL"): > > flight 110513 linux-4.9 real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/110513/ > > > > Regressions :-( > > > > Tests which did not suc

Re: [Xen-devel] [PATCH] ipxe: update to newer commit

2017-06-19 Thread Wei Liu
On Mon, Jun 12, 2017 at 04:04:17PM +0100, Wei Liu wrote: > To get 5f85cbb9ee1c00cec81a848a9e871ad5d1e7f53f to placate gcc 7. > > The only patch we have applies cleanly. > > Reported-by: Zhongze Liu > Signed-off-by: Wei Liu Ping? ___ Xen-devel mailin

Re: [Xen-devel] [PATCH v3] tools: fix several "format-truncation" warnings with GCC 7

2017-06-19 Thread Wei Liu
On Wed, Jun 14, 2017 at 09:11:48AM +0800, Zhongze Liu wrote: > GCC 7.1.1 complains that several buffers passed to snprintf() in xenpmd > and tools/ocmal/xc are too small to hold the largest possible resulting > string, > which is calculated by adding up the maximum length of all the substrings. >

Re: [Xen-devel] [PATCH 06/14 v4] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-06-19 Thread Wei Liu
On Mon, Jun 19, 2017 at 12:01:32PM +0100, Julien Grall wrote: > > > On 19/06/17 11:59, Bhupinder Thakur wrote: > > Hi Julien, > > > > I was mistaken in my earlier mail about vpl011 init working if it is > > moved to libxl__arch_domain_create(). It is failing because as you > > have mentioned vua

[Xen-devel] [PATCH v4 2/2] xen-access: write_ctrlreg_c4 test

2017-06-19 Thread Petre Pircalabu
Add test for write_ctrlreg event handling. Signed-off-by: Petre Pircalabu --- tools/tests/xen-access/xen-access.c | 53 - 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c i

[Xen-devel] [PATCH v4 1/2] x86/monitor: add masking support for write_ctrlreg events

2017-06-19 Thread Petre Pircalabu
Add support for filtering out the write_ctrlreg monitor events if they are generated only by changing certains bits. A new parameter (bitmask) was added to the xc_monitor_write_ctrlreg function in order to mask the event generation if the changed bits are set. Signed-off-by: Petre Pircalabu Acked

[Xen-devel] [PATCH v4 0/2] write_ctrlreg event masking

2017-06-19 Thread Petre Pircalabu
This patchset enables masking the reception of write_ctrlreg events depending on the value of certain bits in that register. The most representative example is filtering out events when the CR4.PGE bit is being flipped (global TLB flushes) --- Changed since v2 * fix coding style * use ARRAY_S

Re: [Xen-devel] [RFC PATCH v3 08/10] arm/mem_access: Add long-descriptor based gpt

2017-06-19 Thread Julien Grall
Hi Sergej, On 15/06/17 12:05, Sergej Proskurin wrote: This commit adds functionality to walk the guest's page tables using the long-descriptor translation table format for both ARMv7 and ARMv8. Similar to the hardware architecture, the implementation supports different page granularities (4K, 16

Re: [Xen-devel] Implementation of single-stepping for Xen on ARMv7

2017-06-19 Thread Florian Jakobsmeier
Hello Julien, thank you for your answer and sorry for the delay. 2017-06-14 14:26 GMT+02:00 Julien Grall : > > > On 06/12/2017 10:34 AM, Florian Jakobsmeier wrote: > >> Dear all, >> > > Hello Florian, > > > I don't have much experience with the debug registers, I have CCed some > folks who may

Re: [Xen-devel] [PATCH for-4.9 0/4] Makefiles: Provide way to ship livepatch tests

2017-06-19 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [PATCH for-4.9 0/4] Makefiles: Provide way to ship livepatch tests"): > I don't see the patches in staging. Do you still plan to have those > patches in Xen 4.9? As you'll have seen, they went to staging last week and are now in xen.git#master. I have just

Re: [Xen-devel] [PATCH] ipxe: update to newer commit

2017-06-19 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] ipxe: update to newer commit"): > On Mon, Jun 12, 2017 at 04:04:17PM +0100, Wei Liu wrote: > > To get 5f85cbb9ee1c00cec81a848a9e871ad5d1e7f53f to placate gcc 7. > > > > The only patch we have applies cleanly. > > > > Reported-by: Zhongze Liu > > Signed-off-by: Wei Li

Re: [Xen-devel] [linux-4.9 test] 110371: regressions - FAIL

2017-06-19 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [linux-4.9 test] 110371: regressions - FAIL"): > There are now in Linux 4.9 stable branch. Now the testing is blocked > because of again local migration [1]. The migration test seem less > reliable than the Arndale these days... is there anything we can do?

Re: [Xen-devel] [PATCH for-4.9 0/4] Makefiles: Provide way to ship livepatch tests

2017-06-19 Thread Andrew Cooper
On 19/06/17 13:59, Ian Jackson wrote: > Julien Grall writes ("Re: [Xen-devel] [PATCH for-4.9 0/4] Makefiles: Provide > way to ship livepatch tests"): >> I don't see the patches in staging. Do you still plan to have those >> patches in Xen 4.9? > As you'll have seen, they went to staging last week

Re: [Xen-devel] [PATCH 06/14 v4] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-06-19 Thread Bhupinder Thakur
Hi Wei, On 19 June 2017 at 17:17, Wei Liu wrote: > On Mon, Jun 19, 2017 at 12:01:32PM +0100, Julien Grall wrote: >> >> >> On 19/06/17 11:59, Bhupinder Thakur wrote: >> > Hi Julien, >> > >> > I was mistaken in my earlier mail about vpl011 init working if it is >> > moved to libxl__arch_domain_crea

Re: [Xen-devel] blkback shutdown problem ? (Re: [linux-4.9 test] 110513: regressions - FAIL)

2017-06-19 Thread Konrad Rzeszutek Wilk
On Mon, Jun 19, 2017 at 12:27:33PM +0100, Roger Pau Monné wrote: > On Mon, Jun 19, 2017 at 11:55:14AM +0100, Ian Jackson wrote: > > osstest service owner writes ("[linux-4.9 test] 110513: regressions - > > FAIL"): > > > flight 110513 linux-4.9 real [real] > > > http://logs.test-lab.xenproject.org/

Re: [Xen-devel] [dpdk-dev] [PATCH] maintainers: claim responsability for xen

2017-06-19 Thread Thomas Monjalon
Thanks Jianfeng for giving new ideas. There is not much activity on Xen side. Is there someone working on DPDK+Xen? Any news? The technical board requested to re-consider Xen support in DPDK. It will be discussed in the next techboard meeting: https://annuel.framapad.org/p/r.0c3cc4d1e0112

Re: [Xen-devel] [PATCH 01/20] rbtree: add const qualifier to some functions

2017-06-19 Thread Jan Beulich
>>> On 17.06.17 at 11:32, wrote: > The 'rb_first()', 'rb_last()', 'rb_next()' and 'rb_prev()' calls > take a pointer to an RB node or RB root. They do not change the > pointed objects, so add a 'const' qualifier in order to make life > of the users of these functions easier. > > Indeed, if I have

[Xen-devel] [linux-linus bisection] complete build-i386-pvops

2017-06-19 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-pvops testid kernel-build Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git *** Found and reproduced problem changeset *** Bug is in tre

Re: [Xen-devel] [PATCH 01/20] rbtree: add const qualifier to some functions

2017-06-19 Thread Praveen Kumar
Hi Jan, On Mon, Jun 19, 2017 at 7:19 PM, Jan Beulich wrote: On 17.06.17 at 11:32, wrote: >> The 'rb_first()', 'rb_last()', 'rb_next()' and 'rb_prev()' calls >> take a pointer to an RB node or RB root. They do not change the >> pointed objects, so add a 'const' qualifier in order to make lif

[Xen-devel] [PATCH for-4.9] xen/test/Makefile: Fix clean target, broken by pattern rule

2017-06-19 Thread Ian Jackson
In "xen/test/livepatch: Regularise Makefiles" we reworked xen/test/Makefile to use a pattern rule. However, there are two problems with this. Both are related to the way that xen/Rules.mk is implicitly part of this Makefile because of the way that Makefiles under xen/ are invoked by their parent

[Xen-devel] [xen-unstable test] 110556: regressions - FAIL

2017-06-19 Thread osstest service owner
flight 110556 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/110556/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-xsm 5 xen-build fail in 110510 REGR. vs. 110465 Tests which are fa

[Xen-devel] [xen-unstable-smoke test] 110567: tolerable trouble: broken/pass - PUSHED

2017-06-19 Thread osstest service owner
flight 110567 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/110567/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12 mig

Re: [Xen-devel] blkback shutdown problem ? (Re: [linux-4.9 test] 110513: regressions - FAIL)

2017-06-19 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("Re: blkback shutdown problem ? (Re: [linux-4.9 test] 110513: regressions - FAIL)"): > On Mon, Jun 19, 2017 at 12:27:33PM +0100, Roger Pau Monné wrote: > > This has already been noticed and fixed by Juergen [0], however AFAIK > > the patches are not yet in Jens/Linus

[Xen-devel] ufs build failure (no __udivdi3) on i386 in linux tip (edf9364d3f92)

2017-06-19 Thread Ian Jackson
osstest service owner writes ("[linux-linus bisection] complete build-i386-pvops"): > branch xen-unstable > xenbranch xen-unstable > job build-i386-pvops > testid kernel-build > > Tree: linux > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git > Tree: linuxfirmware git://xenbi

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Tamas K Lengyel
On Mon, Jun 19, 2017 at 3:09 AM, Julien Grall wrote: > Hi, > > > On 19/06/17 09:15, Jan Beulich wrote: > > On 18.06.17 at 21:19, wrote: >>> >>> On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper >>> wrote: On 04/04/17 14:14, Jan Beulich wrote: > > We shouldn't hand MFN info

Re: [Xen-devel] [PATCH 01/20] rbtree: add const qualifier to some functions

2017-06-19 Thread Jan Beulich
>>> On 19.06.17 at 16:09, wrote: > On Mon, Jun 19, 2017 at 7:19 PM, Jan Beulich wrote: > On 17.06.17 at 11:32, wrote: >>> The 'rb_first()', 'rb_last()', 'rb_next()' and 'rb_prev()' calls >>> take a pointer to an RB node or RB root. They do not change the >>> pointed objects, so add a 'const'

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Tamas K Lengyel
On Mon, Jun 19, 2017 at 3:11 AM, George Dunlap wrote: > On 19/06/17 09:15, Jan Beulich wrote: > On 18.06.17 at 21:19, wrote: >>> On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper >>> wrote: On 04/04/17 14:14, Jan Beulich wrote: > We shouldn't hand MFN info back from increase-reservation

Re: [Xen-devel] [PATCH v4 2/2] xen-access: write_ctrlreg_c4 test

2017-06-19 Thread Tamas K Lengyel
On Mon, Jun 19, 2017 at 6:24 AM, Petre Pircalabu wrote: > Add test for write_ctrlreg event handling. > > Signed-off-by: Petre Pircalabu Acked-by: Tamas K Lengyel > --- > tools/tests/xen-access/xen-access.c | 53 > - > 1 file changed, 52 insertions(+), 1 de

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Julien Grall
On 19/06/17 15:39, Tamas K Lengyel wrote: On Mon, Jun 19, 2017 at 3:09 AM, Julien Grall wrote: Hi, On 19/06/17 09:15, Jan Beulich wrote: On 18.06.17 at 21:19, wrote: On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper wrote: On 04/04/17 14:14, Jan Beulich wrote: We shouldn't hand MFN in

Re: [Xen-devel] blkback shutdown problem ? (Re: [linux-4.9 test] 110513: regressions - FAIL)

2017-06-19 Thread Konrad Rzeszutek Wilk
On Mon, Jun 19, 2017 at 03:27:01PM +0100, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("Re: blkback shutdown problem ? (Re: [linux-4.9 > test] 110513: regressions - FAIL)"): > > On Mon, Jun 19, 2017 at 12:27:33PM +0100, Roger Pau Monné wrote: > > > This has already been noticed and fixed by

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread George Dunlap
On 19/06/17 15:48, Tamas K Lengyel wrote: > On Mon, Jun 19, 2017 at 3:11 AM, George Dunlap > wrote: >> On 19/06/17 09:15, Jan Beulich wrote: >> On 18.06.17 at 21:19, wrote: On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper wrote: > On 04/04/17 14:14, Jan Beulich wrote: >> We s

Re: [Xen-devel] [PATCH for-4.9] xen/test/Makefile: Fix clean target, broken by pattern rule

2017-06-19 Thread Konrad Rzeszutek Wilk
On Mon, Jun 19, 2017 at 03:23:26PM +0100, Ian Jackson wrote: > In "xen/test/livepatch: Regularise Makefiles" we reworked > xen/test/Makefile to use a pattern rule. However, there are two > problems with this. Both are related to the way that xen/Rules.mk is > implicitly part of this Makefile beca

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Tamas K Lengyel
On Mon, Jun 19, 2017 at 8:54 AM, George Dunlap wrote: > On 19/06/17 15:48, Tamas K Lengyel wrote: >> On Mon, Jun 19, 2017 at 3:11 AM, George Dunlap >> wrote: >>> On 19/06/17 09:15, Jan Beulich wrote: >>> On 18.06.17 at 21:19, wrote: > On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper >

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Tamas K Lengyel
On Mon, Jun 19, 2017 at 8:52 AM, Julien Grall wrote: > > > On 19/06/17 15:39, Tamas K Lengyel wrote: >> >> On Mon, Jun 19, 2017 at 3:09 AM, Julien Grall >> wrote: >>> >>> Hi, >>> >>> >>> On 19/06/17 09:15, Jan Beulich wrote: >>> >>> >>> On 18.06.17 at 21:19, wrote: > > >

Re: [Xen-devel] ufs build failure (no __udivdi3) on i386 in linux tip (edf9364d3f92)

2017-06-19 Thread Al Viro
On Mon, Jun 19, 2017 at 03:36:47PM +0100, Ian Jackson wrote: > osstest service owner writes ("[linux-linus bisection] complete > build-i386-pvops"): > > branch xen-unstable > > xenbranch xen-unstable > > job build-i386-pvops > > testid kernel-build > > > > Tree: linux > > git://git.kernel.org/pu

Re: [Xen-devel] [PATCH 06/44] iommu/dma: don't rely on DMA_ERROR_CODE

2017-06-19 Thread Robin Murphy
On 16/06/17 19:10, Christoph Hellwig wrote: > DMA_ERROR_CODE is not a public API and will go away soon. dma dma-iommu > driver already implements a proper ->mapping_error method, so it's only > using the value internally. Add a new local define using the value > that arm64 which is the only curre

[Xen-devel] [linux-4.9 test] 110557: regressions - FAIL

2017-06-19 Thread osstest service owner
flight 110557 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/110557/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-localmigrate/x10 fail REGR. vs. 110456 Tests which ar

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Julien Grall
On 19/06/17 15:57, Tamas K Lengyel wrote: On Mon, Jun 19, 2017 at 8:52 AM, Julien Grall wrote: On 19/06/17 15:39, Tamas K Lengyel wrote: On Mon, Jun 19, 2017 at 3:09 AM, Julien Grall wrote: Hi, On 19/06/17 09:15, Jan Beulich wrote: On 18.06.17 at 21:19, wrote: On Tue, Apr 4, 2

Re: [Xen-devel] [RFC PATCH v3 08/10] arm/mem_access: Add long-descriptor based gpt

2017-06-19 Thread Sergej Proskurin
Hi Julien, [...] On 06/19/2017 02:45 PM, Julien Grall wrote: > Hi Sergej, > >> +/* Normalized page granule size indices. */ >> +#define GRANULE_SIZE_INDEX_4K (0) >> +#define GRANULE_SIZE_INDEX_16K (1) >> +#define GRANULE_SIZE_INDEX_64K (2) > > Why this is e

Re: [Xen-devel] [RFC PATCH v3 08/10] arm/mem_access: Add long-descriptor based gpt

2017-06-19 Thread Julien Grall
On 19/06/17 16:43, Sergej Proskurin wrote: Hi Julien, [...] On 06/19/2017 02:45 PM, Julien Grall wrote: Hi Sergej, +/* Normalized page granule size indices. */ +#define GRANULE_SIZE_INDEX_4K (0) +#define GRANULE_SIZE_INDEX_16K (1) +#define GRANULE_SIZE_INDEX_64K

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Tamas K Lengyel
On Mon, Jun 19, 2017 at 9:34 AM, Julien Grall wrote: > > > On 19/06/17 15:57, Tamas K Lengyel wrote: >> >> On Mon, Jun 19, 2017 at 8:52 AM, Julien Grall >> wrote: >>> >>> >>> >>> On 19/06/17 15:39, Tamas K Lengyel wrote: On Mon, Jun 19, 2017 at 3:09 AM, Julien Grall wrote: >>

Re: [Xen-devel] [PATCH 01/20] rbtree: add const qualifier to some functions

2017-06-19 Thread Dario Faggioli
On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > The 'rb_first()', 'rb_last()', 'rb_next()' and 'rb_prev()' calls > take a pointer to an RB node or RB root. They do not change the > pointed objects, so add a 'const' qualifier in order to make life > of the users of these functions easier.

Re: [Xen-devel] [PATCH 02/20] lib/rbtree.c: optimize rb_erase()

2017-06-19 Thread Dario Faggioli
On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > Tfour 4 redundant if-conditions in function __rb_erase_color() in > lib/rbtree.c are removed. > > In pseudo-source-code, the structure of the code is as follows: > > if ((!A || B) && (!C || D)) { > . > . > . > } else { > if (

Re: [Xen-devel] [PATCH v4.1 3/4] x86/pt: enable binding of GSIs to a PVH Dom0

2017-06-19 Thread Roger Pau Monne
On Wed, Jun 07, 2017 at 07:17:16AM -0600, Jan Beulich wrote: > >>> On 02.06.17 at 15:58, wrote: > > --- a/xen/drivers/passthrough/io.c > > +++ b/xen/drivers/passthrough/io.c > > @@ -164,6 +164,25 @@ static void pt_irq_time_out(void *data) > > > > spin_lock(&irq_map->dom->event_lock); > >

Re: [Xen-devel] [PATCH v2 03/20] rb_tree: reorganize code in rb_erase() for additional changes

2017-06-19 Thread Dario Faggioli
On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > First, move some code around in order to make the next change more > obvious. > > [a...@linux-foundation.org: coding-style fixes] > Signed-off-by: Peter Zijlstra > Signed-off-by: Wolfram Strepp > Signed-off-by: Andrew Morton > Signed-off

Re: [Xen-devel] [PATCH v2 04/20] rb_tree: make clear distinction between two different cases in rb_erase()

2017-06-19 Thread Dario Faggioli
On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > There are two cases when a node, having 2 childs, is erased: > 'normal case': the successor is not the right-hand-child of the node > to be > erased > 'special case': the successor is the right-hand child of the node to > be erased > > Here

Re: [Xen-devel] [PATCH v2 05/20] rb_tree: remove redundant if()-condition in rb_erase()

2017-06-19 Thread Dario Faggioli
On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > Furthermore, notice that the initial checks: > > if (!node->rb_left) > child = node->rb_right; > else if (!node->rb_right) > child = node->rb_left; > else >    

Re: [Xen-devel] [PATCH 02/14 v4] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h

2017-06-19 Thread Bhupinder Thakur
Hi Andre, On 19 June 2017 at 15:03, Andre Przywara wrote: > Hi Bhupinder, > > I think the commit message is a bit misleading. > Actually you *rename* functions and their call sites, and also this > touches the VGIC code, so shouldn't it mention both in the first line of > the commit message? Afte

[Xen-devel] [PATCH v2 12/16] xen/arm: p2m: Rename p2m_valid, p2m_table, p2m_mapping and p2m_is_superpage

2017-06-19 Thread Julien Grall
The helpers p2m_valid, p2m_table, p2m_mapping and p2m_is_superpage are not specific to the stage-2 translation tables. They can also work on any LPAE translation tables. So rename then to lpae_* and use pte.walk to look for the value of the field. Signed-off-by: Julien Grall --- Cc: prosku...@se

[Xen-devel] [PATCH v2 04/16] xen/arm: p2m: Redefine mfn_to_page and page_to_mfn to use typesafe

2017-06-19 Thread Julien Grall
The file xen/arch/arm/p2m.c is using typesafe MFN in most of the place. This requires caller to mfn_to_page and page_to_mfn to use _mfn/mfn_x. To avoid extra _mfn/mfn_x, re-define mfn_to_page and page_to_mfn within xen/arch/arm/p2m.c to handle typesafe MFN. Signed-off-by: Julien Grall --- Th

[Xen-devel] [PATCH v2 02/16] xen/arm: setup: Remove bogus xenheap_mfn_end in setup_mm for arm64

2017-06-19 Thread Julien Grall
xenheap_mfn_end is storing an MFN and not a physical address. Xen is not currently using xenheap_mfn_end and the value will be reset after the loop. So drop this bogus xenheap_mfn_end. Signed-off-by: Julien Grall --- Changes in v2: - Update commit message --- xen/arch/arm/setup.c | 2

[Xen-devel] [PATCH v2 11/16] xen/arm: lpae: Fix comments coding style

2017-06-19 Thread Julien Grall
Also adding one missing full stop + fix description Signed-off-by: Julien Grall --- Cc: prosku...@sec.in.tum.de I haven't retained Stefano's reviewed-by because of the description update. Changes in v2: - Fix description regarding x86 page-table --- xen/include/asm-arm/lpae

[Xen-devel] [PATCH v2 10/16] xen/arm: Move LPAE definition in a separate header

2017-06-19 Thread Julien Grall
page.h is getting bigger. Move out every LPAE definitions in a separate header. There is no functional changes. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Cc: prosku...@sec.in.tum.de Changes in v2: - Move comment after the #endif rather than before - A

[Xen-devel] [PATCH v2 07/16] xen/arm: alternative: Redefine virt_to_mfn to support typesafe

2017-06-19 Thread Julien Grall
The file xen/arch/arm/alternative.c is using typesafe MFN in most of the place. The only caller to virt_to_mfn is using with _mfn(...). To avoid extra _mfn(...), re-define virt_to_mfn within xen/arch/arm/alternative.c to handle typesafe MFN. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabe

[Xen-devel] [PATCH v2 05/16] xen/arm: mm: Redefine virt_to_mfn to support typesafe

2017-06-19 Thread Julien Grall
The file xen/arch/arm/mm.c is using the typesafe MFN in most of the place. This requires all caller of virt_to_mfn to prefixed by _mfn(...). To avoid the extra _mfn(...), re-defined virt_to_mfn within arch/arm/mm.c to handle typesafe MFN. This patch also introduce __virt_to_mfn, so virt_to_mfn ca

[Xen-devel] [PATCH v2 15/16] xen/arm: mm: Introduce temporary variable in create_xen_entries

2017-06-19 Thread Julien Grall
This is improving the code readability and avoid to dereference the table every single time we need to access the entry. Signed-off-by: Julien Grall --- Changes in v2: - Patch added --- xen/arch/arm/mm.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-)

[Xen-devel] [PATCH v2 00/16] xen/arm: Clean-up memory subsystems

2017-06-19 Thread Julien Grall
Hi all, This is a merged of the remainder of 2 series + new clean-up patches: - xen/arm: Extend the usage of typesafe MFN [1] - xen/arm: Move LPAE definition in a separate header. [2] Cheers, [1] <20170613161323.25196-1-julien.gr...@arm.com> [2] <20170615203057.755-1-julien.gr...@arm.com

[Xen-devel] [PATCH v2 08/16] xen/arm: livepatch: Redefine virt_to_mfn to support typesafe

2017-06-19 Thread Julien Grall
The file xen/arch/arm/livepatch.c is using typesafe MFN in most of the place. The only caller to virt_to_mfn is using with _mfn(...). To avoid extra _mfn(...), re-define virt_to_mfn within xen/arch/arm/livepatch.c to handle typesafe MFN. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellin

[Xen-devel] [PATCH v2 13/16] xen/arm: p2m: Move lpae_* helpers in lpae.h

2017-06-19 Thread Julien Grall
lpae_* helpers can work on any LPAE translation tables. Move them in lpae.h to allow other part of Xen to use them. Signed-off-by: Julien Grall --- Cc: prosku...@sec.in.tum.de Changes in v2: - Patch added --- xen/arch/arm/p2m.c | 23 --- xen/include/asm-

[Xen-devel] [PATCH v2 03/16] xen/arm: mm: Use typesafe mfn for xenheap_mfn_*

2017-06-19 Thread Julien Grall
Add more safety when using xenheap_mfn_*. Signed-off-by: Julien Grall --- I haven't introduced mfn_less_than() and mfn_greather_than() as there would be only a couple of usage. We would be able to introduce them and replace the open-coding easily in the future grepping mfn_x(). -

[Xen-devel] [PATCH v2 14/16] xen/arm: mm: Use lpae_valid and lpae_table in create_xen_entries

2017-06-19 Thread Julien Grall
This newly introduced lpae_valid and lpae_table helpers will recude the code and make more readable. Signed-off-by: Julien Grall --- Changes in v2: - Patch added --- xen/arch/arm/mm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/mm.c b/xe

[Xen-devel] [linux-linus test] 110560: regressions - FAIL

2017-06-19 Thread osstest service owner
flight 110560 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/110560/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 5 kernel-build fail REGR. vs. 110515 test-amd64-amd64-xl

[Xen-devel] [PATCH v2 01/16] xen/mm: Don't use _{g, m}fn for defining INVALID_{G, M}FN

2017-06-19 Thread Julien Grall
INVALID_{G,M}FN are defined using static inline helpers _{g,m}fn. This means, they cannot be used to initialize a build time static variable: In file included from mm.c:24:0: xen/xen/include/xen/mm.h:59:26: error: initializer element is not constant #define INVALID_MFN _mfn(~0UL) Signed-off

[Xen-devel] [PATCH v2 06/16] xen/arm: domain_build: Redefine virt_to_mfn to support typesafe

2017-06-19 Thread Julien Grall
The file xen/arch/arm/domain_build.c is using typesafe MFN in most of the place. The only caller to virt_to_mfn is using prefixed with _mfn(...). To avoid extra _mfn(...), re-define virt_to_mfn within arch/arm/domain_build.c to handle typesafe MFN. Signed-off-by: Julien Grall Reviewed-by: Stefan

[Xen-devel] [PATCH v2 16/16] xen/arm: mm: Use __func__ rather than plain name in format string

2017-06-19 Thread Julien Grall
Signed-off-by: Julien Grall --- Changes in v2: - Patch added --- xen/arch/arm/mm.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 657fee0b17..91af4c8743 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/m

[Xen-devel] [PATCH v2 09/16] xen/arm: create_xen_entries: Use typesafe MFN

2017-06-19 Thread Julien Grall
Add a bit more safety when using create_xen_entries. Also when destroying/modifying mapping, the MFN is currently not used. Rather than passing _mfn(0) use INVALID_MFN to stay consistent with the other usage. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2:

Re: [Xen-devel] [PATCH 2/2] memory: don't hand MFN info to translated guests

2017-06-19 Thread Tamas K Lengyel
> The method I found to work is getting the maximum_gpfn from the guest > and then calling populate_physmap with ++max_gpfn. The only problem > then is that I don't see a way to "unpopulate" the page from the > domain and free the corresponding mfn while the domain is running. Is > that currently p

Re: [Xen-devel] [PATCH 02/14 v4] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h

2017-06-19 Thread Andre Przywara
Hi, On 19/06/17 17:53, Bhupinder Thakur wrote: > Hi Andre, > > On 19 June 2017 at 15:03, Andre Przywara wrote: >> Hi Bhupinder, >> >> I think the commit message is a bit misleading. >> Actually you *rename* functions and their call sites, and also this >> touches the VGIC code, so shouldn't it m

Re: [Xen-devel] [PATCH v2 06/20] rbtree: empty nodes have no color

2017-06-19 Thread Dario Faggioli
On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > Empty nodes have no color.  We can make use of this property to > simplify > the code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE > macros.  Also, > we can get rid of the rb_init_node function which had been introduced > by > commit 88d19

Re: [Xen-devel] [PATCH v4 4/4] x86/vioapic: bind interrupts to PVH Dom0

2017-06-19 Thread Roger Pau Monne
On Wed, Jun 07, 2017 at 07:20:38AM -0600, Jan Beulich wrote: > >>> On 01.06.17 at 13:49, wrote: > > --- a/xen/arch/x86/hvm/vioapic.c > > +++ b/xen/arch/x86/hvm/vioapic.c > > @@ -158,6 +158,52 @@ static int vioapic_read( > > return X86EMUL_OKAY; > > } > > > > +static int vioapic_hwdom_map_g

Re: [Xen-devel] [PATCH v2 07/20] rbtree: move some implementation details from rbtree.h to rbtree.c

2017-06-19 Thread Dario Faggioli
On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > --- a/xen/include/xen/rbtree.h > +++ b/xen/include/xen/rbtree.h > @@ -21,9 +21,7 @@ >   >  struct rb_node >  { > The Linux commit converts this into: struct rb_node { and.. > -unsigned long  rb_parent_color; > -#define RB_RED  0 > -#d

Re: [Xen-devel] [PATCH v2 08/16] xen/arm: livepatch: Redefine virt_to_mfn to support typesafe

2017-06-19 Thread Konrad Rzeszutek Wilk
On Mon, Jun 19, 2017 at 05:57:45PM +0100, Julien Grall wrote: > The file xen/arch/arm/livepatch.c is using typesafe MFN in most of > the place. The only caller to virt_to_mfn is using with _mfn(...). > > To avoid extra _mfn(...), re-define virt_to_mfn within > xen/arch/arm/livepatch.c to handle ty

Re: [Xen-devel] [PATCH v2 08/20] rbtree: break out of rb_insert_color loop after tree rotation

2017-06-19 Thread Dario Faggioli
On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > It is a well known property of rbtrees that insertion never requires > more > than two tree rotations.  In our implementation, after one loop > iteration > identified one or two necessary tree rotations, we would iterate and > look > for mor

  1   2   >