Re: [Xen-devel] [PATCH v6 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-25 Thread Stefano Stabellini
On Wed, 25 Oct 2017, Boris Ostrovsky wrote: > On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > > Also add pvcalls-front to the Makefile. > > > > Signed-off-by: Stefano Stabellini > > CC: boris.ostrov...@oracle.com > > CC: jgr...@suse.com > > --- > > drivers/xen/Kconfig |

Re: [Xen-devel] [PATCH v6 12/13] xen/pvcalls: implement release command

2017-10-25 Thread Stefano Stabellini
On Wed, 25 Oct 2017, Boris Ostrovsky wrote: > On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > > Send PVCALLS_RELEASE to the backend and wait for a reply. Take both > > in_mutex and out_mutex to avoid concurrent accesses. Then, free the > > socket. > > > > For passive sockets, check whether we

[Xen-devel] [libvirt test] 115202: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115202 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/115202/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 15 guest-start/debian.repeat fail REGR. vs. 114825 Tests which did not

Re: [Xen-devel] [BUG] xen_gntdev - gntdev_vma_find_special_page - unable to handle kernel paging request

2017-10-25 Thread Arthur Borsboom
JG> Can I add you as "Reported-by:" ? Absolutely. If I can be of any assistance, please let me know. Keep in mind that I am an application developer (J2EE) and not a hardware/kernel/hypervisor hacker. :-) On 25 October 2017 at 16:13, Juergen Gross wrote: > On 25/10/17 13:17,

Re: [Xen-devel] [PATCH v6 02/13] xen/pvcalls: implement frontend disconnect

2017-10-25 Thread Stefano Stabellini
On Wed, 25 Oct 2017, Boris Ostrovsky wrote: > On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > > +static void pvcalls_front_free_map(struct pvcalls_bedata *bedata, > > + struct sock_mapping *map, bool locked) > > +{ > > +} > > + > > static const struct

Re: [Xen-devel] [PATCH v3 1/2] arm/xen: vpl011: Fix the slow early console SBSA UART output

2017-10-25 Thread Stefano Stabellini
On Tue, 24 Oct 2017, Andre Przywara wrote: > From: Bhupinder Thakur > > The early console output uses pl011_early_write() to write data. This > function waits for BUSY bit to get cleared before writing the next byte. > > In the SBSA UART emulation logic, the BUSY

Re: [Xen-devel] [PATCH v3 2/2] arm/xen: vpl011: Fix SBSA UART interrupt assertion

2017-10-25 Thread Stefano Stabellini
On Tue, 24 Oct 2017, Andre Przywara wrote: > From: Bhupinder Thakur > > With the current SBSA UART emulation, streaming larger amounts of data > (as caused by "find /", for instance) can lead to character loses.

Re: [Xen-devel] [PATCH 01/12] ARM: remove unneeded gic.h inclusions

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > gic.h is supposed to hold defines and prototypes for the hardware side > of the GIC interrupt controller. A lot of parts in Xen should not be > bothered with that, as they either only care about the VGIC or use > more generic interfaces. > Remove

Re: [Xen-devel] [PATCH 02/12] ARM: vGIC: fix nr_irq definition

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > The global variable "nr_irqs" is used for x86 and some common Xen code. > To make the latter work easily for ARM, it was #defined to NR_IRQS. > This not only violated the common habit of capitalizing macros, but > also caused issues if one wanted to use

Re: [Xen-devel] [PATCH 03/12] ARM: VGIC: remove gic_clear_pending_irqs()

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > gic_clear_pending_irqs() was not only misnamed, but also misplaced, as > a function solely dealing with the GIC emulation should not live in gic.c. > Move the functionality of this function into its only caller in vgic.c > > Signed-off-by: Andre

Re: [Xen-devel] [PATCH 04/12] ARM: VGIC: move gic_remove_irq_from_queues()

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > gic_remove_irq_from_queues() was not only misnamed, it also has the wrong > abstraction, as it should not live in gic.c. > Move it into vgic.c and vgic.h, where it belongs to, and rename it on > the way. > > Signed-off-by: Andre Przywara

Re: [Xen-devel] [PATCH 05/12] ARM: VGIC: move gic_remove_from_lr_pending()

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > gic_remove_from_lr_pending() was not only misnamed, it also had the wrong > abstraction, as it should not live in gic.c. > Move it into vgic.c and vgic.h, where it belongs, and rename it on the > way. > > Signed-off-by: Andre Przywara

[Xen-devel] [BUG] xen_gntdev - gntdev_vma_find_special_page - unable to handle kernel paging request

2017-10-25 Thread Arthur Borsboom
Since about a month, possibly due to software updates, after a couple of days running several VMs, one of the VM guests crashes and the VM host is not stable anymore. I need to shutdown all the remaining VM guests (if possible) and reboot the server by hardware (sudo reboot hangs). Does anybody

Re: [Xen-devel] [PATCH RFC v2] Add SUPPORT.md

2017-10-25 Thread Andrew Cooper
On 25/10/17 11:59, George Dunlap wrote: >>> +Limit, x86 HVM: 128 >>> +Limit, ARM32: 8 >>> +Limit, ARM64: 128 >>> + >>> +[XXX Andrew Cooper: Do want to add "Limit-Security" here for some of >>> these?] >> 32 for each. 64 vcpu HVM guests can excerpt enough

[Xen-devel] [xen-4.5-testing test] 115191: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115191 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/115191/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 16 guest-start/debian.repeat fail REGR. vs. 114423

Re: [Xen-devel] [PATCH RFC v2] Add SUPPORT.md

2017-10-25 Thread George Dunlap
On Tue, Oct 24, 2017 at 12:42 PM, Andrew Cooper wrote: > On 24/10/17 11:27, George Dunlap wrote: >> On 10/23/2017 06:55 PM, Andrew Cooper wrote: >>> On 23/10/17 17:22, George Dunlap wrote: On 09/11/2017 06:53 PM, Andrew Cooper wrote: > On 11/09/17 18:01, George

[Xen-devel] [xen-unstable-smoke test] 115217: tolerable all pass - PUSHED

2017-10-25 Thread osstest service owner
flight 115217 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/115217/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl

Re: [Xen-devel] [OSSTEST PATCH 00/16] Upgrade to Stretch

2017-10-25 Thread Wei Liu
On Fri, Oct 20, 2017 at 11:38:24AM +0100, Wei Liu wrote: > 3. The unstability with Arndale boards' nic is more prominent. Or worse -- > they >have become completely unusable. I don't have enough data yet. We might >need to work around this, but I'm not sure how to do that yet. It appears

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-25 Thread Doug Goldstein
On 10/24/17 5:20 PM, Daniel Kiper wrote: > On Tue, Oct 24, 2017 at 10:40:26PM +0100, Andrew Cooper wrote: >> On 24/10/2017 22:11, Daniel Kiper wrote: >>> On Tue, Oct 24, 2017 at 09:22:20PM +0100, Andrew Cooper wrote: On 24/10/17 21:08, Daniel Kiper wrote: > On Tue, Oct 24, 2017 at

Re: [Xen-devel] [PATCH 10/13] x86/alternative: Support indirect call replacement

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Add alternative patching support for replacing an instruction with an > indirect call. This will be needed for the paravirt alternatives. > > Signed-off-by: Josh Poimboeuf > --- > arch/x86/kernel/alternative.c | 22

Re: [Xen-devel] [PATCH v6 02/13] xen/pvcalls: implement frontend disconnect

2017-10-25 Thread Boris Ostrovsky
On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > +static void pvcalls_front_free_map(struct pvcalls_bedata *bedata, > +struct sock_mapping *map, bool locked) > +{ > +} > + > static const struct xenbus_device_id pvcalls_front_ids[] = { > { "pvcalls" }, >

Re: [Xen-devel] [PATCH 07/13] x86/paravirt: Simplify ____PVOP_CALL()

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Remove the inline asm duplication in PVOP_CALL(). > > Also add 'IS_ENABLED(CONFIG_X86_32)' to the return variable logic, > making the code clearer and rendering the comment unnecessary. > > Signed-off-by: Josh Poimboeuf

Re: [Xen-devel] [PATCH 06/13] x86/paravirt: Clean up paravirt-asm.h

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Some cleanup to make the code easier to read and understand: > > - Use the common "PV_" prefix > - Simplify the PV_SITE macro interface > - Improve whitespace > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross

Re: [Xen-devel] [PATCH 08/13] x86/paravirt: Clean up paravirt_types.h

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Make paravirt_types.h more understandable: > > - Use more consistent and logical naming > - Simplify interfaces > - Put related macros together > - Improve whitespace > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross

Re: [Xen-devel] [PATCH 09/13] x86/asm: Convert ALTERNATIVE*() assembler macros to preprocessor macros

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > The ALTERNATIVE() and ALTERNATIVE_2() macros are GNU assembler macros, > which makes them quite inflexible for future changes. Convert them to > preprocessor macros. > > Signed-off-by: Josh Poimboeuf Reviewed-by: Juergen Gross

Re: [Xen-devel] [Qemu-devel] [PATCH] pci-assign: Remove

2017-10-25 Thread Philippe Mathieu-Daudé
> On Fri, Oct 20, 2017 at 10:25:38AM +0200, Paolo Bonzini wrote: >> Legacy PCI device assignment has been removed from Linux in 4.12, >> and had been deprecated 2 years ago there. We can remove it from >> QEMU as well. >> >> The ROM loading code was shared with Xen PCI passthrough, so move >> it

Re: [Xen-devel] [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Jiri Slaby
Hi, On 10/06/2017, 03:21 PM, Mark Rutland wrote: > If the aim of this series is to introduce something that architectures > use consistently, then can we please actually poke other architectures > about it? e.g. send this to linux-arch, with a cover letter explaining > the idea and asking

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build test"): > On Wed, Oct 25, 2017 at 04:25:21PM +0100, Ian Jackson wrote: > > If you are worried about this you should check that there are no > > uncommitted files before starting. > > This is already done in this version. > > I

Re: [Xen-devel] [PATCH v3 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-25 Thread Boris Ostrovsky
On 10/25/2017 02:45 AM, Dongli Zhang wrote: > After guest live migration on xen, steal time in /proc/stat > (cpustat[CPUTIME_STEAL]) might decrease because steal returned by > xen_steal_lock() might be less than this_rq()->prev_steal_time which is > derived from previous return value of

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Wei Liu
On Tue, Oct 24, 2017 at 02:38:39PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("Re: [PATCH v2] scripts: introduce a script for build > test"): > > That feels wrong. How do I run the same exact command at the default > > one, but with -j8 instead of -j4? > > .../build-test sh -ec make -j4

Re: [Xen-devel] [PATCH v3 2/7] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-10-25 Thread Zhongze Liu
2017-10-25 17:37 GMT+08:00 Zhongze Liu : > Hi, > > My current plan is to add the following new MAPSPACE to public/memory.h: > > +#define XENMEMSPACE_gmfn_foreign_share 6 /* Same as *_gmfn_foreign, but this > is > +for a privileged

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Wei Liu
On Wed, Oct 25, 2017 at 04:42:44PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build test"): > > On Wed, Oct 25, 2017 at 04:25:21PM +0100, Ian Jackson wrote: > > > If you are worried about this you should check that there are no > > > uncommitted

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Wei Liu
On Wed, Oct 25, 2017 at 04:47:33PM +0100, George Dunlap wrote: > On 10/25/2017 04:27 PM, Wei Liu wrote: > > On Wed, Oct 25, 2017 at 04:25:21PM +0100, Ian Jackson wrote: > >> Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build > >> test"): > >>> On Tue, Oct 24, 2017 at 02:38:39PM

Re: [Xen-devel] [BUG] xen_gntdev - gntdev_vma_find_special_page - unable to handle kernel paging request

2017-10-25 Thread Juergen Gross
On 25/10/17 13:17, Arthur Borsboom wrote: > Since about a month, possibly due to software updates, after a couple of > days running several VMs, one of the VM guests crashes and the VM host > is not stable anymore. I need to shutdown all the remaining VM guests > (if possible) and reboot the

Re: [Xen-devel] [PATCH v4 4/5] xentrace: enable per-VCPU extratime flag for RTDS

2017-10-25 Thread Wei Liu
On Mon, Oct 23, 2017 at 02:50:31PM -0400, Meng Xu wrote: > On Tue, Oct 17, 2017 at 4:10 AM, Dario Faggioli wrote: > > On Wed, 2017-10-11 at 14:02 -0400, Meng Xu wrote: > >> Change repl_budget event output for xentrace formats and xenalyze > >> > >> Signed-off-by: Meng Xu

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-25 Thread Ian Jackson
I have reordered the quoted text, and my replies, so as to address the most technical points first and leave what might be described as process arguments and tone complaints for later. Andrew Cooper writes ("Re: [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by

Re: [Xen-devel] [PATCH RFC 05/14] xen: vmx: Disable the 2M/1G superpage when SPP enabled

2017-10-25 Thread Tamas K Lengyel
On Wed, Oct 25, 2017 at 9:32 AM, Yi Zhang wrote: > On 2017-10-24 at 11:43:45 -0600, Tamas K Lengyel wrote: >> On Fri, Oct 20, 2017 at 2:44 AM, Yi Zhang wrote: >> > On 2017-10-19 at 12:17:12 -0600, Tamas K Lengyel wrote: >> >> On Thu, Oct

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Wei Liu
On Wed, Oct 25, 2017 at 04:23:35PM +0100, Anthony PERARD wrote: > On Wed, Oct 25, 2017 at 04:17:26PM +0100, Wei Liu wrote: > > On Tue, Oct 24, 2017 at 02:38:39PM +0100, Ian Jackson wrote: > > > > Also, what a developper should do when the build fail? She can't modify > > > > the current code,

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread George Dunlap
On 10/25/2017 04:27 PM, Wei Liu wrote: > On Wed, Oct 25, 2017 at 04:25:21PM +0100, Ian Jackson wrote: >> Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build test"): >>> On Tue, Oct 24, 2017 at 02:38:39PM +0100, Ian Jackson wrote: Anthony PERARD writes ("Re: [PATCH v2]

Re: [Xen-devel] [PATCH v6 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-25 Thread Boris Ostrovsky
On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > Also add pvcalls-front to the Makefile. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com > --- > drivers/xen/Kconfig | 9 + > drivers/xen/Makefile | 1 + > 2 files

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build test"): > On Tue, Oct 24, 2017 at 02:38:39PM +0100, Ian Jackson wrote: > > Anthony PERARD writes ("Re: [PATCH v2] scripts: introduce a script for > > build test"): > > > That feels wrong. How do I run the same exact command at

[Xen-devel] [qemu-mainline test] 115198: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115198 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/115198/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3866 xen-buildfail REGR. vs. 114507 build-i386-xsm

Re: [Xen-devel] [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Mark Rutland
On Wed, Oct 25, 2017 at 04:21:48PM +0200, Jiri Slaby wrote: > Hi, > > On 10/06/2017, 03:21 PM, Mark Rutland wrote: > > If the aim of this series is to introduce something that architectures > > use consistently, then can we please actually poke other architectures > > about it? e.g. send this to

[Xen-devel] [PATCH] xen/gntdev: avoid out of bounds access in case of partial gntdev_mmap()

2017-10-25 Thread Juergen Gross
In case gntdev_mmap() succeeds only partially in mapping grant pages it will leave some vital information uninitialized needed later for cleanup. This will lead to an out of bounds array access when unmapping the already mapped pages. So just initialize the data needed for unmapping the pages a

Re: [Xen-devel] [PATCH v4 01/27] linkage: new macros for assembler symbols

2017-10-25 Thread Jiri Slaby
On 10/06/2017, 05:23 PM, Josh Poimboeuf wrote: > On Mon, Oct 02, 2017 at 11:12:20AM +0200, Jiri Slaby wrote: >>SYM_CODE_INNER_LABEL -- only for labels in the middle of code >>SYM_CODE_INNER_LABEL_NOALIGN -- only for labels in the middle of code > > Why are the inner labels aligned by

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Wei Liu
On Wed, Oct 25, 2017 at 04:25:21PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build test"): > > On Tue, Oct 24, 2017 at 02:38:39PM +0100, Ian Jackson wrote: > > > Anthony PERARD writes ("Re: [PATCH v2] scripts: introduce a script for > > > build

Re: [Xen-devel] [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Jiri Slaby
On 10/06/2017, 04:01 PM, Ard Biesheuvel wrote: > On 6 October 2017 at 13:53, Jiri Slaby wrote: >> On 10/04/2017, 09:33 AM, Ard Biesheuvel wrote: >>> In arm64, we use ENTRY/ENDPROC for functions with external linkage, >>> and the bare symbol name/ENDPROC for functions with local

Re: [Xen-devel] [PATCH v6 12/13] xen/pvcalls: implement release command

2017-10-25 Thread Boris Ostrovsky
On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > Send PVCALLS_RELEASE to the backend and wait for a reply. Take both > in_mutex and out_mutex to avoid concurrent accesses. Then, free the > socket. > > For passive sockets, check whether we have already pre-allocated an > active socket for the

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Wei Liu
On Tue, Oct 24, 2017 at 12:29:32PM +0100, Anthony PERARD wrote: > On Mon, Oct 23, 2017 at 05:56:33PM +0100, Wei Liu wrote: > > + > > +if test $# -lt 2 ; then > > +echo "Usage: $0 [CMD]" > > +exit 1 > > +fi > [...] > > +git rev-list $BASE..$TIP | nl -ba | tac | \ > > +while read num rev;

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Anthony PERARD
On Wed, Oct 25, 2017 at 04:17:26PM +0100, Wei Liu wrote: > On Tue, Oct 24, 2017 at 02:38:39PM +0100, Ian Jackson wrote: > > > Also, what a developper should do when the build fail? She can't modify > > > the current code, because changes are going to be losts. Maybe we could > > > trap failures,

[Xen-devel] [PATCH v3 for-4.10] scripts: introduce a script for build test

2017-10-25 Thread Wei Liu
Signed-off-by: Ian Jackson Signed-off-by: Wei Liu --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek

[Xen-devel] [linux-4.9 test] 115196: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115196 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/115196/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 114814 Tests which did not

[Xen-devel] [linux-linus test] 115203: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115203 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/115203/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail REGR. vs. 114682 Tests which did

Re: [Xen-devel] [PATCH 07/12] ARM: VGIC: split gic.c to observe hardware/virtual GIC separation

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > Currently gic.c holds code to handle hardware IRQs as well as code to > bridge VGIC requests to the GIC virtualization hardware. That is true, however, I don't necessarely see "the code to bridge VGIC requests to the GIC virtualization hardware" as

Re: [Xen-devel] [PATCH 09/12] ARM: VGIC: rework events_need_delivery()

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > In event.h we very deeply dive into the VGIC to learn if an event for > a guest is pending. > Rework that function to abstract the VGIC specific part out. Also > reorder the queries there, as we only actually need to check for the > event channel if

Re: [Xen-devel] [PATCH] xen/gntdev: avoid out of bounds access in case of partial gntdev_mmap()

2017-10-25 Thread Boris Ostrovsky
On 10/25/2017 11:08 AM, Juergen Gross wrote: > In case gntdev_mmap() succeeds only partially in mapping grant pages > it will leave some vital information uninitialized needed later for > cleanup. This will lead to an out of bounds array access when unmapping > the already mapped pages. > > So

[Xen-devel] [xen-4.6-testing baseline-only test] 72351: regressions - FAIL

2017-10-25 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72351 xen-4.6-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72351/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-221

Re: [Xen-devel] [OSSTEST PATCH 00/16] Upgrade to Stretch

2017-10-25 Thread Wei Liu
On Fri, Oct 20, 2017 at 11:38:24AM +0100, Wei Liu wrote: > 6. Rumprun doesn't build due to its build system can't cope. This should be >fixed in rumprun. There are two bugs: https://github.com/rumpkernel/rumprun/issues/99 (also numerous duplicates)

Re: [Xen-devel] Xen-unstable + dom0 linux-4.14-rc6: bisected pci-passthrough problem to HVM

2017-10-25 Thread Boris Ostrovsky
On 10/25/2017 04:05 PM, Sander Eikelenboom wrote: > Hi Juergen and Boris, > > While testing out linux 4.14-rc6 i found some trouble with one of my devices > for which I use pci-passthrough. > It fails to start a HVM when configured to use pci-passthrough on this > particular device (see below

Re: [Xen-devel] Libvirt xl to xml converter only picks up first occurrence of an option

2017-10-25 Thread Jim Fehlig
On 10/20/2017 08:46 AM, Wei Liu wrote: Hi Jim Hi Wei, Sorry for the delay. Catching up on mail after some days off... I discovered that libvirt's native config file to xml converter for libxl only pick up the first occurrence of an option. For example in a xl cfg file: extra = "abc" ...

Re: [Xen-devel] [adhoc test] 115230: all pass

2017-10-25 Thread Julien Grall
(+ Jan and Andrew) Hi, Discussing with Ian today, we decided to try reproducing the Windows failure on one of the board where the test was passing. This is still passing so it does not seem to be a random success. I would say the bug is somehow related to merlot/pinot hardware. This also

Re: [Xen-devel] Xen-unstable + dom0 linux-4.14-rc6: bisected pci-passthrough problem to HVM

2017-10-25 Thread Sander Eikelenboom
On 25/10/17 22:34, Boris Ostrovsky wrote: > On 10/25/2017 04:05 PM, Sander Eikelenboom wrote: >> Hi Juergen and Boris, >> >> While testing out linux 4.14-rc6 i found some trouble with one of my devices >> for which I use pci-passthrough. >> It fails to start a HVM when configured to use

[Xen-devel] [adhoc test] 115230: all pass

2017-10-25 Thread iwj
[adhoc adhoc] harness 8f16840: MaxUmask: enforce a maximum umask value 115230: all pass flight 115230 xen-unstable adhoc [adhoc] http://logs.test-lab.xenproject.org/osstest/logs/115230/ Perfect :-) All tests in this flight passed as required baseline version: flight 114644 jobs:

[Xen-devel] [xen-unstable test] 115195: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115195 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/115195/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 7 xen-boot fail REGR. vs. 114644

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-25 Thread Andrew Cooper
On 25/10/17 15:55, Ian Jackson wrote: > I have reordered the quoted text, and my replies, so as to address the > most technical points first and leave what might be described as > process arguments and tone complaints for later. I will keep my reply to the technical points.  I didn't enjoy

Re: [Xen-devel] [PATCH 08/12] ARM: VGIC: split up gic_dump_info() to cover virtual part separately

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > Currently gic_dump_info() not only dumps the hardware state of the GIC, > but also the VGIC internal virtual IRQ lists. > Split the latter off and move it into vgic.c to observe the abstraction. > > Signed-off-by: Andre Przywara

Re: [Xen-devel] [PATCH 11/12] ARM: VGIC: factor out vgic_get_hw_irq_desc()

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > At the moment we happily access the VGIC internal struct pending_irq > (which describes a virtual IRQ) in irq.c. > Factor out the actually needed functionality to learn the associated > hardware IRQ and move that into gic-vgic.c to improve abstraction.

Re: [Xen-devel] [PATCH 10/12] ARM: VGIC: factor out vgic_connect_hw_irq()

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > At the moment we happily access VGIC internal data structures like > the rank and struct pending_irq in gic.c, which should be VGIC agnostic. > > Factor out a new function vgic_connect_hw_irq(), which allows a virtual > IRQ to be connected to a

Re: [Xen-devel] [PATCH 12/12] ARM: VGIC: rework gicv[23]_update_lr to not use pending_irq

2017-10-25 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Andre Przywara wrote: > The functions to actually populate a list register were accessing > the VGIC internal pending_irq struct, although they should be abstracting > from that. > Break the needed information down to remove the reference to pending_irq > from gic-v[23].c. >

Re: [Xen-devel] [PATCH 0/6] Intel Processor Trace virtulization enabling

2017-10-25 Thread Kang, Luwei
> > Hi All, > > > > Here is a patch-series which adding Processor Trace enabling in XEN guest. > > You can get It's software developer manuals from: > > https://software.intel.com/sites/default/files/managed/c5/15/architect > > ure-instruction-set-extensions-programming-reference.pdf > > In

[Xen-devel] How to Hardware performance monitoring from Dom0

2017-10-25 Thread Tejaswini Vibhute
Hi, I need some pointers to how to monitor hardware events in a Xen configured environment. I am running Xen 4.7 with Linux kernel 4.11 as my Dom0. -- Regards, Tejaswini Vibhute ___ Xen-devel mailing list Xen-devel@lists.xen.org

[Xen-devel] [xen-4.9-testing test] 115206: tolerable FAIL - PUSHED

2017-10-25 Thread osstest service owner
flight 115206 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/115206/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 114833

[Xen-devel] [xen-4.8-testing test] 115185: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115185 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/115185/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stopfail REGR. vs. 114689 Tests which

[Xen-devel] [xen-4.9-testing test] 115186: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115186 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/115186/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-ws16-amd64 15 guest-saverestore.2 fail REGR. vs. 115018 Regressions

Re: [Xen-devel] [PATCH V3 5/29] tools/libacpi: Add new fields in acpi_config for DMAR table

2017-10-25 Thread Lan Tianyu
On 2017年10月19日 16:40, Roger Pau Monné wrote: > On Thu, Oct 19, 2017 at 04:09:02PM +0800, Lan Tianyu wrote: >> On 2017年10月18日 23:12, Roger Pau Monné wrote: diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h index a2efd23..fdd6a78 100644 --- a/tools/libacpi/libacpi.h

[Xen-devel] [PATCH v3 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-25 Thread Dongli Zhang
After guest live migration on xen, steal time in /proc/stat (cpustat[CPUTIME_STEAL]) might decrease because steal returned by xen_steal_lock() might be less than this_rq()->prev_steal_time which is derived from previous return value of xen_steal_clock(). For instance, steal time of each vcpu is

Re: [Xen-devel] [PATCH for-4.10 v2 0/5] tools/dombuilder: Fixes and improvements to grant handling

2017-10-25 Thread Juergen Gross
On 24/10/17 18:06, Julien Grall wrote: > Hi, > > I think this is 4.10 material (particularly patch #5). Juergen, would it > be possible get the some feedback on this series? Patch 5: Reviewed-by: Juergen Gross Juergen > > Cheers, > > On 12/10/17 20:19, Andrew Cooper wrote:

Re: [Xen-devel] [PATCH v12 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

2017-10-25 Thread Paul Durrant
> -Original Message- > From: Julien Grall [mailto:julien.gr...@linaro.org] > Sent: 23 October 2017 20:04 > To: Paul Durrant ; 'Jan Beulich' > > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap >

Re: [Xen-devel] [PATCH V3 20/29] VIOMMU: Add get irq info callback to convert irq remapping request

2017-10-25 Thread Roger Pau Monné
On Wed, Oct 25, 2017 at 03:30:39PM +0800, Lan Tianyu wrote: > On 2017年10月19日 23:42, Roger Pau Monné wrote: > > On Thu, Sep 21, 2017 at 11:02:01PM -0400, Lan Tianyu wrote: > > > >> > >> struct viommu_ops { > >> @@ -28,6 +29,9 @@ struct viommu_ops { > >> int (*destroy)(struct viommu

Re: [Xen-devel] [RFC] [Draft Design] ACPI/IORT Support in Xen.

2017-10-25 Thread Manish Jaggi
On 10/23/2017 7:27 PM, Andre Przywara wrote: Hi Manish, On 12/10/17 22:03, Manish Jaggi wrote: ACPI/IORT Support in Xen. -- I had sent out patch series [0] to hide smmu from Dom0 IORT. Extending the scope and including all that is required to support

Re: [Xen-devel] [RFC] [Draft Design] ACPI/IORT Support in Xen.

2017-10-25 Thread Manish Jaggi
On 10/23/2017 8:26 PM, Julien Grall wrote: Hi, On 23/10/17 14:57, Andre Przywara wrote: On 12/10/17 22:03, Manish Jaggi wrote: It is proposed that the idrange of PCIRC and ITS group be constant for domUs. "constant" is a bit confusing here. Maybe "arbitrary", "from scratch" or

[Xen-devel] [xen-4.7-testing test] 115189: regressions - FAIL

2017-10-25 Thread osstest service owner
flight 115189 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/115189/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-5 49 xtf/test-hvm64-lbr-tsx-vmentry fail REGR. vs. 114790

Re: [Xen-devel] [PATCH V3 20/29] VIOMMU: Add get irq info callback to convert irq remapping request

2017-10-25 Thread Lan Tianyu
On 2017年10月19日 23:42, Roger Pau Monné wrote: > On Thu, Sep 21, 2017 at 11:02:01PM -0400, Lan Tianyu wrote: >> This patch is to add get_irq_info callback for platform implementation >> to convert irq remapping request to irq info (E,G vector, dest, dest_mode >> and so on). >> >> Signed-off-by: Lan

Re: [Xen-devel] [PATCH RFC 05/14] xen: vmx: Disable the 2M/1G superpage when SPP enabled

2017-10-25 Thread Yi Zhang
On 2017-10-24 at 11:43:45 -0600, Tamas K Lengyel wrote: > On Fri, Oct 20, 2017 at 2:44 AM, Yi Zhang wrote: > > On 2017-10-19 at 12:17:12 -0600, Tamas K Lengyel wrote: > >> On Thu, Oct 19, 2017 at 2:11 AM, Zhang Yi > >> wrote: > >> > From:

Re: [Xen-devel] [PATCH V3 20/29] VIOMMU: Add get irq info callback to convert irq remapping request

2017-10-25 Thread Lan Tianyu
On 2017年10月25日 15:43, Roger Pau Monné wrote: > On Wed, Oct 25, 2017 at 03:30:39PM +0800, Lan Tianyu wrote: >> On 2017年10月19日 23:42, Roger Pau Monné wrote: >>> On Thu, Sep 21, 2017 at 11:02:01PM -0400, Lan Tianyu wrote: >>> struct viommu_ops { @@ -28,6 +29,9 @@ struct viommu_ops {

[Xen-devel] [distros-debian-squeeze test] 72350: tolerable trouble: broken/fail/pass

2017-10-25 Thread Platform Team regression test user
flight 72350 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72350/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-arm64-pvops 2 hosts-allocate broken like 72228 build-arm64

[Xen-devel] [PATCH 2/5 v2] libxl: Change the type of console_mfn to xen_pfn_t

2017-10-25 Thread Bhupinder Thakur
Currently the type of console mfn is unsigned long in libxl. This may be an issue for 32-bit toolstack running on 64-bit Xen, where the pfn are 64 bit. To ensure that console_mfn can hold any valid 64-bit pfn, the type of console_mfn is changed to xen_pfn_t. Signed-off-by: Bhupinder Thakur

Re: [Xen-devel] [PATCH 02/13] x86/paravirt: Fix output constraint macro names

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Some of the paravirt '*_CLOBBERS' macros refer to output constraints > instead of clobbers, which makes the code extra confusing. Rename the > output constraint related macros to '*_OUTPUTS'. > > Signed-off-by: Josh Poimboeuf I'm

Re: [Xen-devel] [PATCH v3 2/7] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-10-25 Thread Zhongze Liu
Hi, My current plan is to add the following new MAPSPACE to public/memory.h: +#define XENMEMSPACE_gmfn_foreign_share 6 /* Same as *_gmfn_foreign, but this is +for a privileged dom to +shared pages between two

Re: [Xen-devel] [PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > Convert the hard-coded native patch assembly code strings to macros to > facilitate sharing common code between 32-bit and 64-bit. > > These macros will also be used by a future patch which requires the GCC > extended asm syntax of two '%' characters

[Xen-devel] [PATCH 1/5 v2] libxl: Fix the bug introduced in commit "libxl: use correct type modifier for vuart_gfn"

2017-10-25 Thread Bhupinder Thakur
In libxl__device_vuart_add vuart_gfn is getting stored as a hex value: > flexarray_append(ro_front, GCSPRINTF("%"PRI_xen_pfn, state->vuart_gfn)); However, xenstore reads this value as a decimal value and tries to map the wrong address and fails. This patch introduces a new format specifier

[Xen-devel] [PATCH 5/5 v2] xenconsole: Define and use a macro XEN_INVALID_PFN instead of -1

2017-10-25 Thread Bhupinder Thakur
xenconsole will use a new macro XEN_INVALID_PFN instead of -1 for initializing ring-ref. Signed-off-by: Bhupinder Thakur --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien

[Xen-devel] [PATCH 4/5 v2] xenconsole: Change the type of ring_ref to xen_pfn_t in console_create_ring

2017-10-25 Thread Bhupinder Thakur
Currently, ring_ref is read as an integer in console_create_ring which could lead to truncation of the value as it is reading a 64-bit value. The fix is to modify the type of ring_ref to xen_pfn_t and use the correct format specifier to read the value correctly for all architectures.

[Xen-devel] [PATCH 3/5 v2] libxc: Fix the data type of mfn parameter passed to xc_map_foreign_range()

2017-10-25 Thread Bhupinder Thakur
Currently the data type of mfn parameter passed to xc_map_foreign_range() is unsigned long. This could be problem for 32-bit arm architectures where the lengh of long is 32 bits while mfn happens to be a 64-bit value. To avoid truncating a 64-bit value, the type of mfn is changed from "unsigned

Re: [Xen-devel] [PATCH 04/13] x86/paravirt: Convert DEF_NATIVE macro to GCC extended asm syntax

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > In a future patch, the NATIVE_* instruction string macros will be used > in GCC extended inline asm, which requires registers to have two '%' > instead of one in the asm template string. Convert the DEF_NATIVE macro > to the GCC extended asm syntax so

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-25 Thread Andrew Cooper
On 19/10/17 16:17, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH for-4.10 1/2] tools/libxc: Fix > precopy_policy() to not pass a structure by value"): >> On 16/10/17 16:07, Ian Jackson wrote: >>> This statement is true only if you think "the precopy callback" refers >>> to the stub

[Xen-devel] [xen-4.6-testing test] 115190: tolerable FAIL - PUSHED

2017-10-25 Thread osstest service owner
flight 115190 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/115190/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-xtf-amd64-amd64-2 49 xtf/test-hvm64-lbr-tsx-vmentry fail like 114488

[Xen-devel] [PATCH] osstest: fix examine job in generic flight

2017-10-25 Thread Roger Pau Monne
Previous patches only added the FreeBSD runvars to the jobs in the examine flight, but failed to also add them to the examine job in the generic flight. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson --- make-flight | 4 +++- 1 file changed,

Re: [Xen-devel] [PATCH] x86/vpmu: Remove unnecessary call to do_interrupt()

2017-10-25 Thread Andrew Cooper
On 25/10/17 00:30, Boris Ostrovsky wrote: > This call was left during PVHv1 removal (commit 33e5c32559e1 ("x86: > remove PVHv1 code")): > > -if ( is_pvh_vcpu(sampling) && > - !(vpmu_mode & XENPMU_MODE_ALL) && > +if ( !(vpmu_mode & XENPMU_MODE_ALL) && >

Re: [Xen-devel] [PATCH 05/13] x86/paravirt: Move paravirt asm macros to paravirt-asm.h

2017-10-25 Thread Juergen Gross
On 04/10/17 17:58, Josh Poimboeuf wrote: > The paravirt.h file is quite big and the asm interfaces for paravirt > don't need to be in the same file as the C interfaces. Move the asm > interfaces to a dedicated header file. > > Signed-off-by: Josh Poimboeuf Reviewed-by:

  1   2   >