[Xen-devel] [GRUB2 PATCH v5 3/4 - FOR COMMIT] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-19 Thread Daniel Kiper
services then it is easier/safer to not provide maps. However, if image needs memory maps and they are not provided by bootloader then it should get itself just before ExitBootServices() call. Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk --- v5 - suggestions/fixes: - improve

[Xen-devel] [GRUB2 PATCH v5 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-20 Thread Daniel Kiper
services then it is easier/safer to not provide maps. However, if image needs memory maps and they are not provided by bootloader then it should get itself just before ExitBootServices() call. Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk --- v5 - suggestions/fixes: - improve

Re: [Xen-devel] [GRUB2 PATCH v5 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-25 Thread Daniel Kiper
On Fri, Mar 25, 2016 at 12:28:46PM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 18, 2016 at 06:00:23PM +0100, Daniel Kiper wrote: > > Add grub_relocator64_efi relocator. It will be used on EFI 64-bit platforms > > when multiboot2 compatible image requests MULTIBOOT_

Re: [Xen-devel] [PATCH v7 00/11] grub-xen: support booting huge pv-domains

2016-03-29 Thread Daniel Kiper
On Tue, Mar 29, 2016 at 11:52:52AM +0200, Juergen Gross wrote: > On 03/03/16 10:38, Juergen Gross wrote: > > The Xen hypervisor supports starting a dom0 with large memory (up to > > the TB range) by not including the initrd and p2m list in the initial > > kernel mapping. Especially the p2m list can

[Xen-devel] [GRUB2 PATCH v6 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-30 Thread Daniel Kiper
services then it is easier/safer to not provide maps. However, if image needs memory maps and they are not provided by bootloader then it should get itself just before ExitBootServices() call. Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk --- v5 - suggestions/fixes: - improve

[Xen-devel] [GRUB2 PATCH v6 0/4] multiboot2: Add two extensions

2016-03-30 Thread Daniel Kiper
+ 11 files changed, 517 insertions(+), 132 deletions(-) Daniel Kiper (4): i386/relocator: Add grub_relocator64_efi relocator multiboot2: Add tags used to pass ImageHandle to loaded image multiboot2: Do not pass memory maps to image if EFI boot services are enabled

[Xen-devel] [GRUB2 PATCH v6 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-30 Thread Daniel Kiper
Add tags used to pass ImageHandle to loaded image if requested. It is used by at least ExitBootServices() function. Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk --- v4 - suggestions/fixes: - reduce number of #ifdefs in grub_multiboot_get_mbi_size() (suggested by

[Xen-devel] [GRUB2 PATCH v6 3/4 - FOR COMMIT] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-30 Thread Daniel Kiper
services then it is easier/safer to not provide maps. However, if image needs memory maps and they are not provided by bootloader then it should get itself just before ExitBootServices() call. Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk --- v5 - suggestions/fixes: - improve

[Xen-devel] [GRUB2 PATCH v6 4/4] multiboot2: Add support for relocatable images

2016-03-30 Thread Daniel Kiper
dded later. This patch was tested with Xen image which uses that functionality. However, this Xen feature is still under development and new patchset will be released in about 2-3 weeks. Signed-off-by: Daniel Kiper --- v6 - suggestions/fixes: - fix error message in grub_multiboot_load_elf()

[Xen-devel] [GRUB2 PATCH v6 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-30 Thread Daniel Kiper
loaded image, will be set accordingly to Unified Extensible Firmware Interface Specification, Version 2.4 Errata B, section 2.3.4, x64 Platforms, boot services. This way loaded image will be able to use EFI boot services without any issues. Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-06 Thread Daniel Kiper
On Wed, Apr 06, 2016 at 04:40:27AM +0200, Luis R. Rodriguez wrote: > Boris sent out the first HVMLite series of patches to add a new Xen guest type > February 1, 2016 [0]. We've been talking off list with a few folks now over > the prospect of instead of adding yet-another-boot-entry we instead fix

[Xen-devel] [PATCH v3 01/16] x86/boot: do not create unwind tables

2016-04-15 Thread Daniel Kiper
This way .eh_frame section is not included in *.lnk and *.bin files. Hence, final e.g. reloc.bin file size is reduced from 408 bytes to 272 bytes and it contains only used code and data. Suggested-by: Jan Beulich Signed-off-by: Daniel Kiper --- xen/arch/x86/boot/build32.mk |2 +- 1 file

[Xen-devel] [PATCH v3 04/16] x86/boot/reloc: create generic alloc and copy functions

2016-04-15 Thread Daniel Kiper
Create generic alloc and copy functions. We need separate tools for memory allocation and copy to provide multiboot2 protocol support. Signed-off-by: Daniel Kiper Acked-by: Jan Beulich --- v3 - suggestions/fixes: - use "g" constraint instead of "r" for alloc_

[Xen-devel] [PATCH v3 07/16] x86/boot: create *.lnk files with linker script

2016-04-15 Thread Daniel Kiper
code. Signed-off-by: Daniel Kiper --- xen/arch/x86/boot/build32.lds | 49 + xen/arch/x86/boot/build32.mk | 10 ++--- 2 files changed, 56 insertions(+), 3 deletions(-) create mode 100644 xen/arch/x86/boot/build32.lds diff --git a/xen/arch/x86/boot

[Xen-devel] [PATCH v3 03/16] x86/boot: call reloc() using cdecl calling convention

2016-04-15 Thread Daniel Kiper
/leave instructions here. Though they are not strictly needed in this patch. However, then assembly code in patch adding multiboot2 protocol support is easier to read. Suggested-by: Jan Beulich Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - simplify assembly in xen/arch/x86/boot/reloc.c

[Xen-devel] [PATCH v3 09/16] efi: explicitly define efi struct in xen/arch/x86/efi/stub.c

2016-04-15 Thread Daniel Kiper
representation in ELF and PE Xen image. Hence, define efi struct in xen/arch/x86/efi/stub.c and remove efi symbol from ld script. Signed-off-by: Daniel Kiper --- xen/arch/x86/efi/stub.c |8 xen/arch/x86/xen.lds.S |2 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

[Xen-devel] [PATCH v3 16/16] x86: add multiboot2 protocol support for relocatable images

2016-04-15 Thread Daniel Kiper
Add multiboot2 protocol support for relocatable images. Only GRUB2 with "multiboot2: Add support for relocatable images" patch understands that feature. Older multiboot protocol (regardless of version) compatible loaders ignore it and everything works as usual. Signed-off-by: Daniel Kip

[Xen-devel] [PATCH v3 13/16 - RFC] x86: add multiboot2 protocol support for EFI platforms

2016-04-15 Thread Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and other boot loaders which support multiboot2 protocol. Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - take into account alignment when skipping multiboot2 fixed part (suggested by Konrad Rzeszutek Wilk), - improve

[Xen-devel] [PATCH v3 00/16] x86: multiboot2 protocol support

2016-04-15 Thread Daniel Kiper
/efi.h | 13 ++- xen/include/xen/multiboot2.h | 182 +++ 33 files changed, 1491 insertions(+), 570 deletions(-) Daniel Kiper (16): x86/boot: do not create unwind tables x86: zero BSS using stosl instead of stosb x86/boot: call reloc

[Xen-devel] [PATCH v3 02/16] x86: zero BSS using stosl instead of stosb

2016-04-15 Thread Daniel Kiper
ment to coding style. Suggested-by: Andrew Cooper Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - improve comments (suggested by Konrad Rzeszutek Wilk), - improve commit message (suggested by Jan Beulich). --- xen/arch/x86/boot/head.S |5 +++-- xen/arch/x86/xen.lds.S

[Xen-devel] [PATCH v3 05/16] x86/boot: use %ecx instead of %eax

2016-04-15 Thread Daniel Kiper
Use %ecx instead of %eax to store low memory upper limit from EBDA. This way we do not wipe multiboot protocol identifier. It is needed in reloc() to differentiate between multiboot (v1) and multiboot2 protocol. Signed-off-by: Daniel Kiper Reviewed-by: Andrew Cooper Reviewed-by: Konrad

[Xen-devel] [PATCH v3 14/16] x86/boot: implement early command line parser in C

2016-04-15 Thread Daniel Kiper
playing with segment registers) and much easier to maintain. Suggested-by: Andrew Cooper Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - optimize some code (suggested by Jan Beulich), - put VESA data into early_boot_opts_t members (suggested by Jan Beulich), - rename

[Xen-devel] [PATCH v3 10/16] efi: create efi_enabled()

2016-04-15 Thread Daniel Kiper
EFI_PLATFORM feature which is equal to old efi_enabled == 1. Following patch will define EFI_LOADER feature accordingly. Suggested-by: Jan Beulich Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - define efi struct in xen/arch/x86/efi/stub.c in earlier patch (suggested by Jan

[Xen-devel] [PATCH v3 12/16 - RFC] x86/efi: create new early memory allocator

2016-04-15 Thread Daniel Kiper
finally we would get back to #1. Hmmm... Should I check how Linux and others cope with that problem? Signed-off-by: Daniel Kiper --- xen/arch/x86/efi/efi-boot.h | 38 ++ xen/arch/x86/setup.c|3 +-- 2 files changed, 31 insertions(+), 10 deletions(-)

[Xen-devel] [PATCH v3 11/16] efi: build xen.gz with EFI code

2016-04-15 Thread Daniel Kiper
This way we will have one Xen binary which can be loaded by three boot protocols: EFI native loader, multiboot (v1) and multiboot2. Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - check for EFI platform in EFI code (suggested by Jan Beulich), - fix Makefiles (suggested

[Xen-devel] [PATCH v3 08/16] x86: add multiboot2 protocol support

2016-04-15 Thread Daniel Kiper
Add multiboot2 protocol support. Alter min memory limit handling as we now may not find it from either multiboot (v1) or multiboot2. This way we are laying the foundation for EFI + GRUB2 + Xen development. Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - reorder reloc() arguments

[Xen-devel] [PATCH v3 06/16] x86/boot/reloc: Rename some variables and rearrange code a bit

2016-04-15 Thread Daniel Kiper
Replace mbi with mbi_out and mbi_old with mbi_in and rearrange code a bit to make it more readable. Additionally, this way multiboot (v1) protocol implementation and future multiboot2 protocol implementation will use the same variable naming convention. Signed-off-by: Daniel Kiper Reviewed-by

[Xen-devel] [PATCH v3 15/16 - RFC] x86: make Xen early boot code relocatable

2016-04-15 Thread Daniel Kiper
a relative addressing in 32-bit code. Signed-off-by: Daniel Kiper --- v3 - suggestions/fixes: - improve segment registers initialization (suggested by Jan Beulich), - simplify Xen image load base address calculation (suggested by Jan Beulich), - use %esi and %r15d instead of %eb

Re: [Xen-devel] [GRUB2 PATCH v6 0/4] multiboot2: Add two extensions

2016-05-16 Thread Daniel Kiper
Hey, On Wed, Mar 30, 2016 at 05:06:15PM +0200, Daniel Kiper wrote: > Hi, > > This patch series: > - enables EFI boot services usage in loaded images > by multiboot2 protocol, > - add support for multiboot2 protocol compatible > relocatable images. Any chance

Re: [Xen-devel] [PATCH v16 7/9] x86: make Xen early boot code relocatable

2017-04-14 Thread Daniel Kiper
On Thu, Apr 13, 2017 at 02:43:22PM -0500, Doug Goldstein wrote: > On 4/13/17 9:11 AM, Daniel Kiper wrote: > > On Fri, Apr 07, 2017 at 05:23:33AM -0600, Jan Beulich wrote: > >>>>> On 21.02.17 at 20:19, wrote: > >>> Every multiboot protocol (regar

Re: [Xen-devel] [PATCH v16 7/9] x86: make Xen early boot code relocatable

2017-04-14 Thread Daniel Kiper
On Thu, Apr 13, 2017 at 09:44:17PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Apr 13, 2017 at 04:11:25PM +0200, Daniel Kiper wrote: > > On Fri, Apr 07, 2017 at 05:23:33AM -0600, Jan Beulich wrote: > > > >>> On 21.02.17 at 20:19, wrote: > > > > Every mu

[Xen-devel] EFI + tboot + Xen

2017-04-14 Thread Daniel Kiper
Hey, Has anybody tried to run EFI + tboot + Xen? I have a feeling that it does not work because tboot shuts down EFI boot services. However, even if it works then efibootmgr is unusable due to lack of EFI runtime services. Do we care? Is it possible to make it work with full blown EFI infrastructu

Re: [Xen-devel] EFI + tboot + Xen

2017-04-14 Thread Daniel Kiper
On Fri, Apr 14, 2017 at 04:17:54PM +0100, Andrew Cooper wrote: > On 14/04/2017 15:54, Daniel Kiper wrote: > > Hey, > > > > Has anybody tried to run EFI + tboot + Xen? > > I have a feeling that it does not work because > > tboot shuts down EFI boot services. H

Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()

2017-04-14 Thread Daniel Kiper
On Fri, Apr 14, 2017 at 06:53:36PM +0200, Petr Tesarik wrote: > On Tue, 11 Apr 2017 19:20:08 +0200 > Daniel Kiper wrote: > > On Tue, Apr 11, 2017 at 04:59:16PM +0200, Petr Tesarik wrote: > >[...] > > > Tested-by: Petr Tesarik > > > > > > I copied the

Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Daniel Kiper
On Tue, Apr 18, 2017 at 04:49:48AM -0600, Jan Beulich wrote: > >>> On 17.04.17 at 21:09, wrote: > > The spinlock in kexec_swap_images() was removed as > > this function is only reachable on the kexec hypercall, which is > > now protected at the top-level in do_kexec_op_internal(), > > thus the loc

Re: [Xen-devel] [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Daniel Kiper
> > +#define KEXEC_FLAG_CRASH_POS (KEXEC_IMAGE_NR + 1) > > +#define KEXEC_FLAG_IN_PROGRESS(KEXEC_IMAGE_NR + 2) > > +#define KEXEC_FLAG_HC_IN_PROGRESS (KEXEC_IMAGE_NR + 3) > > Perhaps KEXEC_FLAG_IN_HYPERCALL? Other than that (and this Make sense for me. > clearly is sub

Re: [Xen-devel] [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 05:20:50AM -0600, Jan Beulich wrote: > >>> On 19.04.17 at 12:56, wrote: > > On Tue, Apr 18, 2017 at 04:49:48AM -0600, Jan Beulich wrote: > >> >>> On 17.04.17 at 21:09, wrote: > >> > The spinlock in kexec_swap_images() was removed as > >> > this function is only reachable o

Re: [Xen-devel] [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 12:48:56PM +0100, Andrew Cooper wrote: > On 19/04/17 12:00, Daniel Kiper wrote: > > On Tue, Apr 18, 2017 at 04:48:06AM -0600, Jan Beulich wrote: > >>>>> On 17.04.17 at 21:09, wrote: > >>> --- a/xen/common/kexec.c > >>

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Daniel Kiper
e new flag KEXEC_FLAG_HC_IN_PROGRESS > was introduced. > > While at it, fixed the #define mismatched spacing > > Signed-off-by: Eric DeVolder > Reviewed-by: Bhavesh Davda > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by: Jan Beulich > Reviewed-by: Andrew Coop

Re: [Xen-devel] [PATCH v3 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 10:47:16AM -0500, Eric DeVolder wrote: > The spinlock in kexec_swap_images() was removed as > this function is only reachable on the kexec hypercall, which is > now protected at the top-level in do_kexec_op_internal(), > thus the local spinlock is no longer necessary. > > Pe

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: > >>> On 19.04.17 at 17:54, wrote: > > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: > >> @@ -1193,6 +1194,9 @@ static int do_kexec_op_internal(unsigned long op, > >> if ( ret ) > >> return ret; > >> > >> +

Re: [Xen-devel] [PATCH] arm64: xen: Implement EFI reset_system callback

2017-04-19 Thread Daniel Kiper
On Tue, Apr 18, 2017 at 02:46:50PM +0100, Matt Fleming wrote: > On Thu, 06 Apr, at 04:55:11PM, Mark Rutland wrote: > > > > Please, let's keep the Xen knowledge constrained to the Xen EFI wrapper, > > rather than spreading it further. > > > > IMO, given reset_system is a *mandatory* function, the Xe

Re: [Xen-devel] [PATCH] arm64: xen: Implement EFI reset_system callback

2017-04-19 Thread Daniel Kiper
On Wed, Apr 19, 2017 at 08:37:38PM +0100, Matt Fleming wrote: > On Wed, 19 Apr, at 09:29:06PM, Daniel Kiper wrote: > > On Tue, Apr 18, 2017 at 02:46:50PM +0100, Matt Fleming wrote: > > > On Thu, 06 Apr, at 04:55:11PM, Mark Rutland wrote: > > > > > > >

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-20 Thread Daniel Kiper
On Thu, Apr 20, 2017 at 03:34:21AM -0600, Jan Beulich wrote: > >>> On 19.04.17 at 19:16, wrote: > > On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: > >> >>> On 19.04.17 at 17:54, wrote: > >> > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: > >> >> @@ -1193,6 +1194,9 @

Re: [Xen-devel] [PATCH v4 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-20 Thread Daniel Kiper
t; >> Signed-off-by: Eric DeVolder > >> Reviewed-by: Bhavesh Davda > >> Reviewed-by: Konrad Rzeszutek Wilk > > Reviewed-by: Jan Beulich > > Reviewed-by: Andrew Cooper Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v7 0/3] arm64, xen: add xen_boot support into grup-mkconfig

2017-05-04 Thread Daniel Kiper
Hey, On Tue, May 02, 2017 at 03:06:24PM +0800, fu@linaro.org wrote: > From: Fu Wei > > This patchset add xen_boot support into grup-mkconfig for > generating xen boot entrances automatically > > Also update the docs/grub.texi for new xen_boot commands. Slowly recovering after long weekend in

Re: [Xen-devel] [Xen-users] UEFI Secure Boot Xen 4.9

2017-05-15 Thread Daniel Kiper
Hey, CC-ing Xen-devel to spread some knowledge about the issue. On Mon, May 15, 2017 at 10:42:23AM +0100, George Dunlap wrote: > On Wed, May 10, 2017 at 11:36 PM, Bill Jacobs (billjac) > wrote: > > Hi all > > > > I gather that with 4.9, UEFI secure boot of Xen should be possible. > > > > Is this

Re: [Xen-devel] [PATCH v8 0/3] arm64, xen: add xen_boot support into grub-mkconfig

2017-05-15 Thread Daniel Kiper
On Sun, May 14, 2017 at 03:43:44PM +0800, fu@linaro.org wrote: > From: Fu Wei > > This patchset add xen_boot support into grub-mkconfig for > generating xen boot entrances automatically > > Also update the docs/grub.texi for new xen_boot commands. LGTM, if there are no objections I will commi

Re: [Xen-devel] [PATCH v8 0/3] arm64, xen: add xen_boot support into grub-mkconfig

2017-05-15 Thread Daniel Kiper
Hi Julien, On Mon, May 15, 2017 at 02:43:28PM +0100, Julien Grall wrote: > Hi Daniel, > > On 15/05/17 14:38, Daniel Kiper wrote: > >On Sun, May 14, 2017 at 03:43:44PM +0800, fu@linaro.org wrote: > >>From: Fu Wei > >> > >>This patchset a

Re: [Xen-devel] [Xen-users] UEFI Secure Boot Xen 4.9

2017-05-16 Thread Daniel Kiper
On Mon, May 15, 2017 at 07:09:54PM +, Bill Jacobs (billjac) wrote: > > -Original Message- > > From: Daniel Kiper [mailto:daniel.ki...@oracle.com] > > Sent: Monday, May 15, 2017 6:13 AM > > To: Bill Jacobs (billjac) ; george.dun...@citrix.com > > Cc: x

Re: [Xen-devel] [PATCH v8 0/3] arm64, xen: add xen_boot support into grub-mkconfig

2017-05-18 Thread Daniel Kiper
On Mon, May 15, 2017 at 03:46:55PM +0200, Daniel Kiper wrote: > Hi Julien, > > On Mon, May 15, 2017 at 02:43:28PM +0100, Julien Grall wrote: > > Hi Daniel, > > > > On 15/05/17 14:38, Daniel Kiper wrote: > > >On Sun, May 14, 2017 at 03:43:44PM +0800, fu@

Re: [Xen-devel] [Crash-utility] [PATCH] xen: Add support for domU with Linux kernel 3.19 and newer

2017-05-29 Thread Daniel Kiper
have to be translated again. > > * Endless loop starts from here. > > */ > > xen_m2p(machine=0x581b7e000) > > __xen_m2p(machine=0x581b7e000, mfn=0x581b7e) > > readmem(addr=0xc91f5000) > > > > Fortunately, PV domU p2m mapping is also stored at xd->xfd + >

Re: [Xen-devel] [PATCH for-4.9] x86/boot: Fix the boot time relocation calculations

2017-06-03 Thread Daniel Kiper
per > Tested-by: Sergey Dyasli > --- > CC: Jan Beulich > CC: Julien Grall > CC: Daniel Kiper > CC: Doug Goldstein > CC: Sergey Dyasli > > This is a regression introduced in Xen 4.9, and should therefore be fixed. > --- > xen/arch/x86/boot/head.S | 15

Re: [Xen-devel] [PATCH v2] x86/boot: Fix the boot time relocation calculations

2017-06-13 Thread Daniel Kiper
than limiting to an arbitrary 1k. One side effect is that the > MB2/EFI path continues to use the EFI stack until the trampoline is entered. > > Signed-off-by: Andrew Cooper > Tested-by: Sergey Dyasli Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] Fix util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-08-29 Thread Daniel Kiper
On Mon, Aug 28, 2017 at 02:42:18PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 28, 2017 at 02:40:14PM -0400, Konrad Rzeszutek Wilk wrote: > > Commit d33045ce7ffcb7c1e4a60c14d5ca64b36e3c5abe introduced > > the support for this, but it does not work under x86 (as it stops > > 20_linux_xen from

Re: [Xen-devel] [PATCH 2/2] Use grub-file to figure out whether multiboot2 should be used for Xen.gz

2017-08-29 Thread Daniel Kiper
On Mon, Aug 28, 2017 at 02:40:15PM -0400, Konrad Rzeszutek Wilk wrote: > The multiboot2 is much more preferable than multiboot. Especiall > if booting under EFI where multiboot does not have the functionality > to pass ImageHandler. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > v2: Rebase on to

Re: [Xen-devel] [Xen-users] UEFI Secure Boot Xen 4.9

2017-08-29 Thread Daniel Kiper
Hey Tamas, Sorry for late reply. I was on vacation. On Tue, Aug 22, 2017 at 09:01:06PM -0600, Tamas K Lengyel wrote: > On Tue, May 16, 2017 at 5:04 AM, Daniel Kiper wrote: [...] > > UEFI will verify shim secure boot signature then shim will verify GRUB2 > > signature then GR

Re: [Xen-devel] [PATCH v2] Fix ARM multiboot2 breaking Fedora.

2017-08-30 Thread Daniel Kiper
On Tue, Aug 29, 2017 at 04:40:51PM -0400, Konrad Rzeszutek Wilk wrote: > Since v1 [http://lists.gnu.org/archive/html/grub-devel/2017-08/msg00073.html] > - Fixed up patch with failing invocation, > - Redid patch #2 per Daniel's instructions. > > > Hey, > > The first patch: > [PATCH 1/2] Fix util/

Re: [Xen-devel] [Xen-users] UEFI Secure Boot Xen 4.9

2017-09-04 Thread Daniel Kiper
On Wed, Aug 30, 2017 at 10:16:23AM -0600, Tamas K Lengyel wrote: > On Tue, Aug 29, 2017 at 2:01 PM, Daniel Kiper wrote: > > Hey Tamas, > > > > Sorry for late reply. I was on vacation. > > > > On Tue, Aug 22, 2017 at 09:01:06PM -0600, Tamas K Lengyel wrote: >

[Xen-devel] GRUB documentation updated

2017-09-07 Thread Daniel Kiper
Hey, Some people asked me about Multiboot2 Specification and other GRUB doc stuff. So, I have put latest things at https://www.gnu.org/software/grub/grub-documentation.html I hope that helps. If you have any questions please drop me a line. Thanks, Daniel

Re: [Xen-devel] [PATCH v2] Fix ARM multiboot2 breaking Fedora.

2017-09-07 Thread Daniel Kiper
On Wed, Aug 30, 2017 at 12:26:28PM +0200, Daniel Kiper wrote: > On Tue, Aug 29, 2017 at 04:40:51PM -0400, Konrad Rzeszutek Wilk wrote: > > Since v1 > > [http://lists.gnu.org/archive/html/grub-devel/2017-08/msg00073.html] > > - Fixed up patch with failing invocation, >

Re: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-12 Thread Daniel Kiper
On Thu, Oct 12, 2017 at 03:50:06PM -0500, Doug Goldstein wrote: > From: David Esler > > In 9180f5365524 a change was made to the send_chr function to take in > C-strings and print out a character at a time until a NULL was > encountered. However there is no code to increment the current character

Re: [Xen-devel] [PATCH 2/2] x86/boot: rename send_chr to print_err

2017-10-12 Thread Daniel Kiper
UART anymore so rename > > it to print_err so that its closer in name to what it does. > > > > Reviewed-by: Doug Goldstein > > Signed-off-by: David Esler > > Reviewed-by: Andrew Cooper Reviewed-by: Daniel Kiper Daniel __

Re: [Xen-devel] [Xen-users] UEFI Secure Boot Xen 4.9

2017-10-13 Thread Daniel Kiper
On Thu, Oct 12, 2017 at 05:03:13PM +, Bill Jacobs (billjac) wrote: > Hi > What is the status of creating a shim to abstract secure boot > signing for Xen (to leverage MSFT 3rd party, e.g)? xen.efi works with shim itself out of the box. If you wish to use shim and GRUB2 to load Xen you have to

Re: [Xen-devel] [PATCH v2 1/2] x86/boot: fix early error display

2017-10-18 Thread Daniel Kiper
rrent character > position resulting in an endless loop of the first character. This adds > a simple increment. > > Reviewed-by: Doug Goldstein I was told that "Reviewed-by: ..." should be after SOB. > Signed-off-by: David Esler In general Reviewed-by: Daniel Kipe

Re: [Xen-devel] [PATCH v2 2/2] x86/boot: rename send_chr to print_err

2017-10-18 Thread Daniel Kiper
name to what it does. > > Reviewed-by: Doug Goldstein Ditto. > Signed-off-by: David Esler Anyway, Reviewed-by: Daniel Kiper Daniel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Daniel Kiper
On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote: > The EFI multiboot2 entry point currently requires EFI BootServices to > not have been exited however the header currently tells the boot > loader that Xen optionally supports EFI BootServices having been exited. > With this change Xe

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Daniel Kiper
On Tue, Oct 24, 2017 at 09:22:20PM +0100, Andrew Cooper wrote: > On 24/10/17 21:08, Daniel Kiper wrote: > > On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote: > >> The EFI multiboot2 entry point currently requires EFI BootServices to > >> not have bee

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Daniel Kiper
On Tue, Oct 24, 2017 at 03:28:52PM -0500, Doug Goldstein wrote: > On 10/24/17 3:08 PM, Daniel Kiper wrote: > > On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote: > >> The EFI multiboot2 entry point currently requires EFI BootServices to > >> not have bee

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Daniel Kiper
On Tue, Oct 24, 2017 at 03:49:10PM -0500, Doug Goldstein wrote: > On 10/24/17 3:22 PM, Andrew Cooper wrote: > > On 24/10/17 21:08, Daniel Kiper wrote: > >> On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote: > >>> The EFI multiboot2 entry point currentl

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Daniel Kiper
On Tue, Oct 24, 2017 at 10:40:26PM +0100, Andrew Cooper wrote: > On 24/10/2017 22:11, Daniel Kiper wrote: > > On Tue, Oct 24, 2017 at 09:22:20PM +0100, Andrew Cooper wrote: > >> On 24/10/17 21:08, Daniel Kiper wrote: > >>> On Tue, Oct 24, 2017 at 02:40:41PM -0500, Do

Re: [Xen-devel] [PATCH 4.12 26/84] x86/xen/efi: Initialize only the EFI struct members used by Xen

2017-07-19 Thread Daniel Kiper
Hey Greg, On Wed, Jul 19, 2017 at 11:43:32AM +0200, Greg Kroah-Hartman wrote: > 4.12-stable review patch. If anyone has any objections, please let me know. Why did you skip this patch for 4.11? IMO it should be applied there too. Daniel ___ Xen-devel

Re: [Xen-devel] [PATCH 4.12 26/84] x86/xen/efi: Initialize only the EFI struct members used by Xen

2017-07-19 Thread Daniel Kiper
On Wed, Jul 19, 2017 at 01:12:14PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 19, 2017 at 12:37:47PM +0200, Daniel Kiper wrote: > > Hey Greg, > > > > On Wed, Jul 19, 2017 at 11:43:32AM +0200, Greg Kroah-Hartman wrote: > > > 4.12-stable review patch. If anyone has

Re: [Xen-devel] [PATCH 4.12 26/84] x86/xen/efi: Initialize only the EFI struct members used by Xen

2017-07-19 Thread Daniel Kiper
On Wed, Jul 19, 2017 at 01:19:58PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 19, 2017 at 01:12:14PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 19, 2017 at 12:37:47PM +0200, Daniel Kiper wrote: > > > Hey Greg, > > > > > > On Wed, Jul 19, 2017 at 11:43:

Re: [Xen-devel] Xen 4.10 Development Update

2017-07-19 Thread Daniel Kiper
== Hypervisor == > > * Per-cpu tasklet > - XEN-28 > - Konrad Rzeszutek Wilk > > * Add support of rcu_idle_{enter,exit} > - XEN-27 > - Dario Faggioli > > === x86 === Could you add the following project to the list? * Change xen.efi build and add SH

Re: [Xen-devel] [PATCH 4.12 26/84] x86/xen/efi: Initialize only the EFI struct members used by Xen

2017-07-20 Thread Daniel Kiper
On Thu, Jul 20, 2017 at 11:16:39AM +0200, Greg Kroah-Hartman wrote: > On Thu, Jul 20, 2017 at 10:39:10AM +0200, Ingo Molnar wrote: > > > > * Daniel Kiper wrote: > > > > > Hey Greg, > > > > > > On Wed, Jul 19, 2017 at 11:43:32AM +0200, Greg Kroah

[Xen-devel] [PATCH 0/2] xen/efi: Fixes

2017-06-20 Thread Daniel Kiper
insertions(+), 34 deletions(-) Daniel Kiper (2): efi: Process MEMATTR table only if EFI_MEMMAP x86/xen/efi: Init only efi struct members used by Xen ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/2] efi: Process MEMATTR table only if EFI_MEMMAP

2017-06-20 Thread Daniel Kiper
Otherwise e.g. Xen dom0 on x86_64 EFI platforms crashes. In theory we can check EFI_PARAVIRT too, however, EFI_MEMMAP looks more generic and covers more cases. Signed-off-by: Daniel Kiper --- drivers/firmware/efi/efi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[Xen-devel] [PATCH 2/2] x86/xen/efi: Init only efi struct members used by Xen

2017-06-20 Thread Daniel Kiper
mbers used by Xen to avoid such issues in the future. Signed-off-by: Daniel Kiper --- arch/x86/xen/efi.c | 45 - 1 file changed, 12 insertions(+), 33 deletions(-) diff --git a/arch/x86/xen/efi.c b/arch/x86/xen/efi.c index 30bb2e8..01b9faf 100644 --- a

Re: [Xen-devel] [PATCH 2/2] x86/xen/efi: Init only efi struct members used by Xen

2017-06-21 Thread Daniel Kiper
On Wed, Jun 21, 2017 at 09:10:51AM +0100, Andrew Cooper wrote: > On 20/06/2017 21:14, Daniel Kiper wrote: > > Current approach, wholesale efi struct initialization from efi_xen, is not > > good. Usually if new member is defined then it is properly initialized in > > drivers/f

Re: [Xen-devel] [PATCH 2/2] x86/xen/efi: Init only efi struct members used by Xen

2017-06-21 Thread Daniel Kiper
On Wed, Jun 21, 2017 at 11:24:06AM +0200, Ingo Molnar wrote: > > * Daniel Kiper wrote: > > > -static const struct efi efi_xen __initconst = { > > - .systab = NULL, /* Initialized later. */ > > - .runtime_version = 0,/* Initial

[Xen-devel] [PATCH v2 1/2] efi: Process MEMATTR table only if EFI_MEMMAP

2017-06-22 Thread Daniel Kiper
Otherwise e.g. Xen dom0 on x86_64 EFI platforms crashes. In theory we can check EFI_PARAVIRT too, however, EFI_MEMMAP looks more generic and covers more cases. Signed-off-by: Daniel Kiper Reviewed-by: Ard Biesheuvel --- drivers/firmware/efi/efi.c |3 ++- 1 file changed, 2 insertions(+), 1

[Xen-devel] [PATCH v2 2/2] x86/xen/efi: Init only efi struct members used by Xen

2017-06-22 Thread Daniel Kiper
mbers used by Xen to avoid such issues in the future. Signed-off-by: Daniel Kiper Acked-by: Ard Biesheuvel -- Align assignments to increase readability. Suggested by Ingo Molnar. --- arch/x86/xen/efi.c | 45 - 1 file changed, 12 insertions(+), 33 dele

[Xen-devel] [PATCH v2 0/2] xen/efi: Fixes

2017-06-22 Thread Daniel Kiper
- drivers/firmware/efi/efi.c |3 ++- 2 files changed, 14 insertions(+), 34 deletions(-) Daniel Kiper (2): efi: Process MEMATTR table only if EFI_MEMMAP x86/xen/efi: Init only efi struct members used by Xen ___ Xen-devel

Re: [Xen-devel] Optimising the DevSummit schedule on July 11

2017-07-03 Thread Daniel Kiper
On Mon, Jul 03, 2017 at 11:37:29AM +0100, Lars Kurth wrote: > Folks, (committers and speakers/moderators CC'ed) > > I have a few extra sessions from Jan which came in today. Most of Tuesday > in x86 stuff, so there is no space. I merged one of my session with a proposal > from Jan, but it seems to

Re: [Xen-devel] OOPS new Xen 4.9.0_08 / kernel 4.12.0 Dom0 crash @ domain_crash_sync called from entry.S: fault at ffff82d080342328 entry.o#create_bounce_frame+0x135/0x14d

2017-07-05 Thread Daniel Kiper
On Wed, Jul 05, 2017 at 10:27:19AM -0700, PGNet Dev wrote: > On 7/5/17 12:58 AM, Jan Beulich wrote: > >So there are two problems here: One is the fact that the kernel > >really should put an Invalid Opcode exception handler in place > >before intentionally raising any such exceptions (which WARN()

Re: [Xen-devel] Optimising the DevSummit schedule on July 11

2017-07-05 Thread Daniel Kiper
On Tue, Jul 04, 2017 at 09:01:27AM +0100, Roger Pau Monne wrote: > On Mon, Jul 03, 2017 at 11:37:29AM +0100, Lars Kurth wrote: > > Folks, (committers and speakers/moderators CC'ed) > > > > I have a few extra sessions from Jan which came in today. Most of Tuesday > > in x86 stuff, so there is no sp

[Xen-devel] [PATCH RFC 1/7] xen: Introduce XEN_COMPILE_POSIX_TIME

2017-07-08 Thread Daniel Kiper
We need the POSIX time to properly fill the TimeDateStamp field in the PE header. Signed-off-by: Daniel Kiper --- xen/Makefile | 14 -- xen/include/xen/compile.h.in |1 + 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/xen/Makefile b/xen

[Xen-devel] [PATCH RFC 3/7] xen/x86: Add some addresses to the Multiboot header

2017-07-08 Thread Daniel Kiper
In comparison to ELF the PE format is not supported by the Multiboot protocol. So, if we wish to load xen.efi using this protocol we have to put header_addr, load_addr, load_end_addr, bss_end_addr and entry_addr data into Multiboot header. Signed-off-by: Daniel Kiper --- xen/arch/x86/boot

[Xen-devel] [PATCH RFC 5/7] efi: split out efi_shim_lock()

2017-07-08 Thread Daniel Kiper
..which verifies PE signatures with SHIM_LOCK protocol. We want to re-use this code in subsequent patch in efi_multiboot2(). Signed-off-by: Daniel Kiper --- xen/common/efi/boot.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/xen/common/efi/boot.c b

[Xen-devel] [PATCH RFC 2/7] xen/x86: Manually build PE header

2017-07-08 Thread Daniel Kiper
crash tool, - simpler code, - simpler build, - Xen build will no longer depend on ld i386pep support. Signed-off-by: Daniel Kiper --- xen/arch/x86/Rules.mk|2 + xen/arch/x86/boot/head.S | 145 ++ xen/arch/x86/xen.lds.S | 16 - 3

[Xen-devel] [PATCH RFC 6/7] xen/x86/efi: Verify dom0 kernel with SHIM_LOCK protocol in efi_multiboot2()

2017-07-08 Thread Daniel Kiper
Signed-off-by: Daniel Kiper --- xen/arch/x86/boot/head.S| 20 ++-- xen/arch/x86/efi/efi-boot.h | 12 +++- xen/arch/x86/efi/stub.c |5 - 3 files changed, 33 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S

[Xen-devel] [PATCH RFC 7/7] xen/x86: Build xen.mb.efi directly from xen-syms

2017-07-08 Thread Daniel Kiper
Signed-off-by: Daniel Kiper --- xen/arch/x86/Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 93ead6e..e09f5f4 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -95,6 +95,7 @@ syms-warn-dup

[Xen-devel] [PATCH RFC 4/7] xen/x86: Add some addresses to the Multiboot2 header

2017-07-08 Thread Daniel Kiper
MULTIBOOT2_HEADER_TAG_ENTRY_ADDRESS and MULTIBOOT2_HEADER_TAG_ENTRY_ADDRESS_EFI64 tags close to each other. Signed-off-by: Daniel Kiper --- xen/arch/x86/boot/head.S | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 0c603a5..90db661

[Xen-devel] [PATCH RFC 0/7] Change xen.efi build and add SHIM_LOCK verification into efi_multiboot2()

2017-07-08 Thread Daniel Kiper
/include/xen/compile.h.in |1 + 9 files changed, 245 insertions(+), 22 deletions(-) Daniel Kiper (7): xen: Introduce XEN_COMPILE_POSIX_TIME xen/x86: Manually build PE header xen/x86: Add some addresses to the Multiboot header xen/x86: Add some addresses to the Multiboot2

[Xen-devel] [GRUB2 PATCH RFC 1/1] efi: Add EFI shim lock verifier

2017-07-08 Thread Daniel Kiper
This is based on git://git.savannah.gnu.org/grub.git phcoder/verifiers branch. Just an RFC. TODO: - disable the GRUB2 modules load/unload, - disable the dangerous modules, e.g. iorw, memrw. Signed-off-by: Daniel Kiper --- grub-core/Makefile.core.def|6 +++ grub-core/commands

Re: [Xen-devel] Booting signed xen.efi through shim

2017-09-12 Thread Daniel Kiper
Hi Tamas, On Tue, Sep 12, 2017 at 05:40:35PM -0600, Tamas K Lengyel wrote: > Hi all, > for the last couple weeks I've been poking around the options > available to get Xen booted on a Secureboot enabled box. My goal is to > extend the chain of trust to the dom0 kernel. According to > https://wiki.

Re: [Xen-devel] [Xen-users] UEFI Secure Boot Xen 4.9

2017-09-19 Thread Daniel Kiper
On Mon, Sep 18, 2017 at 11:24:15AM -0400, Tamas K Lengyel wrote: > On Tue, Sep 5, 2017 at 12:26 PM, Tamas K Lengyel > wrote: > > On Mon, Sep 4, 2017 at 6:40 AM, Daniel Kiper > > wrote: > >> On Wed, Aug 30, 2017 at 10:16:23AM -0600, Tamas K Lengyel wrote: > >&

Re: [Xen-devel] Booting signed xen.efi through shim

2017-09-20 Thread Daniel Kiper
On Wed, Sep 20, 2017 at 09:59:51AM -0600, Tamas K Lengyel wrote: > On Wed, Sep 20, 2017 at 9:46 AM, Jan Beulich wrote: > On 20.09.17 at 17:20, wrote: > >> On Wed, Sep 20, 2017 at 12:30 AM, Jan Beulich wrote: > >> On 20.09.17 at 00:23, wrote: > Yeap, the shim pretty simply removed

Re: [Xen-devel] Booting signed xen.efi through shim

2017-09-22 Thread Daniel Kiper
On Fri, Sep 22, 2017 at 02:25:46AM -0600, Jan Beulich wrote: > >>> On 22.09.17 at 00:46, wrote: > > One piece that I see still missing is the Xen command line parameters > > not being verified. It would be ideal to have the option to get that > > set during compile time as well, similar to Linux's

  1   2   3   4   5   6   7   8   9   >