On Mon, Jul 25, 2016 at 4:53 PM, Anthony PERARD
wrote:
> On Sun, Jul 10, 2016 at 02:47:35PM +0300, Emil Condrea wrote:
> > The name of the functions moved:
> > * xen_be_evtchn_event
> > * xen_be_unbind_evtchn
> > * xen_be_send_notify
> >
> > Signed-of
Thanks Anthony for the feedback.
I will send v10 containing fixes for patches 1 to 12 + additional patches
for
fixing code style issues for moved code.
On Mon, Jul 25, 2016 at 5:09 PM, Anthony PERARD
wrote:
> On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emil Condrea wrote:
> > Emil Co
On Mon, Jul 25, 2016 at 7:01 PM, Anthony PERARD
wrote:
>
> On Sun, Jul 10, 2016 at 02:47:46PM +0300, Emil Condrea wrote:
> > This patch adds infrastructure for xen front drivers living in qemu,
> > so drivers don't need to implement common stuff on their own. It's
Fixes:
* WARNING: line over 80 characters
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c | 3 ++-
hw/char/xen_console.c| 6 --
hw/display/xenfb.c | 30 --
hw/net/xen_nic.c | 12
hw/xen/xen_backend.c
Its purpose is to store frontend related functions.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c | 1 +
hw/display/xenfb.c| 1 +
hw/net/xen_nic.c | 1 +
hw/usb/xen-usb.c | 1 +
hw/xen/Makefile.objs | 2
* move xendevs qtail to xen_pvdev.c
* change xen_be_get_xendev to use a new function: xen_pv_insert_xendev
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 51 +-
hw/xen/xen_pvdev.c| 57
The name of the functions moved:
* xen_be_evtchn_event
* xen_be_unbind_evtchn
* xen_be_send_notify
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 35 ---
hw/xen/xen_pvdev.c | 35 +++
include/hw/xen
Fixes the following errors:
* ERROR: line over 90 characters
* ERROR: code indent should never use tabs
* ERROR: space prohibited after that open square bracket '['
* ERROR: do not initialise statics to 0 or NULL
* ERROR: "(foo*)" should be "(foo *)"
Signed-off-
xen_pvdev file.
Emil Condrea (15):
xen: Fix coding style errors
xen: Fix coding style warnings
xen: Create a new file xen_pvdev.c
xen: Create a new file xen_frontend.c
xen: Move xenstore_update to xen_pvdev.c
xen: Move evtchn functions to xen_pvdev.c
xen: Prepare xendev qtail to be shared
Prepare xen_be_send_notify to be shared with frontends:
* xen_be_send_notify -> xen_pv_send_notify
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c| 4 ++--
hw/char/xen_console.c | 4 ++--
hw/display/xenfb.c | 8
hw/net/xen_nic.c | 4 ++--
hw/usb/
The purpose of the new file is to store generic functions shared by frontend
and backends such as xenstore operations, xendevs.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
hw/xen/Makefile.objs | 2 +-
hw/xen/xen_backend.c | 126
Prepare xen_be_find_xendev to be shared with frontends:
* xen_be_find_xendev -> xen_pv_find_xendev
Signed-off-by: Emil Condrea
---
hw/display/xenfb.c | 4 ++--
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
4 files changed
Prepare xen_be_printf to be used by both backend and frontends:
* xen_be_printf -> xen_pv_printf
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c| 58 +++---
hw/char/xen_console.c | 10
hw/display/xenfb.c |
Prepare xen_be_del_xendev to be shared with frontends:
* xen_be_del_xendev -> xen_pv_del_xendev
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --
Prepare xen_be_unbind_evtchn to be shared with frontends:
* xen_be_unbind_evtchn -> xen_pv_unbind_evtchn
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c| 2 +-
hw/char/xen_console.c | 2 +-
hw/display/xenfb.c | 2 +-
hw/net/xen_nic.c | 2 +-
hw/usb/xen-us
xen_be_frontend_changed -> xen_fe_frontend_changed
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_frontend.c | 4 ++--
include/hw/xen/xen_frontend.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_backend.c b/hw/
Prepare xen_be_evtchn_event to be shared with frontends:
* xen_be_evtchn_event -> xen_pv_evtchn_event
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
d
The name of the functions moved to xen_pvdev.c:
* xenstore_cleanup_dir
* xen_config_cleanup
* xenstore_mkdir
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 49 -
hw/xen/xen_pvdev.c | 51
* xenstore_update -> xen_pvdev.c
* xenstore_update_fe -> xen_frontend.c
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 43 +--
hw/xen/xen_frontend.c | 18 ++
hw/xen/xen_pvdev.c
Anthony, I've split the reorganization and code style issues in a separate
patch series which I've posted today:
http://markmail.org/message/feu6u3f7py5vt77v
Thanks
On Mon, Jul 25, 2016 at 5:09 PM, Anthony PERARD
wrote:
> On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emil Condrea w
On Tue, Oct 4, 2016 at 11:06 AM, Paolo Bonzini wrote:
>
>
> On 04/10/2016 08:43, Emil Condrea wrote:
>> xen_be_frontend_changed -> xen_fe_frontend_changed
>
> This is not correct. The front-end is implemented in the guest domain,
> while the back-end is implemented in
tyle warnings" patch.
On Tue, Oct 11, 2016 at 4:56 PM, Anthony PERARD
wrote:
> On Tue, Oct 04, 2016 at 09:43:30AM +0300, Emil Condrea wrote:
>> Fixes the following errors:
>> * ERROR: line over 90 characters
>
> It's 80 ;), and there are a few more left in this patc
On Tue, Oct 11, 2016 at 5:20 PM, Anthony PERARD
wrote:
> On Tue, Oct 04, 2016 at 09:43:31AM +0300, Emil Condrea wrote:
>> Fixes:
>> * WARNING: line over 80 characters
>>
>> Signed-off-by: Emil Condrea
>> ---
>> hw/block/xen_disk.c | 3 ++
xen_pvdev file.
---
Changes in v2:
* fixed parameter alignment when spliting long lines
* removed patches for creating xen_frontend
Emil Condrea (13):
xen: Fix coding style errors
xen: Fix coding style warnings
xen: Create a new file xen_pvdev.c
xen: Move xenstore_update to xen_pvdev.c
xen
The purpose of the new file is to store generic functions shared by frontend
and backends such as xenstore operations, xendevs.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
hw/xen/Makefile.objs | 2 +-
hw/xen/xen_backend.c | 126
The name of the functions moved:
* xen_be_evtchn_event
* xen_be_unbind_evtchn
* xen_be_send_notify
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 35 ---
hw/xen/xen_pvdev.c | 35 +++
include/hw/xen
Prepare xen_be_send_notify to be shared with frontends:
* xen_be_send_notify -> xen_pv_send_notify
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/block/xen_disk.c| 4 ++--
hw/char/xen_console.c | 4 ++--
hw/display/xenfb.c
Prepare xen_be_unbind_evtchn to be shared with frontends:
* xen_be_unbind_evtchn -> xen_pv_unbind_evtchn
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/block/xen_disk.c| 2 +-
hw/char/xen_console.c | 2 +-
hw/display/xenfb.c | 2 +-
Prepare xen_be_find_xendev to be shared with frontends:
* xen_be_find_xendev -> xen_pv_find_xendev
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/display/xenfb.c | 4 ++--
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
incl
Prepare xen_be_del_xendev to be shared with frontends:
* xen_be_del_xendev -> xen_pv_del_xendev
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
3 fi
Fixes:
* WARNING: line over 80 characters
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c | 3 ++-
hw/char/xen_console.c| 6 --
hw/display/xenfb.c | 30 --
hw/net/xen_nic.c | 12
hw/xen/xen_backend.c
* move xendevs qtail to xen_pvdev.c
* change xen_be_get_xendev to use a new function: xen_pv_insert_xendev
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 51 +--
hw/xen/xen_pvdev.c | 57
Fixes the following errors:
* ERROR: line over 90 characters
* ERROR: code indent should never use tabs
* ERROR: space prohibited after that open square bracket '['
* ERROR: do not initialise statics to 0 or NULL
* ERROR: "(foo*)" should be "(foo *)"
Signed-off-
* xenstore_update -> xen_pvdev.c
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 30 +++---
hw/xen/xen_pvdev.c | 23 +++
include/hw/xen/xen_backend.h | 3 +++
include/hw/xen/xen_pvdev.h | 1 +
4 files changed,
Prepare xen_be_printf to be used by both backend and frontends:
* xen_be_printf -> xen_pv_printf
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
---
hw/block/xen_disk.c| 58 +++---
hw/char/xen_console.c | 10
hw/disp
Prepare xen_be_evtchn_event to be shared with frontends:
* xen_be_evtchn_event -> xen_pv_evtchn_event
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
3 fi
The name of the functions moved to xen_pvdev.c:
* xenstore_cleanup_dir
* xen_config_cleanup
* xenstore_mkdir
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
---
hw/xen/xen_backend.c | 49 -
hw/xen/xen_pvdev.c | 51
+ cc Paolo Bonzini
On Thu, Oct 13, 2016 at 9:01 AM, Emil Condrea wrote:
> This patch series was splitted from QEMU:Xen stubdom vTPM for HVM virtual
> machine
> http://markmail.org/message/fkix7g3a5zdj7lvr
>
> It contains a reorganization of xen backend and frontend functions
As you suggested, I've dropped the all patches for xen_frontend.
Emil
On Wed, Oct 12, 2016 at 2:00 PM, Paolo Bonzini wrote:
>
>
> On 09/10/2016 21:50, Emil Condrea wrote:
>> On Tue, Oct 4, 2016 at 11:06 AM, Paolo Bonzini wrote:
>>>
>>>
>&
, Anthony PERARD
wrote:
> On Thu, Oct 13, 2016 at 07:04:56AM +0300, Emil Condrea wrote:
>> On Tue, Oct 11, 2016 at 5:20 PM, Anthony PERARD
>> wrote:
>> > On Tue, Oct 04, 2016 at 09:43:31AM +0300, Emil Condrea wrote:
>> >> Fixes:
>> >> * WARNING: line ov
Prepare xen_be_find_xendev to be shared with frontends:
* xen_be_find_xendev -> xen_pv_find_xendev
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/display/xenfb.c | 4 ++--
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
incl
Fixes:
* WARNING: line over 80 characters
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c | 3 ++-
hw/char/xen_console.c| 3 ++-
hw/display/xenfb.c | 6 --
hw/net/xen_nic.c | 12
hw/xen/xen_backend.c | 15
The purpose of the new file is to store generic functions shared by frontend
and backends such as xenstore operations, xendevs.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
hw/xen/Makefile.objs | 2 +-
hw/xen/xen_backend.c | 126
* xenstore_update -> xen_pvdev.c
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 30 +++---
hw/xen/xen_pvdev.c | 23 +++
include/hw/xen/xen_backend.h | 3 +++
include/hw/xen/xen_pvdev.h | 1 +
4 files changed,
Prepare xen_be_del_xendev to be shared with frontends:
* xen_be_del_xendev -> xen_pv_del_xendev
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
3 fi
The name of the functions moved:
* xen_be_evtchn_event
* xen_be_unbind_evtchn
* xen_be_send_notify
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 35 ---
hw/xen/xen_pvdev.c | 35 +++
include/hw/xen
xen_pvdev file.
---
Changes in v3:
* align second line with first parameter
Changes in v2:
* fixed parameter alignment when spliting long lines
* removed patches for creating xen_frontend
Emil Condrea (13):
xen: Fix coding style errors
xen: Fix coding style warnings
xen: Create a new file
Prepare xen_be_send_notify to be shared with frontends:
* xen_be_send_notify -> xen_pv_send_notify
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/block/xen_disk.c| 4 ++--
hw/char/xen_console.c | 4 ++--
hw/display/xenfb.c
Prepare xen_be_unbind_evtchn to be shared with frontends:
* xen_be_unbind_evtchn -> xen_pv_unbind_evtchn
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/block/xen_disk.c| 2 +-
hw/char/xen_console.c | 2 +-
hw/display/xenfb.c | 2 +-
The name of the functions moved to xen_pvdev.c:
* xenstore_cleanup_dir
* xen_config_cleanup
* xenstore_mkdir
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
---
hw/xen/xen_backend.c | 49 -
hw/xen/xen_pvdev.c | 51
* move xendevs qtail to xen_pvdev.c
* change xen_be_get_xendev to use a new function: xen_pv_insert_xendev
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 51 +--
hw/xen/xen_pvdev.c | 57
Prepare xen_be_printf to be used by both backend and frontends:
* xen_be_printf -> xen_pv_printf
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
---
hw/block/xen_disk.c| 58 +++---
hw/char/xen_console.c | 8 +++
hw/display/xenf
Fixes the following errors:
* ERROR: line over 90 characters
* ERROR: code indent should never use tabs
* ERROR: space prohibited after that open square bracket '['
* ERROR: do not initialise statics to 0 or NULL
* ERROR: "(foo*)" should be "(foo *)"
Signed-off-
Prepare xen_be_evtchn_event to be shared with frontends:
* xen_be_evtchn_event -> xen_pv_evtchn_event
Signed-off-by: Emil Condrea
Acked-by: Anthony PERARD
Reviewed-by: Quan Xu
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
3 fi
I guess you are using pv guests, I don't know exactly if Quan finished
development for hvm.
I suggest to take a look at tcsd log:
pkill tcsd
tcsd -f &
tpm_takeownership -z -y -l debug
Also can you see if /sys/devices/vtpm-0 and /dev/tpm0 are present?
On Wed, Jun 24, 2015 at 6:16 PM, Marcos Simó Pi
my previous email.
>
>
> On the other hand, /sys/devices/vtpm-0 is present, but /etc/tpm0 is not.
>
>
> Thanks for your reply.
>
>
> --
> *De:* Emil Condrea
> *Enviado:* jueves, 25 de junio de 2015 10:21
> *Para:* Marcos Simó Picó
&
ading to Ubuntu 15.04 if that might solve
> the problem.
>
>
> Thanks a lot for your reply again.
> ------
> *De:* Emil Condrea
> *Enviado:* jueves, 25 de junio de 2015 11:22
> *Para:* Marcos Simó Picó
> *Cc:* xen-devel@lists.xen.org
> *Asunto:* R
make sure QEMU machine class is initialized and QEMU has registered
Xen stubdom vTPM driver when call tpm_init()
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
Reviewed-by: Stefan Berger
---
vl.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/vl.c b
ndle event channel between the virtual machines.
Call xen_fe_register() function to register XenDevOps, and make sure,
XenDevOps's flags is DEVOPS_FLAG_FE, which is flag bit to point out
the XenDevOps is Xen frontend.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
Changes in v9:
Prepare xen_be_unbind_evtchn to be shared with frontends:
* xen_be_unbind_evtchn -> xen_pv_unbind_evtchn
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c| 2 +-
hw/char/xen_console.c | 2 +-
hw/display/xenfb.c | 2 +-
hw/net/xen_nic.c | 2 +-
hw/
The name of the functions moved:
* xen_be_evtchn_event
* xen_be_unbind_evtchn
* xen_be_send_notify
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 37 +
hw/xen/xen_pvdev.c | 35 +++
include/hw/xen
Prepare xen_be_evtchn_event to be shared with frontends:
* xen_be_evtchn_event -> xen_pv_evtchn_event
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
d
,
"-tpmdev xenstubdoms,id=xenvtpm0 -device tpm-tis,tpmdev=xenvtpm0"
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
Reviewed-by: Stefan Berger
---
Changes in v9:
* added reset_tpm_established_flag and get_tpm_version for TPMDriverOps
* readded tpm_backend_thread_tpm_reset which w
xen_be_check_state should not be called for frontends
Use DEVOPS_FLAG_FE flag to distinguish a frontend.
Signed-off-by: Emil Condrea
Signed-off-by: Quan Xu
---
Changes in v9:
* Removed not needed strstr from xenstore_update_be
It was left over from first patch series when domu was included in
Its purpose is to store frontend related functions.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c | 1 +
hw/display/xenfb.c| 1 +
hw/net/xen_nic.c | 1 +
hw/xen/Makefile.objs | 2 +-
hw/xen/xen_backend.c | 47
Prepare xen_be_send_notify to be shared with frontends:
* xen_be_send_notify -> xen_pv_send_notify
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c| 4 ++--
hw/char/xen_console.c | 4 ++--
hw/display/xenfb.c | 8
hw/net/xen_nic.c | 4 ++--
hw/
xen_be_frontend_changed -> xen_fe_frontend_changed
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_frontend.c | 4 ++--
include/hw/xen/xen_frontend.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_backend.c b/hw/
Prepare xen_be_find_xendev to be shared with frontends:
* xen_be_find_xendev -> xen_pv_find_xendev
Signed-off-by: Emil Condrea
---
hw/display/xenfb.c | 4 ++--
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
4 files changed
Prepare xen_be_del_xendev to be shared with frontends:
* xen_be_del_xendev -> xen_pv_del_xendev
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 2 +-
hw/xen/xen_pvdev.c | 2 +-
include/hw/xen/xen_pvdev.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --
* move xendevs qtail to xen_pvdev.c
* change xen_be_get_xendev to use a new function: xen_pv_insert_xendev
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 70 +---
hw/xen/xen_pvdev.c| 75
* xenstore_update -> xen_pvdev.c
* xenstore_update_fe -> xen_frontend.c
Signed-off-by: Emil Condrea
---
hw/xen/xen_backend.c | 43 +--
hw/xen/xen_frontend.c | 18 ++
hw/xen/xen_pvdev.c
xen_hvm_init()
[...]
-->xen_fe_register("vtpm", ...)
-->xenstore_fe_scan()
-->xen_fe_try_init(ops)
--> XenDevOps.init()
-->xen_fe_get_xendev()
--> XenDevOps.alloc()
-->xen_fe_check()
-->xen_fe_try_initialise()
-->
Also rename it to tpm_util_is_selftest().
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
Reviewed-by: Stefan Berger
---
hw/tpm/Makefile.objs | 2 +-
hw/tpm/tpm_passthrough.c | 13 +
hw/tpm/tpm_util.c| 11 +++
hw/tpm/tpm_util.h| 1 +
4 files
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
Reviewed-by: Eric Blake
---
Changes in v9:
* Replace `type` with `struct` as required by 895a2a80e
* Change `qpm_query_tpm_inst` as required by ce21131a0
---
configure| 14 ++
hmp.c| 2 ++
qapi-schema.json
)
Emil Condrea (19):
xen: Create a new file xen_pvdev.c
xen: Create a new file xen_frontend.c
xen: Move xenstore_update to xen_pvdev.c
xen: Move evtchn functions to xen_pvdev.c
xen: Prepare xendev qtail to be shared with frontends
xen: Rename xen_be_printf to xen_pv_printf
xen: Rename
The purpose of the new file is to store generic functions shared by frontend
and backends such as xenstore operations, xendevs.
Signed-off-by: Quan Xu
Signed-off-by: Emil Condrea
---
hw/xen/Makefile.objs | 2 +-
hw/xen/xen_backend.c | 125
Prepare xen_be_printf to be used by both backend and frontends:
* xen_be_printf -> xen_pv_printf
Signed-off-by: Emil Condrea
---
hw/block/xen_disk.c| 52 +++---
hw/char/xen_console.c | 10 -
hw/display/xenfb.c |
ring in the same patch. Eventually this can be done in another patch
later.
>
>
>
The purpose of the new file is to store generic functions shared by frontend
> and backends such as xenstore operations, xendevs.
>
> Signed-off-by: Quan Xu
> Signed-off-by: Emil Condrea
> ---
>
ic functions shared by
> frontendand backends such as xenstore operations, xendevs.
> >
>
> s/frontendand/front end and/
>
> Please wrap your commit message lines. Since 'git log' displays logs
> with indentation, wrapping around 72 characters is ideal.
>
&g
Sure, I will continue to send revisions until it is approved upstream.
On Jul 22, 2016 5:24 PM, "Quan Xu" wrote:
> Anthony, thanks for your explaination.
> IMO, patch 1 and patch 2 need your detailed review.. IMO the reset
> patches are good in general..
> Emil, if patch 1 / patch 2 are reviewed
, Daniel De Graaf
wrote:
> On 03/09/2015 11:58 AM, Emil Condrea wrote:
>
>> On Mon, Mar 9, 2015 at 4:40 PM, Daniel De Graaf
>> wrote:
>>
>> On 03/08/2015 07:41 AM, Emil Condrea wrote:
>>>
>>> I am trying to validate a Deep Quote request made by dom
I am trying to validate a Deep Quote request made by domU but I feel that
something is missing. Right now when a domU requests TPM_ORD_DeepQuote:
1. vTPM:
- unpacks the params: nonce, vTPM PCR selection and physical PCR selection
- packs PCR_INFO_SHORT structure into buf that contains the selected
ailto:
> xen-devel-boun...@lists.xen.org] *On Behalf Of *Emil Condrea
> *Sent:* Sunday, March 08, 2015 7:41 PM
> *To:* xen-devel@lists.xen.org
> *Cc:* Daniel De Graaf
> *Subject:* [Xen-devel] vTPM Deep Quote validation
>
>
>
> I am trying to validate a Deep Quote request ma
On Mon, Mar 9, 2015 at 4:40 PM, Daniel De Graaf
wrote:
> On 03/08/2015 07:41 AM, Emil Condrea wrote:
>
>> I am trying to validate a Deep Quote request made by domU but I feel that
>> something is missing. Right now when a domU requests TPM_ORD_DeepQuote:
>> 1. vTPM:
PCRs.
This change also has the benefit of increasing the flexibility of the request.
It is simple to define additional flags and add data to the hash if needed.
Emil Condrea (2):
vtpm: deep quote flags
vtpmmgr: execute deep quote in locality 0
stubdom/Makefile| 1
requested]
)
Signed-off-by: Emil Condrea
---
stubdom/vtpmmgr/marshal.h | 1 +
stubdom/vtpmmgr/mgmt_authority.c | 89 ++
stubdom/vtpmmgr/mgmt_authority.h | 2 +-
stubdom/vtpmmgr/vtpm_cmd_handler.c | 7 ++-
stubdom/vtpmmgr/vtpm_manager.h
Currently, the flags are not interpreted by vTPM. They are just
packed and sent to vtpmmgr. The new implementation is backward
compatible, if it receives a request without flags, it continues
the request to vtpmmgr with extraInfoFlags=0.
Signed-off-by: Emil Condrea
---
stubdom/Makefile
On Mon, Apr 6, 2015 at 6:49 PM, Daniel De Graaf
wrote:
> On 04/05/2015 07:09 AM, Emil Condrea wrote:
>
>> Enables deep quote execution for vtpmmgr which can not be started
>> using locality 2. The VTPM_ORD_GET_QUOTE command is backwards
>> compatible. When receives flag
needed.
Emil Condrea (2):
vtpm: deep quote flags
vtpmmgr: execute deep quote in locality 0
stubdom/Makefile| 1 +
stubdom/vtpm-deepquote-anyloc.patch | 127
stubdom/vtpm/vtpm_cmd.c | 13 ++--
stubdom/vtpmmgr/marshal.h
Currently, the flags are not interpreted by vTPM. They are just
packed and sent to vtpmmgr.
Signed-off-by: Emil Condrea
---
stubdom/Makefile| 1 +
stubdom/vtpm-deepquote-anyloc.patch | 127
stubdom/vtpm/vtpm_cmd.c | 13
values are
appended.
Signed-off-by: Emil Condrea
---
stubdom/vtpmmgr/marshal.h | 1 +
stubdom/vtpmmgr/mgmt_authority.c | 91 ++
stubdom/vtpmmgr/mgmt_authority.h | 2 +-
stubdom/vtpmmgr/vtpm_cmd_handler.c | 7 ++-
stubdom/vtpmmgr/vtpm_manager.h
Thanks! Should it remove it and resend the patches ?
On Wed, Apr 15, 2015 at 6:07 PM, Daniel De Graaf
wrote:
> On 04/14/2015 05:08 AM, Emil Condrea wrote:
>
>> Currently, the flags are not interpreted by vTPM. They are just
>> packed and sent to vtpmmgr.
>>
>&g
at 16:34 +0100, Ian Campbell wrote:
> > On Wed, 2015-04-15 at 18:09 +0300, Emil Condrea wrote:
> > > Thanks! Should it remove it and resend the patches ?
> >
> > I'll do it on commit (which I'm about to do).
>
> Except:
> stubdom/tpm_e
flexibility of the request.
It is simple to define additional flags and add data to the hash if needed.
Emil Condrea (2):
vtpm: deep quote flags
vtpmmgr: execute deep quote in locality 0
stubdom/Makefile| 1 +
stubdom/vtpm-deepquote-anyloc.patch | 127
Currently, the flags are not interpreted by vTPM. They are just
packed and sent to vtpmmgr.
Signed-off-by: Emil Condrea
Acked-by: Daniel De Graaf
---
stubdom/Makefile| 1 +
stubdom/vtpm-deepquote-anyloc.patch | 127
stubdom/vtpm
values are
appended.
Signed-off-by: Emil Condrea
Acked-by: Daniel De Graaf
---
stubdom/vtpmmgr/marshal.h | 1 +
stubdom/vtpmmgr/mgmt_authority.c | 91 ++
stubdom/vtpmmgr/mgmt_authority.h | 2 +-
stubdom/vtpmmgr/vtpm_cmd_handler.c | 7 ++-
stubdom
Thank you!
On Thu, Apr 16, 2015 at 5:10 PM, Ian Campbell
wrote:
> On Wed, 2015-04-15 at 21:00 +0300, Emil Condrea wrote:
> > Changes from v2:
> > - removed useless whitespace
> > - fixed compiling issues for tpm emulato
is disabled and
the TPM might return busy if other commands are currently running.
Thanks.
Emil Condrea
On Sat, Nov 8, 2014 at 1:31 AM, Daniel De Graaf
wrote:
> On 11/07/2014 05:40 AM, Emil Condrea wrote:
>
>> My system does not support DRTM so I can not test this. I am interested in
Thanks.
Emil Condrea
On Sun, Nov 16, 2014 at 9:15 AM, Xu, Quan wrote:
> Emil / Graaf,
> I have verified it, it is still not working when tboot is enabled.
> The attach file is txt-stat log.
> [...]
>
> ***
>
tions:
libxl_device.c:device_backend_callback: unable to remove device with path
/local/domain/...vtpm/58/0
libxl.c:devices_destroy_cb:libxl__devices_destroy failed for 58
What do you think? Is it a good ideea to detach vtpm on destroy? Should I
send a patch with the changes?
Thanks.
Emil Co
100 matches
Mail list logo
