arametrize all the macros
[v3]
* add SYM_DATA_SIMPLE, SYM_DATA_SIMPLE_LOCAL, and SYM_DATA_END_LABEL
Signed-off-by: Jiri Slaby
Cc: Andrew Morton
Cc: Boris Ostrovsky
Cc: h...@zytor.com
Cc: Ingo Molnar
Cc: jpoim...@redhat.com
Cc: Juergen Gross
Cc: Len Brown
Cc: Linus Torvalds
Cc:
There is couple of assembly functions, which are invoked only locally in
a file they are defined. In C, we mark them "static". Annotate them here
using SYM_FUNC_START_LOCAL (and switch their ENDPROC to SYM_FUNC_END
too).
Signed-off-by: Jiri Slaby
Cc: "H. Peter Anvin"
Cc:
object file
So fix this by adding ENDPROC to each such case.
Signed-off-by: Jiri Slaby
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc:
Cc: "Rafael J. Wysocki"
Cc: Pavel Machek
Cc:
Cc: Boris Ostrovsky
Cc: Juergen Gross
Reviewed-by: Juergen Gross [xen p
Somewhere END was used to end a function. It is not intended to be used
for functions, because it does not mark the actual symbols as functions.
Use ENDPROC in such cases which does the right job.
Signed-off-by: Jiri Slaby
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
These are all functions which are invoked from elsewhere, so we annotate
them as global using the new SYM_FUNC_START (and their ENDPROC's by
SYM_FUNC_END.)
Signed-off-by: Jiri Slaby
Cc: "H. Peter Anvin"
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: x...@kernel.org
Cc: Herbert X
These are all functions which are invoked from elsewhere, so we annotate
them as global using the new SYM_FUNC_START (and their ENDPROC's by
SYM_FUNC_END.)
And make sure ENTRY/ENDPROC is not defined on X86_64.
Signed-off-by: Jiri Slaby
Cc: "H. Peter Anvin"
Cc: Thomas Gleixner
.
Signed-off-by: Jiri Slaby
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc:
Cc: Boris Ostrovsky
Cc: Juergen Gross
Reviewed-by: Juergen Gross [xen parts]
Cc:
Cc:
---
arch/x86/crypto/aesni-intel_asm.S | 5 ++---
arch
early_stack
Signed-off-by: Jiri Slaby
Cc: Boris Ostrovsky
Cc: Juergen Gross
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Cc: xen-de...@lists.xenproject.org
---
arch/x86/xen/xen-pvh.S | 11 ++-
1 file changed, 6 insertions(+), 5 deletion
On 04/26/2017, 03:42 AM, Josh Poimboeuf wrote:
>> @@ -323,7 +323,7 @@ ENTRY(resume_userspace)
>> movl%esp, %eax
>> callprepare_exit_to_usermode
>> jmp restore_all
>> -END(ret_from_exception)
>> +ENDPROC(ret_from_exception)
>
> What exactly is the motivation of this patch
On 05/13/2017, 12:15 AM, Josh Poimboeuf wrote:
>> Similarly, I have OBJTOOL(START_FUNC) and OBJTOOL(END_FUNC) emitted with
>> each FUNC_START/FUNC_END. So far, when manually expanded for simplicity,
>> it looks like this:
>
> I like the idea of making objtool smart enough to read the entry code,
>
On 05/17/2017, 03:23 PM, Jiri Slaby wrote:
>> So the initial CFI state is different between the two types of
>> "functions". And there are a lot of other differences. C-type
>> functions have to follow frame pointer conventions, for example. So
>> your FUNC_ST
Hi,
On 10/04/2017, 09:33 AM, Ard Biesheuvel wrote:
> On 4 October 2017 at 08:22, Jiri Slaby wrote:
>> On 10/02/2017, 02:48 PM, Ard Biesheuvel wrote:
>>> On 2 October 2017 at 10:12, Jiri Slaby wrote:
>>>> There is a couple of assembly functions, which are invoked
On 10/06/2017, 04:01 PM, Ard Biesheuvel wrote:
> On 6 October 2017 at 13:53, Jiri Slaby wrote:
>> On 10/04/2017, 09:33 AM, Ard Biesheuvel wrote:
>>> In arm64, we use ENTRY/ENDPROC for functions with external linkage,
>>> and the bare symbol name/ENDPROC for func
On 10/06/2017, 05:23 PM, Josh Poimboeuf wrote:
> On Mon, Oct 02, 2017 at 11:12:20AM +0200, Jiri Slaby wrote:
>>SYM_CODE_INNER_LABEL -- only for labels in the middle of code
>>SYM_CODE_INNER_LABEL_NOALIGN -- only for labels in the middle of code
>
> Why are the in
Hi,
On 10/06/2017, 03:21 PM, Mark Rutland wrote:
> If the aim of this series is to introduce something that architectures
> use consistently, then can we please actually poke other architectures
> about it? e.g. send this to linux-arch, with a cover letter explaining
> the idea and asking maintain
.
Signed-off-by: Jiri Slaby
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc:
Cc: Boris Ostrovsky
Cc: Juergen Gross
Reviewed-by: Juergen Gross [xen parts]
Cc:
Cc:
---
arch/x86/crypto/aesni-intel_asm.S | 5 ++---
arch
These are all functions which are invoked from elsewhere, so we annotate
them as global using the new SYM_FUNC_START. And their ENDPROC's by
SYM_FUNC_END.
And make sure ENTRY/ENDPROC is not defined on X86_64, given these were
the last users.
Signed-off-by: Jiri Slaby
Cc: "H. Peter
All these are functions which are invoked from elsewhere, but they are
not typical C functions. So we annotate them (as global) using the new
SYM_CODE_START. All these were not balanced with any END, so mark their
ends by SYM_CODE_END, appropriatelly.
Signed-off-by: Jiri Slaby
Cc: Thomas
/END for a particular function (C or non-C).
Signed-off-by: Jiri Slaby
Cc: "H. Peter Anvin"
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: x...@kernel.org
Cc: Matt Fleming
Cc: Ard Biesheuvel
Cc: linux-...@vger.kernel.org
Cc: xen-de...@lists.xenproject.org
---
arch/x86/boot/compressed
early_stack
Signed-off-by: Jiri Slaby
Cc: Boris Ostrovsky
Cc: Juergen Gross
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Cc: xen-de...@lists.xenproject.org
---
arch/x86/xen/xen-pvh.S | 11 ++-
1 file changed, 6 insertions(+), 5 deletion
YM_END and parametrize all the macros
[v3]
* add SYM_DATA_SIMPLE, SYM_DATA_SIMPLE_LOCAL, and SYM_DATA_END_LABEL
[v4]
* add _NOALIGN versions of some macros
* add _CODE_ derivates of _FUNC_ macros
Signed-off-by: Jiri Slaby
Cc: Andrew Morton
Cc: Boris Ostrovsky
Cc: h...@zytor.com
Cc: Ingo Molnar
All these are functions which are invoked from elsewhere, but they are
not typical C functions. So we annotate them (as global) using the new
SYM_CODE_START. All these were not balanced with any END, so mark their
ends by SYM_CODE_END, appropriatelly.
Signed-off-by: Jiri Slaby
Cc: Boris
Here, we change all code which is not marked as functions. In other
words, this code has been using END, not ENDPROC. So switch all of this
to appropriate new markings SYM_CODE_START and SYM_CODE_END.
Signed-off-by: Jiri Slaby
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin&qu
On 10/02/2017, 02:48 PM, Ard Biesheuvel wrote:
> On 2 October 2017 at 10:12, Jiri Slaby wrote:
>> There is a couple of assembly functions, which are invoked only locally
>> in the file they are defined. In C, we mark them "static". In assembly,
>> annotate them us
On 03/22/2017, 04:44 PM, Jiri Slaby wrote:
> On 03/22/2017, 03:26 PM, Josh Poimboeuf wrote:
>> On Mon, Mar 20, 2017 at 01:32:15PM +0100, Jiri Slaby wrote:
>>> Somewhere END was used to end a function, elsewhere, nothing was used.
>>> So unify it and mark them all by S
On 04/10/2017, 09:35 PM, Josh Poimboeuf wrote:
> The code should be in a mergeable state after each patch. If only
> patches 1-3 were merged, the code would be in an inconsistent state,
> with some functions having confusing ENTRY/SYM_FUNC_END pairs. That
> complicates git history and also makes
on 4 locations.
Signed-off-by: Jiri Slaby
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc:
Cc: Boris Ostrovsky
Cc: Juergen Gross
Cc:
Cc: "Rafael J. Wysocki"
Cc: Len Brown
Cc: Pavel Machek
Cc:
---
arch/x86/kernel/acpi/wakeup_64.S | 14 +++---
arc
_key_expansion_128 is an alias to _key_expansion_256a, __memcpy to
memcpy, xen_syscall32_target to xen_sysenter_target, and so on. Annotate
them all using the new ENTRY_ALIAS and ENTRY_LOCAL_ALIAS. This will make
the tools generating the debuginfo happy.
Signed-off-by: Jiri Slaby
Cc: Herbert Xu
Somewhere END was used to end a function, elsewhere, nothing was used.
So unify it and mark them all by ENDPROC.
Signed-off-by: Jiri Slaby
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc:
Cc: "Rafael J. Wysocki"
Cc: Pavel Machek
Cc:
Cc: Boris Ostrovsky
C
On 03/01/2017, 10:38 AM, Ingo Molnar wrote:
> Agreed?
Sure. I wanted to keep it minimal to see if you agree with this
direction at all. No problem to be more intrusive :).
thanks,
--
js
suse labs
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http
On 11/21/2016, 04:22 PM, Thomas Deutschmann wrote:
> Hi,
>
> the following patch is present in the following LTS kernels
>
>> =linux-3.2.81
>> =linux-3.16.36
>> =linux-3.18.33
>> =linux-4.1.24
>> =linux-4.4.9
>
>
> however it is missing from LTS kernels
>
> - linux-3.4
> - linux-3.10
> - linux
http://lkml.kernel.org/r/57188ed80278000e4...@prv-mh.provo.novell.com
Signed-off-by: Ingo Molnar
Signed-off-by: Jiri Slaby
---
arch/x86/include/asm/hugetlb.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/include/asm/hugetlb.h b/arch/x86/include/asm/hugetlb.h
index 68c05398bba9..7aadd3c
org/r/57188ed80278000e4...@prv-mh.provo.novell.com
Signed-off-by: Ingo Molnar
Signed-off-by: Jiri Slaby
---
arch/x86/include/asm/hugetlb.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/include/asm/hugetlb.h b/arch/x86/include/asm/hugetlb.h
index 68c05398bba9..7aadd3cea843 100644
--- a/arc
On 03/01/2017, 11:27 AM, Ingo Molnar wrote:
> But no strong feelings either way, I just try to sneak in these small
> namespace
> structure tricks when nobody's looking! ;-)
So I assume to introduce two underscores.
thanks,
--
js
suse labs
___
Xen-d
On 03/03/2017, 07:20 PM, h...@zytor.com wrote:
> On March 1, 2017 2:27:54 AM PST, Ingo Molnar wrote:
>>
>> * Thomas Gleixner wrote:
>>
>>> On Wed, 1 Mar 2017, Ingo Molnar wrote:
>>>>
>>>> * Jiri Slaby wrote:
>>>>
>>>
SYM_ALIAS_END -- the end of LOCALALIASed or ALIASed code
SYM_FUNCTION_END -- the end of SYM_LOCAL_FUNC_START, SYM_FUNCTION_START,
SYM_WEAK_FUNC_START, ...
SYM_DATA_START -- global data symbol
SYM_DATA_END -- the end of SYM_DATA_START symbol
Signed-off-by: Jiri Slaby
Cc: Andrew Morton
Cc: Boris Ostrovsky
On 03/16/2017, 09:02 AM, Ingo Molnar wrote:
>
> * Jiri Slaby wrote:
>
>> SYM_LOCAL_ALIAS_START -- use where there are two local names for one code
>> SYM_ALIAS_START -- use where there are two global names for one code
>> SYM_LOCAL_FUNC_START -- use for local func
.
Signed-off-by: Jiri Slaby
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc:
Cc: Boris Ostrovsky
Cc: Juergen Gross
Reviewed-by: Juergen Gross [xen parts]
Cc:
Cc:
---
arch/x86/crypto/aesni-intel_asm.S | 5 ++---
arch
Somewhere END was used to end a function, elsewhere, nothing was used.
So unify it and mark them all by SYM_FUNC_END.
Signed-off-by: Jiri Slaby
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc:
Cc: "Rafael J. Wysocki"
Cc: Pavel Machek
Cc:
Cc: Boris Ostrovsk
. Automatically at best.
This particular patch makes proper use of SYM_DATA_START on data and
SYM_FUNC_START on a function which was not the case on 4 locations.
Signed-off-by: Jiri Slaby
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc:
Cc: Boris Ostrovsky
Cc: Jue
* use SYM_ prefix and sane names
* add SYM_START and SYM_END and parametrize all the macros
Signed-off-by: Jiri Slaby
Cc: Andrew Morton
Cc: Boris Ostrovsky
Cc: h...@zytor.com
Cc: Ingo Molnar
Cc: jpoim...@redhat.com
Cc: Juergen Gross
Cc: Len Brown
Cc: Linus Torvalds
Cc: linux-ker...@vger.ker
On 03/20/2017, 02:32 PM, Josh Poimboeuf wrote:
> On Mon, Mar 20, 2017 at 01:32:14PM +0100, Jiri Slaby wrote:
>> This is a start of series to cleanup macros used for starting functions,
>> data, globals etc. across x86. When we have all this sorted out, this
>> will help to i
On 03/22/2017, 08:25 AM, Ingo Molnar wrote:
>
> * Pavel Machek wrote:
>
>> Hi!
>>
>>> -ENTRY(saved_rbp) .quad 0
>>> -ENTRY(saved_rsi) .quad 0
>>> -ENTRY(saved_rdi) .quad 0
>>> -ENTRY(saved_rbx) .quad 0
>>> +SYM_DATA_START(saved_rbp) .quad 0
>>> +SYM_DATA_START(saved_rs
Hi,
On 03/21/2017, 03:08 PM, Pavel Machek wrote:
>> -ENTRY(saved_rbp).quad 0
>> -ENTRY(saved_rsi).quad 0
>> -ENTRY(saved_rdi).quad 0
>> -ENTRY(saved_rbx).quad 0
>> +SYM_DATA_START(saved_rbp) .quad 0
>> +SYM_DATA_START(saved_rsi) .quad 0
>> +SYM_DATA_
On 03/22/2017, 03:11 PM, Josh Poimboeuf wrote:
> Or, here's a much easier way to do it, without involving objtool:
>
> --- a/include/linux/linkage.h
> +++ b/include/linux/linkage.h
> @@ -138,9 +138,17 @@
> name:
> #endif
>
> +#ifndef CHECK_DUP_SYM_END
> +#define CHECK_DUP_SYM_END(name)
On 03/22/2017, 03:26 PM, Josh Poimboeuf wrote:
> On Mon, Mar 20, 2017 at 01:32:15PM +0100, Jiri Slaby wrote:
>> Somewhere END was used to end a function, elsewhere, nothing was used.
>> So unify it and mark them all by SYM_FUNC_END.
>>
>> Signed-off-by: Jiri Slaby
>
vnet.ibm.com
Cc: david.vra...@citrix.com
Cc: sanje...@broadcom.com
Cc: siva.kal...@broadcom.com
Cc: vyasev...@gmail.com
Cc: xen-de...@lists.xensource.com
Link: http://lkml.kernel.org/r/20150417190448.ga9...@l.oracle.com
Signed-off-by: Ingo Molnar
Signed-off-by: Jiri Slaby
---
arch/x86/Kconfig | 2 +-
1
On 03/16/2016, 10:25 AM, Jan Beulich wrote:
> Hello,
>
> it's been puzzling me for a while that these fixes, despite having the
> necessary Cc, did not make it into (at least) 4.1.y and 3.12.y yet.
> Unless there's a specific reason, may I ask for inclusion of
>
> CVE-2015-8550 / XSA-155:
>
> 45
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 05/25/2015, 02:56 AM, Ben Hutchings wrote:
> This fix appears to be needed in all stable branches:
>
> commit a6dfa128ce5c414ab46b1d690f7a1b8decb8526d Author: Konrad
> Rzeszutek Wilk Date: Fri Apr 17 15:04:48
> 2015 -0400
>
> config: Enable N
.com
Cc: casca...@linux.vnet.ibm.com
Cc: david.vra...@citrix.com
Cc: sanje...@broadcom.com
Cc: siva.kal...@broadcom.com
Cc: vyasev...@gmail.com
Cc: xen-de...@lists.xensource.com
Link: http://lkml.kernel.org/r/20150417190448.ga9...@l.oracle.com
Signed-off-by: Ingo Molnar
Signed-off-by: Jiri Slaby
---
ar
-6927-1-git-send-email-andrew.coop...@citrix.com
Signed-off-by: Thomas Gleixner
Signed-off-by: Jiri Slaby
---
arch/x86/kernel/cpu/common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 6db4828574ef..9364936b47c2
-andrew.coop...@citrix.com
Signed-off-by: Thomas Gleixner
Signed-off-by: Jiri Slaby
---
arch/x86/kernel/cpu/common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 6db4828574ef..9364936b47c2 100644
--- a/arch/x86
teven Rostedt
Cc: Thomas Gleixner
Cc: secur...@kernel.org
Cc: xen-devel
Link:
http://lkml.kernel.org/r/0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.l...@kernel.org
Signed-off-by: Ingo Molnar
Signed-off-by: Jiri Slaby
---
arch/x86/xen/enlighten.c | 40 +++
homas Gleixner
Cc: secur...@kernel.org
Cc: xen-devel
Link:
http://lkml.kernel.org/r/0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.l...@kernel.org
Signed-off-by: Ingo Molnar
Signed-off-by: Jiri Slaby
---
arch/x86/xen/enlighten.c | 40
1 file change
On 01/26/2015, 11:53 AM, Ian Campbell wrote:
> On Fri, 2014-11-21 at 17:00 +, Stefano Stabellini wrote:
>> Need to pass the pointer within the swiotlb internal buffer to the
>> swiotlb library, that in the case of xen_unmap_single is dev_addr, not
>> paddr.
>>
>> Signed-off-by: Stefano Stabelli
55 matches
Mail list logo
