[Xen-devel] [PATCH RFC 7/7] tools/tests: Remove superfluous and incomplete spinlock from xen-access

2014-11-12 Thread Tamas K Lengyel
on the behavior of the system. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- tools/tests/xen-access/xen-access.c | 68 - 1 file changed, 6 insertions(+), 62 deletions(-) diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c

[Xen-devel] [PATCH RFC 2/7] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'

2014-11-12 Thread Tamas K Lengyel
The name of the ring still implies it is used only for memory accesses, which is no longer the case. It is also used to deliver variuos HVM events, thus the name monitor is more appropriate in this setting. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- tools/libxc

[Xen-devel] [PATCH RFC 0/7] xen: Clean-up of mem_event subsystem

2014-11-12 Thread Tamas K Lengyel
RFC series is also available at: https://github.com/tklengyel/xen/tree/mem_event_cleanup Razvan Cojocaru (1): xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel (6): xen/mem_event: Rename the mem_event ring from 'access' to 'monitor' xen/mem_paging: Convert mem_event_op

[Xen-devel] [PATCH RFC 6/7] xen/vm_event: Decouple vm_event and mem_access.

2014-11-12 Thread Tamas K Lengyel
needs to be supported in order to enable vm_event. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/common/Makefile| 2 +- xen/include/xen/vm_event.h | 58 +- xen/include/xsm/dummy.h| 2 -- xen/include/xsm/xsm.h | 2

[Xen-devel] [PATCH RFC 4/7] x86/hvm: rename hvm_memory_event_* functions to hvm_event_*

2014-11-12 Thread Tamas K Lengyel
-by: Tamas K Lengyel tamas.leng...@zentific.com --- docs/misc/pvh-readme.txt | 2 +- xen/arch/x86/hvm/hvm.c| 50 +-- xen/arch/x86/hvm/vmx/vmx.c| 6 +++--- xen/include/asm-x86/hvm/hvm.h | 12 +-- 4 files changed, 35 insertions(+), 35

Re: [Xen-devel] [PATCH RFC 1/7] xen/mem_event: Cleanup of mem_event structures

2014-11-13 Thread Tamas K Lengyel
On Wed, Nov 12, 2014 at 4:58 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 12/11/14 15:31, Tamas K Lengyel wrote: diff --git a/xen/include/public/mem_event.h b/xen/include/public/mem_event.h index 599f9e8..c0e9394 100644 --- a/xen/include/public/mem_event.h +++ b/xen/include

Re: [Xen-devel] [PATCH RFC 0/7] xen: Clean-up of mem_event subsystem

2014-11-18 Thread Tamas K Lengyel
On Tue, Nov 18, 2014 at 8:32 AM, Jan Beulich jbeul...@suse.com wrote: On 17.11.14 at 18:06, tamas.leng...@zentific.com wrote: On Mon, Nov 17, 2014 at 5:37 PM, Jan Beulich jbeul...@suse.com wrote: On 12.11.14 at 16:48, andrew.coop...@citrix.com wrote: On 12/11/14 15:31, Tamas K Lengyel

Re: [Xen-devel] [v8][PATCH 13/17] xen/mem_access: don't allow accessing reserved device memory

2014-12-18 Thread Tamas K Lengyel
I agree with Julien below, this should probably be put into the p2m layer. The ARM definition of the function could then simply be an inline definition that just returns 0. Tamas On Tue, Dec 2, 2014 at 9:54 AM, Julien Grall julien.gr...@linaro.org wrote: Hi, CC Tamas as he did some work on

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 1:43 PM, Tim Deegan t...@xen.org wrote: Hi, At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote: From: Razvan Cojocaru rcojoc...@bitdefender.com The public mem_event structures used to communicate with helper applications via shared rings have been used

Re: [Xen-devel] [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 1:53 PM, Tim Deegan t...@xen.org wrote: At 16:17 +0100 on 18 Jan (1421594275), Tamas K Lengyel wrote: The name of the ring still implies it is used only for memory accesses, which is no longer the case. It is also used to deliver variuos HVM events, thus the name

Re: [Xen-devel] [RFC PATCH V3 10/12] xen: Introduce monitor_op domctl

2015-02-05 Thread Tamas K Lengyel
+int monitor_domctl(struct xen_domctl_monitor_op *domctl, struct domain *d) +{ +/* + * At the moment only HVM domains are supported. However, event delivery + * could be extended to PV domains. See comments below. + */ +if ( !is_hvm_domain(d) ) +return -ENOSYS;

Re: [Xen-devel] [RFC PATCH V3 02/12] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'

2015-02-05 Thread Tamas K Lengyel
On Tue, Feb 3, 2015 at 4:37 PM, Jan Beulich jbeul...@suse.com wrote: On 29.01.15 at 22:46, tamas.leng...@zentific.com wrote: -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS2 +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR2 While this one looks okay, ...

Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-05 Thread Tamas K Lengyel
On Mon, Feb 2, 2015 at 6:19 PM, Ian Campbell ian.campb...@citrix.com wrote: On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote: From: Razvan Cojocaru rcojoc...@bitdefender.com The public mem_event structures used to communicate with helper applications via shared rings have been used

Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-05 Thread Tamas K Lengyel
On Tue, Feb 3, 2015 at 10:17 AM, Jan Beulich jbeul...@suse.com wrote: On 02.02.15 at 18:19, ian.campb...@citrix.com wrote: On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote: +union { +struct mem_event_paging_datamem_paging; +struct

Re: [Xen-devel] [RFC PATCH V3 05/12] xen: Introduce vm_event

2015-02-06 Thread Tamas K Lengyel
On Mon, Feb 2, 2015 at 8:35 PM, Daniel De Graaf dgde...@tycho.nsa.gov wrote: On 01/31/2015 08:24 AM, Tamas K Lengyel wrote: On Fri, Jan 30, 2015 at 6:25 PM, Daniel De Graaf dgde...@tycho.nsa.gov wrote: On 01/29/2015 04:46 PM, Tamas K Lengyel wrote: To make it easier to review the renaming

Re: [Xen-devel] [RFC PATCH V3 05/12] xen: Introduce vm_event

2015-02-06 Thread Tamas K Lengyel
On Fri, Feb 6, 2015 at 2:58 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 06/02/15 13:54, Tamas K Lengyel wrote: Please clarify in the patch description whether this (and perhaps other) copied or cloned code is really just a plain copy with some renaming, or whether there are any other

Re: [Xen-devel] [RFC PATCH V3 07/12] xen: Remove mem_event

2015-02-06 Thread Tamas K Lengyel
Did you look at the resulting patch to see what happened? It didn't remove the mem_event stuff, but adjusted it enough to become the vm_event one while removing the previously added vm_event part again. Another argument against this approach imo. Jan Hm, that is some strange git behavior.

Re: [Xen-devel] [RFC PATCH V3 11/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-06 Thread Tamas K Lengyel
On Wed, Feb 4, 2015 at 10:47 AM, Jan Beulich jbeul...@suse.com wrote: On 29.01.15 at 22:46, tamas.leng...@zentific.com wrote: --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -52,9 +52,10 @@ obj-y += tmem_xen.o obj-y += radix-tree.o obj-y += rbtree.o obj-y += lzo.o +obj-y +=

Re: [Xen-devel] [RFC PATCH V3 12/12] xen/vm_event: Check for VM_EVENT_FLAG_DUMMY only in Debug builds

2015-02-06 Thread Tamas K Lengyel
On Wed, Feb 4, 2015 at 6:59 AM, Tian, Kevin kevin.t...@intel.com wrote: From: Tamas K Lengyel [mailto:tamas.leng...@zentific.com] Sent: Friday, January 30, 2015 5:47 AM The flag is only used for debugging purposes, thus it should be only checked for in debug builds of Xen. Signed-off

Re: [Xen-devel] [RFC PATCH V3 05/12] xen: Introduce vm_event

2015-02-06 Thread Tamas K Lengyel
On Tue, Feb 3, 2015 at 4:54 PM, Jan Beulich jbeul...@suse.com wrote: On 29.01.15 at 22:46, tamas.leng...@zentific.com wrote: --- a/docs/misc/xsm-flask.txt +++ b/docs/misc/xsm-flask.txt @@ -87,6 +87,7 @@ __HYPERVISOR_domctl (xen/include/public/domctl.h) * XEN_DOMCTL_set_machine_address_size

Re: [Xen-devel] [RFC PATCH V3 12/12] xen/vm_event: Check for VM_EVENT_FLAG_DUMMY only in Debug builds

2015-02-06 Thread Tamas K Lengyel
On Wed, Feb 4, 2015 at 10:49 AM, Jan Beulich jbeul...@suse.com wrote: On 29.01.15 at 22:46, tamas.leng...@zentific.com wrote: The flag is only used for debugging purposes, thus it should be only checked for in debug builds of Xen. So this should be where the respective conditional I just

Re: [Xen-devel] [RFC PATCH V3 07/12] xen: Remove mem_event

2015-02-06 Thread Tamas K Lengyel
On Fri, Feb 6, 2015 at 3:18 PM, Jan Beulich jbeul...@suse.com wrote: On 06.02.15 at 13:54, tamas.leng...@zentific.com wrote: Did you look at the resulting patch to see what happened? It didn't remove the mem_event stuff, but adjusted it enough to become the vm_event one while removing the

Re: [Xen-devel] [RFC PATCH V3 11/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-06 Thread Tamas K Lengyel
On Fri, Feb 6, 2015 at 3:20 PM, Jan Beulich jbeul...@suse.com wrote: On 06.02.15 at 14:10, tamas.leng...@zentific.com wrote: On Wed, Feb 4, 2015 at 10:47 AM, Jan Beulich jbeul...@suse.com wrote: On 29.01.15 at 22:46, tamas.leng...@zentific.com wrote: --- a/xen/common/Makefile +++

Re: [Xen-devel] [RFC PATCH V2 3/8] xen/mem_paging: Convert mem_event_op to mem_paging_op

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 4:09 PM, Jan Beulich jbeul...@suse.com wrote: On 18.01.15 at 16:17, tamas.leng...@zentific.com wrote: --- a/xen/arch/x86/mm/mem_paging.c +++ b/xen/arch/x86/mm/mem_paging.c @@ -25,31 +25,31 @@ #include xen/mem_event.h -int mem_paging_memop(struct domain *d,

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 5:00 PM, Jan Beulich jbeul...@suse.com wrote: On 22.01.15 at 16:34, tamas.leng...@zentific.com wrote: On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich jbeul...@suse.com wrote: On 18.01.15 at 16:17, tamas.leng...@zentific.com wrote: --- a/xen/include/public/mem_event.h +++

Re: [Xen-devel] [RFC PATCH V2 5/8] xen/mem_event: Rename mem_event to vm_event

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 3:52 PM, Tim Deegan t...@xen.org wrote: At 16:17 +0100 on 18 Jan (1421594278), Tamas K Lengyel wrote: The mem_event system has originally been used to deliver memory event related information to helper programs located in a domain. However, the usage of this sub-system

Re: [Xen-devel] [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access.

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 3:56 PM, Tim Deegan t...@xen.org wrote: At 16:17 +0100 on 18 Jan (1421594279), Tamas K Lengyel wrote: The vm_event subsystem has been artifically tied to the presence of mem_access. While mem_access does depend on vm_event, vm_event is an entirely independent

Re: [Xen-devel] [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 4:00 PM, Tim Deegan t...@xen.org wrote: At 16:18 +0100 on 18 Jan (1421594281), Tamas K Lengyel wrote: To avoid growing hvm.c these functions can be stored separately. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Assuming this is just code motion

Re: [Xen-devel] [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 4:02 PM, Jan Beulich jbeul...@suse.com wrote: On 18.01.15 at 16:17, tamas.leng...@zentific.com wrote: --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -775,7 +775,7 @@ struct xen_domctl_gdbsx_domstatus { #define

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich jbeul...@suse.com wrote: On 18.01.15 at 16:17, tamas.leng...@zentific.com wrote: --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) all: headers.chk -headers.chk: $(filter-out

Re: [Xen-devel] [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem

2015-01-21 Thread Tamas K Lengyel
I also wonder whether it might be easier to organise the series along the lines of introducing vm_event, move the existing interfaces across, then deleting mem_event. Lets see how easy it is to review in its current form first though. ~Andrew Ack, that indeed might be easier to review. I'm

[Xen-devel] [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem

2015-01-18 Thread Tamas K Lengyel
. This RFC PATCH series is also available at: https://github.com/tklengyel/xen/tree/mem_event_cleanup2 Razvan Cojocaru (1): xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel (7): xen/mem_event: Rename the mem_event ring from 'access' to 'monitor' xen/mem_paging: Convert

[Xen-devel] [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file

2015-01-18 Thread Tamas K Lengyel
To avoid growing hvm.c these functions can be stored separately. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/arch/x86/hvm/Makefile | 3 +- xen/arch/x86/hvm/event.c| 195 xen/arch/x86/hvm/hvm.c | 163

[Xen-devel] [RFC PATCH V2 6/8] xen/vm_event: Decouple vm_event and mem_access.

2015-01-18 Thread Tamas K Lengyel
needs to be supported in order to enable vm_event. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/common/Makefile| 2 +- xen/include/xen/vm_event.h | 56 -- xen/include/xsm/dummy.h| 2 -- xen/include/xsm/xsm.h | 2

[Xen-devel] [RFC PATCH V2 7/8] tools/tests: Clean-up tools/tests/xen-access

2015-01-18 Thread Tamas K Lengyel
on the behavior of the system. Also converting functions that always return 0 to return to void, and making the teardown function actually return an error code on error. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- tools/tests/xen-access/xen-access.c | 99

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-16 Thread Tamas K Lengyel
On Thu, Jan 15, 2015 at 6:31 PM, Ed White edmund.h.wh...@intel.com wrote: On 01/15/2015 02:39 AM, Tamas K Lengyel wrote: There are ways of avoiding the single-step too, although I don't think that falls within the scope of this conversation. Ed I would be very interested in knowing how we

Re: [Xen-devel] [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 5:25 PM, Jan Beulich jbeul...@suse.com wrote: On 18.01.15 at 16:18, tamas.leng...@zentific.com wrote: +static int hvm_event_traps(long parameters, vm_event_request_t *req) +{ +int rc; +struct vcpu *v = current; +struct domain *d = v-domain; Unless the

Re: [Xen-devel] [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 5:32 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 18/01/15 15:18, Tamas K Lengyel wrote: -void hvm_event_cr0(unsigned long value, unsigned long old) -{ -vm_event_request_t req = { -.reason = VM_EVENT_REASON_CR0, -.vcpu_id = current-vcpu_id

Re: [Xen-devel] [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_*

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 4:56 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 18/01/15 15:17, Tamas K Lengyel wrote: The function names currently imply that these events are to be delivered via the memory_event subsystem. However, the naming is confusing as these events have nothing to do

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich jbeul...@suse.com wrote: Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 2:51 PM On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich jbeul...@suse.com wrote: On 09.02.15 at 19:53, tamas.leng...@zentific.com wrote: @@ -598,6 +600,12 @@ int

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 6:39 PM, Jan Beulich jbeul...@suse.com wrote: Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 5:38 PM On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich jbeul...@suse.com wrote: Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 2:51 PM On Tue, Feb 10, 2015 at 1:52 PM

[Xen-devel] [PATCH V6 10/13] xen/vm_event: Decouple vm_event and mem_access.

2015-02-17 Thread Tamas K Lengyel
the corresponding vCPU. This approach reduces code duplication and present a single point of entry for the entire vm_event subsystem's response handling mechanism. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Daniel De Graaf dgde...@tycho.nsa.gov --- v4: Consolidate resume routines

[Xen-devel] [PATCH V6 06/13] tools/tests: Clean-up tools/tests/xen-access

2015-02-17 Thread Tamas K Lengyel
on the behavior of the system. Also converting functions that always return 0 to return to void, and making the teardown function actually return an error code on error. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Ian Campbell ian.campb...@citrix.com --- v5: Process all requests

[Xen-devel] [PATCH V6 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-17 Thread Tamas K Lengyel
. This patch remedies the issue by clearly defining the structure members based on the actual context within which the structure is used. Signed-off-by: Razvan Cojocaru rcojoc...@bitdefender.com Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- v6: Keep gfn's uint64_t and use unsigned

[Xen-devel] [PATCH V6 09/13] xen/vm_event: Deprecate VM_EVENT_FLAG_DUMMY flag

2015-02-17 Thread Tamas K Lengyel
There are no use-cases for this flag. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/arch/x86/mm/mem_sharing.c | 3 --- xen/arch/x86/mm/p2m.c | 3 --- xen/common/mem_access.c | 3 --- xen/include/public/vm_event.h | 1 - 4 files changed, 10 deletions(-) diff

[Xen-devel] [PATCH V6 03/13] xen/mem_paging: Convert mem_event_op to mem_paging_op and cleanup

2015-02-17 Thread Tamas K Lengyel
a bit. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Tim Deegan t...@xen.org Acked-by: Ian Campbell ian.campb...@citrix.com Acked-by: Jan Beulich jbeul...@suse.com --- v6: Make gfn's explicitily 64-bit in the toolstack v5: Style fixes v4: Style fixes v3: Style fixes --- tools

[Xen-devel] [PATCH V6 11/13] xen/vm_event: Relocate memop checks

2015-02-17 Thread Tamas K Lengyel
it consistent. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Reviewed-by: Andrew Cooper andrew.coop...@citrix.com --- v6: Don't pass superfluous cmd to the memops. Unlock rcu's in sharing/paging Style fixes --- xen/arch/x86/mm/mem_paging.c | 44 +++--- xen/arch/x86/mm

[Xen-devel] [PATCH V6 05/13] xen/vm_event: Style fixes

2015-02-17 Thread Tamas K Lengyel
Fix style issues left over from the renaming to vm_event and other minor alignment issues. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/common/vm_event.c | 36 +++- xen/include/xen/vm_event.h | 18 +- 2 files changed, 20

[Xen-devel] [PATCH V6 12/13] xen/xsm: Split vm_event_op into three separate labels

2015-02-17 Thread Tamas K Lengyel
-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Daniel De Graaf dgde...@tycho.nsa.gov Reviewed-by: Andrew Cooper andrew.coop...@citrix.com --- xen/arch/x86/mm/mem_paging.c| 2 +- xen/arch/x86/mm/mem_sharing.c | 2 +- xen/common/mem_access.c | 2 +- xen/include

[Xen-devel] [PATCH V6 07/13] x86/hvm: factor out and rename vm_event related functions

2015-02-17 Thread Tamas K Lengyel
To avoid growing hvm.c these functions can be stored separately. Minor style changes are applied to the logic in the file. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Kevin Tian kevin.t...@intel.com --- v6: Style fixes v5: Style fixes Fix hvm_event_msr input types

[Xen-devel] [PATCH V6 04/13] xen: Rename mem_event to vm_event

2015-02-17 Thread Tamas K Lengyel
applications when encountering various events during a VM's execution. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Daniel De Graaf dgde...@tycho.nsa.gov Acked-by: Jan Beulich jbeul...@suse.com Acked-by: Wei Liu wei.l...@citrix.com --- v5: Rebased on master v4: Using git -M

[Xen-devel] [PATCH V6 08/13] xen: Introduce monitor_op domctl

2015-02-17 Thread Tamas K Lengyel
-by: Andrew Cooper andrew.coop...@citrix.com Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Ian Campbell ian.campb...@citrix.com Acked-by: Kevin Tian kevin.t...@intel.com Acked-by: Daniel De Graaf dgde...@tycho.nsa.gov --- v6: Convert monitor control fields to bool_t both in Xen

[Xen-devel] [PATCH V6 02/13] xen/mem_event: Cleanup mem_event names in rings, functions and domctls

2015-02-17 Thread Tamas K Lengyel
renamed to reflect that they belong to mem_access. The mem_event subop definitions are also shortened to be more meaningful. The tool side changes are only mechanical renaming to match these new names. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Ian Campbell ian.campb

[Xen-devel] [PATCH V6 13/13] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-02-17 Thread Tamas K Lengyel
consolidate them into XEN_VM_EVENT_ENABLE/DISABLE/RESUME. As part of this patch in libxc we also rename the mem_access_enable/disable functions to monitor_enable/disable and move them into xc_monitor.c. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Wei Liu wei.l...@citrix.com --- v6

[Xen-devel] [PATCH V6 00/13] xen: Clean-up of mem_event subsystem

2015-02-17 Thread Tamas K Lengyel
with and without XSM enabled. This PATCH series is also available at: https://github.com/tklengyel/xen/tree/mem_event_cleanup6 Tamas K Lengyel (13): xen/mem_event: Cleanup of mem_event structures xen/mem_event: Cleanup mem_event names in rings, functions and domctls xen/mem_paging: Convert mem_event_op

Re: [Xen-devel] [PATCH V5 07/12] xen: Introduce monitor_op domctl

2015-02-17 Thread Tamas K Lengyel
On Tue, Feb 17, 2015 at 7:20 PM, Tamas K Lengyel tamas.leng...@zentific.com wrote: On Tue, Feb 17, 2015 at 3:02 PM, Jan Beulich jbeul...@suse.com wrote: On 13.02.15 at 17:33, tamas.leng...@zentific.com wrote: --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -411,7 +411,8

Re: [Xen-devel] [PATCH V6 04/13] xen: Rename mem_event to vm_event

2015-02-18 Thread Tamas K Lengyel
On Wed, Feb 18, 2015 at 4:55 PM, Tamas K Lengyel tamas.leng...@zentific.com wrote: On Wed, Feb 18, 2015 at 2:35 PM, Jan Beulich jbeul...@suse.com wrote: On 18.02.15 at 13:21, tamas.k.leng...@gmail.com wrote: On Wed Feb 18 2015 10:46:02 AM CET, Jan Beulich jbeul...@suse.com wrote

Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-17 Thread Tamas K Lengyel
On Tue, Feb 17, 2015 at 7:34 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 17/02/15 18:30, Tamas K Lengyel wrote: All these whitespace changes here and further down don't really belong in this patch - please again get this right when adding the code. Same issue I mentioned

Re: [Xen-devel] [PATCH V5 07/12] xen: Introduce monitor_op domctl

2015-02-17 Thread Tamas K Lengyel
handler. + * + * Copyright (c) 2015 Tamas K Lengyel (ta...@tklengyel.com) + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public + * License v2 as published by the Free Software Foundation. + * + * This program is distributed

Re: [Xen-devel] [PATCH V5 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-02-17 Thread Tamas K Lengyel
On Tue, Feb 17, 2015 at 3:31 PM, Jan Beulich jbeul...@suse.com wrote: On 13.02.15 at 17:33, tamas.leng...@zentific.com wrote: @@ -611,13 +611,22 @@ int vm_event_domctl(struct domain *d, xen_domctl_vm_event_op_t *vec, } break; -case XEN_VM_EVENT_PAGING_DISABLE: +

Re: [Xen-devel] [PATCH V5 07/12] xen: Introduce monitor_op domctl

2015-02-17 Thread Tamas K Lengyel
On Tue, Feb 17, 2015 at 7:37 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 17/02/15 18:20, Tamas K Lengyel wrote: +// +/*monitor event options */ +// +struct

Re: [Xen-devel] [PATCH V5 10/12] xen/vm_event: Relocate memop checks

2015-02-17 Thread Tamas K Lengyel
On Tue, Feb 17, 2015 at 3:25 PM, Jan Beulich jbeul...@suse.com wrote: On 13.02.15 at 17:33, tamas.leng...@zentific.com wrote: -int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *mpo) +int mem_paging_memop(unsigned long cmd, +

Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-17 Thread Tamas K Lengyel
On Tue, Feb 17, 2015 at 3:17 PM, Jan Beulich jbeul...@suse.com wrote: On 13.02.15 at 17:33, tamas.leng...@zentific.com wrote: @@ -1293,56 +1293,30 @@ int p2m_mem_paging_prep(struct domain *d, unsigned long gfn, uint64_t buffer) * * If the gfn was dropped the vcpu needs to be unpaused.

Re: [Xen-devel] EPT question - XENMEM_get_access_op

2015-02-20 Thread Tamas K Lengyel
On Fri, Feb 20, 2015 at 3:21 PM, Balbir Singh bsinghar...@gmail.com wrote: [snip] On Fri, Feb 20, 2015 at 5:21 PM, Jan Beulich jbeul...@suse.com wrote: Thanks Jan! Is there a way for a memevents channel consumer to get access to the L1 (OS Page tables). Hardly. I presume we'll need to walk

Re: [Xen-devel] [PATCH V6 04/13] xen: Rename mem_event to vm_event

2015-02-18 Thread Tamas K Lengyel
On Wed Feb 18 2015 10:46:02 AM CET, Jan Beulich jbeul...@suse.com wrote: On 18.02.15 at 01:11, tamas.leng...@zentific.com wrote: diff --git a/xen/common/mem_event.c b/xen/common/vm_event.c similarity index 59% rename from xen/common/mem_event.c rename to xen/common/vm_event.c

Re: [Xen-devel] [PATCH V5 06/12] x86/hvm: factor out and rename vm_event related functions

2015-02-18 Thread Tamas K Lengyel
On Wed Feb 18 2015 10:07:29 AM CET, Jan Beulich jbeul...@suse.com wrote: On 17.02.15 at 18:37, tamas.leng...@zentific.com wrote: On Tue, Feb 17, 2015 at 12:56 PM, Jan Beulich jbeul...@suse.com wrote: On 13.02.15 at 17:33, tamas.leng...@zentific.com wrote: +static void

Re: [Xen-devel] [PATCH V5 10/12] xen/vm_event: Relocate memop checks

2015-02-18 Thread Tamas K Lengyel
On Wed Feb 18 2015 10:29:40 AM CET, Jan Beulich jbeul...@suse.com wrote: On 17.02.15 at 19:47, tamas.leng...@zentific.com wrote: On Tue, Feb 17, 2015 at 3:25 PM, Jan Beulich jbeul...@suse.com wrote: On 13.02.15 at 17:33, tamas.leng...@zentific.com wrote: -int

Re: [Xen-devel] [PATCH V6 04/13] xen: Rename mem_event to vm_event

2015-02-18 Thread Tamas K Lengyel
On Wed, Feb 18, 2015 at 2:35 PM, Jan Beulich jbeul...@suse.com wrote: On 18.02.15 at 13:21, tamas.k.leng...@gmail.com wrote: On Wed Feb 18 2015 10:46:02 AM CET, Jan Beulich jbeul...@suse.com wrote: On 18.02.15 at 01:11, tamas.leng...@zentific.com wrote: diff --git a/xen/common/mem_event.c

Re: [Xen-devel] [PATCH V5 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-02-18 Thread Tamas K Lengyel
On Wed Feb 18 2015 10:31:06 AM CET, Jan Beulich jbeul...@suse.com wrote: On 17.02.15 at 19:32, tamas.leng...@zentific.com wrote: On Tue, Feb 17, 2015 at 3:31 PM, Jan Beulich jbeul...@suse.com wrote: On 13.02.15 at 17:33, tamas.leng...@zentific.com wrote: @@ -611,13 +611,22 @@ int

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Tamas K Lengyel
On Thu, Jan 29, 2015 at 1:02 PM, Jan Beulich jbeul...@suse.com wrote: On 29.01.15 at 12:54, tamas.leng...@zentific.com wrote: On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel tamas.leng...@zentific.com wrote: On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich jbeul...@suse.com wrote: On 18.01.15

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Tamas K Lengyel
On Thu, Jan 29, 2015 at 1:09 PM, Tamas K Lengyel tamas.leng...@zentific.com wrote: On Thu, Jan 29, 2015 at 1:02 PM, Jan Beulich jbeul...@suse.com wrote: On 29.01.15 at 12:54, tamas.leng...@zentific.com wrote: On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel tamas.leng...@zentific.com wrote

Re: [Xen-devel] [RFC PATCH V3 05/12] xen: Introduce vm_event

2015-01-31 Thread Tamas K Lengyel
On Fri, Jan 30, 2015 at 6:25 PM, Daniel De Graaf dgde...@tycho.nsa.gov wrote: On 01/29/2015 04:46 PM, Tamas K Lengyel wrote: To make it easier to review the renaming process of mem_event - vm_event, the process is broken into three pieces, of which this patch is the first. In this patch

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-23 Thread Tamas K Lengyel
On Fri, Jan 23, 2015 at 10:00 AM, Jan Beulich jbeul...@suse.com wrote: (re-adding xen-devel) On 22.01.15 at 17:54, tamas.leng...@zentific.com wrote: On Thu, Jan 22, 2015 at 5:34 PM, Jan Beulich jbeul...@suse.com wrote: On 22.01.15 at 17:23, tamas.leng...@zentific.com wrote: Wouldn't making

Re: [Xen-devel] [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file

2015-01-23 Thread Tamas K Lengyel
On Fri, Jan 23, 2015 at 10:03 AM, Jan Beulich jbeul...@suse.com wrote: On 23.01.15 at 09:56, rcojoc...@bitdefender.com wrote: On 01/22/2015 06:42 PM, Tamas K Lengyel wrote: On Thu, Jan 22, 2015 at 5:25 PM, Jan Beulich jbeul...@suse.com wrote: On 18.01.15 at 16:18, tamas.leng...@zentific.com

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-13 Thread Tamas K Lengyel
On Mon, Jan 12, 2015 at 7:31 PM, Ed White edmund.h.wh...@intel.com wrote: On 01/12/2015 10:00 AM, Ian Jackson wrote: Ed White writes (Re: [PATCH 00/11] Alternate p2m: support multiple copies of host p2m): The hypercalls are all there. My testing is all done in a Windows domU with the tests

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-14 Thread Tamas K Lengyel
On Wed, Jan 14, 2015 at 12:09 PM, Jan Beulich jbeul...@suse.com wrote: On 14.01.15 at 11:31, tamas.leng...@zentific.com wrote: On Wed, Jan 14, 2015 at 8:04 AM, Jan Beulich jbeul...@suse.com wrote: Ed White edmund.h.wh...@intel.com 01/13/15 10:32 PM On 01/13/2015 12:45 PM, Andrew Cooper wrote:

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-14 Thread Tamas K Lengyel
On Wed, Jan 14, 2015 at 8:04 AM, Jan Beulich jbeul...@suse.com wrote: Ed White edmund.h.wh...@intel.com 01/13/15 10:32 PM On 01/13/2015 12:45 PM, Andrew Cooper wrote: On 13/01/15 20:02, Ed White wrote: The set of mfn's is the same, but I do allow gfn-mfn mappings to be modified under certain

Re: [Xen-devel] [RFC PATCH V3 10/12] xen: Introduce monitor_op domctl

2015-02-09 Thread Tamas K Lengyel
--- a/xen/include/public/hvm/params.h +++ b/xen/include/public/hvm/params.h @@ -162,21 +162,6 @@ */ #define HVM_PARAM_ACPI_IOPORTS_LOCATION 19 -/* Enable blocking memory events, async or sync (pause vcpu until response) - * onchangeonly indicates messages only on a change of value */

[Xen-devel] [PATCH V4 12/13] xen/xsm: Split vm_event_op into three separate labels

2015-02-09 Thread Tamas K Lengyel
-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/arch/x86/mm/mem_paging.c| 2 +- xen/arch/x86/mm/mem_sharing.c | 2 +- xen/common/mem_access.c | 2 +- xen/include/xsm/dummy.h | 20 +++- xen/include/xsm/xsm.h | 33

[Xen-devel] [PATCH V4 13/13] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-02-09 Thread Tamas K Lengyel
consolidate them into XEN_VM_EVENT_ENABLE/DISABLE/RESUME. As part of this patch in libxc we also rename the mem_access_enable/disable functions to monitor_enable/disable and move them into xc_monitor.c. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- tools/libxc/include/xenctrl.h

[Xen-devel] [PATCH V4 05/13] xen: Rename mem_event to vm_event

2015-02-09 Thread Tamas K Lengyel
applications when encountering various events during a VM's execution. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- v4: Using git -M option for patch to improve readability Note that in include/xen/vm_event.h the style problems are fixed in a later patch in the series so

[Xen-devel] [PATCH V4 08/13] xen: Introduce monitor_op domctl

2015-02-09 Thread Tamas K Lengyel
-by: Andrew Cooper andrew.coop...@citrix.com Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Ian Campbell ian.campb...@citrix.com Acked-by: Kevin Tian kevin.t...@intel.com --- v4: Style fixes Only defining struct mov_to_cr and struct debug_event in asm-x86/domain.h Add

[Xen-devel] [PATCH V4 10/13] xen/vm_event: Decouple vm_event and mem_access.

2015-02-09 Thread Tamas K Lengyel
the corresponding vCPU. This approach reduces code duplication and present a single point of entry for the entire vm_event subsystem's response handling mechanism. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- v4: Consolidate resume routines into vm_event_resume Style fixes Sort xen

[Xen-devel] [PATCH V4 02/13] xen/mem_event: Cleanup mem_event ring names and domctls

2015-02-09 Thread Tamas K Lengyel
. The tool side changes are only mechanical renaming to match these new names. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Ian Campbell ian.campb...@citrix.com --- v4: Shorted mem_event domctl subops. v3: Style and comment fixes. --- tools/libxc/xc_domain_restore.c | 14

[Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-09 Thread Tamas K Lengyel
to mean different things under different scenarios. This patch remedies the issue by clearly defining the structure members based on the actual context within which the structure is used. Signed-off-by: Razvan Cojocaru rcojoc...@bitdefender.com Signed-off-by: Tamas K Lengyel tamas.leng

[Xen-devel] [PATCH V4 09/13] xen/vm_event: Check for VM_EVENT_FLAG_DUMMY only in Debug builds

2015-02-09 Thread Tamas K Lengyel
The flag is only used for debugging purposes, thus it should be only checked for in debug builds of Xen. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/arch/x86/mm/mem_sharing.c | 2 ++ xen/arch/x86/mm/p2m.c | 2 ++ xen/common/mem_access.c | 2 ++ 3 files changed

[Xen-devel] [PATCH V4 00/13] xen: Clean-up of mem_event subsystem

2015-02-09 Thread Tamas K Lengyel
with and without XSM enabled. This PATCH series is also available at: https://github.com/tklengyel/xen/tree/mem_event_cleanup4 Razvan Cojocaru (1): xen/mem_event: Cleanup of mem_event structures Tamas K Lengyel (12): xen/mem_event: Cleanup mem_event ring names and domctls xen/mem_paging: Convert

[Xen-devel] [PATCH V4 11/13] xen/vm_event: Relocate memop checks

2015-02-09 Thread Tamas K Lengyel
it consistent. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/arch/x86/mm/mem_paging.c | 42 -- xen/arch/x86/mm/mem_sharing.c | 76 ++- xen/arch/x86/x86_64/compat/mm.c | 28 +++ xen/arch/x86/x86_64/mm.c

[Xen-devel] [PATCH V4 06/13] tools/tests: Clean-up tools/tests/xen-access

2015-02-09 Thread Tamas K Lengyel
on the behavior of the system. Also converting functions that always return 0 to return to void, and making the teardown function actually return an error code on error. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Ian Campbell ian.campb...@citrix.com --- tools/tests/xen-access/xen

[Xen-devel] [PATCH V4 04/13] xen/mem_access: Merge mem_event sanity check into mem_access check

2015-02-09 Thread Tamas K Lengyel
The current sanity check when enabling mem_event is only applicable to mem_access. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/common/mem_event.c | 4 xen/include/asm-x86/p2m.h | 8 +--- xen/include/public/domctl.h | 1 - 3 files changed, 1 insertion(+), 12

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich jbeul...@suse.com wrote: On 09.02.15 at 19:53, tamas.leng...@zentific.com wrote: +static void hvm_memory_event_cr(uint32_t reason, unsigned long value, +unsigned long old) +{ +mem_event_request_t req = { +

[Xen-devel] [PATCH V5 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-13 Thread Tamas K Lengyel
. This patch remedies the issue by clearly defining the structure members based on the actual context within which the structure is used. Signed-off-by: Razvan Cojocaru rcojoc...@bitdefender.com Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- v5: Style fixes Convert gfn

[Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-13 Thread Tamas K Lengyel
the corresponding vCPU. This approach reduces code duplication and present a single point of entry for the entire vm_event subsystem's response handling mechanism. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Daniel De Graaf dgde...@tycho.nsa.gov --- v4: Consolidate resume routines

[Xen-devel] [PATCH V5 03/12] xen/mem_paging: Convert mem_event_op to mem_paging_op

2015-02-13 Thread Tamas K Lengyel
The only use-case of the mem_event_op structure had been in mem_paging, thus renaming the structure mem_paging_op and relocating its associated functions clarifies its actual usage. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Tim Deegan t...@xen.org Acked-by: Ian Campbell

[Xen-devel] [PATCH V5 00/12] xen: Clean-up of mem_event subsystem

2015-02-13 Thread Tamas K Lengyel
with and without XSM enabled. This PATCH series is also available at: https://github.com/tklengyel/xen/tree/mem_event_cleanup5 Tamas K Lengyel (12): xen/mem_event: Cleanup of mem_event structures xen/mem_event: Cleanup mem_event ring names and domctls xen/mem_paging: Convert mem_event_op to mem_paging_op

[Xen-devel] [PATCH V5 02/12] xen/mem_event: Cleanup mem_event ring names and domctls

2015-02-13 Thread Tamas K Lengyel
. The tool side changes are only mechanical renaming to match these new names. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Ian Campbell ian.campb...@citrix.com Acked-by: Jan Beulich jbeul...@suse.com --- v5: Style fixes v4: Shorted mem_event domctl subops. v3: Style

[Xen-devel] [PATCH V5 07/12] xen: Introduce monitor_op domctl

2015-02-13 Thread Tamas K Lengyel
-by: Andrew Cooper andrew.coop...@citrix.com Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Ian Campbell ian.campb...@citrix.com Acked-by: Kevin Tian kevin.t...@intel.com Acked-by: Daniel De Graaf dgde...@tycho.nsa.gov --- v5: p2m_vm_event_sanity_check is moved

[Xen-devel] [PATCH V5 08/12] xen/vm_event: Check for VM_EVENT_FLAG_DUMMY only in Debug builds

2015-02-13 Thread Tamas K Lengyel
The flag is only used for debugging purposes, thus it should be only checked for in debug builds of Xen. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com --- xen/arch/x86/mm/mem_sharing.c | 2 ++ xen/arch/x86/mm/p2m.c | 2 ++ xen/common/mem_access.c | 2 ++ 3 files changed

[Xen-devel] [PATCH V5 06/12] x86/hvm: factor out and rename vm_event related functions

2015-02-13 Thread Tamas K Lengyel
To avoid growing hvm.c these functions can be stored separately. Minor style changes are applied to the logic in the file. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Kevin Tian kevin.t...@intel.com --- v5: Style fixes Fix hvm_event_msr input types to match

[Xen-devel] [PATCH V5 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-02-13 Thread Tamas K Lengyel
consolidate them into XEN_VM_EVENT_ENABLE/DISABLE/RESUME. As part of this patch in libxc we also rename the mem_access_enable/disable functions to monitor_enable/disable and move them into xc_monitor.c. Signed-off-by: Tamas K Lengyel tamas.leng...@zentific.com Acked-by: Wei Liu wei.l...@citrix.com

  1   2   3   4   5   6   7   8   9   10   >