Re: [Xen-devel] [PATCH v1 07/13] x86: implement set value flow for MBA

2017-08-21 Thread Chao Peng
> > > > > >   > > > +/* > > > + * Because multiple features may co-exist, we need handle all > > > features to write > > > + * values of them into a COS register with new COS ID. E.g: > > > + * 1. L3 CAT and MBA co-exist. > > > + * 2. Dom1 and Dom2 share a same COS ID (2). The L3 CAT CBM of > >

Re: [Xen-devel] [PATCH v1 07/13] x86: implement set value flow for MBA

2017-08-18 Thread Yi Sun
On 17-08-18 11:32:08, Chao Peng wrote: > > > +if ( feat->mba_info.linear ) > > +{ > > +unsigned int mod; > > + > > +if ( feat->mba_info.thrtl_max >= 100 ) > > +return false; > > Can we do this check earlier, e.g. when it gets enumerated from CPUID? > Ok,

Re: [Xen-devel] [PATCH v1 07/13] x86: implement set value flow for MBA

2017-08-17 Thread Chao Peng
> +if ( feat->mba_info.linear ) > +{ > +unsigned int mod; > + > +if ( feat->mba_info.thrtl_max >= 100 ) > +return false; Can we do this check earlier, e.g. when it gets enumerated from CPUID? > + > +mod = *thrtl % (100 - feat->mba_info.thrtl_max); > + 

[Xen-devel] [PATCH v1 07/13] x86: implement set value flow for MBA

2017-08-09 Thread Yi Sun
This patch implements set value flow for MBA including its callback function and domctl interface. It also changes the memebers in 'cos_write_info' to transfer the feature array, feature properties array and value array. Then, we can write all features values on the cos id into MSRs.