Re: [Xen-devel] [PATCH v2 4/4] docs: add HVM USB passthrough documentation

[Ian Jackson]

Juergen Gross writes ("Re: [PATCH v2 4/4] docs: add HVM USB passthrough 
documentation"):
> On 20/09/16 12:25, Ian Jackson wrote:
> > This should read:
> >For HVM domains "devicemodel" will be selected.
> 
> Okay, will change.

Great, thanks.

> > Also you might want to consider semantic newlines for your future
> > patches to the markdown.
> >   http://rhodesmill.org/brandon/2012/one-sentence-per-line/
> 
> Thanks for the hint. I'll try to remember it. :-)

I only encountered that fairly recently but it's already improving my
life...

Regards,
Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 4/4] docs: add HVM USB passthrough documentation

[Juergen Gross]

On 20/09/16 12:25, Ian Jackson wrote:
> Juergen Gross writes ("[PATCH v2 4/4] docs: add HVM USB passthrough 
> documentation"):
>> Update the man page regarding passthrough of USB devices to HVM
>> domains via qemu USB emulation.
> 
> Acked-by: Ian Jackson 
> 
> By which I also mean that I approve of the API.  Thanks!
> 
> 
> However,
> 
>> +"devicemodel" specifies a USB controller emulated by qemu. It will show up 
>> as
>> +a PCI-device in the guest.
>> +
>>  "auto" (the default) determines whether a kernel based backend is installed.
>>  If this is the case, "pv" is selected, "qusb" will be selected if no kernel
>> -backend is currently available.
>> +backend is currently available. For HVM domains "devicemodel" is being 
>> selected.
> 
> This should read:
>For HVM domains "devicemodel" will be selected.

Okay, will change.

> But this can be fixed up later; I'm happy to submit such a patch.

No need for that. George wanted a rename of a function in Patch 3, so
I'm going to send V3 anyway.

> Also you might want to consider semantic newlines for your future
> patches to the markdown.
>   http://rhodesmill.org/brandon/2012/one-sentence-per-line/

Thanks for the hint. I'll try to remember it. :-)


Juergen


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 4/4] docs: add HVM USB passthrough documentation

[Ian Jackson]

Juergen Gross writes ("[PATCH v2 4/4] docs: add HVM USB passthrough 
documentation"):
> Update the man page regarding passthrough of USB devices to HVM
> domains via qemu USB emulation.

Acked-by: Ian Jackson 

By which I also mean that I approve of the API.  Thanks!


However,

> +"devicemodel" specifies a USB controller emulated by qemu. It will show up as
> +a PCI-device in the guest.
> +
>  "auto" (the default) determines whether a kernel based backend is installed.
>  If this is the case, "pv" is selected, "qusb" will be selected if no kernel
> -backend is currently available.
> +backend is currently available. For HVM domains "devicemodel" is being 
> selected.

This should read:
   For HVM domains "devicemodel" will be selected.

But this can be fixed up later; I'm happy to submit such a patch.

Also you might want to consider semantic newlines for your future
patches to the markdown.
  http://rhodesmill.org/brandon/2012/one-sentence-per-line/



Regards,
Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 4/4] docs: add HVM USB passthrough documentation

[Juergen Gross]

Update the man page regarding passthrough of USB devices to HVM
domains via qemu USB emulation.

Signed-off-by: Juergen Gross 
Acked-by: Wei Liu 
---
 docs/man/xl.cfg.pod.5.in | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
index 77a1be3..076b2a6 100644
--- a/docs/man/xl.cfg.pod.5.in
+++ b/docs/man/xl.cfg.pod.5.in
@@ -745,19 +745,25 @@ Specifies the usb controller type.
 
 "qusb" specifies a qemu base backend for pvusb.
 
+"devicemodel" specifies a USB controller emulated by qemu. It will show up as
+a PCI-device in the guest.
+
 "auto" (the default) determines whether a kernel based backend is installed.
 If this is the case, "pv" is selected, "qusb" will be selected if no kernel
-backend is currently available.
+backend is currently available. For HVM domains "devicemodel" is being 
selected.
 
 =item