Re: [Xen-devel] [PATCH v5 07/16] livepatch: ARM 32|64: Ignore mapping symbols: $[d, a, x]

2016-09-23 Thread Konrad Rzeszutek Wilk
> > +bool arch_livepatch_symbol_ok(const struct livepatch_elf *elf, > > + const struct livepatch_elf_sym *sym) > > +{ > > +/* > > + * - Mapping symbols - denote the "start of a sequence of bytes of the > > + * appropriate type" to mark certain features - s

Re: [Xen-devel] [PATCH v5 07/16] livepatch: ARM 32|64: Ignore mapping symbols: $[d, a, x]

2016-09-23 Thread Ross Lagerwall
On 09/21/2016 06:32 PM, Konrad Rzeszutek Wilk wrote: Those symbols are used to help final linkers to replace insn. The ARM ELF specification mandates that they are present to denote the start of certain CPU features. There are two variants of it - short and long format. Either way - we can ignor

Re: [Xen-devel] [PATCH v5 07/16] livepatch: ARM 32|64: Ignore mapping symbols: $[d, a, x]

2016-09-22 Thread Julien Grall
Hi Konrad, On 21/09/16 18:32, Konrad Rzeszutek Wilk wrote: Those symbols are used to help final linkers to replace insn. The ARM ELF specification mandates that they are present to denote the start of certain CPU features. There are two variants of it - short and long format. Either way - we ca

[Xen-devel] [PATCH v5 07/16] livepatch: ARM 32|64: Ignore mapping symbols: $[d, a, x]

2016-09-21 Thread Konrad Rzeszutek Wilk
Those symbols are used to help final linkers to replace insn. The ARM ELF specification mandates that they are present to denote the start of certain CPU features. There are two variants of it - short and long format. Either way - we can ignore these symbols. Reviewed-by: Andrew Cooper [x86 bits