Re: [Xen-devel] [PATCH v6 6/6] livepatch/tests: Move the .name value to .rodata

2016-09-21 Thread Ross Lagerwall

On 09/16/2016 04:29 PM, Konrad Rzeszutek Wilk wrote:

Right now the contents of 'name' are all located in
the .data section. We want them in the .rodata section
so change the type to have const on them.

Signed-off-by: Konrad Rzeszutek Wilk 


Reviewed-by: Ross Lagerwall 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH v6 6/6] livepatch/tests: Move the .name value to .rodata

2016-09-19 Thread Jan Beulich
>>> On 16.09.16 at 17:29,  wrote:
> Right now the contents of 'name' are all located in
> the .data section. We want them in the .rodata section
> so change the type to have const on them.
> 
> Signed-off-by: Konrad Rzeszutek Wilk 

I've only now noticed that the tests get covered in the LIVEPATCH
section only by patch 8 of the other series, so patch 5 and 6 here:
Acked-by: Jan Beulich 

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel


[Xen-devel] [PATCH v6 6/6] livepatch/tests: Move the .name value to .rodata

2016-09-16 Thread Konrad Rzeszutek Wilk
Right now the contents of 'name' are all located in
the .data section. We want them in the .rodata section
so change the type to have const on them.

Signed-off-by: Konrad Rzeszutek Wilk 
---
Cc: Andrew Cooper 
Cc: Jan Beulich 

v3: First submission (as part of the ARM 32 and 64 support of Livepatch)
v6: Now moved to the Common Livepatch fixes for 4.8
---
 xen/arch/x86/test/xen_bye_world.c | 2 +-
 xen/arch/x86/test/xen_hello_world.c   | 2 +-
 xen/arch/x86/test/xen_replace_world.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/test/xen_bye_world.c 
b/xen/arch/x86/test/xen_bye_world.c
index b75e0b1..2700f0e 100644
--- a/xen/arch/x86/test/xen_bye_world.c
+++ b/xen/arch/x86/test/xen_bye_world.c
@@ -11,7 +11,7 @@
 
 #include 
 
-static char bye_world_patch_this_fnc[] = "xen_extra_version";
+static const char bye_world_patch_this_fnc[] = "xen_extra_version";
 extern const char *xen_bye_world(void);
 
 struct livepatch_func __section(".livepatch.funcs") livepatch_xen_bye_world = {
diff --git a/xen/arch/x86/test/xen_hello_world.c 
b/xen/arch/x86/test/xen_hello_world.c
index cb5e27a..02f3f85 100644
--- a/xen/arch/x86/test/xen_hello_world.c
+++ b/xen/arch/x86/test/xen_hello_world.c
@@ -12,7 +12,7 @@
 
 #include 
 
-static char hello_world_patch_this_fnc[] = "xen_extra_version";
+static const char hello_world_patch_this_fnc[] = "xen_extra_version";
 extern const char *xen_hello_world(void);
 static unsigned int cnt;
 
diff --git a/xen/arch/x86/test/xen_replace_world.c 
b/xen/arch/x86/test/xen_replace_world.c
index a2a221a..78a8f52 100644
--- a/xen/arch/x86/test/xen_replace_world.c
+++ b/xen/arch/x86/test/xen_replace_world.c
@@ -10,7 +10,7 @@
 
 #include 
 
-static char xen_replace_world_name[] = "xen_extra_version";
+static const char xen_replace_world_name[] = "xen_extra_version";
 extern const char *xen_replace_world(void);
 
 struct livepatch_func __section(".livepatch.funcs") 
livepatch_xen_replace_world = {
-- 
2.5.5


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel