Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-09 Thread Julien Grall 

On 09/11/17 14:36, Julien Grall wrote:

Hi Roger,

On 09/11/17 09:27, Roger Pau Monné wrote:

On Thu, Nov 09, 2017 at 12:22:49AM +, Hao, Xudong wrote:
Qemu-xen didn't have commit a80363, so I report this issue to ask 
for sync up
with qemu upstream. Last mail I mean I usually used Qemu Xen tree to 
do test,

and found out this issue.

Before requesting the backport, have you tested whether it fixes 
your issues?




Yes, Luwei (Cced) tested it with pass result.


In which case requesting a backport would be in place on the grounds
that's a bug fix.

The patch in question fixes a bug mostly seen when doing
PCI-passthrough of devices that support MSI-X interrupts to Windows
guest (and Windows attempts to setup the interrupts using MSI-X). It
doesn't manifest on Linux or FreeBSD because these OSes use a
different dance to setup MSI-X interrupts, and thus are not affected.
It's likely that other OSes with different MSI-X implementations are
able to trigger that bug. The result of not having the patch is that
interrupts of passed through devices will stay masked, thus
preventing the device from working (unless polling mode only is
used).

Pros:
  - It fixes a bug.
  - The patch is not very big or intrusive.

Cons:
  - It hasn't been tested as it's not in qemu-xen.
  - Only Windows is affected by the bug AFAIK.

IMHO, iff the backport is accepted it should be performed ASAP, so
that the patch can be properly tested before the release.


Thank you for the detailed explanation :). On a previous e-mail Stefano 
were happy with the backport. So:


Release-acked-by: Julien Grall 


Note that I think we would need to update xen also to point to the 
commit with this backport included.


Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-09 Thread Julien Grall 

Hi Roger,

On 09/11/17 09:27, Roger Pau Monné wrote:

On Thu, Nov 09, 2017 at 12:22:49AM +, Hao, Xudong wrote:

Qemu-xen didn't have commit a80363, so I report this issue to ask for sync up
with qemu upstream. Last mail I mean I usually used Qemu Xen tree to do test,
and found out this issue.

Before requesting the backport, have you tested whether it fixes your issues?



Yes, Luwei (Cced) tested it with pass result.


In which case requesting a backport would be in place on the grounds
that's a bug fix.

The patch in question fixes a bug mostly seen when doing
PCI-passthrough of devices that support MSI-X interrupts to Windows
guest (and Windows attempts to setup the interrupts using MSI-X). It
doesn't manifest on Linux or FreeBSD because these OSes use a
different dance to setup MSI-X interrupts, and thus are not affected.
It's likely that other OSes with different MSI-X implementations are
able to trigger that bug. The result of not having the patch is that
interrupts of passed through devices will stay masked, thus
preventing the device from working (unless polling mode only is
used).

Pros:
  - It fixes a bug.
  - The patch is not very big or intrusive.

Cons:
  - It hasn't been tested as it's not in qemu-xen.
  - Only Windows is affected by the bug AFAIK.

IMHO, iff the backport is accepted it should be performed ASAP, so
that the patch can be properly tested before the release.


Thank you for the detailed explanation :). On a previous e-mail Stefano 
were happy with the backport. So:


Release-acked-by: Julien Grall 

Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-09 Thread Roger Pau Monné 
On Thu, Nov 09, 2017 at 12:22:49AM +, Hao, Xudong wrote:
> > Qemu-xen didn't have commit a80363, so I report this issue to ask for sync 
> > up
> > with qemu upstream. Last mail I mean I usually used Qemu Xen tree to do 
> > test,
> > and found out this issue.
> > 
> > Before requesting the backport, have you tested whether it fixes your 
> > issues?
> > 
> 
> Yes, Luwei (Cced) tested it with pass result.

In which case requesting a backport would be in place on the grounds
that's a bug fix.

The patch in question fixes a bug mostly seen when doing
PCI-passthrough of devices that support MSI-X interrupts to Windows
guest (and Windows attempts to setup the interrupts using MSI-X). It
doesn't manifest on Linux or FreeBSD because these OSes use a
different dance to setup MSI-X interrupts, and thus are not affected.
It's likely that other OSes with different MSI-X implementations are
able to trigger that bug. The result of not having the patch is that
interrupts of passed through devices will stay masked, thus
preventing the device from working (unless polling mode only is
used).

Pros:
 - It fixes a bug.
 - The patch is not very big or intrusive.

Cons:
 - It hasn't been tested as it's not in qemu-xen.
 - Only Windows is affected by the bug AFAIK.

IMHO, iff the backport is accepted it should be performed ASAP, so
that the patch can be properly tested before the release.

Thanks, Roger.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-08 Thread Hao, Xudong 
> -Original Message-
> From: Roger Pau Monné [mailto:roger@citrix.com]
> Sent: Tuesday, November 7, 2017 5:33 PM
> To: Hao, Xudong <xudong@intel.com>
> Cc: Julien Grall <julien.gr...@linaro.org>; Stefano Stabellini
> <sstabell...@kernel.org>; Lars Kurth <lars.ku...@citrix.com>; Quan Xu
> <quan@gmail.com>; Kang, Luwei <luwei.k...@intel.com>; Zhang,
> PengtaoX <pengtaox.zh...@intel.com>; Julien Grall <julien.gr...@arm.com>;
> Jan Beulich <jbeul...@suse.com>; Xen-devel <xen-de...@lists.xenproject.org>;
> Anthony PERARD <anthony.per...@citrix.com>; Wei Liu <wei.l...@citrix.com>
> Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> 
> On Mon, Nov 06, 2017 at 01:04:56AM +, Hao, Xudong wrote:
> > > -Original Message-
> > > From: Roger Pau Monné [mailto:roger@citrix.com]
> > > Sent: Friday, November 3, 2017 7:23 PM
> > > To: Hao, Xudong <xudong@intel.com>
> > > Cc: Julien Grall <julien.gr...@linaro.org>; Stefano Stabellini
> > > <sstabell...@kernel.org>; Lars Kurth <lars.ku...@citrix.com>; Quan
> > > Xu <quan@gmail.com>; Kang, Luwei <luwei.k...@intel.com>; Zhang,
> > > PengtaoX <pengtaox.zh...@intel.com>; Julien Grall
> > > <julien.gr...@arm.com>; Jan Beulich <jbeul...@suse.com>; Xen-devel
> > > <xen-de...@lists.xenproject.org>; Anthony PERARD
> > > <anthony.per...@citrix.com>; Wei Liu <wei.l...@citrix.com>
> > > Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through
> > > sriov
> > >
> > > On Fri, Nov 03, 2017 at 01:10:26AM +, Hao, Xudong wrote:
> > > >
> > > > > -Original Message-
> > > > > From: Julien Grall [mailto:julien.gr...@linaro.org]
> > > > > Sent: Thursday, November 2, 2017 9:50 PM
> > > > > To: Stefano Stabellini <sstabell...@kernel.org>
> > > > > Cc: Hao, Xudong <xudong@intel.com>; Jan Beulich
> > > > > <jbeul...@suse.com>; Quan Xu <quan@gmail.com>; Lars Kurth
> > > > > <lars.ku...@citrix.com>; Wei Liu <wei.l...@citrix.com>; Zhang,
> > > > > PengtaoX <pengtaox.zh...@intel.com>; Kang, Luwei
> > > > > <luwei.k...@intel.com>; Julien Grall <julien.gr...@arm.com>;
> > > > > Anthony PERARD <anthony.per...@citrix.com>; Xen-devel  > > > > de...@lists.xenproject.org>
> > > > > Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip
> > > > > through sriov
> > > > >
> > > > > Hi,
> > > > >
> > > > > On 27/10/17 21:16, Stefano Stabellini wrote:
> > > > > > On Fri, 27 Oct 2017, Julien Grall wrote:
> > > > > >> On 27/10/17 08:27, Hao, Xudong wrote:
> > > > > >>> This bug exist much long time, there are many discussion
> > > > > >>> last year but not a solution then. I call out it now because
> > > > > >>> there is a fix in qemu
> > > > > upstream:
> > > > > >>> commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > > > > >>> Author: Roger Pau Monne <roger@citrix.com>
> > > > > >>> Date:   Thu Aug 24 16:07:03 2017 +0100
> > > > > >>>
> > > > > >>>   xen/pt: allow QEMU to request MSI unmasking at bind
> > > > > >>> time
> > > > > >>>
> > > > > >>> The fix is not in qemu-xen tree yet, when will qemu-xen sync
> > > > > >>> this fix? Is it possible to catch Xen 4.10's qemu-xen?
> > > > > >>
> > > > > >> I will let Stefano and Anthony providing feedback before
> > > > > >> giving a release-ack here.
> > > > > >
> > > > > > Yes, I think we should backport the commit as it fixes a genuine 
> > > > > > bug.
> > > > > > The backport is not risk-free but it only affects PCI Passthrough.
> > > > > > Also the commit has been in QEMU for 2 months now.
> > > > >
> > > > > Does anyone actually tested it with QEMU Xen tree?
> > > > >
> > > >
> > > > Qemu Xen tree is default which is in Xen source code configuration
> > > > file
> > > Config.mk, I tested it with it.
> > > > QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git
> > >
> > > Can you please make sure you have QEMU commit a80363: xen/pt: allow
> > > QEMU to request MSI unmasking at bind time. AFAICT this is not yet
> > > in the qemu-xen tree.
> > >
> >
> > Roger,
> > Maybe I misunderstood of your question and my last mail confused you.
> Qemu-xen didn't have commit a80363, so I report this issue to ask for sync up
> with qemu upstream. Last mail I mean I usually used Qemu Xen tree to do test,
> and found out this issue.
> 
> Before requesting the backport, have you tested whether it fixes your issues?
> 

Yes, Luwei (Cced) tested it with pass result.


Thanks,
-Xudong

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-08 Thread Julien Grall 

Hi Anthony,

On 08/11/17 12:13, Anthony PERARD wrote:

On Thu, Nov 02, 2017 at 01:49:54PM +, Julien Grall wrote:

On 27/10/17 21:16, Stefano Stabellini wrote:

On Fri, 27 Oct 2017, Julien Grall wrote:

On 27/10/17 08:27, Hao, Xudong wrote:

This bug exist much long time, there are many discussion last year but not a
solution then. I call out it now because there is a fix in qemu upstream:
commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
Author: Roger Pau Monne 
Date:   Thu Aug 24 16:07:03 2017 +0100

   xen/pt: allow QEMU to request MSI unmasking at bind time

The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? Is it
possible to catch Xen 4.10's qemu-xen?


I will let Stefano and Anthony providing feedback before giving a release-ack
here.


Yes, I think we should backport the commit as it fixes a genuine bug.
The backport is not risk-free but it only affects PCI Passthrough. Also
the commit has been in QEMU for 2 months now.


Does anyone actually tested it with QEMU Xen tree?


Yes.  I've tested qemu-xen with this patch and PCI passthrough still
works.

Can I get a release-ack?


I'd still like an answer on Roger's question whether this patch fixes 
the issue they met.


Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-08 Thread Anthony PERARD 
On Thu, Nov 02, 2017 at 01:49:54PM +, Julien Grall wrote:
> On 27/10/17 21:16, Stefano Stabellini wrote:
> > On Fri, 27 Oct 2017, Julien Grall wrote:
> > > On 27/10/17 08:27, Hao, Xudong wrote:
> > > > This bug exist much long time, there are many discussion last year but 
> > > > not a
> > > > solution then. I call out it now because there is a fix in qemu 
> > > > upstream:
> > > > commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > > > Author: Roger Pau Monne 
> > > > Date:   Thu Aug 24 16:07:03 2017 +0100
> > > > 
> > > >   xen/pt: allow QEMU to request MSI unmasking at bind time
> > > > 
> > > > The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? 
> > > > Is it
> > > > possible to catch Xen 4.10's qemu-xen?
> > > 
> > > I will let Stefano and Anthony providing feedback before giving a 
> > > release-ack
> > > here.
> > 
> > Yes, I think we should backport the commit as it fixes a genuine bug.
> > The backport is not risk-free but it only affects PCI Passthrough. Also
> > the commit has been in QEMU for 2 months now.
> 
> Does anyone actually tested it with QEMU Xen tree?

Yes.  I've tested qemu-xen with this patch and PCI passthrough still
works.

Can I get a release-ack?

Thanks,

-- 
Anthony PERARD

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-07 Thread Roger Pau Monné 
On Mon, Nov 06, 2017 at 01:04:56AM +, Hao, Xudong wrote:
> > -Original Message-
> > From: Roger Pau Monné [mailto:roger@citrix.com]
> > Sent: Friday, November 3, 2017 7:23 PM
> > To: Hao, Xudong <xudong@intel.com>
> > Cc: Julien Grall <julien.gr...@linaro.org>; Stefano Stabellini
> > <sstabell...@kernel.org>; Lars Kurth <lars.ku...@citrix.com>; Quan Xu
> > <quan@gmail.com>; Kang, Luwei <luwei.k...@intel.com>; Zhang,
> > PengtaoX <pengtaox.zh...@intel.com>; Julien Grall <julien.gr...@arm.com>;
> > Jan Beulich <jbeul...@suse.com>; Xen-devel <xen-de...@lists.xenproject.org>;
> > Anthony PERARD <anthony.per...@citrix.com>; Wei Liu <wei.l...@citrix.com>
> > Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> > 
> > On Fri, Nov 03, 2017 at 01:10:26AM +, Hao, Xudong wrote:
> > >
> > > > -Original Message-
> > > > From: Julien Grall [mailto:julien.gr...@linaro.org]
> > > > Sent: Thursday, November 2, 2017 9:50 PM
> > > > To: Stefano Stabellini <sstabell...@kernel.org>
> > > > Cc: Hao, Xudong <xudong@intel.com>; Jan Beulich
> > > > <jbeul...@suse.com>; Quan Xu <quan@gmail.com>; Lars Kurth
> > > > <lars.ku...@citrix.com>; Wei Liu <wei.l...@citrix.com>; Zhang,
> > > > PengtaoX <pengtaox.zh...@intel.com>; Kang, Luwei
> > > > <luwei.k...@intel.com>; Julien Grall <julien.gr...@arm.com>; Anthony
> > > > PERARD <anthony.per...@citrix.com>; Xen-devel  > > > de...@lists.xenproject.org>
> > > > Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through
> > > > sriov
> > > >
> > > > Hi,
> > > >
> > > > On 27/10/17 21:16, Stefano Stabellini wrote:
> > > > > On Fri, 27 Oct 2017, Julien Grall wrote:
> > > > >> On 27/10/17 08:27, Hao, Xudong wrote:
> > > > >>> This bug exist much long time, there are many discussion last
> > > > >>> year but not a solution then. I call out it now because there is
> > > > >>> a fix in qemu
> > > > upstream:
> > > > >>> commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > > > >>> Author: Roger Pau Monne <roger@citrix.com>
> > > > >>> Date:   Thu Aug 24 16:07:03 2017 +0100
> > > > >>>
> > > > >>>   xen/pt: allow QEMU to request MSI unmasking at bind time
> > > > >>>
> > > > >>> The fix is not in qemu-xen tree yet, when will qemu-xen sync
> > > > >>> this fix? Is it possible to catch Xen 4.10's qemu-xen?
> > > > >>
> > > > >> I will let Stefano and Anthony providing feedback before giving a
> > > > >> release-ack here.
> > > > >
> > > > > Yes, I think we should backport the commit as it fixes a genuine bug.
> > > > > The backport is not risk-free but it only affects PCI Passthrough.
> > > > > Also the commit has been in QEMU for 2 months now.
> > > >
> > > > Does anyone actually tested it with QEMU Xen tree?
> > > >
> > >
> > > Qemu Xen tree is default which is in Xen source code configuration file
> > Config.mk, I tested it with it.
> > > QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git
> > 
> > Can you please make sure you have QEMU commit a80363: xen/pt: allow QEMU
> > to request MSI unmasking at bind time. AFAICT this is not yet in the 
> > qemu-xen
> > tree.
> > 
> 
> Roger, 
> Maybe I misunderstood of your question and my last mail confused you. 
> Qemu-xen didn't have commit a80363, so I report this issue to ask for sync up 
> with qemu upstream. Last mail I mean I usually used Qemu Xen tree to do test, 
> and found out this issue.

Before requesting the backport, have you tested whether it
fixes your issues?

Roger.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-05 Thread Hao, Xudong 
> -Original Message-
> From: Roger Pau Monné [mailto:roger@citrix.com]
> Sent: Friday, November 3, 2017 7:23 PM
> To: Hao, Xudong <xudong@intel.com>
> Cc: Julien Grall <julien.gr...@linaro.org>; Stefano Stabellini
> <sstabell...@kernel.org>; Lars Kurth <lars.ku...@citrix.com>; Quan Xu
> <quan@gmail.com>; Kang, Luwei <luwei.k...@intel.com>; Zhang,
> PengtaoX <pengtaox.zh...@intel.com>; Julien Grall <julien.gr...@arm.com>;
> Jan Beulich <jbeul...@suse.com>; Xen-devel <xen-de...@lists.xenproject.org>;
> Anthony PERARD <anthony.per...@citrix.com>; Wei Liu <wei.l...@citrix.com>
> Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> 
> On Fri, Nov 03, 2017 at 01:10:26AM +, Hao, Xudong wrote:
> >
> > > -Original Message-
> > > From: Julien Grall [mailto:julien.gr...@linaro.org]
> > > Sent: Thursday, November 2, 2017 9:50 PM
> > > To: Stefano Stabellini <sstabell...@kernel.org>
> > > Cc: Hao, Xudong <xudong@intel.com>; Jan Beulich
> > > <jbeul...@suse.com>; Quan Xu <quan@gmail.com>; Lars Kurth
> > > <lars.ku...@citrix.com>; Wei Liu <wei.l...@citrix.com>; Zhang,
> > > PengtaoX <pengtaox.zh...@intel.com>; Kang, Luwei
> > > <luwei.k...@intel.com>; Julien Grall <julien.gr...@arm.com>; Anthony
> > > PERARD <anthony.per...@citrix.com>; Xen-devel  > > de...@lists.xenproject.org>
> > > Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through
> > > sriov
> > >
> > > Hi,
> > >
> > > On 27/10/17 21:16, Stefano Stabellini wrote:
> > > > On Fri, 27 Oct 2017, Julien Grall wrote:
> > > >> On 27/10/17 08:27, Hao, Xudong wrote:
> > > >>> This bug exist much long time, there are many discussion last
> > > >>> year but not a solution then. I call out it now because there is
> > > >>> a fix in qemu
> > > upstream:
> > > >>> commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > > >>> Author: Roger Pau Monne <roger@citrix.com>
> > > >>> Date:   Thu Aug 24 16:07:03 2017 +0100
> > > >>>
> > > >>>   xen/pt: allow QEMU to request MSI unmasking at bind time
> > > >>>
> > > >>> The fix is not in qemu-xen tree yet, when will qemu-xen sync
> > > >>> this fix? Is it possible to catch Xen 4.10's qemu-xen?
> > > >>
> > > >> I will let Stefano and Anthony providing feedback before giving a
> > > >> release-ack here.
> > > >
> > > > Yes, I think we should backport the commit as it fixes a genuine bug.
> > > > The backport is not risk-free but it only affects PCI Passthrough.
> > > > Also the commit has been in QEMU for 2 months now.
> > >
> > > Does anyone actually tested it with QEMU Xen tree?
> > >
> >
> > Qemu Xen tree is default which is in Xen source code configuration file
> Config.mk, I tested it with it.
> > QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git
> 
> Can you please make sure you have QEMU commit a80363: xen/pt: allow QEMU
> to request MSI unmasking at bind time. AFAICT this is not yet in the qemu-xen
> tree.
> 

Roger, 
Maybe last mail confused you. Qemu-xen didn't have commit a80363, so I report 
this issue to ask for sync up with qemu upstream. Last mail I mean I usually 
used Qemu Xen tree to do test, and found out this issue.


Thanks,
-Xudong


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-05 Thread Hao, Xudong 
> -Original Message-
> From: Roger Pau Monné [mailto:roger@citrix.com]
> Sent: Friday, November 3, 2017 7:23 PM
> To: Hao, Xudong <xudong@intel.com>
> Cc: Julien Grall <julien.gr...@linaro.org>; Stefano Stabellini
> <sstabell...@kernel.org>; Lars Kurth <lars.ku...@citrix.com>; Quan Xu
> <quan@gmail.com>; Kang, Luwei <luwei.k...@intel.com>; Zhang,
> PengtaoX <pengtaox.zh...@intel.com>; Julien Grall <julien.gr...@arm.com>;
> Jan Beulich <jbeul...@suse.com>; Xen-devel <xen-de...@lists.xenproject.org>;
> Anthony PERARD <anthony.per...@citrix.com>; Wei Liu <wei.l...@citrix.com>
> Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> 
> On Fri, Nov 03, 2017 at 01:10:26AM +, Hao, Xudong wrote:
> >
> > > -Original Message-
> > > From: Julien Grall [mailto:julien.gr...@linaro.org]
> > > Sent: Thursday, November 2, 2017 9:50 PM
> > > To: Stefano Stabellini <sstabell...@kernel.org>
> > > Cc: Hao, Xudong <xudong@intel.com>; Jan Beulich
> > > <jbeul...@suse.com>; Quan Xu <quan@gmail.com>; Lars Kurth
> > > <lars.ku...@citrix.com>; Wei Liu <wei.l...@citrix.com>; Zhang,
> > > PengtaoX <pengtaox.zh...@intel.com>; Kang, Luwei
> > > <luwei.k...@intel.com>; Julien Grall <julien.gr...@arm.com>; Anthony
> > > PERARD <anthony.per...@citrix.com>; Xen-devel  > > de...@lists.xenproject.org>
> > > Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through
> > > sriov
> > >
> > > Hi,
> > >
> > > On 27/10/17 21:16, Stefano Stabellini wrote:
> > > > On Fri, 27 Oct 2017, Julien Grall wrote:
> > > >> On 27/10/17 08:27, Hao, Xudong wrote:
> > > >>> This bug exist much long time, there are many discussion last
> > > >>> year but not a solution then. I call out it now because there is
> > > >>> a fix in qemu
> > > upstream:
> > > >>> commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > > >>> Author: Roger Pau Monne <roger@citrix.com>
> > > >>> Date:   Thu Aug 24 16:07:03 2017 +0100
> > > >>>
> > > >>>   xen/pt: allow QEMU to request MSI unmasking at bind time
> > > >>>
> > > >>> The fix is not in qemu-xen tree yet, when will qemu-xen sync
> > > >>> this fix? Is it possible to catch Xen 4.10's qemu-xen?
> > > >>
> > > >> I will let Stefano and Anthony providing feedback before giving a
> > > >> release-ack here.
> > > >
> > > > Yes, I think we should backport the commit as it fixes a genuine bug.
> > > > The backport is not risk-free but it only affects PCI Passthrough.
> > > > Also the commit has been in QEMU for 2 months now.
> > >
> > > Does anyone actually tested it with QEMU Xen tree?
> > >
> >
> > Qemu Xen tree is default which is in Xen source code configuration file
> Config.mk, I tested it with it.
> > QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git
> 
> Can you please make sure you have QEMU commit a80363: xen/pt: allow QEMU
> to request MSI unmasking at bind time. AFAICT this is not yet in the qemu-xen
> tree.
> 

Roger, 
Maybe I misunderstood of your question and my last mail confused you. Qemu-xen 
didn't have commit a80363, so I report this issue to ask for sync up with qemu 
upstream. Last mail I mean I usually used Qemu Xen tree to do test, and found 
out this issue.


Thanks,
-Xudong


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-03 Thread Roger Pau Monné 
On Fri, Nov 03, 2017 at 01:10:26AM +, Hao, Xudong wrote:
> 
> > -Original Message-
> > From: Julien Grall [mailto:julien.gr...@linaro.org]
> > Sent: Thursday, November 2, 2017 9:50 PM
> > To: Stefano Stabellini <sstabell...@kernel.org>
> > Cc: Hao, Xudong <xudong@intel.com>; Jan Beulich <jbeul...@suse.com>;
> > Quan Xu <quan@gmail.com>; Lars Kurth <lars.ku...@citrix.com>; Wei Liu
> > <wei.l...@citrix.com>; Zhang, PengtaoX <pengtaox.zh...@intel.com>; Kang,
> > Luwei <luwei.k...@intel.com>; Julien Grall <julien.gr...@arm.com>; Anthony
> > PERARD <anthony.per...@citrix.com>; Xen-devel  > de...@lists.xenproject.org>
> > Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> > 
> > Hi,
> > 
> > On 27/10/17 21:16, Stefano Stabellini wrote:
> > > On Fri, 27 Oct 2017, Julien Grall wrote:
> > >> On 27/10/17 08:27, Hao, Xudong wrote:
> > >>> This bug exist much long time, there are many discussion last year
> > >>> but not a solution then. I call out it now because there is a fix in 
> > >>> qemu
> > upstream:
> > >>> commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > >>> Author: Roger Pau Monne <roger@citrix.com>
> > >>> Date:   Thu Aug 24 16:07:03 2017 +0100
> > >>>
> > >>>   xen/pt: allow QEMU to request MSI unmasking at bind time
> > >>>
> > >>> The fix is not in qemu-xen tree yet, when will qemu-xen sync this
> > >>> fix? Is it possible to catch Xen 4.10's qemu-xen?
> > >>
> > >> I will let Stefano and Anthony providing feedback before giving a
> > >> release-ack here.
> > >
> > > Yes, I think we should backport the commit as it fixes a genuine bug.
> > > The backport is not risk-free but it only affects PCI Passthrough.
> > > Also the commit has been in QEMU for 2 months now.
> > 
> > Does anyone actually tested it with QEMU Xen tree?
> > 
> 
> Qemu Xen tree is default which is in Xen source code configuration file 
> Config.mk, I tested it with it.
> QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git

Can you please make sure you have QEMU commit a80363: xen/pt: allow
QEMU to request MSI unmasking at bind time. AFAICT this is not yet in
the qemu-xen tree.

Roger.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-02 Thread Hao, Xudong 

> -Original Message-
> From: Julien Grall [mailto:julien.gr...@linaro.org]
> Sent: Thursday, November 2, 2017 9:50 PM
> To: Stefano Stabellini <sstabell...@kernel.org>
> Cc: Hao, Xudong <xudong@intel.com>; Jan Beulich <jbeul...@suse.com>;
> Quan Xu <quan@gmail.com>; Lars Kurth <lars.ku...@citrix.com>; Wei Liu
> <wei.l...@citrix.com>; Zhang, PengtaoX <pengtaox.zh...@intel.com>; Kang,
> Luwei <luwei.k...@intel.com>; Julien Grall <julien.gr...@arm.com>; Anthony
> PERARD <anthony.per...@citrix.com>; Xen-devel  de...@lists.xenproject.org>
> Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> 
> Hi,
> 
> On 27/10/17 21:16, Stefano Stabellini wrote:
> > On Fri, 27 Oct 2017, Julien Grall wrote:
> >> On 27/10/17 08:27, Hao, Xudong wrote:
> >>> This bug exist much long time, there are many discussion last year
> >>> but not a solution then. I call out it now because there is a fix in qemu
> upstream:
> >>> commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> >>> Author: Roger Pau Monne <roger@citrix.com>
> >>> Date:   Thu Aug 24 16:07:03 2017 +0100
> >>>
> >>>   xen/pt: allow QEMU to request MSI unmasking at bind time
> >>>
> >>> The fix is not in qemu-xen tree yet, when will qemu-xen sync this
> >>> fix? Is it possible to catch Xen 4.10's qemu-xen?
> >>
> >> I will let Stefano and Anthony providing feedback before giving a
> >> release-ack here.
> >
> > Yes, I think we should backport the commit as it fixes a genuine bug.
> > The backport is not risk-free but it only affects PCI Passthrough.
> > Also the commit has been in QEMU for 2 months now.
> 
> Does anyone actually tested it with QEMU Xen tree?
> 

Qemu Xen tree is default which is in Xen source code configuration file 
Config.mk, I tested it with it.
QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git


Thanks,
-Xudong


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-02 Thread Julien Grall 

Hi,

On 27/10/17 21:16, Stefano Stabellini wrote:

On Fri, 27 Oct 2017, Julien Grall wrote:

On 27/10/17 08:27, Hao, Xudong wrote:

This bug exist much long time, there are many discussion last year but not a
solution then. I call out it now because there is a fix in qemu upstream:
commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
Author: Roger Pau Monne 
Date:   Thu Aug 24 16:07:03 2017 +0100

  xen/pt: allow QEMU to request MSI unmasking at bind time

The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? Is it
possible to catch Xen 4.10's qemu-xen?


I will let Stefano and Anthony providing feedback before giving a release-ack
here.


Yes, I think we should backport the commit as it fixes a genuine bug.
The backport is not risk-free but it only affects PCI Passthrough. Also
the commit has been in QEMU for 2 months now.


Does anyone actually tested it with QEMU Xen tree?

Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-10-29 Thread Hao, Xudong 
> -Original Message-
> From: Julien Grall [mailto:julien.gr...@linaro.org]
> Sent: Friday, October 27, 2017 6:41 PM
> To: Hao, Xudong <xudong@intel.com>; Jan Beulich <jbeul...@suse.com>;
> Quan Xu <quan@gmail.com>
> Cc: Lars Kurth <lars.ku...@citrix.com>; sstabell...@kernel.org; Wei Liu
> <wei.l...@citrix.com>; Zhang, PengtaoX <pengtaox.zh...@intel.com>; Kang,
> Luwei <luwei.k...@intel.com>; Julien Grall <julien.gr...@arm.com>; Anthony
> PERARD <anthony.per...@citrix.com>; Xen-devel  de...@lists.xenproject.org>
> Subject: Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> 
> Hi,
> 
> On 27/10/17 08:27, Hao, Xudong wrote:
> > This bug exist much long time, there are many discussion last year but not a
> solution then. I call out it now because there is a fix in qemu upstream:
> > commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > Author: Roger Pau Monne <roger@citrix.com>
> > Date:   Thu Aug 24 16:07:03 2017 +0100
> >
> >  xen/pt: allow QEMU to request MSI unmasking at bind time
> >
> > The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? Is it
> possible to catch Xen 4.10's qemu-xen?
> 
> I will let Stefano and Anthony providing feedback before giving a release-ack
> here.
> 
> >
> > BTW, mail report bug is direct but not easy to track, I took much time to
> search this BUG report mail. @Lars, is there plan to introduce any bug system
> for Xen?
> 
> We recently introduced Jira ([1]) to track features and bugs.
> 
> [1] https://xenproject.atlassian.net/projects/XEN/issues.
> 

Happy to see that bugs is tracked on it as well.


Thanks,
-Xudong

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-10-27 Thread Stefano Stabellini 
On Fri, 27 Oct 2017, Julien Grall wrote:
> On 27/10/17 08:27, Hao, Xudong wrote:
> > This bug exist much long time, there are many discussion last year but not a
> > solution then. I call out it now because there is a fix in qemu upstream:
> > commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > Author: Roger Pau Monne 
> > Date:   Thu Aug 24 16:07:03 2017 +0100
> > 
> >  xen/pt: allow QEMU to request MSI unmasking at bind time
> > 
> > The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? Is it
> > possible to catch Xen 4.10's qemu-xen?
> 
> I will let Stefano and Anthony providing feedback before giving a release-ack
> here.

Yes, I think we should backport the commit as it fixes a genuine bug.
The backport is not risk-free but it only affects PCI Passthrough. Also
the commit has been in QEMU for 2 months now.


> > 
> > BTW, mail report bug is direct but not easy to track, I took much time to
> > search this BUG report mail. @Lars, is there plan to introduce any bug
> > system for Xen?
> 
> We recently introduced Jira ([1]) to track features and bugs.
> 
> [1] https://xenproject.atlassian.net/projects/XEN/issues.
> 
> Cheers,
> 
> -- 
> Julien Grall
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-10-27 Thread Julien Grall 

Hi,

On 27/10/17 08:27, Hao, Xudong wrote:

This bug exist much long time, there are many discussion last year but not a 
solution then. I call out it now because there is a fix in qemu upstream:
commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
Author: Roger Pau Monne 
Date:   Thu Aug 24 16:07:03 2017 +0100

 xen/pt: allow QEMU to request MSI unmasking at bind time

The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? Is it 
possible to catch Xen 4.10's qemu-xen?


I will let Stefano and Anthony providing feedback before giving a 
release-ack here.




BTW, mail report bug is direct but not easy to track, I took much time to 
search this BUG report mail. @Lars, is there plan to introduce any bug system 
for Xen?


We recently introduced Jira ([1]) to track features and bugs.

[1] https://xenproject.atlassian.net/projects/XEN/issues.

Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-10-27 Thread Hao, Xudong 
> -Original Message-
> From: Jan Beulich [mailto:jbeul...@suse.com]
> Sent: Friday, October 27, 2017 4:38 PM
> To: Julien Grall <julien.gr...@arm.com>; Anthony PERARD
> <anthony.per...@citrix.com>; Hao, Xudong <xudong@intel.com>;
> sstabell...@kernel.org
> Cc: Lars Kurth <lars.ku...@citrix.com>; Wei Liu <wei.l...@citrix.com>; Quan Xu
> <quan@gmail.com>; Kang, Luwei <luwei.k...@intel.com>; Zhang,
> PengtaoX <pengtaox.zh...@intel.com>; Xen-devel  de...@lists.xenproject.org>
> Subject: RE: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> 
> >>> On 27.10.17 at 09:27, <xudong@intel.com> wrote:
> > This bug exist much long time, there are many discussion last year but
> > not a solution then. I call out it now because there is a fix in qemu 
> > upstream:
> > commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > Author: Roger Pau Monne <roger@citrix.com>
> > Date:   Thu Aug 24 16:07:03 2017 +0100
> >
> > xen/pt: allow QEMU to request MSI unmasking at bind time
> >
> > The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix?
> > Is it possible to catch Xen 4.10's qemu-xen?
> 
> Well, the question shouldn't have been directed at Quan or me - at this point 
> it
> would need to be sorted out between the qemu maintainers (Stefano and
> Anthony) and the release manager (Julien).
> 
Yes, Thanks to point out it. I just replied this mail (default is you two), and 
CC the two qemu maintainers and Julien.


Thanks,
-Xudong

> Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-10-27 Thread Jan Beulich 
>>> On 27.10.17 at 09:27,  wrote:
> This bug exist much long time, there are many discussion last year but not a 
> solution then. I call out it now because there is a fix in qemu upstream:
> commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> Author: Roger Pau Monne 
> Date:   Thu Aug 24 16:07:03 2017 +0100
> 
> xen/pt: allow QEMU to request MSI unmasking at bind time
> 
> The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? Is it 
> possible to catch Xen 4.10's qemu-xen?

Well, the question shouldn't have been directed at Quan or me -
at this point it would need to be sorted out between the qemu
maintainers (Stefano and Anthony) and the release manager
(Julien).

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-10-27 Thread Hao, Xudong 
This bug exist much long time, there are many discussion last year but not a 
solution then. I call out it now because there is a fix in qemu upstream:
commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
Author: Roger Pau Monne <roger@citrix.com>
Date:   Thu Aug 24 16:07:03 2017 +0100

xen/pt: allow QEMU to request MSI unmasking at bind time

The fix is not in qemu-xen tree yet, when will qemu-xen sync this fix? Is it 
possible to catch Xen 4.10's qemu-xen?

BTW, mail report bug is direct but not easy to track, I took much time to 
search this BUG report mail. @Lars, is there plan to introduce any bug system 
for Xen?


Thanks,
-Xudong


> -Original Message-
> From: Xu, Quan
> Sent: Wednesday, June 8, 2016 5:12 PM
> To: Jan Beulich <jbeul...@suse.com>; Hao, Xudong <xudong@intel.com>
> Cc: Wei Liu <wei.l...@citrix.com>; Zhang, PengtaoX
> <pengtaox.zh...@intel.com>; Xen-devel <xen-de...@lists.xenproject.org>
> Subject: RE: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov
> 
> On June 07, 2016 3:50 PM, Jan Beulich <jbeul...@suse.com> wrote:
> > >>> On 07.06.16 at 07:52, <quan...@intel.com> wrote:
> > > -vf PT is not working for win2008: the logs:
> > >qemu-dm-win2k8.log -- qemu log, vf PT for win2008.
> > >xen-win2k8.log -- xen log, vf PT for win2008.
> >
> > Hmm, that's very little output. In particular neither qemu nor Xen see
> > _any_ writes to the MSI-X table (without which interrupts obviously
> > can't get enabled for that device).
> >
> > Albeit - even in the SLES case only qemu sees such writes, so I'll
> > have to check if I made a mistake with the debugging patch.
> >
> 
> Jan,  do you have any other suggestions on how could I dig into this issue?
> 
> Quan

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-08 Thread Jan Beulich 
>>> On 08.06.16 at 11:12,  wrote:
> On June 07, 2016 3:50 PM, Jan Beulich  wrote:
>> >>> On 07.06.16 at 07:52,  wrote:
>> > -vf PT is not working for win2008: the logs:
>> >qemu-dm-win2k8.log -- qemu log, vf PT for win2008.
>> >xen-win2k8.log -- xen log, vf PT for win2008.
>> 
>> Hmm, that's very little output. In particular neither qemu nor Xen see _any_
>> writes to the MSI-X table (without which interrupts obviously can't get
>> enabled for that device).
>> 
>> Albeit - even in the SLES case only qemu sees such writes, so I'll have to 
> check
>> if I made a mistake with the debugging patch.
>> 
> 
> Jan,  do you have any other suggestions on how could I dig into this issue?

Well - first of all, provide a log with the cable plugged in.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-08 Thread Xu, Quan 
On June 07, 2016 3:50 PM, Jan Beulich  wrote:
> >>> On 07.06.16 at 07:52,  wrote:
> > -vf PT is not working for win2008: the logs:
> >qemu-dm-win2k8.log -- qemu log, vf PT for win2008.
> >xen-win2k8.log -- xen log, vf PT for win2008.
> 
> Hmm, that's very little output. In particular neither qemu nor Xen see _any_
> writes to the MSI-X table (without which interrupts obviously can't get
> enabled for that device).
> 
> Albeit - even in the SLES case only qemu sees such writes, so I'll have to 
> check
> if I made a mistake with the debugging patch.
> 

Jan,  do you have any other suggestions on how could I dig into this issue?

Quan

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-07 Thread Xu, Quan 
On June 07, 2016 4:09 PM, Jan Beulich  wrote:
> >>> On 07.06.16 at 09:49,  wrote:
>  On 07.06.16 at 07:52,  wrote:
> >> -vf PT is not working for win2008: the logs:
> >>qemu-dm-win2k8.log -- qemu log, vf PT for win2008.
> >>xen-win2k8.log -- xen log, vf PT for win2008.
> >
> > Hmm, that's very little output. In particular neither qemu nor Xen see
> > _any_ writes to the MSI-X table (without which interrupts obviously
> > can't get enabled for that device).
> >
> > Albeit - even in the SLES case only qemu sees such writes, so I'll
> > have to check if I made a mistake with the debugging patch.
> 
> With the exact same patches I do see MSI-X table writes logged with both SLES
> 11 and SLES 12  guests. What's going on here?
> 

The internet cable is not plugged in for that NIC.

Quan 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-07 Thread Jan Beulich 
>>> On 07.06.16 at 09:49,  wrote:
 On 07.06.16 at 07:52,  wrote:
>> -vf PT is not working for win2008: the logs:
>>qemu-dm-win2k8.log -- qemu log, vf PT for win2008.
>>xen-win2k8.log -- xen log, vf PT for win2008.
> 
> Hmm, that's very little output. In particular neither qemu nor Xen
> see _any_ writes to the MSI-X table (without which interrupts
> obviously can't get enabled for that device).
> 
> Albeit - even in the SLES case only qemu sees such writes, so I'll
> have to check if I made a mistake with the debugging patch.

With the exact same patches I do see MSI-X table writes logged
with both SLES 11 and SLES 12  guests. What's going on here?

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-07 Thread Xu, Quan 
On June 07, 2016 3:50 PM, Jan Beulich  wrote:
> >>> On 07.06.16 at 07:52,  wrote:
> > -vf PT is not working for win2008: the logs:
> >qemu-dm-win2k8.log -- qemu log, vf PT for win2008.
> >xen-win2k8.log -- xen log, vf PT for win2008.
> 
> Hmm, that's very little output. In particular neither qemu nor Xen see _any_
> writes to the MSI-X table (without which interrupts obviously can't get
> enabled for that device).
> 
> Albeit - even in the SLES case only qemu sees such writes, so I'll have to 
> check
> if I made a mistake with the debugging patch.
> 

I added more print-out when I debugged it.. I'll call Jianzhong, Chang for more 
information..
I __guess__ he makes vf work for win2008.

Quan

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-07 Thread Jan Beulich 
>>> On 07.06.16 at 07:52,  wrote:
> -vf PT is not working for win2008: the logs:
>qemu-dm-win2k8.log -- qemu log, vf PT for win2008.
>xen-win2k8.log -- xen log, vf PT for win2008.

Hmm, that's very little output. In particular neither qemu nor Xen
see _any_ writes to the MSI-X table (without which interrupts
obviously can't get enabled for that device).

Albeit - even in the SLES case only qemu sees such writes, so I'll
have to check if I made a mistake with the debugging patch.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-07 Thread Jan Beulich 
>>> On 07.06.16 at 08:07,  wrote:
> On June 07, 2016 1:52 PM, Xu, Quan  wrote:
>> On June 02, 2016 8:09 PM, Jan Beulich  wrote:
>>
> 
> Sorry, this below part is about NIC PF pass-through for win2008..
>  
>> btw, when I updated the NIC driver for win2008,  actually, it is working.
>> Xudong, could you help me verify it again?
>> 
>> ((
>> xen commit: bbfd2d6ccb31a3aeea49c8f9c7884792ddc26e3b
>> NIC: Intel Corporation I350 Gigabit Network Connection
>>  new win2k8 NIC
>> driver ,https://downloadcenter.intel.com/download/18720/Network- 
>> Adapter-Driver-for-Windows-Server-2008-Final-Release?product=59679
>> ))
>> 
>> qemu-dm-TestDom.log -- qemu log, pf PT for win2008.

Okay, but could you please make explicit what works and what
doesn't? I.e. do I take this to mean a passed through PF does
work (at least with the newer driver, maybe also with an older
one), while a passed through VF doesn't work (regardless of
driver version)? Especially with you (earlier) suspecting a driver
issue, precise information here is quite relevant.

Thanks, Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-07 Thread Xu, Quan 
On June 07, 2016 1:52 PM, Xu, Quan  wrote:
> On June 02, 2016 8:09 PM, Jan Beulich  wrote:
>

Sorry, this below part is about NIC PF pass-through for win2008..
 
> btw, when I updated the NIC driver for win2008,  actually, it is working.
> Xudong, could you help me verify it again?
> 
> ((
> xen commit: bbfd2d6ccb31a3aeea49c8f9c7884792ddc26e3b
> NIC: Intel Corporation I350 Gigabit Network Connection
>  new win2k8 NIC
> driver ,https://downloadcenter.intel.com/download/18720/Network-
> Adapter-Driver-for-Windows-Server-2008-Final-Release?product=59679
> ))
> 
> qemu-dm-TestDom.log -- qemu log, pf PT for win2008.
> 
> 
... :(:(

Quan

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-06 Thread Xu, Quan 
On June 02, 2016 8:09 PM, Jan Beulich  wrote:
> Attached both a hypervisor and a qemu patch. Their plus
> debug key M and i output is what I'd like to start with.

Applied these two patches, the attach files are logs.

-vf PT is working for SLES 12. The logs:
   qemu-dm-sles.log -- qemu log, vf PT for sles 12.
   xen-sles.log -- xen log, vf PT for sles 12.

-vf PT is not working for win2008: the logs:
   qemu-dm-win2k8.log -- qemu log, vf PT for win2008.
   xen-win2k8.log -- xen log, vf PT for win2008.


btw, when I updated the NIC driver for win2008,  actually, it is working.  
Xudong, could you help me verify it again?

((
xen commit: bbfd2d6ccb31a3aeea49c8f9c7884792ddc26e3b
NIC: Intel Corporation I350 Gigabit Network Connection
 new win2k8 NIC driver 
,https://downloadcenter.intel.com/download/18720/Network-Adapter-Driver-for-Windows-Server-2008-Final-Release?product=59679
))

qemu-dm-TestDom.log -- qemu log, pf PT for win2008.


... taken together, IMO, from qemu-dm-win2k8.log(also I have read xen/QEMU 
code), the win2k8 vf nic driver is not loading. (any idea, feel free to let me 
know. I will help you try as much as I can..).

Thoughts?

Quan


qemu-dm-sles.log
Description: qemu-dm-sles.log


qemu-dm-TestDom.log
Description: qemu-dm-TestDom.log


qemu-dm-win2k8.log
Description: qemu-dm-win2k8.log


xen-sles.log
Description: xen-sles.log


xen-win2k8.log
Description: xen-win2k8.log
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Xu, Quan 


On June 02, 2016 9:30 PM, Jan Beulich  wrote:
> >>> On 02.06.16 at 15:05,  wrote:
> > On June 02, 2016 8:09 PM, Jan Beulich  wrote:
> >> >>> On 02.06.16 at 13:03,  wrote:
> >> > On Thu, Jun 02, 2016 at 04:38:47AM -0600, Jan Beulich wrote:
> >> >> >>> On 02.06.16 at 12:22,  wrote:
> >> >> > On Thu, Jun 02, 2016 at 07:31:06AM +, Xu, Quan wrote:
> >> >> >> On May 27, 2016 10:06 PM, Jan Beulich 
> wrote:
> >> >> >> > >>> On 27.05.16 at 15:34,  wrote:
> >> >> >> > > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
> >> >> >> > >> >>> On 27.05.16 at 12:39,  wrote:
> >> >> >> > >> > Is this a regression? Does it work on previous versions of 
> >> >> >> > >> > Xen?
> >> >> >> > >>
> >> >> >> > >> I think this is what was already reported by other Intel
> >> >> >> > >> people, see e.g. Quan's most recent reply:
> >> >> >> > >> http://lists.xenproject.org/archives/html/xen-devel/2016-
> >> 05/msg01896.
> >> >> >> > >> html It is not clear where the problem is, and not seeing
> >> >> >> > >> the issue myself makes it hard to analyze. In any event
> >> >> >> > >> this quite likely is a regression.
> >> >> >> > >>
> >> >> >> > >
> >> >> >> > > My reading of that email thread and all relevant links
> >> >> >> > > (including the KVM bug report) is that there is a
> >> >> >> > > regression vf driver,
> >> but not in Xen.
> >> >> >> >
> >> >> >> > Just from reading that I would tend to agree. But the report
> >> >> >> > here is about Win2K8.
> >> >> >>
> >> >> >> Do you know which commit is a regression one? I try to find out
> >> >> >> the
> >> >> > regression commit.  That may be helpful to find out the root cause.
> >> >> >>
> >> >> >> Btw, some feedback from QA team, rhel 6.4 VM  doesn't work, but
> >> >> >> rhel 7.2 VM
> >> > does.
> >> >> >
> >> >> > Isn't this at least an indication that the guest could be buggy here?
> >> >> > It could also be both the hypervsior and guest have bugs. But
> >> >> > we're just not sure at this point.
> >> >>
> >> >> Indeed, and (with the many fixes that went in already) I really
> >> >> suspect a combination of both, or some of the involved hypervisor
> >> >> changes having unmasked some guest issue. Regardless, I'm afraid
> >> >> this ought to be treated as a blocker for the release at least
> >> >> until we understand what the issue is. But otoh making it a
> >> >> blocker probably makes sense only if we can expect progress (which
> >> >> we haven't really made for quite long a time).
> >> >>
> >> >
> >> > This issue is on my list, but the information gathered so far isn't
> >> > convincing enough to make it a blocker.
> >> >
> >> > And yes, we need meaningful progress to make it a blocker. To make
> >> > it so, commitment from various parties is needed. Let's start with
> >> > setting out things to look at, who is going to investigate what,
> >> > and a possible timeline for each item.
> >> >
> >> > Jan, can you come up with a list of what sort of information you need?
> >>
> >> Well, I had hoped to avoid that. But now that you ask for it,
> >> providing an
> > initial
> >> debugging patch seems better than a description which may get
> >> misunderstood. Attached both a hypervisor and a qemu patch. Their
> >> plus debug key M and i output is what I'd like to start with.
> >>
> >
> >
> >  I will try these 2 patches.
> >
> > btw. I read the internal Bugzilla carefully. I found that vf is
> > working for
> > win2k8  at  '2014-12-01 14:32:09 EST', but the bug still exist on '
> > 2015-02-11
> > 15:54:05 EST '.
> > then, I grepped the commit logs, the below 4 MSI-X related commits are
> > may the root cause.
> 
> DYM "vif is not working", or is the use of "still" wrong (or at least 
> misleading in
> this context)? Because if the two dates frame the introduction of the bug,
> then it must be something completely different from what I so far have been
> thinking of.
> 
> > From 6fb3a07bc0ad656b5f76eb9fc961bcd1d3cace58 Mon Sep 17
> 00:00:00 2001
> > From: Jan Beulich 
> > Date: Fri, 12 Dec 2014 10:24:13 +
> > Subject: [PATCH 13/44] domctl: fix IRQ permission granting/revocation
> >
> >
> > From 1965728cd5a1635859158f5800d844fc16774668 Mon Sep 17
> 00:00:00 2001
> > From: Konrad Rzeszutek Wilk 
> > Date: Mon, 12 Jan 2015 11:29:33 -0500
> > Subject: [PATCH 42/44] Revert "dpci: add 'masked' as a gate for
> > hvm_dirq_assist to process"
> >
> >
> > From 72f3c1e26e96686a41d2de1663e578538659f99a Mon Sep 17
> 00:00:00 2001
> > From: Konrad Rzeszutek Wilk 
> > Date: Mon, 12 Jan 2015 11:30:00 -0500
> > Subject: [PATCH 43/44] Revert "dpci: replace tasklet with softirq"
> >
> > rom a8ac2290ed95dbbc0dc1bdde86fc3a49fe784b28 Mon Sep 17
> 00:00:00 2001
> > From: Konrad Rzeszutek Wilk 
> > Date: Mon, 12 Jan 2015 11:30:05 -0500
> >

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Jan Beulich 
>>> On 02.06.16 at 15:05,  wrote:
> On June 02, 2016 8:09 PM, Jan Beulich  wrote:
>> >>> On 02.06.16 at 13:03,  wrote:
>> > On Thu, Jun 02, 2016 at 04:38:47AM -0600, Jan Beulich wrote:
>> >> >>> On 02.06.16 at 12:22,  wrote:
>> >> > On Thu, Jun 02, 2016 at 07:31:06AM +, Xu, Quan wrote:
>> >> >> On May 27, 2016 10:06 PM, Jan Beulich  wrote:
>> >> >> > >>> On 27.05.16 at 15:34,  wrote:
>> >> >> > > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
>> >> >> > >> >>> On 27.05.16 at 12:39,  wrote:
>> >> >> > >> > Is this a regression? Does it work on previous versions of Xen?
>> >> >> > >>
>> >> >> > >> I think this is what was already reported by other Intel
>> >> >> > >> people, see e.g. Quan's most recent reply:
>> >> >> > >> http://lists.xenproject.org/archives/html/xen-devel/2016- 
>> 05/msg01896.
>> >> >> > >> html It is not clear where the problem is, and not seeing the
>> >> >> > >> issue myself makes it hard to analyze. In any event this
>> >> >> > >> quite likely is a regression.
>> >> >> > >>
>> >> >> > >
>> >> >> > > My reading of that email thread and all relevant links
>> >> >> > > (including the KVM bug report) is that there is a regression vf 
>> >> >> > > driver,
>> but not in Xen.
>> >> >> >
>> >> >> > Just from reading that I would tend to agree. But the report
>> >> >> > here is about Win2K8.
>> >> >>
>> >> >> Do you know which commit is a regression one? I try to find out
>> >> >> the
>> >> > regression commit.  That may be helpful to find out the root cause.
>> >> >>
>> >> >> Btw, some feedback from QA team, rhel 6.4 VM  doesn't work, but
>> >> >> rhel 7.2 VM
>> > does.
>> >> >
>> >> > Isn't this at least an indication that the guest could be buggy here?
>> >> > It could also be both the hypervsior and guest have bugs. But we're
>> >> > just not sure at this point.
>> >>
>> >> Indeed, and (with the many fixes that went in already) I really
>> >> suspect a combination of both, or some of the involved hypervisor
>> >> changes having unmasked some guest issue. Regardless, I'm afraid this
>> >> ought to be treated as a blocker for the release at least until we
>> >> understand what the issue is. But otoh making it a blocker probably
>> >> makes sense only if we can expect progress (which we haven't really
>> >> made for quite long a time).
>> >>
>> >
>> > This issue is on my list, but the information gathered so far isn't
>> > convincing enough to make it a blocker.
>> >
>> > And yes, we need meaningful progress to make it a blocker. To make it
>> > so, commitment from various parties is needed. Let's start with
>> > setting out things to look at, who is going to investigate what, and a
>> > possible timeline for each item.
>> >
>> > Jan, can you come up with a list of what sort of information you need?
>> 
>> Well, I had hoped to avoid that. But now that you ask for it, providing an 
> initial
>> debugging patch seems better than a description which may get
>> misunderstood. Attached both a hypervisor and a qemu patch. Their plus
>> debug key M and i output is what I'd like to start with.
>> 
> 
> 
>  I will try these 2 patches.
> 
> btw. I read the internal Bugzilla carefully. I found that vf is working for 
> win2k8  at  '2014-12-01 14:32:09 EST', but the bug still exist on ' 
> 2015-02-11 
> 15:54:05 EST '.
> then, I grepped the commit logs, the below 4 MSI-X related commits are may 
> the root cause.

DYM "vif is not working", or is the use of "still" wrong (or at least
misleading in this context)? Because if the two dates frame the
introduction of the bug, then it must be something completely
different from what I so far have been thinking of.

> From 6fb3a07bc0ad656b5f76eb9fc961bcd1d3cace58 Mon Sep 17 00:00:00 2001
> From: Jan Beulich 
> Date: Fri, 12 Dec 2014 10:24:13 +
> Subject: [PATCH 13/44] domctl: fix IRQ permission granting/revocation
> 
> 
> From 1965728cd5a1635859158f5800d844fc16774668 Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk 
> Date: Mon, 12 Jan 2015 11:29:33 -0500
> Subject: [PATCH 42/44] Revert "dpci: add 'masked' as a gate for
>  hvm_dirq_assist to process"
> 
> 
> From 72f3c1e26e96686a41d2de1663e578538659f99a Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk 
> Date: Mon, 12 Jan 2015 11:30:00 -0500
> Subject: [PATCH 43/44] Revert "dpci: replace tasklet with softirq"
> 
> rom a8ac2290ed95dbbc0dc1bdde86fc3a49fe784b28 Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk 
> Date: Mon, 12 Jan 2015 11:30:05 -0500
> Subject: [PATCH 44/44] Revert "dpci: move from an hvm_irq_dpci (and struct
>  domain) to an hvm_dirq_dpci model"

These all pre-date 4.5 - are you saying 4.5.0 (and note, I'm not
asking about 4.5.1 or newer) is also broken? In particular the
reverts above were done on the 4.5 release branch only,

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Xu, Quan 
On June 02, 2016 8:09 PM, Jan Beulich  wrote:
> >>> On 02.06.16 at 13:03,  wrote:
> > On Thu, Jun 02, 2016 at 04:38:47AM -0600, Jan Beulich wrote:
> >> >>> On 02.06.16 at 12:22,  wrote:
> >> > On Thu, Jun 02, 2016 at 07:31:06AM +, Xu, Quan wrote:
> >> >> On May 27, 2016 10:06 PM, Jan Beulich  wrote:
> >> >> > >>> On 27.05.16 at 15:34,  wrote:
> >> >> > > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
> >> >> > >> >>> On 27.05.16 at 12:39,  wrote:
> >> >> > >> > Is this a regression? Does it work on previous versions of Xen?
> >> >> > >>
> >> >> > >> I think this is what was already reported by other Intel
> >> >> > >> people, see e.g. Quan's most recent reply:
> >> >> > >> http://lists.xenproject.org/archives/html/xen-devel/2016-
> 05/msg01896.
> >> >> > >> html It is not clear where the problem is, and not seeing the
> >> >> > >> issue myself makes it hard to analyze. In any event this
> >> >> > >> quite likely is a regression.
> >> >> > >>
> >> >> > >
> >> >> > > My reading of that email thread and all relevant links
> >> >> > > (including the KVM bug report) is that there is a regression vf 
> >> >> > > driver,
> but not in Xen.
> >> >> >
> >> >> > Just from reading that I would tend to agree. But the report
> >> >> > here is about Win2K8.
> >> >>
> >> >> Do you know which commit is a regression one? I try to find out
> >> >> the
> >> > regression commit.  That may be helpful to find out the root cause.
> >> >>
> >> >> Btw, some feedback from QA team, rhel 6.4 VM  doesn't work, but
> >> >> rhel 7.2 VM
> > does.
> >> >
> >> > Isn't this at least an indication that the guest could be buggy here?
> >> > It could also be both the hypervsior and guest have bugs. But we're
> >> > just not sure at this point.
> >>
> >> Indeed, and (with the many fixes that went in already) I really
> >> suspect a combination of both, or some of the involved hypervisor
> >> changes having unmasked some guest issue. Regardless, I'm afraid this
> >> ought to be treated as a blocker for the release at least until we
> >> understand what the issue is. But otoh making it a blocker probably
> >> makes sense only if we can expect progress (which we haven't really
> >> made for quite long a time).
> >>
> >
> > This issue is on my list, but the information gathered so far isn't
> > convincing enough to make it a blocker.
> >
> > And yes, we need meaningful progress to make it a blocker. To make it
> > so, commitment from various parties is needed. Let's start with
> > setting out things to look at, who is going to investigate what, and a
> > possible timeline for each item.
> >
> > Jan, can you come up with a list of what sort of information you need?
> 
> Well, I had hoped to avoid that. But now that you ask for it, providing an 
> initial
> debugging patch seems better than a description which may get
> misunderstood. Attached both a hypervisor and a qemu patch. Their plus
> debug key M and i output is what I'd like to start with.
> 


 I will try these 2 patches.

btw. I read the internal Bugzilla carefully. I found that vf is working for 
win2k8  at  '2014-12-01 14:32:09 EST', but the bug still exist on ' 2015-02-11 
15:54:05 EST '.
then, I grepped the commit logs, the below 4 MSI-X related commits are may the 
root cause.


From 6fb3a07bc0ad656b5f76eb9fc961bcd1d3cace58 Mon Sep 17 00:00:00 2001
From: Jan Beulich 
Date: Fri, 12 Dec 2014 10:24:13 +
Subject: [PATCH 13/44] domctl: fix IRQ permission granting/revocation


From 1965728cd5a1635859158f5800d844fc16774668 Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk 
Date: Mon, 12 Jan 2015 11:29:33 -0500
Subject: [PATCH 42/44] Revert "dpci: add 'masked' as a gate for
 hvm_dirq_assist to process"


From 72f3c1e26e96686a41d2de1663e578538659f99a Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk 
Date: Mon, 12 Jan 2015 11:30:00 -0500
Subject: [PATCH 43/44] Revert "dpci: replace tasklet with softirq"

rom a8ac2290ed95dbbc0dc1bdde86fc3a49fe784b28 Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk 
Date: Mon, 12 Jan 2015 11:30:05 -0500
Subject: [PATCH 44/44] Revert "dpci: move from an hvm_irq_dpci (and struct
 domain) to an hvm_dirq_dpci model"

Quan


> Jan
> 
> > And then maybe Quan and Pengtao can give an estimation on how long it
> > takes to gather all necessary information and move on to next stage.
> >
> > Wei.
> >
> >> Jan
> >>
> 
> 


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Jan Beulich 
>>> On 02.06.16 at 13:03,  wrote:
> On Thu, Jun 02, 2016 at 04:38:47AM -0600, Jan Beulich wrote:
>> >>> On 02.06.16 at 12:22,  wrote:
>> > On Thu, Jun 02, 2016 at 07:31:06AM +, Xu, Quan wrote:
>> >> On May 27, 2016 10:06 PM, Jan Beulich  wrote:
>> >> > >>> On 27.05.16 at 15:34,  wrote:
>> >> > > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
>> >> > >> >>> On 27.05.16 at 12:39,  wrote:
>> >> > >> > Is this a regression? Does it work on previous versions of Xen?
>> >> > >>
>> >> > >> I think this is what was already reported by other Intel people, see
>> >> > >> e.g. Quan's most recent reply:
>> >> > >> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.
>> >> > >> html It is not clear where the problem is, and not seeing the issue
>> >> > >> myself makes it hard to analyze. In any event this quite likely is a
>> >> > >> regression.
>> >> > >>
>> >> > >
>> >> > > My reading of that email thread and all relevant links (including the
>> >> > > KVM bug report) is that there is a regression vf driver, but not in 
>> >> > > Xen.
>> >> > 
>> >> > Just from reading that I would tend to agree. But the report here is 
>> >> > about
>> >> > Win2K8.
>> >> 
>> >> Do you know which commit is a regression one? I try to find out the 
>> > regression commit.  That may be helpful to find out the root cause.
>> >> 
>> >> Btw, some feedback from QA team, rhel 6.4 VM  doesn't work, but rhel 7.2 
>> >> VM 
> does.
>> > 
>> > Isn't this at least an indication that the guest could be buggy here?
>> > It could also be both the hypervsior and guest have bugs. But we're just
>> > not sure at this point.
>> 
>> Indeed, and (with the many fixes that went in already) I really
>> suspect a combination of both, or some of the involved hypervisor
>> changes having unmasked some guest issue. Regardless, I'm
>> afraid this ought to be treated as a blocker for the release at
>> least until we understand what the issue is. But otoh making it a
>> blocker probably makes sense only if we can expect progress
>> (which we haven't really made for quite long a time).
>> 
> 
> This issue is on my list, but the information gathered so far isn't
> convincing enough to make it a blocker.
> 
> And yes, we need meaningful progress to make it a blocker. To make it
> so, commitment from various parties is needed. Let's start with setting
> out things to look at, who is going to investigate what, and a possible
> timeline for each item.
> 
> Jan, can you come up with a list of what sort of information you need?

Well, I had hoped to avoid that. But now that you ask for it,
providing an initial debugging patch seems better than a
description which may get misunderstood. Attached both a
hypervisor and a qemu patch. Their plus debug key M and i
output is what I'd like to start with.

Jan

> And then maybe Quan and Pengtao can give an estimation on how long it
> takes to gather all necessary information and move on to next stage.
> 
> Wei.
> 
>> Jan
>> 



--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -276,6 +276,7 @@ static int msixtbl_write(struct vcpu *v,
 if ( !entry )
 goto out;
 nr_entry = (address - entry->gtable) / PCI_MSIX_ENTRY_SIZE;
+printk("%pv: write MSI-X#%u: [%lx]=%0*lx\n", v, nr_entry, address, (int)len * 
2, val);//temp
 
 offset = address & (PCI_MSIX_ENTRY_SIZE - 1);
 if ( offset != PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET )
@@ -321,7 +322,17 @@ static int msixtbl_write(struct vcpu *v,
 
 ASSERT(msi_desc == desc->msi_desc);

+{//temp
+ bool_t h = msi_desc->msi_attrib.host_masked;
+ bool_t g = msi_desc->msi_attrib.guest_masked;
+ bool_t ha = entry->pdev->msix->host_maskall;
+ bool_t ga = entry->pdev->msix->guest_maskall;
 guest_mask_msi_irq(desc, !!(val & PCI_MSIX_VECTOR_BITMASK));
+ printk("%pv: MSI-X#%u %d(%d) / %d(%d) -> %d(%d) / %d(%d)\n",
+v, nr_entry, h, ha, g, ga,
+msi_desc->msi_attrib.host_masked, entry->pdev->msix->host_maskall,
+msi_desc->msi_attrib.guest_masked, entry->pdev->msix->guest_maskall);
+}
 
 unlock:
 spin_unlock_irqrestore(>lock, flags);
@@ -330,6 +341,7 @@ unlock:
 
 out:
 rcu_read_unlock(_rcu_lock);
+printk("%pv: write MSI-X [%lx] -> %d\n", v, address, r);//temp
 return r;
 }
 
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -438,6 +438,10 @@ static bool_t msi_set_mask_bit(struct ir
 if ( likely(control & PCI_MSIX_FLAGS_ENABLE) )
 break;
 
+if(pdev->info.is_virtfn) {//temp
+ printk("%04x:%02x:%02x.%o#%u: %d/%d >> %d/%d [%p]\n", seg, bus, slot, func, 
entry->msi_attrib.entry_nr,
+entry->msi_attrib.host_masked, entry->msi_attrib.guest_masked, host, 
guest, __builtin_return_address(0));
+}
 entry->msi_attrib.host_masked = host;
 entry->msi_attrib.guest_masked = guest;
 
@@ -1305,6 +1309,11 @@ int pci_msi_conf_write_intercept(struct

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Wei Liu 
On Thu, Jun 02, 2016 at 04:38:47AM -0600, Jan Beulich wrote:
> >>> On 02.06.16 at 12:22,  wrote:
> > On Thu, Jun 02, 2016 at 07:31:06AM +, Xu, Quan wrote:
> >> On May 27, 2016 10:06 PM, Jan Beulich  wrote:
> >> > >>> On 27.05.16 at 15:34,  wrote:
> >> > > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
> >> > >> >>> On 27.05.16 at 12:39,  wrote:
> >> > >> > Is this a regression? Does it work on previous versions of Xen?
> >> > >>
> >> > >> I think this is what was already reported by other Intel people, see
> >> > >> e.g. Quan's most recent reply:
> >> > >> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.
> >> > >> html It is not clear where the problem is, and not seeing the issue
> >> > >> myself makes it hard to analyze. In any event this quite likely is a
> >> > >> regression.
> >> > >>
> >> > >
> >> > > My reading of that email thread and all relevant links (including the
> >> > > KVM bug report) is that there is a regression vf driver, but not in 
> >> > > Xen.
> >> > 
> >> > Just from reading that I would tend to agree. But the report here is 
> >> > about
> >> > Win2K8.
> >> 
> >> Do you know which commit is a regression one? I try to find out the 
> > regression commit.  That may be helpful to find out the root cause.
> >> 
> >> Btw, some feedback from QA team, rhel 6.4 VM  doesn't work, but rhel 7.2 
> >> VM does.
> > 
> > Isn't this at least an indication that the guest could be buggy here?
> > It could also be both the hypervsior and guest have bugs. But we're just
> > not sure at this point.
> 
> Indeed, and (with the many fixes that went in already) I really
> suspect a combination of both, or some of the involved hypervisor
> changes having unmasked some guest issue. Regardless, I'm
> afraid this ought to be treated as a blocker for the release at
> least until we understand what the issue is. But otoh making it a
> blocker probably makes sense only if we can expect progress
> (which we haven't really made for quite long a time).
> 

This issue is on my list, but the information gathered so far isn't
convincing enough to make it a blocker.

And yes, we need meaningful progress to make it a blocker. To make it
so, commitment from various parties is needed. Let's start with setting
out things to look at, who is going to investigate what, and a possible
timeline for each item.

Jan, can you come up with a list of what sort of information you need?
And then maybe Quan and Pengtao can give an estimation on how long it
takes to gather all necessary information and move on to next stage.

Wei.

> Jan
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Jan Beulich 
>>> On 02.06.16 at 12:22,  wrote:
> On Thu, Jun 02, 2016 at 07:31:06AM +, Xu, Quan wrote:
>> On May 27, 2016 10:06 PM, Jan Beulich  wrote:
>> > >>> On 27.05.16 at 15:34,  wrote:
>> > > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
>> > >> >>> On 27.05.16 at 12:39,  wrote:
>> > >> > Is this a regression? Does it work on previous versions of Xen?
>> > >>
>> > >> I think this is what was already reported by other Intel people, see
>> > >> e.g. Quan's most recent reply:
>> > >> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.
>> > >> html It is not clear where the problem is, and not seeing the issue
>> > >> myself makes it hard to analyze. In any event this quite likely is a
>> > >> regression.
>> > >>
>> > >
>> > > My reading of that email thread and all relevant links (including the
>> > > KVM bug report) is that there is a regression vf driver, but not in Xen.
>> > 
>> > Just from reading that I would tend to agree. But the report here is about
>> > Win2K8.
>> 
>> Do you know which commit is a regression one? I try to find out the 
> regression commit.  That may be helpful to find out the root cause.
>> 
>> Btw, some feedback from QA team, rhel 6.4 VM  doesn't work, but rhel 7.2 VM 
>> does.
> 
> Isn't this at least an indication that the guest could be buggy here?
> It could also be both the hypervsior and guest have bugs. But we're just
> not sure at this point.

Indeed, and (with the many fixes that went in already) I really
suspect a combination of both, or some of the involved hypervisor
changes having unmasked some guest issue. Regardless, I'm
afraid this ought to be treated as a blocker for the release at
least until we understand what the issue is. But otoh making it a
blocker probably makes sense only if we can expect progress
(which we haven't really made for quite long a time).

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Wei Liu 
On Thu, Jun 02, 2016 at 07:31:06AM +, Xu, Quan wrote:
> On May 27, 2016 10:06 PM, Jan Beulich  wrote:
> > >>> On 27.05.16 at 15:34,  wrote:
> > > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
> > >> >>> On 27.05.16 at 12:39,  wrote:
> > >> > Is this a regression? Does it work on previous versions of Xen?
> > >>
> > >> I think this is what was already reported by other Intel people, see
> > >> e.g. Quan's most recent reply:
> > >> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.
> > >> html It is not clear where the problem is, and not seeing the issue
> > >> myself makes it hard to analyze. In any event this quite likely is a
> > >> regression.
> > >>
> > >
> > > My reading of that email thread and all relevant links (including the
> > > KVM bug report) is that there is a regression vf driver, but not in Xen.
> > 
> > Just from reading that I would tend to agree. But the report here is about
> > Win2K8.
> > 
> 
> 
> Jan, 
> Do you know which commit is a regression one? I try to find out the 
> regression commit.  That may be helpful to find out the root cause.
> 
> Btw, some feedback from QA team, rhel 6.4 VM  doesn't work, but rhel 7.2 VM 
> does.
> 

Isn't this at least an indication that the guest could be buggy here?
It could also be both the hypervsior and guest have bugs. But we're just
not sure at this point.

Wei.

> > Jan
> > 
> > > There isn't enough evidence to rule out a bug in Xen, but over all
> > > I'm inclined to think this bug is not in Xen given all the things 
> > > presented.
> > >
> > > Wei.
> > 
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Jan Beulich 
>>> On 02.06.16 at 09:31,  wrote:
> On May 27, 2016 10:06 PM, Jan Beulich  wrote:
>> >>> On 27.05.16 at 15:34,  wrote:
>> > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
>> >> >>> On 27.05.16 at 12:39,  wrote:
>> >> > Is this a regression? Does it work on previous versions of Xen?
>> >>
>> >> I think this is what was already reported by other Intel people, see
>> >> e.g. Quan's most recent reply:
>> >> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.
>> >> html It is not clear where the problem is, and not seeing the issue
>> >> myself makes it hard to analyze. In any event this quite likely is a
>> >> regression.
>> >>
>> >
>> > My reading of that email thread and all relevant links (including the
>> > KVM bug report) is that there is a regression vf driver, but not in Xen.
>> 
>> Just from reading that I would tend to agree. But the report here is about
>> Win2K8.
> 
> Do you know which commit is a regression one? I try to find out the 
> regression commit.  That may be helpful to find out the root cause.

Indeed. There was a lot of rework of MSI-X. Iirc one of your
colleagues had actually narrowed it down a while ago, but I can't
seem to find that mail right now. Nor did it really help understand
what's going wrong (or else we would likely have found a fix for it
already). My primary suspicion was that the interrupt doesn't get
enabled when it should, but the respective fix didn't help that
case (while it did help others). Hence my continued request for
someone being able to observe the problem to simply log guest
actions and what the hypervisor does for them (plus of course
provide all relevant debug information, like debug key output of
interest, for a guest in the broken state).

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-06-02 Thread Xu, Quan 
On May 27, 2016 10:06 PM, Jan Beulich  wrote:
> >>> On 27.05.16 at 15:34,  wrote:
> > On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
> >> >>> On 27.05.16 at 12:39,  wrote:
> >> > Is this a regression? Does it work on previous versions of Xen?
> >>
> >> I think this is what was already reported by other Intel people, see
> >> e.g. Quan's most recent reply:
> >> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.
> >> html It is not clear where the problem is, and not seeing the issue
> >> myself makes it hard to analyze. In any event this quite likely is a
> >> regression.
> >>
> >
> > My reading of that email thread and all relevant links (including the
> > KVM bug report) is that there is a regression vf driver, but not in Xen.
> 
> Just from reading that I would tend to agree. But the report here is about
> Win2K8.
> 


Jan, 
Do you know which commit is a regression one? I try to find out the regression 
commit.  That may be helpful to find out the root cause.

Btw, some feedback from QA team, rhel 6.4 VM  doesn't work, but rhel 7.2 VM 
does.

> Jan
> 
> > There isn't enough evidence to rule out a bug in Xen, but over all
> > I'm inclined to think this bug is not in Xen given all the things presented.
> >
> > Wei.
> 


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-05-27 Thread Jan Beulich 
>>> On 27.05.16 at 15:34,  wrote:
> On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
>> >>> On 27.05.16 at 12:39,  wrote:
>> > Is this a regression? Does it work on previous versions of Xen?
>> 
>> I think this is what was already reported by other Intel people,
>> see e.g. Quan's most recent reply:
>> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.html 
>> It is not clear where the problem is, and not seeing the issue
>> myself makes it hard to analyze. In any event this quite likely
>> is a regression.
>> 
> 
> My reading of that email thread and all relevant links (including the
> KVM bug report) is that there is a regression vf driver, but not in Xen.

Just from reading that I would tend to agree. But the report here
is about Win2K8.

Jan

> There isn't enough evidence to rule out a bug in Xen, but over all  I'm
> inclined to think this bug is not in Xen given all the things presented.
> 
> Wei.



___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-05-27 Thread Wei Liu 
On Fri, May 27, 2016 at 06:16:30AM -0600, Jan Beulich wrote:
> >>> On 27.05.16 at 12:39,  wrote:
> > Is this a regression? Does it work on previous versions of Xen?
> 
> I think this is what was already reported by other Intel people,
> see e.g. Quan's most recent reply:
> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.html
> It is not clear where the problem is, and not seeing the issue
> myself makes it hard to analyze. In any event this quite likely
> is a regression.
> 

My reading of that email thread and all relevant links (including the
KVM bug report) is that there is a regression vf driver, but not in Xen.

There isn't enough evidence to rule out a bug in Xen, but over all  I'm
inclined to think this bug is not in Xen given all the things presented.

Wei.

> Jan
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-05-27 Thread Jan Beulich 
>>> On 27.05.16 at 12:39,  wrote:
> Is this a regression? Does it work on previous versions of Xen?

I think this is what was already reported by other Intel people,
see e.g. Quan's most recent reply:
http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01896.html
It is not clear where the problem is, and not seeing the issue
myself makes it hard to analyze. In any event this quite likely
is a regression.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2016-05-27 Thread Wei Liu 
Hello

Is this a regression? Does it work on previous versions of Xen?

On Fri, May 27, 2016 at 09:04:47AM +, Zhang, PengtaoX wrote:
> Bug detailed description:
> 
> while assign a vf to guest with vf's bdf number in guest configure file 
> static,or use command :"xl pci-attach $domid $bdf" dynamic , affter guest 
> boot up,win2008 guest can not get ip.
> 

"xl -vvv pci-attch" can provide more insight.

From the screenshot I can see the VF does show up in the guest, so the
xl command probably runs fine.

(A side note, please be considerate to xen-devel subscribers who might
not have large bandwidth or an image viewer -- avoid sending pictures in
the future.)

Maybe have a look at xl dmesg to see if there is anything interesting
there?

Wei.


> Environment :
> 
> HW: Skylake-S ,Boardwell-ep,Board-ex,Haswell-ep,Haswell-ex
> NIC: Intel Corporation 82599 Ethernet Controller
> Xen: Xen 4.7.0 RC3
> Dom0: Linux 4.6.0
> 
> Reproduce steps:
> 
> 1.boot up a win2008 guest with vf's bdf number in guest configure file(boot 
> up a win2k8 guest then use :"xl pci-attach $domid $bdf" to guest).
> 2.check guest ip .
> 
> Current result:
> 
> Win2008 guest didn't have ip address .
> 
> Base error log:
> 
> Please check attachment .
> 
> 
> Regards,
> Pengtao


> builder = "hvm"
> name = "vVTD_ASS_13_1435039196"
> memory = 512
> vcpus=2
> disk = [ '/share/xvs/var/img.vmxVTD_ASS_13_1,qcow2,xvda,rw', 
> '/share/xvs/var/img.vmxVTD_ASS_13_2,raw,xvdb,rw' ]
> device_model_override = '/usr/local/lib/xen/bin/qemu-system-i386'
> device_model_version = 'qemu-xen'
> sdl=0
> vnc=1
> stdvga=1
> hap=1
> acpi=1
> pci = [ '03:10.1' ]
> hpet=1
> 



___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel