Re: [Xen-devel] [PATCH 02/14 v4] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h

Hi, On 19/06/17 17:53, Bhupinder Thakur wrote: > Hi Andre, > > On 19 June 2017 at 15:03, Andre Przywara wrote: >> Hi Bhupinder, >> >> I think the commit message is a bit misleading. >> Actually you *rename* functions and their call sites, and also this >> touches the

Re: [Xen-devel] [PATCH 02/14 v4] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h

Hi Andre, On 19 June 2017 at 15:03, Andre Przywara wrote: > Hi Bhupinder, > > I think the commit message is a bit misleading. > Actually you *rename* functions and their call sites, and also this > touches the VGIC code, so shouldn't it mention both in the first line of >

Re: [Xen-devel] [PATCH 02/14 v4] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h

Hi Bhupinder, I think the commit message is a bit misleading. Actually you *rename* functions and their call sites, and also this touches the VGIC code, so shouldn't it mention both in the first line of the commit message? After all this patch really has not much to do with vpl011. On 06/06/17

Re: [Xen-devel] [PATCH 02/14 v4] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h

Hi Bhupinder, On 06/06/17 18:25, Bhupinder Thakur wrote: -/* N-bit register helpers */ -#define VGIC_REG_HELPERS(sz, offmask) \ -static inline register_t vgic_reg##sz##_extract(uint##sz##_t reg, \ -const