Re: [Xen-devel] [PATCH 03/11] xen/arm: traps: Re-order the includes alphabetically

[Julien Grall]

Hi Bhupinder,

On 16/08/17 07:44, Bhupinder Thakur wrote:

Hi Julien,

On 11 August 2017 at 23:32, Julien Grall  wrote:

Signed-off-by: Julien Grall 
---
 xen/arch/arm/traps.c | 42 ++
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index c07999b518..ca9bef712c 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -16,41 +16,43 @@
  * GNU General Public License for more details.
  */

-#include 
-#include 
-#include 
-#include 
-#include 
+#include 
+#include 
+#include 
 #include 
+#include 
+#include 

The above two files should be before xen/irq.h.


Got my alphabet wrong :/. Thank you for spotting it! I will fix it in 
the next version.





 #include 
 #include 
+#include 
 #include 
-#include 
-#include 
-#include 
-#include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
 #include 
-#include 
-#include 
+
 #include 
 #include 
-#include 
-#include 
-#include 
+
+#include 
 #include 
-#include 
-#include 
+#include 
 #include 
+#include 
+#include 
 #include 
+#include 
+#include 
 #include 
+#include 

The above two files should be before asm/psci.h with asm/mmio.h included first.


Same here :/




+#include 
+#include 

 #include "decode.h"
 #include "vtimer.h"
-#include 
-#include 
-#include 
-#include 

 /* The base of the stack must always be double-word aligned, which means
  * that both the kernel half of struct cpu_user_regs (which is pushed in
--
2.11.0



With these two changes.

Acked-by: Bhupinder Thakur 


Thank you for the review.

Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 03/11] xen/arm: traps: Re-order the includes alphabetically

[Bhupinder Thakur]

Hi Julien,

On 11 August 2017 at 23:32, Julien Grall  wrote:
> Signed-off-by: Julien Grall 
> ---
>  xen/arch/arm/traps.c | 42 ++
>  1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index c07999b518..ca9bef712c 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -16,41 +16,43 @@
>   * GNU General Public License for more details.
>   */
>
> -#include 
> -#include 
> -#include 
> -#include 
> -#include 
> +#include 
> +#include 
> +#include 
>  #include 
> +#include 
> +#include 
The above two files should be before xen/irq.h.

>  #include 
>  #include 
> +#include 
>  #include 
> -#include 
> -#include 
> -#include 
> -#include 
>  #include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
>  #include 
> -#include 
> -#include 
> +
>  #include 
>  #include 
> -#include 
> -#include 
> -#include 
> +
> +#include 
>  #include 
> -#include 
> -#include 
> +#include 
>  #include 
> +#include 
> +#include 
>  #include 
> +#include 
> +#include 
>  #include 
> +#include 
The above two files should be before asm/psci.h with asm/mmio.h included first.

> +#include 
> +#include 
>
>  #include "decode.h"
>  #include "vtimer.h"
> -#include 
> -#include 
> -#include 
> -#include 
>
>  /* The base of the stack must always be double-word aligned, which means
>   * that both the kernel half of struct cpu_user_regs (which is pushed in
> --
> 2.11.0
>

With these two changes.

Acked-by: Bhupinder Thakur 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel