On 09/08/17 11:18, Roger Pau Monne wrote: > Using gprintk in arch_set_info_hvm_guest doesn't make sense, since > most of the time this function will be called from the toolstack > domain builder or Xen itself in case of Dom0. > > Switch to using printk instead. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > --- > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com> > --- > xen/arch/x86/hvm/domain.c | 77 > +++++++++++++++++++++++++---------------------- > 1 file changed, 41 insertions(+), 36 deletions(-) > > diff --git a/xen/arch/x86/hvm/domain.c b/xen/arch/x86/hvm/domain.c > index 60474649de..cb4e6cd98f 100644 > --- a/xen/arch/x86/hvm/domain.c > +++ b/xen/arch/x86/hvm/domain.c > @@ -24,12 +24,14 @@ > > #include <public/hvm/hvm_vcpu.h> > > -static int check_segment(struct segment_register *reg, enum x86_segment seg) > +static int check_segment(struct vcpu *v, struct segment_register *reg, > + enum x86_segment seg) > { > > if ( reg->pad != 0 ) > { > - gprintk(XENLOG_ERR, "Segment attribute bits 12-15 are not zero\n"); > + printk(XENLOG_ERR "%pv Segment attribute bits 12-15 are not zero\n",
These need to retain XENLOG_GUEST so they get suitably ratelimited. Alternatively, use something like: gprintk(XENLOG_ERR, "Segment attribute bits 12-15 are not zero for %pv\n") which gives both the current and target contexts. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel