Re: [Xen-devel] [PATCH V2] x86/mm: Fix Coverity issues 1373105 and 1373106

2016-09-21 Thread Jan Beulich
>>> On 21.09.16 at 14:55, wrote: > On 21/09/16 13:52, Jan Beulich wrote: > On 21.09.16 at 14:41, wrote: >>> Added missing error checks in p2m_set_mem_access_multi(). >> >> I think the patch subject should say what is being changed/fixed,

Re: [Xen-devel] [PATCH V2] x86/mm: Fix Coverity issues 1373105 and 1373106

2016-09-21 Thread George Dunlap
On 21/09/16 13:52, Jan Beulich wrote: On 21.09.16 at 14:41, wrote: >> Added missing error checks in p2m_set_mem_access_multi(). > > I think the patch subject should say what is being changed/fixed, > and the two Coverity IDs should be listed here instead.

Re: [Xen-devel] [PATCH V2] x86/mm: Fix Coverity issues 1373105 and 1373106

2016-09-21 Thread Jan Beulich
>>> On 21.09.16 at 14:41, wrote: > Added missing error checks in p2m_set_mem_access_multi(). I think the patch subject should say what is being changed/fixed, and the two Coverity IDs should be listed here instead. Otherwise someone looking over just the patch titles

Re: [Xen-devel] [PATCH V2] x86/mm: Fix Coverity issues 1373105 and 1373106

2016-09-21 Thread George Dunlap
On 21/09/16 13:41, Razvan Cojocaru wrote: > Added missing error checks in p2m_set_mem_access_multi(). > > Signed-off-by: Razvan Cojocaru > --- > Changes since V1: > - Returning -EFAULT instead of -EINVAL. > - Replaced stray TAB with spaces. > --- >