Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-24 Thread Roger Pau Monné
On Thu, Aug 24, 2017 at 03:03:49PM +0100, Julien Grall wrote: > Hi, > > On 23/08/17 15:05, Roger Pau Monné wrote: > > On Wed, Aug 23, 2017 at 11:19:01AM +0100, Julien Grall wrote: > > > Hi Roger, > > > > > > On 23/08/17 08:22, Roger Pau Monné wrote: > > > > On Wed, Aug 23, 2017 at 02:06:17PM

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-24 Thread Julien Grall
Hi, On 23/08/17 15:05, Roger Pau Monné wrote: On Wed, Aug 23, 2017 at 11:19:01AM +0100, Julien Grall wrote: Hi Roger, On 23/08/17 08:22, Roger Pau Monné wrote: On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: Hi Roger: Thanks for your review. On 2017年08月22日 22:32, Roger

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 23, 2017 at 11:19:01AM +0100, Julien Grall wrote: > Hi Roger, > > On 23/08/17 08:22, Roger Pau Monné wrote: > > On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: > > > Hi Roger: > > > Thanks for your review. > > > > > > On 2017年08月22日 22:32, Roger Pau Monné wrote: > > > >

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-23 Thread Julien Grall
Hi Roger, On 23/08/17 08:22, Roger Pau Monné wrote: On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: Hi Roger: Thanks for your review. On 2017年08月22日 22:32, Roger Pau Monné wrote: On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: + +/* vIOMMU capabilities */

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-23 Thread Lan Tianyu
On 2017年08月23日 15:22, Roger Pau Monné wrote: > On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: >> Hi Roger: >> Thanks for your review. >> >> On 2017年08月22日 22:32, Roger Pau Monné wrote: >>> On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: + +/* vIOMMU

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: > Hi Roger: > Thanks for your review. > > On 2017年08月22日 22:32, Roger Pau Monné wrote: > > On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: > >> + > >> +/* vIOMMU capabilities */ > >> +#define VIOMMU_CAP_IRQ_REMAPPING

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-23 Thread Lan Tianyu
Hi Roger: Thanks for your review. On 2017年08月22日 22:32, Roger Pau Monné wrote: > On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: >> This patch is to introduce create, destroy and query capabilities >> command for vIOMMU. vIOMMU layer will deal with requests and call >> arch

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-22 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: > This patch is to introduce create, destroy and query capabilities > command for vIOMMU. vIOMMU layer will deal with requests and call > arch vIOMMU ops. > > Signed-off-by: Lan Tianyu > --- > xen/common/domctl.c

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-17 Thread Lan Tianyu
Hi Wei: Thanks for your review. On 2017年08月17日 19:18, Wei Liu wrote: > On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: >> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h >> index ff39762..4b10f26 100644 >> --- a/xen/include/public/domctl.h >> +++

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-17 Thread Wei Liu
On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: [...] > > +int viommu_domctl(struct domain *d, struct xen_domctl_viommu_op *op, > + bool *need_copy) > +{ > +int rc = -EINVAL, ret; > + > +if ( !viommu_enabled() ) > +return rc; > + > +switch (