Re: [Xen-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-11-30 Thread Oleksandr Andrushchenko
On 11/30/2016 10:45 AM, Jan Beulich wrote: On 29.11.16 at 19:44, wrote: On 11/29/2016 08:30 PM, Dario Faggioli wrote: On Tue, 2016-11-29 at 19:27 +0200, Oleksandr Andrushchenko wrote: On 11/29/2016 07:05 PM, Jan Beulich wrote: If you document it as padding, you can't easily use it later on f

Re: [Xen-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-11-30 Thread Jan Beulich
>>> On 29.11.16 at 19:44, wrote: > On 11/29/2016 08:30 PM, Dario Faggioli wrote: >> On Tue, 2016-11-29 at 19:27 +0200, Oleksandr Andrushchenko wrote: >>> On 11/29/2016 07:05 PM, Jan Beulich wrote: If you document it as padding, you can't easily use it later on for some extension. >>> Why

Re: [Xen-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-11-29 Thread Oleksandr Andrushchenko
On 11/29/2016 08:30 PM, Dario Faggioli wrote: On Tue, 2016-11-29 at 19:27 +0200, Oleksandr Andrushchenko wrote: On 11/29/2016 07:05 PM, Jan Beulich wrote: If you document it as padding, you can't easily use it later on for some extension. Why not? I would be more careful about reserved, rather

Re: [Xen-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-11-29 Thread Dario Faggioli
On Tue, 2016-11-29 at 19:27 +0200, Oleksandr Andrushchenko wrote: > On 11/29/2016 07:05 PM, Jan Beulich wrote: > > If you document it as padding, you can't easily use it later on for > > some extension. > Why not? I would be more careful about reserved, rather than padding. > Reserved means that it

Re: [Xen-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-11-29 Thread Oleksandr Andrushchenko
On 11/29/2016 07:05 PM, Jan Beulich wrote: On 29.11.16 at 17:55, wrote: On 11/29/2016 06:09 PM, Jan Beulich wrote: On 29.11.16 at 16:24, wrote: +struct xensnd_req { +uint16_t id; +uint8_t operation; +uint8_t stream_idx; +uint32_t reserved; +union { +struct xensnd_

Re: [Xen-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-11-29 Thread Jan Beulich
>>> On 29.11.16 at 17:55, wrote: > On 11/29/2016 06:09 PM, Jan Beulich wrote: > On 29.11.16 at 16:24, wrote: >>> +struct xensnd_req { >>> +uint16_t id; >>> +uint8_t operation; >>> +uint8_t stream_idx; >>> +uint32_t reserved; >>> +union { >>> +struct xensnd_open_req

Re: [Xen-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-11-29 Thread Oleksandr Andrushchenko
On 11/29/2016 06:09 PM, Jan Beulich wrote: On 29.11.16 at 16:24, wrote: +struct xensnd_req { +uint16_t id; +uint8_t operation; +uint8_t stream_idx; +uint32_t reserved; +union { +struct xensnd_open_req open; +struct xensnd_rw_req rw; +uint8_t padding[2

Re: [Xen-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-11-29 Thread Jan Beulich
>>> On 29.11.16 at 16:24, wrote: > +struct xensnd_req { > +uint16_t id; > +uint8_t operation; > +uint8_t stream_idx; > +uint32_t reserved; > +union { > +struct xensnd_open_req open; > +struct xensnd_rw_req rw; > +uint8_t padding[24]; > +} op; > +}; >