Re: [Xen-devel] [PATCH v2 0/3] fix xen hvm guest with kaslr enabled
* Juergen Gross wrote: > On 08/08/17 16:00, Boris Ostrovsky wrote: > > On 08/08/2017 02:46 AM, Juergen Gross wrote: > >> On 28/07/17 12:23, Juergen Gross wrote: > >>> This patch series fixes a regression introduced in 4.13-rc1: A Xen > >>> HVM guest with KASLR enabled wouldn't boot any longer due to the usage > >>> of __va() before kernel_randomize_memory() was called. > >>> > >>> Changes in V2: > >>> - patch 1: test for x86_hyper being not NULL > >>> > >>> Juergen Gross (3): > >>> x86: provide an init_mem_mapping hypervisor hook > >>> xen: split up xen_hvm_init_shared_info() > >>> xen: fix hvm guest with kaslr enabled > >>> > >>> arch/x86/include/asm/hypervisor.h | 10 +++ > >>> arch/x86/mm/init.c| 3 ++ > >>> arch/x86/xen/enlighten_hvm.c | 59 > >>> --- > >>> 3 files changed, 50 insertions(+), 22 deletions(-) > >>> > >> Could I have some feedback, please? > >> > >> I'd like to get this regression fixed in 4.13. > >> > >> In case nobody objects this week I'll just add the patches to the Xen > >> tree for rc5. > > > > > > As I said before I think .init_mem_mapping() could live in > > x86_platform_ops() but this works too, so > > > > Reviewed-by: Boris Ostrovsky > > > > But this still wants x86 maintainers' ACK. > > x86 maintainers, could you please comment on at least patch 1? LGTM: Acked-by: Ingo Molnar Thanks, Ingo ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v2 0/3] fix xen hvm guest with kaslr enabled
On 08/08/17 16:00, Boris Ostrovsky wrote: > On 08/08/2017 02:46 AM, Juergen Gross wrote: >> On 28/07/17 12:23, Juergen Gross wrote: >>> This patch series fixes a regression introduced in 4.13-rc1: A Xen >>> HVM guest with KASLR enabled wouldn't boot any longer due to the usage >>> of __va() before kernel_randomize_memory() was called. >>> >>> Changes in V2: >>> - patch 1: test for x86_hyper being not NULL >>> >>> Juergen Gross (3): >>> x86: provide an init_mem_mapping hypervisor hook >>> xen: split up xen_hvm_init_shared_info() >>> xen: fix hvm guest with kaslr enabled >>> >>> arch/x86/include/asm/hypervisor.h | 10 +++ >>> arch/x86/mm/init.c| 3 ++ >>> arch/x86/xen/enlighten_hvm.c | 59 >>> --- >>> 3 files changed, 50 insertions(+), 22 deletions(-) >>> >> Could I have some feedback, please? >> >> I'd like to get this regression fixed in 4.13. >> >> In case nobody objects this week I'll just add the patches to the Xen >> tree for rc5. > > > As I said before I think .init_mem_mapping() could live in > x86_platform_ops() but this works too, so > > Reviewed-by: Boris Ostrovsky > > But this still wants x86 maintainers' ACK. x86 maintainers, could you please comment on at least patch 1? Juergen ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v2 0/3] fix xen hvm guest with kaslr enabled
On 08/08/2017 02:46 AM, Juergen Gross wrote: > On 28/07/17 12:23, Juergen Gross wrote: >> This patch series fixes a regression introduced in 4.13-rc1: A Xen >> HVM guest with KASLR enabled wouldn't boot any longer due to the usage >> of __va() before kernel_randomize_memory() was called. >> >> Changes in V2: >> - patch 1: test for x86_hyper being not NULL >> >> Juergen Gross (3): >> x86: provide an init_mem_mapping hypervisor hook >> xen: split up xen_hvm_init_shared_info() >> xen: fix hvm guest with kaslr enabled >> >> arch/x86/include/asm/hypervisor.h | 10 +++ >> arch/x86/mm/init.c| 3 ++ >> arch/x86/xen/enlighten_hvm.c | 59 >> --- >> 3 files changed, 50 insertions(+), 22 deletions(-) >> > Could I have some feedback, please? > > I'd like to get this regression fixed in 4.13. > > In case nobody objects this week I'll just add the patches to the Xen > tree for rc5. As I said before I think .init_mem_mapping() could live in x86_platform_ops() but this works too, so Reviewed-by: Boris Ostrovsky But this still wants x86 maintainers' ACK. -boris ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v2 0/3] fix xen hvm guest with kaslr enabled
On 28/07/17 12:23, Juergen Gross wrote: > This patch series fixes a regression introduced in 4.13-rc1: A Xen > HVM guest with KASLR enabled wouldn't boot any longer due to the usage > of __va() before kernel_randomize_memory() was called. > > Changes in V2: > - patch 1: test for x86_hyper being not NULL > > Juergen Gross (3): > x86: provide an init_mem_mapping hypervisor hook > xen: split up xen_hvm_init_shared_info() > xen: fix hvm guest with kaslr enabled > > arch/x86/include/asm/hypervisor.h | 10 +++ > arch/x86/mm/init.c| 3 ++ > arch/x86/xen/enlighten_hvm.c | 59 > --- > 3 files changed, 50 insertions(+), 22 deletions(-) > Could I have some feedback, please? I'd like to get this regression fixed in 4.13. In case nobody objects this week I'll just add the patches to the Xen tree for rc5. Juergen ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel