On Wed, 2016-03-23 at 09:43 +0100, Borislav Petkov wrote:
> On Tue, Mar 22, 2016 at 12:35:19PM -0600, Toshi Kani wrote:
> > Right. Will change to "Add support of non-default PAT MSR setting at
> > handoff".
>
> Please remove this "handoff" notion from the text. Every hw register is
> being
On Tue, Mar 22, 2016 at 12:35:19PM -0600, Toshi Kani wrote:
> Right. Will change to "Add support of non-default PAT MSR setting at
> handoff".
Please remove this "handoff" notion from the text. Every hw register is
being handed off to the OS once the kernel takes over so there's no need
to make
On Tue, 22 Mar 2016, Borislav Petkov wrote:
> > +static void pat_keep_handoff_state(void)
>
> Static function, no need for "pat_" prefix. Also, no need for the
> kernel-doc comment.
I have to disagree. kernel-doc comments are not limited to global
functions.
I realy prefer kernel-doc style for
On Tue, 2016-03-22 at 17:57 +0100, Borislav Petkov wrote:
> $Subject is misleading - there's no non-default PAT MSR - the setting is
> non-default.
Right. Will change to "Add support of non-default PAT MSR setting at
handoff".
> On Wed, Mar 16, 2016 at 06:44:57PM -0600, Toshi Kani wrote:
> > In
