Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-17 Thread Kyle Huey
On Mon, Oct 17, 2016 at 9:39 AM, Andrew Cooper wrote: > On 17/10/16 17:28, Kyle Huey wrote: >> On Mon, Oct 17, 2016 at 5:34 AM, Andrew Cooper >> wrote: >>> On 14/10/16 20:36, Kyle Huey wrote: On Fri, Oct 14, 2016 at 10:18 AM, Andrew Cooper wrote: > On a slightly separate note, as y

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-17 Thread Andrew Cooper
On 17/10/16 17:28, Kyle Huey wrote: > On Mon, Oct 17, 2016 at 5:34 AM, Andrew Cooper > wrote: >> On 14/10/16 20:36, Kyle Huey wrote: >>> On Fri, Oct 14, 2016 at 10:18 AM, Andrew Cooper >>> wrote: On a slightly separate note, as you have just been a successful guinea-pig for XTF, how did

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-17 Thread Kyle Huey
On Mon, Oct 17, 2016 at 5:34 AM, Andrew Cooper wrote: > On 14/10/16 20:36, Kyle Huey wrote: >> On Fri, Oct 14, 2016 at 10:18 AM, Andrew Cooper >> wrote: >>> On a slightly separate note, as you have just been a successful >>> guinea-pig for XTF, how did you find it? It is a very new (still >>> so

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-17 Thread Andrew Cooper
On 14/10/16 20:36, Kyle Huey wrote: > On Fri, Oct 14, 2016 at 10:18 AM, Andrew Cooper > wrote: >> On a slightly separate note, as you have just been a successful >> guinea-pig for XTF, how did you find it? It is a very new (still >> somewhat in development) system but the project is looking to tr

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-17 Thread Andrew Cooper
On 14/10/16 20:28, Kyle Huey wrote: >> :) I am now curious as to which bit I missed. > I made these changes. > > - Kyle > > --- > tests/cpuid-faulting/main.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tests/cpuid-faulting/main.c b/tests/cpuid-faulting/main.c

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-14 Thread Kyle Huey
On Fri, Oct 14, 2016 at 10:18 AM, Andrew Cooper wrote: > On a slightly separate note, as you have just been a successful > guinea-pig for XTF, how did you find it? It is a very new (still > somewhat in development) system but the project is looking to try and > improve regression testing in this

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-14 Thread Kyle Huey
> :) I am now curious as to which bit I missed. I made these changes. - Kyle --- tests/cpuid-faulting/main.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/cpuid-faulting/main.c b/tests/cpuid-faulting/main.c index 3e782a2..221567d 100644 --- a/tests/cpuid-fau

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-14 Thread Andrew Cooper
On 14/10/16 18:05, Kyle Huey wrote: > On Fri, Oct 14, 2016 at 7:46 AM, Andrew Cooper > wrote: >> On 14/10/16 13:04, Jan Beulich wrote: >> On 13.10.16 at 23:09, wrote: --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1315,16 +1315,20 @@ static int emulate_forced_invalid

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-14 Thread Kyle Huey
On Fri, Oct 14, 2016 at 7:46 AM, Andrew Cooper wrote: > On 14/10/16 13:04, Jan Beulich wrote: > On 13.10.16 at 23:09, wrote: >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -1315,16 +1315,20 @@ static int emulate_forced_invalid_op(struct >>> cpu_user_regs *regs) >>>

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-14 Thread Andrew Cooper
On 14/10/16 13:04, Jan Beulich wrote: On 13.10.16 at 23:09, wrote: >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -1315,16 +1315,20 @@ static int emulate_forced_invalid_op(struct >> cpu_user_regs *regs) >> /* We only emulate CPUID. */ >> if ( ( rc = copy_from_use

Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-14 Thread Jan Beulich
>>> On 13.10.16 at 23:09, wrote: > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -1315,16 +1315,20 @@ static int emulate_forced_invalid_op(struct > cpu_user_regs *regs) > /* We only emulate CPUID. */ > if ( ( rc = copy_from_user(instr, (char *)eip, sizeof(instr))) != 0 )