>>> On 01.12.16 at 11:58, wrote:
> On 01/12/16 10:40, Jan Beulich wrote:
>>
>>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>>> @@ -2404,6 +2404,11 @@ x86_decode(
>>> #undef insn_fetch_bytes
>>> #undef insn_fetch_type
>>>
>>> +/* Undo DEBUG wra
On 01/12/16 10:40, Jan Beulich wrote:
>
>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>> @@ -2404,6 +2404,11 @@ x86_decode(
>> #undef insn_fetch_bytes
>> #undef insn_fetch_type
>>
>> +/* Undo DEBUG wrapper. */
>> +#ifdef x86_emulate
>> +#undef x
>>> On 30.11.16 at 14:50, wrote:
> In debug builds, confirm that some properties of x86_emulate()'s behaviour
> actually hold. The first property, fixed in a previous change, is that retire
> flags are only ever set in the X86EMUL_OKAY case.
>
> While adjusting the userspace test harness to cope