Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-31 Thread Oleksandr Grytsov 
On Wed, Aug 30, 2017 at 6:52 PM, Ian Jackson  wrote:
> Oleksandr Grytsov writes ("Re: [PATCH v4 00/13] libxl: add PV display device 
> driver interface"):
>> On Thu, Aug 17, 2017 at 2:11 PM, Wei Liu  wrote:
>> > I'm still waiting for the outcome from the other thread in which I
>> > proposed to change p9 to p9s. Ian is out of office at the moment.
>>
>> ping
>
> Sorry, I thought the previous mails were clear.  I think changing the
> name is fine now, despite it being an API break, because we think
> there are very few out-of-tree callers.
>
> Ian.

Yes, it is clear about changing the name.
By pinging I mean review and feedback for all other patches in this patch set.

-- 
Best Regards,
Oleksandr Grytsov.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-30 Thread Ian Jackson 
Oleksandr Grytsov writes ("Re: [PATCH v4 00/13] libxl: add PV display device 
driver interface"):
> On Thu, Aug 17, 2017 at 2:11 PM, Wei Liu  wrote:
> > I'm still waiting for the outcome from the other thread in which I
> > proposed to change p9 to p9s. Ian is out of office at the moment.
> 
> ping

Sorry, I thought the previous mails were clear.  I think changing the
name is fine now, despite it being an API break, because we think
there are very few out-of-tree callers.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-30 Thread Oleksandr Grytsov 
On Thu, Aug 17, 2017 at 2:11 PM, Wei Liu  wrote:
> On Thu, Aug 17, 2017 at 01:13:39PM +0300, Oleksandr Grytsov wrote:
>> On Fri, Jul 28, 2017 at 5:13 PM, Wei Liu  wrote:
>> > On Tue, Jul 18, 2017 at 05:25:17PM +0300, Oleksandr Grytsov wrote:
>> >> From: Oleksandr Grytsov 
>> >>
>> >> Changes since V3:
>> >>   * libxl__device_add renamed to libxl__device_add_async and reworked
>> >> to match the former design;
>> >>   * libxl__device_add used for devices which don't require updating domain
>> >> config but simple write to Xen Store (9pfs, vkb, vfb);
>> >>   * following devices are changed to use the libxl__device_add:
>> >> 9pfs, vkb, vfb, nic, vtpm. Other device (console, pci, usb, disk) have
>> >> very different adding pattern and required to unreasonable extend
>> >> libxl__device_add_async and its parameters;
>> >>   * disk device list changed to use libxl__device_list;
>> >>   * previous comments are applied.
>> >>
>> >> Patches on github [1].
>> >>
>> >> [1] https://github.com/al1img/xen/tree/xl-vdispl-v4
>> >
>> > So I just went through this series and pointed out issues I can
>> > immediately find. I will need to take a closer look at the framework
>> > itself next week.
>>
>> ping
>
> I'm still waiting for the outcome from the other thread in which I
> proposed to change p9 to p9s. Ian is out of office at the moment.

ping

-- 
Best Regards,
Oleksandr Grytsov.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-17 Thread Wei Liu 
On Thu, Aug 17, 2017 at 01:13:39PM +0300, Oleksandr Grytsov wrote:
> On Fri, Jul 28, 2017 at 5:13 PM, Wei Liu  wrote:
> > On Tue, Jul 18, 2017 at 05:25:17PM +0300, Oleksandr Grytsov wrote:
> >> From: Oleksandr Grytsov 
> >>
> >> Changes since V3:
> >>   * libxl__device_add renamed to libxl__device_add_async and reworked
> >> to match the former design;
> >>   * libxl__device_add used for devices which don't require updating domain
> >> config but simple write to Xen Store (9pfs, vkb, vfb);
> >>   * following devices are changed to use the libxl__device_add:
> >> 9pfs, vkb, vfb, nic, vtpm. Other device (console, pci, usb, disk) have
> >> very different adding pattern and required to unreasonable extend
> >> libxl__device_add_async and its parameters;
> >>   * disk device list changed to use libxl__device_list;
> >>   * previous comments are applied.
> >>
> >> Patches on github [1].
> >>
> >> [1] https://github.com/al1img/xen/tree/xl-vdispl-v4
> >
> > So I just went through this series and pointed out issues I can
> > immediately find. I will need to take a closer look at the framework
> > itself next week.
> 
> ping

I'm still waiting for the outcome from the other thread in which I
proposed to change p9 to p9s. Ian is out of office at the moment.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-17 Thread Oleksandr Grytsov 
On Fri, Jul 28, 2017 at 5:13 PM, Wei Liu  wrote:
> On Tue, Jul 18, 2017 at 05:25:17PM +0300, Oleksandr Grytsov wrote:
>> From: Oleksandr Grytsov 
>>
>> Changes since V3:
>>   * libxl__device_add renamed to libxl__device_add_async and reworked
>> to match the former design;
>>   * libxl__device_add used for devices which don't require updating domain
>> config but simple write to Xen Store (9pfs, vkb, vfb);
>>   * following devices are changed to use the libxl__device_add:
>> 9pfs, vkb, vfb, nic, vtpm. Other device (console, pci, usb, disk) have
>> very different adding pattern and required to unreasonable extend
>> libxl__device_add_async and its parameters;
>>   * disk device list changed to use libxl__device_list;
>>   * previous comments are applied.
>>
>> Patches on github [1].
>>
>> [1] https://github.com/al1img/xen/tree/xl-vdispl-v4
>
> So I just went through this series and pointed out issues I can
> immediately find. I will need to take a closer look at the framework
> itself next week.

ping

-- 
Best Regards,
Oleksandr Grytsov.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-07-28 Thread Wei Liu 
On Tue, Jul 18, 2017 at 05:25:17PM +0300, Oleksandr Grytsov wrote:
> From: Oleksandr Grytsov 
> 
> Changes since V3:
>   * libxl__device_add renamed to libxl__device_add_async and reworked
> to match the former design;
>   * libxl__device_add used for devices which don't require updating domain
> config but simple write to Xen Store (9pfs, vkb, vfb);
>   * following devices are changed to use the libxl__device_add:
> 9pfs, vkb, vfb, nic, vtpm. Other device (console, pci, usb, disk) have
> very different adding pattern and required to unreasonable extend
> libxl__device_add_async and its parameters;
>   * disk device list changed to use libxl__device_list;
>   * previous comments are applied.
> 
> Patches on github [1].
> 
> [1] https://github.com/al1img/xen/tree/xl-vdispl-v4

So I just went through this series and pointed out issues I can
immediately find. I will need to take a closer look at the framework
itself next week.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-07-27 Thread Wei Liu 
On Thu, Jul 27, 2017 at 02:30:33PM +0300, Oleksandr Andrushchenko wrote:
> ping
> 

It is on my list but I'm currently very busy with other urgent things. I
will get to this in due time.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-07-27 Thread Oleksandr Andrushchenko 

ping


On 07/18/2017 05:25 PM, Oleksandr Grytsov wrote:

From: Oleksandr Grytsov 

Changes since V3:
   * libxl__device_add renamed to libxl__device_add_async and reworked
 to match the former design;
   * libxl__device_add used for devices which don't require updating domain
 config but simple write to Xen Store (9pfs, vkb, vfb);
   * following devices are changed to use the libxl__device_add:
 9pfs, vkb, vfb, nic, vtpm. Other device (console, pci, usb, disk) have
 very different adding pattern and required to unreasonable extend
 libxl__device_add_async and its parameters;
   * disk device list changed to use libxl__device_list;
   * previous comments are applied.

Patches on github [1].

[1] https://github.com/al1img/xen/tree/xl-vdispl-v4

Oleksandr Grytsov (13):
   libxl: add generic function to add device
   libxl: add generic functions to get and free device list
   libxl: add vdispl device
   xl: add PV display device commands
   docs: add PV display driver information
   libxl: change p9 to use generec add function
   libxl: change vkb to use generec add function
   libxl: change vfb to use generec add function
   libxl: change disk to use generic getting list functions
   libxl: change nic to use generec add function
   libxl: change vtpm to use generec add function
   libxl: remove unneeded DEVICE_ADD macro
   libxl: make pci and usb setdefault function generic

  docs/man/xl.cfg.pod.5.in  |  49 ++
  docs/man/xl.pod.1.in  |  42 +
  tools/libxl/Makefile  |   2 +-
  tools/libxl/libxl.h   |  54 +--
  tools/libxl/libxl_9pfs.c  |  67 +++-
  tools/libxl/libxl_checkpoint_device.c |  16 +-
  tools/libxl/libxl_colo_save.c |   4 +-
  tools/libxl/libxl_console.c   | 153 --
  tools/libxl/libxl_create.c|  17 +-
  tools/libxl/libxl_device.c| 262 ++
  tools/libxl/libxl_disk.c  | 101 
  tools/libxl/libxl_dm.c|  10 +-
  tools/libxl/libxl_internal.h  | 126 ++-
  tools/libxl/libxl_nic.c   | 212 +
  tools/libxl/libxl_pci.c   |  10 +-
  tools/libxl/libxl_types.idl   |  40 -
  tools/libxl/libxl_types_internal.idl  |   1 +
  tools/libxl/libxl_usb.c   |  21 ++-
  tools/libxl/libxl_utils.h |   4 +
  tools/libxl/libxl_vdispl.c| 289 ++
  tools/libxl/libxl_vtpm.c  | 229 ---
  tools/ocaml/libs/xl/xenlight_stubs.c  |   6 +-
  tools/xl/Makefile |   1 +
  tools/xl/xl.h |   3 +
  tools/xl/xl_block.c   |   3 +-
  tools/xl/xl_cmdtable.c|  19 +++
  tools/xl/xl_nic.c |   3 +-
  tools/xl/xl_parse.c   |  79 +-
  tools/xl/xl_parse.h   |   2 +-
  tools/xl/xl_vdispl.c  | 163 +++
  tools/xl/xl_vtpm.c|   3 +-
  31 files changed, 1293 insertions(+), 698 deletions(-)
  create mode 100644 tools/libxl/libxl_vdispl.c
  create mode 100644 tools/xl/xl_vdispl.c




___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel