Re: [Xen-devel] [PATCH v4 4/5] x86/time: implement PVCLOCK_TSC_STABLE_BIT

2016-09-19 Thread Joao Martins 


On 09/19/2016 11:22 AM, Jan Beulich wrote:
 On 14.09.16 at 19:37,  wrote:
>> --- a/xen/arch/x86/time.c
>> +++ b/xen/arch/x86/time.c
>> @@ -951,6 +951,14 @@ static void __update_vcpu_system_time(struct vcpu *v, 
>> int force)
>>  _u.tsc_timestamp = tsc_stamp;
>>  _u.system_time   = t->stamp.local_stime;
>>  
>> +/*
>> + * It's expected that domains cope with this bit changing on every
>> + * pvclock read to check whether they can resort solely on this tuple
>> + * or if it further requires monotonicity checks with other vcpus.
>> + */
>> +if ( clocksource_is_tsc() )
>> +_u.flags|= XEN_PVCLOCK_TSC_STABLE_BIT;
> 
> Stray blanks ahead of the |=.
> 
Will fix it.

> With that taken care of
> Reviewed-by: Jan Beulich 
Thanks!

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 4/5] x86/time: implement PVCLOCK_TSC_STABLE_BIT

2016-09-19 Thread Jan Beulich 
>>> On 14.09.16 at 19:37,  wrote:
> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -951,6 +951,14 @@ static void __update_vcpu_system_time(struct vcpu *v, 
> int force)
>  _u.tsc_timestamp = tsc_stamp;
>  _u.system_time   = t->stamp.local_stime;
>  
> +/*
> + * It's expected that domains cope with this bit changing on every
> + * pvclock read to check whether they can resort solely on this tuple
> + * or if it further requires monotonicity checks with other vcpus.
> + */
> +if ( clocksource_is_tsc() )
> +_u.flags|= XEN_PVCLOCK_TSC_STABLE_BIT;

Stray blanks ahead of the |=.

With that taken care of
Reviewed-by: Jan Beulich 

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel