Re: [Xen-devel] [PATCH v5 06/16] livepatch: ARM/x86: Check displacement of old_addr and new_addr

2016-09-28 Thread Ross Lagerwall
On 09/23/2016 04:59 PM, Konrad Rzeszutek Wilk wrote: On Fri, Sep 23, 2016 at 11:37:27AM -0400, Konrad Rzeszutek Wilk wrote: On Fri, Sep 23, 2016 at 03:36:27PM +0100, Ross Lagerwall wrote: On 09/21/2016 06:32 PM, Konrad Rzeszutek Wilk wrote: If the distance is too big we are in trouble - as

Re: [Xen-devel] [PATCH v5 06/16] livepatch: ARM/x86: Check displacement of old_addr and new_addr

2016-09-23 Thread Konrad Rzeszutek Wilk
On Fri, Sep 23, 2016 at 11:37:27AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 23, 2016 at 03:36:27PM +0100, Ross Lagerwall wrote: > > On 09/21/2016 06:32 PM, Konrad Rzeszutek Wilk wrote: > > > If the distance is too big we are in trouble - as our relocation > > > distance can surely be

Re: [Xen-devel] [PATCH v5 06/16] livepatch: ARM/x86: Check displacement of old_addr and new_addr

2016-09-23 Thread Konrad Rzeszutek Wilk
On Fri, Sep 23, 2016 at 03:36:27PM +0100, Ross Lagerwall wrote: > On 09/21/2016 06:32 PM, Konrad Rzeszutek Wilk wrote: > > If the distance is too big we are in trouble - as our relocation > > distance can surely be clipped, or still have a valid width - but > > cause an overflow of distance. > >

Re: [Xen-devel] [PATCH v5 06/16] livepatch: ARM/x86: Check displacement of old_addr and new_addr

2016-09-23 Thread Ross Lagerwall
On 09/21/2016 06:32 PM, Konrad Rzeszutek Wilk wrote: If the distance is too big we are in trouble - as our relocation distance can surely be clipped, or still have a valid width - but cause an overflow of distance. On various architectures the maximum displacement for a unconditional

Re: [Xen-devel] [PATCH v5 06/16] livepatch: ARM/x86: Check displacement of old_addr and new_addr

2016-09-22 Thread Julien Grall
Hi Konrad, On 21/09/16 18:32, Konrad Rzeszutek Wilk wrote: diff --git a/xen/include/asm-arm/livepatch.h b/xen/include/asm-arm/livepatch.h index 929c7d9..482d74f 100644 --- a/xen/include/asm-arm/livepatch.h +++ b/xen/include/asm-arm/livepatch.h @@ -6,6 +6,8 @@ #ifndef __XEN_ARM_LIVEPATCH_H__