Re: [Xen-devel] [PATCH v7 2/2] x86/monitor: Notify monitor if an emulation fails.

2017-08-06 Thread Andrew Cooper 
On 06/08/17 11:00, Jan Beulich wrote:
 Petre Pircalabu  08/04/17 8:36 PM >>>
>> @@ -2114,6 +2116,8 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, 
>> unsigned int trapnr,
>> */
>> return;
>> case X86EMUL_UNIMPLEMENTED:
>> +if ( hvm_monitor_emul_unimplemented() )
>> +return;
>> case X86EMUL_UNHANDLEABLE:
> Missing a "fall-through" comment for Coverity's sake.

And GCC 7 these days as well, which noticed this:

http://xenbits.xen.org/gitweb/?p=xtf.git;a=commitdiff;h=53582e5a4337acf55690881dedc91508851e0d81

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v7 2/2] x86/monitor: Notify monitor if an emulation fails.

2017-08-06 Thread Jan Beulich 
>>> Petre Pircalabu  08/04/17 8:36 PM >>>
>@@ -2114,6 +2116,8 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, 
>unsigned int trapnr,
>*/
>return;
>case X86EMUL_UNIMPLEMENTED:
>+if ( hvm_monitor_emul_unimplemented() )
>+return;
>case X86EMUL_UNHANDLEABLE:

Missing a "fall-through" comment for Coverity's sake. (I see now why you've
chosen this ordering of case labels in patch 1, so feel free to ignore my
respective comment there.)

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel