Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-15 Thread Jan Beulich
>>> On 15.08.17 at 17:03, wrote: > I can switch x86 only back to "normal" types but then we also have this > in patch 7: > > static void check_and_stop_scrub(struct page_info *head) > { > if ( head->u.free.scrub_state == BUDDY_SCRUBBING ) > { >

Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-15 Thread Boris Ostrovsky
On 08/15/2017 10:52 AM, Julien Grall wrote: > Hi Jan, > > On 15/08/17 15:51, Jan Beulich wrote: > On 15.08.17 at 16:41, wrote: >>> On 08/15/2017 04:18 AM, Jan Beulich wrote: >>> On 14.08.17 at 16:29, wrote: > On 08/14/2017 06:37

Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-15 Thread Julien Grall
Hi Jan, On 15/08/17 15:51, Jan Beulich wrote: On 15.08.17 at 16:41, wrote: On 08/15/2017 04:18 AM, Jan Beulich wrote: On 14.08.17 at 16:29, wrote: On 08/14/2017 06:37 AM, Jan Beulich wrote: On 08.08.17 at 23:45,

Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-15 Thread Jan Beulich
>>> On 15.08.17 at 16:41, wrote: > On 08/15/2017 04:18 AM, Jan Beulich wrote: > On 14.08.17 at 16:29, wrote: >>> On 08/14/2017 06:37 AM, Jan Beulich wrote: >>> On 08.08.17 at 23:45, wrote: > ---

Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-15 Thread Boris Ostrovsky
On 08/15/2017 04:18 AM, Jan Beulich wrote: On 14.08.17 at 16:29, wrote: >> On 08/14/2017 06:37 AM, Jan Beulich wrote: >> On 08.08.17 at 23:45, wrote: --- a/xen/include/asm-x86/mm.h +++ b/xen/include/asm-x86/mm.h @@

Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-15 Thread Jan Beulich
>>> On 14.08.17 at 16:29, wrote: > On 08/14/2017 06:37 AM, Jan Beulich wrote: > On 08.08.17 at 23:45, wrote: >>> --- a/xen/include/asm-x86/mm.h >>> +++ b/xen/include/asm-x86/mm.h >>> @@ -88,7 +88,15 @@ struct page_info >>> /*

Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-14 Thread Boris Ostrovsky
On 08/14/2017 06:37 AM, Jan Beulich wrote: On 08.08.17 at 23:45, wrote: >> .. so that it's easy to find pages that need to be scrubbed (those pages are >> now marked with _PGC_need_scrub bit). >> >> We keep track of the first unscrubbed page in a page buddy using

Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-14 Thread Julien Grall
Hi Boris, On 08/08/17 22:45, Boris Ostrovsky wrote: .. so that it's easy to find pages that need to be scrubbed (those pages are now marked with _PGC_need_scrub bit). We keep track of the first unscrubbed page in a page buddy using first_dirty field. For now it can have two values, 0 (whole

Re: [Xen-devel] [PATCH v7 2/9] mm: Place unscrubbed pages at the end of pagelist

2017-08-14 Thread Jan Beulich
>>> On 08.08.17 at 23:45, wrote: > .. so that it's easy to find pages that need to be scrubbed (those pages are > now marked with _PGC_need_scrub bit). > > We keep track of the first unscrubbed page in a page buddy using first_dirty > field. For now it can have two