Re: [Xen-devel] [PATCH v8 11/13] arm/mem_access: Add long-descriptor based gpt

2017-08-16 Thread Sergej Proskurin
Hi all, On 08/16/2017 12:28 AM, Andrew Cooper wrote: > On 15/08/2017 23:25, Stefano Stabellini wrote: >> On Tue, 15 Aug 2017, Julien Grall wrote: >>> On 14/08/17 22:03, Sergej Proskurin wrote: Hi Julien, On 08/14/2017 07:37 PM, Julien Grall wrote: > Hi Sergej, > > On 09/

Re: [Xen-devel] [PATCH v8 11/13] arm/mem_access: Add long-descriptor based gpt

2017-08-15 Thread Andrew Cooper
On 15/08/2017 23:25, Stefano Stabellini wrote: > On Tue, 15 Aug 2017, Julien Grall wrote: >> On 14/08/17 22:03, Sergej Proskurin wrote: >>> Hi Julien, >>> >>> On 08/14/2017 07:37 PM, Julien Grall wrote: Hi Sergej, On 09/08/17 09:20, Sergej Proskurin wrote: > +/* > + *

Re: [Xen-devel] [PATCH v8 11/13] arm/mem_access: Add long-descriptor based gpt

2017-08-15 Thread Stefano Stabellini
On Tue, 15 Aug 2017, Julien Grall wrote: > On 14/08/17 22:03, Sergej Proskurin wrote: > > Hi Julien, > > > > On 08/14/2017 07:37 PM, Julien Grall wrote: > > > Hi Sergej, > > > > > > On 09/08/17 09:20, Sergej Proskurin wrote: > > > > +/* > > > > + * According to to ARM DDI 0487B.a J1-5927,

Re: [Xen-devel] [PATCH v8 11/13] arm/mem_access: Add long-descriptor based gpt

2017-08-15 Thread Sergej Proskurin
Hi Julien, On 08/15/2017 12:13 PM, Julien Grall wrote: > > > On 14/08/17 22:03, Sergej Proskurin wrote: >> Hi Julien, >> >> On 08/14/2017 07:37 PM, Julien Grall wrote: >>> Hi Sergej, >>> >>> On 09/08/17 09:20, Sergej Proskurin wrote: +/* + * According to to ARM DDI 0487B.a J1-5

Re: [Xen-devel] [PATCH v8 11/13] arm/mem_access: Add long-descriptor based gpt

2017-08-15 Thread Julien Grall
On 14/08/17 22:03, Sergej Proskurin wrote: Hi Julien, On 08/14/2017 07:37 PM, Julien Grall wrote: Hi Sergej, On 09/08/17 09:20, Sergej Proskurin wrote: +/* + * According to to ARM DDI 0487B.a J1-5927, we return an error if the found Please drop one of the 'to'. The rest looks good

Re: [Xen-devel] [PATCH v8 11/13] arm/mem_access: Add long-descriptor based gpt

2017-08-14 Thread Sergej Proskurin
Hi Julien, On 08/14/2017 07:37 PM, Julien Grall wrote: > Hi Sergej, > > On 09/08/17 09:20, Sergej Proskurin wrote: >> +/* >> + * According to to ARM DDI 0487B.a J1-5927, we return an error if >> the found > > Please drop one of the 'to'. The rest looks good to me. > Great, thanks. I wi

Re: [Xen-devel] [PATCH v8 11/13] arm/mem_access: Add long-descriptor based gpt

2017-08-14 Thread Julien Grall
Hi Sergej, On 09/08/17 09:20, Sergej Proskurin wrote: +/* + * According to to ARM DDI 0487B.a J1-5927, we return an error if the found Please drop one of the 'to'. The rest looks good to me. + * PTE is invalid or holds a reserved entry (PTE<1:0> == x0)) or if the PTE + * maps