Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-20 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: 19 лист. 2014 20:32, користувач Stefano Stabellini stefano.stabell...@eu.citrix.com написав: On Wed, 19 Nov 2014, Julien Grall wrote: On 11/19/2014 06:14 PM, Stefano Stabellini wrote: That's right, the maintenance interrupt handler is

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-20 Thread Julien Grall
On 11/20/2014 10:28 AM, Stefano Stabellini wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: 19 лист. 2014 20:32, користувач Stefano Stabellini stefano.stabell...@eu.citrix.com написав: On Wed, 19 Nov 2014, Julien Grall wrote: On 11/19/2014 06:14 PM, Stefano Stabellini wrote: That's

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-20 Thread Andrii Tseglytskyi
I think I'll debug this a bit later - unfortunately, now don't have time for this. But I want to get rid of spurious interrupt here. BTW - Stefano are you going to post the patch that we created yesterday ? Will Ian accept it? Regards, Andrii On Thu, Nov 20, 2014 at 1:15 PM, Julien Grall

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-20 Thread Andrii Tseglytskyi
OK - I see. thanks a lot. On Thu, Nov 20, 2014 at 6:15 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: Already posted: http://marc.info/?l=xen-develm=141648092100568 Ian hasn't provided any feedback yet. On Thu, 20 Nov 2014, Andrii Tseglytskyi wrote: I think I'll debug

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
Hi Stefano, Thank you for your support. You are right - with latest change you've proposed I got a continuous prints during platform hang: (XEN) gic.c:725:d0v0 LRs full, not injecting irq=2 into d0v0 (XEN) gic.c:725:d0v0 LRs full, not injecting irq=2 into d0v0 (XEN) gic.c:725:d0v0 LRs full, not

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, Thank you for your support. You are right - with latest change you've proposed I got a continuous prints during platform hang: (XEN) gic.c:725:d0v0 LRs full, not injecting irq=2 into d0v0 (XEN) gic.c:725:d0v0 LRs full, not

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
On Wed, Nov 19, 2014 at 1:12 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, Thank you for your support. You are right - with latest change you've proposed I got a continuous prints during platform hang: (XEN)

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Ian Campbell
On Wed, 2014-11-19 at 11:42 +, Stefano Stabellini wrote: So it looks like there is not actually anything wrong, is just that you have too much inflight irqs? It should cause problems because in that case GICH_HCR_UIE should be set and you should get a maintenance interrupt when LRs become

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
Hi Stefano, if ( !list_empty(current-arch.vgic.lr_pending) lr_all_full() ) -GICH[GICH_HCR] |= GICH_HCR_UIE; +GICH[GICH_HCR] |= GICH_HCR_NPIE; else -GICH[GICH_HCR] = ~GICH_HCR_UIE; +GICH[GICH_HCR] = ~GICH_HCR_NPIE; } Yes, exactly I

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
Hi Julien, On Wed, Nov 19, 2014 at 2:23 PM, Julien Grall julien.gr...@linaro.org wrote: On 11/19/2014 12:17 PM, Stefano Stabellini wrote: On Wed, 19 Nov 2014, Ian Campbell wrote: On Wed, 2014-11-19 at 11:42 +, Stefano Stabellini wrote: So it looks like there is not actually anything

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Julien Grall
On 11/19/2014 12:40 PM, Andrii Tseglytskyi wrote: Hi Julien, On Wed, Nov 19, 2014 at 2:23 PM, Julien Grall julien.gr...@linaro.org wrote: On 11/19/2014 12:17 PM, Stefano Stabellini wrote: On Wed, 19 Nov 2014, Ian Campbell wrote: On Wed, 2014-11-19 at 11:42 +, Stefano Stabellini wrote:

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Julien Grall
On 11/19/2014 01:30 PM, Andrii Tseglytskyi wrote: On Wed, Nov 19, 2014 at 3:26 PM, Julien Grall julien.gr...@linaro.org wrote: On 11/19/2014 12:40 PM, Andrii Tseglytskyi wrote: Hi Julien, On Wed, Nov 19, 2014 at 2:23 PM, Julien Grall julien.gr...@linaro.org wrote: On 11/19/2014 12:17 PM,

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, if ( !list_empty(current-arch.vgic.lr_pending) lr_all_full() ) -GICH[GICH_HCR] |= GICH_HCR_UIE; +GICH[GICH_HCR] |= GICH_HCR_NPIE; else -GICH[GICH_HCR] = ~GICH_HCR_UIE; +

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, On Wed, Nov 19, 2014 at 4:52 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, if ( !list_empty(current-arch.vgic.lr_pending) lr_all_full() )

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
On Wed, Nov 19, 2014 at 5:41 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, On Wed, Nov 19, 2014 at 4:52 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote:

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: On Wed, Nov 19, 2014 at 6:01 PM, Andrii Tseglytskyi andrii.tseglyts...@globallogic.com wrote: On Wed, Nov 19, 2014 at 5:41 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
On Wed, Nov 19, 2014 at 6:13 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: On Wed, Nov 19, 2014 at 6:01 PM, Andrii Tseglytskyi andrii.tseglyts...@globallogic.com wrote: On Wed, Nov 19, 2014 at 5:41 PM, Stefano Stabellini

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
Gic dump during interrupt requesting: (XEN) GICH_LRs (vcpu 0) mask=f (XEN)HW_LR[0]=3a1f (XEN)HW_LR[1]=9a015856 (XEN)HW_LR[2]=1a1b (XEN)HW_LR[3]=9a00e439 (XEN) Inflight irq=31 lr=0 (XEN) Inflight irq=86 lr=1 (XEN) Inflight irq=27 lr=2 (XEN) Inflight irq=57 lr=3 (XEN)

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
BTW - shouldn't this flag GICH_LR_MAINTENANCE_IRQ be set after maintenance interrupt requesting ? On Wed, Nov 19, 2014 at 6:32 PM, Andrii Tseglytskyi andrii.tseglyts...@globallogic.com wrote: Gic dump during interrupt requesting: (XEN) GICH_LRs (vcpu 0) mask=f (XEN)HW_LR[0]=3a1f

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: On Wed, Nov 19, 2014 at 6:13 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: On Wed, Nov 19, 2014 at 6:01 PM, Andrii Tseglytskyi andrii.tseglyts...@globallogic.com wrote: On Wed,

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
I think that's OK: it looks like that on your board for some reasons when UIE is set you get irq 1023 (spurious interrupt) instead of your normal maintenance interrupt. But everything should work anyway without issues. This is the same patch as before but on top of the lastest xen-unstable tree.

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, On Wed, Nov 19, 2014 at 7:07 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I think that's OK: it looks like that on your board for some reasons when UIE is set you get irq 1023 (spurious interrupt) instead of your

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
On Wed, Nov 19, 2014 at 7:42 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, On Wed, Nov 19, 2014 at 7:07 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I think that's OK: it looks like that on your

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
That's right, the maintenance interrupt handler is not called, but it doesn't do anything so we are fine. The important thing is that an interrupt is sent and git_clear_lrs gets called on hypervisor entry. On Wed, 19 Nov 2014, Andrii Tseglytskyi wrote: The only ambiguity left - maintenance

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Julien Grall
On 11/19/2014 06:14 PM, Stefano Stabellini wrote: That's right, the maintenance interrupt handler is not called, but it doesn't do anything so we are fine. The important thing is that an interrupt is sent and git_clear_lrs gets called on hypervisor entry. It would be worth to write down this

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Julien Grall wrote: On 11/19/2014 06:14 PM, Stefano Stabellini wrote: That's right, the maintenance interrupt handler is not called, but it doesn't do anything so we are fine. The important thing is that an interrupt is sent and git_clear_lrs gets called on hypervisor

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-19 Thread Andrii Tseglytskyi
19 лист. 2014 20:32, користувач Stefano Stabellini stefano.stabell...@eu.citrix.com написав: On Wed, 19 Nov 2014, Julien Grall wrote: On 11/19/2014 06:14 PM, Stefano Stabellini wrote: That's right, the maintenance interrupt handler is not called, but it doesn't do anything so we are

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-18 Thread Andrii Tseglytskyi
Hi Stefano, On Mon, Nov 17, 2014 at 8:02 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Mon, 17 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, Thank you for your answer. On Mon, Nov 17, 2014 at 6:39 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote:

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-18 Thread Andrii Tseglytskyi
OK, I see that GICH_V2_LR_MAINTENANCE_IRQ must always be set and everything works fine The following 2 patches fixes xen/master for my platform. Stefano, could you please take a look to these changes? commit 3628a0aa35706a8f532af865ed784536ce514eca Author: Andrii Tseglytskyi

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-18 Thread Stefano Stabellini
On Tue, 18 Nov 2014, Andrii Tseglytskyi wrote: OK, I see that GICH_V2_LR_MAINTENANCE_IRQ must always be set and everything works fine The following 2 patches fixes xen/master for my platform. Stefano, could you please take a look to these changes? commit

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-18 Thread Andrii Tseglytskyi
What if I try on top of current master branch the following code: diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 31fb81a..6764ab7 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -36,6 +36,8 @@ #include asm/io.h #include asm/gic.h +#define GIC_DEBUG 1 + /*

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-18 Thread Andrii Tseglytskyi
OK got it. Give me a few mins On Tue, Nov 18, 2014 at 6:14 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: It is not the same: I would like to set GICH_V2_LR_MAINTENANCE_IRQ only for non-hardware irqs (desc == NULL) and keep avoiding GICH_V2_LR_MAINTENANCE_IRQ and setting

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-18 Thread Andrii Tseglytskyi
Hi Stefano, No hangs with this change. Complete log is the following: U-Boot SPL 2013.10-00499-g062782f (Oct 14 2014 - 11:36:26) DRA752 ES1.0 ethaddr not set. Validating first E-fuse MAC cpsw - UART enabled - - CPU booting - - Xen starting in Hyp mode - - Zero BSS - - Setting up control

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-18 Thread Stefano Stabellini
Hello Andrii, we are getting closer :-) It would help if you post the output with GIC_DEBUG defined but without the other change that fixes the issue. I think the problem is probably due to software irqs. You are getting too many gic.c:617:d0v1 trying to inject irq=2 into d0v0, when it is still

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-17 Thread Andrii Tseglytskyi
Hi, Issue occurs after the following commit: commit 5495a512b63bad868c147198f7f049c2617d468c Author: Stefano Stabellini stefano.stabell...@eu.citrix.com Date: Tue Jun 10 15:07:12 2014 +0100 xen/arm: support HW interrupts, do not request maintenance_interrupts If the irq to be

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-17 Thread Stefano Stabellini
On Mon, 17 Nov 2014, Andrii Tseglytskyi wrote: Hi Stefano, Thank you for your answer. On Mon, Nov 17, 2014 at 6:39 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: Although it is possible that that patch is the cause of your problem, unfortunately it is part of a

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Stefano Stabellini
On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: On Fri, Nov 14, 2014 at 4:35 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: Hi, I observe system freeze on latest xen/master branch. My setup is: - Jacinto 6 evm board

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
On Fri, Nov 14, 2014 at 5:22 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: On Fri, Nov 14, 2014 at 4:35 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: Hi, I

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Stefano Stabellini
On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: On Fri, Nov 14, 2014 at 5:22 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Fri, 14 Nov 2014, Andrii Tseglytskyi wrote: On Fri, Nov 14, 2014 at 4:35 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Fri,

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
Hi Julien, On Fri, Nov 14, 2014 at 5:49 PM, Julien Grall julien.gr...@linaro.org wrote: Hi Andrii, On 11/14/2014 03:39 PM, Andrii Tseglytskyi wrote: Also note - freeze depends on system load. It reproduces more frequently if I start Android + QNX + all frontends/backends drivers. Starting

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-14 Thread Andrii Tseglytskyi
Hi Julien, I would be surprised that the next GIC series impact this code as the next driver is only compiled for arm64 (GICv3 doesn't exist on arm32). Though, there was some refactoring. I meant that code was divided for generic GIC and GICv2 together with refactoring. Also in mails I saw