Re: [Xen-devel] [PATCH v1] xen: acpi: upload _PSD info for offline CPUs too

2018-03-07 Thread Joao Martins
On 03/07/2018 05:51 PM, Boris Ostrovsky wrote: > On 03/06/2018 03:12 PM, Joao Martins wrote: >> All uploaded PM data from offline CPUs takes the info from vCPU 0 and > > "offline" may not be the right term here. Maybe "non-dom0"? > Yeah, probably clearer to use that. >> changing only the

[Xen-devel] [PATCH v2 3/5] x86: Fix APIC MSR constant names

2018-03-07 Thread Andrew Cooper
We currently have MSR_IA32_APICBASE and MSR_IA32_APICBASE_MSR which are synonymous from a naming point of view, but refer to very different things. Rename the x2APIC MSRs to MSR_X2APIC_*, which are shorter constants and visually separate the register function from the generic APIC name. For the

[Xen-devel] [PATCH v2 1/5] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

2018-03-07 Thread Andrew Cooper
Dispatch from the guest_{rd,wr}msr() functions, after confirming that the domain is configured to use viridian. This allows for simplifiction of the viridian helpers as they don't need to cope with the "not a viridian MSR" case. It also means that viridian MSRs which are unimplemented, or

[Xen-devel] [PATCH v2 2/5] x86: Handle the Xen MSRs via the new guest_{rd, wr}msr() infrastructure

2018-03-07 Thread Andrew Cooper
Dispatch from the guest_{rd,wr}msr() functions, after falling through from the !is_viridian_domain() case. Rename {rd,wr}msr_hypervisor_regs() to guest_{rd,wr}msr_xen() for consistency, and because the _regs suffix isn't very appropriate. Update them to take a vcpu pointer rather than presuming

[Xen-devel] [PATCH v2 0/5] x86: Switch some bits of MSR handing over to the new infrastructure

2018-03-07 Thread Andrew Cooper
Various changes to MSR handling which don't impact the MSR policy objects themselves. See individual patches for details. Andrew Cooper (5): x86/hvm: Handle viridian MSRs via the new guest_{rd,wr}msr() infrastructure x86: Handle the Xen MSRs via the new guest_{rd,wr}msr() infrastructure

[Xen-devel] [PATCH] common/sched: Fix ARM build following c/s 340edc3902

2018-03-07 Thread Andrew Cooper
The OSSTest smoke tests reports: sched_credit2.c: In function 'csched2_alloc_domdata': sched_credit2.c:3015:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration] return ERR_PTR(-ENOMEM); ^ sched_credit2.c:3015:9: error: nested

Re: [Xen-devel] [PATCH v2 5/5] x86/msr: Blacklist various MSRs which guests definitely shouldn't be using

2018-03-07 Thread Konrad Rzeszutek Wilk
On Wed, Mar 07, 2018 at 06:58:36PM +, Andrew Cooper wrote: > The main purpose is to blacklist the Intel Resource Director Technology MSRs. > We do not yet virtualise support for guests, but Linux has been observed to > probe for these MSRs without checking CPUID first. Bad bad guest.. > >

[Xen-devel] [xen-unstable-smoke test] 120313: regressions - FAIL

2018-03-07 Thread osstest service owner
flight 120313 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120313/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 120304 build-armhf

[Xen-devel] tools/libacpi printf output to logging instead of console/stdout ?

2018-03-07 Thread Sander Eikelenboom
L.S., When starting a guest with the 'xl create' command (non-verbose) i get this extra output on PVH guest types only: S3 disabled S4 disabled CONV disabled It seems libacpi/* only contains normal printf's, so for the other guest types i probably just never triggered one of them. Shouldn't

[Xen-devel] [PATCH v2 5/5] x86/msr: Blacklist various MSRs which guests definitely shouldn't be using

2018-03-07 Thread Andrew Cooper
The main purpose is to blacklist the Intel Resource Director Technology MSRs. We do not yet virtualise support for guests, but Linux has been observed to probe for these MSRs without checking CPUID first. The architecturally inaccessable ranges don't need to fall back into the legacy ranges,

[Xen-devel] [PATCH 4.14 031/110] x86/xen: Zero MSR_IA32_SPEC_CTRL before suspend

2018-03-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Juergen Gross commit 71c208dd54ab971036d83ff6d9837bae4976e623 upstream. Older Xen versions (4.5 and before) might have problems migrating pv guests with MSR_IA32_SPEC_CTRL

[Xen-devel] [PATCH v2 6/6] xen/domain: Added debug safety in the domain_create() failure path

2018-03-07 Thread Andrew Cooper
Hitting the fail path with err = 0 causes callers to dereference a NULL pointer, as 0 fails an IS_ERR() check. All of the paths appear to be fine, but leave some logic to help catch stray misuses. Signed-off-by: Andrew Cooper --- CC: George Dunlap

[Xen-devel] [qemu-mainline test] 120274: trouble: broken/fail/pass

2018-03-07 Thread osstest service owner
flight 120274 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/120274/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu broken

Re: [Xen-devel] [PATCH 37/57] ARM: new VGIC: Add ENABLE registers handlers

2018-03-07 Thread Julien Grall
(sorry for the formatting) On Wed, 7 Mar 2018, 18:23 Andre Przywara, wrote: > Hi, > > On 07/03/18 17:01, Julien Grall wrote: > > Hi Andre, > > > > On 03/05/2018 04:03 PM, Andre Przywara wrote: > >> As the enable register handlers are shared between the v2 and v3 > >>

[Xen-devel] [PATCH 4.15 036/122] x86/xen: Zero MSR_IA32_SPEC_CTRL before suspend

2018-03-07 Thread Greg Kroah-Hartman
4.15-stable review patch. If anyone has any objections, please let me know. -- From: Juergen Gross commit 71c208dd54ab971036d83ff6d9837bae4976e623 upstream. Older Xen versions (4.5 and before) might have problems migrating pv guests with MSR_IA32_SPEC_CTRL

Re: [Xen-devel] [PATCH 37/57] ARM: new VGIC: Add ENABLE registers handlers

2018-03-07 Thread Andre Przywara
Hi, On 07/03/18 17:01, Julien Grall wrote: > Hi Andre, > > On 03/05/2018 04:03 PM, Andre Przywara wrote: >> As the enable register handlers are shared between the v2 and v3 >> emulation, their implementation goes into vgic-mmio.c, to be easily >> referenced from the v3 emulation as well later.

[Xen-devel] [PATCH v2 4/5] x86/hvm: Handle x2apic MSRs via the new guest_{rd, wr}msr() infrastructure

2018-03-07 Thread Andrew Cooper
Dispatch from the guest_{rd,wr}msr() functions. The read side should be safe outside of current context, but the write side is definitely not. As the toolstack has no legitimate reason to access the APIC registers via this interface (not least because whether they are accessible at all depends

Re: [Xen-devel] [PATCH v2 3/5] x86: Fix APIC MSR constant names

2018-03-07 Thread Konrad Rzeszutek Wilk
On Wed, Mar 07, 2018 at 06:58:34PM +, Andrew Cooper wrote: > We currently have MSR_IA32_APICBASE and MSR_IA32_APICBASE_MSR which are > synonymous from a naming point of view, but refer to very different things. > > Rename the x2APIC MSRs to MSR_X2APIC_*, which are shorter constants and >

[Xen-devel] [PATCH LINUX] Fixes to xen-blkfront.

2018-03-07 Thread Konrad Rzeszutek Wilk
Hi! We found this tiny bug when we were unplugging and re-plugging different block-devices to a guest and found a bug in there resulting in the multi-queue parameter being lost. This patch fixes it. I meant to post this in December but got side-tracked with Spectre_v2 work.

Re: [Xen-devel] [PATCH v2 4/5] x86/hvm: Handle x2apic MSRs via the new guest_{rd, wr}msr() infrastructure

2018-03-07 Thread Konrad Rzeszutek Wilk
On Wed, Mar 07, 2018 at 06:58:35PM +, Andrew Cooper wrote: > Dispatch from the guest_{rd,wr}msr() functions. The read side should be safe > outside of current context, but the write side is definitely not. As the > toolstack has no legitimate reason to access the APIC registers via this >

[Xen-devel] [PATCH] xen-blkfront: move negotiate_mq to cover all cases of new VBDs

2018-03-07 Thread Konrad Rzeszutek Wilk
From: Bhavesh Davda negotiate_mq should happen in all cases of a new VBD being discovered by xen-blkfront, whether called through _probe() or a hot-attached new VBD from dom-0 via xenstore. Otherwise, hot-attached new VBDs are left configured without multi-queue.

Re: [Xen-devel] [PATCH] common/sched: Fix ARM build following c/s 340edc3902

2018-03-07 Thread Stefano Stabellini
On Wed, 7 Mar 2018, Andrew Cooper wrote: > The OSSTest smoke tests reports: > > sched_credit2.c: In function 'csched2_alloc_domdata': > sched_credit2.c:3015:9: error: implicit declaration of function 'ERR_PTR' > [-Werror=implicit-function-declaration] >return ERR_PTR(-ENOMEM); >

[Xen-devel] [linux-3.18 test] 120276: tolerable FAIL - PUSHED

2018-03-07 Thread osstest service owner
flight 120276 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/120276/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 16 guest-localmigrate/x10 fail in 120235 pass in 120276

[Xen-devel] [libvirt test] 120277: tolerable all pass - PUSHED

2018-03-07 Thread osstest service owner
flight 120277 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/120277/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 120188 test-armhf-armhf-libvirt 14

[Xen-devel] [xen-unstable-smoke test] 120321: regressions - FAIL

2018-03-07 Thread osstest service owner
flight 120321 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120321/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 120304 build-armhf

Re: [Xen-devel] [PATCH v2 3/5] x86: Fix APIC MSR constant names

2018-03-07 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, March 8, 2018 2:59 AM > > We currently have MSR_IA32_APICBASE and MSR_IA32_APICBASE_MSR > which are > synonymous from a naming point of view, but refer to very different things. > > Rename the x2APIC MSRs to MSR_X2APIC_*,

[Xen-devel] [xen-unstable-smoke test] 120316: regressions - FAIL

2018-03-07 Thread osstest service owner
flight 120316 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120316/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 120304 build-armhf

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-xl-qemut-ws16-amd64

2018-03-07 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemut-ws16-amd64 testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

[Xen-devel] [xen-4.9-testing test] 120278: regressions - trouble: broken/fail/pass

2018-03-07 Thread osstest service owner
flight 120278 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120278/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-pvgrub broken test-amd64-amd64-pygrub

Re: [Xen-devel] Xen Virtio Drivers

2018-03-07 Thread Christopher Clark
On Wed, Mar 7, 2018 at 6:13 AM, Volo M. wrote: > Hi Devs, > > Could you please help me to identify right way to start using Virtio > drivers for Xen guests > *HiThis reply might not be the answer that you’re looking for, but it may be helpful for the next person

[Xen-devel] [xen-unstable-smoke test] 120329: regressions - FAIL

2018-03-07 Thread osstest service owner
flight 120329 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120329/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 120304 build-armhf

Re: [Xen-devel] [PATCH v4 0/7] unsafe big.LITTLE support

2018-03-07 Thread Peng Fan
Hi Stefano, On Fri, Mar 02, 2018 at 11:05:54AM -0800, Stefano Stabellini wrote: >Hi all, > >This series changes the initialization of two virtual registers to make >sure they match the value of the underlying physical cpu. > >It also disables cpus different from the boot cpu, unless a newly

[Xen-devel] [xen-unstable-smoke bisection] complete build-arm64-xsm

2018-03-07 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-arm64-xsm testid xen-build Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug

[Xen-devel] [xen-unstable-smoke test] 120334: regressions - FAIL

2018-03-07 Thread osstest service owner
flight 120334 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120334/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 120304 build-armhf

[Xen-devel] [ovmf test] 120285: all pass - PUSHED

2018-03-07 Thread osstest service owner
flight 120285 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/120285/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5e3719aeaef198f36808a5e53a1f5bb23762e3a5 baseline version: ovmf

Re: [Xen-devel] [PATCH 38/57] ARM: new VGIC: Add PENDING registers handlers

2018-03-07 Thread Julien Grall
Hi Andre, On 03/05/2018 04:03 PM, Andre Przywara wrote: The pending register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. For level triggered interrupts the real line level is

Re: [Xen-devel] [PATCH v1] xen: acpi: upload _PSD info for offline CPUs too

2018-03-07 Thread Boris Ostrovsky
On 03/06/2018 03:12 PM, Joao Martins wrote: > All uploaded PM data from offline CPUs takes the info from vCPU 0 and "offline" may not be the right term here. Maybe "non-dom0"? > changing only the acpi_id. For processors which P-state coordination type > is HW_ALL (0xFD) it is OK to upload bogus

Re: [Xen-devel] osstest planned outage consultation

2018-03-07 Thread Jan Beulich
>>> On 06.03.18 at 20:32, wrote: > Jan Beulich writes ("Re: osstest planned outage consultation"): >> The most recent flights don't look too bad anymore (at least >> most of the have started disappearing again), so >> there's some hop for pushes soon. I hope to get around

Re: [Xen-devel] [alsa-devel] [PATCH 0/2] sndif: add explicit back and front synchronization

2018-03-07 Thread Oleksandr Andrushchenko
On 03/06/2018 06:30 PM, Takashi Iwai wrote: On Tue, 06 Mar 2018 17:04:41 +0100, Oleksandr Andrushchenko wrote: If we decide to negotiate the parameters, then it can't be done at .open stage as well, as at this moment we don't know stream parameters yet, e.g. we don't know the number of

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Wei Liu
On Wed, Mar 07, 2018 at 11:17:44AM +0100, Juergen Gross wrote: > Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread > stack size for watch thread") added a dependency to libdl to > libxenstore. > > Add the needed flags to LDLIBS_libxenstore and the pkg-config file of >

[Xen-devel] [xen-unstable-coverity test] 120298: regressions - ALL FAIL

2018-03-07 Thread osstest service owner
flight 120298 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/120298/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd647 coverity-upload fail REGR. vs. 119558 version

Re: [Xen-devel] Save the date: Xen Project Developer Summit, Nanjing, China, June 20-22 (Wednesday - Friday)

2018-03-07 Thread Lars Kurth
Hi everyone, a quick update. We finally have the contract in hand: that took a lot longer than expected as we didn't realise that contracts which involve foreign events hosted in China, need to be vetted by the Chinese government. My LF contact will meet the Linux Foundation's contract

Re: [Xen-devel] [PATCH 27/57] ARM: new VGIC: Add data structure definitions

2018-03-07 Thread Julien Grall
Hi Andre, On 03/06/2018 06:01 PM, Andre Przywara wrote: On 06/03/18 17:46, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote: Add a new header file for the new and improved GIC implementation. The big change is that we now have a struct vgic_irq per IRQ instead of spreading all the

[Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Juergen Gross
Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread stack size for watch thread") added a dependency to libdl to libxenstore. Add the needed flags to LDLIBS_libxenstore and the pkg-config file of libxenstore. Fixes: 448c03b3cbe14873ee63 Signed-off-by: Juergen Gross

[Xen-devel] [linux-linus test] 120269: regressions - FAIL

2018-03-07 Thread osstest service owner
flight 120269 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/120269/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 118324

Re: [Xen-devel] [OSSTEST PATCH v2 04/19] ts-xen-install: install some packages on stretch

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 04/19] ts-xen-install: install some packages on stretch"): > The "route" command is now in that package. > > libnl is needed when running xl. ... > +if ($ho->{Suite} =~ m/stretch/) { > +target_install_packages($ho, 'net-tools libnl-route-3-200'); >

[Xen-devel] Xen Virtio Drivers

2018-03-07 Thread Volo M.
Hi Devs, Could you please help me to identify right way to start using Virtio drivers for Xen guests as described here https://wiki.xen.org/wiki/QEMU_Upstream . I've managed to start my Windows 2008 VM with Virtio network drivers by using 'model='virtio-net'' option as described above and it

Re: [Xen-devel] [OSSTEST PATCH v2 02/19] ts-xen-build-prep: only install w3c-dtd-xhtml for suites

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 02/19] ts-xen-build-prep: only install w3c-dtd-xhtml for suites That package is not included in Stretch. > > That package was installed because libvirt build needed it. However > libvirt builds fine without it in Stretch. Acked-by: Ian Jackson

Re: [Xen-devel] [PATCH 29/57] ARM: new VGIC: Implement virtual IRQ injection

2018-03-07 Thread Julien Grall
Hi Andre, Overall this patch looks good. Few comments below. On 03/05/2018 04:03 PM, Andre Przywara wrote: +/* + * Only valid injection if changing level for level-triggered IRQs or for a + * rising edge. + */ +static bool vgic_validate_injection(struct vgic_irq *irq, bool level) +{ +if (

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Juergen Gross
On 07/03/18 11:17, Juergen Gross wrote: > Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread > stack size for watch thread") added a dependency to libdl to > libxenstore. > > Add the needed flags to LDLIBS_libxenstore and the pkg-config file of > libxenstore. > > Fixes:

[Xen-devel] [PATCH v2] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Juergen Gross
Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread stack size for watch thread") added a dependency to libdl to libxenstore. Add the needed flags to LDLIBS_libxenstore and the pkg-config file of libxenstore. Fixes: 448c03b3cbe14873ee63 Signed-off-by: Juergen Gross

Re: [Xen-devel] [PATCH v2] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Wei Liu
On Wed, Mar 07, 2018 at 12:03:18PM +0100, Juergen Gross wrote: > Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread > stack size for watch thread") added a dependency to libdl to > libxenstore. > > Add the needed flags to LDLIBS_libxenstore and the pkg-config file of >

Re: [Xen-devel] [PATCH] tools/xenstore: Don't link libxenstore against systemd

2018-03-07 Thread Wei Liu
On Wed, Mar 07, 2018 at 11:13:33AM +, Andrew Cooper wrote: > It is only xenstored which uses libsystemd. Avoid having libxenstored pull > libsystemd into the address space of all of its users. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu

Re: [Xen-devel] [PATCH 29/57] ARM: new VGIC: Implement virtual IRQ injection

2018-03-07 Thread Andre Przywara
Hi, On 07/03/18 11:02, Julien Grall wrote: > Hi Andre, > > Overall this patch looks good. Few comments below. > > On 03/05/2018 04:03 PM, Andre Przywara wrote: >> +/* >> + * Only valid injection if changing level for level-triggered IRQs or >> for a >> + * rising edge. >> + */ >> +static bool

Re: [Xen-devel] [PATCH] tools/libxc: Correct comment for normalise_pagetable()

2018-03-07 Thread Wei Liu
On Wed, Mar 07, 2018 at 12:15:51PM +, Andrew Cooper wrote: > This is most likely a copy/paste mistake. > > Reported-by: Bruno Alvisio > Signed-off-by: Andrew Cooper Acked-by: Wei Liu

Re: [Xen-devel] [PATCH 30/57] ARM: new VGIC: Add IRQ sorting

2018-03-07 Thread Julien Grall
Hi Andre, On 03/05/2018 04:03 PM, Andre Przywara wrote: Adds the sorting function to cover the case where you have more IRQs to consider than you have LRs. We consider their priorities. This pulls in Linux' list_sort.c, which is a merge sort implementation for linked lists. Apart from adding a

Re: [Xen-devel] [PATCH 29/57] ARM: new VGIC: Implement virtual IRQ injection

2018-03-07 Thread Julien Grall
Hi Andre, On 03/07/2018 11:22 AM, Andre Przywara wrote: On 07/03/18 11:02, Julien Grall wrote: Overall this patch looks good. Few comments below. On 03/05/2018 04:03 PM, Andre Przywara wrote: +/* + * Only valid injection if changing level for level-triggered IRQs or for a + * rising edge. +

Re: [Xen-devel] [PATCH 32/57] ARM: new VGIC: Add GICv2 world switch backend

2018-03-07 Thread Julien Grall
Hi Andre, On 03/05/2018 04:03 PM, Andre Przywara wrote: +void vgic_v2_fold_lr_state(struct vcpu *vcpu) +{ +struct vgic_cpu *vgic_cpu = >arch.vgic; +unsigned int used_lrs = vcpu->arch.vgic.used_lrs; +unsigned long flags; +unsigned int lr; + +if ( !used_lrs )/* No LRs

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Juergen Gross
On 07/03/18 12:19, Ian Jackson wrote: > Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to > libxenstore"): >> libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl >> +else >> +PKG_CONFIG_REMOVE += dl > > What is this ? -ldl is needed on Linux only, but I didn't want to add a

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Juergen Gross
On 07/03/18 13:06, ian.jack...@citrix.com wrote: > Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to > libxenstore"): >> On 07/03/18 12:19, Ian Jackson wrote: >>> Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to >>> libxenstore"):

[Xen-devel] [PATCH] tools/libxc: Correct comment for normalise_pagetable()

2018-03-07 Thread Andrew Cooper
This is most likely a copy/paste mistake. Reported-by: Bruno Alvisio Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu --- tools/libxc/xc_sr_save_x86_pv.c | 2 +- 1 file changed, 1

Re: [Xen-devel] [PATCH 31/57] ARM: new VGIC: Add IRQ sync/flush framework

2018-03-07 Thread Andre Przywara
Hi, On 07/03/18 11:47, Julien Grall wrote: > Hi Andre, > > On 03/05/2018 04:03 PM, Andre Przywara wrote: >> Implement the framework for syncing IRQs between our emulation and the >> list registers, which represent the guest's view of IRQs. >> This is done in kvm_vgic_flush_hwstate and

Re: [Xen-devel] Setting up a Xen x86 community call

2018-03-07 Thread Lars Kurth
Hi all, thanks for the feedback. It seems to me that the following times satisfy all requirements. Those with minor issues are on the TO list and called out below. Winter == 15:00 - 16:00 UTC 07:00 - 08:00 Pacific 09:00 - 10:00 Austin 10:00 - 11:00 New York 15:00 - 16:00 London 16:00 -

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Wei Liu
On Wed, Mar 07, 2018 at 12:01:25PM +0100, Juergen Gross wrote: > On 07/03/18 11:17, Juergen Gross wrote: > > Commit 448c03b3cbe14873ee63 ("tools/xenstore: try to get minimum thread > > stack size for watch thread") added a dependency to libdl to > > libxenstore. > > > > Add the needed flags to

[Xen-devel] [PATCH] tools/xenstore: Don't link libxenstore against systemd

2018-03-07 Thread Andrew Cooper
It is only xenstored which uses libsystemd. Avoid having libxenstored pull libsystemd into the address space of all of its users. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu ---

[Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread Ian Jackson
Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to libxenstore"): > libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl > +else > +PKG_CONFIG_REMOVE += dl What is this ? Ian. ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 31/57] ARM: new VGIC: Add IRQ sync/flush framework

2018-03-07 Thread Julien Grall
Hi Andre, On 03/05/2018 04:03 PM, Andre Przywara wrote: Implement the framework for syncing IRQs between our emulation and the list registers, which represent the guest's view of IRQs. This is done in kvm_vgic_flush_hwstate and kvm_vgic_sync_hwstate, which You probably want to update the

Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

2018-03-07 Thread ian.jackson
Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to libxenstore"): > On 07/03/18 12:19, Ian Jackson wrote: > > Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to > > libxenstore"): > >> libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl > >> +else > >>

Re: [Xen-devel] [PATCH 32/57] ARM: new VGIC: Add GICv2 world switch backend

2018-03-07 Thread Andre Przywara
Hi, On 07/03/18 12:10, Julien Grall wrote: > Hi Andre, > > On 03/05/2018 04:03 PM, Andre Przywara wrote: >> +void vgic_v2_fold_lr_state(struct vcpu *vcpu) >> +{ >> +    struct vgic_cpu *vgic_cpu = >arch.vgic; >> +    unsigned int used_lrs = vcpu->arch.vgic.used_lrs; >> +    unsigned long flags;

Re: [Xen-devel] [OSSTEST PATCH v2 14/19] ts-guests-nbd-mirror: make it work with stretch

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 14/19] ts-guests-nbd-mirror: make it work with stretch"): > On the server side, only add oldstyle= and port= on Wheezy and Jessie. > Stretch doesn't support or need those anymore. ... > +if ($cho->{Suite} !~ m/stretch/) { > +

Re: [Xen-devel] [OSSTEST PATCH v2 17/19] Skip bootloader installation for arm32 in Stretch

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 17/19] Skip bootloader installation for arm32 in Stretch"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson But some minor style questions: > diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm > index

Re: [Xen-devel] [PATCH 34/57] ARM: new VGIC: Add MMIO handling framework

2018-03-07 Thread Julien Grall
Hi, On 03/05/2018 04:03 PM, Andre Przywara wrote: Add an MMIO handling framework to the VGIC emulation: Each register is described by its offset, size (or number of bits per IRQ, if applicable) and the read/write handler functions. We provide initialization macros to describe each GIC register

Re: [Xen-devel] [OSSTEST PATCH v2 05/19] Debian.pm: use sysvinit-core instead of systemd

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 05/19] Debian.pm: use sysvinit-core instead of systemd"): > Install that packages for suites >wheezy, because they use systemd as > the default init. Acked-by: Ian Jackson ___ Xen-devel

Re: [Xen-devel] [PATCH 35/57] ARM: new VGIC: Add GICv2 MMIO handling framework

2018-03-07 Thread Julien Grall
Hi Andre, On 03/05/2018 04:03 PM, Andre Przywara wrote: Create vgic-mmio-v2.c to describe GICv2 emulation specific handlers using the initializer macros provided by the VGIC MMIO framework. Provide a function to register the GICv2 distributor registers to the Xen MMIO framework. The actual

[Xen-devel] [xen-4.7-testing test] 120270: FAIL

2018-03-07 Thread osstest service owner
flight 120270 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120270/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-pair broken in 120232

Re: [Xen-devel] [OSSTEST PATCH v2 09/19] ts-debian-fixup: merge origin extra= to our own

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 09/19] ts-debian-fixup: merge origin extra= to our own"): > The original extra= was not removed, so there were two extra= in the > resulting config file. > > It wasn't a problem for xl because the second extra= took precedence. > However libvirt tests would

Re: [Xen-devel] [OSSTEST PATCH v2 11/19] ts-debian-hvm-install: disable new nic naming scheme

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 11/19] ts-debian-hvm-install: disable new nic naming scheme"): > This is required to fix nested hvm test. The L1 host is installed by > this script. We want the L1 host to not use the new nic naming scheme. Without this, and without the scheme that was in

Re: [Xen-devel] [OSSTEST PATCH v2 13/19] TestSupport: add dpkg option when installing packages

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 13/19] TestSupport: add dpkg option when installing packages"): > Upgrading configuration file of nbd-client is controlled by dpkg in > stretch. Add dpkg option to keep old configuration file(s). I don't think w just want to suppress all these conffile

Re: [Xen-devel] [OSSTEST PATCH v2 18/19] make-flight: don't test pvgrub for Xen XXX

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 18/19] make-flight: don't test pvgrub for Xen XXX"): > XXX Need to pin down the version of Xen when the upgrade to stretch is > complete because osstest configuration is branched for each version. I don't understand this. > + # pvgrub1 tests for version < XXX

Re: [Xen-devel] [OSSTEST PATCH v2 07/19] ts-host-install: don't use the new nic naming scheme

2018-03-07 Thread Ian Jackson
Ian Jackson writes ("Re: [Xen-devel] [OSSTEST PATCH v2 07/19] ts-host-install: don't use the new nic naming scheme"): > Wei Liu writes ("Re: [Xen-devel] [OSSTEST PATCH v2 07/19] ts-host-install: > don't use the new nic naming scheme"): > > It is rather different. It is a hack put in by IanC to

Re: [Xen-devel] [OSSTEST PATCH v2 10/19] ts-debian-fixup: use correct resume device

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 10/19] ts-debian-fixup: use correct resume device"): > See code comment for explanation. ... > +$cfg =~ m/'phy:.+-swap,(xvda\d+),.*'/; This is quite a careless regexp! > +$extra .= " resume=/dev/$1"; > +logm("change resume device to $1"); Can't we

Re: [Xen-devel] [OSSTEST PATCH v2 16/19] Set mac address in interfaces(5) if force-mac-address is set

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 16/19] Set mac address in interfaces(5) if force-mac-address is set"): > ff9e0d8cbd generated a udev rule for setting the mac address. But that > udev rule is not copied into the target so reboot after installation > will fail. > > We can copy the udev rule to

Re: [Xen-devel] Xen Virtio Drivers

2018-03-07 Thread Volo M.
Thanks, Cool, I'll have to check how to tweak xen build. Will I have to change below disk lines of XL toolkit VM config somehow to enable using Virtio drives emulation or custom xen build just enable it by those kvm-enabled tweak for all HVM guests within hypervisor? vif = [ "model=virtio-net,

[Xen-devel] X86 Community Call: Wed March 14, 15:00 - 16:00 UTC

2018-03-07 Thread Lars Kurth
Hi all, please find attached a) Meeting details (attached meeting invite) b) Bridge details c) Call for agenda items I will collate input and send out a complete agenda, Monday the 12th. Depending on volume of agenda requests, I may have to limit agenda items per person/vendor. Please be

Re: [Xen-devel] [OSSTEST PATCH v2 19/19] Switch to Debian Stretch

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 19/19] Switch to Debian Stretch"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [OSSTEST PATCH v2 15/19] Add clk_ignore_unused for stretch for arm hosts

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 15/19] Add clk_ignore_unused for stretch for arm hosts"): > Without that parameter we lose uart output. In this patch we are propagating a workaroound further into the future. This is an opportunity to prod the people responsible for the bug. Julien, is this

Re: [Xen-devel] Setting up a Xen x86 community call

2018-03-07 Thread Daniel Kiper
On Wed, Mar 07, 2018 at 01:27:45PM +0100, Lars Kurth wrote: > Hi all, > > thanks for the feedback. It seems to me that the following times satisfy all > requirements. > Those with minor issues are on the TO list and called out below. > > Winter > == > 15:00 - 16:00 UTC > 07:00 - 08:00 Pacific

Re: [Xen-devel] [OSSTEST PATCH v2 08/19] ts-guests-nbd-mirror: use target_{get, put}file_root to transfter cfg

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 08/19] ts-guests-nbd-mirror: use target_{get,put}file_root to transfter cfg"): > The original code used target_cmd_output_root which caused a trailing > new line to be deleted, which caused libvirt converter to fail. > > It wasn't discovered until now because

Re: [Xen-devel] Xen Virtio Drivers

2018-03-07 Thread Konrad Rzeszutek Wilk
On Wed, Mar 07, 2018 at 04:13:47PM +0200, Volo M. wrote: > Hi Devs, > > Could you please help me to identify right way to start using Virtio > drivers for Xen guests > as described here https://wiki.xen.org/wiki/QEMU_Upstream . > I've managed to start my Windows 2008 VM with Virtio network

Re: [Xen-devel] [OSSTEST PATCH v2 12/19] ts-xen-build-prep: install e2fslibs-dev

2018-03-07 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH v2 12/19] ts-xen-build-prep: install e2fslibs-dev"): > The in-tree libfsimage ext2fs implementation can't handle 64bit > enabled ext4, which is the default in stretch. > > Installing e2fslibs-dev causes libfsimage to pick up the packaged > ext2fs implementation.

[Xen-devel] [xen-unstable-smoke test] 120304: tolerable all pass - PUSHED

2018-03-07 Thread osstest service owner
flight 120304 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120304/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [PATCH v3 2/7] x86/alt: Clean up struct alt_instr and its users

2018-03-07 Thread Andrew Cooper
* Rename some fields for consistency and clarity, and use standard types. * Don't opencode the use of ALT_{ORIG,REPL}_PTR(). No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu Reviewed-by: Roger Pau Monné

[Xen-devel] [PATCH v3 1/7] x86/alt: Drop unused alternative infrastructure

2018-03-07 Thread Andrew Cooper
ALTERNATIVE_3 is more complicated than ALTERNATIVE_2 when it comes to calculating extra padding length, and we have no need for the complexity. Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu Reviewed-by: Roger Pau Monné

[Xen-devel] [PATCH v3 6/7] x86/alt: Drop explicit padding of origin sites

2018-03-07 Thread Andrew Cooper
Now that the alternatives infrastructure can calculate the required padding automatically, there is no need to hard code it. Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu Reviewed-by: Roger Pau Monné Reviewed-by: Jan

Re: [Xen-devel] [PATCH 36/57] ARM: new VGIC: Add CTLR, TYPER and IIDR handlers

2018-03-07 Thread Julien Grall
Hi Andre, On 03/05/2018 04:03 PM, Andre Przywara wrote: +static void vgic_mmio_write_v2_misc(struct vcpu *vcpu, +paddr_t addr, unsigned int len, +unsigned long val) +{ +struct vgic_dist *dist = >domain->arch.vgic; +

Re: [Xen-devel] preparations for 4.9.2 and 4.7.5

2018-03-07 Thread Wei Liu
On Tue, Mar 06, 2018 at 08:32:48AM -0700, Jan Beulich wrote: > All, > > these stable releases should go out before the end of the month. > Please point out backport candidates you find missing from the > respective staging branches, but which you consider relevant. > Please note that 4.7.5 is

[Xen-devel] [xen-4.6-testing test] 120273: regressions - FAIL

2018-03-07 Thread osstest service owner
flight 120273 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120273/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-3 50 xtf/test-hvm64-lbr-tsx-vmentry fail REGR. vs. 119227

Re: [Xen-devel] [PATCH 37/57] ARM: new VGIC: Add ENABLE registers handlers

2018-03-07 Thread Julien Grall
Hi Andre, On 03/05/2018 04:03 PM, Andre Przywara wrote: As the enable register handlers are shared between the v2 and v3 emulation, their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. This introduces a vgic_sync_hardware_irq() function, which

[Xen-devel] [PATCH v3 3/7] x86/alt: Clean up the assembly used to generate alternatives

2018-03-07 Thread Andrew Cooper
* On the C side, switch to using local lables rather than hardcoded numbers. * Rename parameters and lables to be consistent with alt_instr names, and consistent between the the C and asm versions. * On the asm side, factor some expressions out into macros to aid clarity. * Consistently

[Xen-devel] [PATCH v3 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-03-07 Thread Andrew Cooper
With future changes, altinstruction_entry is going to become more complicated to use. Furthermore, there are already ALTERNATIVE* macros which can be used to avoid opencoding the creation of replacement information. For ASM_STAC, ASM_CLAC and CR4_PV32_RESTORE, this means the removal of all

  1   2   >