Re: [Xen-devel] [PATCH v3 4/6] ALSA: xen-front: Implement handling of shared buffers

2018-05-15 Thread Oleksandr Andrushchenko
On 05/15/2018 09:01 AM, Takashi Iwai wrote: On Tue, 15 May 2018 07:46:38 +0200, Oleksandr Andrushchenko wrote: On 05/14/2018 11:28 PM, Takashi Iwai wrote: On Mon, 14 May 2018 08:27:40 +0200, Oleksandr Andrushchenko wrote: --- /dev/null +++ b/sound/xen/xen_snd_front_shbuf.c @@ -0,0 +1,193 @@

Re: [Xen-devel] [PATCH v3 4/6] ALSA: xen-front: Implement handling of shared buffers

2018-05-15 Thread Takashi Iwai
On Tue, 15 May 2018 07:46:38 +0200, Oleksandr Andrushchenko wrote: > > On 05/14/2018 11:28 PM, Takashi Iwai wrote: > > On Mon, 14 May 2018 08:27:40 +0200, > > Oleksandr Andrushchenko wrote: > >> --- /dev/null > >> +++ b/sound/xen/xen_snd_front_shbuf.c > >> @@ -0,0 +1,193 @@ > >> +//

Re: [Xen-devel] [PATCH 5/5] docs/pvh: document initial MTRR state

2018-05-15 Thread Jan Beulich
>>> On 14.05.18 at 18:18, wrote: > On Mon, May 14, 2018 at 10:13:47AM -0600, Jan Beulich wrote: >> >>> On 14.05.18 at 18:03, wrote: >> > On Thu, May 10, 2018 at 06:15:05PM +0100, Roger Pau Monne wrote: >> >> --- a/docs/misc/pvh.markdown >> >> +++

Re: [Xen-devel] [RFC][PATCH] KVM: APPLES can improve the performance of applications and virtualized systems by up to 49%

2018-05-15 Thread Wei Liu
On Sat, May 12, 2018 at 04:27:04PM +0800, Weiwei Jia wrote: > Dear all, > > Recently, we made a few improvements on effectively utilizing Pause > Loop Exiting (PLE) support for higher throughput on virtualized > systems. Basically, it solves two problems: 1) how to adjust > PLE_Window; 2) how to

Re: [Xen-devel] [PATCH RFC 1/7] xen: Introduce XEN_COMPILE_POSIX_TIME

2018-05-15 Thread Jan Beulich
>>> On 14.05.18 at 18:25, wrote: > On Mon, May 14, 2018 at 04:30:02AM -0600, Jan Beulich wrote: >> >>> On 08.05.18 at 14:18, wrote: >> > On Mon, Apr 30, 2018 at 09:56:38AM -0600, Jan Beulich wrote: >> >> >>> On 08.07.17 at 23:53,

Re: [Xen-devel] [PATCH 3/5] hvm/mtrr: copy hardware state for Dom0

2018-05-15 Thread Jan Beulich
>>> On 14.05.18 at 18:33, wrote: > On Mon, May 14, 2018 at 08:26:30AM -0600, Jan Beulich wrote: >> >>> On 10.05.18 at 19:15, wrote: >> > Copy the state found on the hardware when creating a PVH Dom0. Since >> > the memory map provided to a PVH Dom0 is

Re: [Xen-devel] [PATCH RFC 2/7] xen/x86: Manually build PE header

2018-05-15 Thread Jan Beulich
>>> On 14.05.18 at 18:52, wrote: > On Mon, May 14, 2018 at 04:40:39AM -0600, Jan Beulich wrote: >> >>> On 08.05.18 at 14:47, wrote: >> > On Fri, May 04, 2018 at 09:38:03AM -0600, Jan Beulich wrote: >> >> >>> On 08.07.17 at 23:53,

Re: [Xen-devel] [PATCH RFC 6/7] xen/x86/efi: Verify dom0 kernel with SHIM_LOCK protocol in efi_multiboot2()

2018-05-15 Thread Jan Beulich
>>> On 14.05.18 at 18:56, wrote: > On Mon, May 14, 2018 at 04:43:13AM -0600, Jan Beulich wrote: >> >>> On 08.05.18 at 15:09, wrote: >> > On Fri, May 04, 2018 at 09:46:33AM -0600, Jan Beulich wrote: >> >> >>> On 08.07.17 at 23:53,

[Xen-devel] [PATCH v2 3/6] hvm/mtrr: use the hardware number of variable ranges for Dom0

2018-05-15 Thread Roger Pau Monne
Expand the size of the variable ranges array to match the size of the underlying hardware, this is a preparatory change for copying the hardware MTRR state for Dom0. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper

[Xen-devel] [PATCH v2 5/6] libxc/pvh: set default MTRR type to write-back

2018-05-15 Thread Roger Pau Monne
And enable MTRR. This allows to provide a sane initial MTRR state for PVH DomUs. This will have to be expanded when pci-passthrough support is added to PVH guests, so that MMIO regions of devices are set as UC. Note that initial MTRR setup is done by hvmloader for HVM guests, that's not used by

[Xen-devel] [PATCH v2 6/6] docs/pvh: document initial MTRR state

2018-05-15 Thread Roger Pau Monne
Provided to both Dom0 and DomUs. Signed-off-by: Roger Pau Monné --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall

[Xen-devel] [PATCH v2 1/6] hvm/mtrr: add emacs local variables block with formatting info

2018-05-15 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/hvm/mtrr.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c index

[Xen-devel] [PATCH v2 0/6] PVH MTRR initial stat

2018-05-15 Thread Roger Pau Monne
Hello, The following patches set a sane initial MTRR state for both Dom0 and DomU PVH guests. Note that for Dom0 the host MTRR state is used, OTOH for DomU the default MTRR type is set to write-back. This should avoid guests having to setup some kind of MTRR state in order to boot. Thanks,

[Xen-devel] [PATCH v2 2/6] mtrr: introduce mask to get VCNT from MTRRcap MSR

2018-05-15 Thread Roger Pau Monne
No functional change. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/cpu/mtrr/main.c| 2 +- xen/arch/x86/hvm/mtrr.c | 6 +++--- xen/include/asm-x86/msr-index.h | 2 ++ 3

[Xen-devel] [PATCH v2 4/6] hvm/mtrr: copy hardware state for Dom0

2018-05-15 Thread Roger Pau Monne
Copy the state found on the hardware when creating a PVH Dom0. Since the memory map provided to a PVH Dom0 is based on the native one using the same set of MTRR ranges should provide Dom0 with a sane MTRR state without having to manually build it in Xen. Signed-off-by: Roger Pau Monné

[Xen-devel] [PATCH for-4.11 0/3] Support matrix: add missing caveat footnotes

2018-05-15 Thread Ian Jackson
From: Ian Jackson Lars spotted that the support matrix https://xenbits.xen.org/docs/unstable/support-matrix.html is missing some footnotes. These three patches fix this. I think this is release-critical. Ian Jackson (3): docs/parse-support-md: Rename RealSect to

[Xen-devel] [PATCH 3/3] docs/parse-support-md: Correctly process caveats in multi-status sections

2018-05-15 Thread Ian Jackson
When SUPPORT.md uses the syntax Status, : the caveats were lost (not footnoted) because they were attached only to . Caveats occur in running text, so they are necessarily part of a real section, not an individual status line like that. So attach them to the RealSectNode, and look there for

[Xen-devel] [PATCH 1/3] docs/parse-support-md: Rename RealSect to RealInSect

2018-05-15 Thread Ian Jackson
This makes the distinction between insections and sectnodes clearer. No functional change. Signed-off-by: Ian Jackson --- docs/parse-support-md | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git

Re: [Xen-devel] [PATCH 3/4] tools: xencall, xengnttab, xengntshr: Provide access to internal fds

2018-05-15 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH 3/4] tools: xencall, xengnttab, xengntshr: Provide access to internal fds"): > These are ABI breakages. Thanks for the review and sorry to miss that. You are right. I have another question, RFC: I have a test C program which links against Xen

Re: [Xen-devel] [PATCH 2/4] libxc: Provide access to internal handles

2018-05-15 Thread Roger Pau Monné
On Mon, May 14, 2018 at 06:08:57PM +0100, Ian Jackson wrote: > In order to support auditing of qemu depriv, my audit tool wants to > know the fd of a privcmd handle on which it can easily make > hypercalls. xencall provides such a handle, but has no cooked > facilities for making hypercalls. So

[Xen-devel] [xen-4.10-testing test] 122725: trouble: blocked/broken/fail/pass

2018-05-15 Thread osstest service owner
flight 122725 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/122725/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit2 broken build-arm64-xsm

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread George Dunlap
> On May 15, 2018, at 11:05 AM, Roger Pau Monne wrote: > > Just some replies/questions to some of the points raised below. > > On Fri, May 11, 2018 at 09:33:10AM -0700, Dan Williams wrote: >> [ adding linux-nvdimm ] >> >> Great write up! Some comments below... >> >> On

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread George Dunlap
On 05/11/2018 05:33 PM, Dan Williams wrote: > [ adding linux-nvdimm ] > > Great write up! Some comments below... Thanks for the quick response! It seems I still have some fundamental misconceptions about what's going on, so I'd better start with that. :-) Here's the part that I'm having a hard

Re: [Xen-devel] [PATCH for-4.11 0/3] Support matrix: add missing caveat footnotes

2018-05-15 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH for-4.11 0/3] Support matrix: add missing caveat footnotes"): > For the series: > Release-acked-by: Juergen Gross Thanks. FYI, example output is here: https://xenbits.xen.org/people/iwj/2018/support-matrix-example-E/t.html For my notes, I

Re: [Xen-devel] [PATCH] tools/ocaml/libs/xc fix gcc-8 format-truncation warning

2018-05-15 Thread Wei Liu
CC Juergen, I think this should be in 4.11 On Tue, May 15, 2018 at 11:48:43AM +1000, John Thomson wrote: > CC xenctrl_stubs.o > xenctrl_stubs.c: In function 'failwith_xc': > xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before the > last format character

[Xen-devel] [PATCH v2 3/3] vpci/msi: fix update of bound MSI interrupts

2018-05-15 Thread Roger Pau Monne
Current update process of already bound MSI interrupts is wrong because unmap_domain_pirq calls pci_disable_msi, which disables MSI interrupts on the device. On the other hand map_domain_pirq doesn't enable MSI, so the current update process of already enabled MSI entries is wrong because MSI

[Xen-devel] [PATCH v2 1/3] vpci/msi: fix unbind loop

2018-05-15 Thread Roger Pau Monne
The current unbind loop on failure in vpci_msi_enable is wrong and will only work correctly if the initial pirq is 0. Fix this by adding a proper bound. Reported-by: Jan Beulich Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc:

[Xen-devel] [PATCH v2 2/3] vpci/msi: split code to bind pirq

2018-05-15 Thread Roger Pau Monne
And put it in a separate update function. This is required in order to improve binding of MSI PIRQs when using vPCI. No functional change. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper ---

Re: [Xen-devel] [PATCH v2 1/3] xen-hvm: create separate function for ioreq server initialization

2018-05-15 Thread Anthony PERARD
On Thu, May 10, 2018 at 10:15:16AM +0100, Paul Durrant wrote: > The code is sufficiently substantial that it improves code readability > to put it in a new function called by xen_hvm_init() rather than having > it inline. > > Signed-off-by: Paul Durrant Reviewed-by:

Re: [Xen-devel] [PATCH for-4.11 0/3] Support matrix: add missing caveat footnotes

2018-05-15 Thread Juergen Gross
On 15/05/18 16:49, Ian Jackson wrote: > From: Ian Jackson > > Lars spotted that the support matrix > https://xenbits.xen.org/docs/unstable/support-matrix.html > is missing some footnotes. These three patches fix this. I think > this is release-critical. > > Ian

Re: [Xen-devel] [PATCH for-4.11 0/3] Support matrix: add missing caveat footnotes

2018-05-15 Thread Lars Kurth
This seems to address the issue Lars On 15/05/2018, 16:06, "Ian Jackson" wrote: Juergen Gross writes ("Re: [PATCH for-4.11 0/3] Support matrix: add missing caveat footnotes"): > For the series: > Release-acked-by: Juergen Gross

Re: [Xen-devel] [PATCH] tools/ocaml/libs/xc fix gcc-8 format-truncation warning

2018-05-15 Thread Juergen Gross
On 15/05/18 15:19, Wei Liu wrote: > CC Juergen, I think this should be in 4.11 > > On Tue, May 15, 2018 at 11:48:43AM +1000, John Thomson wrote: >> CC xenctrl_stubs.o >> xenctrl_stubs.c: In function 'failwith_xc': >> xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before

Re: [Xen-devel] [PATCH 4/4] libxl: Provide better error message when qemu restrict user not found

2018-05-15 Thread Roger Pau Monné
On Mon, May 14, 2018 at 06:08:59PM +0100, Ian Jackson wrote: > Add mention of LIBXL_QEMU_USER_RANGE_BASE, in case that is what the > user was intending. > > Signed-off-by: Ian Jackson Reviewed-by: Roger Pau Monné Thanks.

Re: [Xen-devel] [PATCH] tools/ocaml/libs/xc fix gcc-8 format-truncation warning

2018-05-15 Thread Christian Lindig
> On 15 May 2018, at 02:48, John Thomson > wrote: > > CC xenctrl_stubs.o > xenctrl_stubs.c: In function 'failwith_xc': > xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before the > last format character [-Werror=format-truncation=] >

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread Roger Pau Monné
Just some replies/questions to some of the points raised below. On Fri, May 11, 2018 at 09:33:10AM -0700, Dan Williams wrote: > [ adding linux-nvdimm ] > > Great write up! Some comments below... > > On Wed, May 9, 2018 at 10:35 AM, George Dunlap > wrote: > >> To use

[Xen-devel] [PATCH v4 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-05-15 Thread Mirela Simonovic
In existing code the virtual paging for non-boot CPUs is setup only on boot. The setup is triggered from start_xen() after all CPUs are brought online. In other words, the initialization of VTCR_EL2 register is done out of the cpu_up/start_secondary() control flow. However, the cpu_up flow is also

[Xen-devel] [PATCH v4 04/10] xen/arm: Remove __initdata and __init to enable CPU hotplug

2018-05-15 Thread Mirela Simonovic
CPU up flow is currently used during the initial boot to start secondary CPUs. However, the same flow should be used for CPU hotplug, e.g. when hotplugging secondary CPUs within the resume procedure (resume from the suspend to RAM). Therefore, prefixes __initdata and __init had to be removed from

[Xen-devel] [PATCH v4 10/10] xen/arm: Enable errata for secondary CPU on hotplug after the boot

2018-05-15 Thread Mirela Simonovic
On boot, enabling errata workarounds will be triggered by the boot CPU from start_xen(). On CPU hotplug (non-boot scenario) this would not be done. This patch adds the code required to enable errata workarounds for a CPU being hotplugged after the system boots. This is triggered using a notifier.

Re: [Xen-devel] [PATCH v3 10/10] xen/arm: Enable errata for secondary CPU on hotplug after the boot

2018-05-15 Thread Mirela Simonovic
Hi Stefano, On Mon, May 14, 2018 at 6:59 PM, Stefano Stabellini wrote: > On Mon, 14 May 2018, Julien Grall wrote: >> On 11/05/18 22:47, Stefano Stabellini wrote: >> > On Fri, 11 May 2018, Dario Faggioli wrote: >> > > On Fri, 2018-05-11 at 14:08 +0100, Julien Grall wrote:

[Xen-devel] [PATCH v4 08/10] xen/arm: Disable timers and release their interrupts on CPU hot-unplug

2018-05-15 Thread Mirela Simonovic
When a CPU is hot-unplugged we need to disable timers and release their interrupts in order to free the memory that was allocated when interrupts were requested (using request_irq()). The request_irq() is called for each timer interrupt when the CPU gets hotplugged

[Xen-devel] [PATCH v4 06/10] xen/common: Restore IRQ affinity when hotplugging a pCPU

2018-05-15 Thread Mirela Simonovic
Non-boot pCPUs are being hot-unplugged during the system suspend to RAM and hotplugged during the resume. When non-boot pCPUs are hot-unplugged the interrupts that were targeted to them are migrated to the boot pCPU. On suspend, each guest could have its own wake-up devices/interrupts

[Xen-devel] [PATCH v4 01/10] xen/arm64: Added handling of the trapped access to OSLSR register

2018-05-15 Thread Mirela Simonovic
Linux/dom0 accesses OSLSR register when saving CPU context during the suspend procedure. Xen traps access to this register, but has no handling for it. Consequently, Xen injects undef exception to linux, causing it to crash. This patch adds handling of the trapped access to OSLSR as ro/raz.

Re: [Xen-devel] [PATCH 3/5] hvm/mtrr: copy hardware state for Dom0

2018-05-15 Thread Roger Pau Monné
On Tue, May 15, 2018 at 02:48:16AM -0600, Jan Beulich wrote: > >>> On 15.05.18 at 10:35, wrote: > > On Tue, May 15, 2018 at 01:52:43AM -0600, Jan Beulich wrote: > >> >>> On 14.05.18 at 18:33, wrote: > >> > On Mon, May 14, 2018 at 08:26:30AM -0600, Jan

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread George Dunlap
> On May 15, 2018, at 1:26 PM, Jan Beulich wrote: > On 15.05.18 at 12:12, wrote: >>> On May 15, 2018, at 11:05 AM, Roger Pau Monne wrote: >>> On Fri, May 11, 2018 at 09:33:10AM -0700, Dan Williams wrote: [ adding

Re: [Xen-devel] [PATCH][next] drm/xen-front: fix spelling mistake: "conector" -> "connector"

2018-05-15 Thread Oleksandr Andrushchenko
On 05/15/2018 11:54 AM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in DRM_INFO message. Signed-off-by: Colin Ian King Thank you, Reviewed-by: Oleksandr Andrushchenko Will

[Xen-devel] [linux-4.14 test] 122727: regressions - trouble: blocked/broken/fail/pass

2018-05-15 Thread osstest service owner
flight 122727 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/122727/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken test-arm64-arm64-examine 5

[Xen-devel] [PATCH v4 02/10] xen/arm: Ignore write to GICD_ISACTIVERn registers (vgic-v2)

2018-05-15 Thread Mirela Simonovic
Guests attempt to write into these registers on resume (for example Linux). Without this patch a data abort exception will be raised to the guest. This patch handles the write access by ignoring it, but only if the value to be written is zero. This should be fine because reading these registers is

[Xen-devel] [PATCH v4 00/10] xen/arm64: Suspend preconditions and CPU hotplug fixes

2018-05-15 Thread Mirela Simonovic
This patch set contains fixes that are required as precondition for suspend to RAM support, including the CPU hotplug which is required to suspend non-boot CPUs. The first two patches in this series: 1) xen/arm64: Added handling of the trapped access to OSLSR register 2) xen/arm: Ignore write to

[Xen-devel] [PATCH v4 09/10] xen/arm: Free memory allocated for sibling/core maps on CPU hot-unplug

2018-05-15 Thread Mirela Simonovic
The memory allocated in setup_cpu_sibling_map() when a CPU is hotplugged has to be freed when the CPU is hot-unplugged. This is done in remove_cpu_sibling_map() and called when the CPU dies. The call to remove_cpu_sibling_map() is made from a notifier callback when CPU_DEAD event is received.

[Xen-devel] [PATCH v4 03/10] xen/arm: Implement CPU_OFF PSCI call (physical interface)

2018-05-15 Thread Mirela Simonovic
During the system suspend to RAM non-boot CPUs will be hotplugged. This will be triggered via disable_nonboot_cpus() call. When hotplugged the CPU will end up in an infinite wfi loop in stop_cpu(). This patch adds PSCI CPU_OFF call to the EL3 with the aim to get powered down the calling CPU during

[Xen-devel] [PATCH v4 07/10] xen/arm: Release maintenance interrupt when CPU is hot-unplugged

2018-05-15 Thread Mirela Simonovic
When a CPU is hot-unplugged the maintenance interrupt has to be released in order to free the memory that was allocated when the CPU was hotplugged and interrupt requested. The interrupt was requested using request_irq() which is called from start_secondary-> init_maintenance_interrupt. With this

[Xen-devel] [distros-debian-snapshot test] 74718: tolerable FAIL

2018-05-15 Thread Platform Team regression test user
flight 74718 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74718/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-i386-daily-netboot-pvgrub 11 guest-start fail blocked in 74691

Re: [Xen-devel] [PATCH v1 for 4.7] x86/cpuid: fix raw FEATURESET_7d0 reporting

2018-05-15 Thread Jan Beulich
>>> On 15.05.18 at 10:37, wrote: > Commit 62b1879693e0 ("x86: further CPUID handling adjustments") added > FEATURESET_7d0 reporting but forgot to update calculate_raw_featureset() > function. As result, the value reported by xen-cpuid contains 0. > > Fix that by

Re: [Xen-devel] [PATCH 3/5] hvm/mtrr: copy hardware state for Dom0

2018-05-15 Thread Jan Beulich
>>> On 15.05.18 at 11:16, wrote: > On Tue, May 15, 2018 at 02:48:16AM -0600, Jan Beulich wrote: >> >>> On 15.05.18 at 10:35, wrote: >> > On Tue, May 15, 2018 at 01:52:43AM -0600, Jan Beulich wrote: >> >> >>> On 14.05.18 at 18:33,

Re: [Xen-devel] [PATCH 4/5] libxc/pvh: set default MTRR type to write-back

2018-05-15 Thread Jan Beulich
>>> On 15.05.18 at 13:43, wrote: > On Thu, May 10, 2018 at 06:15:04PM +0100, Roger Pau Monne wrote: >> @@ -1014,6 +1034,30 @@ static int vcpu_hvm(struct xc_dom_image *dom) >> if ( dom->start_info_seg.pfn ) >> bsp_ctx.cpu.rbx = dom->start_info_seg.pfn <<

Re: [Xen-devel] [PATCH 4/5] libxc/pvh: set default MTRR type to write-back

2018-05-15 Thread Wei Liu
On Thu, May 10, 2018 at 06:15:04PM +0100, Roger Pau Monne wrote: > And enable MTRR. This allows to provide a sane initial MTRR state for > PVH DomUs. This will have to be expanded when pci-passthrough support > is added to PVH guests, so that MMIO regions of devices are set as > UC. > > Note that

Re: [Xen-devel] 4.11.0 RC1 panic

2018-05-15 Thread Jan Beulich
>>> On 01.05.18 at 22:22, wrote: > On Mon, Apr 30, 2018 at 07:31:28AM -0600, Jan Beulich wrote: >> >>> On 25.04.18 at 16:42, wrote: >> > On Wed, Apr 25, 2018 at 12:42:42PM +0200, Manuel Bouyer wrote: >> >> > Without line numbers associated with at

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread Jan Beulich
>>> On 15.05.18 at 12:12, wrote: >> On May 15, 2018, at 11:05 AM, Roger Pau Monne wrote: >> On Fri, May 11, 2018 at 09:33:10AM -0700, Dan Williams wrote: >>> [ adding linux-nvdimm ] >>> >>> Great write up! Some comments below... >>> >>> On Wed,

Re: [Xen-devel] [PATCH v2 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-15 Thread Anthony PERARD
On Tue, May 15, 2018 at 04:45:25PM +0100, Paul Durrant wrote: > > > diff --git a/include/hw/xen/xen_common.h > > b/include/hw/xen/xen_common.h > > > index 5f1402b494..d925751040 100644 > > > --- a/include/hw/xen/xen_common.h > > > +++ b/include/hw/xen/xen_common.h > > > @@ -119,6 +119,20 @@ static

[Xen-devel] [PATCH] scripts/add_maintainers.pl: New script

2018-05-15 Thread Ian Jackson
From: Lars Kurth This provides a much better workflow when using git format-patch and git send-email, with get_maintainer.pl. The tool covers step 2 of the following workflow Step 1: git format-patch ... -o ... Step 2: ./scripts/add_maintainers.pl -d This

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread Dan Williams
On Tue, May 15, 2018 at 5:26 AM, Jan Beulich wrote: On 15.05.18 at 12:12, wrote: [..] >> That is, each fsdax / devdax namespace has a superblock that, in part, >> defines what parts are used for Linux and what parts are used for data. Or >> to

[Xen-devel] [PATCH RFC] Supporting more than 4 emulated NICs

2018-05-15 Thread Charles Arnold
Some time ago this bug was written up, https://bugs.xenproject.org/xen/bug/46 "qemu-upstream: limitation on 4 emulated NICs prevents guest from starting unless PV override is used." While there were some proposed patches and discussion in the bug and on the mailing list back in 2014/2015 to

Re: [Xen-devel] [PATCH for-4.11 v4 1/1] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-15 Thread Ian Jackson
Lars Kurth writes ("[PATCH for-4.11 v4 1/1] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl"): > The tool covers step 2 of the following workflow Thanks. Sorry to spot this only now, but > +sub writefile ($$) { > +my ($content,

Re: [Xen-devel] [PATCH v1 for 4.7] x86/cpuid: fix raw FEATURESET_7d0 reporting

2018-05-15 Thread Andrew Cooper
On 15/05/18 10:04, Jan Beulich wrote: On 15.05.18 at 10:37, wrote: >> Commit 62b1879693e0 ("x86: further CPUID handling adjustments") added >> FEATURESET_7d0 reporting but forgot to update calculate_raw_featureset() >> function. As result, the value reported by

Re: [Xen-devel] [Qemu-devel] [PATCH v2 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-15 Thread Eric Blake
On 05/15/2018 11:16 AM, Anthony PERARD wrote: +errno = EOPNOTSUPP; I think ENOSYS would be better. EOPNOTSUPP seems to be for sockets. No, EOPNOTSUPP is more general than that and is convention for unimplemented API operations elsewhere. ENOSYS is supposed to strictly mean 'system

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread Dan Williams
On Tue, May 15, 2018 at 7:19 AM, George Dunlap wrote: > On 05/11/2018 05:33 PM, Dan Williams wrote: >> [ adding linux-nvdimm ] >> >> Great write up! Some comments below... > > Thanks for the quick response! > > It seems I still have some fundamental misconceptions about

Re: [Xen-devel] [PATCH v2 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-15 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 15 May 2018 17:17 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; xen-devel@lists.xenproject.org; Stefano > Stabellini > Subject: Re: [PATCH v2 3/3]

[Xen-devel] [PATCH v3 1/3] xen-hvm: create separate function for ioreq server initialization

2018-05-15 Thread Paul Durrant
The code is sufficiently substantial that it improves code readability to put it in a new function called by xen_hvm_init() rather than having it inline. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini

[Xen-devel] [PATCH v3 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-15 Thread Paul Durrant
Xen 4.11 has a new API to directly map guest resources. Among the resources that can be mapped using this API are ioreq pages. This patch modifies QEMU to attempt to use the new API should it exist, falling back to the previous mechanism if it is unavailable. Signed-off-by: Paul Durrant

[Xen-devel] [PATCH v3 0/3] xen-hvm: use new resource mapping API

2018-05-15 Thread Paul Durrant
This series modifies QEMU to use the new guest resource mapping API (available in Xen 4.11+) to map ioreq pages. v2: - Add a patch to checkpatch to avoid misparsing of Xen stable API handles Paul Durrant (3): xen-hvm: create separate function for ioreq server initialization checkpatch:

[Xen-devel] [PATCH v3 2/3] checkpatch: generalize xen handle matching in the list of types

2018-05-15 Thread Paul Durrant
All the xen stable APIs define handle types of the form: xen_handle and some define additional handle types of the form: xen__handle Examples of these are xenforeignmemory_handle and xenforeignmemory_resource_handle. Both of these types will be misparsed by checkpatch if they appear as the

Re: [Xen-devel] [PATCH v5] scripts/add_maintainers.pl: New script

2018-05-15 Thread Lars Kurth
Acked-by: Lars Kurth Although it should probably mention --get-maintainers in the help message Lars On 15/05/2018, 18:12, "Ian Jackson" wrote: (Fixed the Subject line.) Ian Jackson writes ("[PATCH] scripts/add_maintainers.pl: New

[Xen-devel] [xen-unstable-smoke test] 122848: tolerable all pass - PUSHED

2018-05-15 Thread osstest service owner
flight 122848 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122848/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [PATCH for-4.7/4.8] x86: Fix "x86: further CPUID handling adjustments"

2018-05-15 Thread Andrew Cooper
c/s f9616884e (a backport of c/s 0d703a701 "x86/feature: Definitions for Indirect Branch Controls") missed a CPUID adjustment when calculating the raw featureset. This impacts host administrator diagnostics. Signed-off-by: Sergey Dyasli c/s 62b187969 "x86: further

Re: [Xen-devel] [PATCH for-4.11 0/3] Support matrix: add missing caveat footnotes

2018-05-15 Thread Lars Kurth
On 15/05/2018, 16:23, "Lars Kurth" wrote: This seems to address the issue Lars On 15/05/2018, 16:06, "Ian Jackson" wrote: Juergen Gross writes ("Re: [PATCH for-4.11 0/3] Support matrix: add missing caveat

Re: [Xen-devel] [PATCH v2 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-15 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 15 May 2018 16:38 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; xen-devel@lists.xenproject.org; Stefano > Stabellini > Subject: Re: [PATCH v2 3/3]

Re: [Xen-devel] [PATCH v5] scripts/add_maintainers.pl: New script

2018-05-15 Thread Ian Jackson
(Fixed the Subject line.) Ian Jackson writes ("[PATCH] scripts/add_maintainers.pl: New script"): > Changes since v4: > - Strip some trailing whitespace from the code > - writefile() now uses the .tmp-and-rename pattern to avoid data loss > - Provide --get-maintainers= option to specify

[Xen-devel] [qemu-mainline test] 122734: trouble: broken/fail/pass

2018-05-15 Thread osstest service owner
flight 122734 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/122734/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm broken

[Xen-devel] [PATCH for-next 5/5] tools: provide --with-system-ipxe

2018-05-15 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Ian Jackson --- config/Tools.mk.in| 1 + tools/config.h.in | 3 +++ tools/configure | 53 +++ tools/configure.ac| 18

[Xen-devel] [PATCH for-next 0/5] Load ipxe from a standalone file

2018-05-15 Thread Wei Liu
Seeing yet another bug report regarding ipxe today, I would rather have this done than having to continuously cherry-pick ipxe commits. I have written these patches from scratch to my liking. Only very light testing is done. I will do a bit more testing when I have time. Cc: Jan Beulich

[Xen-devel] [PATCH for-next 4/5] tools: load IPXE from standalone file

2018-05-15 Thread Wei Liu
Do not embed IPXE into Rombios anymore. Instead, it is loaded by the toolstack from a file as a separate module. Ability to let user specify an IPXE blob will come later. No user visible change. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Jan

[Xen-devel] [PATCH for-next 2/5] ipxe: produce a single binary from its build

2018-05-15 Thread Wei Liu
And switch hvmloader/Makefile to use that binary. This will help later when we change hvmloader to pick a user provided binary. No functional change. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper ---

[Xen-devel] [PATCH for-next 3/5] libxc: allow HVM guest to have modules

2018-05-15 Thread Wei Liu
Lift the loading code out of PVH specific branch. Take the chance to make the debug message more useful. IPXE will be loaded as a module of Rombios. Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/libxc/xc_dom_x86.c | 32

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread Andrew Cooper
On 15/05/18 19:06, Dan Williams wrote: > On Tue, May 15, 2018 at 7:19 AM, George Dunlap > wrote: >> On 05/11/2018 05:33 PM, Dan Williams wrote: >> >> This is all pretty foundational. Xen can read static ACPI tables, but >> it can't do AML. So to do a proper design for

Re: [Xen-devel] [PATCH for-4.11 00/10] x86: Improvements and fixes to Spectre handling

2018-05-15 Thread Juergen Gross
On 11/05/18 12:38, Andrew Cooper wrote: > In hindsight, the end result of the Spectre mitigations aren't as great as I'd > hoped, and have several inefficiencies. Also, the `bti=` command line option > isn't as flexible as intended. > > This series does four things: > > 1) Some internal

Re: [Xen-devel] [PATCH 06/10] x86/spec_ctrl: Split X86_FEATURE_SC_MSR into PV and HVM variants

2018-05-15 Thread Andrew Cooper
On 14/05/18 16:27, Jan Beulich wrote: On 11.05.18 at 12:38, wrote: >> --- a/xen/arch/x86/spec_ctrl.c >> +++ b/xen/arch/x86/spec_ctrl.c >> @@ -128,7 +128,8 @@ static void __init print_details(enum ind_thunk thunk, >> uint64_t caps) >> thunk ==

[Xen-devel] [linux-linus test] 122743: regressions - trouble: blocked/broken/fail/pass

2018-05-15 Thread osstest service owner
flight 122743 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/122743/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-xsm broken build-armhf-xsm 4

[Xen-devel] [xen-unstable-smoke test] 122852: tolerable all pass - PUSHED

2018-05-15 Thread osstest service owner
flight 122852 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122852/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [PATCH for-next 1/5] Tools.mk.in: drop unused variables

2018-05-15 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Ian Jackson --- config/Tools.mk.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 2d6c440324..4cc9f29090 100644 --- a/config/Tools.mk.in +++ b/config/Tools.mk.in @@

Re: [Xen-devel] [PATCH] Revert xen: dont fiddle with event channel masking in suspend/resume

2018-05-15 Thread Anchal Agarwal
O Fri, Apr 20, 2018 at 07:43:31AM +0200, Juergen Gross wrote: > On 20/04/18 01:04, Anchal Agarwal wrote: > > > > Hello, > > > > This patch reverts commit e91b2b1194335ca83d8a40fa4e0efd480bf2babe. > > evtchn are supposed to be masked during resume by irq subsytem > > however, they are not. This

Re: [Xen-devel] [PATCH v2 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-15 Thread Anthony PERARD
On Thu, May 10, 2018 at 10:15:18AM +0100, Paul Durrant wrote: > --- a/hw/i386/xen/xen-hvm.c > +++ b/hw/i386/xen/xen-hvm.c > @@ -1239,13 +1239,41 @@ static void xen_wakeup_notifier(Notifier *notifier, > void *data) > > static int xen_map_ioreq_server(XenIOState *state) > { > +void *addr =

Re: [Xen-devel] [PATCH for-4.11 v4 1/1] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

2018-05-15 Thread Lars Kurth
On 15/05/2018, 16:35, "Ian Jackson" wrote: Lars Kurth writes ("[PATCH for-4.11 v4 1/1] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl"): > The tool covers step 2 of the following workflow

[Xen-devel] [PATCH v6] scripts/add_maintainers.pl: New script

2018-05-15 Thread Ian Jackson
From: Lars Kurth This provides a much better workflow when using git format-patch and git send-email, with get_maintainer.pl. The tool covers step 2 of the following workflow Step 1: git format-patch ... -o ... Step 2: ./scripts/add_maintainers.pl -d This

Re: [Xen-devel] [PATCH v5] scripts/add_maintainers.pl: New script

2018-05-15 Thread Ian Jackson
Lars Kurth writes ("Re: [PATCH v5] scripts/add_maintainers.pl: New script"): > Acked-by: Lars Kurth > Although it should probably mention --get-maintainers in the help message Good point. Ian. ___ Xen-devel mailing list

[Xen-devel] Ping: Re: [PATCH] x86: correct vCPU dirty CPU handling

2018-05-15 Thread Jan Beulich
>>> On 26.04.18 at 12:52, wrote: On 26.04.18 at 11:51, wrote: >> On 26/04/18 10:41, Jan Beulich wrote: >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -1202,11 +1202,23 @@ void put_page_from_l1e(l1_pgentry_t l1e, >>>

Re: [Xen-devel] [PATCH 5/5] docs/pvh: document initial MTRR state

2018-05-15 Thread Wei Liu
On Tue, May 15, 2018 at 01:51:03AM -0600, Jan Beulich wrote: > >>> On 14.05.18 at 18:18, wrote: > > On Mon, May 14, 2018 at 10:13:47AM -0600, Jan Beulich wrote: > >> >>> On 14.05.18 at 18:03, wrote: > >> > On Thu, May 10, 2018 at 06:15:05PM +0100, Roger

Re: [Xen-devel] [PATCH 5/5] docs/pvh: document initial MTRR state

2018-05-15 Thread Roger Pau Monné
On Tue, May 15, 2018 at 01:51:03AM -0600, Jan Beulich wrote: > >>> On 14.05.18 at 18:18, wrote: > > On Mon, May 14, 2018 at 10:13:47AM -0600, Jan Beulich wrote: > >> >>> On 14.05.18 at 18:03, wrote: > >> > On Thu, May 10, 2018 at 06:15:05PM +0100, Roger

Re: [Xen-devel] [PATCH 3/5] hvm/mtrr: copy hardware state for Dom0

2018-05-15 Thread Roger Pau Monné
On Tue, May 15, 2018 at 01:52:43AM -0600, Jan Beulich wrote: > >>> On 14.05.18 at 18:33, wrote: > > On Mon, May 14, 2018 at 08:26:30AM -0600, Jan Beulich wrote: > >> >>> On 10.05.18 at 19:15, wrote: > >> > Copy the state found on the hardware when

Re: [Xen-devel] [PATCH 2/4] libxc: Provide access to internal handles

2018-05-15 Thread Wei Liu
On Mon, May 14, 2018 at 06:08:57PM +0100, Ian Jackson wrote: > In order to support auditing of qemu depriv, my audit tool wants to > know the fd of a privcmd handle on which it can easily make > hypercalls. xencall provides such a handle, but has no cooked > facilities for making hypercalls. So

[Xen-devel] [PATCH v1 for 4.7] x86/cpuid: fix raw FEATURESET_7d0 reporting

2018-05-15 Thread Sergey Dyasli
Commit 62b1879693e0 ("x86: further CPUID handling adjustments") added FEATURESET_7d0 reporting but forgot to update calculate_raw_featureset() function. As result, the value reported by xen-cpuid contains 0. Fix that by properly filling raw_featureset[FEATURESET_7d0]. Signed-off-by: Sergey

  1   2   >