Re: [Xen-devel] [PATCH V2 5/6] iommu/arm: Introduce iommu_add_dt_device API

2019-08-13 Thread Oleksandr
On 13.08.19 16:49, Julien Grall wrote: Hi Oleksandr, Hi Julien On 8/2/19 5:39 PM, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This patch adds new iommu_add_dt_device API for adding DT device to the IOMMU using generic IOMMU DT binding [1] and previously added "iommu_fwspec"

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Anthony PERARD
On Tue, Aug 13, 2019 at 04:47:23PM +0100, Andrew Cooper wrote: > Error between user and terminal. :) > > I'd sync'd xl and libxl.so, but not libxlu.so I actually made the same mistake first time I tried. > Ok, so that is working now.  I think 'cmdline+=" dom0=pvh > dom0-iommu=none"' is slightly

Re: [Xen-devel] [PATCH] x86/pv: Clean up cr3 handling in arch_set_info_guest()

2019-08-13 Thread Andrew Cooper
On 24/01/2019 22:10, Andrew Cooper wrote: > On 24/01/2019 21:42, Julien Grall wrote: >> Hi Andrew, >> >> On 12/21/18 1:46 PM, Andrew Cooper wrote: >>> All of this code lives inside CONFIG_PV which means gfn == mfn, and the >>> fill_ro_mpt() calls clearly show that the value is used untranslated.

Re: [Xen-devel] [PATCH v5 4/7] xen/arm: early_print_info print reserved_mem

2019-08-13 Thread Julien Grall
Hi, On 8/13/19 3:28 PM, Volodymyr Babchuk wrote: Stefano Stabellini writes: Improve early_print_info to also print the banks saved in bootinfo.reserved_mem. Print them right after RESVD, increasing the same index. Since we are at it, also switch the existing RESVD print to use unsigned int.

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Andrew Cooper
On 13/08/2019 15:48, Anthony PERARD wrote: > Handle += of both strings and lists. > > If += is used for config options expected to be numbers, then a > warning is printed and the config option ignored (because xl ignores > config options with errors). > > This is to be used for development

Re: [Xen-devel] [PATCH 1/3] xen/sched: populate cpupool0 only after all cpus are up

2019-08-13 Thread Dario Faggioli
On Fri, 2019-08-02 at 15:07 +0200, Juergen Gross wrote: > With core or socket scheduling we need to know the number of siblings > per scheduling unit before we can setup the scheduler properly. In > order to prepare that do cpupool0 population only after all cpus are > up. > > With that in place

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Julien Grall
Hi Dario, On 8/13/19 4:27 PM, Dario Faggioli wrote: On Fri, 2019-08-09 at 11:30 -0700, Stefano Stabellini wrote: On Fri, 9 Aug 2019, Dario Faggioli wrote: Can you help me with this, e.g., by providing some more info and, if possible, logs? I am attaching the logs. Thanks! Interestingly,

[Xen-devel] [linux-linus test] 140038: regressions - FAIL

2019-08-13 Thread osstest service owner
flight 140038 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/140038/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-examine 8 reboot fail REGR. vs. 133580

Re: [Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions

2019-08-13 Thread Julien Grall
Hi, On 8/13/19 4:14 PM, Volodymyr Babchuk wrote: Julien Grall writes: On 8/13/19 3:23 PM, Volodymyr Babchuk wrote: Stefano Stabellini writes: { device_tree_get_reg(, address_cells, size_cells, , ); if ( !size ) continue; -

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Andrew Cooper
On 13/08/2019 16:30, Anthony PERARD wrote: > On Tue, Aug 13, 2019 at 04:06:33PM +0100, Andrew Cooper wrote: >> On 13/08/2019 15:48, Anthony PERARD wrote: >>> Handle += of both strings and lists. >>> >>> If += is used for config options expected to be numbers, then a >>> warning is printed and the

[Xen-devel] [PATCH 2/1] toos/xenstat: Fix -Wunused-function issue

2019-08-13 Thread Andrew Cooper
When compiling xenstat with -Werror, Clang complains: src/xenstat.c:134:34: error: unused function 'parse' [-Werror,-Wunused-function] static inline unsigned long long parse(char *s, char *match) ^ 1 error generated. Drop the function. It really is

Re: [Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions

2019-08-13 Thread Volodymyr Babchuk
Hi Julien, Julien Grall writes: > Hi, > > On 8/13/19 3:23 PM, Volodymyr Babchuk wrote: >> >> Stefano Stabellini writes: >> >>> As we parse the device tree in Xen, keep track of the reserved-memory >>> regions as they need special treatment (follow-up patches will make use >>> of the stored

Re: [Xen-devel] [PATCH V2 4/6] iommu/arm: Add lightweight iommu_fwspec support

2019-08-13 Thread Julien Grall
Hi, On 8/13/19 4:17 PM, Oleksandr wrote: On 13.08.19 15:39, Julien Grall wrote: xfree is able to deal with NULL pointer, so the check is not necessary. Yes, the reason I left this check is to not perform an extra operation (dev_iommu_fwspec_set). Shall I drop this check anyway? I can't

Re: [Xen-devel] [PATCH V2 4/6] iommu/arm: Add lightweight iommu_fwspec support

2019-08-13 Thread Oleksandr
On 13.08.19 16:40, Julien Grall wrote: Hi Oleksandr, Hi Julien. One more comment :). On 8/2/19 5:39 PM, Oleksandr Tyshchenko wrote: +int iommu_fwspec_init(struct device *dev, struct device *iommu_dev) +{ +    struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); + +    if ( fwspec )

Re: [Xen-devel] [PATCH v5 1/7] xen/arm: pass node to device_tree_for_each_node

2019-08-13 Thread Julien Grall
Hi, On 8/12/19 11:28 PM, Stefano Stabellini wrote: Add a new parameter to device_tree_for_each_node: node, the node to start the search from. Passing 0 triggers the old behavior. Set min_depth to depth of the current node + 1 and replace the for loop with a do/while loop to avoid scanning

Re: [Xen-devel] [PATCH 0/3] xen/sched: use new idle scheduler for free cpus

2019-08-13 Thread Dario Faggioli
On Fri, 2019-08-02 at 15:07 +0200, Juergen Gross wrote: > These three patches have been carved out from my core scheduling > series > as they are sufficiently independent to be applied even without the > big > series. > > Without this little series there are messages like the following to > be >

Re: [Xen-devel] [PATCH V2 4/6] iommu/arm: Add lightweight iommu_fwspec support

2019-08-13 Thread Oleksandr
On 13.08.19 18:28, Julien Grall wrote: Hi, Hi Julien On 8/13/19 4:17 PM, Oleksandr wrote: On 13.08.19 15:39, Julien Grall wrote: xfree is able to deal with NULL pointer, so the check is not necessary. Yes, the reason I left this check is to not perform an extra operation

[Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Anthony PERARD
Handle += of both strings and lists. If += is used for config options expected to be numbers, then a warning is printed and the config option ignored (because xl ignores config options with errors). This is to be used for development purposes, where modifying config option can be done on the `xl

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Dario Faggioli
On Fri, 2019-08-09 at 11:30 -0700, Stefano Stabellini wrote: > On Fri, 9 Aug 2019, Dario Faggioli wrote: > > Can you help me with this, e.g., by providing some more info and, > > if > > possible, logs? > > I am attaching the logs. > Thanks! > Interestingly, I get a bunch of: > > (XEN) ***

Re: [Xen-devel] [PATCH V2 5/6] iommu/arm: Introduce iommu_add_dt_device API

2019-08-13 Thread Julien Grall
Hi, On 8/13/19 5:05 PM, Oleksandr wrote: On 13.08.19 16:49, Julien Grall wrote: On 8/2/19 5:39 PM, Oleksandr Tyshchenko wrote: Hmm, I was thinking how to end up with only one callback re-used (add_device), really didn't want to add a new one (of_xlate). But, I didn't take into the account

[Xen-devel] [linux-4.4 test] 140040: regressions - FAIL

2019-08-13 Thread osstest service owner
flight 140040 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140040/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail REGR. vs. 139698 Tests which did not

[Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in dtb_load()

2019-08-13 Thread Julien Grall
dtb_load() can be called by other domain than dom0. To avoid confusion in the log, print the correct domain. Signed-off-by: Julien Grall --- xen/arch/arm/domain_build.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c

Re: [Xen-devel] [RFC] Code of Conduct

2019-08-13 Thread Lars Kurth
Perfect: I updated this also in the google doc. I will leave the review open for a week or two (we do have summer holidays after all) and let people comment. I can then send a proper proposal, followed by a vote Lars On 12/08/2019, 15:35, "George Dunlap" wrote: On 8/12/19 3:27 PM, Lars

Re: [Xen-devel] [PATCH V2 4/6] iommu/arm: Add lightweight iommu_fwspec support

2019-08-13 Thread Oleksandr
On 13.08.19 15:39, Julien Grall wrote: Hi Oleksandr, Hi Julien. On 8/2/19 5:39 PM, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko We need to have some abstract way to add new device to the IOMMU based on the generic IOMMU DT binding [1] which can be used for both DT (right now)

Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

2019-08-13 Thread Anthony PERARD
On Tue, Aug 13, 2019 at 04:06:33PM +0100, Andrew Cooper wrote: > On 13/08/2019 15:48, Anthony PERARD wrote: > > Handle += of both strings and lists. > > > > If += is used for config options expected to be numbers, then a > > warning is printed and the config option ignored (because xl ignores > >

Re: [Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions

2019-08-13 Thread Volodymyr Babchuk
Julien Grall writes: > Hi, > > On 8/13/19 4:14 PM, Volodymyr Babchuk wrote: >> Julien Grall writes: >>> On 8/13/19 3:23 PM, Volodymyr Babchuk wrote: Stefano Stabellini writes: >{ >device_tree_get_reg(, address_cells, size_cells, , > ); >

[Xen-devel] [ovmf test] 140047: all pass - PUSHED

2019-08-13 Thread osstest service owner
flight 140047 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/140047/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ecc32c90ee4ad557205cb2725619a3cc2f45ebd0 baseline version: ovmf

Re: [Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions

2019-08-13 Thread Volodymyr Babchuk
Stefano Stabellini writes: > As we parse the device tree in Xen, keep track of the reserved-memory > regions as they need special treatment (follow-up patches will make use > of the stored information.) > > Reuse process_memory_node to add reserved-memory regions to the > bootinfo.reserved_mem

Re: [Xen-devel] [PATCH v5 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-13 Thread Volodymyr Babchuk
Stefano Stabellini writes: > Don't allow reserved-memory regions to be remapped into any unprivileged > guests, until reserved-memory regions are properly supported in Xen. For > now, do not call iomem_permit_access on them, because giving > iomem_permit_access to dom0 means that the toolstack

Re: [Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions

2019-08-13 Thread Julien Grall
Hi, On 8/13/19 3:23 PM, Volodymyr Babchuk wrote: Stefano Stabellini writes: As we parse the device tree in Xen, keep track of the reserved-memory regions as they need special treatment (follow-up patches will make use of the stored information.) Reuse process_memory_node to add

Re: [Xen-devel] [PATCH v5 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-13 Thread Julien Grall
Hi, On 8/13/19 3:34 PM, Volodymyr Babchuk wrote: Stefano Stabellini writes: Don't allow reserved-memory regions to be remapped into any unprivileged guests, until reserved-memory regions are properly supported in Xen. For now, do not call iomem_permit_access on them, because giving

Re: [Xen-devel] [PATCH 2/3] xen/sched: remove cpu from pool0 before removing it

2019-08-13 Thread Dario Faggioli
On Fri, 2019-08-02 at 15:07 +0200, Juergen Gross wrote: > Today a cpu which is removed from the system is taken directly from > Pool0 to the offline state. This will conflict with the new idle > scheduler, so remove it from Pool0 first. Additionally accept > removing > a free cpu instead of

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Dario Faggioli
On Tue, 2019-08-13 at 17:52 +0100, Julien Grall wrote: > Hi Dario, > Hello! > On 8/13/19 4:27 PM, Dario Faggioli wrote: > > On Fri, 2019-08-09 at 11:30 -0700, Stefano Stabellini wrote: > > > > > In my (x86 and "dom0full") testbox, this seems to come from > >

Re: [Xen-devel] Terminology for "guest" - Was: [PATCH] docs/sphinx: Introduction

2019-08-13 Thread Sarah Newman
On 8/13/19 1:43 AM, George Dunlap wrote: On Aug 13, 2019, at 3:59 AM, Sarah Newman wrote: On 8/12/19 8:01 AM, Andrew Cooper wrote: On 12/08/2019 15:53, George Dunlap wrote: On 8/8/19 10:13 AM, Julien Grall wrote: Hi Jan, On 08/08/2019 10:04, Jan Beulich wrote: On 08.08.2019 10:43,

Re: [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile

2019-08-13 Thread Andrew Cooper
On 13/08/2019 22:02, YOUNG, MICHAEL A. wrote: > I have been looking at the pygrub code to see if it is possible to cope > with grub files with BLSCFG and spotted this minor issue in GrubConf.py > where the code intends to replace ${saved_entry} and ${next_entry} with 0 > but doesn't succeed. >

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-13 Thread Roman Shaposhnik
Hi Roger, sorry for the delay -- I hope you will understand that I actually had a good reason. See below: On Mon, Aug 12, 2019 at 1:57 AM Roger Pau Monné wrote: > > Ping? > > I know I've posted this quite recently, but have you been able to test > the two proposed patches? > > ie: the one here

[Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile

2019-08-13 Thread YOUNG, MICHAEL A.
I have been looking at the pygrub code to see if it is possible to cope with grub files with BLSCFG and spotted this minor issue in GrubConf.py where the code intends to replace ${saved_entry} and ${next_entry} with 0 but doesn't succeed. Signed-off-by: Michael Young From

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Julien Grall
On 8/13/19 6:34 PM, Dario Faggioli wrote: On Tue, 2019-08-13 at 17:52 +0100, Julien Grall wrote: Hi Dario, Hello! On 8/13/19 4:27 PM, Dario Faggioli wrote: On Fri, 2019-08-09 at 11:30 -0700, Stefano Stabellini wrote: In my (x86 and "dom0full") testbox, this seems to come from

Re: [Xen-devel] [PATCH 1/2] xen: Drop XEN_DOMCTL_suppress_spurious_page_faults

2019-08-13 Thread Marek Marczykowski-Górecki
On Tue, Aug 13, 2019 at 11:53:51AM +0100, Andrew Cooper wrote: > This functionality is obsolete. It was introduced by c/s 39407bed9c0 into > Xend, but never exposed in libxl. > > While not explicitly limited to PV guests, this is PV-only by virtue of its > position in the pagefault handler. > >

Re: [Xen-devel] [PATCH 2/2] xen: Drop XEN_DOMCTL_{get, set}_machine_address_size

2019-08-13 Thread Marek Marczykowski-Górecki
On Tue, Aug 13, 2019 at 11:53:52AM +0100, Andrew Cooper wrote: > This functionality is obsolete. It was introduced by c/s 41296317a31 into > Xend, but was never exposed in libxl. > > Nothing limits this to PV guests, but it makes no sense for HVM guests. > > Looking through the XenServer

[Xen-devel] [xen-unstable-smoke test] 140071: tolerable all pass - PUSHED

2019-08-13 Thread osstest service owner
flight 140071 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/140071/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] Xen-unstable staging build broken by pvshim patches.

2019-08-13 Thread Andrew Cooper
On 13/08/2019 22:03, Sander Eikelenboom wrote: > On 13/08/2019 15:31, Andrew Cooper wrote: >> On 13/08/2019 12:51, Sander Eikelenboom wrote: >>> On 13/08/2019 13:21, Andrew Cooper wrote: On 09/08/2019 00:28, Sander Eikelenboom wrote: > On 09/08/2019 00:44, Andrew Cooper wrote: >> On

Re: [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile

2019-08-13 Thread YOUNG, MICHAEL A.
On Tue, 13 Aug 2019, Andrew Cooper wrote: > On 13/08/2019 22:02, YOUNG, MICHAEL A. wrote: >> I have been looking at the pygrub code to see if it is possible to cope >> with grub files with BLSCFG and spotted this minor issue in GrubConf.py >> where the code intends to replace ${saved_entry} and

Re: [Xen-devel] Xen-unstable staging build broken by pvshim patches.

2019-08-13 Thread Sander Eikelenboom
On 13/08/2019 15:31, Andrew Cooper wrote: > On 13/08/2019 12:51, Sander Eikelenboom wrote: >> On 13/08/2019 13:21, Andrew Cooper wrote: >>> On 09/08/2019 00:28, Sander Eikelenboom wrote: On 09/08/2019 00:44, Andrew Cooper wrote: > On 08/08/2019 23:34, Sander Eikelenboom wrote: >> On

[Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example

2019-08-13 Thread Julien Grall
The binding for the dom0less module does not match Xen implementation. Any module should contain the compatible "multiboot,module" to be recognized. This was clearly an oversight as other examples with Xen code base provide the compatible "multiboot,module". So fix the binding and the example

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Stefano Stabellini
On Tue, 13 Aug 2019, Dario Faggioli wrote: > On Fri, 2019-08-09 at 11:30 -0700, Stefano Stabellini wrote: > > On Fri, 9 Aug 2019, Dario Faggioli wrote: > > > Can you help me with this, e.g., by providing some more info and, > > > if > > > possible, logs? > > > > I am attaching the logs. > > >

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Julien Grall
Hi, On 8/13/19 7:43 PM, Julien Grall wrote: > > > On 8/13/19 6:34 PM, Dario Faggioli wrote: >> On Tue, 2019-08-13 at 17:52 +0100, Julien Grall wrote: >>> Hi Dario, >>> >> Hello! >> >>> On 8/13/19 4:27 PM, Dario Faggioli wrote: On Fri, 2019-08-09 at 11:30 -0700, Stefano Stabellini wrote:

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Dario Faggioli
On Tue, 2019-08-13 at 14:14 -0700, Stefano Stabellini wrote: > On Tue, 13 Aug 2019, Dario Faggioli wrote: > > > > I am attaching an updated debug patch, with an additional printk > > when > > we reach the point, within the null scheduler, when the vcpu would > > wake > > up (to check whether the

[Xen-devel] [xen-unstable test] 140048: regressions - FAIL

2019-08-13 Thread osstest service owner
flight 140048 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/140048/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 16 guest-localmigrate fail REGR. vs. 139876

[Xen-devel] [ovmf test] 140068: all pass - PUSHED

2019-08-13 Thread osstest service owner
flight 140068 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/140068/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 073f2cede820782e37e31bd6664aa53b79bbade4 baseline version: ovmf

Re: [Xen-devel] Xen-unstable staging build broken by pvshim patches.

2019-08-13 Thread Sander Eikelenboom
On 13/08/2019 23:05, Andrew Cooper wrote: > On 13/08/2019 22:03, Sander Eikelenboom wrote: >> On 13/08/2019 15:31, Andrew Cooper wrote: >>> On 13/08/2019 12:51, Sander Eikelenboom wrote: On 13/08/2019 13:21, Andrew Cooper wrote: > On 09/08/2019 00:28, Sander Eikelenboom wrote: >> On

[Xen-devel] [xen-unstable-smoke test] 140081: tolerable all pass - PUSHED

2019-08-13 Thread osstest service owner
flight 140081 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/140081/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Dario Faggioli
On Tue, 2019-08-13 at 19:43 +0100, Julien Grall wrote: > On 8/13/19 6:34 PM, Dario Faggioli wrote: > > On Tue, 2019-08-13 at 17:52 +0100, Julien Grall wrote: > > > > > So, unless the flag gets cleared again, or something else happens > > that > > makes the vCPU(s) fail the vcpu_runnable() check

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Julien Grall
On Tue, 13 Aug 2019, 23:39 Dario Faggioli, wrote: > On Tue, 2019-08-13 at 19:43 +0100, Julien Grall wrote: > > On 8/13/19 6:34 PM, Dario Faggioli wrote: > > > On Tue, 2019-08-13 at 17:52 +0100, Julien Grall wrote: > > > > > > > So, unless the flag gets cleared again, or something else happens >

[Xen-devel] [qemu-mainline test] 140059: regressions - FAIL

2019-08-13 Thread osstest service owner
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190813' into staging ppc patch queue 2019-08-13 (last minute qemu-4.1 fixes) Here's a very, very last minute pull request for qemu-4.1. This fixes two nasty bugs with the XIVE interrupt controller in "

[Xen-devel] [linux-4.19 test] 140061: regressions - FAIL

2019-08-13 Thread osstest service owner
flight 140061 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140061/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvops 6 kernel-build fail REGR. vs. 129313 Tests which are

Re: [Xen-devel] [PATCH v5 4/7] xen/arm: early_print_info print reserved_mem

2019-08-13 Thread Volodymyr Babchuk
Stefano Stabellini writes: > Improve early_print_info to also print the banks saved in > bootinfo.reserved_mem. Print them right after RESVD, increasing the same > index. > > Since we are at it, also switch the existing RESVD print to use unsigned > int. > > Signed-off-by: Stefano Stabellini

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-13 Thread Dario Faggioli
On Thu, 2019-08-08 at 17:07 +0300, Andrii Anisov wrote: > On 06.08.19 16:09, Andrii Anisov wrote: > > p.p.s. I'm looking through freertos as well to get wider look on > > the available approaches > > OK, basically Free-RTOS does not account the IRQ time separately. Yet > its scheduling is very

Re: [Xen-devel] [PATCH v5 2/7] xen/arm: make process_memory_node a device_tree_node_func

2019-08-13 Thread Julien Grall
Hi, On 8/12/19 11:28 PM, Stefano Stabellini wrote: Change the signature of process_memory_node to match device_tree_node_func. Thanks to this change, the next patch will be able to use device_tree_for_each_node to call process_memory_node on all the children of a provided node. Return error if

Re: [Xen-devel] [PATCH 3/3] xen/sched: add minimalistic idle scheduler for free cpus

2019-08-13 Thread Dario Faggioli
On Fri, 2019-08-02 at 15:07 +0200, Juergen Gross wrote: > Instead of having a full blown scheduler running for the free cpus > add a very minimalistic scheduler for that purpose only ever > scheduling > the related idle vcpu. This has the big advantage of not needing any > per-cpu, per-domain or

Re: [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile

2019-08-13 Thread Steven Haigh
I've had a tinker with the patch - I don't have a Fedora build system atm - so I just edited the file on the Dom0 and removed the pyc/pyo files. Same issue: pyGRUB version 0.6 ┌┐ │ Fedora (5.2.6-200.fc30.x86_64) 30

[Xen-devel] [linux-4.4 test] 140072: regressions - FAIL

2019-08-13 Thread osstest service owner
flight 140072 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140072/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail REGR. vs. 139698 Tests which are

Re: [Xen-devel] [PATCH 3/3] xen/blkback: Use refcount_t for refcount

2019-08-13 Thread Chuhong Yuan
On Thu, Aug 8, 2019 at 9:35 PM Roger Pau Monné wrote: > > On Thu, Aug 08, 2019 at 09:11:00PM +0800, Chuhong Yuan wrote: > > Reference counters are preferred to use refcount_t instead of > > atomic_t. > > This is because the implementation of refcount_t can prevent > > overflows and detect

[Xen-devel] [PATCH] drm/xen-front: Make structure fb_funcs constant

2019-08-13 Thread Nishka Dasgupta
Static structure fb_funcs, of type drm_framebuffer_funcs, is used only when it is passed to drm_gem_fb_create_with_funcs() as its last argument. drm_gem_fb_create_with_funcs does not modify its lst argument (fb_funcs) and hence fb_funcs is never modified. Therefore make fb_funcs constant to

[Xen-devel] [PATCH v5 4/7] xen/arm: early_print_info print reserved_mem

2019-08-13 Thread Stefano Stabellini
Improve early_print_info to also print the banks saved in bootinfo.reserved_mem. Print them right after RESVD, increasing the same index. Since we are at it, also switch the existing RESVD print to use unsigned int. Signed-off-by: Stefano Stabellini --- Changes in v5: - switch to unsigned

[Xen-devel] [xen-unstable-smoke test] 139980: tolerable all pass - PUSHED

2019-08-13 Thread osstest service owner
flight 139980 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/139980/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH 1/6] domain: introduce XEN_DOMCTL_CDF_iommu

2019-08-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 07 August 2019 10:22 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Julien Grall ; > Andrew Cooper > ; Anthony Perard ; > Roger Pau Monne > ; Volodymyr Babchuk ; > George Dunlap > ; Ian Jackson ; Stefano > Stabellini > ;

[Xen-devel] [PATCH v3 06/28] xen/arm64: head: Introduce a macro to get a PC-relative address of a symbol

2019-08-13 Thread Julien Grall
Arm64 provides instructions to load a PC-relative address, but with some limitations: - adr is enable to cope with +/-1MB - adrp is enale to cope with +/-4GB but relative to a 4KB page address Because of that, the code requires to use 2 instructions to load any Xen symbol. To make the

Re: [Xen-devel] [PATCH] x86/spec-ctrl: Scrub stale segment registers on leaky hardware

2019-08-13 Thread Andrew Cooper
On 12/08/2019 09:00, Jan Beulich wrote: > On 09.08.2019 19:16, Andrew Cooper wrote: >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -1914,7 +1914,7 @@ By default SSBD will be mitigated at runtime >> (i.e `ssbd=runtime`). >>   ### spec-ctrl (x86) >>   >

[Xen-devel] [ANNOUNCE] Xen Project Developer Summit 2019: Slides, Recordings and Design Session notes are available

2019-08-13 Thread Lars Kurth
Dear Community member, if you didn’t make it to the developer summit, you can find material related to the summit in the following locations Slides: https://www.slideshare.net/search/slideshow?searchfrom=header=XPDDS19 YouTube playlist of recordings

Re: [Xen-devel] [RFC] Code of Conduct

2019-08-13 Thread George Dunlap
On 8/9/19 6:48 PM, Lars Kurth wrote: > Hi all, > > Following the discussion we had at the Developer Summit (see > https://wiki.xenproject.org/wiki/Design_Sessions_2019#Community_Issues_.2F_Improvements_-_Communication.2C_Code_of_Conduct.2C_etc. > for notes) I put together a draft for the Code

[Xen-devel] [PATCH v3 09/28] xen/arm32: head: Mark the end of subroutines with ENDPROC

2019-08-13 Thread Julien Grall
putn() and puts() are two subroutines. Add ENDPROC for the benefits of static analysis tools and the reader. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v3: - Add Stefano's acked-by Changes in v2: - Patch added --- xen/arch/arm/arm32/head.S

[Xen-devel] [PATCH] x86/AMD-Vi: Fold exit paths of {enable, disable}_iommu()

2019-08-13 Thread Andrew Cooper
... to avoid having multiple spin_unlock_irqrestore() calls. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Boris Ostrovsky CC: Suravee Suthikulpanit CC: Brian Woods Interestingly GCC 6.3 managed to fold disable_iommu() automatically. There is some

Re: [Xen-devel] [PATCH] drm/xen-front: Make structure fb_funcs constant

2019-08-13 Thread Oleksandr Andrushchenko
On 8/13/19 9:27 AM, Nishka Dasgupta wrote: Static structure fb_funcs, of type drm_framebuffer_funcs, is used only when it is passed to drm_gem_fb_create_with_funcs() as its last argument. drm_gem_fb_create_with_funcs does not modify its lst argument (fb_funcs) and hence fb_funcs is never

Re: [Xen-devel] [PATCH] xen/arm: p2m: Free the p2m entry after flushing the IOMMU TLBs

2019-08-13 Thread Julien Grall
Hi Andrew, On 8/13/19 9:03 AM, Andrew Cooper wrote: On 12/08/2019 21:27, Julien Grall wrote: When freeing a p2m entry, all the sub-tree behind it will also be freed. This may include intermediate page-tables or any l3 entry requiring to drop a reference (e.g for foreign pages). As soon as

[Xen-devel] [PATCH v3 24/28] xen/arm: Zero BSS after the MMU and D-cache is turned on

2019-08-13 Thread Julien Grall
At the moment BSS is zeroed before the MMU and D-Cache is turned on. In other words, the cache will be bypassed when zeroing the BSS section. On Arm64, per the Image protocol [1], the state of the cache for BSS region is not known because it is not part of the "loaded kernel image". On Arm32,

Re: [Xen-devel] [ANNOUNCE] Xen 4.13 Development Update

2019-08-13 Thread Paul Durrant
> -Original Message- > > === x86 === > > * PV-IOMMU (v7) > - Paul Durrant > Realistically I'm unlikely to get back to the hypercall interface any time soon. There's just too much groundwork to lay, so probably better stop tracking this for now. Paul

[Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions

2019-08-13 Thread Stefano Stabellini
As we parse the device tree in Xen, keep track of the reserved-memory regions as they need special treatment (follow-up patches will make use of the stored information.) Reuse process_memory_node to add reserved-memory regions to the bootinfo.reserved_mem array. Refuse to continue once we reach

[Xen-devel] [qemu-mainline test] 140012: tolerable FAIL - PUSHED

2019-08-13 Thread osstest service owner
flight 140012 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/140012/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 139887 test-armhf-armhf-libvirt 14

Re: [Xen-devel] [PATCH] xen/arm: p2m: Free the p2m entry after flushing the IOMMU TLBs

2019-08-13 Thread Andrew Cooper
On 12/08/2019 21:27, Julien Grall wrote: > When freeing a p2m entry, all the sub-tree behind it will also be freed. > This may include intermediate page-tables or any l3 entry requiring to > drop a reference (e.g for foreign pages). As soon as pages are freed, > they may be re-used by Xen or

[Xen-devel] [PATCH v2 3/3] xen/blkback: Use refcount_t for refcount

2019-08-13 Thread Chuhong Yuan
Reference counters are preferred to use refcount_t instead of atomic_t. This is because the implementation of refcount_t can prevent overflows and detect possible use-after-free. So convert atomic_t ref counters to refcount_t. Signed-off-by: Chuhong Yuan --- Changes in v2: - Also convert

[Xen-devel] [PATCH] x86/suspend: Sanity check more properties in enter_state()

2019-08-13 Thread Andrew Cooper
The logic depends on being run on CPU0, and in IDLE context. Having this explicitly identified allows for simplification of the whole S3 path. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/acpi/power.c | 2 ++ 1 file changed, 2

Re: [Xen-devel] [PATCH v8 01/28] linkage: new macros for assembler symbols

2019-08-13 Thread Borislav Petkov
Hi, this time a more detailed look. :) > Subject: Re: [PATCH v8 01/28] linkage: new macros for assembler symbols Patch subject needs a verb, like, for example: "linkage: Introduce new macros for assembler symbols" On Thu, Aug 08, 2019 at 12:38:27PM +0200, Jiri Slaby wrote: > Introduce new C

[Xen-devel] [PATCH v3 18/28] xen/arm32: head: Move assembly switch to the runtime PT in secondary CPUs path

2019-08-13 Thread Julien Grall
The assembly switch to the runtime PT is only necessary for the secondary CPUs. So move the code in the secondary CPUs path. While this is definitely not compliant with the Arm Arm as we are switching between two differents set of page-tables without turning off the MMU. Turning off the MMU is

Re: [Xen-devel] [PATCH v4 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-13 Thread Stefano Stabellini
On Mon, 12 Aug 2019, Julien Grall wrote: > On 09/08/2019 23:56, Stefano Stabellini wrote: > > On Thu, 8 Aug 2019, Volodymyr Babchuk wrote: > > > Hi Stefano, > > > > > > Stefano Stabellini writes: > > > > > > > Don't allow reserved-memory regions to be remapped into any guests, > > > > until

Re: [Xen-devel] [PATCH v5] x86/xpti: Don't leak TSS-adjacent percpu data via Meltdown

2019-08-13 Thread Jan Beulich
On 12.08.2019 12:29, Andrew Cooper wrote: On 12/08/2019 08:23, Jan Beulich wrote: @@ -747,16 +747,10 @@ void load_system_tables(void) .bitmap = IOBMP_INVALID_OFFSET, }; -    _set_tssldt_desc( -    gdt + TSS_ENTRY, -    (unsigned long)tss, -    offsetof(struct

Re: [Xen-devel] [PATCH] xen/arm: setup: Add Xen as boot module before printing all boot modules

2019-08-13 Thread Stefano Stabellini
On Mon, 12 Aug 2019, Julien Grall wrote: > Since commit f60658c6ae "xen/arm: Stop relocating Xen", the position of > Xen in memory is not printed anymore. This can make difficult to debug > early code. > > As Xen is not relocated anymore, we can add Xen as boot module before > calling

[Xen-devel] [PATCH v3 03/28] xen/arm64: head: Rework and document setup_fixmap()

2019-08-13 Thread Julien Grall
At the moment, the fixmap table is only hooked when earlyprintk is used. This is fine today because in C land, the fixmap is not used by anyone until the the boot CPU is switching to the runtime page-tables. In the future, the boot CPU will not switch between page-tables to avoid TLB incoherency.

[Xen-devel] [PATCH v3 07/28] xen/arm64: head: Fix typo in the documentation on top of init_uart()

2019-08-13 Thread Julien Grall
Signed-off-by: Julien Grall --- Changes in v3: - Patch added --- xen/arch/arm/arm64/head.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index cd03101196..a6f3aa4ee5 100644 --- a/xen/arch/arm/arm64/head.S

Re: [Xen-devel] [PATCH] xen/blkback: fix memory leaks

2019-08-13 Thread Boris Ostrovsky
On 8/11/19 1:23 PM, Wenwen Wang wrote: > In read_per_ring_refs(), after 'req' and related memory regions are > allocated, xen_blkif_map() is invoked to map the shared frame, irq, and > etc. However, if this mapping process fails, no cleanup is performed, > leading to memory leaks. To fix this

[Xen-devel] [PATCH v5 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-13 Thread Stefano Stabellini
Don't allow reserved-memory regions to be remapped into any unprivileged guests, until reserved-memory regions are properly supported in Xen. For now, do not call iomem_permit_access on them, because giving iomem_permit_access to dom0 means that the toolstack will be able to assign the region to a

Re: [Xen-devel] [PATCH] docs/sphinx: Introduction

2019-08-13 Thread George Dunlap
On 8/7/19 8:41 PM, Andrew Cooper wrote: > Put together an introduction page for the Sphinx/RST docs, along with a > glossary which will accumulate over time. > > Signed-off-by: Andrew Cooper > --- > CC: George Dunlap > CC: Ian Jackson > CC: Jan Beulich > CC: Stefano Stabellini > CC: Wei Liu

Re: [Xen-devel] [PATCH 3/6] remove late (on-demand) construction of IOMMU page tables

2019-08-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 07 August 2019 11:32 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Julien Grall ; > Alexandru Isaila > ; Petre Pircalabu ; > Razvan Cojocaru > ; Andrew Cooper ; Roger > Pau Monne > ; VolodymyrBabchuk ; George > Dunlap > ;

[Xen-devel] [PATCH v5 0/7] reserved-memory in dom0

2019-08-13 Thread Stefano Stabellini
Hi all, This patch series introduces partial reserved-memory support for dom0 only (no domU support for reserved-memory yet.) The following changes since commit 762b9a2d990bba1f3aefe660cff0c37ad2e375bc: xen/page_alloc: Keep away MFN 0 from the buddy allocator (2019-08-09 11:12:55 -0700)

Re: [Xen-devel] [PATCH] x86/iommu: remove usage of {set/clear}_identity_p2m_entry against PV domains

2019-08-13 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 02 August 2019 10:22 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Roman Shaposhnik > ; George Dunlap > ; Jan Beulich ; Andrew Cooper > ; Wei Liu ; Kevin Tian > ; Paul Durrant > > Subject: [PATCH] x86/iommu: remove

Re: [Xen-devel] [PATCH v2 3/3] xen/blkback: Use refcount_t for refcount

2019-08-13 Thread Roger Pau Monné
On Tue, Aug 13, 2019 at 02:16:50PM +0800, Chuhong Yuan wrote: > Reference counters are preferred to use refcount_t instead of > atomic_t. > This is because the implementation of refcount_t can prevent > overflows and detect possible use-after-free. > So convert atomic_t ref counters to refcount_t.

[Xen-devel] [xen-unstable test] 140007: regressions - FAIL

2019-08-13 Thread osstest service owner
flight 140007 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/140007/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-livepatch 7 xen-boot fail REGR. vs. 139876

[Xen-devel] [PATCH v3 15/28] xen/arm32: head: Rework and document zero_bss()

2019-08-13 Thread Julien Grall
On secondary CPUs, zero_bss() will be a NOP because BSS only need to be zeroed once at boot. So the call in the secondary CPUs path can be removed. Lastly, document the behavior and the main registers usage within the function. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini ---

Re: [Xen-devel] [PATCH v4 3/7] xen/arm: keep track of reserved-memory regions

2019-08-13 Thread Stefano Stabellini
On Sat, 10 Aug 2019, Julien Grall wrote: > On Fri, 9 Aug 2019, 23:21 Stefano Stabellini, wrote: > On Wed, 7 Aug 2019, Julien Grall wrote: > > Hi Stefano, > > > > On 06/08/2019 22:49, Stefano Stabellini wrote: > > > As we parse the device tree in Xen, keep track of

Re: [Xen-devel] [edk2-devel] [PATCH v4 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-08-13 Thread Anthony PERARD
On Tue, Jul 30, 2019 at 03:10:13PM +0200, Laszlo Ersek wrote: > Hi Anthony, > > On 07/29/19 17:39, Anthony PERARD wrote: > > Patch series available in this git branch: > > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > > br.platform-xen-pvh-v4 > > > > Changes in v4: > > - patch

  1   2   >