Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread Jan Beulich
On 29.05.2020 12:07, Andrew Cooper wrote: > On 29/05/2020 10:34, Jan Beulich wrote: >> While the behavior to ignore this option without FLASK support was >> properly documented, it is still somewhat surprising to someone using >> this option and then still _not_ getting the assumed security. Add a

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Julien Grall
Hi Jan, On 29/05/2020 08:35, Jan Beulich wrote: On 28.05.2020 20:54, Julien Grall wrote: On 28/05/2020 16:25, Bertrand Marquis wrote: At the moment on Arm, a Linux guest running with KTPI enabled will cause the following error when a context switch happens in user mode: (XEN) p2m.c:1890:

[OSSTEST PATCH 28/49] 20_linux_xen: Support Xen Security Modules (XSM/FLASK)

2020-05-29 Thread Ian Jackson
XSM is enabled by adding "flask=enforcing" as a Xen command line argument, and providing the policy file as a grub module. We make entries for both with and without XSM. If XSM is not compiled into Xen, then there are no policy files, so no change to the boot options. Signed-off-by: Ian Jackson

[OSSTEST PATCH 13/49] Debian: Specify `priority=critical' rather than locale

2020-05-29 Thread Ian Jackson
In buster, it appears that specifying locale on the command line is not sufficient. Rather than adding more things to the command line, instead, just say `priority=critical', by defaulting $debconf_priority to 'critical'. I think this change should be fine for earlier suites too. Signed-off-by:

[OSSTEST PATCH 34/49] buster: grub, arm64: extend chainloading workaround

2020-05-29 Thread Ian Jackson
multiboot[2] isn't supported. Also link to the bug report. CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 3fc9e555..9f1ce1df 100644 ---

[OSSTEST PATCH 40/49] Debian.pm: Break out standard_extradebs

2020-05-29 Thread Ian Jackson
Refactor this out of ts-xen-install. We are going to run it in ts-host-install. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 7 ++- ts-xen-install| 3 +-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index d51ac493..60393ca9

[OSSTEST PATCH 41/49] Debian.pm: Move standard_extradebs to ts-host-install

2020-05-29 Thread Ian Jackson
This makes it effect builds on Debian, too. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 1 + ts-host-install | 2 ++ ts-xen-install| 2 -- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 60393ca9..2d30b3e9 100644 ---

[OSSTEST PATCH 31/49] overlay-initrd-buster/sbin/reopen-console: Fix #932416

2020-05-29 Thread Ian Jackson
This bug affects us. Cherry pick the changes to the relevant file from the commit in the upstream debian-installer repo: https://salsa.debian.org/installer-team/rootskel/commit/0ee43d05b83f8ef5a856f3282e002a111809cef9 Signed-off-by: Ian Jackson --- overlay-initrd-buster/sbin/reopen-console

[OSSTEST PATCH 47/49] setupboot_grub2: Do not boot with XSM policy etc. unless xsm=1

2020-05-29 Thread Ian Jackson
This prevents us from passing an XSM policy file, and `flask=enforcing', in supposedly-non-XSM tests. These bootloader entries can appear because the Xen upstream build ships XSM policy files by default even if XSM is disabled in the hypervisor, causing update-grub to generate useless `XSM

[OSSTEST PATCH 14/49] Honour 'LinuxSerialConsole ' host property

2020-05-29 Thread Ian Jackson
This works like LinuxSerialConsole. I originally wrote this to try to work around #940028, where multiple d-i autoinstalls run in parallel leading to hard-to-debug lossage! Explicitly specing the console causes it to run only on that one. However, it turns out that explicitly specifying the

[OSSTEST PATCH 29/49] mg-debian-installer-update: support overlay-intramfs-SUITE

2020-05-29 Thread Ian Jackson
This lets us patch the installer more easily. No uses yet. Signed-off-by: Ian Jackson --- mg-debian-installer-update | 20 1 file changed, 20 insertions(+) diff --git a/mg-debian-installer-update b/mg-debian-installer-update index f1e682f9..fb4fe2ab 100755 ---

[OSSTEST PATCH 11/49] ts-debian-di-install: Provide guest with more RAM

2020-05-29 Thread Ian Jackson
buster cannot boot in so little because its initramfs and kernel are too large. Bump it to 2G. However, our armhf test nodes have very little RAM. And the Debian armhf does fit in them as a guest still, so use a smaller value there. Keying this off the architecture rather than the available

[OSSTEST PATCH 10/49] Debian guests made with xen-tools: Write systemd random seed file

2020-05-29 Thread Ian Jackson
When the Debian guest is not made with d-i, we must still provide this random seed file. This can be done in ts-debian-fixup. Signed-off-by: Ian Jackson --- ts-debian-fixup | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ts-debian-fixup b/ts-debian-fixup index fef9836e..dfeb4d39

[OSSTEST PATCH 48/49] buster 20_linux_xen: Only load policy in XSM-enabled builds

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- overlay-buster/etc/grub.d/20_linux_xen | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/overlay-buster/etc/grub.d/20_linux_xen b/overlay-buster/etc/grub.d/20_linux_xen index 4d3294a2..6f2a98ba 100755 --- a/overlay-buster/etc/grub.d/20_linux_xen

[OSSTEST PATCH 42/49] buster: Install own linux-libc-dev package (!)

2020-05-29 Thread Ian Jackson
As reported here: https://patchew.org/QEMU/20200513120147.21443-1-f4...@amsat.org/ https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=960271 the kernel has broken the build of upstream qemu. This made it into a Debian stable kernel update. This breaks our CI runs almost completely, when they

[OSSTEST PATCH 43/49] setupboot_grub2: Insist on space after directives

2020-05-29 Thread Ian Jackson
These parsing regexps were all wrong! Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 2d30b3e9..a20569e5 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -529,17

[OSSTEST PATCH 12/49] Debian: preseed: use priority= alias

2020-05-29 Thread Ian Jackson
This marginally reduces command line clobber. This alias has been supported approximately forever. (And this code is currently only used when DebconfPriority is set, which it generally isn't.) Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1

[OSSTEST PATCH 16/49] buster: Extend grub2 uefi no install workaround

2020-05-29 Thread Ian Jackson
src:grub2 is RFH in Debian, which is a contributory factor to these patches in #789798 and #792547 languishing. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 7b311a14..9b4ef967

[OSSTEST PATCH 49/49] buster: Switch to Debian buster as the default suite

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest.pm b/Osstest.pm index 1e381d8f..6395 100644 --- a/Osstest.pm +++ b/Osstest.pm @@ -87,7 +87,7 @@ our %c = qw( Images images -DebianSuite stretch +DebianSuite

[OSSTEST PATCH 19/49] buster: preseed partman-auto-lvm/guided_size

2020-05-29 Thread Ian Jackson
Otherwise we get this question: | You may use the whole volume group for guided partitioning, or part | of it. [...] | Amount of volume group to use for guided partitioning: Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 1 + 1 file changed, 1 insertion(+) diff --git

[OSSTEST PATCH 22/49] buster: Extend guest bootloader workaround

2020-05-29 Thread Ian Jackson
CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 71167351..3fc9e555 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -1064,7 +1064,7

[OSSTEST PATCH 17/49] buster: ts-host-install: Extend net.ifnames workaround

2020-05-29 Thread Ian Jackson
Really we should fix this by making a .deb in Debian that we could install. But this is a longer-term project. Signed-off-by: Ian Jackson --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index 7a72a867..fe26f70f 100755

Re: [PATCH 0/2] xen: credit2: limit the number of CPUs per runqueue

2020-05-29 Thread Dario Faggioli
So, I felt like providing some additional thoughts about this series, from a release point of view (adding Paul). Timing is *beyond tight* so if this series, entirely or partly, has any chance to go in, it would be through some form of exception, which of course comes with some risks, etc. I

Re: [PATCH v10 1/9] x86emul: address x86_insn_is_mem_{access, write}() omissions

2020-05-29 Thread Andrew Cooper
On 25/05/2020 15:26, Jan Beulich wrote: > First of all explain in comments what the functions' purposes are. Then > make them actually match their comments. > > Note that fc6fa977be54 ("x86emul: extend x86_insn_is_mem_write() > coverage") didn't actually fix the function's behavior for

[xen-unstable-smoke test] 150472: regressions - trouble: blocked/fail

2020-05-29 Thread osstest service owner
flight 150472 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150472/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 150438 build-amd64

Re: [PATCH v10 2/9] x86emul: rework CMP and TEST emulation

2020-05-29 Thread Andrew Cooper
On 25/05/2020 15:26, Jan Beulich wrote: > Unlike similarly encoded insns these don't write their memory operands, "write to their". > and hence x86_is_mem_write() should return false for them. However, > rather than adding special logic there, rework how their emulation gets > done, by making

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Hongyan Xia
On Fri, 2020-05-29 at 08:13 +, Bertrand Marquis wrote: > Hi Julien, > > > On 28 May 2020, at 19:54, Julien Grall wrote: > > > > Hi Bertrand, > > > > Thank you for the patch. > > > > On 28/05/2020 16:25, Bertrand Marquis wrote: > > > At the moment on Arm, a Linux guest running with KTPI

Re: [PATCH 2/2] xen: credit2: limit the max number of CPUs in a runqueue

2020-05-29 Thread Jan Beulich
On 28.05.2020 16:55, Dario Faggioli wrote: > On Wed, 2020-05-27 at 08:17 +0200, Jan Beulich wrote: >> On 27.05.2020 00:00, Dario Faggioli wrote: >>> Just in case, is there a >>> way to identify them easily, like with a mask or something, in the >>> code >>> already? >> >> cpu_sibling_mask still

Re: [PATCH 2/2] xen: credit2: limit the max number of CPUs in a runqueue

2020-05-29 Thread Dario Faggioli
On Fri, 2020-05-29 at 11:58 +0200, Jan Beulich wrote: > On 28.05.2020 16:55, Dario Faggioli wrote: > > > > Which means I will be treating HTs and CUs the same which, thinking > > more about it (and thinking actually to CUs, rather than to any > > cache > > sharing relationship), does make sense

Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n"): > On 29/05/2020 10:34, Jan Beulich wrote: > > While the behavior to ignore this option without FLASK support was > > properly documented, it is still somewhat surprising to someone using > > this option

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Ian Jackson
George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): > > On May 27, 2020, at 4:41 PM, Ian Jackson wrote: > > 3. Failing that, Xen should provide some other mechanism which would > > enable something like update-grub to determine whether a particular > > hypervisor can sensibly

[OSSTEST PATCH 45/49] setupboot_grub2: Recognise --nounzip for initramfs

2020-05-29 Thread Ian Jackson
Modern versions of update-grub like to add this. We need to spot this so that under EFI we generate the right things in xen.cfg. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index

[OSSTEST PATCH 46/49] setupboot_grub2: Copy hv command line from grub to xen.cfg

2020-05-29 Thread Ian Jackson
This reuses all of the stuff that update-grub, etc., have put there. In particular without this we never have flask=enforcing! We have to do something about the ${xen_rm_opts} that appear in these entries. In principle there might be many variable expansions, but in practice there is only this

[OSSTEST PATCH 18/49] buster: Deinstall the "systemd" package

2020-05-29 Thread Ian Jackson
This installs a pam rule which causes logins to hang. It also seems to cause some kind of udev wedge. We are using sysvinit so this package is not desirable. Empirically, removing it makes the system work. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 1 + 1 file changed, 1 insertion(+)

RE: [PATCH v3] docs: update xenstore-migration.md

2020-05-29 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of Juergen > Gross > Sent: 29 May 2020 12:37 > To: xen-devel@lists.xenproject.org > Cc: Juergen Gross ; Stefano Stabellini > ; Julien Grall > ; Wei Liu ; Andrew Cooper > ; Ian Jackson > ; George Dunlap ; Jan > Beulich > Subject: [PATCH

[xen-unstable test] 150444: tolerable trouble: fail/pass/starved - PUSHED

2020-05-29 Thread osstest service owner
flight 150444 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150444/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail blocked in 150414 test-armhf-armhf-libvirt 14

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Jan Beulich
On 29.05.2020 11:18, Bertrand Marquis wrote: > Hi Jan, > >> On 29 May 2020, at 09:45, Jan Beulich wrote: >> >> On 29.05.2020 10:13, Bertrand Marquis wrote: On 28 May 2020, at 19:54, Julien Grall wrote: AFAICT, there is no restriction on when the runstate hypercall can be called.

Re: [PATCH v8 2/8] block: consolidate blocksize properties consistency checks

2020-05-29 Thread Markus Armbruster
Roman Kagan writes: > Several block device properties related to blocksize configuration must > be in certain relationship WRT each other: physical block must be no > smaller than logical block; min_io_size, opt_io_size, and > discard_granularity must be a multiple of a logical block. > > To

Re: [PATCH v10 07/12] xen: provide version information in hypfs

2020-05-29 Thread Jan Beulich
On 29.05.2020 11:19, Jürgen Groß wrote: > On 29.05.20 10:34, Jan Beulich wrote: >> On 19.05.2020 09:21, Juergen Gross wrote: >>> @@ -373,6 +374,52 @@ void __init do_initcalls(void) >>> (*call)(); >>> } >>> >>> +#ifdef CONFIG_HYPFS >>> +static unsigned int __read_mostly

Re: [PATCH 0/3] Automation: improve openSUSE containers + podman

2020-05-29 Thread Dario Faggioli
On Thu, 2020-05-21 at 09:43 +0200, Dario Faggioli wrote: > On Thu, 2020-04-30 at 20:27 +0200, Dario Faggioli wrote: > > Hello, > > > > This short series contains some improvements for building Xen in > > openSUSE containers. In fact, the build dependencies inside the > > Tumbleweed container are

[PATCH] tools: fix Rules.mk library make variables

2020-05-29 Thread Juergen Gross
Both SHDEPS_libxendevicemodel and SHDEPS_libxenhypfs have a bug by adding $(SHLIB_xencall) instead of $(SHLIB_libxencall). The former seems not to have any negative impact, probably because it is not used anywhere in Xen without the correct $(SHLIB_libxencall) being used, too. Fixes:

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Ian Jackson
Ian Jackson writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): > George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): > > > On May 27, 2020, at 4:41 PM, Ian Jackson wrote: > > > 3. Failing that, Xen should provide some other mechanism which would > > > enable something

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Julien Grall
Hi, On 29/05/2020 10:18, Bertrand Marquis wrote: On 29 May 2020, at 09:45, Jan Beulich wrote: On 29.05.2020 10:13, Bertrand Marquis wrote: On 28 May 2020, at 19:54, Julien Grall wrote: AFAICT, there is no restriction on when the runstate hypercall can be called. So this can even be called

Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread George Dunlap
> On May 29, 2020, at 11:39 AM, Ian Jackson wrote: > > Andrew Cooper writes ("Re: [PATCH] xsm: also panic upon "flask=enforcing" > when XSM_FLASK=n"): >> On 29/05/2020 10:34, Jan Beulich wrote: >>> While the behavior to ignore this option without FLASK support was >>> properly documented, it

[PATCH v7 02/15] x86/mm: make sure there is one exit path for modify_xen_mappings

2020-05-29 Thread Hongyan Xia
From: Wei Liu We will soon need to handle dynamically mapping / unmapping page tables in the said function. Since dynamic mappings may map and unmap pl3e in different iterations, lift pl3e out of the loop. No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed

[PATCH v7 09/15] efi: use new page table APIs in copy_mapping

2020-05-29 Thread Hongyan Xia
From: Wei Liu After inspection ARM doesn't have alloc_xen_pagetable so this function is x86 only, which means it is safe for us to change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - hoist l3 variables out of the loop to avoid repetitive mappings. ---

[PATCH v7 00/15] switch to domheap for Xen page tables

2020-05-29 Thread Hongyan Xia
From: Hongyan Xia This series rewrites all the remaining functions and finally makes the switch from xenheap to domheap for Xen page tables, so that they no longer need to rely on the direct map, which is a big step towards removing the direct map. This series depends on the following

[PATCH v7 07/15] x86_64/mm: switch to new APIs in paging_init

2020-05-29 Thread Hongyan Xia
From: Wei Liu Map and unmap pages instead of relying on the direct map. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - use the new alloc_map_clear_xen_pt() helper. - move the unmap of pl3t up a bit. - remove the unmaps in the nomem path. --- xen/arch/x86/x86_64/mm.c

[PATCH v7 01/15] x86/mm: map_pages_to_xen would better have one exit path

2020-05-29 Thread Hongyan Xia
From: Wei Liu We will soon rewrite the function to handle dynamically mapping and unmapping of page tables. Since dynamic mappings may map and unmap pages in different iterations of the while loop, we need to lift pl3e out of the loop. No functional change. Signed-off-by: Wei Liu

[PATCH v7 08/15] x86_64/mm: switch to new APIs in setup_m2p_table

2020-05-29 Thread Hongyan Xia
From: Wei Liu Avoid repetitive mapping of l2_ro_mpt by keeping it across loops, and only unmap and map it when crossing 1G boundaries. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - avoid repetitive mapping of l2_ro_mpt. - edit commit message. - switch to

[PATCH v7 06/15] x86_64/mm: introduce pl2e in paging_init

2020-05-29 Thread Hongyan Xia
From: Wei Liu We will soon map and unmap pages in paging_init(). Introduce pl2e so that we can use l2_ro_mpt to point to the page table itself. No functional change. Signed-off-by: Wei Liu --- Changed in v7: - reword commit message. --- xen/arch/x86/x86_64/mm.c | 16 +--- 1 file

[PATCH v7 03/15] x86/mm: rewrite virt_to_xen_l*e

2020-05-29 Thread Hongyan Xia
From: Wei Liu Rewrite those functions to use the new APIs. Modify its callers to unmap the pointer returned. Since alloc_xen_pagetable_new() is almost never useful unless accompanied by page clearing and a mapping, introduce a helper alloc_map_clear_xen_pt() for this sequence. Note that the

[PATCH v7 04/15] x86/mm: switch to new APIs in map_pages_to_xen

2020-05-29 Thread Hongyan Xia
From: Wei Liu Page tables allocated in that function should be mapped and unmapped now. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- xen/arch/x86/mm.c | 60 --- 1 file changed, 36 insertions(+), 24 deletions(-) diff --git

[OSSTEST PATCH 08/49] ts-leak-check: Ignore buster's udevd too

2020-05-29 Thread Ian Jackson
For reasons I don't propose to investigate, on buster udevd shows up like this: 2019-11-26 18:13:48 Z LEAKED [process 2633 /lib/systemd/systemd-udevd] process: root 2633 1555 0 18:10 ?00:00:00 /lib/systemd/systemd-udevd This does not match our suppression. Add an additional

[OSSTEST PATCH 06/49] di_installcmdline_core: Pass locale on d-i command line

2020-05-29 Thread Ian Jackson
In buster, d-i wants when setting up the network, ie before the preseed is loaded. We leave it in the preseed too because why not. I think this change should be fine for older versions of Debian. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 3 ++- 1 file changed, 2 insertions(+), 1

[OSSTEST PATCH 09/49] Bodge systemd random seed arrangements

2020-05-29 Thread Ian Jackson
systemd does not regard the contents of the random seed file as useful for the purposes of placating the kernel's entropy tracker. As a result, the system hangs at boot waiting for entropy. Fix this by providing a small program which can be used to load a seed file into /dev/random and also call

[OSSTEST PATCH 05/49] Booting: Use `--' rather than `---' to introduce host cmdline

2020-05-29 Thread Ian Jackson
Because systemd did something obnoxious, the kernel retaliated in the game of Core Wars by hiding all arguments before `--' from userspace. So use `---' instead so that all the arguments remain visible. This in some sense now applies to host installs a change we had already made to Debian HVM

[OSSTEST PATCH 03/49] lvcreate argments: pass --yes -Z y -W y

2020-05-29 Thread Ian Jackson
The documentation seesm to think this is the default but empirically it isn't. In our environment --yes is fine. I have reported this to Debian as #953183. Also vaguely related (and discovered by me at the same time) is #953185. This came up while trying to get things work on buster. I don't

[OSSTEST PATCH 02/49] ts-xen-build-prep: Install rsync

2020-05-29 Thread Ian Jackson
osstest uses this for transferring configuration, build artefacts, and so on. In Debian stretch and earlier, rsync happened to be pulled in by something else. Signed-off-by: Ian Jackson --- ts-xen-build-prep | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-xen-build-prep

[OSSTEST PATCH 04/49] TestSupport: allow more time for apt

2020-05-29 Thread Ian Jackson
Empirically some of these operations can take longer than 30s, especially with a cold cache. Note that because of host sharing and our on-host apt lock, the timeout needs to be the same for every apt operation: a fast operation could be blocked behind a slow one. Signed-off-by: Ian Jackson ---

[BOOTLOADER SPECIFICATION RFC] The bootloader log format for TrenchBoot and others

2020-05-29 Thread Daniel Kiper
Hey, Below you can find my rough idea of the bootloader log format which is generic thing but initially will be used for TrenchBoot work. I discussed this proposal with Ross and Daniel S. So, the idea went through initial sanitization. Now I would like to take feedback from other folks too. So,

[PATCH v7 11/15] x86/smpboot: add exit path for clone_mapping()

2020-05-29 Thread Hongyan Xia
From: Wei Liu We will soon need to clean up page table mappings in the exit path. No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - edit commit message. - begin with rc = 0 and set it to -ENOMEM ahead of if(). --- xen/arch/x86/smpboot.c | 16

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Julien Grall
Hi Bertrand, On 29/05/2020 09:13, Bertrand Marquis wrote: Hi Julien, On 28 May 2020, at 19:54, Julien Grall wrote: Hi Bertrand, Thank you for the patch. On 28/05/2020 16:25, Bertrand Marquis wrote: At the moment on Arm, a Linux guest running with KTPI enabled will cause the following

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread George Dunlap
> On May 29, 2020, at 9:52 AM, Jan Beulich wrote: > > On 27.05.2020 18:08, George Dunlap wrote: >>> On May 27, 2020, at 4:41 PM, Ian Jackson wrote: >>> 2. Xen should disable the XSM policy build when FLASK is disabled. >>> This is unfortunately not so simple because the XSM policy build is a

Re: [PATCH v10 07/12] xen: provide version information in hypfs

2020-05-29 Thread Jürgen Groß
On 29.05.20 11:53, Jan Beulich wrote: On 29.05.2020 11:19, Jürgen Groß wrote: On 29.05.20 10:34, Jan Beulich wrote: On 19.05.2020 09:21, Juergen Gross wrote: @@ -373,6 +374,52 @@ void __init do_initcalls(void) (*call)(); } +#ifdef CONFIG_HYPFS +static unsigned int

Re: [PATCH v8 2/8] block: consolidate blocksize properties consistency checks

2020-05-29 Thread Roman Kagan
On Fri, May 29, 2020 at 11:53:26AM +0200, Markus Armbruster wrote: > Roman Kagan writes: > > > Several block device properties related to blocksize configuration must > > be in certain relationship WRT each other: physical block must be no > > smaller than logical block; min_io_size,

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Jan Beulich
On 29.05.2020 12:50, Ian Jackson wrote: > George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): >>> On May 27, 2020, at 4:41 PM, Ian Jackson wrote: >>> 3. Failing that, Xen should provide some other mechanism which would >>> enable something like update-grub to determine whether

[PATCH v7 05/15] x86/mm: switch to new APIs in modify_xen_mappings

2020-05-29 Thread Hongyan Xia
From: Wei Liu Page tables allocated in that function should be mapped and unmapped now. Note that pl2e now maybe mapped and unmapped in different iterations, so we need to add clean-ups for that. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - use normal unmap in the

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread George Dunlap
> On May 29, 2020, at 12:02 PM, Jan Beulich wrote: > > On 29.05.2020 12:50, Ian Jackson wrote: >> George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): On May 27, 2020, at 4:41 PM, Ian Jackson wrote: 3. Failing that, Xen should provide some other mechanism which

[PATCH v7 12/15] x86/smpboot: switch clone_mapping() to new APIs

2020-05-29 Thread Hongyan Xia
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - change patch title - remove initialiser of pl3e. - combine the initialisation of pl3e into a single assignment. - use the new alloc_map_clear() helper. - use the normal map_domain_page() in the error path.

[PATCH v7 14/15] x86: switch to use domheap page for page tables

2020-05-29 Thread Hongyan Xia
From: Hongyan Xia Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- xen/arch/x86/mm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 38cfa3ce25..16f1aa3344 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@

[PATCH v7 13/15] x86/mm: drop old page table APIs

2020-05-29 Thread Hongyan Xia
From: Hongyan Xia Two sets of old APIs, alloc/free_xen_pagetable() and lXe_to_lYe(), are now dropped to avoid the dependency on direct map. There are two special cases which still have not been re-written into the new APIs, thus need special treatment: rpt in smpboot.c cannot use ephemeral

[PATCH v7 10/15] efi: switch to new APIs in EFI code

2020-05-29 Thread Hongyan Xia
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - add blank line after declaration. - rename efi_l4_pgtable into efi_l4t. - pass the mapped efi_l4t to copy_mapping() instead of map it again. - use the alloc_map_clear_xen_pt() API. - unmap pl3e, pl2e, l1t

RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)

2020-05-29 Thread Paul Durrant
> -Original Message- > From: Ian Jackson > Sent: 29 May 2020 12:19 > To: xen-devel@lists.xenproject.org; Paul Durrant > Cc: Ian Jackson ; committ...@xenproject.org > Subject: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable) > > This series looks about as ready as it is

[PATCH v7 15/15] x86/mm: drop _new suffix for page table APIs

2020-05-29 Thread Hongyan Xia
From: Wei Liu No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Acked-by: Jan Beulich --- xen/arch/x86/mm.c| 44 xen/arch/x86/smpboot.c | 6 +++--- xen/arch/x86/x86_64/mm.c | 2 +- xen/include/asm-x86/mm.h | 4 ++--

[PATCH v3] docs: update xenstore-migration.md

2020-05-29 Thread Juergen Gross
Update connection record details: - make flags common for sockets and domains (makes it easier to have a C union for conn-spec) - add pending incoming data (needed for handling partially read requests when doing live update) - add partial response length (needed for proper split to individual

Re: [PATCH v2 03/14] x86/shstk: Introduce Supervisor Shadow Stack support

2020-05-29 Thread Jan Beulich
On 28.05.2020 20:10, Andrew Cooper wrote: > On 28/05/2020 11:25, Jan Beulich wrote: >> On 27.05.2020 21:18, Andrew Cooper wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -34,6 +34,10 @@ config ARCH_DEFCONFIG >>> config INDIRECT_THUNK >>> def_bool

[xen-unstable-smoke test] 150465: regressions - trouble: blocked/fail

2020-05-29 Thread osstest service owner
flight 150465 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150465/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 150438 build-amd64

[PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread Jan Beulich
While the behavior to ignore this option without FLASK support was properly documented, it is still somewhat surprising to someone using this option and then still _not_ getting the assumed security. Add a 2nd handler for the command line option for the XSM_FLASK=n case, and invoke panic() when

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Jan Beulich
On 29.05.2020 11:55, George Dunlap wrote: > > >> On May 29, 2020, at 9:52 AM, Jan Beulich wrote: >> >> On 27.05.2020 18:08, George Dunlap wrote: On May 27, 2020, at 4:41 PM, Ian Jackson wrote: 2. Xen should disable the XSM policy build when FLASK is disabled. This is

Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread Andrew Cooper
On 29/05/2020 10:34, Jan Beulich wrote: > While the behavior to ignore this option without FLASK support was > properly documented, it is still somewhat surprising to someone using > this option and then still _not_ getting the assumed security. Add a > 2nd handler for the command line option for

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread George Dunlap
> On May 29, 2020, at 11:50 AM, Ian Jackson wrote: > > George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): >>> On May 27, 2020, at 4:41 PM, Ian Jackson wrote: >>> 3. Failing that, Xen should provide some other mechanism which would >>> enable something like update-grub to

[xen-unstable-smoke test] 150469: regressions - trouble: blocked/fail

2020-05-29 Thread osstest service owner
flight 150469 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150469/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 150438 build-amd64

[OSSTEST PATCH 01/49] ts-logs-capture: Cope if xl shutdown leaves domain running for a bit

2020-05-29 Thread Ian Jackson
This seems mostly to affect buster but it could in principle affect earlier releases too I think. In principle it would be nice to fix this bug, and to have a proper test for it, but a reliable test is hard and an unreliable one is not useful. So I guess we are going to have this workaround

[OSSTEST PATCH 07/49] setupboot_grub2: Drop $submenu variable

2020-05-29 Thread Ian Jackson
We really only used this to check how many levels deep in { we are. That can be done by checking $#offsets, which is >0 if we are in a submenu and not otherwise. We lose the ability to report the start line of the submenu, but that's OK. But as a bonus, we no longer bomb out on nested submenus:

[OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)

2020-05-29 Thread Ian Jackson
This series looks about as ready as it is going to be. Unfortunately there are still two issues, each of which cropped up once in my final formal retest. See below. What are people's opinions? Should I push this to osstest pretest soon after the Xen codefreeze (eg, after we get the first push

[OSSTEST PATCH 26/49] 20_linux_xen: Adhoc template substitution

2020-05-29 Thread Ian Jackson
This file is a template that various build-time variables get substituted into. Make thos substitutions by hand (actually, by copying the values our file for stretch). And rename the file. So now we are using our file instead of the grub package's. But it is the same... Signed-off-by: Ian

[OSSTEST PATCH 36/49] buster: setupboot_grub2: Handle missing policy file bug

2020-05-29 Thread Ian Jackson
This is a complex interaction between update-grub and the Xen build system on ARM64. Not sure exactly who to blame but since we have our own 20_linux_xen bodge, let's wait until we don't. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 12 +++- 1 file changed, 11 insertions(+), 1

[OSSTEST PATCH 44/49] setupboot_grub2: Print line number of entry we are using

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index a20569e5..615047cb 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -562,7 +562,7 @@ sub setupboot_grub2 () {

[OSSTEST PATCH 25/49] 20_linux_xen: Copy Debian buster version into our initramfs area

2020-05-29 Thread Ian Jackson
This is from 41e42571ebc50fa351cd63ce40044946652c5c72 in Debian's grub package. We are going to want to modify this to support XSM/FLASK and cope with upstream build outputs. In this commit we dump the exact file contents across. It's not effective right now because of the ".in" extension. In

[OSSTEST PATCH 39/49] ts-xen-install: Move some_extradebs to Debian.pm

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 38 ++ ts-xen-install| 36 2 files changed, 38 insertions(+), 36 deletions(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 49d94b9b..d51ac493 100644 ---

[OSSTEST PATCH 20/49] buster: ts-host-install: NTP not honoured bug remains

2020-05-29 Thread Ian Jackson
Debian #778564 remains open. Signed-off-by: Ian Jackson --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index fe26f70f..253dbb5d 100755 --- a/ts-host-install +++ b/ts-host-install @@ -152,7 +152,7 @@ END my

[OSSTEST PATCH 32/49] buster: chiark-scripts: Install a new version on buster too

2020-05-29 Thread Ian Jackson
We need various fixes that are not in buster, sadly. Signed-off-by: Ian Jackson --- production-config | 1 + 1 file changed, 1 insertion(+) diff --git a/production-config b/production-config index f0ddc132..e3870d47 100644 --- a/production-config +++ b/production-config @@ -107,6 +107,7 @@

[OSSTEST PATCH 30/49] overlay-initrd-buster/sbin/reopen-console: Copy from Debian

2020-05-29 Thread Ian Jackson
We are going to patch this file to work around a bug, using the new overlay mechanism. The first step is to include the file in our overlay so we overwrite it. Currently, this is a no-op, so no functional change. Signed-off-by: Ian Jackson --- overlay-initrd-buster/sbin/reopen-console | 94

[OSSTEST PATCH 24/49] buster: Specify DebianImageFile_SUITE_ARCH

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- production-config | 3 +++ 1 file changed, 3 insertions(+) diff --git a/production-config b/production-config index 103b8915..f0ddc132 100644 --- a/production-config +++ b/production-config @@ -98,6 +98,9 @@ DebianSnapshotBackports_jessie

[OSSTEST PATCH 23/49] Honour DebianImageFile_SUITE_ARCH

2020-05-29 Thread Ian Jackson
This lets us specify the whole filename, not just a version. This is needed because for buster we are going to use debian-10.2.0-ARCH-xfce-CD-1.iso Signed-off-by: Ian Jackson --- mfi-common | 9 + 1 file changed, 9 insertions(+) diff --git a/mfi-common b/mfi-common index

[OSSTEST PATCH 38/49] ts-xen-install: Add $ho argument to some_extradebs

2020-05-29 Thread Ian Jackson
This is going to move to Debian.pm. Signed-off-by: Ian Jackson --- ts-xen-install | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ts-xen-install b/ts-xen-install index 08b4ea23..6196a890 100755 --- a/ts-xen-install +++ b/ts-xen-install @@ -71,8 +71,8 @@ sub packages

[OSSTEST PATCH 33/49] buster: Provide TftpDiVersion

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- production-config | 1 + 1 file changed, 1 insertion(+) diff --git a/production-config b/production-config index e3870d47..6372ac9a 100644 --- a/production-config +++ b/production-config @@ -91,6 +91,7 @@ TftpNetbootGroup osstest TftpDiVersion_wheezy 2016-06-08

[OSSTEST PATCH 35/49] buster: setupboot_grub2: Note what files exist in /boot

2020-05-29 Thread Ian Jackson
Nothing uses this yet. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 9f1ce1df..0386ff7a 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -448,6 +448,11 @@ sub setupboot_grub2 ()

[OSSTEST PATCH 15/49] buster: make-hosts-flight: Add to possible suites for hosts flight

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- make-hosts-flight | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make-hosts-flight b/make-hosts-flight index 92da1c7c..e2c3776a 100755 --- a/make-hosts-flight +++ b/make-hosts-flight @@ -26,7 +26,7 @@ blessing=$4 buildflight=$5 :

  1   2   3   >