Re: [PATCH] docs/misra: add 13.6 to rules.rst

2024-04-03 Thread Jan Beulich
On 03.04.2024 01:21, Stefano Stabellini wrote: > As agreed during MISRA C meetings, add Rule 13.6 to rules.rst. > > Signed-off-by: Stefano Stabellini > --- > There was a request to expand the scope to also include alignof and > typeof. Depending on whether the MISRA C scanners support it, and

[xen-unstable-smoke test] 185225: tolerable all pass - PUSHED

2024-04-03 Thread osstest service owner
flight 185225 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185225/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl

[PATCH v7 16/19] xen/riscv: introduce vm_event_*() functions

2024-04-03 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V5-V7: - Only rebase was done. --- Changes in V4: - New patch. --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/vm_event.c | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 xen/arch/riscv/vm_event.c diff --git

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Jan Beulich
On 03.04.2024 13:10, Daniel P. Smith wrote: > On 4/3/24 02:16, Jan Beulich wrote: >> On 02.04.2024 19:06, Andrew Cooper wrote: >>> The commit makes a claim without any kind of justification. >> >> Well, what does "have no business" leave open? > > Why does it not have any business? Why should a

Re: [PATCH] xen/include: move definition of ASM_INT() to xen/linkage.h

2024-04-03 Thread Andrew Cooper
On 03/04/2024 1:03 pm, Juergen Gross wrote: > ASM_INT() is defined in arch/[arm|x86]/include/asm/asm_defns.h in > exactly the same way. Instead of replicating this definition for riscv > and ppc, move it to include/xen/linkage.h, where other arch agnostic > definitions for assembler code are

Re: [PATCH v4 2/5] tools/init-xenstore-domain: Replace variable MB() usage

2024-04-03 Thread Anthony PERARD
On Mon, Mar 25, 2024 at 04:45:12PM -0400, Jason Andryuk wrote: > The local MB() & GB() macros will be replaced with a common > implementation, but those only work with constant values. Introduce a > static inline mb_to_bytes() in place of the MB() macro to convert the > variable values. > >

Re: [PATCH v6 1/4] tools/init-xenstore-domain: Replace variable MB() usage

2024-04-03 Thread Jason Andryuk
On 2024-04-03 08:41, Anthony PERARD wrote: On Wed, Mar 27, 2024 at 05:50:59PM -0400, Jason Andryuk wrote: The local MB() & GB() macros will be replaced with a common implementation, but those only work with constant values. Introduce a By the way, this is not true, the macro introduce in the

Re: [PATCH] xen/include: move definition of ASM_INT() to xen/linkage.h

2024-04-03 Thread Jan Beulich
On 03.04.2024 14:03, Juergen Gross wrote: > ASM_INT() is defined in arch/[arm|x86]/include/asm/asm_defns.h in > exactly the same way. Instead of replicating this definition for riscv > and ppc, move it to include/xen/linkage.h, where other arch agnostic > definitions for assembler code are living

[linux-linus test] 185220: tolerable FAIL - PUSHED

2024-04-03 Thread osstest service owner
flight 185220 linux-linus real [real] flight 185226 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185220/ http://logs.test-lab.xenproject.org/osstest/logs/185226/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [RFC XEN PATCH v6 5/5] domctl: Add XEN_DOMCTL_gsi_permission to grant gsi

2024-04-03 Thread Anthony PERARD
On Thu, Mar 28, 2024 at 02:34:02PM +0800, Jiqian Chen wrote: > diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c > index 2cec83e0b734..debf6ec6ddc7 100644 > @@ -1500,13 +1510,25 @@ static void pci_add_dm_done(libxl__egc *egc, > rc = ERROR_FAIL; >

Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-04-03 Thread George Dunlap
On Tue, Mar 19, 2024 at 3:39 AM Stefano Stabellini wrote: > > The main use of fixed width types, to me, is in interface structure > > definitions - between Xen and hardware / firmware, or in hypercall > > structures. I'm afraid I have a hard time seeing good uses outside of > > that. Even in

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Jan Beulich
On 03.04.2024 12:54, Oleksii wrote: > On Wed, 2024-04-03 at 12:28 +0200, Jan Beulich wrote: >> On 03.04.2024 12:19, Oleksii Kurochko wrote: >>> This patch disables unnecessary configs for two cases: >>> 1. By utilizing EXTRA_FIXED_RANDCONFIG for randconfig builds >>> (GitLab CI jobs). >>> 2. By

[PATCH] xen/include: move definition of ASM_INT() to xen/linkage.h

2024-04-03 Thread Juergen Gross
ASM_INT() is defined in arch/[arm|x86]/include/asm/asm_defns.h in exactly the same way. Instead of replicating this definition for riscv and ppc, move it to include/xen/linkage.h, where other arch agnostic definitions for assembler code are living already. Adapt the generation of assembler

Xen 4.19 release status tracking list [ April ]

2024-04-03 Thread Oleksii
Hello everyone, I would like to share with you a list for status tracking based on Xen ML and community members comments: *** Arm ***: * [PATCH v7 00/14] Arm cache coloring [ https://patchew.org/Xen/20240315105902.160047-1-carlo.non...@minervasys.tech/ ]: - new patch series version [v7]

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Daniel P. Smith
On 4/3/24 08:05, Jan Beulich wrote: On 03.04.2024 13:10, Daniel P. Smith wrote: On 4/3/24 02:16, Jan Beulich wrote: On 02.04.2024 19:06, Andrew Cooper wrote: The commit makes a claim without any kind of justification. Well, what does "have no business" leave open? Why does it not have any

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Daniel P. Smith
On 4/3/24 02:52, Jan Beulich wrote: On 03.04.2024 08:16, Jan Beulich wrote: On 02.04.2024 19:06, Andrew Cooper wrote: Whether to return information about a xen-owned evtchn is a matter of policy, and it's not acceptable to short circuit the XSM on the matter. I can certainly accept this as

Re: [PATCH v6 1/4] tools/init-xenstore-domain: Replace variable MB() usage

2024-04-03 Thread Anthony PERARD
On Wed, Mar 27, 2024 at 05:50:59PM -0400, Jason Andryuk wrote: > The local MB() & GB() macros will be replaced with a common > implementation, but those only work with constant values. Introduce a By the way, this is not true, the macro introduce in the following patch ("tools: Move MB/GB() to

Re: preparations for 4.17.4

2024-04-03 Thread Jan Beulich
On 03.04.2024 16:08, Andrew Cooper wrote: > On 02/04/2024 3:26 pm, Jan Beulich wrote: >> On 27.03.2024 13:33, Andrew Cooper wrote: >>> 5) Ucode scan stability  (For 4.18 only) >>> >>> Xen 4.18 had "x86/ucode: Refresh raw CPU policy after microcode load" in >>> it's .0 release, so should also gain:

text-tsx fails on Intel core 8th gen system

2024-04-03 Thread Marek Marczykowski-Górecki
Hi, I've noticed that tools/tests/tsx/test-tsx fails on a system with Intel Core i7-8750H. Specific error I get: [user@dom0 tsx]$ ./test-tsx TSX tests Got 16 CPUs Testing MSR_TSX_FORCE_ABORT consistency CPU0 val 0 Testing MSR_TSX_CTRL consistency Testing

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Jan Beulich
On 03.04.2024 13:50, Daniel P. Smith wrote: > On 4/3/24 02:52, Jan Beulich wrote: >> On 03.04.2024 08:16, Jan Beulich wrote: >>> On 02.04.2024 19:06, Andrew Cooper wrote: Whether to return information about a xen-owned evtchn is a matter of policy, and it's not acceptable to short

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Daniel P. Smith
On 4/3/24 07:54, Jan Beulich wrote: On 03.04.2024 13:50, Daniel P. Smith wrote: On 4/3/24 02:52, Jan Beulich wrote: On 03.04.2024 08:16, Jan Beulich wrote: On 02.04.2024 19:06, Andrew Cooper wrote: Whether to return information about a xen-owned evtchn is a matter of policy, and it's not

Re: preparations for 4.17.4

2024-04-03 Thread Andrew Cooper
On 02/04/2024 3:26 pm, Jan Beulich wrote: > On 27.03.2024 13:33, Andrew Cooper wrote: >> 1) livepatching of .rodata: >> >> 989556c6f8ca - xen/virtual-region: Rename the start/end fields >> ef969144a425 - xen/virtual-region: Include rodata pointers >> b083b1c393dc - x86/livepatch: Relax permissions

Re: [PATCH] xen/include: move definition of ASM_INT() to xen/linkage.h

2024-04-03 Thread Jan Beulich
On 03.04.2024 15:59, Andrew Cooper wrote: > On 03/04/2024 1:51 pm, Jan Beulich wrote: >> On 03.04.2024 14:03, Juergen Gross wrote: >>> ASM_INT() is defined in arch/[arm|x86]/include/asm/asm_defns.h in >>> exactly the same way. Instead of replicating this definition for riscv >>> and ppc, move it

Re: text-tsx fails on Intel core 8th gen system

2024-04-03 Thread Jan Beulich
On 03.04.2024 16:50, Marek Marczykowski-Górecki wrote: > Hi, > > I've noticed that tools/tests/tsx/test-tsx fails on a system with Intel > Core i7-8750H. Specific error I get: > > [user@dom0 tsx]$ ./test-tsx > TSX tests > Got 16 CPUs > Testing MSR_TSX_FORCE_ABORT consistency >

Re: [PATCH v6 2/4] tools: Move MB/GB() to common-macros.h

2024-04-03 Thread Anthony PERARD
On Wed, Mar 27, 2024 at 05:51:00PM -0400, Jason Andryuk wrote: > Consolidate to a single set of common macros for tools. > > MB() will gain another use in libelf, so this movement makes it > available. > > Requested-by: Jan Beulich > Signed-off-by: Jason Andryuk > Reviewed-by: Jan Beulich >

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Daniel P. Smith
On 4/2/24 13:06, Andrew Cooper wrote: The commit makes a claim without any kind of justification. The claim is false, and the commit broke lsevtchn in dom0. It is also quite obvious from XSM_TARGET that it has broken device model stubdoms too. Whether to return information about a xen-owned

Re: [PATCH] xen/include: move definition of ASM_INT() to xen/linkage.h

2024-04-03 Thread Andrew Cooper
On 03/04/2024 1:51 pm, Jan Beulich wrote: > On 03.04.2024 14:03, Juergen Gross wrote: >> ASM_INT() is defined in arch/[arm|x86]/include/asm/asm_defns.h in >> exactly the same way. Instead of replicating this definition for riscv >> and ppc, move it to include/xen/linkage.h, where other arch

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Juergen Gross
On 03.04.24 13:47, Jan Beulich wrote: On 03.04.2024 13:18, Juergen Gross wrote: On 03.04.24 12:54, Oleksii wrote: On Wed, 2024-04-03 at 12:28 +0200, Jan Beulich wrote: On 03.04.2024 12:19, Oleksii Kurochko wrote: This patch disables unnecessary configs for two cases: 1. By utilizing

Re: [XEN PATCH 1/7] xen/domctl: address a violation of MISRA C:2012 Rule 16.3

2024-04-03 Thread Jan Beulich
On 02.04.2024 09:22, Federico Serafini wrote: > Add break statement to address a violation of MISRA C:2012 Rule 16.3 > ("An unconditional `break' statement shall terminate every > switch-clause "). > > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich

Re: [PATCH v3 2/2] drivers/char: mark extra reserved device memory in memory map

2024-04-03 Thread Jan Beulich
On 27.03.2024 03:53, Marek Marczykowski-Górecki wrote: > The IOMMU driver checks if RMRR/IVMD are marked as reserved in memory > map. This should be true for addresses coming from the firmware, but > when extra pages used by Xen itself are included in the mapping, those > are taken from usable RAM

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Oleksii
On Wed, 2024-04-03 at 12:28 +0200, Jan Beulich wrote: > On 03.04.2024 12:19, Oleksii Kurochko wrote: > > This patch disables unnecessary configs for two cases: > > 1. By utilizing EXTRA_FIXED_RANDCONFIG for randconfig builds > > (GitLab CI jobs). > > 2. By using tiny64_defconfig for non-randconfig

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Daniel P. Smith
On 4/3/24 02:16, Jan Beulich wrote: On 02.04.2024 19:06, Andrew Cooper wrote: The commit makes a claim without any kind of justification. Well, what does "have no business" leave open? Why does it not have any business? Why should a domain that creates an event channel not be able to

Re: [XEN PATCH 3/7] xen/sched: address a violation of MISRA C:2012 Rule 16.3

2024-04-03 Thread Nicola Vetrini
On 2024-04-03 08:33, Jan Beulich wrote: On 02.04.2024 09:22, Federico Serafini wrote: Use pseudo-keyword fallthrough to meet the requirements to deviate MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No functional change. Signed-off-by:

[PATCH v7 04/19] xen: introduce generic non-atomic test_*bit()

2024-04-03 Thread Oleksii Kurochko
The patch introduces the following generic functions: * test_bit * generic__test_and_set_bit * generic__test_and_clear_bit * generic__test_and_change_bit Also, the patch introduces the following generics which are used by the functions mentioned above: * BITOP_BITS_PER_WORD * BITOP_MASK *

[PATCH v7 07/19] xen/riscv: introduce bitops.h

2024-04-03 Thread Oleksii Kurochko
Taken from Linux-6.4.0-rc1 Xen's bitops.h consists of several Linux's headers: * linux/arch/include/asm/bitops.h: * The following function were removed as they aren't used in Xen: * test_and_set_bit_lock * clear_bit_unlock * __clear_bit_unlock * The following functions

[PATCH v7 00/19] Enable build of full Xen for RISC-V

2024-04-03 Thread Oleksii Kurochko
This patch series performs all of the additions necessary to drop the build overrides for RISCV and enable the full Xen build. Except in cases where compatibile implementations already exist (e.g. atomic.h and bitops.h), the newly added definitions are simple. The patch series is based on the

[PATCH v7 15/19] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-04-03 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7: - update argument type of maddr_to_virt() function: unsigned long -> paddr_t - rename argument of PFN_ORDER(): pfn -> pg. - add Acked-by: Jan Beulich --- Changes in V6: - drop __virt_to_maddr() ( transform to macro )

[PATCH v7 09/19] xen/riscv: introduce io.h

2024-04-03 Thread Oleksii Kurochko
The header taken form Linux 6.4.0-rc1 and is based on arch/riscv/include/asm/mmio.h with the following changes: - drop forcing of endianess for read*(), write*() functions as no matter what CPU endianness, what endianness a particular device (and hence its MMIO region(s)) is using is entirely

[PATCH v7 10/19] xen/riscv: introduce atomic.h

2024-04-03 Thread Oleksii Kurochko
Initially the patch was introduced by Bobby, who takes the header from Linux kernel. The following changes were done on top of Bobby's changes: - atomic##prefix##_*xchg_*(atomic##prefix##_t *v, c_t n) were updated to use__*xchg_generic() - drop casts in write_atomic() as they are unnecessary

[PATCH v7 08/19] xen/riscv: introduce cmpxchg.h

2024-04-03 Thread Oleksii Kurochko
The header was taken from Linux kernl 6.4.0-rc1. Addionally, were updated: * add emulation of {cmp}xchg for 1/2 byte types using 32-bit atomic access. * replace tabs with spaces * replace __* variale with *__ * introduce generic version of xchg_* and cmpxchg_*. * drop

[PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Oleksii Kurochko
This patch disables unnecessary configs for two cases: 1. By utilizing EXTRA_FIXED_RANDCONFIG for randconfig builds (GitLab CI jobs). 2. By using tiny64_defconfig for non-randconfig builds. Only configs which lead to compilation issues were disabled. Signed-off-by: Oleksii Kurochko --- Changes

[PATCH v7 12/19] xen/riscv: add definition of __read_mostly

2024-04-03 Thread Oleksii Kurochko
The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - [PATCH] move

[PATCH v7 06/19] xen/bitops: put __ffs() into linux compatible header

2024-04-03 Thread Oleksii Kurochko
The mentioned macros exist only because of Linux compatible purpose. The patch defines __ffs() in terms of Xen bitops and it is safe to define in this way ( as __ffs() - 1 ) as considering that __ffs() was defined as __builtin_ctzl(x), which has undefined behavior when x=0, so it is assumed that

[PATCH v7 01/19] automation: introduce fixed randconfig for RISC-V

2024-04-03 Thread Oleksii Kurochko
This patch introduces the anchor riscv-fixed-randconfig, which includes all configurations that should be disabled for randconfig builds. Suggested-by: Stefano Stabellini Signed-off-by: Oleksii Kurochko Reviewed-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in V7: - Nothing

[PATCH v7 03/19] xen/riscv: introduce extenstion support check by compiler

2024-04-03 Thread Oleksii Kurochko
Currently, RISC-V requires two extensions: _zbb and _zihintpause. This patch introduces a compiler check to check if these extensions are supported. Additionally, it introduces the riscv/booting.txt file, which contains information about the extensions that should be supported by the platform.

[PATCH v7 11/19] xen/riscv: introduce monitor.h

2024-04-03 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V4-V7: - Nothing changed. Only rebase. --- Changes in V3: - new patch. --- xen/arch/riscv/include/asm/monitor.h | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 xen/arch/riscv/include/asm/monitor.h diff --git

[PATCH v7 05/19] xen/bitops: implement fls{l}() in common logic

2024-04-03 Thread Oleksii Kurochko
Return type was left 'int' because of the following compilation error: ./include/xen/kernel.h:18:21: error: comparison of distinct pointer types lacks a cast [-Werror] 18 | (void) (&_x == &_y);\ | ^~ common/page_alloc.c:1843:34: note:

[PATCH v7 19/19] xen/README: add compiler and binutils versions for RISC-V64

2024-04-03 Thread Oleksii Kurochko
This patch doesn't represent a strict lower bound for GCC and GNU Binutils; rather, these versions are specifically employed by the Xen RISC-V container and are anticipated to undergo continuous testing. Older GCC and GNU Binutils would work, but this is not a guarantee. While it is feasible to

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Juergen Gross
On 03.04.24 12:54, Oleksii wrote: On Wed, 2024-04-03 at 12:28 +0200, Jan Beulich wrote: On 03.04.2024 12:19, Oleksii Kurochko wrote: This patch disables unnecessary configs for two cases: 1. By utilizing EXTRA_FIXED_RANDCONFIG for randconfig builds (GitLab CI jobs). 2. By using

Re: [XEN PATCH 2/7] console: address a violation of MISRA C:2012 Rule 16.3

2024-04-03 Thread Jan Beulich
On 02.04.2024 09:22, Federico Serafini wrote: > Add break statement to address a violation of MISRA C:2012 Rule 16.3 > ("An unconditional `break' statement shall terminate every > switch-clause "). > > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich

Re: [XEN PATCH 4/7] xen/evtchn: address a violation of MISRA C:2012 Rule 16.3

2024-04-03 Thread Jan Beulich
On 02.04.2024 09:22, Federico Serafini wrote: > Add break statement to address a violation of MISRA C:2012 Rule 16.3 > ("An unconditional `break' statement shall terminate every > switch-clause "). > > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Jan Beulich
On 03.04.2024 08:16, Jan Beulich wrote: > On 02.04.2024 19:06, Andrew Cooper wrote: >> Whether to return information about a xen-owned evtchn is a matter of policy, >> and it's not acceptable to short circuit the XSM on the matter. > > I can certainly accept this as one possible view point. As in

Re: [XEN PATCH 7/7] vsprintf: address violations of MISRA C:2012 Rule 16.3

2024-04-03 Thread Federico Serafini
On 03/04/24 09:06, Jan Beulich wrote: On 02.04.2024 09:22, Federico Serafini wrote: MISRA C:2012 Rule 16.3 states: "An unconditional `break' statement shall terminate every switch-clause". Add break statement to address violations of the rule or add pseudo-keyword fallthrough to meet the

[PATCH v7 14/19] xen/riscv: add minimal stuff to page.h to build full Xen

2024-04-03 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V5-V7: - Nothing changed. Only rebase. --- Changes in V4: --- - Change message -> subject in "Changes in V3" - s/BUG/BUG_ON("...") - Do proper rebase ( pfn_to_paddr() and paddr_to_pfn() aren't removed ). --- Changes in V3:

[PATCH v7 18/19] xen/riscv: enable full Xen build

2024-04-03 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- Changes in V5-V7: - Nothing changed. Only rebase. --- Changes in V4: - drop stubs for irq_actor_none() and irq_actor_none() as common/irq.c is compiled now. - drop defintion of max_page in stubs.c as common/page_alloc.c is compiled

Re: [PATCH 1/2] xen/arm: Add i.MX UART early printk support

2024-04-03 Thread Michal Orzel
Hi Oleksandr, On 02/04/2024 14:05, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > Tested on i.MX 8M Mini only, but I guess, it should be > suitable for other i.MX8M* SoCs (those UART device tree nodes > contain "fsl,imx6q-uart" compatible string). Please use imperative mood

Re: [XEN PATCH 3/7] xen/sched: address a violation of MISRA C:2012 Rule 16.3

2024-04-03 Thread Jan Beulich
On 02.04.2024 09:22, Federico Serafini wrote: > Use pseudo-keyword fallthrough to meet the requirements to deviate > MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall > terminate every switch-clause"). > > No functional change. > > Signed-off-by: Federico Serafini > --- >

Re: [XEN PATCH 5/7] xen/sched: address a violation of MISRA C:2012 Rule 16.3

2024-04-03 Thread Federico Serafini
On 03/04/24 08:55, Jan Beulich wrote: On 02.04.2024 09:22, Federico Serafini wrote: Add break statement to address a violation of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause "). No functional change. Signed-off-by: Federico Serafini

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Jan Beulich
On 03.04.2024 13:18, Juergen Gross wrote: > On 03.04.24 12:54, Oleksii wrote: >> On Wed, 2024-04-03 at 12:28 +0200, Jan Beulich wrote: >>> On 03.04.2024 12:19, Oleksii Kurochko wrote: This patch disables unnecessary configs for two cases: 1. By utilizing EXTRA_FIXED_RANDCONFIG for

Re: [PATCH v6 7/8] xen/rwlock: raise the number of possible cpus

2024-04-03 Thread Jan Beulich
On 02.04.2024 17:29, Jürgen Groß wrote: > On 02.04.24 16:52, Jan Beulich wrote: >> On 27.03.2024 16:22, Juergen Gross wrote: >>> @@ -36,14 +36,21 @@ void queue_write_lock_slowpath(rwlock_t *lock); >>> >>> static inline bool _is_write_locked_by_me(unsigned int cnts) >>> { >>> -

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-04-03 Thread Jan Beulich
On 02.04.2024 19:06, Andrew Cooper wrote: > The commit makes a claim without any kind of justification. Well, what does "have no business" leave open? > The claim is false, and the commit broke lsevtchn in dom0. Or alternatively lsevtchn was doing something that was never meant to work (from

Re: [PATCH 2/3] drivers: serial: add Qualcomm GENI-based serial driver

2024-04-03 Thread Michal Orzel
On 02/04/2024 23:19, Volodymyr Babchuk wrote: > > > Hi Michal, > > Michal Orzel writes: > >> Hello, >> >> On 29/03/2024 01:08, Volodymyr Babchuk wrote: >>> >>> >>> Generic Interface (GENI) is a newer interface for low speed interfaces >>> like UART, I2C or SPI. This patch adds the simple

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Jan Beulich
On 03.04.2024 12:19, Oleksii Kurochko wrote: > This patch disables unnecessary configs for two cases: > 1. By utilizing EXTRA_FIXED_RANDCONFIG for randconfig builds (GitLab CI jobs). > 2. By using tiny64_defconfig for non-randconfig builds. > > Only configs which lead to compilation issues were

Re: [PATCH v7 03/19] xen/riscv: introduce extenstion support check by compiler

2024-04-03 Thread Jan Beulich
On 03.04.2024 12:19, Oleksii Kurochko wrote: > Currently, RISC-V requires two extensions: _zbb and _zihintpause. > > This patch introduces a compiler check to check if these extensions > are supported. > Additionally, it introduces the riscv/booting.txt file, which contains > information about

Re: [PATCH 4/4] xen/virtual-region: Drop setup_virtual_regions()

2024-04-03 Thread Oleksii
On Mon, 2024-03-18 at 13:49 +, Andrew Cooper wrote: > On 18/03/2024 1:29 pm, Jan Beulich wrote: > > On 18.03.2024 12:04, Andrew Cooper wrote: > > > --- a/xen/common/virtual_region.c > > > +++ b/xen/common/virtual_region.c > > > @@ -39,6 +39,11 @@ static struct virtual_region core = { > > >

[PATCH v7 13/19] xen/riscv: add required things to current.h

2024-04-03 Thread Oleksii Kurochko
Add minimal requied things to be able to build full Xen. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V5/V6/V7: - Nothing changed. Only rebase. --- Changes in V4: - BUG() was changed to BUG_ON("unimplemented"); - Change "xen/bug.h" to "xen/lib.h" as BUG_ON is defined

Re: [XEN PATCH 5/7] xen/sched: address a violation of MISRA C:2012 Rule 16.3

2024-04-03 Thread Jan Beulich
On 02.04.2024 09:22, Federico Serafini wrote: > Add break statement to address a violation of MISRA C:2012 Rule 16.3 > ("An unconditional `break' statement shall terminate every > switch-clause "). > > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich

Re: [XEN PATCH 7/7] vsprintf: address violations of MISRA C:2012 Rule 16.3

2024-04-03 Thread Jan Beulich
On 02.04.2024 09:22, Federico Serafini wrote: > MISRA C:2012 Rule 16.3 states: "An unconditional `break' statement > shall terminate every switch-clause". > > Add break statement to address violations of the rule or add > pseudo-keyword fallthrough to meet the requirements to deviate it. While

Re: [PATCH 3/3] arm: platform: qcom: add basic support SA8155P SoC

2024-04-03 Thread Michal Orzel
Hello, On 29/03/2024 01:08, Volodymyr Babchuk wrote: > > > Qualcomm SA8155P is the automotive variant of SM8150 aka Snapdragon > 855. > > This patch adds very basic support for the platform. We need to handle > Qualcomm-specific SMC to workaround quirk in the QCOM SCM driver in > the Linux

[PATCH v3 4/4] xen/memory, tools: Avoid hardcoding GUEST_MAGIC_BASE in init-dom0less

2024-04-03 Thread Henry Wang
Currently the GUEST_MAGIC_BASE in the init-dom0less application is hardcoded, which will lead to failures for 1:1 direct-mapped Dom0less DomUs. Instead of hardcoding the guest magic pages region, use the XEN_DOMCTL_get_mem_map domctl to get the start address of the guest magic pages region. Add

[PATCH v3 3/4] xen/arm: Find unallocated spaces for magic pages of direct-mapped domU

2024-04-03 Thread Henry Wang
For 1:1 direct-mapped dom0less DomUs, the magic pages should not clash with any RAM region. To find a proper region for guest magic pages, we can reuse the logic of finding domain extended regions. If the extended region is enabled, since the extended region banks are at least 64MB, carve out the

[PATCH v3 0/4] DOMCTL-based guest magic region allocation for 11 domUs

2024-04-03 Thread Henry Wang
An error message can seen from the init-dom0less application on direct-mapped 1:1 domains: ``` Allocating magic pages memory.c:238:d0v0 mfn 0x39000 doesn't belong to d1 Error on alloc magic pages ``` This is because populate_physmap() automatically assumes gfn == mfn for direct mapped domains.

[PATCH v3 2/4] xen/arm: Generalize the extended region finding logic

2024-04-03 Thread Henry Wang
Recently there are needs to find unallocated/used memory regions for different use cases at boot time, and the logic of finding extended regions can be reused for some of the new use cases. This commit therefore generalize the extended region finding logic. Firstly, extract the extended region

[PATCH v3 1/4] xen/domctl, tools: Introduce a new domctl to get guest memory map

2024-04-03 Thread Henry Wang
There are some use cases where the toolstack needs to know the guest memory map. For example, the toolstack helper application "init-dom0less" needs to know the guest magic page regions for 1:1 direct-mapped dom0less DomUs to allocate magic pages. To address such needs, add XEN_DOMCTL_get_mem_map

[PATCH v7 17/19] xen/riscv: add minimal amount of stubs to build full Xen

2024-04-03 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7: - Only rebase was done. --- Changes in V6: - update the commit in stubs.c around /* ... common/irq.c ... */ - add Acked-by: Jan Beulich --- Changes in V5: - drop unrelated changes - assert_failed("unimplmented...")

Re: [PATCH] docs/misra: add 13.6 to rules.rst

2024-04-03 Thread Stefano Stabellini
On Wed, 3 Apr 2024, Jan Beulich wrote: > On 03.04.2024 01:21, Stefano Stabellini wrote: > > As agreed during MISRA C meetings, add Rule 13.6 to rules.rst. > > > > Signed-off-by: Stefano Stabellini > > --- > > There was a request to expand the scope to also include alignof and > > typeof.

Re: [XEN PATCH 3/6] xen/arm: ffa: separate memory sharing routines

2024-04-03 Thread Stefano Stabellini
On Thu, 27 Mar 2024, Julien Grall wrote: > Hi Bertrand, > > On 27/03/2024 13:40, Bertrand Marquis wrote: > > Hi Jens, > > > > > On 25 Mar 2024, at 10:39, Jens Wiklander > > > wrote: > > > > > > Move memory sharing routines into a separate file for easier navigation > > > in the source code. >

[linux-linus test] 185228: tolerable FAIL - PUSHED

2024-04-03 Thread osstest service owner
flight 185228 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/185228/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185220 test-amd64-amd64-xl-qemut-win7-amd64

[linux-6.1 test] 185227: regressions - FAIL

2024-04-03 Thread osstest service owner
flight 185227 linux-6.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/185227/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-buildfail REGR. vs. 185167 Tests which did not

Re: text-tsx fails on Intel core 8th gen system

2024-04-03 Thread Marek Marczykowski-Górecki
On Wed, Apr 03, 2024 at 05:04:20PM +0200, Jan Beulich wrote: > On 03.04.2024 16:50, Marek Marczykowski-Górecki wrote: > > Hi, > > > > I've noticed that tools/tests/tsx/test-tsx fails on a system with Intel > > Core i7-8750H. Specific error I get: > > > > [user@dom0 tsx]$ ./test-tsx > >

Re: [PATCH v3 1/2] hw/xen: detect when running inside stubdomain

2024-04-03 Thread Anthony PERARD
On Wed, Mar 27, 2024 at 04:05:14AM +0100, Marek Marczykowski-Górecki wrote: > Introduce global xen_is_stubdomain variable when qemu is running inside > a stubdomain instead of dom0. This will be relevant for subsequent > patches, as few things like accessing PCI config space need to be done >

Re: text-tsx fails on Intel core 8th gen system

2024-04-03 Thread Andrew Cooper
On 03/04/2024 3:50 pm, Marek Marczykowski-Górecki wrote: > Hi, > > I've noticed that tools/tests/tsx/test-tsx fails on a system with Intel > Core i7-8750H. Specific error I get: > > [user@dom0 tsx]$ ./test-tsx > TSX tests > Got 16 CPUs > Testing MSR_TSX_FORCE_ABORT consistency >

[PATCH AUTOSEL 6.8 18/28] x86/xen: attempt to inflate the memory balloon on PVH

2024-04-03 Thread Sasha Levin
From: Roger Pau Monne [ Upstream commit 38620fc4e8934f1801c7811ef39a041914ac4c1d ] When running as PVH or HVM Linux will use holes in the memory map as scratch space to map grants, foreign domain pages and possibly miscellaneous other stuff. However the usage of such memory map holes for Xen

[PATCH AUTOSEL 6.6 13/20] x86/xen: attempt to inflate the memory balloon on PVH

2024-04-03 Thread Sasha Levin
From: Roger Pau Monne [ Upstream commit 38620fc4e8934f1801c7811ef39a041914ac4c1d ] When running as PVH or HVM Linux will use holes in the memory map as scratch space to map grants, foreign domain pages and possibly miscellaneous other stuff. However the usage of such memory map holes for Xen

[PATCH AUTOSEL 6.1 11/15] x86/xen: attempt to inflate the memory balloon on PVH

2024-04-03 Thread Sasha Levin
From: Roger Pau Monne [ Upstream commit 38620fc4e8934f1801c7811ef39a041914ac4c1d ] When running as PVH or HVM Linux will use holes in the memory map as scratch space to map grants, foreign domain pages and possibly miscellaneous other stuff. However the usage of such memory map holes for Xen

Re: [PATCH v3 2/2] xen: fix stubdom PCI addr

2024-04-03 Thread Anthony PERARD
On Wed, Mar 27, 2024 at 04:05:15AM +0100, Marek Marczykowski-Górecki wrote: > When running in a stubdomain, the config space access via sysfs needs to > use BDF as seen inside stubdomain (connected via xen-pcifront), which is > different from the real BDF. For other purposes (hypercall parameters

Re: [PATCH] x86: Address MISRA Rule 13.6

2024-04-03 Thread Federico Serafini
On 02/04/24 18:09, Andrew Cooper wrote: On 02/04/2024 5:06 pm, Jan Beulich wrote: On 02.04.2024 17:54, Andrew Cooper wrote: On 02/04/2024 4:46 pm, Jan Beulich wrote: On 02.04.2024 17:43, Andrew Cooper wrote: MISRA Rule 13.6 doesn't like having an expression in a sizeof() which potentially

[xen-unstable test] 185222: tolerable FAIL

2024-04-03 Thread osstest service owner
flight 185222 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185222/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185215

[PATCH v3] docs/misra: document the expected sizes of integer types

2024-04-03 Thread Stefano Stabellini
Xen makes assumptions about the size of integer types on the various architectures. Document these assumptions. Signed-off-by: Stefano Stabellini --- Changes in v3: - add links to System V, AAPCS32 and AAPCS64 --- docs/misra/C-language-toolchain.rst | 69 + 1 file

[xen-unstable test] 185229: tolerable FAIL - PUSHED

2024-04-03 Thread osstest service owner
flight 185229 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185229/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185222

[xen-unstable-smoke test] 185234: tolerable all pass - PUSHED

2024-04-03 Thread osstest service owner
flight 185234 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185234/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl