Re: [Xen-devel] [PATCH] migration, xen: Fix block image lock issue on live migration

2017-11-27 Thread Anthony PERARD
: > From: Anthony PERARD <anthony.per...@citrix.com> > > When doing a live migration of a Xen guest with libxl, the images for > block devices are locked by the original QEMU process, and this prevent > the QEMU at the destination to take the lock and the migration fail. > &g

Re: [Xen-devel] [PATCH v3 08/17] SUPPORT.md: Add x86-specific virtual hardware

2017-11-27 Thread Anthony PERARD
On Mon, Nov 27, 2017 at 04:30:36PM +, George Dunlap wrote: > On 11/27/2017 03:12 PM, Anthony PERARD wrote: > > On Wed, Nov 22, 2017 at 07:20:15PM +, George Dunlap wrote: > >> x86-specific virtual hardware provided by the hypervisor, toolstack, > >> or QEMU. >

Re: [Xen-devel] [PATCH] migration, xen: Fix block image lock issue on live migration

2017-11-29 Thread Anthony PERARD
On Wed, Nov 29, 2017 at 12:28:39PM +, Julien Grall wrote: > + Stefano > > On 11/27/2017 03:00 PM, Anthony PERARD wrote: > > Hi Julien, > > Hi Anthony, > > > > > Can I get a release-ack for this patch? > > > > This fix local live migration

Re: [Xen-devel] [PATCH v6 4/4] hw: convert XenInput keyboard to keycodemapdb

2017-12-13 Thread Anthony PERARD
P. Berrange <berra...@redhat.com> FYI, I think that is done by <20171103115631.15175-3-owen.sm...@citrix.com>. ([PATCH v5 2/4] xenfb: Use Input Handlers directly) -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https:

Re: [Xen-devel] [PATCH v6 1/4] hw: convert virtio-input-hid device to keycodemapdb

2017-12-13 Thread Anthony PERARD
ut-keymap.c > +++ b/ui/input-keymap.c > @@ -6,6 +6,7 @@ > #include "standard-headers/linux/input.h" > > #include "ui/input-keymap-linux-to-qcode.c" > +#include "ui/input-keymap-qcode-to-linux.c" > #include "ui/input-keymap-qcode-to-

Re: [Xen-devel] [PATCH v3 3/3] msi: Handle remappable format interrupt request

2017-12-11 Thread Anthony PERARD
pirq. This 'if' test excludes Intel-specific > + * remappable msi. > + */ > +#define MSI_ADDR_IF_MASK 0x0010 I don't think that is the right place for a define, they also exist outside of the context of the function. That define would be better at the top

Re: [Xen-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-12-11 Thread Anthony PERARD
b: activate input handlers for raw pointer devices The patch series looks good to me: Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 2/3] xen/pt: Pass the whole msi addr/data to Xen

2017-12-11 Thread Anthony PERARD
); Same here, this build against older version of Xen, but I don't think an older libxc (like from Xen 4.10) is going to correctly with this new arguments. > if (rc) { > -XEN_PT_ERR(d, "Unbinding of MSI%s failed. (err: %d, pirq: %d, > gvec: %#x)\n", > - is_msix ? "-X" : "", errno, pirq, gvec); > +XEN_PT_ERR(d, "Unbinding of MSI%s failed. (err: %d, pirq: %d, " > + "addr: %"PRIx64", data: %#x)\n", > + is_msix ? "-X" : "", errno, pirq, addr, data); > return rc; > } > } Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [OSSTEST RFC 06/16] Osstest/CentOS.pm: Introduce CentOS support, starting with kickstart_installcmdline_core

2017-12-06 Thread Anthony PERARD
This function will be use later to install CentOS on a host. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- Osstest/CentOS.pm | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 Osstest/CentOS.pm diff --git a/O

[Xen-devel] [OSSTEST RFC 04/16] TestSupport: In host_install_postboot, don't call update-rc.d on CentOS

2017-12-06 Thread Anthony PERARD
Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- Osstest/TestSupport.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 13e4360..b0e21bf 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupp

[Xen-devel] [OSSTEST RFC 03/16] Osstest/TestSupport: Add centos to package_install_cmd

2017-12-06 Thread Anthony PERARD
Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- Osstest/TestSupport.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 65324fb..13e4360 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -530,6

[Xen-devel] [OSSTEST RFC 01/16] JobDB-Standalone.tcl: Fix read-runvar

2017-12-06 Thread Anthony PERARD
AND job = $job AND name = $name } runvarinfo { se..." (procedure "jobdb::read-runvar" line 3) invoked from within "jobdb::read-runvar $flight $job all_host_os" (procedure "run-job" line 13) invoked from within "run-job $job&q

[Xen-devel] [OSSTEST RFC 07/16] Osstest/CentOS: kickstart_create to generate an autoinstall recipe

2017-12-06 Thread Anthony PERARD
Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- Osstest/CentOS.pm | 215 ++ 1 file changed, 215 insertions(+) diff --git a/Osstest/CentOS.pm b/Osstest/CentOS.pm index 33479b1..dbba354 100644 --- a/Osstest/CentOS.pm +++ b/O

[Xen-devel] [OSSTEST RFC 15/16] make-centos-flight: Create a flight with CentOS as dom0

2017-12-06 Thread Anthony PERARD
ere is no build jobs as the Xen packages been tested are built in the CentOS CBS. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- make-centos-flight | 524 + 1 file changed, 524 insertions(+) create mode 100755 make-centos-flight

[Xen-devel] [OSSTEST RFC 13/16] WORKAROUND: Osstest/TestSupport: Make target_reboot works with systemd

2017-12-06 Thread Anthony PERARD
On host running with systemd as init, doing `ssh host reboot` will result in ssh returning an error. This patch works around by not waiting for the reboot command to return. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- Osstest/TestSupport.pm | 3 ++- 1 file changed, 2 inse

[Xen-devel] [OSSTEST RFC 11/16] ts-centos-xen-pkg-install: Adjust daemons configuration

2017-12-06 Thread Anthony PERARD
Ajust configuration of xenconsoled and libvirtd. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- ts-centos-xen-pkg-install | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ts-centos-xen-pkg-install b/ts-centos-xen-pkg-install index e10456d..0327b72 100755 --

[Xen-devel] [OSSTEST RFC 16/16] Osstest/TestSupport: Handle qemu-img location on CentOS

2017-12-06 Thread Anthony PERARD
Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- Osstest/TestSupport.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 40a5c5a..c82ba96 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupp

[Xen-devel] [OSSTEST RFC 10/16] ts-centos-xen-pkg-install: Install of Xen package on CentOS

2017-12-06 Thread Anthony PERARD
Install candidate packages that have been built by CBS, the CentOS Community Build Service. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- ts-centos-xen-pkg-install | 79 +++ 1 file changed, 79 insertions(+) create mode 100755 ts-

[Xen-devel] [OSSTEST RFC 12/16] ts-centos-xen-pkg-install: Create bridge config

2017-12-06 Thread Anthony PERARD
Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- ts-centos-xen-pkg-install | 22 ++ 1 file changed, 22 insertions(+) diff --git a/ts-centos-xen-pkg-install b/ts-centos-xen-pkg-install index 0327b72..9a4dcdd 100755 --- a/ts-centos-xen-pkg-install +++ b/ts-

[Xen-devel] [OSSTEST RFC 14/16] sg-run-job: Select host install script based on all_host_os runvar

2017-12-06 Thread Anthony PERARD
This also select a different xen installation script. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- sg-run-job | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/sg-run-job b/sg-run-job index f6e8340..b324101 100755 --- a/sg-run-job +++ b/

[Xen-devel] [OSSTEST RFC 05/16] TestSupport: Adapt target_https_mitm_proxy_setup to CentOS

2017-12-06 Thread Anthony PERARD
The location for new certificates is different, and update-ca-certificates is Debian specific. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- Osstest/TestSupport.pm | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/Osstest/TestSupport.pm b/O

[Xen-devel] [OSSTEST RFC 09/16] CentOS: Setup osstest-confirm-booted.service

2017-12-06 Thread Anthony PERARD
is set as the new default. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- Osstest/CentOS.pm | 7 ++ .../systemd/system/osstest-confirm-booted.service | 28 ++ overlay-centos/etc/systemd/system/osstest.target

[Xen-devel] [OSSTEST RFC 08/16] ts-centos-host-install: Install CentOS on a host

2017-12-06 Thread Anthony PERARD
Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- ts-centos-host-install | 154 + 1 file changed, 154 insertions(+) create mode 100755 ts-centos-host-install diff --git a/ts-centos-host-install b/ts-centos-host-install new fil

Re: [Xen-devel] migration regression in xen-4.11 and qemu-2.11 and qcow2

2018-05-10 Thread Anthony PERARD
or snapshot db0c7dde021c29c2ae0d847d70fb7b59e02ea522 I'm not sure if that information is going to help, but that what I have for now about the lock of block images. -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] QEMU build fixes for Xen-4.11

2018-05-10 Thread Anthony PERARD
eprecated libusb_set_debug with libusb_set_option > https://git.qemu.org/?p=qemu.git;a=commit;h=9d8fa0df49af16a208fa961c2968fba4daffcc07 Regards, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/

Re: [Xen-devel] [PATCH v2 1/3] xen-hvm: create separate function for ioreq server initialization

2018-05-15 Thread Anthony PERARD
rix.com> Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 6/8] xen_backend: make the xen_feature_grant_copy flag private

2018-05-17 Thread Anthony PERARD
On Fri, May 04, 2018 at 08:26:05PM +0100, Paul Durrant wrote: > There is no longer any use of this flag outside of the xen_backend code. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com>

Re: [Xen-devel] [PATCH v3 5/8] xen_disk: remove use of grant map/unmap

2018-05-17 Thread Anthony PERARD
y: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-18 Thread Anthony PERARD
t; falling back to the previous mechanism if it is unavailable. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel mailing list Xen

Re: [Xen-devel] [PATCH v4 5/9] xen_backend: add an emulation of grant copy

2018-05-18 Thread Anthony PERARD
main_grant_refs() and memcpy() for those environments. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject

Re: [Xen-devel] [PATCH v4 1/9] xen: add a meaningful declaration of grant_copy_segment into xen_common.h

2018-05-18 Thread Anthony PERARD
> pre-4.8 compat area in xen_common.h, which allows xen_disk to be cleaned > up. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___

Re: [Xen-devel] [PATCH v4 2/9] xen_backend: add grant table helpers

2018-05-18 Thread Anthony PERARD
od in XenDevOps is invoked. This method is responsible for > mapping the shared ring. No prior method requires access to the grant table. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reviewed-by: Anthony PERARD <anthony.per..

Re: [Xen-devel] [PATCH v3 7/8] xen_disk: use a single entry iovec

2018-05-17 Thread Anthony PERARD
tructure can shrink significantly. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https:

Re: [Xen-devel] [PATCH v3 8/8] xen_disk: be consistent with use of xendev and blkdev->xendev

2018-05-17 Thread Anthony PERARD
> occasions modified those functions to use it consistently. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@l

Re: [Xen-devel] [PATCH v3 1/8] xen_backend: add grant table helpers

2018-05-16 Thread Anthony PERARD
od in XenDevOps is invoked. This method is responsible for > mapping the shared ring. No prior method requires access to the grant table. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > --- > Cc: Stefano Stabellini <sstabell...@kernel.org> > Cc: Antho

Re: [Xen-devel] [PATCH v3 3/8] xen: remove other open-coded use of libxengnttab

2018-05-16 Thread Anthony PERARD
netdev->xendev.dom, > - rxreq.gref, PROT_WRITE); > +page = xen_be_map_grant_refs(>xendev, , 1, > + PROT_WRITE); xen_be_map_grant_ref instead? With that fix: Acked-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 4/8] xen_backend: add an emulation of grant copy

2018-05-16 Thread Anthony PERARD
main_grant_refs() and memcpy() for those environments. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > --- The patch looks ok, but since patch 1 is going to be change, this one is going to need to be change as well. -- Anthony PERARD

Re: [Xen-devel] [PATCH v3 2/8] xen_disk: remove open-coded use of libxengnttab

2018-05-16 Thread Anthony PERARD
itialise method. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-15 Thread Anthony PERARD
hypercalls in Xen, leading to occasional > fun with Linux checkpatch.pl. In man errno, I have: ENOTSUP Operation not supported (POSIX.1-2001) EOPNOTSUPP Operation not supported on socket (POSIX.1-2001). ENOSYS Function not implemented (POSIX.1-2001). But I guess any of these would work. -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen-hvm: stop faking I/O to access PCI config space

2018-05-17 Thread Anthony PERARD
else { > +for (i = 0; i < req->count; i++) { > +uint32_t tmp = 0; > + > + read_phys_req_item(req->data, req, i, ); > +pci_host_config_write_common( > +xendev->pci_dev, r

Re: [Xen-devel] [PATCH] xen_pt: Present the size of 64 bit BARs correctly

2018-05-17 Thread Anthony PERARD
be incorrect. > > Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> > --- > hw/xen/xen_pt_config_init.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/

[Xen-devel] [PATCH for-4.11] Config.mk: Update QEMU to include build fixes

2018-05-18 Thread Anthony PERARD
This tag includes two build fixes: - dump: Fix build with newer gcc Fix build with GCC-8 - Fix libusb-1.0.22 deprecated libusb_set_debug with libusb_set_option Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> --- FYI, I've already ask with this mail: > QEMU build fixes for

Re: [Xen-devel] [PATCH v4] xen-hvm: stop faking I/O to access PCI config space

2018-05-18 Thread Anthony PERARD
G_SPACE_SIZE when Xen gains the ability to > emulate MCFG table accesses. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD ___ Xen-devel m

Re: [Xen-devel] [PATCH v2 3/3] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages

2018-05-15 Thread Anthony PERARD
EOPNOTSUPP; I think ENOSYS would be better. EOPNOTSUPP seems to be for sockets. > +return -1; Should this return NULL instead? That doesn't build on Xen 4.10 and earlier. > +} > + > #endif /* CONFIG_XEN_CTRL_INTERFACE_VERSION < 41100 */ > > #if CONFIG_XEN_CTRL_INTERFACE_VERSION < 41000 Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-15 Thread Anthony PERARD
On Fri, Jun 15, 2018 at 11:06:47AM +0100, Peter Maydell wrote: > On 5 June 2018 at 17:55, Anthony PERARD wrote: > > On Fri, Jun 01, 2018 at 06:59:10PM +0100, Peter Maydell wrote: > >> The xen pci_assign_dev_load_option_rom() currently creates a RAM

Re: [Xen-devel] [PATCH for-next 4/5] tools: load IPXE from standalone file

2018-06-04 Thread Anthony PERARD
nd argument is used at the address of the firmware to load. Here "ipxe" is an extra blob to load. -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 00/31] libxl: Enable save/restore/migration of a restricted QEMU + libxl__ev_qmp_*

2018-06-01 Thread Anthony PERARD
On Fri, Jun 01, 2018 at 03:36:49PM +0100, Anthony PERARD wrote: > The real meat in this patch series start with patch > "libxl_qmp_ev: Introduce libxl__ev_qmp_start() to connect to QMP" > which implement libxl__ev_qmp_* functions to turn the QMP client into > asynchronous

[Xen-devel] [PATCH v3 00/31] libxl: Enable save/restore/migration of a restricted QEMU + libxl__ev_qmp_*

2018-06-01 Thread Anthony PERARD
cted to the QMP socket. But libxl doesn't care about failure, and that just mean that `xl console` will not work and vnc will not have any password. save/restore of the same guest will works fine because libxl__ev_qmp_* will have an oportunity to disconnect from the socket before libxl__qmp_initializatio

[Xen-devel] [PATCH v3 03/31] libxl_qmp: Fix use of DEBUG_RECEIVED

2018-06-01 Thread Anthony PERARD
This patch fix complilation error with #define DEBUG_RECEIVED of the macro DEBUG_REPORT_RECEIVED. error: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 9 has type ‘ssize_t {aka long int}’ Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- Notes: New in RFC

[Xen-devel] [PATCH v3 09/31] libxl_qmp: Move struct sockaddr_un variable to qmp_open()

2018-06-01 Thread Anthony PERARD
This variable is only used once, no need to keep it in the handler. Also fix coding style (remove space after sizeof). And allow strncpy to use all the space in sun_path. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions

[Xen-devel] [PATCH v3 01/31] libxl_event: Fix DEBUG prints

2018-06-01 Thread Anthony PERARD
The libxl__log() call was missing the domid. The macro DBG is using LIBXL__LOG which rely on a "gc". Add a GC where needed. Signed-off-by: Anthony PERARD Reviewed-by: Wei Liu --- Notes: v3: - Add a commit message. New in RFC v2 tools/libxl/libxl_event.c | 8 ++

[Xen-devel] [PATCH v3 04/31] libxl_json: fix build with DEBUG_ANSWER

2018-06-01 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- tools/libxl/libxl_json.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c index 0823b8cfd2..dc93a88ef1 100644 --- a/tools/libxl/libxl_json.c +++ b/tools/libxl/libxl_json.c @@ -59,8 +59,8

[Xen-devel] [PATCH v3 08/31] libxl_qmp: Have QEMU save its state to a file descriptor

2018-06-01 Thread Anthony PERARD
In case QEMU have restricted access to the system, open the file for it, and QEMU will save its state to this file descritor. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git

[Xen-devel] [PATCH v3 26/31] libxl_qmp: Disable beautify for QMP generated cmd

2018-06-01 Thread Anthony PERARD
There is no need for it. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 302178c5f5..f44b313a5e 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl/libxl_qmp.c @@ -601,6

[Xen-devel] [PATCH v3 23/31] libxl_qmp_ev: Handle messages from QEMU

2018-06-01 Thread Anthony PERARD
This will handle messages received, and call callbacks registered via libxl__ev_qmp_register(). This also print error messages from QMP on behalf of the callback. Signed-off-by: Anthony PERARD --- Should we let callbacks print error messages themself? They already have the error class, which

[Xen-devel] [PATCH v3 18/31] libxl_json: libxl__json_object_to_json

2018-06-01 Thread Anthony PERARD
Allow to generate a JSON string from a libxl__json_object, usefull for debugging. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_internal.h | 3 +++ tools/libxl/libxl_json.c | 36 2 files changed, 39 insertions(+) diff --git a/tools/libxl

[Xen-devel] [PATCH v3 17/31] libxl_json: Enable yajl_allow_trailing_garbage

2018-06-01 Thread Anthony PERARD
an error. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_json.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_json.h b/tools/libxl/libxl_json.h index af26e7885d..260783bfde 100644 --- a/tools/libxl/libxl_json.h +++ b/tools/libxl/libxl_json.h

[Xen-devel] [PATCH v3 28/31] libxl_disk: Cut libxl_cdrom_insert into step

2018-06-01 Thread Anthony PERARD
This is to prepare libxl_cdrom_insert to be able to send commands to QEMU via the libxl__ev_qmp. The next patch is going to make use of it. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_disk.c | 195 +++ 1 file changed, 138 insertions(+), 57 deletions

[Xen-devel] [PATCH v3 21/31] libxl_qmp_ev: Handle write to socket

2018-06-01 Thread Anthony PERARD
The libxl__ev_qmp_* will now send commands to QEMU when the socket is ready for writes. Also stop pulling for POLLOUT events once the send queue is empty. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 48 + 1 file changed, 48 insertions

[Xen-devel] [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next.

2018-06-01 Thread Anthony PERARD
That buffer is only used locally, and never reuse accross different call of qmp_next. So remove it form the handler. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl

[Xen-devel] [PATCH v3 20/31] libxl_qmp: Introduce libxl__ev_qmp functions

2018-06-01 Thread Anthony PERARD
Calling libxl__ev_qmp_register() will prepare a command to be sent to QEMU and stash it in a queue to be sent later. The actual sent will be done in a separate patch. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_internal.h | 39 +++- tools/libxl/libxl_qmp.c

[Xen-devel] [PATCH v3 19/31] libxl_qmp_ev: Parse JSON input from QMP

2018-06-01 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 98 + 1 file changed, 98 insertions(+) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 48dc376307..e4441f76f4 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl

[Xen-devel] [PATCH v3 13/31] libxl_qmp: Separate QMP message generation from qmp_send_prepare

2018-06-01 Thread Anthony PERARD
This new function qmp_prepare_qmp_cmd() can be reuse later when introducing a different way to communicate with a QMP server, libxl__ev_qmp. Also, add the QMP end of command '\r\n' into the generated string. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 60

[Xen-devel] [PATCH v3 16/31] libxl_json: Allow partial parsing

2018-06-01 Thread Anthony PERARD
This set of function allow to parse a JSON string that is spread accross different memory location. This is usefull when a JSON string is received from a remote process, and in order to avoid using realloc, the message is recorded in multiple buffers. Signed-off-by: Anthony PERARD --- tools

[Xen-devel] [PATCH v3 14/31] libxl_qmp_ev: Introduce libxl__ev_qmp_start() to connect to QMP

2018-06-01 Thread Anthony PERARD
This is a first patch to implement libxl__ev_qmp, it only connect to the QMP socket of QEMU and register a callback that does nothing. Callback functions will be implemented in following patches. Signed-off-by: Anthony PERARD --- TODO: This would probably needs to have a list in CTX, with state

[Xen-devel] [PATCH v3 27/31] libxl_qmp: Implement libxl__qmp_insert_cdrom_ev

2018-06-01 Thread Anthony PERARD
, this is done in the next few patches. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_internal.h | 4 ++ tools/libxl/libxl_qmp.c | 102 +++ 2 files changed, 106 insertions(+) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h

[Xen-devel] [PATCH v3 30/31] libxl_dm: Pre-open QMP socket for QEMU

2018-06-01 Thread Anthony PERARD
strict will be available in QEMU 3.0. Signed-off-by: Anthony PERARD --- Notes: We may want to set cloexec on the socket up to the forking point. Because if the socket stay open in a random process, libxl will not detected right away if QEMU as failed to start. On the other hand, we can rely on ti

[Xen-devel] [PATCH v3 31/31] libxl: QEMU startup sync based on QMP

2018-06-01 Thread Anthony PERARD
This is only activated when dm_restrict=1, as explained in the previous patch "libxl_dm: Pre-open QMP socket for QEMU" Signed-off-by: Anthony PERARD --- tools/libxl/libxl_dm.c | 7 ++ tools/libxl/libxl_exec.c | 44 tools/libxl/libxl_

[Xen-devel] [PATCH v3 29/31] libxl_disk: Have libxl_cdrom_insert use libxl__ev_qmp

2018-06-01 Thread Anthony PERARD
So when QEMU is involve, the operation will be asynchrone and will finish later. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_disk.c | 55 +++- 1 file changed, 49 insertions(+), 6 deletions(-) diff --git a/tools/libxl/libxl_disk.c b/tools/libxl

[Xen-devel] [PATCH v3 22/31] libxl_qmp: Simplify qmp_response_type() prototype

2018-06-01 Thread Anthony PERARD
Remove the libxl__qmp_handler* argument so the function can be reused later in a different context. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index

[Xen-devel] [PATCH v3 25/31] libxl_qmp_ev: Disconnect QMP when no more events

2018-06-01 Thread Anthony PERARD
This will check if there is more libxl_ev_qmp in flight, and if not, just disconnect from the QMP socket. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index

[Xen-devel] [PATCH v3 11/31] libxl_qmp: Remove unused yajl_ctx form handler

2018-06-01 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 4da84dcf16..1184ca823f 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl/libxl_qmp.c @@ -111,8 +111,6 @@ struct

[Xen-devel] [PATCH v3 12/31] libxl_json: constify libxl__json_object_to_yajl_gen arguments

2018-06-01 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- tools/libxl/libxl_internal.h | 2 +- tools/libxl/libxl_json.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index c582894589..12bbfe4a63 100644 --- a/tools/libxl

[Xen-devel] [PATCH v3 15/31] libxl_qmp_ev: Implement fd callback and read data

2018-06-01 Thread Anthony PERARD
First step into taking care of the input from QEMU's QMP socket. For now, we read data and store them in buffers. Parsing of the data will be done in the following patches. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 113 1 file changed

[Xen-devel] [PATCH v3 24/31] libxl_qmp_ev: Respond to QMP greeting

2018-06-01 Thread Anthony PERARD
Slight change in the infrastructure to allow to send a buffer before any command that would already been prepared. qmp_capabilities needs to be the first command sent. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 87 ++--- 1 file changed, 82

[Xen-devel] [PATCH v3 02/31] libxl_qmp: Documentation of the logic of the QMP client

2018-06-01 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- Notes: v3: - Add documentation of the qmp_callback_t type. New in RFC v2 tools/libxl/libxl_qmp.c | 42 + 1 file changed, 42 insertions(+) diff --git a/tools/libxl/libxl_qmp.c b/tools

[Xen-devel] [PATCH v3 05/31] libxl_qmp: Move the buffer realloc to the same scope level as read

2018-06-01 Thread Anthony PERARD
to happen as the receive buffer is very large. And receiving two messages in a row is unlikely. In the current case, this could be an event and a response to a command. Signed-off-by: Anthony PERARD --- Notes: New in RFC v2 tools/libxl/libxl_qmp.c | 31 --- 1 file

[Xen-devel] [PATCH v3 06/31] libxl_qmp: Add a warning to not trust QEMU

2018-06-01 Thread Anthony PERARD
... even if it is not the case for the current code. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 58ecd4baf3..8b3ed94868 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools

[Xen-devel] [PATCH v3 07/31] libxl_qmp: Learned to send FD through QMP to QEMU

2018-06-01 Thread Anthony PERARD
Adding the ability to send a file descriptor from libxl to QEMU via the QMP interface. This will be use with the "add-fd" QMP command. Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- tools/libxl/libxl_qmp.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletion

Re: [Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

2018-06-05 Thread Anthony PERARD
of a sweep through for code using > the _nomigrate versions of functions. That patch looks fine, and seams fine after hacking my way into testing the change. Acked-by: Anthony PERARD Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] [OSSTEST PATCH 3/3] mfi-*: Set appropriate PropMinVer:XenMin: hostflags, to honour XenMin property

2018-06-06 Thread Anthony PERARD
case "$xenbranch" in > + xen-[0-9]*-testing) I don't think that's going to work, xenbranch should contain string like "xen-4.3-testing". You want: xen-[0-9.]*-testing) -- Anthony PERARD ___ Xen-devel mail

Re: [Xen-devel] [PATCH for-next 5/5] tools: provide --with-system-ipxe

2018-06-04 Thread Anthony PERARD
nk abrove, $withval will be "yes" and this will result with IPXE_PATH=yes I don't know if you want to look at that, since you're introducing a new one. -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

2018-06-04 Thread Anthony PERARD
) { > > You don't need to test if the guest is HVM anymore. You only need to > know if QEMU upstream is running. > > Anthony, please check if I've said anything wrong. I think the patch is fine. The resume side is not needed for PV because that only resume emulation, and qemu start with emulation running, but it is armless to call the command. Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 13/31] libxl_qmp: Separate QMP message generation from qmp_send_prepare

2018-06-27 Thread Anthony PERARD
On Wed, Jun 27, 2018 at 03:45:33PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v3 13/31] libxl_qmp: Separate QMP message > generation from qmp_send_prepare"): > > This new function qmp_prepare_qmp_cmd() can be reuse later when > > introducing a

Re: [Xen-devel] [PATCH v3 07/31] libxl_qmp: Learned to send FD through QMP to QEMU

2018-06-27 Thread Anthony PERARD
On Wed, Jun 27, 2018 at 03:26:51PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v3 07/31] libxl_qmp: Learned to send FD > through QMP to QEMU"): > > Adding the ability to send a file descriptor from libxl to QEMU via the > > QMP interface. This will

Re: [Xen-devel] [PATCH v3 09/31] libxl_qmp: Move struct sockaddr_un variable to qmp_open()

2018-06-27 Thread Anthony PERARD
On Wed, Jun 27, 2018 at 03:31:21PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v3 09/31] libxl_qmp: Move struct sockaddr_un > variable to qmp_open()"): > ... > > And allow strncpy to use all the space in sun_path. > > I wasn't able to see in the dif

Re: [Xen-devel] [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next.

2018-06-27 Thread Anthony PERARD
On Wed, Jun 27, 2018 at 03:32:32PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v3 10/31] libxl_qmp: Move buffers to the stack > of qmp_next."): > > That buffer is only used locally, and never reuse accross different call > > of qmp_next. So remove it fo

[Xen-devel] [PATCH v3.1] libxl: Design of an async API to issue QMP commands to QEMU

2018-07-03 Thread Anthony PERARD
All the functions will be implemented in later patches. Signed-off-by: Anthony PERARD --- What do you think of this design? This is the same as in my patch series with new names (to avoid confusion with libxl___ev_*) and documentation. I'll write something as well for the internal

Re: [Xen-devel] [PATCH] xen/hvm: correct reporting of modified memory under physmap during migration

2018-05-02 Thread Anthony PERARD
RAM. > > We need to make a translation for this address into PFN using > physmap. Since there is no way to access physmap properly inside > xen_hvm_modified_memory() let's make it a global structure. > > Signed-off-by: Igor Druzhinin <igor.druzhi...@citrix.com> A

Re: [Xen-devel] [PATCH 0/4] block/xen_disk: legacy code removal and cleanup

2018-05-02 Thread Anthony PERARD
that it is too soon to remove the compatibility code from qemu. Regards, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 0/4] block/xen_disk: legacy code removal and cleanup

2018-05-03 Thread Anthony PERARD
On Wed, May 02, 2018 at 05:03:09PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > > Sent: 02 May 2018 16:58 > > To: Paul Durrant <paul.durr...@citrix.com> > > Cc: xen-devel@lists.xenproj

Re: [Xen-devel] [PATCH v2 5/6] xen: Add only xen-sysdev to dynamic sysbus device list

2018-01-05 Thread Anthony PERARD
On Sat, Nov 25, 2017 at 01:16:09PM -0200, Eduardo Habkost wrote: > There's no need to make the machine allow every possible sysbus > device. We can now just add xen-sysdev to the allowed list. > > Cc: Stefano Stabellini <sstabell...@kernel.org> > Cc: Anthony Perard <a

Re: [Xen-devel] PCI Device Subtree Change from Traditional to Upstream

2018-01-25 Thread Anthony PERARD
On Thu, Jan 25, 2018 at 05:54:36PM +, George Dunlap wrote: > On 01/04/2018 12:52 PM, Anthony PERARD wrote: > > From: Anthony PERARD <anthony.per...@citrix.com> > > Subject: [PATCH] libxl_dm: Explicitly put xen-platform device on PCI slot 3 > > > > In ord

Re: [Xen-devel] [Xen-users] xen_pt_region_update: Error: create new mem mapping failed! (err: 22)

2018-01-25 Thread Anthony PERARD
=0x402,chardev=debugcon', ] (Feel free to change the path.) Thanks, -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] Slow HVM boot time, was "HVM boot time optimization"

2018-02-08 Thread Anthony PERARD
isremember how it > works. My understanding is direct kernel boot jumps straight to kernel > entry point without going through firmware. > > If this is direct kernel boot why is seabios involved? seabios is the one to load the kernel into memory and start it. -- Anthony PERARD _

Re: [Xen-devel] qemu-xen fails to build in staging

2018-02-07 Thread Anthony PERARD
db is likely to be required. > ___ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel -- Anthony PERARD ___ Xen-devel mailing li

Re: [Xen-devel] qemu-xen fails to build in staging

2018-02-07 Thread Anthony PERARD
On Wed, Feb 07, 2018 at 02:44:05PM +, Anthony PERARD wrote: > On Wed, Feb 07, 2018 at 01:40:04PM +0100, Olaf Hering wrote: > > Am Wed, 7 Feb 2018 11:13:22 +0100 > > schrieb Olaf Hering <o...@aepfle.de>: > > > > > Yes, it looks like qemu has now sub

Re: [Xen-devel] PCI Device Subtree Change from Traditional to Upstream

2018-01-03 Thread Anthony PERARD
ws to treat these devices as the same? A > patch-based solution would be acceptable to me if there is one, but I > don't understand the code well enough to create my own solution. Hi Kevin, I've got a patch to QEMU that seems to do the trick: From: Anthony PERARD <anthony.per...@citrix.com

Re: [Xen-devel] PCI Device Subtree Change from Traditional to Upstream

2018-01-04 Thread Anthony PERARD
On Wed, Jan 03, 2018 at 05:10:54PM -0600, Kevin Stange wrote: > On 01/03/2018 11:57 AM, Anthony PERARD wrote: > > On Wed, Dec 20, 2017 at 11:40:03AM -0600, Kevin Stange wrote: > >> Hi, > >> > >> I've been working on transitioning a number of Windows g

Re: [Xen-devel] [PATCH v4 12/32] libxl: Design of an async API to issue QMP commands to QEMUç

2018-08-03 Thread Anthony PERARD
On Thu, Aug 02, 2018 at 11:01:43AM +0200, Roger Pau Monné wrote: > On Fri, Jul 27, 2018 at 03:05:54PM +0100, Anthony PERARD wrote: > > All the functions will be implemented in later patches. > > > > This patch includes the API that libxl can use to send QMP commands to >

  1   2   3   4   5   6   7   8   9   10   >