Re: [Xen-devel] [PATCH] tools/ocaml/libs/xc fix gcc-8 format-truncation warning

> static void Noreturn failwith_xc(xc_interface *xch) > { > - char error_str[1028]; > + char error_str[XC_MAX_ERROR_MSG_LEN + 6]; > if (xch) { > const xc_error *error = xc_get_last_error(xch); > if (error->code == XC_ERROR_NONE) > --

Re: [Xen-devel] [PATCH for-4.11 0/2] xenstore: reduce use of unsafe conversions

As we recently found out in another project with C bindings, problems stemming from interaction with the OCaml garbage collector can be very rare and very hard to find. So I appreciate to get this right and Marcello (who is sitting next to me) has the most experience with this in our group. But

Re: [Xen-devel] [PATCH RFC] ocaml: Fix compile with ocaml 4.06, use unsafe strings

> On 26. Jan 2018, at 09:09, M A Young wrote: > > On Fri, 26 Jan 2018, John Thomson wrote: > >> Use autoconf to test if ocaml version >= 4.02 >> If so, use -unsafe-string for ocamlopt and ocamlc >> >> Bytes & safe-string were introduced in ocaml 4.02 (2015-07-27) >>

Re: [Xen-devel] [PATCH RFC] ocaml: Fix compile with ocaml 4.06, use unsafe strings

> On 26. Jan 2018, at 11:43, Wei Liu <wei.l...@citrix.com> wrote: > > On Fri, Jan 26, 2018 at 09:29:20AM +0000, Christian Lindig wrote: >> >> >>> On 26. Jan 2018, at 09:09, M A Young <m.a.yo...@durham.ac.uk> wrote: >>> >>> On

Re: [Xen-devel] [PATCH RFC] ocaml: Fix compile with ocaml 4.06, use unsafe strings

> On 26. Jan 2018, at 12:00, Wei Liu <wei.l...@citrix.com> wrote: > >> >> Reviewed-by: Christian Lindig <christian.lin...@citrix.com> >> > > Taking the above into consideration, does this tag still stand? Thanks for the clarification. My tag stil

Re: [Xen-devel] [PATCH 1/2] tools/ocaml: Drop coredump infrastructure

son <ian.jack...@eu.citrix.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Christian Lindig <christian.lin...@citrix.com> > --- > tools/ocaml/libs/xc/xenctrl.ml | 86 - > tools/ocaml/libs/xc/xenctrl.mli | 16 --- &g

Re: [Xen-devel] [PATCH 1/2] tools/ocaml: Drop coredump infrastructure

> On 25. Jan 2018, at 19:50, Andrew Cooper <andrew.coop...@citrix.com> wrote: > > On 25/01/18 19:47, Christian Lindig wrote: >> >>> On 19. Jan 2018, at 19:19, Andrew Cooper <andrew.coop...@citrix.com> wrote: >>> >>> It is unused, and uses

Re: [Xen-devel] [PATCH RFC] ocaml: Fix compile with ocaml 4.06, use unsafe strings

> On 28. Jan 2018, at 23:44, Michael Young wrote: > >> >> I do not know if caml-stubdom uses any of these files, but it seems to use >> ocaml-3.11.0? >>

Re: [Xen-devel] [PATCH 2/2] update the minimal ocaml version to 4.02

)]) > ocamltools="n" > ], [ > - AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [3.09.3], [ > +AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [4.02.0], [ > AS_IF([test "x$enable_ocamltools" = "xyes"], [ > AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not > supported])]) > ocamltools="n" > -- > 2.14.3 Acked-by: Christian Lindig <christian.lin...@citrix.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

> On 8. Feb 2018, at 18:24, Wei Liu wrote: > > Christian, do you have any idea when you can look into fixing the > safe-string patch? Sorry, I can’t make a promise because of my other obligations. I do wonder, though: this patch did not come out of nowhere but supposedly

Re: [Xen-devel] [PATCH 2/2] ocaml/libs/xb: don't generate *.mli automatically

t = { > + tid : int; > + rid : int; > + ty : Op.operation; > + len : int; > + buf : Buffer.t; > +} > +external header_size : unit -> int = "stub_header_size" > +external header_of_string_internal : string -> int * int * int * int > + = "stub_header_of_string" > +val xenstore_payload_max : int > +val of_string : string -> pkt > +val append : pkt -> string -> int -> unit > +val to_complete : pkt -> int > -- > 2.11.0 > Acked-by: Christian Lindig <christian.lin...@citrix.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/2] ocaml/xb: update xb.mli in accordance with df1e4c6e7f8

ackend_fd -> 'a -> string -> int -> int > +val write_fd : backend_fd -> 'a -> bytes -> int -> int > val write_mmap : backend_mmap -> 'a -> string -> int -> int > val write : t -> string -> int -> int > val output : t ->

Re: [Xen-devel] [PATCH] tools: fix python shebangs to use /usr/bin/env

> On 2 Aug 2018, at 10:05, Roger Pau Monne wrote: > > The path to the python binary can be different from /usr/bin/python > depending on the distro/OS. > > Signed-off-by: Roger Pau Monné -- Acked-by: Christian Lindig ___ Xen-

Re: [Xen-devel] [PATCH v2 00/12] Improvements to domain creation

On 13/08/18 11:00, Andrew Cooper wrote: This series can be found in git form here: http://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h=refs/heads/xen-create-v1 Is this the correct URL? The subject says v2 but this is branch v1. Looking over the OCaml-related patches, I

Re: [Xen-devel] [PATCH v2 2/2] ocaml: remove undefined behaviour in systemd_stubs.c

as a signature of unit -> unit, we simply change > the return value to Val_unit. > > Signed-off-by: Wei Liu > --- > Cc: Christian Lindig > Cc: David Scott > > See: https://gitlab.com/liuw/xen/-/jobs/83628833 > --- > tools/ocaml/xenstored/systemd_stubs.c

Re: [Xen-devel] [PATCH 2/2] ocaml: remove undefined behaviour in systemd_stubs.c

> On 23 Jul 2018, at 10:52, Wei Liu wrote: > > On Mon, Jul 23, 2018 at 10:47:04AM +0100, Andrew Cooper wrote: >> On 23/07/18 10:30, Wei Liu wrote: >>> Clang complains: >>> >>> systemd_stubs.c:51:8: error: shifting a negative signed value is undefined >>> [-Werror,-Wshift-negative-value] >>>

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

The problem with the old patch is illustrated by the following section from the old patch for tools/ocaml/xenstored/utils.ml @@ -85,7 +85,7 @@ let create_unix_socket name =  let read_file_single_integer filename =     let fd = Unix.openfile filename [ Unix.O_RDONLY ] 0o640 in     let buf

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

ml/xenstored/stdext.ml | 2 +- tools/ocaml/xenstored/utils.ml | 20 ++-- 5 files changed, 45 insertions(+), 43 deletions(-) Reviewed-by: Christian Lindig<christian.lin...@citrix.com> This patch is good to go. One caveat, though: the conversion between bytes and strings

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

he previous patch which compiled but lead to lock up at run time? I briefly tried your patch and can confirm that it compiles and looks clean except for two trailing spaces. — Christian Acked-by: Christian Lindig <christian.lin...@citrix.com> _

Re: [Xen-devel] [PATCH 1/1] tools: reduce copies b/w ocaml Strings and Bytes

fe to use the unsafe functions and prevent a copy. This patch updates the code to use the unsafe conversions where possible. Signed-off-by: Marcello Seri <marcello.s...@citrix.com> Reviewed-by: Christian Lindig <christian.lin...@citrix.com> --- tools/ocaml/libs/xb/xb.ml

Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

> On 19. Mar 2018, at 19:13, Andrew Cooper wrote: > > + max_grant_frames: int32; > + max_maptrack_frames: int32; As part of: > +type domctl_create_config = > +{ > + ssidref: int32; > + handle: string; > + flags: domain_create_flag list; >

Re: [Xen-devel] [PATCH 12/20] xen/domctl: Merge max_vcpus into createdomain

onstruction. > > For the python stubs, extend the domain_create keyword list to take a > max_vcpus parameter, in lieu of deleting the pyxc_domain_max_vcpus function. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Acked-by: Christian Lindig <christian.lin...@citrix.com

Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain

ing a plain int. > > ~Andrew Acked-by: Christian Lindig <christian.lin...@citrix.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 10/20] xen/domctl: Merge set_max_evtchn into createdomain

e, and should be part of createdomain, rather than > editable after the fact. > > Drop XEN_DOMCTL_set_max_evtchn completely (including XSM hooks and libxc > wrappers), and retain the functionality in XEN_DOMCTL_createdomain. Acked-by: Christian Li

Re: [Xen-devel] [PATCH 06/20] tools/ocaml: Drop domain_create_flag_table[]

> On 19. Mar 2018, at 19:13, Andrew Cooper <andrew.coop...@citrix.com> wrote: > > This is a logarithm in disguise. Update the logic to match how > x86_arch_emulation_flags works in c/s 9d683b5e37 and b38d96f596. Acked-by: Christian Lindig <christ

Re: [Xen-devel] [PATCH 09/20] tools: Rework xc_domain_create() to take a full xen_domctl_createdomain

in the common part of the structure (flags s3_integrity and > oos_off specifically). > > No practical change in behaviour. Acked-by: Christian Lindig <christian.lin...@citrix.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 08/20] tools/ocaml: Pass a full domctl_create_config into stub_xc_domain_create()

> On 19. Mar 2018, at 19:13, Andrew Cooper <andrew.coop...@citrix.com> wrote: > > The underlying C function is about to make the same change, and the structure > is going to gain extra fields. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com&g

Re: [Xen-devel] [PATCH] tools/ocaml: Release the global lock before invoking block syscalls

xeneventchn_stubs.c | 30 +-- > 1 file changed, 28 insertions(+), 2 deletions(-) Acked-by: Christian Lindig From an OCaml point of view this is looking good. But I would like to hear from developers understanding event channels that this is inde

[Xen-devel] RFC building tools/ocaml as Opam packages

The tools/ocaml source tree is deeply interwoven with with how Xen is built. To explore what it would look like as an independent OCaml project I have created https://github.com/lindig/xen-ocaml-tools/ which builds the Xen bindings and xenstored against libraries already installed on a

[Xen-devel] [PATCH v2 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

This patch i updated: * set the global handle to None * updated documentation ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

is opened upon first usage and kept open. This handle can be obtained by clients using new functions get_handle() and close_handle(). The main motivation of re-introducing with_intf is that otherwise clients will have to implement this functionality individually. Signed-off-by: Christian Lindig

[Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

The type of Xsraw.sync is made more precise: from val sync : (Xenbus.Xb.t -> 'a) -> con -> string to val sync : (Xenbus.Xb.t -> unit) -> con -> string The first argument is enforced to return unit rather than a value that is not used anyway. Signed-off-by: Christian Lindig

Re: [Xen-devel] [PATCH v2 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper [and 1 more messages]

On 31/10/18 15:41, Ian Jackson wrote: this needs a stronger warning against anyone ever calling it, or a clearer explanation of the consquences (whose scope is very broad). The consequence is that the global handle is closed but it would be opened again if one called with_intf again. So I'm

Re: [Xen-devel] [PATCH v2 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper [and 1 more messages]

On 31/10/18 16:01, Ian Jackson wrote: IMO the bug is that spong calls close_handle which has a distant destructive action, without being able to know that it is safe to do so. I will add add more words or caution. Thanks for pointing it out. -- C

[Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

is opened upon first usage and kept open. This handle can be obtained by clients using new functions get_handle() and close_handle(). The main motivation of re-introducing with_intf is that otherwise clients will have to implement this functionality individually. Signed-off-by: Christian Lindig

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

> On 30 Oct 2018, at 16:50, Ian Jackson wrote: > > I'm not much of an ocaml programmer but this seems like it has no > overall functional change ? > > I take it that ignore is the trivial function with type ('a -> unit). That is correct. Except that types now reflect more accurately what is

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

> On 30 Oct 2018, at 16:48, Ian Jackson wrote: > > I think it would be better to have close_handle set handle to None, > and write in the docs that it is forbidden to call close_handle within > with_intf. You are right - close_handle should set the handle to None in addition. > For that

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

> On 30 Oct 2018, at 17:01, Ian Jackson wrote: > > Well, yes, but who would ever call it ? It's not safe to use except > at the toplevel (whatever that means, but probably outside any > with_intf) because elsewhere you don't know whose work you're > sabotaging. > > Which reminds me: why do

[Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

is opened upon first usage and kept open. This handle can be obtained by clients using new functions get_handle() and close_handle(). The main motivation of re-introducing with_intf is that otherwise clients will have to implement this functionality individually. Signed-off-by: Christian Lindig

[Xen-devel] [PATCH 1/1] tools/ocaml: cleanup to reduce compiler warnings

with an underscore (warning 32) This commit does not include changes to fix compiler warnings 52 (matching against strings in exceptions). These changes have no impact on functionality. Signed-off-by: Christian Lindig --- tools/ocaml/libs/xb/xb.ml| 10 +++--- tools/ocaml/test/dmesg.ml

Re: [Xen-devel] [PATCH 0/3] tools/ocaml: Assorted improvements

re-open a xenctrl handle for every domain introduction > tools/ocaml: Delete the Xenctrl.with_intf wrapper Making xc a global handle that is opened once is IMHO an improvement rather than threading it as a parameter through the call hierarchy. --

Re: [Xen-devel] [PATCH] tools/ocaml: Add OCaml binding of virq bind

> Reviewed-by: Andrew Cooper (forwarding my > internal review of this patch) There is a discussion about caml_{leave,enter}_blocking_section required for this to work in a thread context that is not yet addressed in the patch. Acked-by: Christian Lindig

Re: [Xen-devel] [PATCH] tools/ocaml: Add OCaml binding of virq bind

> On 27 Sep 2018, at 11:15, Andrew Cooper wrote: > > On 27/09/18 11:11, Christian Lindig wrote: >> >>> On 27 Sep 2018, at 09:59, Andrew Cooper wrote: >>> >>> On 27/09/18 08:53, Yang Qian wrote: >>>> 1. Add a common bind virq funct

Re: [Xen-devel] [PATCH 4/4] tools/ocaml: make python scripts 2 and 3 compatible

> On 1 Apr 2019, at 11:32, Wei Liu wrote: > > 1. Explicitly import reduce because that's required in 3. > 2. Change print to function. > 3. Eliminate invocations of has_key. > > Signed-off-by: M A Young > Signed-off-by: Wei Liu Ac

[Xen-devel] [PATCH 1/1] tools/ocaml: Dup2 /dev/null to stdin in daemonize()

Don't close stdin in daemonize() but dup2 /dev/null instead. This avoids fd 0 being reused and potentially written to. Signed-off-by: Christian Lindig --- tools/ocaml/xenstored/stdext.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/xenstored/stdext.ml b

Re: [Xen-devel] [PATCH 2/2] xen: Drop XEN_DOMCTL_{get, set}_machine_address_size

t when 5.4 was > released in 2009. > > Signed-off-by: Andrew Cooper > --- tools/ocaml/libs/xc/xenctrl.ml | 5 - tools/ocaml/libs/xc/xenctrl.mli | 5 - tools/ocaml/libs/xc/xenctrl_stubs.c | 26 — Acked-by: Christian Lindig ___

Re: [Xen-devel] [PATCH] tools/oxenstored: port XS_INTRODUCE evtchn rebind function from cxenstored

> + if (Domain.get_mfn edom) = mfn && > (Connections.find_domain cons domid) != con then begin This should use <> instead of != because != is pointer inequality in OCaml. The parentheses are not strictly necessary because function application has precedence. So: if

Re: [Xen-devel] [PATCH] tools/oxenstored: port XS_INTRODUCE evtchn rebind function from cxenstored

> On 20 Aug 2019, at 11:45, Igor Druzhinin wrote: > > On 20/08/2019 09:21, Christian Lindig wrote: >>> + if (Domain.get_mfn edom) = mfn && >>> (Connections.find_domain cons domid) != con then begin >> >> This should use &l

Re: [Xen-devel] [PATCH] tools/oxenstored: port XS_INTRODUCE evtchn rebind function from cxenstored

at Connection.t is not abstract and its equality not well defined. Using != now relies on the fact that you only compare values stored in the same hash table. — C Acked-by: Christian Lindig ___ Xen-devel mailing list Xen-devel@lists.xenpr

Re: [Xen-devel] [PATCH v7 6/6] introduce a 'passthrough' configuration option to xl.cfg...

side as a list (of an enumeration type) and a bit vector in C and the bindings translate between the two. — C -- Acked-by: Christian Lindig ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v8 2/6] domain: introduce XEN_DOMCTL_CDF_iommu flag

> On 2 Sep 2019, at 15:50, Paul Durrant wrote: > > tools/ocaml/libs/xc/xenctrl.ml| 8 +++- > tools/ocaml/libs/xc/xenctrl.mli | 8 +++- Acked-by: Christian Lindig ___ Xen-devel mailing list Xen-devel@lists.xenproje

Re: [Xen-devel] [PATCH v9 3/6] sysctl / libxl: report whether IOMMU/HAP page table sharing is supported

> On 12 Sep 2019, at 12:17, Paul Durrant wrote: > > tools/libxl/libxl_types.idl | 1 + > tools/ocaml/libs/xc/xenctrl.ml | 1 + > tools/ocaml/libs/xc/xenctrl.mli | 2 +- Acked-by: Christian Lindig ___ Xen-devel mailing

Re: [Xen-devel] [PATCH v3 00/12] ocaml abi fixes

for the further script and xenctrl_stubs changes in v3 (or v3.1) of this series. Acked-by: Christian Lindig ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP

xenctrl.mli > +++ b/tools/ocaml/libs/xc/xenctrl.mli > @@ -92,6 +92,7 @@ type physinfo_cap_flag = > | CAP_HVM > | CAP_PV > | CAP_DirectIO > + | CAP_hap Acked-by: Christian Lindig ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks

to improve it, which at least for the OCaml part is very desirable. However, I’m not going to object to the patch. Acked-by: Christian Lindig — Christian ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] libxl: wait for the ack when issuing power control requests

> On 1 Oct 2019, at 11:12, Roger Pau Monne wrote: > > + libxl_asyncop_how *ao_how = aohow_val(async); > > caml_enter_blocking_section(); > - ret = libxl_domain_shutdown(CTX, c_domid); > + ret = libxl_domain_shutdown(CTX, c_domid, ao_how); >

Re: [Xen-devel] [PATCH] libxl: wait for the ack when issuing power control requests

> On 1 Oct 2019, at 11:12, Roger Pau Monne wrote: > > tools/ocaml/libs/xl/xenlight_stubs.c | 18 --- Acked-by: Christian Lindig ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

> On 1 Oct 2019, at 16:22, Roger Pau Monne wrote: > > tools/ocaml/libs/xl/xenlight.ml.in | 4 +- > tools/ocaml/libs/xl/xenlight.mli.in | 4 +- > tools/ocaml/libs/xl/xenlight_stubs.c | 18 ++++-- Acked-by: Christian Lindig ___ Xe

Re: [Xen-devel] [PATCH REPOST v13 3/4] tools/ocaml: abi check: Cope with consecutive relevant enums

> On 23 Sep 2019, at 14:39, Paul Durrant wrote: > > Ping? I think this is the only remaining patch in this series that still > needs an ack. Acked-by: Christian Lindig ___ Xen-devel mailing list Xen-devel@lists.xenproje

Re: [Xen-devel] [PATCH 2/6] tools/ocaml: Drop cpuid helpers

On 05/02/2020 16:50, Andrew Cooper wrote: These have no callers, and the underlying infrastructure is about to be rewritten completely. Signed-off-by: Andrew Cooper --- CC: Christian Lindig --- tools/ocaml/libs/xc/xenctrl.ml | 7 - tools/ocaml/libs/xc/xenctrl.mli | 7

Re: [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string

The changes in the OCaml C stubs look good to me. They don't really touch the interface but are mostly concerned with types on the C side by adding casts, const, and so on. The extended error handling is an improvement. -- Christian -- Acked-by: Christian Lindig

Re: [PATCH v4 2/4] Map: backport find_opt/update from 4.06

as the it saves the lookup for mem(). And moving to OCaml 4.06 improves performance. -- C From: Edwin Torok Sent: 28 August 2020 18:43 To: Christian Lindig; xen-devel@lists.xenproject.org Cc: Ian Jackson; d...@recoil.org; w...@xen.org Subject: Re: [PATCH v4 2/4] Map

Re: [PATCH 05/11 RFC] gitignore: Create .gitignore file for tools/ocaml/

Fine with me. Edvin is using locally for the OCaml part a Dune-based build that does away with a lot of the cruft because it puts all files generated during a build into _build/ directory which then is enough to ignore. IMHO that is the direction of the future. -- Acked-by: Christian Lindig

Re: [PATCH 0/3] tools: avoid creating symbolic links during make

-- Acked-by: Christian Lindig From: Juergen Gross Sent: 02 October 2020 15:22 To: xen-devel@lists.xenproject.org Cc: Juergen Gross; Andrew Cooper; George Dunlap; Ian Jackson; Jan Beulich; Julien Grall; Stefano Stabellini; Wei Liu; Samuel Thibault

Re: [PATCH 3/8] xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt

-- Acked-by: Christian Lindig From: Andrew Cooper Sent: 01 October 2020 12:02 To: Jan Beulich Cc: Xen-devel; Roger Pau Monne; Wei Liu; Ian Jackson; Christian Lindig; Edwin Torok; Rob Hoes Subject: Re: [PATCH 3/8] xen/domctl: Introduce and use

Re: [PATCH v1 1/1] tools/ocaml/xenstored: drop the creation of the RO socket

-- Acked-by: Christian Lindig From: Edwin Török Sent: 02 October 2020 17:06 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Christian Lindig; David Scott; Ian Jackson; Wei Liu Subject: [PATCH v1 1/1] tools/ocaml/xenstored: drop the creation of the RO

Re: [PATCH v3 00/38] tools: move most libraries into tools/libs

here is welcome. -- Acked-by: Christian Lindig ?? From: Juergen Gross Sent: 23 August 2020 10:34 To: xen-devel@lists.xenproject.org; xen-de...@dornerworks.com Cc: Juergen Gross; Samuel Thibault; Ian Jackson; Wei Liu; George Dunlap; Nick Rosbrook; Andrew Cooper

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

I see little reason to support old OCaml releases and requiring OCaml 4.06 would be fine with me but I assume that the project might have its own ideas about this. From: Edwin Torok Sent: 18 August 2020 08:28 To: Christian Lindig; xen-devel

Re: [PATCH v4 2/4] Map: backport find_opt/update from 4.06

From: Edwin Török Sent: 27 August 2020 18:35 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Christian Lindig; David Scott; Ian Jackson; Wei Liu Subject: [PATCH v4 2/4] Map: backport find_opt/update from 4.06 We are currently on OCaml 4.02 as minimum

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

select paves the way to a more efficient implementation. From: Edwin Torok Sent: 14 August 2020 23:11 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Christian Lindig; David Scott; Ian Jackson; Wei Liu Subject: [PATCH v1 0/6] tools/ocaml/xenstored: simplify

Re: [PATCH v1 5/6] tools/ocaml/xenstored: use more efficient node trees

a physical equivalence check first. -- C From: Edwin Torok Sent: 14 August 2020 23:14 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Christian Lindig; David Scott; Ian Jackson; Wei Liu Subject: [PATCH v1 5/6] tools/ocaml/xenstored: use more efficient node

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

From: Edwin Torok Sent: 14 August 2020 23:11 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Christian Lindig; David Scott; Ian Jackson; Wei Liu Subject: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code Fix warnings, and delete some obsolete code

Re: [PATCH 00/25] xl / libxl: named PCI pass-through devices

> NOTE: The OCaml bindings are adjusted to contain the interface change. It > should therefore not affect compatibility with OCaml-based utilities. Acked-by: Christian Lindig From: Paul Durrant Sent: 23 October 2020 17:22 To: xen

Re: [PATCH v1 1/1] oxenstored: fix ABI breakage introduced in Xen 4.9.0

From: Edwin Török Sent: 15 July 2020 16:10 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Christian Lindig; David Scott; Ian Jackson; Wei Liu; Igor Druzhinin Subject: [PATCH v1 1/1] oxenstored: fix ABI breakage introduced in Xen 4.9.0

Re: [PATCH 2/2] tools/ocaml: Default to useful build output

> Time for a bit of controversy. OCaml outside Xen has moved to a different model of building based on dune which is fast, declarative and reliable. The OCaml xenstore is stagnating because nobody with OCaml experience wants to touch it anymore. It would be beneficial for the health of the

Re: [PATCH 2/2] tools/ocaml: Default to useful build output

is inefficient. -- C From: Paul Durrant Sent: 20 July 2020 10:00 To: Christian Lindig; 'Elliott Mitchell'; xen-de...@lists.xen.org Cc: Ian Jackson; Edwin Torok; w...@xen.org; d...@recoil.org Subject: RE: [PATCH 2/2] tools/ocaml: Default to useful build output

Re: [PATCH 1/2] Partially revert "Cross-compilation fixes."

From: Elliott Mitchell Sent: 18 July 2020 04:31 To: xen-de...@lists.xen.org Cc: Ian Jackson; w...@xen.org; Christian Lindig; d...@recoil.org Subject: [PATCH 1/2] Partially revert "Cross-compilation fixes." This partially reve

Re: [PATCH 2/2] tools/ocaml: Default to useful build output

From: Elliott Mitchell Sent: 18 July 2020 04:32 To: xen-de...@lists.xen.org Cc: Ian Jackson; w...@xen.org; Christian Lindig; d...@recoil.org Subject: [PATCH 2/2] tools/ocaml: Default to useful build output While hiding details of build output looks

Re: [PATCH v20210111 34/39] tools: adjust libxl_domain_suspend to receive a struct props

> Upcoming changes will pass more knobs down to xc_domain_save. > Adjust the libxl_domain_suspend API to allow easy adding of additional knobs. Acked-by: Christian Lindig From: Olaf Hering Sent: 11 January 2021 17:42 To: xen-devel@lists.xenproje

Re: [PATCH v5 0/4] Xen ABI feature control

Acked-by: Christian Lindig From: Jürgen Groß Sent: Thursday, December 03, 2020 13:15 To: Paul Durrant; xen-devel@lists.xenproject.org Cc: Paul Durrant; Andrew Cooper; Anthony Perard; Christian Lindig; David Scott; George Dunlap; Ian Jackson; Jan Beulich

Re: [XEN PATCH] tools/xenstore: Log xenstored build ID on startup

07:53 To: Edwin Torok; xen-devel@lists.xenproject.org; jgr...@suse.com; Andrew Cooper Cc: w...@xen.org; Christian Lindig; jgr...@amazon.co.uk; elnik...@amazon.de; i...@xenproject.org Subject: Re: [XEN PATCH] tools/xenstore: Log xenstored build ID on startup On 13.11.20 18:23, Edwin Torok wrote

Re: [PATCH v1 0/4] tools/ocaml/libs/xc: domid control at domain creation time

for building the OCaml part in the future. Acked-by: Christian Lindig From: Edwin Török Sent: 17 November 2020 18:24 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Doug Goldstein; Andrew Cooper; George Dunlap; Ian Jackson; Jan Beulich; Julien Grall; Stefano

Re: [PATCH v2 0/2] tools/ocaml/libs/xc: domid control

Acked-by: Christian Lindig I'm providing some feedback on https://github.com/edwintorok/xen/pull/1 From: Edwin Török Sent: 15 January 2021 22:28 To: xen-devel@lists.xenproject.org Cc: Edwin Torok; Christian Lindig; David Scott; Ian Jackson; Wei Liu

Re: [PATCH v4 0/4] tools/ocaml/xenstored: optimizations

Acked-by: Christian Lindig I am providing feedback on https://github.com/edwintorok/xen/pull/1. In general: this is a large patch and therefore difficult to review for correctness. However: * It comes with a lot of testing and was fuzz-tested * It improves building OCaml xenstore

Re: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored

> Change this, by selecting between C xenstored and Ocaml xenstored "at random" Acked-by: Christian Lindig From: Ian Jackson Sent: 22 January 2021 15:56 To: xen-devel@lists.xenproject.org Cc: Ian Jackson; Edwin Torok; Christian Lindig;

Re: [PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h

Acked-by: Christian Lindig From: Manuel Bouyer Sent: 12 January 2021 18:12 To: xen-devel@lists.xenproject.org Cc: Manuel Bouyer; Christian Lindig; David Scott; Ian Jackson; Wei Liu Subject: [PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h From

Re: [PATCH for-4.15 0/3] tools/oxenstored bugfixes

Acked-by: Christian Lindig From: Andrew Cooper Sent: 03 February 2021 17:35 To: Xen-devel Cc: Andrew Cooper; Christian Lindig; Ian Jackson; Wei Liu Subject: [PATCH for-4.15 0/3] tools/oxenstored bugfixes All of these been posted before, but were tangled

Re: [PATCH 3/3] tools/oxenstored: mkdir conflicts were sometimes missed

Acked-by: Christian Lindig From: Andrew Cooper Sent: 03 February 2021 17:35 To: Xen-devel Cc: Edwin Torok; Christian Lindig; Ian Jackson; Wei Liu Subject: [PATCH 3/3] tools/oxenstored: mkdir conflicts were sometimes missed From: Edwin Török Due to how

Re: [PATCH 2/3] tools/oxenstored: Reject invalid watch paths early

Acked-by: Christian Lindig Great work. Fuzzing is often thought as best to find bugs in languages like C where memory is explicitly managed but here it reveals logical bugs. From: Andrew Cooper Sent: 03 February 2021 17:35 To: Xen-devel Cc: Edwin Torok

Re: [PATCH 01/12] libxc: split xc_logdirty_control() from xc_shadow_control()

For the OCaml part: Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>> On 25 Jun 2021, at 14:17, Jan Beulich mailto:jbeul...@suse.com>> wrote: For log-dirty operations a 64-bit field is being truncated to become an "int" return value. Seeing the lar

Re: [PATCH] tools/ocaml/libs/xc: add OCaml stubs to query CPU policy

4 insertions(+), 1 deletion(-) Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>> +static CAMLprim value Val_leaves(const xen_cpuid_leaf_t *leaves, uint32_t nr_leaves) +{ +CAMLparam0(); +CAMLlocal1(result); +uint32_t i; + +result = caml_alloc(nr_leaves, 0); +for (i=0;i

Re: [PATCH v4 0/5] Fix redefinition errors for toolstack libs

eaders by indirectly including /usr/include/limits.h where PAGE_SIZE and PATH_MAX are defined. [..] tools/ocaml/libs/xc/xenctrl_stubs.c | 10 +++ .../ocaml/libs/xentoollog/xentoollog_stubs.c | 4 +++ tools/ocaml/libs/xl/xenlight_stubs.c | 4 +++ Acked-by: Christian

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

trl_stubs.c | 2 +- xen/include/public/domctl.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>>

Re: [PATCH 0/5] Fix redefinition errors for toolstack libs

(+), 2 deletions(-) — 2.20.1 For the OCaml bindings, this avoids redefinitions as you say. Looks good to me. Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>>

Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection

The impact on the OCaml side is minimal and looks good to me. Acked-by: Christian Lindig From: Roger Pau Monne Sent: 09 March 2021 10:56 To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne; Ian Jackson; Wei Liu; Andrew Cooper; George Dunlap; Jan

Re: [PATCH v2 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any()

GN_API #include +#include #include #include "mmap_stubs.h" — 2.26.2 Do we need this when there are no other changes in the file? Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>>

Re: [PATCH 0/6] gnttab: add per-domain controls

> On 17 Sep 2021, at 16:46, Roger Pau Monne wrote: > > Hello, > > The first two patches of this series allows setting the preisoutly host > wide command line `gnttab` option on a per domain basis. That means > selecting the max allowed grant table version and whether transitive > grants are

Re: [PATCH v5 0/3] Expose PMU to the guests

xen/include/asm-arm/domain.h | 1 + xen/include/public/domctl.h | 4 ++- xen/include/public/sysctl.h | 6 ++-- xen/include/xen/domain.h | 2 ++ 21 files changed, 157 insertions(+), 11 deletions(-) — 2.29.0 Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>>

Re: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"

On 14 Oct 2021, at 10:33, Julien Grall mailto:jul...@xen.org>> wrote: Looking at the thread, we are only missing an ack for... --- tools/ocaml/libs/xc/xenctrl.ml | 1 - > tools/ocaml/libs/xc/xenctrl.mli | 1 - Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>>

Re: [PATCH v2 0/6] gnttab: add per-domain controls

On 11 Oct 2021, at 10:36, Roger Pau Monne mailto:roger@citrix.com>> wrote: Ping? The two patches above didn't get any review in either v1 or v2. Patch #1 should be ready to go in AFAICT. Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>>

  1   2   >