Re: [Xen-devel] [PATCH] [v3] x86: Convert x86_platform_ops to timespec64

2018-04-27 Thread Joao Martins
On 04/27/2018 09:13 PM, Arnd Bergmann wrote: > diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c > index 761f6af6efa5..637982efecd8 100644 > --- a/arch/x86/kernel/pvclock.c > +++ b/arch/x86/kernel/pvclock.c > @@ -123,28 +123,35 @@ u64 pvclock_clocksource_read(struct >

[Xen-devel] [PATCH v2] x86/xen: Combine PV features to be disabled in xen_nopv

2018-05-28 Thread Joao Martins
Rzeszutek Wilk Signed-off-by: Joao Martins --- Changes since RFC: (https://lists.xenproject.org/archives/html/xen-devel/2015-10/msg00898.html Comments from Boris, and new changes) - Improve subject and commit message - Fix Documentation format and deprecate 'xen_nopvspin' instead of removing

Re: [Xen-devel] [PATCH] [v3] x86: Convert x86_platform_ops to timespec64

2018-05-02 Thread Joao Martins
On 04/28/2018 11:09 AM, Arnd Bergmann wrote: > On Sat, Apr 28, 2018 at 12:21 AM, Joao Martins > <joao.m.mart...@oracle.com> wrote: >> On 04/27/2018 09:13 PM, Arnd Bergmann wrote: >>> diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c >>> ind

Re: [Xen-devel] [PATCH net-next v2] xen-netback: make copy batch size configurable

2018-01-04 Thread Joao Martins
On 12/26/2017 10:22 PM, David Miller wrote: > From: Joao Martins <joao.m.mart...@oracle.com> > Date: Thu, 21 Dec 2017 17:24:28 + > >> Commit eb1723a29b9a ("xen-netback: refactor guest rx") refactored Rx >> handling and as a result decreased max gran

Re: [Xen-devel] [PATCH v2 31/62] x86: xen pv clock time source

2018-01-12 Thread Joao Martins
On 01/12/2018 11:28 AM, Wei Liu wrote: > It is a variant of TSC clock source. > > Signed-off-by: Wei Liu > Signed-off-by: Andrew Cooper > Signed-off-by: Roger Pau Monné > --- > Changes since v1: > - Use the mapped

[Xen-devel] [PATCH] xenbus: track user request id

2018-02-01 Thread Joao Martins
nstore accesses") Reported-by: Bhavesh Davda <bhavesh.da...@oracle.com> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- Sending out for some feedback first, more to double check whether this indeed constitutes a problem. If it does I'll need to include a "Cc: <sta

[Xen-devel] [PATCH v2] xenbus: track caller request id

2018-02-02 Thread Joao Martins
Bhavesh Davda <bhavesh.da...@oracle.com> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- Here's a link to a unit test (https://pastebin.com/2q51j2sR) where req_id of reply and response are being asserted each request. Without this patch the assert will fail (e.g. try it with `./xsw

[Xen-devel] [PATCH v3] xenbus: track caller request id

2018-02-08 Thread Joao Martins
Bhavesh Davda <bhavesh.da...@oracle.com> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> --- Here's a link to a unit test (https://pastebin.com/N0kqNBnM) where req_id of reply and response are being asserted each request. Witho

Re: [Xen-devel] [PATCH RFC 2/8] public/io/netif: add directory for backend parameters

2018-02-08 Thread Joao Martins
On 02/08/2018 11:13 AM, Wei Liu wrote: > On Wed, Feb 07, 2018 at 12:10:37PM +0000, Joao Martins wrote: >> On 02/06/2018 05:12 PM, Wei Liu wrote: >>> (Three months after you sent this, sorry...) >>> >>> On Mon, Nov 06, 2017 at 12:33:06PM +, Joao Martins wrote

Re: [Xen-devel] [PATCH RFC 0/8] libxl, xl, public/io: PV backends feature control

2018-02-07 Thread Joao Martins
On 02/07/2018 11:30 AM, Roger Pau Monné wrote: > On Wed, Feb 07, 2018 at 12:20:42PM +0100, Juergen Gross wrote: >> On 07/02/18 12:16, Roger Pau Monné wrote: >>> On Thu, Nov 02, 2017 at 06:06:08PM +, Joao Martins wrote: >>>> * Toolstack constructs a key val

Re: [Xen-devel] [PATCH RFC 2/8] public/io/netif: add directory for backend parameters

2018-02-07 Thread Joao Martins
On 02/06/2018 05:12 PM, Wei Liu wrote: > (Three months after you sent this, sorry...) > > On Mon, Nov 06, 2017 at 12:33:06PM +0000, Joao Martins wrote: >> On Mon, Nov 06, 2017 at 10:33:59AM +, Paul Durrant wrote: >>>> -Original Message----- >>>>

Re: [Xen-devel] [PATCH RFC 7/8] xen-blkback: frontend feature control

2018-02-07 Thread Joao Martins
On 02/07/2018 12:08 PM, Roger Pau Monné wrote: > On Thu, Nov 02, 2017 at 06:06:15PM +0000, Joao Martins wrote: >> Toolstack may write values to the "require" subdirectory in the >> backend main directory (e.g. backend/vbd/X/Y/). Read these values >> and

Re: [Xen-devel] [PATCH RFC 0/8] libxl, xl, public/io: PV backends feature control

2018-02-07 Thread Joao Martins
On 02/07/2018 11:16 AM, Roger Pau Monné wrote: > On Thu, Nov 02, 2017 at 06:06:08PM +0000, Joao Martins wrote: >> Hey folks, >> >> Presented herewith is an attempt to implement PV backends feature control >> as discussed in the list >> (https://lists.xen.or

[Xen-devel] [PATCH net-next v2] xen-netback: make copy batch size configurable

2017-12-21 Thread Joao Martins
er batches (i.e. for better throughput with big packets) as it was prior to the above mentioned commit. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- Changes since v1: * move rx_copy.{idx,op} reallocation to separate helper Addressed Paul's comments: * rename xenvif_copy_

Re: [Xen-devel] [PATCH v3 2/4] x86: possibly bring up all CPUs even if not all are supposed to be used

2018-07-19 Thread Joao Martins
On 07/19/2018 11:32 AM, Jan Beulich wrote: > Note: On one of my test systems the parked CPUs get _PSD data reported > by Dom0 that is different from the non-parked ones (coord_type is > 0xFC instead of 0xFE). Giving Dom0 enough vCPU-s eliminates this > problem, so there is

Re: [Xen-devel] [PATCH v1] xen: acpi: upload _PSD info for offline CPUs too

2018-03-07 Thread Joao Martins
On 03/07/2018 05:51 PM, Boris Ostrovsky wrote: > On 03/06/2018 03:12 PM, Joao Martins wrote: >> All uploaded PM data from offline CPUs takes the info from vCPU 0 and > > "offline" may not be the right term here. Maybe "non-dom0"? > Yeah, probably

[Xen-devel] [PATCH v1] xen: acpi: upload _PSD info for offline CPUs too

2018-03-06 Thread Joao Martins
and offline) and always uploading the correct P-State dependency up to Xen. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- xen_processor_get_psd() is taken from acpi_processor_get_psd() (drivers/acpi/processor_perflib.c) simply because only Xen Dom0 needs to handle vcpus !=

[Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0 CPUs too

2018-03-08 Thread Joao Martins
procesors and always uploading the correct info to Xen. We export acpi_processor_get_psd() to help with this purpose, but change signature to not assume the existence of a struct acpi_processor given that ACPI doesn't create an acpi_processor for non-dom0 CPUs. Signed-off-by: Joao Martins <joao.m.m

[Xen-devel] [PATCH v3] xen/acpi: upload _PSD info for non Dom0 CPUs too

2018-03-15 Thread Joao Martins
processors and thus always uploading the correct info to Xen. We export acpi_processor_get_psd() for that this purpose, but change signature to not assume an existent of acpi_processor given that ACPI isn't creating an acpi_processor for non-dom0 CPUs. Signed-off-by: Joao Martins <joao.m.m

Re: [Xen-devel] [PATCH] xen/acpi: off by one in read_acpi_id()

2018-03-28 Thread Joao Martins
comes right after the condition you're fixing). > Fixes: 59a568029181 ("xen/acpi-processor: C and P-state driver that uploads > said data to hypervisor.") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > FWIW, Reviewed-by: Joao Martins <joao.m.mart...@

Re: [Xen-devel] [PATCH v3] xen/acpi: upload _PSD info for non Dom0 CPUs too

2018-03-16 Thread Joao Martins
On 03/15/2018 03:45 PM, Boris Ostrovsky wrote: > On 03/15/2018 10:22 AM, Joao Martins wrote: >> All uploaded PM data from non-dom0 CPUs takes the info from vCPU 0 and >> changing only the acpi_id. For processors which P-state coordination type >> is HW_ALL (0xFD) it is OK to

Re: [Xen-devel] [PATCH v3] xen/acpi: upload _PSD info for non Dom0 CPUs too

2018-03-20 Thread Joao Martins
On 03/20/2018 09:41 AM, Rafael J. Wysocki wrote: > On Fri, Mar 16, 2018 at 2:57 PM, Joao Martins <joao.m.mart...@oracle.com> > wrote: >> On 03/15/2018 03:45 PM, Boris Ostrovsky wrote: >>> On 03/15/2018 10:22 AM, Joao Martins wrote: >>>> All uploaded PM data

Re: [Xen-devel] [PATCH] xen: drop writing error messages to xenstore

2018-10-10 Thread Joao Martins
On 10/09/2018 05:09 PM, Juergen Gross wrote: > xenbus_va_dev_error() will try to write error messages to Xenstore > under the error//error node (with something like > "device/vbd/51872"). This will fail normally and another message > about this failure is added to dmesg. > > I believe this is a

Re: [Xen-devel] [PATCH] xen: drop writing error messages to xenstore

2018-10-11 Thread Joao Martins
On 10/11/2018 06:05 AM, Juergen Gross wrote: > On 10/10/2018 18:57, Boris Ostrovsky wrote: >> On 10/10/18 11:53 AM, Juergen Gross wrote: >>> On 10/10/2018 17:09, Joao Martins wrote: >>>> On 10/09/2018 05:09 PM, Juergen Gross wrote: >>>>> xenbus_va

Re: [Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

2019-04-08 Thread Joao Martins
On 4/8/19 7:44 AM, Juergen Gross wrote: > On 12/03/2019 18:14, Joao Martins wrote: >> On 2/22/19 4:59 PM, Paolo Bonzini wrote: >>> On 21/02/19 12:45, Joao Martins wrote: >>>> On 2/20/19 9:09 PM, Paolo Bonzini wrote: >>>>> On 20/02/19 21:15, Joao Martins

Re: [Xen-devel] [PATCH RFC 20/39] xen-blkback: module_exit support

2019-02-26 Thread Joao Martins
On 2/25/19 6:57 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 20, 2019 at 08:15:50PM +0000, Joao Martins wrote: >> >> Implement module_exit to allow users to do module unload of blkback. >> We prevent users from module unload whenever there are still interfaces >> al

Re: [Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

2019-02-21 Thread Joao Martins
On 2/20/19 9:09 PM, Paolo Bonzini wrote: > On 20/02/19 21:15, Joao Martins wrote: >> 2. PV Driver support (patches 17 - 39) >> >> We start by redirecting hypercalls from the backend to routines >> which emulate the behaviour that PV backends expect i.e. grant >&

Re: [Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

2019-02-21 Thread Joao Martins
On 2/20/19 11:39 PM, Marek Marczykowski-Górecki wrote: > On Wed, Feb 20, 2019 at 08:15:30PM +0000, Joao Martins wrote: >> 2. PV Driver support (patches 17 - 39) >> >> We start by redirecting hypercalls from the backend to routines >> which emulate the behaviour

Re: [Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

2019-02-21 Thread Joao Martins
On 2/21/19 7:57 AM, Juergen Gross wrote: > On 21/02/2019 00:39, Marek Marczykowski-Górecki wrote: >> On Wed, Feb 20, 2019 at 08:15:30PM +0000, Joao Martins wrote: >>> 2. PV Driver support (patches 17 - 39) >>> >>> We start by redirecting hypercalls from the ba

[Xen-devel] [PATCH RFC 38/39] xen-blkback: xen_shim_domain() support

2019-02-20 Thread Joao Martins
-by: Ankur Arora Signed-off-by: Joao Martins Signed-off-by: Ankur Arora --- drivers/block/xen-blkback/blkback.c | 19 --- drivers/block/xen-blkback/xenbus.c | 5 +++-- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block

[Xen-devel] [PATCH RFC 34/39] xen/gntdev: xen_shim_domain() support

2019-02-20 Thread Joao Martins
From: Ankur Arora GNTTABOP_map_grant_ref treats host_addr as an OUT parameter for xen_shim_domaim(). Accordingly it's updated in struct gnttab_unmap_grant_ref before it gets used via GNTTABOP_unmap_grant_ref. Co-developed-by: Joao Martins Signed-off-by: Ankur Arora Signed-off-by: Joao

[Xen-devel] [PATCH RFC 20/39] xen-blkback: module_exit support

2019-02-20 Thread Joao Martins
Implement module_exit to allow users to do module unload of blkback. We prevent users from module unload whenever there are still interfaces allocated, in other words, do module_get on xen_blkif_alloc() and module_put on xen_blkif_free(). Signed-off-by: Joao Martins --- drivers/block/xen

[Xen-devel] [PATCH RFC 17/39] x86/xen: export vcpu_info and shared_info

2019-02-20 Thread Joao Martins
From: Ankur Arora Also remove __init annotations from xen_evtchn_2l/fifo_init(). This allows us to support 2-level event channel ABI on xen_shim_domain(). Signed-off-by: Ankur Arora --- arch/x86/xen/enlighten.c | 3 +++ drivers/xen/events/events_2l.c | 2 +-

[Xen-devel] [PATCH RFC 33/39] xen/grant-table: xen_shim_domain() support

2019-02-20 Thread Joao Martins
elides the setting of that state if xen_shim_domain(). In addition, gnttab_map_refs() now fills in the appropriate page returned from the grant operation. Signed-off-by: Joao Martins --- drivers/xen/grant-table.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

[Xen-devel] [PATCH RFC 32/39] xen/balloon: xen_shim_domain() support

2019-02-20 Thread Joao Martins
.) This allows the calling code -- which does a page_to_pfn() on the returned struct page -- to remain unchanged before doing the grant operation (which in this case would fill in the real struct page.) Co-developed-by: Ankur Arora Signed-off-by: Joao Martins Signed-off-by: Ankur Arora --- arch

[Xen-devel] [PATCH RFC 36/39] drivers/xen: xen_shim_domain() support

2019-02-20 Thread Joao Martins
Enable /dev/xen/{gntdev,evtchn} and /proc/xen/ for xen_shim_domain(). These interfaces will be used by xenstored to initialize its event channel port and the kva used to communicate with the xenbus driver. Signed-off-by: Joao Martins --- drivers/xen/evtchn.c | 4 +++- drivers/xen

[Xen-devel] [PATCH RFC 31/39] xen-shim: introduce shim domain driver

2019-02-20 Thread Joao Martins
, blkback etc) in order to drive guest I/O. Co-developed-by: Joao Martins Signed-off-by: Ankur Arora Signed-off-by: Joao Martins --- arch/x86/include/asm/kvm_host.h | 2 + arch/x86/kvm/Kconfig | 10 +++ arch/x86/kvm/Makefile| 1 + arch/x86/kvm

[Xen-devel] [PATCH RFC 35/39] xen/xenbus: xen_shim_domain() support

2019-02-20 Thread Joao Martins
and pfn externally. Co-developed-by: Joao Martins Signed-off-by: Ankur Arora Signed-off-by: Joao Martins --- drivers/xen/xenbus/xenbus_client.c | 23 +-- drivers/xen/xenbus/xenbus_dev_backend.c | 4 ++-- drivers/xen/xenbus/xenbus_dev_frontend.c | 4 ++-- drivers/xen

[Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

2019-02-20 Thread Joao Martins
spinlocks slowpath Joao Martins (14): KVM: x86: fix Xen hypercall page msr handling KVM: x86/xen: intercept xen hypercalls if enabled KVM: x86/xen: register shared_info page KVM: x86/xen: setup pvclock updates KVM: x86/xen

[Xen-devel] [PATCH RFC 18/39] x86/xen: make hypercall_page generic

2019-02-20 Thread Joao Martins
From: Ankur Arora Export hypercall_page as a generic interface which can be implemented by other hypervisors. With this change, hypercall_page now points to the newly introduced xen_hypercall_page which is seeded by Xen, or to one that is filled in by a different hypervisor. Signed-off-by:

[Xen-devel] [PATCH RFC 19/39] xen/xenbus: xenbus uninit support

2019-02-20 Thread Joao Martins
-by: Joao Martins --- drivers/xen/xenbus/xenbus.h| 2 ++ drivers/xen/xenbus/xenbus_client.c | 5 drivers/xen/xenbus/xenbus_probe.c | 51 +++--- drivers/xen/xenbus/xenbus_xs.c | 38 4 files changed, 93 insertions(+), 3

Re: [Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

2019-03-12 Thread Joao Martins
On 2/22/19 4:59 PM, Paolo Bonzini wrote: > On 21/02/19 12:45, Joao Martins wrote: >> On 2/20/19 9:09 PM, Paolo Bonzini wrote: >>> On 20/02/19 21:15, Joao Martins wrote: >>>> 2. PV Driver support (patches 17 - 39) >>>> >>>> We start

Re: [Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

2019-04-08 Thread Joao Martins
On 4/8/19 11:42 AM, Juergen Gross wrote: > On 08/04/2019 12:36, Joao Martins wrote: >> On 4/8/19 7:44 AM, Juergen Gross wrote: >>> On 12/03/2019 18:14, Joao Martins wrote: >>>> On 2/22/19 4:59 PM, Paolo Bonzini wrote: >>>>> On 21/02/19 12:45, Joao Ma