Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v3 02/14] qom: make interface types abstract

2018-11-20 Thread Laszlo Ersek
On 11/20/18 17:33, Igor Mammedov wrote: > On Wed, 7 Nov 2018 16:36:40 +0400 > Marc-André Lureau wrote: > >> Interfaces don't have instance, let's make the interface type really >> abstract to avoid confusion. >> >> Signed-off-by: Marc-André Lureau >> --- >>

Re: [Xen-devel] [PATCH v2 00/31] Specific platform to run OVMF in Xen PVH and HVM guests

2019-04-08 Thread Laszlo Ersek
On 04/08/19 16:23, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v2 > > Hi, > > I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc > with the goal to make it work on both Xen

Re: [Xen-devel] [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

2019-03-06 Thread Laszlo Ersek
On 03/06/19 13:40, Igor Druzhinin wrote: > On Xen, hvmloader firmware leaves address decoding enabled for > enumerated PCI device before jumping into OVMF. OVMF seems to > expect it to be disabled and tries to size PCI BARs in several places > without disabling it which causes BAR64, for example,

Re: [Xen-devel] [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

2019-03-06 Thread Laszlo Ersek
On 03/06/19 15:26, Igor Druzhinin wrote: > On 06/03/2019 13:22, Laszlo Ersek wrote: >> On 03/06/19 13:40, Igor Druzhinin wrote: >>> On Xen, hvmloader firmware leaves address decoding enabled for >>> enumerated PCI device before jumping into OVMF. OVMF seems to &

Re: [Xen-devel] [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

2019-03-20 Thread Laszlo Ersek
On 03/19/19 15:03, Anthony PERARD wrote: > On Thu, Mar 14, 2019 at 07:45:56PM +, Igor Druzhinin wrote: >> On 14/03/2019 17:41, Anthony PERARD wrote: >>> Hi, >>> >>> On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote: This aperture doesn't exist in OVMF and trying to use it

Re: [Xen-devel] [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

2019-03-22 Thread Laszlo Ersek
On 03/22/19 09:33, Roger Pau Monné wrote: > On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote: >> This aperture doesn't exist in OVMF and trying to use it causes >> failing assertions later in cases there are prefetchable and >> non-prefetchable BARs following each other. This

Re: [edk2-devel] [PATCH v2 02/31] OvmfPkg: Create platform XenOvmf

2019-04-11 Thread Laszlo Ersek
On 04/10/19 20:37, Jordan Justen wrote: > On 2019-04-10 07:27:15, Laszlo Ersek wrote: >> On 04/10/19 11:48, Jordan Justen wrote: >>> On 2019-04-09 04:08:15, Anthony PERARD wrote: >>>> This is a copy of OvmfX64, removing VirtIO and some SMM. >>>> >

Re: [edk2-devel] [PATCH v2 08/31] OvmfPkg/XenResetVector: Allow to jumpstart from either hvmloader or PVH

2019-04-11 Thread Laszlo Ersek
ctor}/Ia32/SearchForBfvBase.asm | 19 + > OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm > | 30 ++-- > 4 files changed, 66 insertions(+), 11 deletions(-) (4) For the subject line: please drop the word "to". With th

Re: [edk2-devel] [PATCH v2 11/31] OvmfPkg/XenPlatformPei: Use mXenHvmloaderInfo to get E820

2019-04-11 Thread Laszlo Ersek
return EFI_SUCCESS; >} > > - ASSERT (Info->E820 < MAX_ADDRESS); > - *Entries = (EFI_E820_ENTRY64 *)(UINTN) Info->E820; > - *Count = Info->E820EntriesCount; > - > - return EFI_SUCCESS; > + return EFI_NOT_FOUND; > } > > /** > Acked-b

Re: [edk2-devel] [PATCH v2 14/31] OvmfPkg/AcpiPlatformDxe: Use PVH RSDP if exist

2019-04-11 Thread Laszlo Ersek
On 04/11/19 14:23, Laszlo Ersek wrote: > On 04/11/19 14:20, Laszlo Ersek wrote: >> On 04/09/19 13:08, Anthony PERARD wrote: >>> If the firmware have been started via the PVH entry point, a RSDP >>> pointer would have been provided. Use it. >>> >>> Also

Re: [edk2-devel] [PATCH v2 14/31] OvmfPkg/AcpiPlatformDxe: Use PVH RSDP if exist

2019-04-11 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > If the firmware have been started via the PVH entry point, a RSDP > pointer would have been provided. Use it. > > Also, use XenDetect() from the new XenPlatformLib. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony

Re: [edk2-devel] [PATCH v2 06/31] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2019-04-11 Thread Laszlo Ersek
s, but the copies you created earlier don't, and that will present itself as a difference with --find-copies-harder.) With the above two formalities fixed: Acked-by: Laszlo Ersek Thanks Laszlo > @@ -27,9 +29,23 @@ ALIGN 16 > ; located just below 0x1 (4GB) in the firmware device

Re: [edk2-devel] [PATCH v2 10/31] OvmfPkg/XenPlatformPei: Detect OVMF_INFO from hvmloader

2019-04-11 Thread Laszlo Ersek
hould be indented as: AsciiStrnCpyS ( Sig, sizeof (Sig), (CHAR8 *) >Signature, sizeof (Info->Signature) ); or: AsciiStrnCpyS (Sig, sizeof (Sig), (CHAR8 *) >Signature, sizeof (Info->Signature)); (note the whitespace before the opening paren, aft

Re: [edk2-devel] [PATCH v2 07/31] OvmfPkg/XenResetVector: Saving start of day pointer for PVH guests

2019-04-11 Thread Laszlo Ersek
NT32|0x30 > + gUefiOvmfPkgTokenSpaceGuid.PcdXenStartOfDayStructPtrSize|0x0|UINT32|0x31 > + (2) calling these PcdXenPvh* rather than just PcdXen* (my understanding is that they are specific to PVH) (3) Please use token values 0x17 and 0x28. That should decrease the token space

Re: [Xen-devel] [edk2-devel] [PATCH v2 10/31] OvmfPkg/XenPlatformPei: Detect OVMF_INFO from hvmloader

2019-04-11 Thread Laszlo Ersek
On 04/11/19 13:47, Laszlo Ersek wrote: > On 04/09/19 13:08, Anthony PERARD wrote: >> This struct is only useful to retrieve the E820 table. The > > (1) please replace "this struct" with the name of the struct. > >> mXenHvmloaderInfo isn't used yet,

Re: [edk2-devel] [PATCH v2 12/31] OvmfPkg/XenPlatformPei: Grab RSDP from PVH guest start of day struct

2019-04-11 Thread Laszlo Ersek
; + // booted via the PVH entry point. > + // > + > + PVHResetVectorData = (VOID *)(UINTN) PcdGet32(PcdXenStartOfDayStructPtr); (2) missing space after PcdGet32 > + // > + // That magic value is "XPVH", and it is written in > + // XenResetVector/Ia32/XenPVHM

Re: [edk2-devel] [PATCH v2 14/31] OvmfPkg/AcpiPlatformDxe: Use PVH RSDP if exist

2019-04-11 Thread Laszlo Ersek
On 04/11/19 14:20, Laszlo Ersek wrote: > On 04/09/19 13:08, Anthony PERARD wrote: >> If the firmware have been started via the PVH entry point, a RSDP >> pointer would have been provided. Use it. >> >> Also, use XenDetect() from the new XenPlatformLib. >>

Re: [edk2-devel] [PATCH v2 09/31] OvmfPkg/XenOvmf: use a TimerLib instance that depends only on the CPU

2019-04-11 Thread Laszlo Ersek
On 04/11/19 13:25, Laszlo Ersek wrote: > On 04/09/19 13:08, Anthony PERARD wrote: >> ACPI Timer does not work in a PVH guest, but local APIC works on both >> PVH and HVM. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Anthony PERAR

Re: [edk2-devel] [PATCH v2 09/31] OvmfPkg/XenOvmf: use a TimerLib instance that depends only on the CPU

2019-04-11 Thread Laszlo Ersek
gt; > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > (1) I suggest simplifying this patch by: - deleting all TimerLib resolutions except the

Re: [edk2-devel] [PATCH v2 13/31] OvmfPkg/Library/XenPlatformLib: New library

2019-04-11 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > The purpose of XenPlatformPei is to regroup the few functions that are (1) did you mean XenPlatformLib here? > used in several places to detect if Xen is detected, and to get the > XenInfo HOB. > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2-devel] [PATCH v2 05/31] OvmfPkg/XenOvmf: Creating an ELF header

2019-04-11 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > This header replace the embedded variable store. > > The ELF header explain to a loader to load the binary at the address > 1MB, then jump to the PVH entry point which will be created in a later > patch. > > That patch include generate_elf_header.c

Re: [edk2-devel] [PATCH v2 01/31] OvmfPkg/ResetSystemLib: Add missing dependency on PciLib

2019-04-10 Thread Laszlo Ersek
11 +17,10 @@ > #include > #include > #include > +#include > #include > #include > > -#include > - > VOID > AcpiPmControl ( >UINTN SuspendType > Hm, the duplicated #include is my fault, from commit 1466b76f9385 ("OvmfPkg: determine PMBA v

Re: [edk2-devel] [PATCH v2 02/31] OvmfPkg: Create platform XenOvmf

2019-04-10 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > This is a copy of OvmfX64, removing VirtIO and some SMM. > > This new platform will be changed to make it works on two types of Xen > guest: HVM and PVH. > > Compare to OvmfX64, this patch: > > - changed: PLATFORM_GUID, OUTPUT_DIRECTORY,

Re: [edk2-devel] [PATCH v2 04/31] OvmfPkg: Introduce XenPlatformPei

2019-04-10 Thread Laszlo Ersek
etBoolS (TokenName, Setting); \ > - ASSERT_RETURN_ERROR (PcdStatus); \ > -} \ > - } while (0) > - > -VOID > -NoexecDxeInitialization ( > - VOID > - ) > -{ > - UPDATE

Re: [edk2-devel] [PATCH v2 03/31] OvmfPkg: Introduce XenResetVector

2019-04-10 Thread Laszlo Ersek
Yes, please mention "gEfiFirmwareVolumeTopFileGuid" here. With that commit message update: Reviewed-by: Laszlo Ersek Thanks, Laszlo > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony PERARD > --- > OvmfPkg/XenOvmf.dsc

Re: [edk2-devel] [PATCH v2 00/31] Specific platform to run OVMF in Xen PVH and HVM guests

2019-04-09 Thread Laszlo Ersek
On 04/08/19 17:50, Laszlo Ersek wrote: > On 04/08/19 16:23, Anthony PERARD wrote: >> Patch series available in this git branch: >> https://xenbits.xen.org/git-http/people/aperard/ovmf.git >> br.platform-xen-pvh-v2 >> >> Hi, >> >> I've started

Re: [edk2-devel] [PATCH v2 0/3] Xen PCI passthrough fixes

2019-04-09 Thread Laszlo Ersek
Hi Igor, On 04/09/19 05:12, Igor Druzhinin wrote: > Igor Druzhinin (3): > OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge > aperture > OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64 > OvmfPkg/XenSupport: turn off address decoding before BAR sizing

Re: [Xen-devel] [PATCH v2 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

2019-04-09 Thread Laszlo Ersek
On 04/09/19 05:12, Igor Druzhinin wrote: > On Xen, hvmloader firmware leaves address decoding enabled for > enumerated PCI device before jumping into OVMF. OVMF seems to > expect it to be disabled and tries to size PCI BARs in several places > without disabling it which causes BAR64, for example,

Re: [edk2-devel] [PATCH v2 15/31] OvmfPkg/XenHypercallLib: Enable it in PEIM

2019-04-12 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > Allow to use Xen hypercalls earlier, during the PEIM stage, but > XenHypercallLibReInit() must be called once the XenInfo HOB is created > with the HyperPage setup. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony

Re: [edk2-devel] [PATCH v2 20/31] OvmfPkg: Import XENMEM_memory_map hypercall to Xen/memory.h

2019-04-12 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > This is copied over from the public header of the Xen Project, with the (1) Please expand "This". with that, Acked-by: Laszlo Ersek Thanks Laszlo > type name modified to build on OVMF. > > Contributed-under: TianoCore Cont

Re: [edk2-devel] [PATCH v2 16/31] OvmfPkg/XenPlatformPei: Introduce XenHvmloaderDetected

2019-04-12 Thread Laszlo Ersek
mPei/Xen.c > @@ -202,6 +202,13 @@ XenDetect ( >return FALSE; > } > > +BOOLEAN > +XenHvmloaderDetected ( > + VOID > + ) > +{ > + return (mXenHvmloaderInfo != NULL); > +} > > VOID > XenPublishRamRegions ( > (1) Please add least one se

Re: [edk2-devel] [PATCH v2 19/31] OvmfPkg/XenPlatformPei: Introduce XenPvhDetected

2019-04-12 Thread Laszlo Ersek
+ ASSERT (mXenInfo.VersionMajor != 0); > + > + return mXenHvmloaderInfo == NULL; > +} > + > VOID > XenPublishRamRegions ( >VOID > (1) Please write a nonempty commit message body. with that Acked-by: Laszlo Ersek Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io L

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: replace MIT license blocks with SPDX IDs

2019-04-12 Thread Laszlo Ersek
On 04/10/19 14:58, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: ovmf_spdx_mit > > For <https://bugzilla.tianocore.org/show_bug.cgi?id=1373>, we replaced > open-coded license text blocks with "SPDX-License-Identifier"s,

Re: [edk2-devel] [PATCH v2 17/31] OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it as runned

2019-04-12 Thread Laszlo Ersek
leBusEnumeration, TRUE); >ASSERT_RETURN_ERROR (PcdStatus); > (1) please fix the subject: s/as runned/has run/ (2) please write a nonempty commit message body. With that: Acked-by: Laszlo Ersek Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [PATCH v2 18/31] OvmfPkg/XenPlatformPei: Setup HyperPages earlier

2019-04-12 Thread Laszlo Ersek
t;mXenInfo.VersionMajor = (UINT16)(XenVersion >> 16); > @@ -265,12 +272,6 @@ InitializeXen ( > { >RETURN_STATUS PcdStatus; > > - if (mXenLeaf == 0) { > -return EFI_NOT_FOUND; > - } > - > - XenConnect (mXenLeaf); > - >// >// Reserve away HVMLOA

Re: [edk2-devel] [PATCH v2 21/31] OvmfPkg/XenPlatformPei: Get E820 table via hypercall ...

2019-04-12 Thread Laszlo Ersek
> +TmpEntry = E820Entries[Index]; > +E820Entries[Index] = E820Entries[Index - 1]; > +E820Entries[Index - 1] = TmpEntry; > + } > +} > + } > + > + *Count = E820EntriesCount; > + *Entries = E820Entries; > + > + return EFI_SUCCESS; > } > > /**

Re: [edk2-devel] [PATCH v2 24/31] OvmfPkg/XenPlatformPei: Ignore missing PCI Host Bridge on Xen PVH

2019-04-15 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > When the device ID of the host bridge is unknown, check if we are > running as a PVH guest as there is no PCI bus in that case. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony PERARD > --- > > Notes: > v2: >

Re: [edk2-devel] [PATCH v2 23/31] OvmfPkg/XenPlatformPei: Reserve VGA memory region, to boot Linux

2019-04-15 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > Linux panic if this region isn't reserved. Please expand "this" (just copy from the subject). with that, Acked-by: Laszlo Ersek Thanks Laszlo > > When Linux is booted on EFI system, it expects the memory at 0xa to > _not_

Re: [edk2-devel] [PATCH v2 25/31] OvmfPkg/PlatformBootManagerLib: Handle the absence of PCI bus on Xen PVH

2019-04-15 Thread Laszlo Ersek
, 0, 0x6b), 0x0b); // H >break; > +case XEN_PVH_PCI_HOST_BRIDGE_DEVICE_ID: > + // > + // There are no PCI bus in this case. (1) s/are/is/, please with that: Reviewed-by: Laszlo Ersek Thanks Laszlo > + // > + return; > default: >DEBUG ((EFI_D_ER

Re: [edk2-devel] [PATCH v2 25/31] OvmfPkg/PlatformBootManagerLib: Handle the absence of PCI bus on Xen PVH

2019-04-15 Thread Laszlo Ersek
On 04/15/19 15:33, Laszlo Ersek wrote: > On 04/09/19 13:08, Anthony PERARD wrote: >> When running on PVH without PCI bus, the XenPlatformPei will set >> PcdOvmfHostBridgePciDevId to XEN_PVH_PCI_HOST_BRIDGE_DEVICE_ID. >> >> Contributed-under: TianoCore Contribution

Re: [edk2-devel] [PATCH v2 28/31] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn

2019-04-15 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > On a Xen PVH guest, none of the existing serial or console interface > works, so we add a new one, based on XenConsoleSerialPortLib, and > implemeted via SerialDxe. > > That a simple console implementation that can works on both PVH guest (1) ITYM "that

Re: [edk2-devel] [PATCH v2 24/31] OvmfPkg/XenPlatformPei: Ignore missing PCI Host Bridge on Xen PVH

2019-04-15 Thread Laszlo Ersek
On 04/15/19 15:29, Laszlo Ersek wrote: > On 04/09/19 13:08, Anthony PERARD wrote: >> When the device ID of the host bridge is unknown, check if we are >> running as a PVH guest as there is no PCI bus in that case. >> >> Contributed-under: TianoCore Contribution

Re: [edk2-devel] [PATCH v2 26/31] OvmfPkg/XenOvmf: Override PcdFSBClock to Xen vLAPIC timer frequency

2019-04-15 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > That value is used by SecPeiDxeTimerLibCpu, the TimerLib implementation. > It will also be used by XenTimerDxe. (1) please expand "that value". with that, Acked-by: Laszlo Ersek Thanks Laszlo > > Contributed-under: TianoCore

Re: [edk2-devel] [PATCH v2 27/31] OvmfPkg/XenOvmf: Introduce XenTimerDxe

2019-04-15 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > "PcAtChipsetPkg/8254TimerDxe" is replaced with a Xen-specific > EFI_TIMER_ARCH_PROTOCOL implementation. Also remove > 8259InterruptControllerDxe as it is not used anymore. > > This Timer uses the local APIC timer as time source as it can work on > both a

Re: [edk2-devel] [PATCH v2 22/31] OvmfPkg/XenPlatformPei: Rework memory detection

2019-04-12 Thread Laszlo Ersek
he Reserve type and explain > about the ACPI type. MTRR settings aren't modified anymore, on HVM, it's > already done by hvmloader, on PVH it is supposed to have sane default. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony PERARD > --- For th

Re: [edk2-devel] [PATCH v2 25/31] OvmfPkg/PlatformBootManagerLib: Handle the absence of PCI bus on Xen PVH

2019-04-15 Thread Laszlo Ersek
On 04/15/19 16:40, Anthony PERARD wrote: > On Mon, Apr 15, 2019 at 03:49:25PM +0200, Laszlo Ersek wrote: >> On 04/15/19 15:33, Laszlo Ersek wrote: >>> On 04/09/19 13:08, Anthony PERARD wrote: >>>> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlat

Re: [edk2-devel] [PATCH v3 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

2019-04-30 Thread Laszlo Ersek
On 04/30/19 18:35, Anthony PERARD wrote: > On Fri, Apr 26, 2019 at 08:15:07PM +0200, Laszlo Ersek wrote: >> On 04/25/19 22:23, Igor Druzhinin wrote: >>> On Xen, hvmloader firmware leaves address decoding enabled for >>> enumerated PCI device before jumping into OVM

Re: [edk2-devel] [PATCH v3 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

2019-04-26 Thread Laszlo Ersek
SET) > + ); > + >for (Offset = BarOffsetBase; Offset < BarOffsetEnd; Offset += sizeof > (UINT32)) { > PcatPciRootBridgeBarExisted ( >PCI_LIB_ADDRESS (Bus, Device, Function, Offset), > Acked-by: Laszlo Ersek Someone from the Xen community please ACK this t

Re: [Xen-devel] [PATCH v3 07/35] OvmfPkg/XenResetVector: Saving start of day pointer for PVH guests

2019-07-05 Thread Laszlo Ersek
we allocate some space in the MEMFD for it. We use 'XPVH' as > a signature (for "Xen PVH"). > > [1] https://xenbits.xenproject.org/docs/unstable/misc/pvh.html > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Las

Re: [Xen-devel] [PATCH v3 06/35] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2019-07-05 Thread Laszlo Ersek
eate mode 100644 OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm Acked-by: Laszlo Ersek ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 05/35] OvmfPkg/OvmfXen: Creating an ELF header

2019-07-05 Thread Laszlo Ersek
/ (1) This patch is almost complete, just please update the comment style, for this top-level comment, from /* * @file * blah */ to: /** @file blah **/ Please refer to e.g. "OvmfPkg/XenBusDxe/XenBusDxe.c". With that comment style update: Acked-by: Laszlo Ersek Thanks Laszlo

Re: [Xen-devel] [PATCH v3 08/35] OvmfPkg/XenResetVector: Allow jumpstart from either hvmloader or PVH

2019-07-05 Thread Laszlo Ersek
d a extra parameter to indicate where to start the search for the > boot firmware volume. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Laszlo Ersek > --- > > Notes: > v3: > - rebased, SPDX >

Re: [Xen-devel] [PATCH v3 09/35] OvmfPkg/OvmfXen: use a TimerLib instance that depends only on the CPU

2019-07-05 Thread Laszlo Ersek
es: > v3: > - cleanup .dsc, leave only one TimerLib resolution > - Added a note in the commit message regarding the use of the local apic > by runtime drivers Good note -- yes, the warning in "MdePkg/Library/SecPeiDxeTimerLibCpu/SecPeiDxeTimerLibCpu.inf" applie

Re: [Xen-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-05 Thread Laszlo Ersek
On 07/04/19 16:41, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v3 > > Hi, > > I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc > with the goal to make it work on both

Re: [Xen-devel] [PATCH v3 04/35] OvmfPkg: Introduce XenPlatformPei

2019-07-05 Thread Laszlo Ersek
initialization fails if Xen has not been > detected. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v3: > - fix coding style in new code > (use DEBUG_xxx,

Re: [Xen-devel] [PATCH v3 02/35] OvmfPkg: Create platform OvmfXen

2019-07-05 Thread Laszlo Ersek
++ > OvmfPkg/OvmfXen.fdf | 439 ++ > 2 files changed, 1168 insertions(+) > create mode 100644 OvmfPkg/OvmfXen.dsc > create mode 100644 OvmfPkg/OvmfXen.fdf Reviewed-by: Laszlo Ersek ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-05 Thread Laszlo Ersek
Hi Anthony, On 07/04/19 16:41, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v3 > > Hi, > > I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc > with the goal to make it

Re: [Xen-devel] [PATCH v3 33/35] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

2019-07-10 Thread Laszlo Ersek
On 07/04/19 16:42, Anthony PERARD wrote: > XenIoPvhDxe use XenIoMmioLib to reserve some space to be use by the > Grant Tables. > > The call is only done if it is necessary, we simply detect if the > guest is PVH, as in this case there is currently no PCI bus, and no > PCI Xen platform device

Re: [Xen-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-10 Thread Laszlo Ersek
On 07/04/19 16:41, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v3 > > Hi, > > I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc > with the goal to make it work on both

Re: [Xen-devel] [PATCH v3 17/35] OvmfPkg/XenPlatformPei: Reinit XenHypercallLib

2019-07-08 Thread Laszlo Ersek
ages (TransferPages); > @@ -152,6 +154,13 @@ XenConnect ( > sizeof(mXenInfo) > ); > > + // > + // Initialize the XenHypercall library, now that the XenInfo HOB is > + // available > + // > + Status = XenHypercallLibInit (); > + ASSERT_RETURN_ERROR (Status); >

Re: [Xen-devel] [PATCH v3 26/35] OvmfPkg/XenPlatformPei: Ignore missing PCI Host Bridge on Xen PVH

2019-07-08 Thread Laszlo Ersek
ridge Device ID: 0x%04x\n", > __FUNCTION__, mHostBridgeDevId)); >ASSERT (FALSE); > Acked-by: Laszlo Ersek ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 13/35] OvmfPkg/Library/XenPlatformLib: New library

2019-07-08 Thread Laszlo Ersek
running under Xen and > +* allow to get more information when it is the case. > +* > +* Copyright (c) 2019, Citrix Systems, Inc. > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +* > +**/ These comment blocks should not have a column of "*" to the left. With tha

Re: [Xen-devel] [PATCH v3 16/35] OvmfPkg/XenHypercallLib: Enable it in PEIM

2019-07-08 Thread Laszlo Ersek
URN_STATUS > +EFIAPI > +XenHypercallLibConstruct ( > + VOID > + ) > +{ > + XenHypercallLibInit (); > + // > + // We don't fail library construction, since that has catastrophic > + // consequences for client modules (whereas those modules may easily be > + // running on a n

Re: [Xen-devel] [PATCH v3 14/35] OvmfPkg/AcpiPlatformDxe: Use XenPlatformLib

2019-07-08 Thread Laszlo Ersek
h, splited from the next patch > (which was OvmfPkg/AcpiPlatformDxe: Use PVH RSDP if exist) Reviewed-by: Laszlo Ersek ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 15/35] OvmfPkg/AcpiPlatformDxe: Use Xen PVH RSDP if it exist

2019-07-08 Thread Laszlo Ersek
// First look for PVH one > + // > + XenInfo = XenGetInfoHOB (); > + ASSERT (XenInfo != NULL); > + if (XenInfo->RsdpPvh != NULL) { > +DEBUG ((DEBUG_INFO, "%a: Use ACPI RSDP table at 0x%p\n", > +gEfiCallerBaseName, XenInfo->RsdpPvh)); (1) Please fix the ind

Re: [edk2-devel] [PATCH v2 02/31] OvmfPkg: Create platform XenOvmf

2019-04-10 Thread Laszlo Ersek
On 04/10/19 11:48, Jordan Justen wrote: > On 2019-04-09 04:08:15, Anthony PERARD wrote: >> This is a copy of OvmfX64, removing VirtIO and some SMM. >> >> This new platform will be changed to make it works on two types of Xen >> guest: HVM and PVH. >> >> Compare to OvmfX64, this patch: >> >> -

[edk2-devel] [PATCH 3/4] OvmfPkg/IndustryStandard/Xen: replace MIT license text with SPDX ID

2019-04-10 Thread Laszlo Ersek
nocore.org/show_bug.cgi?id=1654 Signed-off-by: Laszlo Ersek --- OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h| 18 +- OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h | 18 +- OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h

[edk2-devel] [PATCH 1/4] OvmfPkg/License.txt: remove XenPvBlkDxe from the MIT licensed dir list

2019-04-10 Thread Laszlo Ersek
lists.xenproject.org Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1654 Signed-off-by: Laszlo Ersek --- OvmfPkg/License.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/OvmfPkg/License.txt b/OvmfPkg/License.txt index 0666e1bac65e..a2e02a1796aa 100644 --- a/OvmfPkg/License.txt +++ b

[edk2-devel] [PATCH 2/4] OvmfPkg/License.txt: refresh the MIT license text and include the SPDX ID

2019-04-10 Thread Laszlo Ersek
ten Cc: Julien Grall Cc: Lars Kurth Cc: xen-devel@lists.xenproject.org Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1654 Signed-off-by: Laszlo Ersek --- OvmfPkg/License.txt | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/License.txt b/OvmfPkg

[edk2-devel] [PATCH 0/4] OvmfPkg: replace MIT license blocks with SPDX IDs

2019-04-10 Thread Laszlo Ersek
the MIT license blocks with the corresponding SPDX License IDs. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Cc: Lars Kurth Cc: xen-devel@lists.xenproject.org Thanks, Laszlo Laszlo Ersek (4): OvmfPkg/License.txt: remove XenPvBlkDxe from the MIT licensed dir list OvmfPk

[edk2-devel] [PATCH 4/4] OvmfPkg/XenBusDxe: replace MIT license text with SPDX ID

2019-04-10 Thread Laszlo Ersek
roject.org Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1654 Signed-off-by: Laszlo Ersek --- OvmfPkg/XenBusDxe/XenStore.h | 18 +- OvmfPkg/XenBusDxe/XenBus.c | 18 +- OvmfPkg/XenBusDxe/XenStore.c | 18 +- 3 files changed, 3 insertions(

Re: [edk2-devel] [PATCH v2 29/31] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

2019-04-16 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > This "device" use XenIoMmioLib to reserve some space to be use by the > Grant Tables. (1) can we replace "this device" with "XenIoPvhDxe"? > > The call is only done if it is necessary, we simply detect if the guest > is probably PVH, as in this case

Re: [edk2-devel] [PATCH v2 30/31] OvmfPkg: Move XenRealTimeClockLib from ArmVirtPkg

2019-04-16 Thread Laszlo Ersek
On 04/09/19 13:08, Anthony PERARD wrote: > So it can be used from the OvmfPkg by the following patch, > "OvmfPkg/XenOvmf: use RealTimeClockRuntimeDxe from EmbeddedPkg" (1) Please make the commit message self-contained. with that, Reviewed-by: Laszlo Ersek Thanks Laszlo >

Re: [edk2-devel] [PATCH v2 31/31] OvmfPkg/XenOvmf: use RealTimeClockRuntimeDxe from EmbeddedPkg

2019-04-16 Thread Laszlo Ersek
Xen.dsc", that is, please resolve the RealTimeClockLib class to XenRealTimeClockLib.inf globally, under [LibraryClasses]. With that, Acked-by: Laszlo Ersek Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39160): https://edk

Re: [Xen-devel] [PATCH v3 27/35] OvmfPkg/XenPlatformLib: Cache result for XenDetected

2019-07-10 Thread Laszlo Ersek
N_INFO *) GET_GUID_HOB_DATA (GuidHob); >} > - > - return (EFI_XEN_INFO *) GET_GUID_HOB_DATA (GuidHob); > + Cached = TRUE; > + return XenInfo; > } > > /** > This will work fine in DXE modules (and by the end of the series, only DXE modules use XenPlatformLib

Re: [Xen-devel] [PATCH v3 29/35] OvmfPkg/PlatformBootManagerLib: Handle the absence of PCI bus on Xen PVH

2019-07-10 Thread Laszlo Ersek
0x6b), 0x0b); // H >break; > default: > + if (XenDetected ()) { > +// > +// There is no PCI bus in this case. > +// > +return; > + } >DEBUG ((EFI_D_ERROR, "%a: Unknown Host Bridge Device ID: 0x%

Re: [Xen-devel] [PATCH v3 31/35] OvmfPkg/OvmfXen: Introduce XenTimerDxe

2019-07-10 Thread Laszlo Ersek
- rebased, SPDX, copyright (1) Please replace both occurrences of "PcAtChipsetPkg" in the commit message with "OvmfPkg". (You rebased the DSC/FDF files correctly, but missed the commit message.) With that: Acked-by: Laszlo Ersek ___ Xe

Re: [Xen-devel] [PATCH v3 14/35] OvmfPkg/AcpiPlatformDxe: Use XenPlatformLib

2019-07-10 Thread Laszlo Ersek
On 07/08/19 16:38, Laszlo Ersek wrote: > On 07/04/19 16:42, Anthony PERARD wrote: >> This patch replace the XenDetected() function by the one in >> XenPlatformLib. >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 >> Signed-off-by: Anthony PERA

Re: [Xen-devel] [PATCH v3 28/35] OvmfPkg/PlatformBootManagerLib: Use XenDetected from XenPlatformLib

2019-07-10 Thread Laszlo Ersek
; > - if (GuidHob == NULL) { > -FoundHob = 0; > -return FALSE; > - } > - > - FoundHob = 1; > - return TRUE; > -} > - > EFI_STATUS > EFIAPI > ConnectRecursivelyIfPciMassStorage ( > Is it possible to clean up the remaining code a bit more, such as

Re: [Xen-devel] [PATCH v3 32/35] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn

2019-07-10 Thread Laszlo Ersek
ful. Because now that I'm looking at VENDOR_UART_DEVICE_PATH, it seems that we don't need the new type XEN_CONSOLE_DEVICE_PATH at all. Is that right? So: (1) Please drop XEN_CONSOLE_DEVICE_PATH. (2) Please replace the comment Debug Agent UART Device Path structure with Vendor UART Device Path

Re: [Xen-devel] [edk2-devel] [PATCH v5 20/35] OvmfPkg/XenPlatformPei: Introduce XenPvhDetected

2019-08-15 Thread Laszlo Ersek
On 08/13/19 13:31, Anthony PERARD wrote: > XenPvhDetected() can be used to figure out if OVMF has started via the > Xen PVH entry point. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Laszlo Ersek > ---

Re: [Xen-devel] [edk2-devel] [PATCH v5 31/35] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn

2019-08-15 Thread Laszlo Ersek
core.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v5: > - fix typos in commit message. Thanks for those fixes, my R-b stands. Laszlo > v4: > - instead of creating a new XEN_CONSOLE_DEVICE_PA

Re: [Xen-devel] [edk2-devel] [PATCH v5 33/35] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

2019-08-15 Thread Laszlo Ersek
en platform device which would start the XenIoPciDxe and allocate > the space for the Grant Tables. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v5: > - add m

Re: [Xen-devel] [edk2-devel] [PATCH v5 23/35] OvmfPkg/XenPlatformPei: Rework memory detection

2019-08-15 Thread Laszlo Ersek
have sane default. MTRR will need > to be done properly but keeping what's already been done by programs > that have run before OVMF will do for now. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Laszlo Ersek &

Re: [Xen-devel] [edk2-devel] [PATCH v5 32/35] OvmfPkg: Introduce PcdXenGrantFrames

2019-08-15 Thread Laszlo Ersek
igned-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v5: > - add missing PcdLib to [LibraryClasses] Yes, that's for 365f2b95-b6c9-03cf-5346-5e1192bfa437@redhat.com">http://mid.mail-archive.com/365f2b95-b6c9-03cf-5346-5e1192bfa437@redhat.c

Re: [Xen-devel] [edk2-devel] [PATCH v5 32/35] OvmfPkg: Introduce PcdXenGrantFrames

2019-08-15 Thread Laszlo Ersek
On 08/15/19 11:40, Laszlo Ersek wrote: > On 08/13/19 13:31, Anthony PERARD wrote: >> Introduce PcdXenGrantFrames to replace a define in XenBusDxe and allow >> the same value to be used in a different module. >> >> The reason for the number of page to be 4 doesn't exist a

Re: [Xen-devel] [edk2-devel] [PATCH v5 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-08-15 Thread Laszlo Ersek
On 08/13/19 13:30, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v5 > > Changes in v5: > - patch 23 got a rework of the lapic range skipping > - small fixups in patch 20, 22, 23, 31, 32, 33. >

Re: [Xen-devel] [edk2-devel] [PATCH v5 22/35] OvmfPkg/XenPlatformPei: no hvmloader: get the E820 table via hypercall

2019-08-15 Thread Laszlo Ersek
h would give the same result. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Laszlo Ersek > --- > > Notes: > v5: > - fix commit message, the hypercall *can* be made several time, but we >

Re: [Xen-devel] [edk2-devel] [PATCH v4 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-08-13 Thread Laszlo Ersek
On 08/12/19 17:12, Anthony PERARD wrote: > On Tue, Jul 30, 2019 at 03:10:13PM +0200, Laszlo Ersek wrote: >> Hi Anthony, >> >> On 07/29/19 17:39, Anthony PERARD wrote: >>> Patch series available in this git branch: >>> https://xenbits.xen.org/git-http/peopl

Re: [Xen-devel] [PATCH v3 32/35] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn

2019-07-23 Thread Laszlo Ersek
On 07/22/19 19:06, Anthony PERARD wrote: > On Wed, Jul 10, 2019 at 12:48:57PM +0200, Laszlo Ersek wrote: >> On 07/04/19 16:42, Anthony PERARD wrote: >>> On a Xen PVH guest, none of the existing serial or console interface >>> works, so we add a new one, based

Re: [Xen-devel] [PATCH v3 24/35] OvmfPkg/XenPlatformPei: Rework memory detection

2019-07-22 Thread Laszlo Ersek
t;>> already done by hvmloader, on PVH it is supposed to have sane default. >>> >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 >>> Signed-off-by: Anthony PERARD >>> Acked-by: Laszlo Ersek >>> --- >>> >>> Notes: >>

Re: [Xen-devel] [PATCH v3 09/35] OvmfPkg/OvmfXen: use a TimerLib instance that depends only on the CPU

2019-07-22 Thread Laszlo Ersek
On 07/22/19 15:49, Anthony PERARD wrote: > On Mon, Jul 15, 2019 at 04:22:19PM +0200, Roger Pau Monné wrote: >> On Thu, Jul 04, 2019 at 03:42:07PM +0100, Anthony PERARD wrote: >>> ACPI Timer does not work in a PVH guest, but local APIC works on both >> >> This is not accurate. It's not that the

Re: [Xen-devel] [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-22 Thread Laszlo Ersek
On 07/19/19 18:42, Anthony PERARD wrote: > On Fri, Jul 05, 2019 at 02:21:13PM +0200, Laszlo Ersek wrote: >> The patches on the list are malformed. They have >> >> Content-Transfer-Encoding: quoted-printable >> >> which is fine, in itself; however, th

Re: [Xen-devel] [PATCH v3 24/35] OvmfPkg/XenPlatformPei: Rework memory detection

2019-07-22 Thread Laszlo Ersek
On 07/22/19 21:45, Laszlo Ersek wrote: > we place the 32-bit PCI IOMMU aperture based on [...] Do I get a medal for this hugely confusing typo? :) In earnest, I'm sorry about it -- my comment had nothing to do with "IOMMU"; I meant "MMIO". (At least I got it right i

Re: [Xen-devel] [PATCH v3 06/35] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2019-07-19 Thread Laszlo Ersek
On 07/19/19 12:20, Anthony PERARD wrote: > On Fri, Jul 05, 2019 at 02:57:06PM +0100, Andrew Cooper wrote: >> On 04/07/2019 15:42, Anthony PERARD wrote: >>> diff --git a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm >>> b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm >>> new file mode 100644

Re: [Xen-devel] [edk2-devel] [PATCH v4 05/35] OvmfPkg/OvmfXen: Creating an ELF header

2019-07-30 Thread Laszlo Ersek
r, but this will be a manual step. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Laszlo Ersek > --- > > Notes: > v4: > - fix top-level comment style > - Update Maintainers.txt > >

Re: [Xen-devel] [edk2-devel] [PATCH v4 06/35] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2019-07-30 Thread Laszlo Ersek
seems to be > useful. This is the entry point used by HVM guest (hvmloader). > > [1] UefiCpuPkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Laszlo Ersek > --- > &g

Re: [Xen-devel] [edk2-devel] [PATCH v4 02/35] OvmfPkg: Create platform OvmfXen

2019-07-30 Thread Laszlo Ersek
, "OvmfPkg: raise DXEFV size to 11 MB" > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v4: > - rebased > - Update Maintainers.

Re: [Xen-devel] [edk2-devel] [PATCH v4 04/35] OvmfPkg: Introduce XenPlatformPei

2019-07-30 Thread Laszlo Ersek
ntainers.txt > index 34bdb275b4..42ec8d54af 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -379,6 +379,7 @@ F: OvmfPkg/PlatformPei/Xen.* > F: OvmfPkg/SmbiosPlatformDxe/*Xen.c > F: OvmfPkg/XenBusDxe/ > F: OvmfPkg/XenIoPciDxe/ > +F: OvmfPkg/XenPlatformPei/ > F: OvmfPkg/XenPvBlkDxe/ > F: OvmfPkg/XenResetVector/ > R: Anthony Perard > Reviewed-by: Laszlo Ersek ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [edk2-devel] [PATCH v4 13/35] OvmfPkg/Library/XenPlatformLib: New library

2019-07-30 Thread Laszlo Ersek
by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v4: > - fix top-level comment style > - Update Maintainers.txt > > v3: > - use SPDX > - add XenPlatformLib.h to [LibraryClasses] in OvmfPkg.dec > - fix typos &g

  1   2   >