[Xen-devel] [PATCH] libxc: check for null size file mapping

2018-02-12 Thread Paul Semel
. With this change, we get a `zero length file` error. Signed-off-by: Paul Semel <semelp...@gmail.com> --- tools/libxc/xc_dom_core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c index 96e71dd2d9..9bd04cb2d5 100644 --- a/tools

[Xen-devel] [xen-devel] [fuzz] [x86 emulator] Input size

2018-02-22 Thread Paul Semel
ds should rather be : DATA_OFFSET < size < sizeof (struct fuzz_corpus) but maybe I am missing something here  Thanks, -- Paul Semel ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Paul Semel
On 02/23/2018 05:30 PM, Wei Liu wrote: On Fri, Feb 23, 2018 at 12:57:26AM +0100, Paul Semel wrote: The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array to be filled. This is not needed for the fuzzer

[Xen-devel] [PATCH v2] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Paul Semel
The maximum size for the input size was set to INPUT_SIZE, which is actually the size of the data array inside the fuzz_corpus structure and so was not abling user (or AFL) to fill in the whole structure. Changing to sizeof(struct fuzz_corpus) correct this problem. Signed-off-by: Paul Semel

[Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-22 Thread Paul Semel
the size of the data array inside the fuzz_corpus structure and so was not abling user (or AFL) to fill in the whole structure. Changing to sizeof(struct fuzz_corpus) correct this problem. Signed-off-by: Paul Semel <semelp...@gmail.com> --- tools/fuzz/x86_instruction_emulator/fuzz-emul

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Paul Semel
On 02/23/2018 11:44 AM, George Dunlap wrote: Paul, thanks for reporting this! A couple of comments... On 02/22/2018 11:57 PM, Paul Semel wrote: The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array

Re: [Xen-devel] [XTF] [PATCH v2] lib.c: added unsigned 64bits division for 32 bits arch

2018-04-07 Thread Paul Semel
On 04/07/2018 09:53 PM, Andrew Cooper wrote: On 07/04/18 20:35, Paul Semel wrote: this is a simple implementation of unsigned 64bits divisions for 32 bits archs. Signed-off-by: Paul Semel <semelp...@gmail.com> I'm terribly sorry not to have spotted this before, but the code actually

[Xen-devel] [XTF] [PATCH v2] lib.c: added unsigned 64bits division for 32 bits arch

2018-04-07 Thread Paul Semel
this is a simple implementation of unsigned 64bits divisions for 32 bits archs. Signed-off-by: Paul Semel <semelp...@gmail.com> --- arch/x86/include/arch/lib.h | 2 ++ arch/x86/lib.c | 37 + build/files.mk | 1 + 3 files chang

Re: [Xen-devel] [PATCH v3 1/7] introduce time managment in xtf

2018-04-10 Thread Paul Semel
conds from the moment the VM has booted Signed-off-by: Paul Semel <phen...@amazon.de> --- This seems to be missing a list of changes between v2 and v3. Please add such a list when posting new versions. +uint64_t since_boot_time(void) +{ +uint64_t tsc; +uint32_t ver1, ver2; +uint

Re: [Xen-devel] [PATCH v3 1/7] introduce time managment in xtf

2018-04-10 Thread Paul Semel
conds from the moment the VM has booted Signed-off-by: Paul Semel <phen...@amazon.de> --- This seems to be missing a list of changes between v2 and v3. Please add such a list when posting new versions. +uint64_t since_boot_time(void) +{ +uint64_t tsc; +uint32_t ver1, ver2; +uint

Re: [Xen-devel] [PATCH v3 1/7] introduce time managment in xtf

2018-04-10 Thread Paul Semel
conds from the moment the VM has booted Signed-off-by: Paul Semel <phen...@amazon.de> --- This seems to be missing a list of changes between v2 and v3. Please add such a list when posting new versions. +uint64_t since_boot_time(void) +{ +uint64_t tsc; +uint32_t ver1, ver2; +uint

[Xen-devel] [PATCH v2 2/7] add current_time function to time manager

2018-04-08 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this function returns the "epoch" time Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 18 ++ include/xtf/time.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/common/time.c b/commo

[Xen-devel] [PATCH v2 1/7] introduce time managment in xtf

2018-04-08 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this file is introduce to be able to implement an inter domain communication protocol over xenstore. For synchronization purpose, we do really want to be able to "control" time common/time.c: since_boot_time gets the time in nanoseconds from t

[Xen-devel] [PATCH v2 7/7] add sleep, msleep and NOW() macros to time manager

2018-04-08 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 10 ++ include/xtf/time.h | 12 2 files changed, 22 insertions(+) diff --git a/common/time.c b/common/time.c index f75979a..246a2dd 100644 --- a/common/

[Xen-devel] [PATCH v2 3/7] add gettimeofday function to time managment

2018-04-08 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 23 +++ include/xtf/time.h | 7 +++ 2 files changed, 30 insertions(+) diff --git a/common/time.c b/common/time.c index 3e8e8ce..1f0f289 100644 --- a/c

[Xen-devel] [PATCH v2 6/7] add mspin_sleep function to time manager

2018-04-08 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/common/time.c b/common/time.c index 67fe049..f75979a 100644 --- a/common/time.c +++ b/common/time.c @@ -125,6 +125,12 @@ s

[Xen-devel] [PATCH v2 5/7] add spin_sleep function to time manager

2018-04-08 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/common/time.c b/common/time.c index 1d7fef5..67fe049 100644 --- a/common/time.c +++ b/common/time.c @@ -119,6 +119,12 @@ s

[Xen-devel] [PATCH v2 4/7] add nspin_sleep function to time manager

2018-04-08 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 9 + 1 file changed, 9 insertions(+) diff --git a/common/time.c b/common/time.c index 1f0f289..1d7fef5 100644 --- a/common/time.c +++ b/common/time.c @@ -110,6 +1

[Xen-devel] [PATCH v2 (fix)] introduce time managment in xtf

2018-04-08 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this file is introduce to be able to implement an inter domain communication protocol over xenstore. For synchronization purpose, we do really want to be able to "control" time common/time.c: since_boot_time gets the time in nanoseconds from t

Re: [Xen-devel] [PATCH 1/7] introduce time managment in xtf

2018-04-08 Thread Paul Semel
On 04/07/2018 10:58 PM, Paul Semel wrote: On 04/07/2018 10:39 PM, Andrew Cooper wrot>>>>> However, both of your patches have (different) barrier issues, and different (mis)uses of the shared memory clocks, which will need to be addressed. One general comment for the full series i

[Xen-devel] [PATCH v4 1/7] introduce time managment in xtf

2018-04-10 Thread Paul Semel
this file is introduce to be able to implement an inter domain communication protocol over xenstore. For synchronization purpose, we do really want to be able to "control" time common/time.c: since_boot_time gets the time in nanoseconds from the moment the VM has booted Signed-off-by:

[Xen-devel] [PATCH v4 5/7] add spin_sleep function to time manager

2018-04-10 Thread Paul Semel
this function uses nspin_sleep to spin sleep for t seconds Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - new patch version common/time.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/common/time.c b/common/time.c index 232e134..87db124 100644 --- a/

[Xen-devel] [PATCH v4 7/7] add sleep, msleep and NOW() macros to time manager

2018-04-10 Thread Paul Semel
those are helpful macro to use the time manager correctly Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - new patch version common/time.c | 10 ++ include/xtf/time.h | 12 2 files changed, 22 insertions(+) diff --git a/common/time.c b/

[Xen-devel] [PATCH v4 4/7] add nspin_sleep function to time manager

2018-04-10 Thread Paul Semel
this function spin sleeps for t nanoseconds Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - new patch version common/time.c | 12 1 file changed, 12 insertions(+) diff --git a/common/time.c b/common/time.c index 8489f3b..232e134 100644 --- a/common/

[Xen-devel] [PATCH v4 6/7] add mspin_sleep function to time manager

2018-04-10 Thread Paul Semel
this function uses mspin_sleep to spin sleep for t milliseconds Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - new patch version common/time.c | 6 ++ include/xtf/time.h | 1 + 2 files changed, 7 insertions(+) diff --git a/common/time.c b/common/time.c

[Xen-devel] [PATCH v4 2/7] add current_time function to time manager

2018-04-10 Thread Paul Semel
this function returns the "epoch" time Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - new patch version common/time.c | 39 +++ include/xtf/time.h | 5 + 2 files changed, 44 insertions(+) diff --git a/common

[Xen-devel] [PATCH v4 3/7] add gettimeofday function to time managment

2018-04-10 Thread Paul Semel
this function acts as the POSIX gettimeofday function Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - new patch version common/time.c | 30 ++ include/xtf/time.h | 8 2 files changed, 38 insertions(+) diff --git a/common/

Re: [Xen-devel] [PATCH v3 1/7] introduce time managment in xtf

2018-04-09 Thread Paul Semel
conds from the moment the VM has booted Signed-off-by: Paul Semel <phen...@amazon.de> --- This seems to be missing a list of changes between v2 and v3. Please add such a list when posting new versions. +uint64_t since_boot_time(void) +{ +uint64_t tsc; +uint32_t ver1, ver2; +uint

[Xen-devel] [XTF] [PATCH] lib.c: added unsigned 64bits division for 32 bits arch

2018-04-07 Thread Paul Semel
this is a simple implementation of unsigned 64bits divisions for 32 bits archs. Signed-off-by: Paul Semel <semelp...@gmail.com> --- common/lib.c | 21 + include/xtf/lib.h | 4 2 files changed, 25 insertions(+) diff --git a/common/lib.c b/common/lib.c index a

Re: [Xen-devel] [PATCH 1/7] introduce time managment in xtf

2018-04-07 Thread Paul Semel
On 04/07/2018 10:39 PM, Andrew Cooper wrot> However, both of your patches have (different) barrier issues, and different (mis)uses of the shared memory clocks, which will need to be addressed. One general comment for the full series is to not bother trying to make time 32bits in a 32bit

[Xen-devel] [PATCH v3 2/7] add current_time function to time manager

2018-04-09 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this function returns the "epoch" time Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 39 +++ include/xtf/time.h | 4 2 files changed, 43 insertions(+) diff --git a/

[Xen-devel] [PATCH v3 5/7] add spin_sleep function to time manager

2018-04-09 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this function uses nspin_sleep to spin sleep for t seconds Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/common/time.c b/common/time.c index 4770b9a..e744ab1 100644

[Xen-devel] [PATCH v3 1/7] introduce time managment in xtf

2018-04-09 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this file is introduce to be able to implement an inter domain communication protocol over xenstore. For synchronization purpose, we do really want to be able to "control" time common/time.c: since_boot_time gets the time in nanoseconds from t

[Xen-devel] [PATCH v3 6/7] add mspin_sleep function to time manager

2018-04-09 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this function uses mspin_sleep to spin sleep for t milliseconds Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 6 ++ include/xtf/time.h | 1 + 2 files changed, 7 insertions(+) diff --git a/common/time.c b/common/

[Xen-devel] [PATCH v3 4/7] add nspin_sleep function to time manager

2018-04-09 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this function spin sleeps for t nanoseconds Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 12 1 file changed, 12 insertions(+) diff --git a/common/time.c b/common/time.c index d0c9ed2..4770b9a 100644 --- a/c

[Xen-devel] [PATCH v3 7/7] add sleep, msleep and NOW() macros to time manager

2018-04-09 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> those are helpful macro to use the time manager correctly Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 10 ++ include/xtf/time.h | 12 2 files changed, 22 insertions(+) diff --git a/common/tim

[Xen-devel] [PATCH v3 3/7] add gettimeofday function to time managment

2018-04-09 Thread Paul Semel
From: Paul Semel <phen...@amazon.de> this function acts as the POSIX gettimeofday function Signed-off-by: Paul Semel <phen...@amazon.de> --- common/time.c | 30 ++ include/xtf/time.h | 7 +++ 2 files changed, 37 insertions(+) diff --git a/com

Re: [Xen-devel] [PATCH v4 3/7] add gettimeofday function to time managment

2018-04-16 Thread Paul Semel
Hi ! Thanks a lot for reviewing ! On 04/13/2018 03:39 PM, Roger Pau Monné wrote: On Tue, Apr 10, 2018 at 09:16:57PM +0200, Paul Semel wrote: this function acts as the POSIX gettimeofday function Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - new patch v

Re: [Xen-devel] [PATCH v4 7/7] add sleep, msleep and NOW() macros to time manager

2018-04-16 Thread Paul Semel
On 04/13/2018 03:55 PM, Roger Pau Monné wrote: those are helpful macro to use the time manager correctly Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - new patch version common/time.c | 10 ++ include/xtf/time.h | 12 2 files chang

Re: [Xen-devel] [PATCH v4 1/7] introduce time managment in xtf

2018-04-16 Thread Paul Semel
conds from the moment the VM has booted Signed-off-by: Paul Semel <phen...@amazon.de> --- Notes: v4: - moved rdtsc to arch/x86/include/arch/lib.h - added a rdtsc_ordered implementation to serialize rdtsc - simplified since_boot_time function - still need to have Andr

Re: [Xen-devel] [PATCH v2] fuzz/x86_emulate: fix bounds for input size

2018-02-28 Thread Paul Semel
Hey George, On 02/27/2018 11:39 AM, George Dunlap wrote: Thanks for the patch. Looking a bit more at the code over the weekend, I figured out what that BUILD_BUG_ON() is for -- in afl_harness.c, we statically allocate a buffer of size INPUT_SIZE to hold the fuzz data. The BUILD_BUG_ON() is to