Re: [Xen-devel] [PULL 0/6] xen-20171214-tag

On 15 December 2017 at 00:27, Stefano Stabellini wrote: > The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639: > > Update version for v2.11.0 release (2017-12-13 14:31:09 +) > > are available in the git repository at: > >

Re: [Xen-devel] [RESEND PULL v9 00/16] xen: xen-domid-restrict improvements

On 26 April 2018 at 19:15, Ian Jackson wrote: > The following changes since commit b8846a4d6352b2a1d2012f8b3b9115640524aeda: > > vl.c: new function serial_max_hds() (2018-04-26 13:58:29 +0100) > > are available in the git repository at: > >

Re: [Xen-devel] [PULL v2 00/15] xen-20180522-tag

On 22 May 2018 at 19:46, Stefano Stabellini wrote: > The following changes since commit d32e41a1188e929cc0fb16829ce3736046951e39: > > Merge remote-tracking branch > 'remotes/famz/tags/docker-and-block-pull-request' into staging (2018-05-18 > 14:11:52 +0100) > > are

Re: [Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

On 5 June 2018 at 17:55, Anthony PERARD wrote: > On Fri, Jun 01, 2018 at 06:59:10PM +0100, Peter Maydell wrote: >> The xen pci_assign_dev_load_option_rom() currently creates a RAM >> memory region with memory_region_init_ram_nomigrate(), and then >> manually registers it with

Re: [Xen-devel] [PULL 0/3] xen-20180531-tag

On 31 May 2018 at 20:08, Stefano Stabellini wrote: > The following changes since commit c181ddaa176856b3cd2dfd12bbcf25fa9c884a97: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180531-1' into staging (2018-05-31 > 17:00:55 +0100) > > are available in the git

[Xen-devel] [RFC] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom()

use for the vmstate_register_ram() call refer to the same object. Simplify the function to only take a pointer to the device once instead of twice, and use memory_region_init_ram() which automatically does the vmstate register for us. Signed-off-by: Peter Maydell --- This is a fairly trivial no-behaviour-cha

Re: [Xen-devel] [PULL v9 00/16] xen: xen-domid-restrict improvements

On 26 April 2018 at 16:56, Ian Jackson wrote: > From: Ian Jackson > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > The following changes since commit b8846a4d6352b2a1d2012f8b3b9115640524aeda: > > vl.c: new function serial_max_hds()

Re: [Xen-devel] [PULL v9 00/16] xen: xen-domid-restrict improvements

On 26 April 2018 at 18:36, Ian Jackson <ian.jack...@citrix.com> wrote: > Peter Maydell writes ("Re: [PULL v9 00/16] xen: xen-domid-restrict > improvements"): >> Hi -- my apply-pullreq script thinks this isn't a signed tag: >> >> error: remotes/iwj/for-up

Re: [Xen-devel] [Qemu-devel] [PATCH 4/8] xen: Remove useless casts

On 4 July 2018 at 16:39, Philippe Mathieu-Daudé wrote: > Patch created mechanically by rerunning: > > $ spatch --sp-file scripts/coccinelle/typecast.cocci \ > --macro-file scripts/cocci-macro-file.h \ > --dir . --in-place > > Signed-off-by: Philippe Mathieu-Daudé > ---

Re: [Xen-devel] [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid

nz...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Daniel P. Berrange <berra...@redhat.com> > CC: Michael Tokarev <m...@tls.msk.ru> > --- Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM __

Re: [Xen-devel] [PATCH] qemu: include generated files with <> and not ""

On 20 March 2018 at 09:44, Daniel P. Berrangé wrote: > We can follow what autoconf does, and add a check to configure to see if > there are generated files left in the source dir, when configuring with > builddir != srcdir, and exit with error, telling user to clean their >

Re: [Xen-devel] [PULL 00/20] Trivial patches patches

On 26 October 2018 at 16:31, Laurent Vivier wrote: > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > > are available in the Git repository

Re: [Xen-devel] [PULL v2 00/20] Qemu trivial for 3.1 patches

On 30 October 2018 at 11:23, Laurent Vivier wrote: > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > > are available in the Git repository

Re: [Xen-devel] Xen boot failure on QEMU (WAS: Re: [PATCH v3] xen:arm: Populate arm64 image header)

On 8 October 2018 at 19:00, Julien Grall wrote: > Per the Linux arm64 booting protocol [1], the load offset can definitely be > 0. The bootloader (here QEMU) should not assume a specific text offset, > Linux actually provides an option to randomize the text offset in order to > test that

Re: [Xen-devel] [PULL 00/25] Xen queue v2

On Mon, 14 Jan 2019 at 13:52, Anthony PERARD wrote: > > The following changes since commit 7260438b7056469610ee166f7abe9ff8a26b8b16: > > Merge remote-tracking branch > 'remotes/palmer/tags/riscv-for-master-3.2-part2' into staging (2019-01-14 > 11:41:43 +) > > are available in the Git

Re: [Xen-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

On Mon, 21 Jan 2019 at 14:49, Anthony PERARD wrote: > > When Xen is detected via pkg-config, it isn't necessary to modify > LDFLAGS as modifying libs_softmmu is enough. > > Reported-by: Peter Maydell > Signed-off-by: Anthony PERARD > --- > configure | 1 - >

Re: [Xen-devel] [PATCH] hw/block/xen: use proper format string for printing sectors

On Wed, 16 Jan 2019 at 12:13, Alex Bennée wrote: > > The %lu format string is different depending on the host architecture > which causes builds like the debian-armhf-cross build to fail. Use the > correct PRi64 format string. > > Signed-off-by: Alex Bennée > --- > hw/block/xen-block.c | 2 +- >

Re: [Xen-devel] [PATCH 09/21] configure: use pkg-config for obtaining xen version

On Tue, 25 Apr 2017 at 19:35, Stefano Stabellini wrote: > > From: Juergen Gross > > Instead of trying to guess the Xen version to use by compiling various > test programs first just ask the system via pkg-config. Only if it > can't return the version fall back to the test program scheme. > > If

Re: [Xen-devel] [PATCH 2/2] avoid TABs in files that only contain a few

On Thu, 13 Dec 2018 at 22:38, Paolo Bonzini wrote: > > Most files that have TABs only contain a handful of them. Change > them to spaces so that we don't confuse people. > > disas, standard-headers, linux-headers and libdecnumber are imported > from other projects and probably should be exempted

Re: [Xen-devel] [PATCH for-3.1] hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much

On Mon, 26 Nov 2018 at 15:03, Anthony PERARD wrote: > > On Mon, Nov 19, 2018 at 04:26:58PM +, Peter Maydell wrote: > > Coverity (CID 796599) points out that xen_pt_setup_vga() trusts > > the rom->size field in the BIOS ROM from a PCI passthrough VGA > > devi

Re: [Xen-devel] [PATCH v3 00/21] QOM'ify SysBusDeviceClass->init

On Fri, 30 Nov 2018 at 09:39, Mao Zhongyi wrote: > > v3 -> v2: > > - rebase to the HEAD > - use SysBusDevice *sbd variable in patch15 > Mao Zhongyi (21): > musicpal: Convert sysbus init function to realize function > block/noenand: Convert sysbus init function to realize function >

Re: [Xen-devel] [Qemu-devel] [PATCH 20/22] xen_backend: Convert sysbus init function to realize function

On 19 November 2018 at 12:08, Mao Zhongyi wrote: > Use DeviceClass rather than SysBusDeviceClass in > xen_sysdev_class_init(). > > Cc: sstabell...@kernel.org > Cc: anthony.per...@citrix.com > Cc: xen-devel@lists.xenproject.org > > Signed-off-by: Mao Zhongyi > Signed-off-by: Zhang Shengju > ---

[Xen-devel] [PATCH for-3.1] hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much

eck that the size is within bounds before we use it. We are also trusting the pcioffset field, and assuming that the whole rom_header is present; Coverity doesn't notice these, but check them too. Signed-off-by: Peter Maydell --- Disclaimer: compile tested only, as I don't have a Xen setup, let alone

Re: [Xen-devel] [Qemu-devel] [PULL 00/25] xen queue

On Thu, 10 Jan 2019 at 13:52, Anthony PERARD wrote: > > The following changes since commit 8ae951fbc1068308313b2c57a4fc3c68451641f4: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20190109' > into staging (2019-01-09 16:08:31 +) > > are available in the Git repository

Re: [Xen-devel] [Qemu-devel] [PATCH] xen: Fix event channel interface for XenDevice-s

On Fri, 11 Jan 2019 at 18:13, Anthony PERARD wrote: > > On Fri, Jan 11, 2019 at 06:09:41PM +, Anthony PERARD wrote: > > Patch "xen: add event channel interface for XenDevice-s" makes use of > > the type xenevtchn_port_or_error_t, but this isn't avaiable before Xen > > 4.7. Also the function

Re: [Xen-devel] [Qemu-devel] [PULL 00/25] xen queue

On Fri, 11 Jan 2019 at 15:55, Anthony PERARD wrote: > > On Fri, Jan 11, 2019 at 01:35:29PM +, Peter Maydell wrote: > > On Thu, 10 Jan 2019 at 13:52, Anthony PERARD > > wrote: > > > > > > The following changes since commit > > > 8ae951fbc1068308

Re: [Xen-devel] [PULL 0/2] xen queue for 4.0-rc3

On Fri, 5 Apr 2019 at 00:07, Anthony PERARD wrote: > > The following changes since commit f4b37171378b0b1782570060c3411a504375d1bc: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190403' into > staging (2019-04-03 13:13:30 +0100) > > are available in the Git repository at: > >

Re: [Xen-devel] [PULL 0/7] Tracing patches

On Mon, 25 Mar 2019 at 15:59, Stefan Hajnoczi wrote: > > The following changes since commit d97a39d903fe33c45be83ac6943a2f82a3649a11: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2019-03-22 09:37:38 +) > > are available in the Git

Re: [Xen-devel] [PULL 0/4] xen queue 2019-02-28

On Thu, 28 Feb 2019 at 17:34, Anthony PERARD wrote: > > The following changes since commit 711d13d5e2e160c1c3bcbd302af6df3980a99469: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-feb-27-2019' into staging (2019-02-28 > 12:59:49 +) > > are available in the Git

Re: [Xen-devel] Maintainers, please tell us how to boot your machines!

arm/integratorcp.c = > Peter Maydell (maintainer:Integrator CP) > qemu-...@nongnu.org (open list:Integrator CP) ${QEMU} \ -M integratorcp \ -kernel "${TESTDIR}"/zImage.integrator \ -initrd "${TESTDIR}"/arm_root.img -serial stdio \ -append "console=

Re: [Xen-devel] [PULL 0/1] xen queue 2019-03-19

On Tue, 19 Mar 2019 at 15:45, Anthony PERARD wrote: > > The following changes since commit b98a66201dbc7cf3b962f4bb260f66100cc75578: > > Merge remote-tracking branch > 'remotes/palmer/tags/riscv-for-master-4.0-rc0-2' into staging (2019-03-19 > 12:55:02 +) > > are available in the Git

Re: [Xen-devel] [PATCH] xen-block: stop leaking memory in xen_block_drive_create()

way. > > This patch also makes that more obvious by taking the error path if > 'params' is NULL and then asserting that both driver and filename are > non-NULL in the normal path. > > Reported-by: Peter Maydell > Signed-off-by: Paul Durrant > --- > Cc: Stefano Stabellini

Re: [Xen-devel] [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

On Thu, 24 Jan 2019 at 17:40, Eric Blake wrote: > > On 1/24/19 2:45 AM, Markus Armbruster wrote: > > >> Signed-off-by: Michael Tokarev > >> Revieved-by: Michael Tokarev > > > > Typo in Reviewed-by. > > Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:' > tags, to catch

Re: [Xen-devel] [PULL 0/4] Xen queue 20190204

On Mon, 4 Feb 2019 at 11:28, Anthony PERARD wrote: > > The following changes since commit b3fc0af1ff5e922d4dd7c875394dbd26dc7313b4: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2019-02-01 17:58:27 +) > > are available in the Git repository at: > >

Re: [Xen-devel] [PULL 0/8] xen queue 2019-06-24

On Mon, 24 Jun 2019 at 16:33, Anthony PERARD wrote: > > The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 > 15:40:50 +0100) > > are available in the Git

Re: [Xen-devel] [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE

On Fri, 16 Aug 2019 at 12:37, wrote: > > Hi Phillippe, > > On 8/16/19 7:58 PM, Philippe Mathieu-Daudé wrote: > >On 8/16/19 8:28 AM, tony.ngu...@bt.com wrote: > >> For each device declared with DEVICE_NATIVE_ENDIAN, find the set of > >> targets from the set of target/hw/*/device.o. > >> > >> If

Re: [Xen-devel] [PULL 0/4] xen queue 2019-08-27

On Tue, 27 Aug 2019 at 14:33, Anthony PERARD wrote: > > The following changes since commit dac03af5d5482ec7ee9c23db467bb7230b33c0d9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190825' into > staging (2019-08-27 10:00:51 +0100) > > are available in the Git repository at: > >

Re: [Xen-devel] [PULL v2 0/3] Trivial branch patches

On Tue, 5 Nov 2019 at 20:06, Laurent Vivier wrote: > > Le 05/11/2019 à 20:20, no-re...@patchew.org a écrit : > > Patchew URL: > > https://patchew.org/QEMU/20191105175010.2591-1-laur...@vivier.eu/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below

Re: [Xen-devel] [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

On Tue, 22 Oct 2019 at 09:52, Esteban Bosse wrote: > > El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > > +static void piix4_request_i8259_irq(void *opaque, int irq, int > > level) > > +{ > > +PIIX4State *s = opaque; > > +qemu_set_irq(s->cpu_intr, level); > > +} >

Re: [Xen-devel] [PULL 0/7] xen queue 2019-09-24

On Tue, 24 Sep 2019 at 12:31, Anthony PERARD wrote: > > The following changes since commit 2f93a3ecdd3bb060bd04f698ccafe66efd98563a: > > Merge remote-tracking branch > 'remotes/davidhildenbrand/tags/s390x-tcg-2019-09-23' into staging (2019-09-23 > 15:44:52 +0100) > > are available in the Git

Re: [Xen-devel] [PULL 0/3] Xen queue 2020-02-27

On Thu, 27 Feb 2020 at 12:16, Anthony PERARD wrote: > > The following changes since commit db736e0437aa6fd7c1b7e4599c17f9619ab6b837: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-02-25 13:31:16 +) > > are available in the Git repository at: > >

Re: [Xen-devel] [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argument

On Tue, 18 Feb 2020 at 20:07, Philippe Mathieu-Daudé wrote: > I don't understand well cpu_physical_memory*(). Aren't these obsolete? > They confuse me when using multi-core CPUs. They sort of are, but there is no simple mechanical replacement for them -- you need to look at the individual use to

Re: [Xen-devel] [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argument

On Tue, 18 Feb 2020 at 17:57, Stefan Weil wrote: > > Am 18.02.20 um 14:20 schrieb Philippe Mathieu-Daudé: > > > This commit was produced with the included Coccinelle script > > scripts/coccinelle/as-rw-const.patch. > > > > Inspired-by: Peter Maydell > >

Re: [PULL 0/3] xen queue for 5.0

On Tue, 7 Apr 2020 at 16:22, Anthony PERARD wrote: > > The following changes since commit 8f0d25c464a1989d606f7b988d07b1147dfcde33: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/acceptance-fixes-20200407' into staging > (2020-04-07 15:10:11 +0100) > > are available in the Git

Re: [PATCH 1/2] Fix undefined behaviour

On Tue, 28 Apr 2020 at 08:50, Grzegorz Uriasz wrote: > > Signed-off-by: Grzegorz Uriasz > --- > hw/xen/xen_pt_load_rom.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) The subject doesn't match the patch contents and there is no long-form part of the commit message

Re: [PATCH] xen: fix build without pci passthrough

On Tue, 19 May 2020 at 12:28, Roger Pau Monné wrote: > > On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote: > > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > > > index 179775db7b..660dd8a008 100644 > > > ---

[Xen-devel] [RFC] hw/usb/xen-usb.c: Pass struct usbback_req* to usbback_packet_complete()

the Coverity Scan analysis, resulting in the false positive CID 1421919 where it thinks that we write off the end of the structure). Since both callsites already have the pointer to the struct usbback_req, just pass that in directly. Signed-off-by: Peter Maydell --- This is an RFC because: * I'm

Re: [Xen-devel] [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen

On Mon, 16 Mar 2020 at 16:08, Philippe Mathieu-Daudé wrote: > > Xen on ARM does not use QEMU machines [*]. Disable the 'virt' > machine there to avoid odd errors such: > > CC i386-softmmu/hw/cpu/a15mpcore.o > hw/cpu/a15mpcore.c:28:10: fatal error: kvm_arm.h: No such file or directory >

Re: [PATCH 0/8] hw: Fix some incomplete memory region size

prefix definitions > hw/hppa/dino: Use the IEC binary prefix definitions > hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions > target/i386/cpu: Use the IEC binary prefix definitions whole series: Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

tion, > > returning the xen_allowed boolean. > > > > Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") > > Reported-by: Paul Durrant > > Suggested-by: Peter Maydell > > Signed-off-by: Philippe Mathieu-Daudé > > Revi

Re: [PULL 0/1] xen queue 2020-08-03

On Mon, 3 Aug 2020 at 17:53, Anthony PERARD wrote: > > xen patches > > bug fix > > > Philippe Mathieu-Daudé (1): > accel/xen: Fix xen_enabled() behavior on

Re: [PULL 0/1] xen queue 2020-08-04

On Tue, 4 Aug 2020 at 10:26, Anthony PERARD wrote: > > The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200803' into staging (2020-08-03 > 20:34:26 +0100) > > are available in the Git

Re: [PULL 0/2] xen queue 2020-07-10

On Fri, 10 Jul 2020 at 14:11, Anthony PERARD wrote: > > The following changes since commit b6d7e9b66f59ca6ebc6e9b830cd5e7bf849d31cf: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2020-07-10 09:01:28 +0100) > > are available in the Git repository

Re: [PULL 0/4] Microvm 20200617 patches

On Wed, 17 Jun 2020 at 13:33, Gerd Hoffmann wrote: > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging > (2020-06-16 14:57:15 +0100) > > are available in the

Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices

On Mon, 8 Jun 2020 at 17:00, Philippe Mathieu-Daudé wrote: > > Based on today's IRC chat, this is a trivial RFC series > to anotate pre-qdev/QOM devices so developers using them > without knowing they are not QOM'ified yet can realize > it and convert them if they have time. What mechanism did

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

On Tue, 28 Jul 2020 at 10:51, Philippe Mathieu-Daudé wrote: > I'd rather uninline xen_enabled() but I'm not sure this has perf > penalties. Paolo is that OK to uninline it? Can we just follow the same working pattern we already have for kvm_enabled() etc ? thanks -- PMM

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

On Tue, 28 Jul 2020 at 11:00, Philippe Mathieu-Daudé wrote: > Apparently kvm_enabled() checks CONFIG_KVM_IS_POSSIBLE instead > of CONFIG_KVM, I suppose to bypass this limitation (from osdep.h): > > 21 #ifdef NEED_CPU_H > 22 # ifdef CONFIG_KVM > 24 # define CONFIG_KVM_IS_POSSIBLE > 25 # endif

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

On Tue, 28 Jul 2020 at 10:19, Paul Durrant wrote: > > From: Paul Durrant > > The recent commit da278d58a092 "accel: Move Xen accelerator code under > accel/xen/" introduced a subtle semantic change, making xen_enabled() always > return false unless CONFIG_XEN is defined prior to inclusion of

Re: [PATCH v3 08/13] audio: remove GNUC & MSVC check

On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé wrote: > > On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > QEMU requires either GCC or Clang, which both advertize __GNUC__. > > Drop MSVC fallback path. > > > > Note: I intentionally left further

Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback

On Thu, 10 Dec 2020 at 14:32, Philippe Mathieu-Daudé wrote: > > On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > > version"), QEMU explicitely depends on GCC >= 4.8. > > > > (clang

Re: [PATCH v3 11/13] compiler: remove GNUC check

On Thu, 10 Dec 2020 at 13:50, wrote: > > From: Marc-André Lureau > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions. > > Signed-off-by: Marc-André Lureau > --- > include/qemu/compiler.h | 8 +--- > 1 file changed, 1 insertion(+), 7 deleti

Re: [PATCH v2 1/7] hw/board: promote fdt from ARM VirtMachineState to MachineState

On Thu, 11 Feb 2021 at 17:19, Alex Bennée wrote: > > The use of FDT's is quite common across our various platforms. To > allow the generic loader to tweak it we need to make it available in > the generic state. This creates the field and migrates the initial > user to use the generic field. Other

Re: An error due to installation that require binutils package

On Mon, 29 Mar 2021 at 20:20, John Simpson wrote: > > Hello, > > Kindly ask you to have a look at this bug. > Thank you for your replies. >> > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils wrote: >> > > BUILD pc-bios/optionrom/kvmvapic.img >> > > ld: Error: unable to

Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense

On Mon, 14 Mar 2022 at 16:01, Markus Armbruster wrote: > > g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, > for two reasons. One, it catches multiplication overflowing size_t. > Two, it returns T * rather than void *, which lets the compiler catch > more type errors. > >

Re: [PULL 0/6] Block patches

handle_output() (2022-01-12 > 17:09:39 +) > > -------- > Pull request > Reviewed-by: Peter Maydell thanks -- PMM

Re: QEMU features useful for Xen development?

On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini wrote: > As Xen is gaining R52 and R82 support, it would be great to be able to > use QEMU for development and testing there as well, but I don't think > QEMU can emulate EL2 properly for the Cortex-R architecture. We would > need EL2 support in

Re: QEMU features useful for Xen development?

On Thu, 31 Aug 2023 at 10:53, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini > > wrote: > >> As Xen is gaining R52 and R82 support, it would be great to be able to > >> use QEMU for development an

Re: QEMU features useful for Xen development?

On Thu, 31 Aug 2023 at 11:49, Alex Bennée wrote: > Peter Maydell writes: > > All our MPS2/MPS3 boards are M-profile. That means we have the > > device models for all the interesting devices on the board, but > > it would be simpler to write the an536 board model separatel

Re: [PATCH 3/7] ui: Clean up local variable shadowing

ZRLE_PIXEL *ptr; > - > for (ptr = data; ptr < data + w * h; ptr++) { > ZRLE_WRITE_PIXEL(vs, *ptr); > } For this one I'm tempted to suggest instead moving the pix and end currently at whole-function scope into their own block, so it's clear these are actually four completely independent uses of ptr/end. But either way Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 06/15] hw/xen: automatically assign device index to block devices

On Tue, 7 Nov 2023 at 09:24, David Woodhouse wrote: > > From: David Woodhouse > > There's no need to force the user to assign a vdev. We can automatically > assign one, starting at xvda and searching until we find the first disk > name that's unused. > > This means we can now allow '-drive

Re: [BUG] Xen build error - undefined reference to bpf_program__set_socket_filter

On Mon, 17 Oct 2022 at 10:02, Jan Beulich wrote: > > On 17.10.2022 10:12, Arthur Borsboom wrote: > > Xen 4.16.1, 4.16.2 and 4.17.0-rc1 don't build anymore in Arch Linux. > > I believe it is caused by the missing function > > bpf_program__set_socket_filter provided by libbpf. > > That is, qemu

Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al

On Tue, 20 Sept 2022 at 23:50, Bernhard Beschow wrote: > > Am 20. September 2022 09:55:37 UTC schrieb Peter Maydell > : > >On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote: > >> > >> In address-spaces.h it can be read that get_system_memory() and &

Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al

On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote: > > In address-spaces.h it can be read that get_system_memory() and > get_system_io() are temporary interfaces which "should only be used > temporarily > until a proper bus interface is available". This statement certainly extends > to >

Re: [PATCH] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx

On Tue, 10 Jan 2023 at 22:04, BALATON Zoltan wrote: > > On Tue, 10 Jan 2023, Philippe Mathieu-Daudé wrote: > > The 'hwaddr' type is defined in "exec/hwaddr.h" as: > > > >hwaddr is the type of a physical address > > (its size can be different from 'target_ulong'). > > > > All definitions use

Re: [PATCH] exec: Rename NEED_CPU_H -> CONFIG_TARGET

On Fri, 16 Dec 2022 at 22:09, Philippe Mathieu-Daudé wrote: > > 'NEED_CPU_H' guard target-specific code; it is defined by meson > altogether with the 'CONFIG_TARGET' definition. Since the latter > name is more meaningful, directly use it. > > Inspired-by: Peter Maydell > Si

Re: [PULL 00/27] Enable PV backends with Xen/KVM emulation

On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd: > > Merge tag 'pull-riscv-to-apply-20230306' of > https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 > +) > > are available in the Git

Re: [PATCH v2 0/6] Deprecate support for 32-bit x86 and arm hosts

On Fri, 3 Mar 2023 at 11:09, John Paul Adrian Glaubitz wrote: > > Hello! > > On Fri, 2023-03-03 at 10:48 +0100, Thomas Huth wrote: > > x86 ==> deprecate both, user and system emulation support on > > 32-bit hosts > > arm ==> deprecate only system emulation on 32-bit hosts. > > I would

Re: [PATCH v2 4/6] docs/about/deprecated: Deprecate the qemu-system-arm binary

On Thu, 2 Mar 2023 at 16:31, Thomas Huth wrote: > > qemu-system-aarch64 is a proper superset of qemu-system-arm, > and the latter was mainly still required for 32-bit KVM support. > But this 32-bit KVM arm support has been dropped in the Linux > kernel a couple of years ago already, so we don't

Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes

On Wed, 12 Apr 2023 at 20:01, David Woodhouse wrote: > > On Wed, 2023-04-12 at 19:55 +0100, Peter Maydell wrote: > > On Wed, 12 Apr 2023 at 19:52, David Woodhouse wrote: > > > > > > Some Coverity fixes and minor cleanups. And most notably, dropping > > &g

Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations

On Wed, 12 Apr 2023 at 19:22, David Woodhouse wrote: > > On Tue, 2023-04-11 at 19:07 +0100, Peter Maydell wrote: > > > > > > > +static void xs_be_unwatch(struct qemu_xs_handle *h, struct > > > qemu_xs_watch *w) > > > +{ > > > +

Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()

fies the code > a bit. > > Fixes: 7a8a749da7d3 ("hw/xen: Move xenstore_store_pv_console_info to > xen_console.c") > Signed-off-by: David Woodhouse Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 5/5] hw/xen: Fix broken check for invalid state in xs_be_open()

XenStore > operations") > Signed-off-by: David Woodhouse > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes

On Wed, 12 Apr 2023 at 19:52, David Woodhouse wrote: > > Some Coverity fixes and minor cleanups. And most notably, dropping > support for Xen libraries older than 4.7.1. > > I believe there are two issues that remain to be fixed. The x32 build > fails, and I've seen patches which attempt to

Re: [PULL 05/27] hw/xen: Watches on XenStore transactions

On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Firing watches on the nodes that still exist is relatively easy; just > walk the tree and look at the nodes with refcount of one. > > Firing watches on *deleted* nodes is more fun. We add 'modified_in_tx' > and

Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation

On Tue, 4 Apr 2023 at 18:45, David Woodhouse wrote: > > On Tue, 2023-04-04 at 18:35 +0100, Peter Maydell wrote: > > On Tue, 7 Mar 2023 at 18:27, David Woodhouse > > wrote: > > > > > > From: Paul Durrant > > > > > > Signed-off-

Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation

On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: Paul Durrant > > Signed-off-by: Paul Durrant > Signed-off-by: David Woodhouse > Reviewed-by: Paul Durrant > --- Hi; Coverity points out a memory leak in this code (CID 1508098): > +static struct qemu_xs_handle

Re: [PATCH] hw/xen: Fix memory leak in libxenstore_open() for Xen

(CID 1508098). > > Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to > internal emulation") > Suggested-by: Peter Maydell > Signed-off-by: David Woodhouse > --- > hw/xen/xen-operations.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations

On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Now that we have an internal implementation of XenStore, we can populate > the xenstore_backend_ops to allow PV backends to talk to it. > > Watches can't be processed with immediate callbacks because that would >

Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations

On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Now that we have an internal implementation of XenStore, we can populate > the xenstore_backend_ops to allow PV backends to talk to it. > > Watches can't be processed with immediate callbacks because that would >

Re: [PULL 14/27] hw/xen: Move xenstore_store_pv_console_info to xen_console.c

On Tue, 7 Mar 2023 at 18:28, David Woodhouse wrote: > > From: David Woodhouse > > There's no need for this to be in the Xen accel code, and as we want to > use the Xen console support with KVM-emulated Xen we'll want to have a > platform-agnostic version of it. Make it use GString to build up

Re: [PATCH] xen-block: Avoid leaks on new error path

ter the error check, and free both > `filename` and `driver` when we are about to return and thus taking > care of both success and error path. > > Coverity only spotted the leak of qdicts (*_layer variables). > > Reported-by: Peter Maydell > Fixes: Coverity CID 1508722, 1398649 &

Re: [PULL 05/27] hw/xen: Watches on XenStore transactions

On Tue, 2 May 2023 at 18:08, Peter Maydell wrote: > > On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > > > From: David Woodhouse > > > > Firing watches on the nodes that still exist is relatively easy; just > > walk the tree and look at the nodes

Re: [PULL 05/27] hw/xen: Watches on XenStore transactions

On Fri, 2 Jun 2023 at 18:06, Peter Maydell wrote: > > On Tue, 2 May 2023 at 18:08, Peter Maydell wrote: > > > > On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > > > > > From: David Woodhouse > > Hi; Coverity's "is there missing er

Re: QEMU features useful for Xen development?

On Thu, 31 Aug 2023 at 11:32, Ayan Kumar Halder wrote: > On 31/08/2023 11:03, Peter Maydell wrote: > > On Thu, 31 Aug 2023 at 10:53, Alex Bennée wrote: > >> Peter Maydell writes: > >>> On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini > >>> wrote: &g

Re: [PATCH] fix qemu build with xen-4.18.0

On Tue, 12 Dec 2023 at 14:20, Anthony PERARD wrote: > Building qemu with something like: > ./configure --enable-xen --cpu=x86_64 > used to work. Can we fix that? It still works with v8.1.0. > At least, it works on x86, I never really try to build qemu for arm. > Notice that there's no

Re: [PULL 0/6] Block patches

On Mon, 8 Jan 2024 at 16:37, Stefan Hajnoczi wrote: > > The following changes since commit ffd454c67e38cc6df792733ebc5d967eee28ac0d: > > Merge tag 'pull-vfio-20240107' of https://github.com/legoater/qemu into > staging (2024-01-08 10:28:42 +) > > are available in the Git repository at: > >

Re: [PATCH v6 01/11] linux-headers: Update to kernel headers to add venus capset

On Tue, 19 Dec 2023 at 13:49, Huang Rui wrote: > > On Tue, Dec 19, 2023 at 08:20:22PM +0800, Akihiko Odaki wrote: > > On 2023/12/19 16:53, Huang Rui wrote: > > > Sync up kernel headers to update venus macro till they are merged into > > > mainline. > > > > Thanks for sorting things out with the

Re: [PATCH v3 01/46] net: add qemu_{configure,create}_nic_device(), qemu_find_nic_info()

On Fri, 26 Jan 2024 at 15:20, David Woodhouse wrote: > > On Fri, 2024-01-26 at 14:43 +, Peter Maydell wrote: > > > > > +NICInfo *qemu_find_nic_info(const char *typename, bool match_default, > > > +const char *alias); > &g

Re: [PATCH v3 01/46] net: add qemu_{configure,create}_nic_device(), qemu_find_nic_info()

On Mon, 8 Jan 2024 at 20:49, David Woodhouse wrote: > > From: David Woodhouse > > Most code which directly accesses nd_table[] and nb_nics uses them for > one of two things. Either "I have created a NIC device and I'd like a > configuration for it", or "I will create a NIC device *if* there is a

Re: [PATCH] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

On Thu, 9 Nov 2023 at 15:30, David Woodhouse wrote: > > From: David Woodhouse > > Coverity couldn't see that nr_existing was always going to be zero when > qemu_xen_xs_directory() returned NULL in the ENOENT case (CID 1523906). > > Perhaps more to the point, neither could Peter at first glance.

  1   2   >