Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread Roger Pau Monné
On Mon, Nov 27, 2017 at 02:15:50PM +, George Dunlap wrote: > On 11/27/2017 11:43 AM, Roger Pau Monné wrote: > > On Wed, Nov 22, 2017 at 07:20:12PM +, George Dunlap wrote: > >> For now only include xl-specific features, or interaction with the > >> syst

Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread Roger Pau Monné
On Mon, Nov 27, 2017 at 02:58:38PM +, George Dunlap wrote: > On 11/27/2017 02:39 PM, Roger Pau Monné wrote: > > On Mon, Nov 27, 2017 at 02:12:40PM +, George Dunlap wrote: > >> On 11/27/2017 11:43 AM, Roger Pau Monné wrote: > >>> On Wed, Nov 22, 2017 at 07:20:1

Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread Roger Pau Monné
Supported, x86: bzImage ELF is missing here. > +Supported, ARM32: zImage > +Supported, ARM64: Image > + > +Format which the toolstack accept for direct-boot kernels > + > +### systemd support for xl BSD-style init is also supported. The rest LGTM: Revie

Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread Roger Pau Monné
On Mon, Nov 27, 2017 at 02:12:40PM +, George Dunlap wrote: > On 11/27/2017 11:43 AM, Roger Pau Monné wrote: > > On Wed, Nov 22, 2017 at 07:20:12PM +, George Dunlap wrote: > >> For now only include xl-specific features, or interaction with the > >> syst

Re: [Xen-devel] [PATCH 1/3] x86/boot: add acpi rsdp address to setup_header

2017-11-28 Thread Roger Pau Monné
> kernel. > > For this purpose expand the struct setup_header to hold the physical > address of the RSDP address. Being zero means it isn't specified and > has to be located the legacy way (searching through low memory or > EBDA). > > Signed-off-by: Juergen Gross <jgr...@suse.com&g

Re: [Xen-devel] [PATCH 3/3] x86/xen: supply rsdp address in boot params for pvh guests

2017-11-28 Thread Roger Pau Monné
On Tue, Nov 28, 2017 at 10:44:00AM +0100, Juergen Gross wrote: > When booted via the special PVH entry save the RSDP address set in the > boot information block in struct boot_params. This will enable Xen to > locate the RSDP at an arbitrary address. > > Signed-off-by: Juergen Gross

Re: [Xen-devel] [PATCH 2/3] x86/acpi: take rsdp address for boot params if available

2017-11-28 Thread Roger Pau Monné
On Tue, Nov 28, 2017 at 11:30:15AM +0100, Juergen Gross wrote: > On 28/11/17 11:18, Roger Pau Monné wrote: > > On Tue, Nov 28, 2017 at 10:43:59AM +0100, Juergen Gross wrote: > >> In case the rsdp address in struct boot_params is specified don't try > >> to find the t

Re: [Xen-devel] [PATCH 2/3] x86/acpi: take rsdp address for boot params if available

2017-11-28 Thread Roger Pau Monné
On Tue, Nov 28, 2017 at 10:43:59AM +0100, Juergen Gross wrote: > In case the rsdp address in struct boot_params is specified don't try > to find the table by searching, but take the address directly as set > by the boot loader. > > Signed-off-by: Juergen Gross > --- >

Re: [Xen-devel] [RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point

2017-11-29 Thread Roger Pau Monné
On Wed, Nov 29, 2017 at 09:21:59AM +0100, Juergen Gross wrote: > On 28/11/17 20:34, Maran Wilson wrote: > > For certain applications it is desirable to rapidly boot a KVM virtual > > machine. In cases where legacy hardware and software support within the > > guest is not needed, Qemu should be

Re: [Xen-devel] [RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point

2017-11-29 Thread Roger Pau Monné
On Wed, Nov 29, 2017 at 03:11:12PM +0100, Juergen Gross wrote: > On 29/11/17 15:03, Boris Ostrovsky wrote: > > On 11/29/2017 03:50 AM, Roger Pau Monné wrote: > >> On Wed, Nov 29, 2017 at 09:21:59AM +0100, Juergen Gross wrote: > >>> On 28/11/17 20:34, Maran Wi

Re: [Xen-devel] [PATCH] sched/null: skip vCPUs on the waitqueue that are blocked

2017-12-19 Thread Roger Pau Monné
On Tue, Dec 19, 2017 at 07:25:51AM -0700, Jan Beulich wrote: > >>> On 19.12.17 at 15:16, wrote: > > --- a/xen/common/sched_null.c > > +++ b/xen/common/sched_null.c > > @@ -781,6 +781,10 @@ static struct task_slice null_schedule(const struct > > scheduler *ops, > >

Re: [Xen-devel] [PATCH] libxl/pvh: force PVH guests to use the xenstore shutdown

2017-12-19 Thread Roger Pau Monné
On Tue, Dec 19, 2017 at 02:48:47PM +, Ian Jackson wrote: > Roger Pau Monné writes ("Re: [PATCH] libxl/pvh: force PVH guests to use the > xenstore shutdown"): > > Yes, that's exactly what I meant but failed to express. Feel free to > > replace the commit message

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

2017-12-19 Thread Roger Pau Monné
On Fri, Dec 01, 2017 at 03:14:07PM +0100, Juergen Gross wrote: > Instead of locating the RSDP table below 1MB put it just below 4GB > like the rest of the ACPI tables in case of PVH guests. This will > avoid punching more holes than necessary into the memory map. > > Signed-off-by: Juergen Gross

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

2017-12-19 Thread Roger Pau Monné
On Tue, Dec 19, 2017 at 04:46:37PM +0100, Juergen Gross wrote: > On 19/12/17 16:38, Roger Pau Monné wrote: > > On Fri, Dec 01, 2017 at 03:14:07PM +0100, Juergen Gross wrote: > >> Instead of locating the RSDP table below 1MB put it just below 4GB > >> like the rest of the

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

2017-12-20 Thread Roger Pau Monné
On Tue, Dec 19, 2017 at 05:20:41PM +0100, Juergen Gross wrote: > On 19/12/17 17:11, Roger Pau Monné wrote: > > On Tue, Dec 19, 2017 at 04:46:37PM +0100, Juergen Gross wrote: > >> On 19/12/17 16:38, Roger Pau Monné wrote: > >>> On Fri, Dec 01, 2017 at 03:14:0

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Roger Pau Monné
On Tue, Dec 05, 2017 at 03:09:47PM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ > with FreeBSD release targets"): > > Due to a recent FreeBSD change the default output directory of the release > > targets is changed to the object directory

Re: [Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-06 Thread Roger Pau Monné
On Wed, Dec 06, 2017 at 12:22:00PM +0100, Juergen Gross wrote: > On 06/12/17 10:53, Julien Grall wrote: > > Hi Juergen, > > > > On 12/05/2017 04:19 PM, Juergen Gross wrote: > >> On 05/12/17 16:23, Julien Grall wrote: > >>> Hi Juergen, > >>> > >>> On 04/12/17 15:49, Juergen Gross wrote: > On

Re: [Xen-devel] [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-04 Thread Roger Pau Monné
.g. when > hotplugging memory into the guest. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> Albeit I would also prefer this to not be PVH specific. Ideally I would like both PVH and HVM to share the logic to mark the re

Re: [Xen-devel] [PATCH 5/5] docs/pvh: document initial MTRR state

2018-05-14 Thread Roger Pau Monné
On Mon, May 14, 2018 at 05:03:52PM +0100, Wei Liu wrote: > On Thu, May 10, 2018 at 06:15:05PM +0100, Roger Pau Monne wrote: > > Provided to both Dom0 and DomUs. > > > > Signed-off-by: Roger Pau Monné <roger@citrix.com> > > --- > > Cc: Andrew Cooper <

Re: [Xen-devel] [PATCH 1/2] vpci/msi: split code to bind pirq

2018-05-14 Thread Roger Pau Monné
On Mon, May 14, 2018 at 08:56:16AM -0600, Jan Beulich wrote: > >>> On 14.05.18 at 16:15, wrote: > > On Mon, May 14, 2018 at 06:24:37AM -0600, Jan Beulich wrote: > >> >>> On 08.05.18 at 11:25, wrote: > >> > --- a/xen/arch/x86/hvm/vmsi.c > >> > +++

Re: [Xen-devel] [PATCH 4/5] libxc/pvh: set default MTRR type to write-back

2018-05-14 Thread Roger Pau Monné
On Mon, May 14, 2018 at 05:00:51PM +0100, Wei Liu wrote: > On Thu, May 10, 2018 at 06:15:04PM +0100, Roger Pau Monne wrote: > > @@ -1014,6 +1034,30 @@ static int vcpu_hvm(struct xc_dom_image *dom) > > if ( dom->start_info_seg.pfn ) > > bsp_ctx.cpu.rbx = dom->start_info_seg.pfn <<

Re: [Xen-devel] [PATCH 3/5] hvm/mtrr: copy hardware state for Dom0

2018-05-14 Thread Roger Pau Monné
gt; > the same set of MTRR ranges should provide Dom0 with a sane MTRR state > > without having to manually build it in Xen. > > > > Signed-off-by: Roger Pau Monné <roger@citrix.com> > > --- > > Cc: Jan Beulich <jbeul...@suse.com> > > Cc:

Re: [Xen-devel] [PATCH 1/2] vpci/msi: split code to bind pirq

2018-05-14 Thread Roger Pau Monné
On Mon, May 14, 2018 at 06:24:37AM -0600, Jan Beulich wrote: > >>> On 08.05.18 at 11:25, wrote: > > --- a/xen/arch/x86/hvm/vmsi.c > > +++ b/xen/arch/x86/hvm/vmsi.c > > @@ -663,6 +663,42 @@ void vpci_msi_arch_mask(struct vpci_msi *msi, const > > struct pci_dev *pdev, > >

Re: [Xen-devel] [PATCH 2/2] vpci/msi: fix update of bound MSI interrupts

2018-05-14 Thread Roger Pau Monné
On Mon, May 14, 2018 at 06:29:37AM -0600, Jan Beulich wrote: > >>> On 08.05.18 at 11:25, wrote: > > --- a/xen/arch/x86/hvm/vmsi.c > > +++ b/xen/arch/x86/hvm/vmsi.c > > @@ -699,6 +699,29 @@ static int vpci_msi_update(const struct pci_dev *pdev, > > uint32_t data, > >

Re: [Xen-devel] [PATCH 4/5] libxc/pvh: set default MTRR type to write-back

2018-05-14 Thread Roger Pau Monné
On Mon, May 14, 2018 at 05:42:53PM +0100, Wei Liu wrote: > On Mon, May 14, 2018 at 05:02:47PM +0100, Roger Pau Monné wrote: > > On Mon, May 14, 2018 at 05:00:51PM +0100, Wei Liu wrote: > > > On Thu, May 10, 2018 at 06:15:04PM +0100, Roger Pau Monne wrote: > > > > @@

Re: [Xen-devel] [PATCH] pci: treat class 0 devices as endpoints

2018-05-14 Thread Roger Pau Monné
gners don't > even get the class code right, what other flaws do we have to expect? > Anyway, this is no objection to the actual code change, I'm merely > unconvinced that the argumentation is plausible. > > > Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> > > Signed

Re: [Xen-devel] [PATCH 0/2] vpci/msi: fix updating already bound MSI interrupts

2018-05-08 Thread Roger Pau Monné
On Tue, May 08, 2018 at 11:30:18AM +0200, Juergen Gross wrote: > On 08/05/18 11:23, Roger Pau Monne wrote: > > Hello, > > > > There's a bug in current vpci code for MSI emulation when updating an > > already bound interrupt. The code will disable and enable the interrupt > > in order to update

Re: [Xen-devel] [PATCH v2 1/3] xen/pvh: enable and set default MTRR type

2018-05-09 Thread Roger Pau Monné
On Wed, May 09, 2018 at 12:30:16PM +0100, Roger Pau Monné wrote: > On Wed, May 09, 2018 at 11:56:40AM +0100, Andrew Cooper wrote: > > On 09/05/18 11:21, Roger Pau Monne wrote: > > I'm not sure that setting the default MTRR type is going to be a > > clever idea in hindsight

Re: [Xen-devel] [PATCH v2 1/3] xen/pvh: enable and set default MTRR type

2018-05-09 Thread Roger Pau Monné
ing the default type to WB. Linux > > will use PAT to set the actual memory cache attributes. > > > > Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > > Signed-off-by: Roger Pau Monné <roger@citrix.com> > > I'd argue that this is a bug in PVH st

Re: [Xen-devel] [PATCH RFC] libxl: set 1GB MMIO hole for PVH

2018-05-10 Thread Roger Pau Monné
On Wed, May 09, 2018 at 06:12:28PM +0200, Juergen Gross wrote: > On 09/05/18 18:07, Roger Pau Monne wrote: > > This prevents page-shattering, by being able to populate the RAM > > regions below 4GB using 1GB pages, provided the guest memory size is > > set to a multiple of a GB. > > > > Note that

Re: [Xen-devel] [PATCH RFC] libxl: set 1GB MMIO hole for PVH

2018-05-10 Thread Roger Pau Monné
On Thu, May 10, 2018 at 10:43:26AM +0100, George Dunlap wrote: > On Wed, May 9, 2018 at 5:07 PM, Roger Pau Monne wrote: > > This prevents page-shattering, by being able to populate the RAM > > regions below 4GB using 1GB pages, provided the guest memory size is > > set to a

Re: [Xen-devel] [PATCH] x86/domain: Drop the only-written smap_check_policy infrastructure

2018-05-08 Thread Roger Pau Monné
n guest_walk_tables() > was resolved by the aformentioned commit. > > Remove the unused variables and associated infrastructure. > > Reported-by: Jason Andryuk <jandr...@gmail.com> > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Roger Pau Monné &

Re: [Xen-devel] [PATCH 2/4] libxc: Provide access to internal handles

2018-05-15 Thread Roger Pau Monné
On Mon, May 14, 2018 at 06:08:57PM +0100, Ian Jackson wrote: > In order to support auditing of qemu depriv, my audit tool wants to > know the fd of a privcmd handle on which it can easily make > hypercalls. xencall provides such a handle, but has no cooked > facilities for making hypercalls. So

Re: [Xen-devel] [OSSTEST PATCH 06/10] Perl @INC path: fix a few more scripts to use BEGIN

2018-05-17 Thread Roger Pau Monné
On Thu, May 17, 2018 at 12:16:55PM +0100, Ian Jackson wrote: > Three more files which missed out on > dea987c5ab11 "PERLLIB, @INC: Use BEGIN { }" > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-by: Roger Pau

Re: [Xen-devel] [OSSTEST PATCH 07/10] mg-anoint: Make readonly operations "work" in standalone mode

2018-05-17 Thread Roger Pau Monné
On Thu, May 17, 2018 at 12:16:56PM +0100, Ian Jackson wrote: > This makes `mg-anoint' in standalone mode a view onto an empty set of > anointments. So now it becomes ok to call mg-anoint in make-*-flight. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-b

Re: [Xen-devel] [PATCH for-4.11] x86/cacheattr: fix mtrr_pat_not_equal

2018-05-17 Thread Roger Pau Monné
qual. Both vCPU-s having MTRRs disabled means only PAT needs to be > compared. Along those lines for fixed range MTRRs. Differring variable > range counts likewise mean settings are different overall. > > Constify types and convert bool_t to bool. > > Signed-off-by: Jan Beulich <

Re: [Xen-devel] [OSSTEST PATCH 10/10] mfi-common: Fall back to anointed builds in Executive mode

2018-05-17 Thread Roger Pau Monné
Jackson <ian.jack...@eu.citrix.com> LGTM Reviewed-by: Roger Pau Monné <roger@citrix.com> Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [OSSTEST PATCH 08/10] mg-anoint: Support mg-anoint retrieve --tolerate-unprepared

2018-05-17 Thread Roger Pau Monné
On Thu, May 17, 2018 at 12:16:57PM +0100, Ian Jackson wrote: > make-*-flight is going to want this. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> Just a style comment below. > --- > mg-anoint | 12 +++

Re: [Xen-devel] [OSSTEST PATCH 09/10] mfi-common: set_freebsd_runvars: Never set freebsd_distpath to `/amd64' etc.

2018-05-17 Thread Roger Pau Monné
appropriately. The overall result is that > if no useful FreeBSD build is found, we simply do not set the > freebsd_* runvars, rather than setting them to wrong values (eg, > `freebsd_distpath=/i386'. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-by

Re: [Xen-devel] [PATCH v2 3/6] hvm/mtrr: use the hardware number of variable ranges for Dom0

2018-05-16 Thread Roger Pau Monné
On Wed, May 16, 2018 at 07:51:07AM -0600, Jan Beulich wrote: > >>> On 16.05.18 at 15:41, wrote: > > On Wed, May 16, 2018 at 06:01:00AM -0600, Jan Beulich wrote: > >> @@ -729,6 +729,14 @@ static int hvm_load_mtrr_msr(struct doma > >> if ( hvm_load_entry(MTRR, h, _mtrr)

Re: [Xen-devel] [PATCH v2 3/6] hvm/mtrr: use the hardware number of variable ranges for Dom0

2018-05-16 Thread Roger Pau Monné
On Wed, May 16, 2018 at 06:01:00AM -0600, Jan Beulich wrote: > >>> On 16.05.18 at 13:53, wrote: > > On Wed, May 16, 2018 at 02:39:26AM -0600, Jan Beulich wrote: > >> >>> On 15.05.18 at 16:36, wrote: > >> > +for ( i = 0; i < num_var_ranges; i++

Re: [Xen-devel] [PATCH 4/4] libxl: Provide better error message when qemu restrict user not found

2018-05-15 Thread Roger Pau Monné
On Mon, May 14, 2018 at 06:08:59PM +0100, Ian Jackson wrote: > Add mention of LIBXL_QEMU_USER_RANGE_BASE, in case that is what the > user was intending. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-by: Roger Pau Monné <roger...

Re: [Xen-devel] Draft NVDIMM proposal

2018-05-15 Thread Roger Pau Monné
Just some replies/questions to some of the points raised below. On Fri, May 11, 2018 at 09:33:10AM -0700, Dan Williams wrote: > [ adding linux-nvdimm ] > > Great write up! Some comments below... > > On Wed, May 9, 2018 at 10:35 AM, George Dunlap > wrote: > >> To use

Re: [Xen-devel] [PATCH 3/5] hvm/mtrr: copy hardware state for Dom0

2018-05-15 Thread Roger Pau Monné
e memory map provided to a PVH Dom0 is based on the native one using > >> >> > the same set of MTRR ranges should provide Dom0 with a sane MTRR state > >> >> > without having to manually build it in Xen. > >> >> > > >> >> > Signe

Re: [Xen-devel] [PATCH v2 4/6] hvm/mtrr: copy hardware state for Dom0

2018-05-16 Thread Roger Pau Monné
On Wed, May 16, 2018 at 02:47:39AM -0600, Jan Beulich wrote: > >>> On 15.05.18 at 16:36, wrote: > > --- a/xen/arch/x86/hvm/mtrr.c > > +++ b/xen/arch/x86/hvm/mtrr.c > > @@ -185,6 +185,30 @@ int hvm_vcpu_cacheattr_init(struct vcpu *v) > > ((uint64_t)PAT_TYPE_UC_MINUS

Re: [Xen-devel] [PATCH v2 3/6] hvm/mtrr: use the hardware number of variable ranges for Dom0

2018-05-16 Thread Roger Pau Monné
On Wed, May 16, 2018 at 02:39:26AM -0600, Jan Beulich wrote: > >>> On 15.05.18 at 16:36, wrote: > > +for ( i = 0; i < num_var_ranges; i++ ) > > Following your v1 I had already put together a patch to change just the > save and load functions here, as the adjustments

Re: [Xen-devel] [PATCH] xen-hvm: stop faking I/O to access PCI config space

2018-05-16 Thread Roger Pau Monné
G_SPACE_SIZE when Xen gains the ability to > emulate MCFG table accesses. Thanks for doing this. I'm not a QEMU maintainer but: Reviewed-by: Roger Pau Monné <roger@citrix.com> > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > -- > Cc: Stefano Stabellini <sst

Re: [Xen-devel] ViryaOS: proposal for a new Xen Project sub-project

2018-05-21 Thread Roger Pau Monné
This looks interesting IMO. Just one small nit. On Thu, May 17, 2018 at 03:31:40PM -0700, Stefano Stabellini wrote: > ## Hardware Support > > ViryaOS will support as many hardware platforms as possible, x86 and ARM It might be good to mention "x86 (amd64)", and likewise in the bullet list

Re: [Xen-devel] xen vtd : set msi guest_masked 0 by default

2018-05-21 Thread Roger Pau Monné
On Mon, May 21, 2018 at 12:46:19PM +0100, David Woodhouse wrote: > On Tue, 2016-01-26 at 09:34 +0800, Jianzhong,Chang wrote: > > There are some problems when msi guest_masked is set to 1 by default. > > When guest os is windows 2008 r2 server, > > the device(eg X540-AT2 vf) is not initialized

Re: [Xen-devel] Pending patches for 4.11?

2018-05-23 Thread Roger Pau Monné
On Tue, May 22, 2018 at 11:58:35AM +0100, Andrew Cooper wrote: > On 22/05/18 07:57, Juergen Gross wrote: > > Are there any patches for 4.11 still pending? > > > > Are any important patches missing my Release-ack? > > > > I'd like to have a final rc this Friday and hope OSStest will catch up > > in

Re: [Xen-devel] [PATCH 3/9] x86/vmx: Factor locate_msr_entry() out of vmx_find_msr() and vmx_add_msr()

2018-05-24 Thread Roger Pau Monné
On Wed, May 23, 2018 at 05:55:50PM +0100, Andrew Cooper wrote: > On 23/05/18 17:39, Roger Pau Monné wrote: > > On Tue, May 22, 2018 at 12:20:40PM +0100, Andrew Cooper wrote: > >> Instead of having multiple algorithms searching the MSR lists, implement a > >> single

Re: [Xen-devel] [PATCH 2/5] x86: split out cpuid objects and helpers

2018-05-25 Thread Roger Pau Monné
On Fri, May 25, 2018 at 11:01:18AM +0100, Andrew Cooper wrote: > On 25/05/18 10:49, Wei Liu wrote: > > On Fri, May 25, 2018 at 11:41:04AM +0200, Roger Pau Monné wrote: > >> On Thu, May 24, 2018 at 05:05:19PM +0100, Wei Liu wrote: > >>> They are moved to a new header

Re: [Xen-devel] [PATCH 1/5] x86: move definition of struct cpuid_leaf to cpuid.h

2018-05-25 Thread Roger Pau Monné
On Thu, May 24, 2018 at 05:05:18PM +0100, Wei Liu wrote: > This is a step towards consolidating relevant data structures and > defines to one location. > > It then requires defining cpuid_leaf in user space harness headers to > make them continue to compile. > > No functional change. > >

Re: [Xen-devel] [PATCH 2/5] x86: split out cpuid objects and helpers

2018-05-25 Thread Roger Pau Monné
On Thu, May 24, 2018 at 05:05:19PM +0100, Wei Liu wrote: > They are moved to a new header which is going to be consumed by both > the hypervisor and toolstack. > > Create a new directory for this kind of headers in anticipation of

Re: [Xen-devel] [OSSTEST PATCH] ap-common: Switch to Linux 4.14 by default on X86.

2018-05-25 Thread Roger Pau Monné
stabell...@kernel.org> > CC: Wei Liu <wei.l...@citrix.com> > CC: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > CC: Roger Pau Monné <roger@citrix.com> > CC: Julien Grall <julien.gr...@linaro.org> > Signed-off-by: Ian Jackson <ia

Re: [Xen-devel] [PATCH 5/9] x86/vmx: Fix handing of MSR_DEBUGCTL on VMExit

2018-05-24 Thread Roger Pau Monné
m> > CC: Jun Nakajima <jun.nakaj...@intel.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger@citrix.com> > > Notes for backporting: This change probably does want backporting, but depends >

Re: [Xen-devel] [PATCH 8/9] x86/vmx: Support removing MSRs from the host/guest load/save lists

2018-05-24 Thread Roger Pau Monné
; CC: Jan Beulich <jbeul...@suse.com> > CC: Jun Nakajima <jun.nakaj...@intel.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger@citrix.com> > --- > xen/arch/x86/hvm/vmx/vmcs.c| 68

Re: [Xen-devel] [PATCH 9/9] x86/vmx: Don't leak EFER.NXE into guest context

2018-05-24 Thread Roger Pau Monné
all writes to CR0 and reads from MSR_EFER, so can provide > architecturally consistent behaviour from the guests point of view. > > As a result of fixing EFER context switching, we can remove the Intel-special > case from hvm_nx_enabled() and let guest_walk_tables() work with the real >

Re: [Xen-devel] [PATCH 7/9] x86/vmx: Support load-only guest MSR list entries

2018-05-24 Thread Roger Pau Monné
hat inserting an MSR into the load-save list involves > moving the entire load-only list, and updating both counts. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> Just one nit below. > @@ -1423,8 +1446,

Re: [Xen-devel] [PATCH 3/9] x86/vmx: Factor locate_msr_entry() out of vmx_find_msr() and vmx_add_msr()

2018-05-24 Thread Roger Pau Monné
On Thu, May 24, 2018 at 11:59:07AM +0100, Andrew Cooper wrote: > On 24/05/18 11:53, Roger Pau Monné wrote: > > On Wed, May 23, 2018 at 05:55:50PM +0100, Andrew Cooper wrote: > >> On 23/05/18 17:39, Roger Pau Monné wrote: > >>> On Tue, May 22, 2018 at 12:20:4

Re: [Xen-devel] [PATCH 4/9] x86/vmx: Support remote access to the MSR lists

2018-05-24 Thread Roger Pau Monné
On Tue, May 22, 2018 at 12:20:41PM +0100, Andrew Cooper wrote: > At the moment, all modifications of the MSR lists are in current context. > However, future changes may need to put MSR_EFER into the lists from domctl > hypercall context. > > Plumb a struct vcpu parameter down through the

Re: [Xen-devel] [PATCH 5/5] docs/pvh: document initial MTRR state

2018-05-15 Thread Roger Pau Monné
On Tue, May 15, 2018 at 01:51:03AM -0600, Jan Beulich wrote: > >>> On 14.05.18 at 18:18, wrote: > > On Mon, May 14, 2018 at 10:13:47AM -0600, Jan Beulich wrote: > >> >>> On 14.05.18 at 18:03, wrote: > >> > On Thu, May 10, 2018 at 06:15:05PM +0100, Roger

Re: [Xen-devel] [PATCH 3/5] hvm/mtrr: copy hardware state for Dom0

2018-05-15 Thread Roger Pau Monné
> >> > Copy the state found on the hardware when creating a PVH Dom0. Since > >> > the memory map provided to a PVH Dom0 is based on the native one using > >> > the same set of MTRR ranges should provide Dom0 with a sane MTRR state > >> > without having

Re: [Xen-devel] [PATCH 1/4] libxc: Drop declarations of osdep_privcmd_open and _close

2018-05-15 Thread Roger Pau Monné
On Mon, May 14, 2018 at 06:08:56PM +0100, Ian Jackson wrote: > These functions are no longer defined or used anywhere. The > declarations should have been deleted when the definitions were. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-by: Roge

Re: [Xen-devel] [PATCH 2/9] x86/vmx: Internal cleanup for MSR load/save infrastructure

2018-05-23 Thread Roger Pau Monné
Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Jun Nakajima <jun.nakaj...@intel.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger@citrix.com> > ---

Re: [Xen-devel] [PATCH 1/9] x86/vmx: API improvements for MSR load/save infrastructure

2018-05-23 Thread Roger Pau Monné
type); > + > +static inline int vmx_read_guest_msr(uint32_t msr, uint64_t *val) > +{ > +struct vmx_msr_entry *ent; const Also I would probably do: { const struct vmx_msr_entry *ent = vmx_find_msr(msr, VMX_MSR_GUEST); if ( !ent ) return -E

Re: [Xen-devel] [PATCH 3/9] x86/vmx: Factor locate_msr_entry() out of vmx_find_msr() and vmx_add_msr()

2018-05-23 Thread Roger Pau Monné
..@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Jun Nakajima <jun.nakaj...@intel.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger@citrix.com> > --- > xen/arch/x

Re: [Xen-devel] [PATCH 5/6] x86/vmx: Defer vmx_vmcs_exit() as long as possible in construct_vmcs()

2018-06-06 Thread Roger Pau Monné
CC: Jan Beulich > CC: Jun Nakajima > CC: Kevin Tian > CC: Wei Liu > CC: Roger Pau Monné > --- > xen/arch/x86/hvm/vmx/vmcs.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c

Re: [Xen-devel] [PATCH 4/6] x86/vmx: Simplify PAT handling during vcpu construction

2018-06-06 Thread Roger Pau Monné
iewed-by: Roger Pau Monné Thanks. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 03/11] x86: Initialise debug registers correctly

2018-06-06 Thread Roger Pau Monné
ng this) and call it early in vcpu_initialise(). Make a > similar adjustment in hvm_vcpu_reset_state(). > > Finally, adjust the vcpu state initialising logic in libxc. All 3 sites zero > memory before choosing the nonzero defaults, which propagates the RTM corner > case. > >

Re: [Xen-devel] [PATCH 6/6] x86/vmx: Drop VMX signal for full real-mode

2018-06-06 Thread Roger Pau Monné
ally sets %rax to 0 in the > same action it uses to set %rip to the appropriate entrypoint. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/6] x86/pat: Simplify host PAT handling

2018-06-06 Thread Roger Pau Monné
On Mon, May 28, 2018 at 03:27:55PM +0100, Andrew Cooper wrote: > With the removal of the 32bit hypervisor build, host_pat is a constant value. > Drop the variable and the redundant cpu_has_pat predicate, and use a define > instead. > > Signed-off-by: Andrew Cooper Reviewed-by:

Re: [Xen-devel] [PATCH 02/11] x86/vmx: Don't clobber %dr6 while debugging state is lazy

2018-06-06 Thread Roger Pau Monné
der stale > value. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné > --- > CC: Jan Beulich > CC: Wei Liu > CC: Roger Pau Monné > CC: Jun Nakajima > CC: Kevin Tian > --- > xen/arch/x86/hvm/vmx/vmx.c | 1 + > 1 file changed, 1 insertion(+) &

Re: [Xen-devel] [PATCH v3] xen: share start flags between PV and PVH

2018-06-08 Thread Roger Pau Monné
e that ARM is also switched to use the new variable. > > > > Signed-off-by: Boris Ostrovsky > > Signed-off-by: Roger Pau Monné > > As I already mentioned, the ARM part is OK. However, is the issue that > xen_start_info is not available on PVH? We had the same problem on AR

Re: [Xen-devel] [PATCH v2] multiboot2: clarify usage of the address tag

2018-06-08 Thread Roger Pau Monné
On Fri, Jun 08, 2018 at 11:35:52AM +0200, Daniel Kiper wrote: > On Thu, Jun 07, 2018 at 05:59:06PM +0200, Roger Pau Monne wrote: > > Add a note to spell out that if the address tag is not present the > > file should be loaded using the elf header. > > > > Sig

Re: [Xen-devel] [PATCH] multiboot2: clarify usage of the address tag

2018-06-07 Thread Roger Pau Monné
On Wed, Jun 06, 2018 at 07:28:20PM +0200, Daniel Kiper wrote: > On Tue, Jun 05, 2018 at 11:55:36AM +0200, Roger Pau Monne wrote: > > Add a note to spell out that if the address tag is not present the > > file should be loaded using the elf header. > > > > Sig

[Xen-devel] Build issues with newer iasl (was: Re: Status of comet-4.10 branch)

2018-06-16 Thread Roger Pau Monné
On Fri, Jun 15, 2018 at 07:26:14PM +0100, Michael Young wrote: > context (this hasn't reached Fedora yet as the build is broken, I think due > to updates to Fedora's acpica-tools package which provides iasl). I've recently experienced the same on FreeBSD, you might want to try:

Re: [Xen-devel] [RFC PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2018-06-14 Thread Roger Pau Monné
Please try to avoid top posting. On Wed, Jun 13, 2018 at 10:20:48PM +, Anchal Agarwal wrote: > Hi Roger, > To answer your question, due to the lack of mentioned commit > (commit 12ea729645ac ("xen/blkback: unmap all persistent grants when > frontend gets disconnected") in the older dom0

Re: [Xen-devel] [PATCH qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time

2018-06-18 Thread Roger Pau Monné
ked. > > Introduce a new flag in the gflags field to signal Xen whether a MSI > interrupt should be unmasked after being bound. > > This also requires to track the mask register for MSI interrupts, so > QEMU can also notify to Xen whether the MSI interrupt should be bound > mas

Re: [Xen-devel] [RFC PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2018-06-13 Thread Roger Pau Monné
On Tue, Jun 12, 2018 at 08:56:13PM +, Anchal Agarwal wrote: > From: Munehisa Kamata > > Add freeze and restore callbacks for PM suspend and hibernation support. > The freeze handler stops a block-layer queue and disconnect the frontend > from the backend while freeing ring_info and

Re: [Xen-devel] [PATCH v2 1/2] VT-d: re-phrase logic in vtd_set_hwdom_mapping() for clarity

2018-06-13 Thread Roger Pau Monné
> > Signed-off-by: Paul Durrant Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 2/2] VT-d: reconcile iommu_inclusive_mapping and iommu=dom0-strict

2018-06-13 Thread Roger Pau Monné
get a mapping established." > > This patch modifies the VT-d hardware domain initialization code such that > the workaround will continue to function in dom0-strict mode, by mapping > all pages not marked as unusable *unless* they are RAM pages not assigned > to dom0. >

Re: [Xen-devel] [OSSTEST PATCH] cr-daily-branch, cr-publish-flight-logs: Tolerate failure to push harness

2018-06-13 Thread Roger Pau Monné
ARNESS which might contain '' or > --push-harness or --push-harness-try. > > CC: Roger Pau Monné > Signed-off-by: Ian Jackson Just tested this by manually killing a cr-daily-branch and it worked properly, see: http://logs.test-lab.xenproject.org/osstest/logs/124171/ So: Teste

[Xen-devel] [osstest] add FreeBSD flight

2018-06-13 Thread Roger Pau Monné
Hello, I've run a test flight of my FreeBSD osstest series today, the flight shows all green: http://logs.test-lab.xenproject.org/osstest/logs/124163/ The series can be found at: git://xenbits.xen.org/people/royger/osstest.git freebsd_v18 AFAICT it's fully Acked. I've rebased it on top of

Re: [Xen-devel] [PATCH v2 2/8] libxc: Provide access to internal handles

2018-06-11 Thread Roger Pau Monné
and has not caused problems. > > libxc is not a stable API so the downside risk of providing this > access is not significant. > > Signed-off-by: Ian Jackson > Acked-by: Wei Liu Reviewed-by: Roger Pau Monné Thanks. ___ Xen-devel mail

Re: [Xen-devel] [PATCH v2 7/8] tools/tests/depriv: Install depriv-fd-checker in our private libexec directory

2018-06-11 Thread Roger Pau Monné
On Mon, Jun 11, 2018 at 03:13:23PM +0100, Ian Jackson wrote: > osstest is going to want to call it, and should not be expected to > fish it out of the build tree. > > Signed-off-by: Ian Jackson Reviewed-by: Roger Pau Monné Thanks _

Re: [Xen-devel] [PATCH v2 3/8] tools: xencall, xengnttab, xengntshr: Provide access to internal fds

2018-06-11 Thread Roger Pau Monné
On Mon, Jun 11, 2018 at 03:13:19PM +0100, Ian Jackson wrote: > I want this to support my qemu depriv descriptor audit tool. > > Signed-off-by: Ian Jackson > CC: Andrew Cooper Reviewed-by: Roger Pau Monné > diff --git a/tools/libs/call/libxencall.map b/tools/libs/call/libxenc

Re: [Xen-devel] [PATCH v2 6/8] tools/tests: Allow a test subdir to have `install' and `uninstall' targets

2018-06-11 Thread Roger Pau Monné
On Mon, Jun 11, 2018 at 03:13:22PM +0100, Ian Jackson wrote: > Signed-off-by: Ian Jackson Reviewed-by: Roger Pau Monné Thanks ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] multiboot2: clarify usage of the address tag

2018-06-11 Thread Roger Pau Monné
On Fri, Jun 08, 2018 at 12:39:28PM +0200, Daniel Kiper wrote: > On Fri, Jun 08, 2018 at 12:08:22PM +0200, Roger Pau Monné wrote: > > On Fri, Jun 08, 2018 at 11:35:52AM +0200, Daniel Kiper wrote: > > > On Thu, Jun 07, 2018 at 05:59:06PM +0200, Roger Pau Monne wrote: > > >

Re: [Xen-devel] [PATCH 2/2] VT-d: reconcile iommu_inclusive_mapping and iommu=dom0-strict

2018-06-11 Thread Roger Pau Monné
On Fri, Jun 08, 2018 at 04:30:30PM +0100, Paul Durrant wrote: > The documentation for the iommu_inclusive_mapping Xen command line option > states: > > "Use this to work around firmware issues providing incorrect RMRR entries" > > Unfortunately this workaround does not function correctly if the

Re: [Xen-devel] [PATCH 1/2] VT-d: re-phrase logic in vtd_set_hwdom_mapping() for clarity

2018-06-11 Thread Roger Pau Monné
On Fri, Jun 08, 2018 at 04:30:29PM +0100, Paul Durrant wrote: > diff --git a/docs/misc/xen-command-line.markdown > b/docs/misc/xen-command-line.markdown > index 8712a833a2..6beb28dada 100644 > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -1212,8

Re: [Xen-devel] strange behavior with Multiboot2 on EFI

2018-06-15 Thread Roger Pau Monné
Adding Daniel Kiper. On Wed, Jun 13, 2018 at 02:09:45AM +0300, Kristaps Čivkulis wrote: > Hello, > > I am implementing Multiboot2 support for FreeBSD loader to load Xen > kernel. Currently I pass EFI 64-bit system table pointer tag, EFI boot > services not terminated tag, EFI 64-bit image handle

Re: [Xen-devel] Building xen-hypervisor 4.10 and xen-tools on Ubuntu 16.04 for PVH

2018-05-29 Thread Roger Pau Monné
On Tue, May 29, 2018 at 03:32:40AM +, .. .. wrote: > Hello, > > I am doing a study on Virtual Machine Introspection on Intel SGX based > system using Xen based VMs. > > I followed the article - > > https://wiki.xenproject.org/wiki/Linux_PVH >

Re: [Xen-devel] Building xen-hypervisor 4.10 and xen-tools on Ubuntu 16.04 for PVH+

2018-05-29 Thread Roger Pau Monné
Please don't drop xen-devel from Cc and don't top post. On Tue, May 29, 2018 at 09:56:29AM +0200, .. .. wrote: > Yes, without xen, the system boots up fine. Unfortunately, since the system > within few seconds goes back to login screen I am not able to check even > the logs. But I am not sure if

Re: [Xen-devel] [PATCH 05/11] x86/emul: Unfold %cr4.de handling in x86emul_read_dr()

2018-06-06 Thread Roger Pau Monné
On Mon, Jun 04, 2018 at 02:59:09PM +0100, Andrew Cooper wrote: > No functional change (as curr->arch.debugreg[5] is zero when DE is clear), but > this change simplifies the following patch. > > Signed-off-by: Andrew Cooper Reviewed-by:

Re: [Xen-devel] [PATCH 06/11] x86: Reorganise and rename debug register fields in struct vcpu

2018-06-06 Thread Roger Pau Monné
ll rather than silently discarding the values. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné > diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h > index 197f8d6..59d5e4a 100644 > --- a/xen/include/asm-x86/domain.h > +++ b/xen/include/asm-x86

Re: [Xen-devel] [PATCH 11/11] x86/dbg: Cleanup of legacy dr6 constants

2018-06-06 Thread Roger Pau Monné
On Mon, Jun 04, 2018 at 02:59:15PM +0100, Andrew Cooper wrote: > Replace the few remaining uses with X86_DR6_* constants. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné ___ Xen-devel mailing list Xen-devel@lists.xenproject.

Re: [Xen-devel] [PATCH 04/11] x86: Fix calculation of %dr6/7 reserved bits

2018-06-06 Thread Roger Pau Monné
On Wed, Jun 06, 2018 at 04:59:24PM +0100, Andrew Cooper wrote: > On 06/06/18 16:49, Roger Pau Monné wrote: > > On Mon, Jun 04, 2018 at 02:59:08PM +0100, Andrew Cooper wrote: > >> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > >> index 10415e6..7fddae1 100

Re: [Xen-devel] [PATCH 07/11] x86/emul: Add pending_dbg field to x86_event

2018-06-06 Thread Roger Pau Monné
On Mon, Jun 04, 2018 at 02:59:11PM +0100, Andrew Cooper wrote: > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > index bfa3a0d..39c9ddc 100644 > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -2483,7 +2483,7 @@ void update_guest_eip(void) > } >

Re: [Xen-devel] [PATCH 07/11] x86/emul: Add pending_dbg field to x86_event

2018-06-06 Thread Roger Pau Monné
On Wed, Jun 06, 2018 at 05:50:38PM +0100, Andrew Cooper wrote: > On 06/06/18 17:46, Roger Pau Monné wrote: > > On Mon, Jun 04, 2018 at 02:59:11PM +0100, Andrew Cooper wrote: > >> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > >> index bfa3a0d..39

  1   2   3   4   5   6   7   8   9   10   >