Re: [Xen-devel] [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells

2017-11-29 Thread Stefano Stabellini
df > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Acked-by: Stefano Stabellini <sstabell...@kernel.org> > --- > > This was discovered debugging DT generated by GRUB on ACPI-only > platform. I am not aware of any DT relying on that for now,

Re: [Xen-devel] [RFC PATCH 05/31] pmstat: make pmstat functions more generalizable

2017-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: > Hi Stefano > > On Sat, Dec 2, 2017 at 3:21 AM, Stefano Stabellini > <sstabell...@kernel.org> wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > >> From: Oleksandr Dmytryshyn <oleksandr.dmytrys...@glob

Re: [Xen-devel] [RFC PATCH 13/31] xen/arm: Add driver_data field to struct device

2017-12-04 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <julien.

Re: [Xen-devel] [RFC PATCH 09/31] xen/device-tree: Add dt_property_for_each_string macros

2017-12-04 Thread Stefano Stabellini
to use git log and git blame to narrow them down for copyright reasons): Signed-off-by: Stephen Warren <swar...@nvidia.com> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> With those: Acked-by: Stefano Stabellini <sstabell...@kernel.org> > Signed-off-by: Ole

Re: [Xen-devel] [RFC PATCH 11/31] xen/device-tree: Add dt_property_count_elems_of_size helper

2017-12-04 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > > This is a port from Linux. > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > CC: Stefano Stabellini <sstabell...@kernel.o

Re: [Xen-devel] [RFC PATCH 12/31] xen/device-tree: Add dt_property_read_string_helper and friends

2017-12-04 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > > This is a port from Linux. > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > CC: Stefano Stabellini <sstabell...@kernel.o

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Volodymyr Babchuk wrote: > > = Xen command forwarding = > > > > In the code below, it looks like Xen is forwarding everything to OP-TEE. > > Are there some commands Xen should avoid forwarding? Should we have a > > whitelist or a blacklist? > My code implements whitelists (at

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-04 Thread Stefano Stabellini
On Sat, 2 Dec 2017, Oleksandr Tyshchenko wrote: > On Sat, Dec 2, 2017 at 3:06 AM, Stefano Stabellini > <sstabell...@kernel.org> wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > >> From: Oleksandr Dmytryshyn <oleksandr.dmytrys...@globallogic.com> >

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: > Hi, Stefano > > On Sat, Dec 2, 2017 at 3:37 AM, Stefano Stabellini > <sstabell...@kernel.org> wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > >> From: Oleksandr Dmytryshyn <oleksandr.dmytrys

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Volodymyr Babchuk wrote: > Hi Julien, > > > On Mon, Dec 04, 2017 at 04:27:14PM +, Julien Grall wrote: > > [...] > > >>= Error checking / DOS protection = > > >> > > >>We need powerful checks on arguments passed by the caller and evaluated > > >>by the mediator. > > >> >

Re: [Xen-devel] [RFC PATCH 10/31] xen/device-tree: Add dt_property_read_u32_index helper

2017-12-04 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > > This is a port from Linux. > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > CC: Stefano Stabellini <sstabell...@kernel.o

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-04 Thread Stefano Stabellini
> > CC: "Edgar E. Iglesias" <edgar.igles...@xilinx.com> > > Signed-off-by: Volodymyr Babchuk <volodymyr_babc...@epam.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <julien.gr...@linaro.org> > --- > xen/arch/arm/arm32

Re: [Xen-devel] [v2 04/16] xen/arm: Extend copy_to_guest to support zeroing guest VA and use it

2017-12-12 Thread Stefano Stabellini
ear_guest using copy_to_guest. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > Changes in v3: > - Use vaddr_t > --- > xen/arch/arm/guestcopy.c | 41 +++--

Re: [Xen-devel] [v2 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-12 Thread Stefano Stabellini
On Tue, 12 Dec 2017, Julien Grall wrote: > This new function will be used in a follow-up patch to copy data to the guest > using the IPA (aka guest physical address) and then clean the cache. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano St

[Xen-devel] [PULL 3/6] xenfb: Use Input Handlers directly

2017-12-14 Thread Stefano Stabellini
_linux(). Removes the scancode2linux mapping, and supporting documention. Signed-off-by: Owen Smith <owen.sm...@citrix.com> Reviewed-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.o

[Xen-devel] [PULL 1/6] xen-disk: use an IOThread per instance

2017-12-14 Thread Stefano Stabellini
follow the state transtions of an instance in the log. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/block/trace-events | 7 +++ hw

[Xen-devel] [PULL 4/6] xenfb: Add [feature|request]-raw-pointer

2017-12-14 Thread Stefano Stabellini
77644fa884a5031e Signed-off-by: Owen Smith <owen.sm...@citrix.com> Reviewed-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/display/xenfb.c | 47

[Xen-devel] [PULL 2/6] ui: generate qcode to linux mappings

2017-12-14 Thread Stefano Stabellini
From: Owen Smith <owen.sm...@citrix.com> Use keycodedb to generate a qcode to linux mapping Signed-off-by: Owen Smith <owen.sm...@citrix.com> Reviewed-by: Gerd Hoffmann <kra...@redhat.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- Makefile

[Xen-devel] [PULL 0/6] xen-20171214-tag

2017-12-14 Thread Stefano Stabellini
The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639: Update version for v2.11.0 release (2017-12-13 14:31:09 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20171214-tag for you to fetch changes up to

[Xen-devel] [PULL 6/6] xen/pt: Set is_express to avoid out-of-bounds write

2017-12-14 Thread Stefano Stabellini
x86_64-linux-gnu/libglib-2.0.so.0+0x50580) #2 0x55e0fdda7d3d in device_set_realized hw/core/qdev.c:914 [...] Signed-off-by: Simon Gaiser <h...@ipsumj.de> Acked-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/xe

[Xen-devel] [PULL 5/6] xenfb: activate input handlers for raw pointer devices

2017-12-14 Thread Stefano Stabellini
tablet or emulated PS/2 mouse. HVM xen_kbdfront can incorrectly scale absolute coordinates when the display resolution is not 800x600. Signed-off-by: Owen Smith <owen.sm...@citrix.com> Reviewed-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Stefano Stabellini <sstabell...@k

Re: [Xen-devel] [v2 02/16] xen/arm: raw_copy_to_guest_helper: Rework the prototype and rename it

2017-12-12 Thread Stefano Stabellini
hat for now, only > copying to guest virtual address is supported. Follow-up patches will > extend the support. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > Changes in v2: >

Re: [Xen-devel] [v2 16/16] xen/arm: traps: Merge do_trap_instr_abort_guest and do_trap_data_abort_guest

2017-12-12 Thread Stefano Stabellini
rate helpers. > > For instance, merging the both will make easier to maintain stage-2 abort > handling. So consolidate the two helpers in a new helper > do_trap_stage2_abort. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabe

Re: [Xen-devel] [v2 03/16] xen/arm: Extend copy_to_guest to support copying from guest VA and use it

2017-12-12 Thread Stefano Stabellini
to support copying from guest VA by adding using a > bit in the flags to tell the direction of the copy. > > Lastly, reimplement raw_copy_from_guest using copy_to_guest. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell.

Re: [Xen-devel] [v2 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-12 Thread Stefano Stabellini
o extend the use of it, it is now possible > to copy data crossing page boundary. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > Changes in v2: > - Rework the patch after the int

Re: [Xen-devel] [PATCH] xen/efi: Fix build with clang-5.0

2017-12-13 Thread Stefano Stabellini
> Spotted by Travis. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: J

Re: [Xen-devel] [PATCH for-next 14/16] xen/arm: traps: Remove the field gva from mmio_info_t

2017-12-07 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > mmio_info_t is used to gather information in order do emulation a ^ of a Aside from this Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > region. Guest vir

Re: [Xen-devel] [PATCH for-next 15/16] xen/arm: traps: Move the definition of mmio_info_t in try_handle_mmio

2017-12-07 Thread Stefano Stabellini
o_info_t is now filled by > try_handle_mmio. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/arch/arm/traps.c | 31 +-- > 1 file changed, 17 insertions(+), 1

Re: [Xen-devel] [PATCH for-next 16/16] xen/arm: traps: Merge do_trap_instr_abort_guest and do_trap_data_abort_guest

2017-12-07 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The two helpers do_trap_instr_abort_guest and do_trap_data_abort_guest > are used trap stage-2 abort. While the former is only handling prefetch > abort and the latter data abort, they are very similarly and does not > warrant to have separate helpers. >

Re: [Xen-devel] [PATCH for-next 12/16] xen/arm: p2m: Introduce p2m_tlb_flush_sync, export it and use it

2017-12-07 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > Multiple places in the code requires to flush the TLBs wonly when ^ only Aside from this Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > p2m->need_flush is set. >

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Bail out if gicv3_cpu_init fail

2017-12-07 Thread Stefano Stabellini
icv3_cpu_init only > on success. As the rest of the code (e.g gicv3_hyp_init) relies on > system register, it is better to bail out directly. > > This will save time on debugging early boot issue on GICv3 platform. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> This

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-07 Thread Stefano Stabellini
On Wed, 6 Dec 2017, Julien Grall wrote: > Hi Stefano, > > On 12/06/2017 01:22 AM, Stefano Stabellini wrote: > > On Thu, 23 Nov 2017, Julien Grall wrote: > > > The only differences between copy_to_guest and access_guest_memory_by_ipa > > > are: > > >

Re: [Xen-devel] [PATCH for-next 11/16] xen/arm: p2m: Rename p2m_flush_tlb and p2m_flush_tlb_sync

2017-12-07 Thread Stefano Stabellini
asily some code ported > from x86 P2M or even to shared with. > > For p2m_flush_tlb_sync, the 'force' was added because the TLBs are > flush unconditionally. A follow-up patch will add an helper to flush > TLBs only in certain cases. > > Signed-off-by: Julien Grall <julien.

Re: [Xen-devel] [PATCH for-next 13/16] xen/arm: p2m: Fold p2m_tlb_flush into p2m_force_tlb_flush_sync

2017-12-07 Thread Stefano Stabellini
> > This seems a bit pointless but would allow to have a single API for > flushing and avoid misusage in the P2M code. > > So update p2m_alloc_table to use p2m_force_tlb_flush_sync and fold > p2m_tlb_flush in p2m_force_tlb_flush_sync. > > Signed-off-by: Julien Grall <juli

Re: [Xen-devel] [PATCH] xen/arm64: head.S: Introduce macro to load the physical address of a symbol

2017-12-07 Thread Stefano Stabellini
acro to replace all the current opencoded version. > > Note that most of comments associated to the code changed have been > removed because the code is now self-explanatory. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell

Re: [Xen-devel] [PATCH] xen/arm: Remove unused fixmap slots

2017-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2017, Julien Grall wrote: > There are quite a few fixmap slots that have not been used for a while. > Remove them. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > xe

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Volodymyr Babchuk wrote: > Hi Stefano, > > On Mon, Dec 04, 2017 at 06:30:13PM -0800, Stefano Stabellini wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > > > From: Volodymyr Babchuk <volodymyr_babc...@epam.com> > > > >

Re: [Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Dan Carpenter wrote: > Smatch complains that "len" is uninitialized if xenbus_read() fails so > let's add some error handling. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.or

Re: [Xen-devel] [RFC PATCH 27/31] cpufreq: hack: perf->states isn't a real guest handle on ARM

2017-12-05 Thread Stefano Stabellini
Tyshchenko <oleksandr_tyshche...@epam.com> > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <julien.gr...@linaro.org> As a reference, this pat

Re: [Xen-devel] [PATCH 1/2] gnttab: correct GNTTABOP_cache_flush empty batch handling

2017-12-05 Thread Stefano Stabellini
pportunity and also correct the order of argument checks: > >> We shouldn't accept zero-length elements with unknown bits set in "op". > >> Also constify cache_flush()'s first parameter. > >> > >> Reported-by: Jann Horn <ja...@google.com> &g

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Oleksandr Tyshchenko wrote: > >> Another question is second_max_freq. As I understand, it is highest > >> non-turbo frequency calculated by framework to limit target frequency > >> when > >> turbo mode "is disabled". And Xen assumes that second_max_freq is > >> always P1 if

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Julien Grall wrote: > Hi Ian, > > On 05/12/17 18:28, Ian Jackson wrote: > > This drops the dependency on Stefano's personal git tree. > > The osstest output branch remains unmoved. > > > > CC: Stefano Stabellini <sstabell...@kernel.

Re: [Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Stefano Stabellini
the backend") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c > index 40caa92bff33..d1e1d8d2b9d5 100644 > --- a/drivers/

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > Hi Stefano, > > On 07/12/17 23:01, Stefano Stabellini wrote: > > On Wed, 6 Dec 2017, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 12/06/2017 01:22 AM, Stefano Stabellini wrote: > > > > On Th

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Bail out if gicv3_cpu_init fail

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > Hi Stefano, > > On 07/12/17 23:05, Stefano Stabellini wrote: > > On Wed, 6 Dec 2017, Julien Grall wrote: > > > From: Julien Grall <julien.gr...@arm.com> > > > > > > When system registers a

Re: [Xen-devel] [PATCH] xen/arm: Surround HSR_SYSREG macro value with ()

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > Hi, > > Ping? > > Cheers, > > On 29/11/17 17:46, Julien Grall wrote: > > The value of the macro HCR_SYSREG is not surrounded by (). This means > > the behavior may change depend on how it is used. > > > > Thanksfully recent GCC will issue a warning for

Re: [Xen-devel] [RFC PATCH 29/31] xen/arm: Introduce CPUFreq Interface component

2017-12-06 Thread Stefano Stabellini
On Wed, 6 Dec 2017, Oleksandr Tyshchenko wrote: > >> +perf->platform_limit = platform_limit; > >> +perf->shared_type = CPUFREQ_SHARED_TYPE_ANY; > >> +perf->domain_info.domain = cpumask_first(mask); > >> +perf->domain_info.num_processors = cpumask_weight(mask); > >> + > >> +/*

Re: [Xen-devel] [PATCH for-next 04/16] xen/arm: Extend copy_to_guest to support zeroing guest VA and use it

2017-12-05 Thread Stefano Stabellini
ear_guest using copy_to_guest. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Aside from the usual question about vaddr_t: Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/arch/arm/guestcopy.c | 41 +++--

Re: [Xen-devel] [PATCH for-next 05/16] xen/arm: guest_copy: Extend the prototype to pass the vCPU

2017-12-05 Thread Stefano Stabellini
linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/arch/arm/guestcopy.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/guestcopy.c b/xen/arch/arm/guestcopy.c > index 3aaa80859e..487f5ab82d

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > Hi Andrew, > > On 23/11/17 18:49, Andrew Cooper wrote: > > On 23/11/17 18:32, Julien Grall wrote: > > > This new function will be used in a follow-up patch to copy data to the > > > guest > > > using the IPA (aka guest physical address) and then clean

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Julien Grall wrote: > Hi all, > > Even though it is an Arm failure, I have CCed x86 folks to get feedback on the > approach. I have a WIP branch I could share if that interest people. > > Few months ago, we noticed an heisenbug on jobs run by osstest on the > cubietrucks (see

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Stefano Stabellini wrote: > On Thu, 23 Nov 2017, Julien Grall wrote: > > The only differences between copy_to_guest and access_guest_memory_by_ipa > > are: > > - The latter does not support copying data crossing page boundary > > - The form

Re: [Xen-devel] [PATCH for-next 02/16] xen/arm: raw_copy_to_guest_helper: Rework the prototype and rename it

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > All the helpers within arch/arm/guestcopy.c are doing the same things: > copy data from/to the guest. > > At the moment, the logic is duplicated in each helpers making more > difficult to implement new variant. > > The first step for the consolidation

Re: [Xen-devel] [PATCH for-next 03/16] xen/arm: Extend copy_to_guest to support copying from guest VA and use it

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The only differences between copy_to_guest (formerly called > raw_copy_to_guest_helper) and raw_copy_from_guest is: > - The direction of the memcpy > - The permission use for translating the address > > Extend copy_to_guest to support copying

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The only differences between copy_to_guest and access_guest_memory_by_ipa are: > - The latter does not support copying data crossing page boundary > - The former is copying from/to guest VA whilst the latter from > guest PA > > copy_to_guest

Re: [Xen-devel] [PATCH for-next 01/16] xen/arm: raw_copy_to_guest_helper: Rename flush_dcache to flags

2017-12-05 Thread Stefano Stabellini
lien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/arch/arm/guestcopy.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/guestcopy.c b/xen/arch/arm/guestcopy.c > index

Re: [Xen-devel] [PATCH for-next 08/16] xen/arm: kernel: Rework kernel_zimage_load to use the generic copy helper

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Stefano Stabellini wrote: > On Thu, 23 Nov 2017, Julien Grall wrote: > > The function kernel_zimage is dealing with IPA but uses gvirt_to_maddr to > > do the translation. This is currently working fine because the stage-1 MMU > > is disabled. > > &g

Re: [Xen-devel] [PATCH for-next 10/16] xen/arm: domain_build: Use copy_to_guest_phys_flush_dcache in dtb_load

2017-12-05 Thread Stefano Stabellini
_phys_flush_dcache. This also result to a slightly more > comprehensible code. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Yes definitely an improvement Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/arch/arm/domain_build.c | 7

Re: [Xen-devel] [PATCH for-next 09/16] xen/arm: domain_build: Rework initrd_load to use the generic copy helper

2017-12-05 Thread Stefano Stabellini
ulien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/arch/arm/domain_build.c | 31 --- > 1 file changed, 8 insertions(+), 23 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xe

Re: [Xen-devel] [Qemu-devel] [PATCH] xen/pt: Set is_express to avoid out-of-bounds write

2017-12-08 Thread Stefano Stabellini
here: > #0 0x7ff596a94bb8 in __interceptor_calloc > (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xd9bb8) > #1 0x7ff57da66580 in g_malloc0 > (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x50580) > #2 0x55e0fdda7d3d in device_set_realized hw/core/qdev.c:914 > [...] > > Signed

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > On 8 Dec 2017 22:26, "Stefano Stabellini" <sstabell...@kernel.org> wrote: > On Fri, 8 Dec 2017, Julien Grall wrote: > > On 06/12/17 12:27, Julien Grall wrote: > > > On 12/06/2017 01:26 AM, Stefano S

Re: [Xen-devel] [PATCH v3 for-next 4/4] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN

2017-12-11 Thread Stefano Stabellini
the callers are now switched to _mfn(domain_page_to_mfn(...)). > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Acked-by: Stefano Stabellini <sstabell...@kernel.org> > --- > > Andrew suggested to drop IS_VALID_PAGE in xen/tmem_xen.h. His comment > was: > > "

Re: [Xen-devel] [PATCH v3 for-next 0/4] xen: Convert __page_to_mfn and _mfn_to_page to use typesafe MFN

2017-12-11 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Jan Beulich wrote: > >>> On 09.11.17 at 16:48, wrote: > > On 09/11/17 15:47, Jan Beulich wrote: > > On 09.11.17 at 16:39, wrote: > >>> What I meant is you would replace the 4 occurrences by > >>> mfn_to_page(_mfn(...)). If

Re: [Xen-devel] [RFC] xen/arm: Suspend to RAM Support in Xen for ARM

2017-12-11 Thread Stefano Stabellini
On Wed, 9 Aug 2017, Mirela Simonovic wrote: > This document contains our draft proposal for implementing "suspend to RAM" > support for ARM in Xen, as discussed during the last Xen ARM community call. > It covers the basic suspend to RAM mechanism based on ARM PSCI standard, > that would allow

Re: [Xen-devel] [PATCH v3 for-next 2/4] xen/arm32: mm: Rework is_xen_heap_page to avoid nameclash

2017-12-11 Thread Stefano Stabellini
t; Fix it by renaming the local variable _mfn to mfn_. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > > Cc: Stefano Stabellini <sstabell...@kernel.org> > > Changes in v3: >

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-11 Thread Stefano Stabellini
On Tue, 12 Dec 2017, Julien Grall wrote: > Hi Stefano, > > On 12/08/2017 10:43 PM, Stefano Stabellini wrote: > > On Fri, 8 Dec 2017, Julien Grall wrote: > > > On 8 Dec 2017 22:26, "Stefano Stabellini" <sstabell...@kernel.org> wrote: > > &

Re: [Xen-devel] [PATCH v3 for-next 1/4] xen/arm: domain_build: Clean-up insert_11_bank

2017-12-11 Thread Stefano Stabellini
On Wed, 1 Nov 2017, Julien Grall wrote: > - Remove spurious () > - Add missing spaces > - Turn 1 << to 1UL << > - Rename spfn to smfn and switch to mfn_t > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefan

Re: [Xen-devel] [PATCH 1/2] gnttab: correct GNTTABOP_cache_flush empty batch handling

2017-12-01 Thread Stefano Stabellini
orn <ja...@google.com> > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Stefano Stabellini <sstabell...@kernel.org> > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -3208,7 +3208,7 @@ gnttab_swap_grant_ref(XEN_GUEST_HANDLE_P > retu

Re: [Xen-devel] [PATCH 2/2] gnttab: improve GNTTABOP_cache_flush locking

2017-12-01 Thread Stefano Stabellini
ff-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -786,10 +786,10 @@ static int _set_status(unsigned gt_versi > return _set_status_v2(d

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-01 Thread Stefano Stabellini
On Mon, 27 Nov 2017, Volodymyr Babchuk wrote: > This is follow-up to our conversation during community call. > You asked me to send OP-TEE mediator as a patch, so we can > discuss it in the mailing list. So, there it is. I squashed > two patches into one and skipped patches that we already >

Re: [Xen-devel] [RFC PATCH 01/31] cpufreq: move cpufreq.h file to the xen/include/xen location

2017-12-01 Thread Stefano Stabellini
lt;jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > MAINTAINERS

Re: [Xen-devel] [RFC PATCH 02/31] pm: move processor_perf.h file to the xen/include/xen location

2017-12-01 Thread Stefano Stabellini
lt;jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > MAINTAINERS

Re: [Xen-devel] [RFC PATCH 03/31] pmstat: move pmstat.c file to the xen/drivers/pm/stat.c location

2017-12-01 Thread Stefano Stabellini
lt;jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > MAINTAINERS |

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-01 Thread Stefano Stabellini
@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <julien.gr...@linaro.org> > --- > xen/arch/x86/Kconfig | 1 + > xen/drivers/cpufreq/Kconfig | 3 +++ > xen/drivers

Re: [Xen-devel] [RFC PATCH 05/31] pmstat: make pmstat functions more generalizable

2017-12-01 Thread Stefano Stabellini
ates, couldn't we just rely on XEN_PROCESSOR_PM_CX not being available? > Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytrys...@globallogic.com> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <a

Re: [Xen-devel] [RFC PATCH 07/31] xenpm: Clarify xenpm usage

2017-12-01 Thread Stefano Stabellini
Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > > CC: Ian Jackson <ian.jack...@eu.citrix.com> > > CC: Wei Liu <wei.l...@citrix.com> > > CC: Stefano Stabellini <sstabell...@kernel.org> > > CC: Julien Grall <julien.gr...@linaro.org> &

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-01 Thread Stefano Stabellini
sandr_tyshche...@epam.com> > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Julien Grall <julien.gr...@linaro.org> > --- > xen/drivers/cpufreq/cpufreq.c|

Re: [Xen-devel] [PATCH v2 10/10] ARM: VGIC: rework gicv[23]_update_lr to not use pending_irq

2017-12-08 Thread Stefano Stabellini
rom gic-v[23].c. > > Signed-off-by: Andre Przywara <andre.przyw...@linaro.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/arch/arm/gic-v2.c | 14 +++--- > xen/arch/arm/gic-v3.c | 12 ++-- > xen/arch/arm/gic-vgic.c

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > On 06/12/17 12:27, Julien Grall wrote: > > On 12/06/2017 01:26 AM, Stefano Stabellini wrote: > > > On Thu, 23 Nov 2017, Julien Grall wrote: > > > > Hi Andrew, > > > > > > > > On 23/11/17 18:49, An

Re: [Xen-devel] [PATCH v3 10/10] xen/arm: Enable errata for secondary CPU on hotplug after the boot

2018-05-14 Thread Stefano Stabellini
On Mon, 14 May 2018, Julien Grall wrote: > On 11/05/18 22:47, Stefano Stabellini wrote: > > On Fri, 11 May 2018, Dario Faggioli wrote: > > > On Fri, 2018-05-11 at 14:08 +0100, Julien Grall wrote: > > > > The whole idea here is we have only one place taking the decisio

Re: [Xen-devel] Xen and safety certification, Minutes of the meeting on Apr 4th

2018-05-07 Thread Stefano Stabellini
On Fri, 6 Apr 2018, Stefano Stabellini wrote: > > > > > 3) Understand how to address dom0. FreeRTOS Dom0 sounds like a good > > > > > solution. > > > > > Next step: reach out to Dornerworks and/or others that worked with > > > > > Fre

Re: [Xen-devel] migration regression in xen-4.11 and qemu-2.11 and qcow2

2018-05-09 Thread Stefano Stabellini
CC'ing Linux x86 maintainers On Wed, 9 May 2018, Olaf Hering wrote: > Am Wed, 9 May 2018 14:08:14 -0700 (PDT) > schrieb Stefano Stabellini <sstabell...@kernel.org>: > > > I cannot find 512b109ec962 or "xen: unplug the emulated devices at > > resume time" any

Re: [Xen-devel] [PATCH v2 3/3] xen: share start flags between PV and PVH

2018-05-09 Thread Stefano Stabellini
vsky <boris.ostrov...@oracle.com> > Signed-off-by: Roger Pau Monné <roger@citrix.com> > --- > Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> > Cc: Juergen Gross <jgr...@suse.com> > Cc: Stefano Stabellini <sstabell...@kernel.org> > Cc: xen-devel@lists.xe

Re: [Xen-devel] migration regression in xen-4.11 and qemu-2.11 and qcow2

2018-05-10 Thread Stefano Stabellini
On Thu, 10 May 2018, Olaf Hering wrote: > Am Wed, 9 May 2018 14:43:17 -0700 (PDT) > schrieb Stefano Stabellini <sstabell...@kernel.org>: > > > 512b109ec962 is a very old commit: why is it causing problems to Xen > > 4.10 and Xen 4.11 HVM migration? What is the error

Re: [Xen-devel] migration regression in xen-4.11 and qemu-2.11 and qcow2

2018-05-09 Thread Stefano Stabellini
On Wed, 9 May 2018, Olaf Hering wrote: > Am Tue, 8 May 2018 18:40:26 +0200 > schrieb Olaf Hering : > > > It looks like the IDE unplug is not permanent. > > Stefano, > > Jochen pointed me to commit 512b109ec962 ("xen: unplug the emulated devices > at resume time"), which I think

Re: [Xen-devel] [PATCH v3 10/10] xen/arm: Enable errata for secondary CPU on hotplug after the boot

2018-05-11 Thread Stefano Stabellini
On Fri, 11 May 2018, Dario Faggioli wrote: > On Fri, 2018-05-11 at 14:08 +0100, Julien Grall wrote: > > The whole idea here is we have only one place taking the decision and > > we > > don't spread BUG_ON()/panic/stop_cpu everywhere. The benefit is > > having > > only one place to fix over

Re: [Xen-devel] Xen and safety certification, Minutes of the meeting on Apr 4th

2018-05-10 Thread Stefano Stabellini
On Thu, 10 May 2018, Praveen Kumar wrote: > > Yeah, you are right. It looks like turning Dom0 into a DomU is not good > > enough. Maybe for this option to be viable we would actually have to > > terminate (or pause and never unpause?) dom0 after boot. > > Just a thought ! > How about keeping Dom0

Re: [Xen-devel] Xen and safety certification, Minutes of the meeting on Apr 4th

2018-05-08 Thread Stefano Stabellini
On Tue, 8 May 2018, Julien Grall wrote: > Hi Stefano, > > On 08/05/18 01:11, Stefano Stabellini wrote: > > On Fri, 6 Apr 2018, Stefano Stabellini wrote: > > > > > > > 3) Understand how to address dom0. FreeRTOS Dom0 sounds like a > > > > > >

Re: [Xen-devel] ViryaOS: proposal for a new Xen Project sub-project

2018-05-21 Thread Stefano Stabellini
On Mon, 21 May 2018, Roger Pau Monné wrote: > This looks interesting IMO. Just one small nit. > > On Thu, May 17, 2018 at 03:31:40PM -0700, Stefano Stabellini wrote: > > ## Hardware Support > > > > ViryaOS will support as many hardware platforms as possible, x86 an

[Xen-devel] [PULL 03/15] configure: Add explanation for --enable-xen-pci-passthrough

2018-05-21 Thread Stefano Stabellini
From: Anthony PERARD <anthony.per...@citrix.com> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- configure | 2 +- 1 file changed, 1 insertion(+), 1

[Xen-devel] [PULL 09/15] xen_disk: remove open-coded use of libxengnttab

2018-05-21 Thread Stefano Stabellini
urrant <paul.durr...@citrix.com> Acked-by: Anthony Perard <anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/block/xen_disk.c | 122 ++-- 1 file changed, 32 insertions(+), 90 deletions(-

[Xen-devel] [PULL 05/15] xen-hvm: create separate function for ioreq server initialization

2018-05-21 Thread Stefano Stabellini
<anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/i386/xen/xen-hvm.c | 76 +++ 1 file changed, 46 insertions(+), 30 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index

[Xen-devel] [PULL 06/15] All the xen stable APIs define handle types of the form:

2018-05-21 Thread Stefano Stabellini
le API handles of the forms detailed above. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- dtc | 2 +- scripts/checkpatch.pl | 2 +- ui/keycodemapdb

[Xen-devel] [PULL 10/15] xen: remove other open-coded use of libxengnttab

2018-05-21 Thread Stefano Stabellini
From: Paul Durrant <paul.durr...@citrix.com> Now that helpers are available in xen_backend, use them throughout all Xen PV backends. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony Perard <anthony.per...@citrix.com> Signed-off-by: Stefano St

[Xen-devel] [PULL 08/15] xen_backend: add grant table helpers

2018-05-21 Thread Stefano Stabellini
method is responsible for mapping the shared ring. No prior method requires access to the grant table. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/xen/xen

[Xen-devel] [PULL 13/15] xen_backend: make the xen_feature_grant_copy flag private

2018-05-21 Thread Stefano Stabellini
From: Paul Durrant <paul.durr...@citrix.com> There is no longer any use of this flag outside of the xen_backend code. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony Perard <anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@ke

[Xen-devel] [PULL 01/15] xen-pvdevice: Introduce a simplistic xen-pvdevice save state

2018-05-21 Thread Stefano Stabellini
change their state for worse. Signed-off-by: Igor Druzhinin <igor.druzhi...@citrix.com> Reviewed-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/i386/xen/xen_pvdevice.c |

[Xen-devel] [PULL 07/15] xen: add a meaningful declaration of grant_copy_segment into xen_common.h

2018-05-21 Thread Stefano Stabellini
mmon.h, which allows xen_disk to be cleaned up. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/block/xen_disk.c | 18 -- include/

[Xen-devel] [PULL 14/15] xen_disk: use a single entry iovec

2018-05-21 Thread Stefano Stabellini
cantly. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Anthony Perard <anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/block/xen_disk.c | 76 +++-- 1 file changed, 21 ins

[Xen-devel] [PULL 12/15] xen_disk: remove use of grant map/unmap

2018-05-21 Thread Stefano Stabellini
itrix.com> Acked-by: Anthony Perard <anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/block/xen_disk.c | 352 1 file changed, 25 insertions(+), 327 deletions(-) diff --git a/hw/blo

  1   2   3   4   5   6   7   8   9   10   >