Re: [Xen-devel] [PATCH] XSM: add Kconfig option to override bootloader provided policy

2017-11-28 Thread Tamas K Lengyel
On Tue, Nov 28, 2017 at 12:00 PM, Andrew Cooper <andrew.coop...@citrix.com> wrote: > On 28/11/17 18:06, Tamas K Lengyel wrote: >> From: Tamas K Lengyel <lengy...@ainfosec.com> >> >> Currently the built-in XSM policy only gets used if there is no other policy >&g

Re: [Xen-devel] [PATCH] XSM: add Kconfig option to override bootloader provided policy

2017-11-29 Thread Tamas K Lengyel
On Wed, Nov 29, 2017 at 5:29 AM, George Dunlap <george.dun...@citrix.com> wrote: > On 11/28/2017 07:04 PM, Tamas K Lengyel wrote: >> On Tue, Nov 28, 2017 at 12:00 PM, Andrew Cooper >> <andrew.coop...@citrix.com> wrote: >>> On 28/11/17 18:06, Tamas K Lengyel wrot

Re: [Xen-devel] [PATCH] XSM: add Kconfig option to override bootloader provided policy

2017-11-29 Thread Tamas K Lengyel
On Wed, Nov 29, 2017 at 1:19 AM, Jan Beulich wrote: On 28.11.17 at 19:06, wrote: >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -140,6 +140,20 @@ config XSM_POLICY >> >> If unsure, say Y. >> >> +config XSM_POLICY_OVERRIDE >> +

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-08 Thread Tamas K Lengyel
On Fri, Dec 8, 2017 at 5:42 AM, Razvan Cojocaru wrote: > On 12/08/2017 02:18 PM, Jan Beulich wrote: > On 24.10.17 at 12:19, wrote: >>> HVMOP_altp2m_set_mem_access_multi has been added as a HVMOP (as opposed to a >>> DOMCTL) for

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread Tamas K Lengyel
On Mon, Dec 11, 2017 at 8:05 AM, Jan Beulich wrote: On 11.12.17 at 15:51, wrote: >> On 12/11/2017 02:46 PM, Razvan Cojocaru wrote: >>> On 12/11/2017 03:36 PM, Jan Beulich wrote: >>> On 11.12.17 at 13:50, wrote:

Re: [Xen-devel] [PATCH v6] x86/mm: Suppresses vm_events caused by page-walks

2018-05-07 Thread Tamas K Lengyel
gt; This is needed by the introspection so it will only get gla > faults and not get spammed with other faults. > In p2m_mem_access_check() we emulate so no event will get sent. Thanks for the changes! Acked-by: Tamas K Lengyel <ta...@tklengyel.com> > Signed-off-by: Alexandr

Re: [Xen-devel] [PATCH v5] x86/mm: Suppresses vm_events caused by page-walks

2018-04-27 Thread Tamas K Lengyel
On Mon, Apr 23, 2018 at 2:00 AM, Alexandru Isaila wrote: > This patch is adding a way to enable/disable inguest pagefault > events. It introduces the xc_monitor_inguest_pagefault function > and adds the inguest_pagefault_disabled in the monitor structure. > This is needed

Re: [Xen-devel] [PATCH v5] x86/mm: Suppresses vm_events caused by page-walks

2018-04-28 Thread Tamas K Lengyel
On Sat, Apr 28, 2018 at 12:13 AM, Razvan Cojocaru <rcojoc...@bitdefender.com> wrote: > On 04/28/2018 12:30 AM, Tamas K Lengyel wrote: >> >> On Mon, Apr 23, 2018 at 2:00 AM, Alexandru Isaila >> <aisa...@bitdefender.com> wrote: >>> >>> This patch

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-17 Thread Tamas K Lengyel
roperly parse this > buffer, thus making it possible to have separate EFI boot options > present for the different config sections. > > Signed-off-by: Tamas K Lengyel <ta...@tklengyel.com> > Signed-off-by: Jan Beulich <jbeul...@suse.com> > --- > v4: Address my own revi

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-21 Thread Tamas K Lengyel
On Thu, May 17, 2018 at 11:42 AM, Tamas K Lengyel <ta...@tklengyel.com> wrote: > On Thu, May 17, 2018 at 2:03 AM, Jan Beulich <jbeul...@suse.com> wrote: >>>>> On 07.02.18 at 17:00, <ta...@tklengyel.com> wrote: >>> This patch as-is correctly tells

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-22 Thread Tamas K Lengyel
> buffer, thus making it possible to have separate EFI boot options > present for the different config sections. > > Signed-off-by: Tamas K Lengyel <ta...@tklengyel.com> > Signed-off-by: Jan Beulich <jbeul...@suse.com> > --- > v4: Address my

Re: [Xen-devel] [PATCH v1 2/2] hvm/svm: Enable EMUL_UNIMPLEMENTED events on svm

2018-05-18 Thread Tamas K Lengyel
On Fri, May 18, 2018 at 9:32 AM, Jan Beulich wrote: On 11.05.18 at 13:11, wrote: >> Signed-off-by: Alexandru Isaila > > It would be helpful to know whether this patch depends on patch 1 in any way. > If it doesn't, with

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-18 Thread Tamas K Lengyel
On Mon, Jun 18, 2018 at 9:19 AM Alexandru Isaila wrote: > > From: Isaila Alexandru > > This patch adds access rights for the NPT pages. The access rights are > saved in a radix tree with the root saved in p2m_domain. The rights are > manipulated through p2m_set_access() > and p2m_get_access()

Re: [Xen-devel] TESTDAY report 4.11rc6

2018-06-12 Thread Tamas K Lengyel
> > ## Functionality tested > > - PV & HVM/ xl create, shu, des > - HVM/ altp2m with LibVMI and Drakvuf (on the modern hardware only) Happy to see Drakvuf getting some tests alongside Xen :) This test report thus covers vm_event and memaccess interfaces as well. Thanks! Tamas

Re: [Xen-devel] [PATCH v3 04/10] Make MEM_ACCESS configurable

2018-05-30 Thread Tamas K Lengyel
On Wed, May 30, 2018 at 2:24 PM, Stefano Stabellini wrote: > On Tue, 29 May 2018, Jan Beulich wrote: >> >>> On 23.05.18 at 02:25, wrote: >> > --- a/xen/arch/arm/Kconfig >> > +++ b/xen/arch/arm/Kconfig >> > @@ -26,6 +26,9 @@ config ARCH_DEFCONFIG >> > default

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-29 Thread Tamas K Lengyel
On Fri, Jun 29, 2018 at 3:38 AM Jan Beulich wrote: > > >>> On 29.06.18 at 10:42, wrote: > > I've started a win 7 machine with no introspection or xen-access. After > > 30 min of uptime there were 0 inserts into the tree. I guess the > > overhead is down to a minimum with no user modified access

Re: [Xen-devel] Altp2m/#VE page issue

2018-06-29 Thread Tamas K Lengyel
On Fri, Jun 29, 2018 at 9:25 AM Razvan Cojocaru wrote: > > Hello, > > We're trying to get #VE to work with a "regular" guest page (that is, > not a page that we get via xc_domain_increase_reservation_exact() / > xc_domain_populate_physmap_exact()). > > However, the way Xen's code works now, it

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-19 Thread Tamas K Lengyel
On Tue, Jun 19, 2018 at 2:14 AM Alexandru Stefan ISAILA wrote: > > On Lu, 2018-06-18 at 09:39 -0600, Tamas K Lengyel wrote: > > On Mon, Jun 18, 2018 at 9:19 AM Alexandru Isaila > > wrote: > > > > > > > > > +static p2m_access_t p2m_get_access(st

[Xen-devel] [PATCHv2] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Tamas K Lengyel
, and in this patch we make Xen properly parse this buffer, thus making it possible to have separate EFI boot options present for the different config sections. Signed-off-by: Tamas K Lengyel <lengy...@ainfosec.com> --- Cc: Jan Beulich <jbeul...@suse.com> Cc: ope...@googlegroups.c

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Tamas K Lengyel
On Thu, Jan 4, 2018 at 8:00 AM, Jan Beulich wrote: On 04.01.18 at 15:39, wrote: >> On Thu, Jan 4, 2018 at 3:43 AM, Jan Beulich wrote: >>> Just looking at the low bit of the first >>> byte before assuming this could be a load option

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Tamas K Lengyel
On Thu, Jan 4, 2018 at 9:25 AM, Jan Beulich wrote: On 04.01.18 at 17:16, wrote: >> On Thu, Jan 4, 2018 at 8:00 AM, Jan Beulich wrote: >> On 04.01.18 at 15:39, wrote: On Thu, Jan 4, 2018 at 3:43 AM,

Re: [Xen-devel] AMD / SVM vm_event support

2018-01-18 Thread Tamas K Lengyel
On Thu, Jan 18, 2018 at 6:19 AM, Razvan Cojocaru wrote: > Hello, > > We're looking at potentially working with vm_event on SVM hosts. To that > end, we've removed a few cpu_has_vmx tests and saw that some things just > work. > > That is, unfortunately, not the case for

Re: [Xen-devel] [PATCHv2] xen: Add EFI_LOAD_OPTION support

2018-01-19 Thread Tamas K Lengyel
On Fri, Jan 19, 2018 at 2:12 AM, Jan Beulich wrote: On 04.01.18 at 21:33, wrote: >> @@ -375,12 +385,52 @@ static void __init PrintErrMesg(const CHAR16 *mesg, >> EFI_STATUS ErrCode) >> >> static unsigned int __init get_argv(unsigned int argc, CHAR16

Re: [Xen-devel] [PATCHv2] xen: Add EFI_LOAD_OPTION support

2018-01-19 Thread Tamas K Lengyel
On Fri, Jan 19, 2018 at 9:41 AM, Jan Beulich wrote: On 19.01.18 at 17:25, wrote: >> On Fri, Jan 19, 2018 at 2:12 AM, Jan Beulich wrote: >>> And then - how about a different heuristic altogether: Current >>> code scans the pointed

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-01-26 Thread Tamas K Lengyel
On Fri, Jan 26, 2018 at 5:46 AM, Jan Beulich wrote: On 23.01.18 at 01:21, wrote: >> @@ -88,6 +88,16 @@ typedef struct _EFI_APPLE_PROPERTIES { >> EFI_APPLE_PROPERTIES_GETALL GetAll; >> } EFI_APPLE_PROPERTIES; >> >> +typedef struct

Re: [Xen-devel] [PATCH] tests/xen-access: disable CR4 write events on application exit

2018-01-29 Thread Tamas K Lengyel
On Mon, Jan 29, 2018 at 10:10 AM, Razvan Cojocaru wrote: > On exit, xen-access did not unsubscribe from CR4 write vm_events, > potentially leaving the guest stuck. > > Signed-off-by: Razvan Cojocaru > --- >

Re: [Xen-devel] [PATCH] tests/xen-access: disable CR4 write events on application exit

2018-01-29 Thread Tamas K Lengyel
On Mon, Jan 29, 2018 at 11:03 AM, Razvan Cojocaru <rcojoc...@bitdefender.com> wrote: > On 01/29/2018 07:58 PM, Tamas K Lengyel wrote: >> On Mon, Jan 29, 2018 at 10:10 AM, Razvan Cojocaru >> <rcojoc...@bitdefender.com> wrote: >>> On exit, xen-access did not

Re: [Xen-devel] [PATCH v1 2/4] hvm/svm: Enable Breakpoint events

2018-02-02 Thread Tamas K Lengyel
On Fri, Feb 2, 2018 at 2:37 AM, Alexandru Isaila wrote: > This commit enables the breakpoint events for svm. > > Signed-off-by: Alexandru Isaila > --- > xen/arch/x86/hvm/svm/svm.c| 52 > --- >

Re: [Xen-devel] [PATCH v1 1/4] asm-x86/monitor: Enable svm monitor events

2018-02-02 Thread Tamas K Lengyel
On Fri, Feb 2, 2018 at 2:37 AM, Alexandru Isaila wrote: > This commit separates the svm caps from the vmx caps. > > Signed-off-by: Alexandru Isaila > --- > xen/include/asm-x86/monitor.h | 33 - > 1 file changed,

Re: [Xen-devel] [PATCH V3] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-02 Thread Tamas K Lengyel
so that no flushes occur when > the bit was set. > > Signed-off-by: Razvan Cojocaru <rcojoc...@bitdefender.com> > Reported-by: Bitweasil <bitwea...@cryptohaze.com> > Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> Acked-by: Tamas K Lengyel <ta...@tklengyel.co

Re: [Xen-devel] [PATCH V2] tests/xen-access: disable CR4 write events on application exit

2018-02-01 Thread Tamas K Lengyel
d-off-by: Razvan Cojocaru <rcojoc...@bitdefender.com> Acked-by: Tamas K Lengyel <ta...@tklengyel.com> >> >> --- >> Changes since V1: >> - Made all the ignored parameters of xc_monitor_write_ctrlreg() zeroes. >> --- >> tools/tests/xen-access/xen-access.c | 2

Re: [Xen-devel] [PATCH V2 2/2] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-01-31 Thread Tamas K Lengyel
On Wed, Jan 31, 2018 at 11:44 AM, Tamas K Lengyel <ta...@tklengyel.com> wrote: > " > > On Tue, Jan 30, 2018 at 2:16 AM, Razvan Cojocaru > <rcojoc...@bitdefender.com> wrote: >> The emulation layers of Xen lack PCID support, and as we only offer >> PCID to

Re: [Xen-devel] [PATCH v2 4/4] hvm/svm: Enable CR events

2018-02-08 Thread Tamas K Lengyel
On Thu, Feb 8, 2018 at 8:25 AM, Alexandru Isaila wrote: > This commit enables controlregister events for svm. So this patch enables the event to trigger but where is it being handled and forwarded to the monitor ring? > > Signed-off-by: Alexandru Isaila

Re: [Xen-devel] [PATCH v2 4/4] hvm/svm: Enable CR events

2018-02-09 Thread Tamas K Lengyel
On Thu, Feb 8, 2018 at 8:25 AM, Alexandru Isaila <aisa...@bitdefender.com> wrote: > This commit enables controlregister events for svm. > > Signed-off-by: Alexandru Isaila <aisa...@bitdefender.com> Acked-by: Tamas K Lengyel <ta...@tklengyel.com> > --- > x

Re: [Xen-devel] [PATCH v2 4/4] hvm/svm: Enable CR events

2018-02-09 Thread Tamas K Lengyel
On Fri, Feb 9, 2018 at 6:10 AM, Alexandru Stefan ISAILA <aisa...@bitdefender.com> wrote: > On Jo, 2018-02-08 at 11:06 -0700, Tamas K Lengyel wrote: >> On Thu, Feb 8, 2018 at 8:25 AM, Alexandru Isaila >> <aisa...@bitdefender.com> wrote: >> > >> > This

Re: [Xen-devel] [PATCH v3 2/4] hvm/svm: Enable Breakpoint events

2018-02-12 Thread Tamas K Lengyel
On Mon, Feb 12, 2018 at 8:54 AM, Andrew Cooper wrote: > On 12/02/18 15:08, Alexandru Isaila wrote: >> @@ -2619,14 +2634,31 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) >> break; >> >> case VMEXIT_EXCEPTION_BP: >> -if (

Re: [Xen-devel] [PATCH V4] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-14 Thread Tamas K Lengyel
so that no flushes occur when > the bit was set. > > Signed-off-by: Razvan Cojocaru <rcojoc...@bitdefender.com> > Reported-by: Bitweasil <bitwea...@cryptohaze.com> > Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> Acked-by: Tamas K Lengyel <ta...@tklengyel.

Re: [Xen-devel] [PATCH v3 1/4] asm-x86/monitor: Fix monitor capability reporting on SVM systems

2018-02-14 Thread Tamas K Lengyel
rom Tamas or Razvan, but there is no >> comment so far that I can find. > > I think Tamas probably wouldn't object, so FWIW: > > Acked-by: Razvan Cojocaru <rcojoc...@bitdefender.com> Yes, this looks fine to me too: Acked-by: Tamas K Lengyel <ta...@tklengyel.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 2/4] hvm/svm: Enable Breakpoint events

2018-02-08 Thread Tamas K Lengyel
On Thu, Feb 8, 2018 at 8:25 AM, Alexandru Isaila wrote: > This commit enables the breakpoint events for svm. > > Signed-off-by: Alexandru Isaila > > --- > Changes since V1: > - Clean up bool_t > - Removed event.insn_len = 0 >

Re: [Xen-devel] [PATCH v2 3/4] hvm/svm: Enable MSR events

2018-02-08 Thread Tamas K Lengyel
On Thu, Feb 8, 2018 at 8:25 AM, Alexandru Isaila <aisa...@bitdefender.com> wrote: > This commit enables MSR events for svm. > > Signed-off-by: Alexandru Isaila <aisa...@bitdefender.com> Acked-by: Tamas K Lengyel <ta...@tklengyel.com> > --- > xen/arch/x86/hvm/

Re: [Xen-devel] [PATCH v1 2/2] hvm/svm: Implement CPUID events

2018-02-19 Thread Tamas K Lengyel
On Mon, Feb 19, 2018 at 6:07 AM, Alexandru Isaila wrote: > At this moment the CPUID events for the AMD architecture are not > forwarded to the monitor layer. > > This patch adds the CPUID event to the common capabilities and then > forwards the event to the monitor layer.

Re: [Xen-devel] [PATCH v1 2/2] hvm/svm: Implement CPUID events

2018-02-20 Thread Tamas K Lengyel
On Tue, Feb 20, 2018 at 3:37 AM, Alexandru Stefan ISAILA <aisa...@bitdefender.com> wrote: > On Lu, 2018-02-19 at 08:25 -0700, Tamas K Lengyel wrote: >> On Mon, Feb 19, 2018 at 6:07 AM, Alexandru Isaila >> <aisa...@bitdefender.com> wrote: >> > >> >

Re: [Xen-devel] [PATCH v3] hvm/svm: Implement CPUID events

2018-02-23 Thread Tamas K Lengyel
to the monitor layer. > > --- > Changes since V2: > - Pass the inst_len to svm_vmexit_do_cpuid() > > Signed-off-by: Alexandru Isaila <aisa...@bitdefender.com> Acked-by: Tamas K Lengyel <ta...@tklengyel.com> > --- > xen/arch/x86/hvm/svm/svm.c

Re: [Xen-devel] [PATCH v2] x86/mm: Suppresses vm_events caused by page-walks

2018-02-23 Thread Tamas K Lengyel
On Mon, Jan 8, 2018 at 5:49 AM, Alexandru Isaila wrote: > This patch is adding a way to enable/disable nested pagefault > events. It introduces the xc_monitor_nested_pagefault function > and adds the nested_pagefault_disabled in the monitor structure. > This is needed by

Re: [Xen-devel] [PATCH v2] x86/mm: Suppresses vm_events caused by page-walks

2018-02-23 Thread Tamas K Lengyel
On Fri, Feb 23, 2018 at 3:25 PM, Razvan Cojocaru <rcojoc...@bitdefender.com> wrote: > On 02/24/2018 12:06 AM, Tamas K Lengyel wrote: >> On Mon, Jan 8, 2018 at 5:49 AM, Alexandru Isaila >> <aisa...@bitdefender.com> wrote: >>> This patch is adding a way to enable

[Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-02 Thread Tamas K Lengyel
in this patch we make Xen properly parse this buffer, thus making it possible to have separate EFI boot options present for the different config sections. Signed-off-by: Tamas K Lengyel <lengy...@ainfosec.com> --- Cc: Jan Beulich <jbeul...@suse.com> Cc: ope...@googlegroups.com --- xe

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-03 Thread Tamas K Lengyel
On Wed, Jan 3, 2018 at 9:36 AM, Jan Beulich wrote: On 03.01.18 at 17:04, wrote: >> On Wed, Jan 3, 2018 at 4:20 AM, Jan Beulich wrote: >> On 02.01.18 at 16:56, wrote: +if ( elo->Attributes &

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-03 Thread Tamas K Lengyel
On Wed, Jan 3, 2018 at 4:20 AM, Jan Beulich wrote: On 02.01.18 at 16:56, wrote: >> When booting Xen via UEFI the Xen config file can contain multiple sections >> each describing different boot options. It is currently only possible to >> choose >>

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Tamas K Lengyel
On Thu, Jan 4, 2018 at 3:43 AM, Jan Beulich wrote: On 03.01.18 at 17:53, wrote: >> On Wed, Jan 3, 2018 at 9:36 AM, Jan Beulich wrote: >> On 03.01.18 at 17:04, wrote: On Wed, Jan 3, 2018 at 4:20 AM,

Re: [Xen-devel] [PATCH v2] hvm/altp2m: Clarify the proper way to extend the altp2m interface

2018-07-26 Thread Tamas K Lengyel
t, C3 has been seen as the best solution in discussion. > > Signed-off-by: George Dunlap > --- > Changes since v1: > - Patch description: clarify that HVM guest can't make domctls > - No blacklist for the 'internal' use case; instead document its risk > - Move more of the di

Re: [Xen-devel] [PATCH] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-07-31 Thread Tamas K Lengyel
On Tue, Jul 31, 2018 at 5:53 AM Jan Beulich wrote: > > >>> On 25.07.18 at 13:49, wrote: > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > @@ -4467,6 +4467,30 @@ static int hvmop_get_param( > > return rc; > > } > > > > +/* > > + * Find the struct vcpu given a dom_id and

Re: [Xen-devel] [PATCH v3 0/4] x86/iommu: PVH Dom0 workarounds for missing RMRR entries

2018-08-14 Thread Tamas K Lengyel
On Wed, Aug 8, 2018 at 3:54 AM Jan Beulich wrote: > > >>> On 08.08.18 at 10:25, wrote: > > On Tue, Aug 07, 2018 at 10:45:32AM -0600, Tamas K Lengyel wrote: > >> On Tue, Aug 7, 2018 at 10:04 AM Tamas K Lengyel > >> wrote: > >> (XEN) [VT-D]iommu.c:9

Re: [Xen-devel] [PATCH v3 0/4] x86/iommu: PVH Dom0 workarounds for missing RMRR entries

2018-08-16 Thread Tamas K Lengyel
On Wed, Aug 15, 2018 at 12:40 AM Jan Beulich wrote: > > >>> On 15.08.18 at 03:00, wrote: > > On Wed, Aug 8, 2018 at 3:54 AM Jan Beulich wrote: > >> > >> >>> On 08.08.18 at 10:25, wrote: > >> > On Tue, Aug 07, 2018 at 10:45:32AM -0600,

Re: [Xen-devel] [PATCH v3 0/4] x86/iommu: PVH Dom0 workarounds for missing RMRR entries

2018-08-07 Thread Tamas K Lengyel
On Tue, Aug 7, 2018 at 9:09 AM Roger Pau Monné wrote: > > On Tue, Aug 07, 2018 at 08:45:07AM -0600, Tamas K Lengyel wrote: > > On Tue, Aug 7, 2018 at 8:37 AM Roger Pau Monné wrote: > > > > > > On Tue, Aug 07, 2018 at 08:29:49AM -0600, Tamas K Lengyel wrote: > >

Re: [Xen-devel] [PATCH v3 0/4] x86/iommu: PVH Dom0 workarounds for missing RMRR entries

2018-08-07 Thread Tamas K Lengyel
On Tue, Aug 7, 2018 at 8:04 AM Roger Pau Monne wrote: > > Hello, > > The following series implement a workaround for missing RMRR > entries for a PVH Dom0. It's based on the iommu_inclusive_mapping VTd > option. > > The PVH workaround identity maps all regions marked as reserved in the > memory

Re: [Xen-devel] [PATCH v3 0/4] x86/iommu: PVH Dom0 workarounds for missing RMRR entries

2018-08-07 Thread Tamas K Lengyel
On Tue, Aug 7, 2018 at 8:37 AM Roger Pau Monné wrote: > > On Tue, Aug 07, 2018 at 08:29:49AM -0600, Tamas K Lengyel wrote: > > On Tue, Aug 7, 2018 at 8:04 AM Roger Pau Monne wrote: > > > > > > Hello, > > > > > > The following series implement a wor

Re: [Xen-devel] [PATCH v3 0/4] x86/iommu: PVH Dom0 workarounds for missing RMRR entries

2018-08-07 Thread Tamas K Lengyel
On Tue, Aug 7, 2018 at 10:04 AM Tamas K Lengyel wrote: > > On Tue, Aug 7, 2018 at 9:09 AM Roger Pau Monné wrote: > > > > On Tue, Aug 07, 2018 at 08:45:07AM -0600, Tamas K Lengyel wrote: > > > On Tue, Aug 7, 2018 at 8:37 AM Roger Pau Monné > > > wrote: > &

Re: [Xen-devel] [PATCH v3 0/4] x86/iommu: PVH Dom0 workarounds for missing RMRR entries

2018-08-07 Thread Tamas K Lengyel
On Tue, Aug 7, 2018 at 10:45 AM Tamas K Lengyel wrote: > > On Tue, Aug 7, 2018 at 10:04 AM Tamas K Lengyel > wrote: > > > > On Tue, Aug 7, 2018 at 9:09 AM Roger Pau Monné wrote: > > > > > > On Tue, Aug 07, 2018 at 08:45:07AM -0600, Tamas K Lengyel wrote:

Re: [Xen-devel] [PATCH v3] x86/mm: Add mem access rights to NPT

2018-07-19 Thread Tamas K Lengyel
On Thu, Jul 19, 2018 at 2:30 AM Jan Beulich wrote: > > >>> On 19.07.18 at 10:18, wrote: > > On Mi, 2018-07-18 at 15:33 +, George Dunlap wrote: > >> > On Jul 2, 2018, at 8:42 AM, Alexandru Isaila >> > @@ -112,8 +117,37 @@ static unsigned long p2m_type_to_flags(const > >> > struct p2m_domain

Re: [Xen-devel] [PATCH v2 12/23] x86: monitor.o is currently HVM only

2018-08-29 Thread Tamas K Lengyel
On Wed, Aug 29, 2018 at 10:42 AM Wei Liu wrote: > > On Mon, Aug 27, 2018 at 09:18:29AM -0600, Jan Beulich wrote: > > >>> On 26.08.18 at 14:19, wrote: > > > There has been plan to make PV work, but it is not yet there. Provide > > > stubs to make it build with !CONFIG_HVM. > > > > > >

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-04 Thread Tamas K Lengyel
On Mon, Sep 3, 2018 at 10:59 PM Adrian Pop wrote: > > In a classic HVI + Xen setup, the introspection engine would monitor > legacy guest page-tables by marking them read-only inside the EPT; this > way any modification explicitly made by the guest or implicitly made by > the CPU page walker

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-05 Thread Tamas K Lengyel
On Tue, Sep 4, 2018 at 2:58 PM Razvan Cojocaru wrote: > > On 9/4/18 11:40 PM, Tamas K Lengyel wrote: > > On Mon, Sep 3, 2018 at 10:59 PM Adrian Pop wrote: > >> > >> In a classic HVI + Xen setup, the introspection engine would monitor > >> legacy guest page-

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-05 Thread Tamas K Lengyel
On Wed, Sep 5, 2018 at 10:40 AM Razvan Cojocaru wrote: > > On 9/5/18 7:28 PM, Tamas K Lengyel wrote: > > On Tue, Sep 4, 2018 at 2:58 PM Razvan Cojocaru > > wrote: > >> > >> On 9/4/18 11:40 PM, Tamas K Lengyel wrote: > >>> O

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-05 Thread Tamas K Lengyel
On Wed, Sep 5, 2018 at 12:45 PM Andrew Cooper wrote: > > On 05/09/18 19:40, Tamas K Lengyel wrote: > > On Wed, Sep 5, 2018 at 10:40 AM Razvan Cojocaru > > wrote: > >> On 9/5/18 7:28 PM, Tamas K Lengyel wrote: > >>> On Tue, Sep 4, 2018 at 2:58 PM Razvan Coj

Re: [Xen-devel] L1TF, and future work

2018-09-10 Thread Tamas K Lengyel
On Fri, Aug 24, 2018 at 3:16 AM Dario Faggioli wrote: > > On Wed, 2018-08-15 at 14:17 +0100, Andrew Cooper wrote: > > Hello, > > > > Now that the embargo on XSA-273 is up, we can start publicly > > discussing > > the remaining work do, because there is plenty to do. In no > > particular > >

Re: [Xen-devel] [PATCH v3 11/16] x86/mm: put HVM only code under CONFIG_HVM

2018-09-07 Thread Tamas K Lengyel
On Tue, Sep 4, 2018, 10:29 AM Wei Liu wrote: > Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. > Put these components under CONFIG_HVM. This further requires putting > one of the vm event under CONFIG_HVM. > > Altp2m requires a bit more attention because its code is embedded

Re: [Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-07-05 Thread Tamas K Lengyel
On Thu, Jul 5, 2018 at 2:31 AM Jan Beulich wrote: > > >>> On 04.07.18 at 18:44, wrote: > > > > >> On Jul 4, 2018, at 4:38 PM, Jan Beulich wrote: > >> > > On 04.07.18 at 16:05, wrote: > On Jul 2, 2018, at 7:34 AM, Jan Beulich wrote: > >>> On 29.06.18 at 18:39, wrote: > > On

Re: [Xen-devel] [PATCH v2 1/2] x86/mem_access: Add a helper function for memaccess conversion

2018-07-05 Thread Tamas K Lengyel
On Thu, Jul 5, 2018 at 4:44 AM Adrian Pop wrote: > > The p2m_access_to_xenmem_access() converts a p2m_access_t to a > xenmem_access_t. It is complementary to xenmem_access_to_p2m_access(). > It is currently only used by _p2m_get_mem_access(). > > Signed-off-by: Adrian Pop > --- >

Re: [Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-07-05 Thread Tamas K Lengyel
On Thu, Jul 5, 2018 at 9:22 AM Razvan Cojocaru wrote: > > On 07/05/2018 05:35 PM, Tamas K Lengyel wrote: > > Jan's comment here about the too broad exposure is not without a > > point. For a security application to point in using altp2m and > > memaccess is to

Re: [Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-07-09 Thread Tamas K Lengyel
8 07:53 AM, Razvan Cojocaru wrote: > > On 07/09/2018 02:46 PM, George Dunlap wrote: > >> On 07/09/2018 12:18 PM, Razvan Cojocaru wrote: > >>> On 07/09/2018 02:04 PM, George Dunlap wrote: > >>>> On 07/06/2018 05:52 PM, Tamas K Lengyel wrote: > >>>&g

Re: [Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-07-06 Thread Tamas K Lengyel
On Fri, Jul 6, 2018 at 2:56 AM Razvan Cojocaru wrote: > > On 07/05/2018 07:45 PM, Tamas K Lengyel wrote: > > On Thu, Jul 5, 2018 at 9:22 AM Razvan Cojocaru > > wrote: > >> However, our particular application is only interested in setting (and > >> querying) pa

Re: [Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-07-04 Thread Tamas K Lengyel
On Mon, Jul 2, 2018 at 5:14 AM Razvan Cojocaru wrote: > > On 07/02/2018 09:34 AM, Jan Beulich wrote: > On 29.06.18 at 18:39, wrote: > >> On 06/29/2018 06:38 PM, Jan Beulich wrote: > >> On 28.06.18 at 15:00, wrote: > @@ -4666,6 +4667,23 @@ static int do_altp2m_op( > }

[Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-01-22 Thread Tamas K Lengyel
, and in this patch we make Xen properly parse this buffer, thus making it possible to have separate EFI boot options present for the different config sections. Signed-off-by: Tamas K Lengyel <lengy...@ainfosec.com> --- Cc: Jan Beulich <jbeul...@suse.com> Cc: ope...@googlegroups.com

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-03-12 Thread Tamas K Lengyel
Patch ping. Jan, I would like to touch base once more to see if we can get this patch included in 4.11. The patch as-is correctly tells the difference between buffers provided by both an EFI shell or by the firmware as an EFI_LOAD_OPTION. Thanks, Tamas On Wed, Feb 7, 2018 at 9:00 AM, Tamas K

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-03-13 Thread Tamas K Lengyel
On Tue, Mar 13, 2018 at 1:47 AM, Jan Beulich wrote: On 12.03.18 at 16:00, wrote: >> Patch ping. Jan, I would like to touch base once more to see if we can >> get this patch included in 4.11. The patch as-is correctly tells the >> difference between

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-11 Thread Tamas K Lengyel
On Wed, Apr 11, 2018 at 12:39 AM, Razvan Cojocaru wrote: > On 04/09/2018 05:12 PM, George Dunlap wrote: >> The obvious place to look is the logdirtyvram functionality, which is >> used to make it easier for QEMU to figure out which bits of the display >> buffer have

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-13 Thread Tamas K Lengyel
On Fri, Apr 13, 2018 at 8:44 AM, Razvan Cojocaru wrote: > On 04/11/2018 11:04 AM, Razvan Cojocaru wrote: >> Debugging continues. > > Finally, the attached patch seems to get the display unstuck in my > scenario, although for one guest I get: > > (XEN) d2v0 Unexpected

Re: [Xen-devel] Weird altp2m behaviour when switching early to a new view

2018-04-17 Thread Tamas K Lengyel
On Tue, Apr 17, 2018 at 9:13 AM, Razvan Cojocaru wrote: > On 04/17/2018 05:58 PM, George Dunlap wrote: It might be nice to have a more structured way of keeping all these changes in sync, rather than relying on this open-coding everywhere. >>> >>> Very true.

Re: [Xen-devel] [PATCH v2] hvm/svm: Implement Debug events

2018-03-20 Thread Tamas K Lengyel
On Tue, Mar 20, 2018 at 11:07 AM, Alexandru Stefan ISAILA <aisa...@bitdefender.com> wrote: > On Ma, 2018-03-20 at 10:49 -0600, Tamas K Lengyel wrote: >> On Tue, Mar 20, 2018 at 3:40 AM, Alexandru Isaila >> <aisa...@bitdefender.com> wrote: >> > >> >

Re: [Xen-devel] [PATCH v2] hvm/svm: Implement Debug events

2018-03-20 Thread Tamas K Lengyel
On Tue, Mar 20, 2018 at 3:40 AM, Alexandru Isaila wrote: > At this moment the Debug events for the AMD architecture are not > forwarded to the monitor layer. > > This patch adds the Debug event to the common capabilities, adds > the VMEXIT_ICEBP then forwards the event to

Re: [Xen-devel] Setting up a Xen x86 community call

2018-03-02 Thread Tamas K Lengyel
On Fri, Mar 2, 2018 at 8:39 AM, Lars Kurth wrote: > Hi all, > (sorry for the extensive distribution list - I went through MAINTAINERS and > people who may have an interest) > > I would like to start organizing a recurring x86 community call to discuss > and sync-up on

Re: [Xen-devel] [PATCH V3] xen/altp2m: set access_required properly for all altp2ms

2018-06-28 Thread Tamas K Lengyel
access_required to the value from the hostp2m > on altp2m init, and propagates the values received via hypercall > to all the active altp2ms, when applicable. > > Signed-off-by: Razvan Cojocaru LGTM Acked-by: Tamas K Lengyel > > --- > Cc: Stefano Stabellini > Cc:

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-28 Thread Tamas K Lengyel
On Thu, Jun 28, 2018 at 8:40 AM Jan Beulich wrote: > > >>> On 28.06.18 at 16:10, wrote: > > On Vi, 2018-06-22 at 09:51 -0600, Jan Beulich wrote: > >> > > > On 18.06.18 at 17:17, wrote: > >> > From: Isaila Alexandru > >> > > >> > This patch adds access rights for the NPT pages. The access

Re: [Xen-devel] Mapping HVM guest memory from Dom0

2018-10-11 Thread Tamas K Lengyel
On Wed, Oct 10, 2018 at 5:10 PM Andrew Cooper wrote: > > On 10/10/18 23:08, Spencer Michaels wrote: > > Interesting … sorry, I had read the docs a while ago and my > > interpretation at the time was that it didn't. I can try to get libvmi > > working, but nonetheless I do want to figure out how

Re: [Xen-devel] [PATCH 2/4] xen/arm: initialize access

2018-10-15 Thread Tamas K Lengyel
On Mon, Oct 15, 2018 at 3:57 AM Stefano Stabellini wrote: > > Initialize variable *access before returning it back to the caller. > > Signed-off-by: Stefano Stabellini > --- > xen/arch/arm/mem_access.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm/mem_access.c

Re: [Xen-devel] Fix VGA logdirty related display freezes with altp2m

2018-10-18 Thread Tamas K Lengyel
On Thu, Oct 18, 2018 at 4:09 AM Razvan Cojocaru wrote: > > Hello, > > This series aims to prevent the display from freezing when > enabling altp2m and switching to a new view (and assorted problems > when resizing the display). > > The first patch propagates ept.ad changes to all active altp2ms,

Re: [Xen-devel] [PATCH v3] arch/x86: Add registers to vm_event

2018-10-18 Thread Tamas K Lengyel
-by: Alexandru Isaila LGTM Acked-by: Tamas K Lengyel ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] Fix VGA logdirty related display freezes with altp2m

2018-10-22 Thread Tamas K Lengyel
On Thu, Oct 18, 2018 at 3:12 PM Razvan Cojocaru wrote: > > On 10/18/18 11:08 PM, Tamas K Lengyel wrote: > > On Thu, Oct 18, 2018 at 4:09 AM Razvan Cojocaru > > wrote: > >> > >> Hello, > >> > >> This series aims to prevent the display from fre

Re: [Xen-devel] Fix VGA logdirty related display freezes with altp2m

2018-10-22 Thread Tamas K Lengyel
On Mon, Oct 22, 2018 at 3:22 PM Andrew Cooper wrote: > > On 22/10/2018 22:17, Razvan Cojocaru wrote: > > On 10/22/18 11:48 PM, Tamas K Lengyel wrote: > >> On Thu, Oct 18, 2018 at 3:12 PM Razvan Cojocaru > >> wrote: > >>> On 10/18/18 11:08 PM, Tamas K

Re: [Xen-devel] Fix VGA logdirty related display freezes with altp2m

2018-10-22 Thread Tamas K Lengyel
On Mon, Oct 22, 2018 at 4:15 PM Razvan Cojocaru wrote: > > With the config fixed it boots but when I run DRAKVUF on the domain I > get the following crash: > > (XEN) [ Xen-4.12-unstable x86_64 debug=y Not tainted ] > (XEN) CPU:0 > (XEN) RIP:

Re: [Xen-devel] [RFC PATCH v1 00/16] xen: sched: implement core-scheduling

2018-10-17 Thread Tamas K Lengyel
On Fri, Aug 24, 2018 at 5:36 PM Dario Faggioli wrote: > > Hello, > > As anticipated here: > https://lists.xenproject.org/archives/html/xen-devel/2018-08/msg02052.html > > Here's a preliminary version of my work, trying to implement > core-scheduling in Xen. > > First of all, this deals with

Re: [Xen-devel] [RFC PATCH v1 00/16] xen: sched: implement core-scheduling

2018-10-18 Thread Tamas K Lengyel
On Thu, Oct 18, 2018 at 2:16 AM Dario Faggioli wrote: > > On Wed, 2018-10-17 at 15:36 -0600, Tamas K Lengyel wrote: > > On Fri, Aug 24, 2018 at 5:36 PM Dario Faggioli > > wrote: > > > > > > They give me a system that boots, where I can do basic stuff (li

Re: [Xen-devel] [PATCH 2/4] xen/arm: initialize access

2018-10-16 Thread Tamas K Lengyel
On Mon, Oct 15, 2018 at 7:14 PM Stefano Stabellini wrote: > > On Mon, 15 Oct 2018, Tamas K Lengyel wrote: > > On Mon, Oct 15, 2018 at 3:57 AM Stefano Stabellini > > wrote: > > > > > > Initialize variable *access before returning it back to the caller

Re: [Xen-devel] Ongoing/future speculative mitigation work

2018-10-24 Thread Tamas K Lengyel
> A solution to this issue was proposed, whereby Xen synchronises siblings > on vmexit/entry, so we are never executing code in two different > privilege levels. Getting this working would make it safe to continue > using hyperthreading even in the presence of L1TF. Obviously, its going > to

Re: [Xen-devel] Fix VGA logdirty related display freezes with altp2m

2018-10-24 Thread Tamas K Lengyel
On Tue, Oct 23, 2018 at 6:37 AM Razvan Cojocaru wrote: > > Tamas, could you please give this a spin? > > https://github.com/razvan-cojocaru/xen/tree/altp2m-logdirty-take2 > > It _should_ solve the crashes. Indeed, I no longer see the crash. However, there might be some locking issue present

Re: [Xen-devel] Fix VGA logdirty related display freezes with altp2m

2018-10-24 Thread Tamas K Lengyel
On Wed, Oct 24, 2018 at 11:20 AM Razvan Cojocaru wrote: > > On 10/24/18 8:09 PM, Tamas K Lengyel wrote: > > On Tue, Oct 23, 2018 at 6:37 AM Razvan Cojocaru > > wrote: > >> > >> Tamas, could you please give this a spin? > >> > >> https://git

Re: [Xen-devel] Fix VGA logdirty related display freezes with altp2m

2018-10-24 Thread Tamas K Lengyel
On Wed, Oct 24, 2018 at 11:31 AM Tamas K Lengyel wrote: > > On Wed, Oct 24, 2018 at 11:20 AM Razvan Cojocaru > wrote: > > > > On 10/24/18 8:09 PM, Tamas K Lengyel wrote: > > > On Tue, Oct 23, 2018 at 6:37 AM Razvan Cojocaru > > > wrote: > > >&

Re: [Xen-devel] Ongoing/future speculative mitigation work

2018-10-26 Thread Tamas K Lengyel
On Fri, Oct 26, 2018, 1:49 AM Dario Faggioli wrote: > On Thu, 2018-10-25 at 12:35 -0600, Tamas K Lengyel wrote: > > On Thu, Oct 25, 2018 at 12:13 PM Andrew Cooper > > wrote: > > > > > > TBH, I'd perhaps start with an admin control which lets them switch >

Re: [Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Tamas K Lengyel
On Tue, Oct 30, 2018 at 7:19 AM Jan Beulich wrote: > > >>> On 30.10.18 at 13:26, wrote: > > On 10/30/18 1:33 PM, Jan Beulich wrote: > > On 30.10.18 at 11:07, wrote: > >>> --- a/xen/include/public/vm_event.h > >>> +++ b/xen/include/public/vm_event.h > >>> @@ -29,7 +29,7 @@ > >>> > >>>

Re: [Xen-devel] Fix VGA logdirty related display freezes with altp2m

2018-10-25 Thread Tamas K Lengyel
On Thu, Oct 25, 2018 at 9:02 AM Razvan Cojocaru wrote: > > On 10/25/18 5:55 PM, Tamas K Lengyel wrote: > > On Thu, Oct 25, 2018 at 8:24 AM Razvan Cojocaru > > wrote: > >> > >> On 10/24/18 8:52 PM, Tamas K Lengyel wrote: > >>> On Wed, Oct 2

  1   2   3   4   5   6   7   8   9   10   >