Re: [Xen-devel] [PATCH 0/5] for-linux/sndif: add explicit back and front synchronization
On 04/12/2018 08:13 PM, Boris Ostrovsky wrote: On 04/12/2018 12:55 PM, Oleksandr Andrushchenko wrote: On 04/12/2018 07:55 PM, Boris Ostrovsky wrote: On 04/12/2018 12:11 PM, Oleksandr Andrushchenko wrote: Hello, Konrad, Takashi! Could you please review the *Linux Kernel* version of the changes? As I said in the cover letter below there is no functional changes comparing to the corresponding Xen version, but spaces to tabs. Still, formally, I have to drop the R-b tags and request for the new review. Is there any reason why this all can't be done in a single patch? Just to preserve the history of the changes? The history is tracked in Xen tree and since you are only updating the header file I don't think we gain much by repeating it here. makes sense This is just syncing up with the canonical definition in Xen. Do you want me to squash and resend? Yes, please. will do -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 0/5] for-linux/sndif: add explicit back and front synchronization
On 04/12/2018 12:55 PM, Oleksandr Andrushchenko wrote: > On 04/12/2018 07:55 PM, Boris Ostrovsky wrote: >> On 04/12/2018 12:11 PM, Oleksandr Andrushchenko wrote: >>> Hello, Konrad, Takashi! >>> >>> Could you please review the *Linux Kernel* version of the changes? >>> As I said in the cover letter below there is no functional changes >>> comparing to the corresponding Xen version, but spaces to tabs. >>> Still, formally, I have to drop the R-b tags and request for the new >>> review. >> Is there any reason why this all can't be done in a single patch? > Just to preserve the history of the changes? The history is tracked in Xen tree and since you are only updating the header file I don't think we gain much by repeating it here. >> This is just syncing up with the canonical definition in Xen. > Do you want me to squash and resend? Yes, please. -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 0/5] for-linux/sndif: add explicit back and front synchronization
On 04/12/2018 07:55 PM, Boris Ostrovsky wrote: On 04/12/2018 12:11 PM, Oleksandr Andrushchenko wrote: Hello, Konrad, Takashi! Could you please review the *Linux Kernel* version of the changes? As I said in the cover letter below there is no functional changes comparing to the corresponding Xen version, but spaces to tabs. Still, formally, I have to drop the R-b tags and request for the new review. Is there any reason why this all can't be done in a single patch? Just to preserve the history of the changes? This is just syncing up with the canonical definition in Xen. Do you want me to squash and resend? -boris Thank you, Oleksandr ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 0/5] for-linux/sndif: add explicit back and front synchronization
On 04/12/2018 12:11 PM, Oleksandr Andrushchenko wrote: > Hello, Konrad, Takashi! > > Could you please review the *Linux Kernel* version of the changes? > As I said in the cover letter below there is no functional changes > comparing to the corresponding Xen version, but spaces to tabs. > Still, formally, I have to drop the R-b tags and request for the new > review. Is there any reason why this all can't be done in a single patch? This is just syncing up with the canonical definition in Xen. -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 0/5] for-linux/sndif: add explicit back and front synchronization
Hello, Konrad, Takashi! Could you please review the *Linux Kernel* version of the changes? As I said in the cover letter below there is no functional changes comparing to the corresponding Xen version, but spaces to tabs. Still, formally, I have to drop the R-b tags and request for the new review. Thank you, Oleksandr P.S. Minus GlobalLogic e-mails which bounce On 04/12/2018 07:00 PM, Oleksandr Andrushchenko wrote: Hello, all! This is the syncup version of the sound protocol changes for Linux Kernel with the only difference from the corresponding Xen version being spaces to tabs conversion. Regradless of this only change I have dropped R-b tags received for Xen version. In order to provide explicit synchronization between backend and frontend the following changes are introduced in the protocol: - bump protocol version to 2 - add new ring buffer for sending asynchronous events from backend to frontend to report number of bytes played by the frontend (XENSND_EVT_CUR_POS) - introduce trigger events for playback control: start/stop/pause/resume - add "req-" prefix to event-channel and ring-ref to unify naming of the Xen event channels for requests and events - add XENSND_OP_HW_PARAM_QUERY request to read/update stream configuration space: request passes desired intervals/formats for the stream parameters and the response returns allowed intervals and formats mask that can be used. - MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets - Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all parameters at once, allowing to check all the configuration space. - Minor documentation cleanup (added missed "reserved" fields) Oleksandr Andrushchenko (5): xen/sndif: Introduce protocol version xen/sndif: Fix missed "reserved" fields in comments xen/sndif: Make requests and responses 64 octets long xen/sndif: Add explicit back and front synchronization xen/sndif: Add explicit back and front parameter negotiation include/xen/interface/io/sndif.h | 322 +-- 1 file changed, 306 insertions(+), 16 deletions(-) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [PATCH 0/5] for-linux/sndif: add explicit back and front synchronization
Hello, all! This is the syncup version of the sound protocol changes for Linux Kernel with the only difference from the corresponding Xen version being spaces to tabs conversion. Regradless of this only change I have dropped R-b tags received for Xen version. In order to provide explicit synchronization between backend and frontend the following changes are introduced in the protocol: - bump protocol version to 2 - add new ring buffer for sending asynchronous events from backend to frontend to report number of bytes played by the frontend (XENSND_EVT_CUR_POS) - introduce trigger events for playback control: start/stop/pause/resume - add "req-" prefix to event-channel and ring-ref to unify naming of the Xen event channels for requests and events - add XENSND_OP_HW_PARAM_QUERY request to read/update stream configuration space: request passes desired intervals/formats for the stream parameters and the response returns allowed intervals and formats mask that can be used. - MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets - Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all parameters at once, allowing to check all the configuration space. - Minor documentation cleanup (added missed "reserved" fields) Oleksandr Andrushchenko (5): xen/sndif: Introduce protocol version xen/sndif: Fix missed "reserved" fields in comments xen/sndif: Make requests and responses 64 octets long xen/sndif: Add explicit back and front synchronization xen/sndif: Add explicit back and front parameter negotiation include/xen/interface/io/sndif.h | 322 +-- 1 file changed, 306 insertions(+), 16 deletions(-) -- 2.17.0 ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
