Re: [Xen-devel] [PATCH 1/2] dmar: iommu mem leak fix

[Jan Beulich]

>>> On 20.08.18 at 05:32,  wrote:
> Release memory allocated for drhd iommu in error path.
> 
> Signed-off-by: Zhenzhong Duan 

Reviewed-by: Jan Beulich 

But this needs a maintainer ack, and you didn't Cc him (now done).

Jan

> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -100,6 +100,7 @@ static void __init disable_all_dmar_units(void)
>  {
>  list_del(>list);
>  scope_devices_free(>scope);
> +iommu_free(drhd->iommu);
>  xfree(drhd);
>  }
>  list_for_each_entry_safe ( rmrr, _rmrr, _rmrr_units, list )
> -- 
> 1.7.3





___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 1/2] dmar: iommu mem leak fix

[Zhenzhong Duan]

Release memory allocated for drhd iommu in error path.

Signed-off-by: Zhenzhong Duan 
---
 xen/drivers/passthrough/vtd/dmar.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/xen/drivers/passthrough/vtd/dmar.c 
b/xen/drivers/passthrough/vtd/dmar.c
index 46decd4..8c5fa80 100644
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -100,6 +100,7 @@ static void __init disable_all_dmar_units(void)
 {
 list_del(>list);
 scope_devices_free(>scope);
+iommu_free(drhd->iommu);
 xfree(drhd);
 }
 list_for_each_entry_safe ( rmrr, _rmrr, _rmrr_units, list )
-- 
1.7.3

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel