Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Igor Druzhinin
On 13/11/2018 10:27, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 November 2018 10:14 >> To: xen-devel >> Cc: Andrew Cooper ; Paul Durrant >> ; Wei Liu >> Subject: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to >>

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2018 11:15 > To: Andrew Cooper ; Paul Durrant > > Cc: Wei Liu ; xen-devel de...@lists.xenproject.org> > Subject: Re: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to > p2m_ioreq_server pages > >

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 12:08, wrote: > On 13/11/2018 10:53, Paul Durrant wrote: >>> -Original Message- >>> From: Andrew Cooper >>> Sent: 13 November 2018 10:47 >>> To: Jan Beulich ; xen-devel >> de...@lists.xenproject.org> >>> Cc: Paul Durrant ; Wei Liu >>> Subject: Re: [PATCH 1/3] x86/HVM:

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Andrew Cooper
On 13/11/2018 10:53, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper >> Sent: 13 November 2018 10:47 >> To: Jan Beulich ; xen-devel > de...@lists.xenproject.org> >> Cc: Paul Durrant ; Wei Liu >> Subject: Re: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to >>

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 13 November 2018 10:47 > To: Jan Beulich ; xen-devel de...@lists.xenproject.org> > Cc: Paul Durrant ; Wei Liu > Subject: Re: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to > p2m_ioreq_server pages > > On 13/11/18 10:13, Jan

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 11:47, wrote: > On 13/11/18 10:13, Jan Beulich wrote: >> Commit 3bdec530a5 ("x86/HVM: split page straddling emulated accesses in >> more cases") introduced a hvm_copy_to_guest_linear() attempt before >> falling back to hvmemul_linear_mmio_write(). This is wrong for the >>

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Andrew Cooper
On 13/11/18 10:13, Jan Beulich wrote: > Commit 3bdec530a5 ("x86/HVM: split page straddling emulated accesses in > more cases") introduced a hvm_copy_to_guest_linear() attempt before > falling back to hvmemul_linear_mmio_write(). This is wrong for the > p2m_ioreq_server special case. That change

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2018 10:14 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > ; Wei Liu > Subject: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to > p2m_ioreq_server pages > > Commit 3bdec530a5 ("x86/HVM:

[Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Jan Beulich
Commit 3bdec530a5 ("x86/HVM: split page straddling emulated accesses in more cases") introduced a hvm_copy_to_guest_linear() attempt before falling back to hvmemul_linear_mmio_write(). This is wrong for the p2m_ioreq_server special case. That change widened a pre-existing issue though: Other