Re: [Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-14 Thread Jan Beulich
>>> On 12.02.18 at 12:23, wrote: > --- a/xen/arch/x86/x86_64/compat/entry.S > +++ b/xen/arch/x86/x86_64/compat/entry.S > @@ -109,13 +109,10 @@ ENTRY(compat_restore_all_guest) > ASSERT_INTERRUPTS_DISABLED > mov

Re: [Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-13 Thread Jan Beulich
>>> On 13.02.18 at 11:07, wrote: > On 13/02/2018 09:56, Jan Beulich wrote: > On 12.02.18 at 13:30, wrote: >>> On Mon, Feb 12, 2018 at 11:23:04AM +, Andrew Cooper wrote: diff --git a/xen/arch/x86/x86_64/entry.S

Re: [Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-13 Thread Andrew Cooper
On 13/02/2018 09:56, Jan Beulich wrote: On 12.02.18 at 13:30, wrote: >> On Mon, Feb 12, 2018 at 11:23:04AM +, Andrew Cooper wrote: >>> diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S >>> index 58f652d..bd3819a 100644 >>> ---

Re: [Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-13 Thread Jan Beulich
>>> On 12.02.18 at 13:30, wrote: > On Mon, Feb 12, 2018 at 11:23:04AM +, Andrew Cooper wrote: >> diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S >> index 58f652d..bd3819a 100644 >> --- a/xen/arch/x86/x86_64/entry.S >> +++

Re: [Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-12 Thread Roger Pau Monné
On Mon, Feb 12, 2018 at 11:23:04AM +, Andrew Cooper wrote: > With future changes, altinstruction_entry is going to become more complicated > to use. Furthermore, there are already ALTERNATIVE* macros which can be used > to avoid opencoding the creation of replacement information. > > For

Re: [Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-12 Thread Wei Liu
On Mon, Feb 12, 2018 at 11:23:04AM +, Andrew Cooper wrote: > With future changes, altinstruction_entry is going to become more complicated > to use. Furthermore, there are already ALTERNATIVE* macros which can be used > to avoid opencoding the creation of replacement information. > > For

Re: [Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-12 Thread Andrew Cooper
On 12/02/18 12:30, Wei Liu wrote: > On Mon, Feb 12, 2018 at 11:23:04AM +, Andrew Cooper wrote: >> diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S >> index 58f652d..bd3819a 100644 >> --- a/xen/arch/x86/x86_64/entry.S >> +++ b/xen/arch/x86/x86_64/entry.S >> @@ -557,23

Re: [Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-12 Thread Wei Liu
On Mon, Feb 12, 2018 at 11:23:04AM +, Andrew Cooper wrote: > diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S > index 58f652d..bd3819a 100644 > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -557,23 +557,9 @@ handle_exception_saved: >

[Xen-devel] [PATCH 4/7] x86/asm: Remove opencoded uses of altinstruction_entry

2018-02-12 Thread Andrew Cooper
With future changes, altinstruction_entry is going to become more complicated to use. Furthermore, there are already ALTERNATIVE* macros which can be used to avoid opencoding the creation of replacement information. For ASM_STAC, ASM_CLAC and CR4_PV32_RESTORE, this means the removal of all