Re: [Xen-devel] [PATCH v2 2/4] xen/arm: initialize access
On 17/10/2018 15:31, Stefano Stabellini wrote: Initialize variable *access before returning it back to the caller. It makes the code a bit nicer and it is a safety certification requirement. Same as previous patch. Signed-off-by: Stefano Stabellini CC: rcojoc...@bitdefender.com CC: Tamas K Lengyel --- Changes in v2: - improve comment - use p2m->default_access --- xen/arch/arm/mem_access.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c index ba4ec78..86f0882 100644 --- a/xen/arch/arm/mem_access.c +++ b/xen/arch/arm/mem_access.c @@ -47,6 +47,7 @@ static int __p2m_get_mem_access(struct domain *d, gfn_t gfn, }; ASSERT(p2m_is_locked(p2m)); +*access = p2m->default_access; /* If no setting was ever set, just return rwx. */ if ( !p2m->mem_access_enabled ) -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v2 2/4] xen/arm: initialize access
On 10/17/18 5:31 PM, Stefano Stabellini wrote: > Initialize variable *access before returning it back to the caller. > It makes the code a bit nicer and it is a safety certification > requirement. > > Signed-off-by: Stefano Stabellini > CC: rcojoc...@bitdefender.com > CC: Tamas K Lengyel Acked-by: Razvan Cojocaru Thanks, Razvan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [PATCH v2 2/4] xen/arm: initialize access
Initialize variable *access before returning it back to the caller. It makes the code a bit nicer and it is a safety certification requirement. Signed-off-by: Stefano Stabellini CC: rcojoc...@bitdefender.com CC: Tamas K Lengyel --- Changes in v2: - improve comment - use p2m->default_access --- xen/arch/arm/mem_access.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c index ba4ec78..86f0882 100644 --- a/xen/arch/arm/mem_access.c +++ b/xen/arch/arm/mem_access.c @@ -47,6 +47,7 @@ static int __p2m_get_mem_access(struct domain *d, gfn_t gfn, }; ASSERT(p2m_is_locked(p2m)); +*access = p2m->default_access; /* If no setting was ever set, just return rwx. */ if ( !p2m->mem_access_enabled ) -- 1.9.1 ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
