Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Paul Semel
On 02/23/2018 05:30 PM, Wei Liu wrote: On Fri, Feb 23, 2018 at 12:57:26AM +0100, Paul Semel wrote: The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array to be filled. This is not needed for the fuzzer t

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Wei Liu
On Fri, Feb 23, 2018 at 04:33:18PM +, George Dunlap wrote: > On 02/23/2018 04:30 PM, Wei Liu wrote: > > On Fri, Feb 23, 2018 at 12:57:26AM +0100, Paul Semel wrote: > >> The minimum size for the input size was set to DATA_OFFSET + 1 which was > >> meaning > >> that we were requesting at least o

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread George Dunlap
On 02/23/2018 04:30 PM, Wei Liu wrote: > On Fri, Feb 23, 2018 at 12:57:26AM +0100, Paul Semel wrote: >> The minimum size for the input size was set to DATA_OFFSET + 1 which was >> meaning >> that we were requesting at least one character of the data array to be >> filled. >> This is not needed fo

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Wei Liu
On Fri, Feb 23, 2018 at 12:57:26AM +0100, Paul Semel wrote: > The minimum size for the input size was set to DATA_OFFSET + 1 which was > meaning > that we were requesting at least one character of the data array to be filled. > This is not needed for the fuzzer to get working correctly. Sorry, I

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Paul Semel
On 02/23/2018 11:44 AM, George Dunlap wrote: Paul, thanks for reporting this! A couple of comments... On 02/22/2018 11:57 PM, Paul Semel wrote: The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array to

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread George Dunlap
Paul, thanks for reporting this! A couple of comments... On 02/22/2018 11:57 PM, Paul Semel wrote: > The minimum size for the input size was set to DATA_OFFSET + 1 which was > meaning > that we were requesting at least one character of the data array to be filled. > This is not needed for the fu

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Paul Semel
On 02/23/2018 12:57 AM, Paul Semel wrote: The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array to be filled. This is not needed for the fuzzer to get working correctly. The maximum size for the input s

[Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-22 Thread Paul Semel
The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array to be filled. This is not needed for the fuzzer to get working correctly. The maximum size for the input size was set to INPUT_SIZE, which is actually t