Re: [PATCH v4 07/10] vpci: Refactor vpci_remove_register to remove matched registers
On Mon, May 19, 2025 at 08:30:22AM +0200, Jan Beulich wrote: > On 09.05.2025 11:05, Jiqian Chen wrote: > > vpci_remove_register() only supports removing a register in a time, > > but the follow-on changes need to remove all registers within a range. > > So, refactor it to support removing all matched registers in a calling > > time. > > Generally I'm a little wary of changing behavior for existing callers, > but I guess Roger already did signal he's okay taking that route? The only users of that function currently are in tools/tests/vpci/, so changing is not a problem IMO. Regards, Roger.
Re: [PATCH v4 07/10] vpci: Refactor vpci_remove_register to remove matched registers
On 09.05.2025 11:05, Jiqian Chen wrote: > vpci_remove_register() only supports removing a register in a time, > but the follow-on changes need to remove all registers within a range. > So, refactor it to support removing all matched registers in a calling > time. Generally I'm a little wary of changing behavior for existing callers, but I guess Roger already did signal he's okay taking that route? Jan
Re: [PATCH v4 07/10] vpci: Refactor vpci_remove_register to remove matched registers
On 2025/5/19 14:30, Jan Beulich wrote: > On 09.05.2025 11:05, Jiqian Chen wrote: >> vpci_remove_register() only supports removing a register in a time, >> but the follow-on changes need to remove all registers within a range. >> So, refactor it to support removing all matched registers in a calling >> time. > > Generally I'm a little wary of changing behavior for existing callers, > but I guess Roger already did signal he's okay taking that route? Yes, this is suggested by Roger. vpci_remove_register() is just used for test without my series. > > Jan -- Best regards, Jiqian Chen.
